View GitHub Repository server

Schedule Inspection
Subscribe
Completed
Pull Request — master (#840)
by Julius
11:43
created
Status
Category
Toggle Patches
apps/theming/lib/Controller/IconController.php 2 patches
Unused Use Statements   -2 removed lines patch added patch discarded remove patch 
@@ -22,7 +22,6 @@  discard block
 
 block discarded – undo
22 22 
  */
23 23 
 namespace OCA\Theming\Controller;
24 24
25 
-use OCA\Theming\Template;
26 25 
 use OCA\Theming\ThemingDefaults;
27 26 
 use OCP\AppFramework\Controller;
28 27 
 use OCP\AppFramework\Http;
 
@@ -35,7 +34,6 @@  discard block
 
 block discarded – undo
35 34 
 use OCP\IL10N;
36 35 
 use OCP\IRequest;
37 36 
 use OCA\Theming\Util;
38 
-use OCP\IURLGenerator;
39 37 
 use Imagick;
40 38 
 use ImagickPixel;
41 39
Please login to merge, or discard this patch.
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -92,7 +92,7 @@  discard block
 
 block discarded – undo
92 92 
 	 *
93 93 
 	 * @param $app app name
94 94 
 	 * @param $image image file name
95 
-	 * @return StreamResponse|DataResponse
95 
+	 * @return DataDisplayResponse
96 96 
 	 */
97 97 
 	public function getThemedIcon($app, $image) {
98 98 
 		$image = $this->util->getAppImage($app, $image);
 
@@ -113,7 +113,7 @@  discard block
 
 block discarded – undo
113 113 
 	 * @NoCSRFRequired
114 114 
 	 *
115 115 
 	 * @param $app app name
116 
-	 * @return StreamResponse|DataResponse
116 
+	 * @return DataDisplayResponse
117 117 
 	 */
118 118 
 	public function getFavicon($app="core") {
119 119 
 		$icon = $this->renderAppIcon($app);
 
@@ -133,7 +133,7 @@  discard block
 
 block discarded – undo
133 133 
 	 * @NoCSRFRequired
134 134 
 	 *
135 135 
 	 * @param $app app name
136 
-	 * @return StreamResponse|DataResponse
136 
+	 * @return DataDisplayResponse
137 137 
 	 */
138 138 
 	public function getTouchIcon($app="core") {
139 139 
 		$icon = $this->renderAppIcon($app);
 
@@ -149,7 +149,7 @@  discard block
 
 block discarded – undo
149 149 
 	 * Render app icon on themed background color
150 150 
 	 * fallback to logo
151 151 
 	 *
152 
-	 * @param $app app name
152 
+	 * @param string $app app name
153 153 
 	 * @return Imagick
154 154 
 	 */
155 155 
 	private function renderAppIcon($app) {
Please login to merge, or discard this patch.
apps/theming/lib/Util.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -52,7 +52,7 @@  discard block
 
 block discarded – undo
52 52 
 	/**
53 53 
 	 * get color for on-page elements:
54 54 
 	 * theme color by default, grey if theme color is to bright
55 
-	 * @param $color
55 
+	 * @param string $color
56 56 
 	 * @return string
57 57 
 	 */
58 58 
 	public function elementColor($color) {
 
@@ -83,7 +83,7 @@  discard block
 
 block discarded – undo
83 83 
 	}
84 84
85 85 
 	/**
86 
-	 * @param $color
86 
+	 * @param string $color
87 87 
 	 * @return string base64 encoded radio button svg
88 88 
 	 */
89 89 
 	public function generateRadioButton($color) {
 
@@ -156,8 +156,8 @@  discard block
 
 block discarded – undo
156 156 
 	/**
157 157 
 	 * replace default color with a custom one
158 158 
 	 *
159 
-	 * @param $svg content of a svg file
160 
-	 * @param $color color to match
159 
+	 * @param string $svg content of a svg file
160 
+	 * @param string $color color to match
161 161 
 	 * @return string
162 162 
 	 */
163 163 
 	public function colorizeSvg($svg, $color) {
Please login to merge, or discard this patch.