Completed
Pull Request — master (#1194)
by Robin
46:18 queued 35:09
created
apps/dav/lib/CalDAV/CalDavBackend.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -132,6 +132,9 @@  discard block
 block discarded – undo
132 132
 		$this->sharingBackend = new Backend($this->db, $principalBackend, 'calendar');
133 133
 	}
134 134
 
135
+	/**
136
+	 * @param string $principalUri
137
+	 */
135 138
 	public function getCalendarsForUserCount($principalUri, $excludeBirthday = true) {
136 139
 		$principalUri = $this->convertPrincipal($principalUri, true);
137 140
 		$query = $this->db->getQueryBuilder();
@@ -1105,7 +1108,7 @@  discard block
 block discarded – undo
1105 1108
 	 * @param string $principalUri
1106 1109
 	 * @param string $uri
1107 1110
 	 * @param array $properties
1108
-	 * @return mixed
1111
+	 * @return integer
1109 1112
 	 */
1110 1113
 	function createSubscription($principalUri, $uri, array $properties) {
1111 1114
 
@@ -1464,6 +1467,9 @@  discard block
 block discarded – undo
1464 1467
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
1465 1468
 	}
1466 1469
 
1470
+	/**
1471
+	 * @param boolean $toV2
1472
+	 */
1467 1473
 	private function convertPrincipal($principalUri, $toV2) {
1468 1474
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1469 1475
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/CardDavBackend.php 1 patch
Doc Comments   +10 added lines, -2 removed lines patch added patch discarded remove patch
@@ -98,6 +98,9 @@  discard block
 block discarded – undo
98 98
 		$this->sharingBackend = new Backend($this->db, $principalBackend, 'addressbook');
99 99
 	}
100 100
 
101
+	/**
102
+	 * @param string $principalUri
103
+	 */
101 104
 	public function getAddressBooksForUserCount($principalUri) {
102 105
 		$principalUri = $this->convertPrincipal($principalUri, true);
103 106
 		$query = $this->db->getQueryBuilder();
@@ -228,7 +231,8 @@  discard block
 block discarded – undo
228 231
 	}
229 232
 
230 233
 	/**
231
-	 * @param $addressBookUri
234
+	 * @param string $addressBookUri
235
+	 * @param string $principal
232 236
 	 * @return array|null
233 237
 	 */
234 238
 	public function getAddressBooksByUri($principal, $addressBookUri) {
@@ -910,6 +914,7 @@  discard block
 block discarded – undo
910 914
 	 *   * readOnly - boolean
911 915
 	 *   * summary - Optional, a description for the share
912 916
 	 *
917
+	 * @param integer $addressBookId
913 918
 	 * @return array
914 919
 	 */
915 920
 	public function getShares($addressBookId) {
@@ -1009,7 +1014,7 @@  discard block
 block discarded – undo
1009 1014
 
1010 1015
 	/**
1011 1016
 	 * For shared address books the sharee is set in the ACL of the address book
1012
-	 * @param $addressBookId
1017
+	 * @param integer $addressBookId
1013 1018
 	 * @param $acl
1014 1019
 	 * @return array
1015 1020
 	 */
@@ -1017,6 +1022,9 @@  discard block
 block discarded – undo
1017 1022
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
1018 1023
 	}
1019 1024
 
1025
+	/**
1026
+	 * @param boolean $toV2
1027
+	 */
1020 1028
 	private function convertPrincipal($principalUri, $toV2) {
1021 1029
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1022 1030
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.
apps/dav/lib/HookManager.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,6 @@
 block discarded – undo
21 21
  */
22 22
 namespace OCA\DAV;
23 23
 
24
-use OCA\DAV\CalDAV\BirthdayService;
25 24
 use OCA\DAV\CalDAV\CalDavBackend;
26 25
 use OCA\DAV\CardDAV\CardDavBackend;
27 26
 use OCA\DAV\CardDAV\SyncService;
Please login to merge, or discard this patch.