nextcloud / server

apps/dav/tests/unit/Connector/Sabre/FilesPluginTest.php

Indentation +716 added lines, -716 removed lines

@@ -39,721 +39,721 @@
  */
 class FilesPluginTest extends TestCase {
 
-	private Tree&MockObject $tree;
-	private Server&MockObject $server;
-	private IConfig&MockObject $config;
-	private IRequest&MockObject $request;
-	private IPreview&MockObject $previewManager;
-	private IUserSession&MockObject $userSession;
-	private IFilenameValidator&MockObject $filenameValidator;
-	private IAccountManager&MockObject $accountManager;
-	private FilesPlugin $plugin;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$this->server = $this->createMock(Server::class);
-		$this->tree = $this->createMock(Tree::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->config->expects($this->any())->method('getSystemValue')
-			->with($this->equalTo('data-fingerprint'), $this->equalTo(''))
-			->willReturn('my_fingerprint');
-		$this->request = $this->createMock(IRequest::class);
-		$this->previewManager = $this->createMock(IPreview::class);
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->filenameValidator = $this->createMock(IFilenameValidator::class);
-		$this->accountManager = $this->createMock(IAccountManager::class);
-
-		$this->plugin = new FilesPlugin(
-			$this->tree,
-			$this->config,
-			$this->request,
-			$this->previewManager,
-			$this->userSession,
-			$this->filenameValidator,
-			$this->accountManager,
-		);
-
-		$response = $this->getMockBuilder(ResponseInterface::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$this->server->httpResponse = $response;
-		$this->server->xml = new Service();
-
-		$this->plugin->initialize($this->server);
-	}
-
-	/**
-	 * @param string $class
-	 * @return \PHPUnit\Framework\MockObject\MockObject
-	 */
-	private function createTestNode($class, $path = '/dummypath') {
-		$node = $this->getMockBuilder($class)
-			->disableOriginalConstructor()
-			->getMock();
-
-		$node->expects($this->any())
-			->method('getId')
-			->willReturn(123);
-
-		$this->tree->expects($this->any())
-			->method('getNodeForPath')
-			->with($path)
-			->willReturn($node);
-
-		$node->expects($this->any())
-			->method('getFileId')
-			->willReturn('00000123instanceid');
-		$node->expects($this->any())
-			->method('getInternalFileId')
-			->willReturn('123');
-		$node->expects($this->any())
-			->method('getEtag')
-			->willReturn('"abc"');
-		$node->expects($this->any())
-			->method('getDavPermissions')
-			->willReturn('DWCKMSR');
-
-		$fileInfo = $this->createMock(FileInfo::class);
-		$fileInfo->expects($this->any())
-			->method('isReadable')
-			->willReturn(true);
-		$fileInfo->expects($this->any())
-			->method('getCreationTime')
-			->willReturn(123456789);
-
-		$node->expects($this->any())
-			->method('getFileInfo')
-			->willReturn($fileInfo);
-
-		return $node;
-	}
-
-	public function testGetPropertiesForFile(): void {
-		/** @var File|\PHPUnit\Framework\MockObject\MockObject $node */
-		$node = $this->createTestNode('\OCA\DAV\Connector\Sabre\File');
-
-		$propFind = new PropFind(
-			'/dummyPath',
-			[
-				FilesPlugin::GETETAG_PROPERTYNAME,
-				FilesPlugin::FILEID_PROPERTYNAME,
-				FilesPlugin::INTERNAL_FILEID_PROPERTYNAME,
-				FilesPlugin::SIZE_PROPERTYNAME,
-				FilesPlugin::PERMISSIONS_PROPERTYNAME,
-				FilesPlugin::DOWNLOADURL_PROPERTYNAME,
-				FilesPlugin::OWNER_ID_PROPERTYNAME,
-				FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME,
-				FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
-				FilesPlugin::CREATIONDATE_PROPERTYNAME,
-			],
-			0
-		);
-
-		$user = $this->getMockBuilder(User::class)
-			->disableOriginalConstructor()->getMock();
-		$user
-			->expects($this->once())
-			->method('getUID')
-			->willReturn('foo');
-		$user
-			->expects($this->once())
-			->method('getDisplayName')
-			->willReturn('M. Foo');
-
-		$owner = $this->getMockBuilder(Account::class)
-			->disableOriginalConstructor()->getMock();
-		$this->accountManager->expects($this->once())
-			->method('getAccount')
-			->with($user)
-			->willReturn($owner);
-
-		$node->expects($this->once())
-			->method('getDirectDownload')
-			->willReturn(['url' => 'http://example.com/']);
-		$node->expects($this->exactly(2))
-			->method('getOwner')
-			->willReturn($user);
-
-		$displayNameProp = $this->getMockBuilder(AccountProperty::class)
-			->disableOriginalConstructor()->getMock();
-		$owner
-			->expects($this->once())
-			->method('getProperty')
-			->with(IAccountManager::PROPERTY_DISPLAYNAME)
-			->willReturn($displayNameProp);
-		$displayNameProp
-			->expects($this->once())
-			->method('getScope')
-			->willReturn(IAccountManager::SCOPE_PUBLISHED);
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals('"abc"', $propFind->get(FilesPlugin::GETETAG_PROPERTYNAME));
-		$this->assertEquals('00000123instanceid', $propFind->get(FilesPlugin::FILEID_PROPERTYNAME));
-		$this->assertEquals('123', $propFind->get(FilesPlugin::INTERNAL_FILEID_PROPERTYNAME));
-		$this->assertEquals('1973-11-29T21:33:09+00:00', $propFind->get(FilesPlugin::CREATIONDATE_PROPERTYNAME));
-		$this->assertEquals(0, $propFind->get(FilesPlugin::SIZE_PROPERTYNAME));
-		$this->assertEquals('DWCKMSR', $propFind->get(FilesPlugin::PERMISSIONS_PROPERTYNAME));
-		$this->assertEquals('http://example.com/', $propFind->get(FilesPlugin::DOWNLOADURL_PROPERTYNAME));
-		$this->assertEquals('foo', $propFind->get(FilesPlugin::OWNER_ID_PROPERTYNAME));
-		$this->assertEquals('M. Foo', $propFind->get(FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME));
-		$this->assertEquals('my_fingerprint', $propFind->get(FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME));
-		$this->assertEquals([], $propFind->get404Properties());
-	}
-
-	public function testGetDisplayNamePropertyWhenNotPublished(): void {
-		/** @var File|\PHPUnit\Framework\MockObject\MockObject $node */
-		$node = $this->createTestNode('\OCA\DAV\Connector\Sabre\File');
-
-		$propFind = new PropFind(
-			'/dummyPath',
-			[
-				FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME,
-			],
-			0
-		);
-
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn(null);
-
-		$user = $this->getMockBuilder(User::class)
-			->disableOriginalConstructor()->getMock();
-
-		$user
-			->expects($this->never())
-			->method('getDisplayName');
-
-		$owner = $this->getMockBuilder(Account::class)
-			->disableOriginalConstructor()->getMock();
-		$this->accountManager->expects($this->once())
-			->method('getAccount')
-			->with($user)
-			->willReturn($owner);
-
-		$node->expects($this->once())
-			->method('getOwner')
-			->willReturn($user);
-
-		$displayNameProp = $this->getMockBuilder(AccountProperty::class)
-			->disableOriginalConstructor()->getMock();
-		$owner
-			->expects($this->once())
-			->method('getProperty')
-			->with(IAccountManager::PROPERTY_DISPLAYNAME)
-			->willReturn($displayNameProp);
-		$displayNameProp
-			->expects($this->once())
-			->method('getScope')
-			->willReturn(IAccountManager::SCOPE_PRIVATE);
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals(null, $propFind->get(FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME));
-	}
+    private Tree&MockObject $tree;
+    private Server&MockObject $server;
+    private IConfig&MockObject $config;
+    private IRequest&MockObject $request;
+    private IPreview&MockObject $previewManager;
+    private IUserSession&MockObject $userSession;
+    private IFilenameValidator&MockObject $filenameValidator;
+    private IAccountManager&MockObject $accountManager;
+    private FilesPlugin $plugin;
+
+    protected function setUp(): void {
+        parent::setUp();
+        $this->server = $this->createMock(Server::class);
+        $this->tree = $this->createMock(Tree::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->config->expects($this->any())->method('getSystemValue')
+            ->with($this->equalTo('data-fingerprint'), $this->equalTo(''))
+            ->willReturn('my_fingerprint');
+        $this->request = $this->createMock(IRequest::class);
+        $this->previewManager = $this->createMock(IPreview::class);
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->filenameValidator = $this->createMock(IFilenameValidator::class);
+        $this->accountManager = $this->createMock(IAccountManager::class);
+
+        $this->plugin = new FilesPlugin(
+            $this->tree,
+            $this->config,
+            $this->request,
+            $this->previewManager,
+            $this->userSession,
+            $this->filenameValidator,
+            $this->accountManager,
+        );
+
+        $response = $this->getMockBuilder(ResponseInterface::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->server->httpResponse = $response;
+        $this->server->xml = new Service();
+
+        $this->plugin->initialize($this->server);
+    }
+
+    /**
+     * @param string $class
+     * @return \PHPUnit\Framework\MockObject\MockObject
+     */
+    private function createTestNode($class, $path = '/dummypath') {
+        $node = $this->getMockBuilder($class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $node->expects($this->any())
+            ->method('getId')
+            ->willReturn(123);
+
+        $this->tree->expects($this->any())
+            ->method('getNodeForPath')
+            ->with($path)
+            ->willReturn($node);
+
+        $node->expects($this->any())
+            ->method('getFileId')
+            ->willReturn('00000123instanceid');
+        $node->expects($this->any())
+            ->method('getInternalFileId')
+            ->willReturn('123');
+        $node->expects($this->any())
+            ->method('getEtag')
+            ->willReturn('"abc"');
+        $node->expects($this->any())
+            ->method('getDavPermissions')
+            ->willReturn('DWCKMSR');
+
+        $fileInfo = $this->createMock(FileInfo::class);
+        $fileInfo->expects($this->any())
+            ->method('isReadable')
+            ->willReturn(true);
+        $fileInfo->expects($this->any())
+            ->method('getCreationTime')
+            ->willReturn(123456789);
+
+        $node->expects($this->any())
+            ->method('getFileInfo')
+            ->willReturn($fileInfo);
+
+        return $node;
+    }
+
+    public function testGetPropertiesForFile(): void {
+        /** @var File|\PHPUnit\Framework\MockObject\MockObject $node */
+        $node = $this->createTestNode('\OCA\DAV\Connector\Sabre\File');
+
+        $propFind = new PropFind(
+            '/dummyPath',
+            [
+                FilesPlugin::GETETAG_PROPERTYNAME,
+                FilesPlugin::FILEID_PROPERTYNAME,
+                FilesPlugin::INTERNAL_FILEID_PROPERTYNAME,
+                FilesPlugin::SIZE_PROPERTYNAME,
+                FilesPlugin::PERMISSIONS_PROPERTYNAME,
+                FilesPlugin::DOWNLOADURL_PROPERTYNAME,
+                FilesPlugin::OWNER_ID_PROPERTYNAME,
+                FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME,
+                FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
+                FilesPlugin::CREATIONDATE_PROPERTYNAME,
+            ],
+            0
+        );
+
+        $user = $this->getMockBuilder(User::class)
+            ->disableOriginalConstructor()->getMock();
+        $user
+            ->expects($this->once())
+            ->method('getUID')
+            ->willReturn('foo');
+        $user
+            ->expects($this->once())
+            ->method('getDisplayName')
+            ->willReturn('M. Foo');
+
+        $owner = $this->getMockBuilder(Account::class)
+            ->disableOriginalConstructor()->getMock();
+        $this->accountManager->expects($this->once())
+            ->method('getAccount')
+            ->with($user)
+            ->willReturn($owner);
+
+        $node->expects($this->once())
+            ->method('getDirectDownload')
+            ->willReturn(['url' => 'http://example.com/']);
+        $node->expects($this->exactly(2))
+            ->method('getOwner')
+            ->willReturn($user);
+
+        $displayNameProp = $this->getMockBuilder(AccountProperty::class)
+            ->disableOriginalConstructor()->getMock();
+        $owner
+            ->expects($this->once())
+            ->method('getProperty')
+            ->with(IAccountManager::PROPERTY_DISPLAYNAME)
+            ->willReturn($displayNameProp);
+        $displayNameProp
+            ->expects($this->once())
+            ->method('getScope')
+            ->willReturn(IAccountManager::SCOPE_PUBLISHED);
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals('"abc"', $propFind->get(FilesPlugin::GETETAG_PROPERTYNAME));
+        $this->assertEquals('00000123instanceid', $propFind->get(FilesPlugin::FILEID_PROPERTYNAME));
+        $this->assertEquals('123', $propFind->get(FilesPlugin::INTERNAL_FILEID_PROPERTYNAME));
+        $this->assertEquals('1973-11-29T21:33:09+00:00', $propFind->get(FilesPlugin::CREATIONDATE_PROPERTYNAME));
+        $this->assertEquals(0, $propFind->get(FilesPlugin::SIZE_PROPERTYNAME));
+        $this->assertEquals('DWCKMSR', $propFind->get(FilesPlugin::PERMISSIONS_PROPERTYNAME));
+        $this->assertEquals('http://example.com/', $propFind->get(FilesPlugin::DOWNLOADURL_PROPERTYNAME));
+        $this->assertEquals('foo', $propFind->get(FilesPlugin::OWNER_ID_PROPERTYNAME));
+        $this->assertEquals('M. Foo', $propFind->get(FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME));
+        $this->assertEquals('my_fingerprint', $propFind->get(FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME));
+        $this->assertEquals([], $propFind->get404Properties());
+    }
+
+    public function testGetDisplayNamePropertyWhenNotPublished(): void {
+        /** @var File|\PHPUnit\Framework\MockObject\MockObject $node */
+        $node = $this->createTestNode('\OCA\DAV\Connector\Sabre\File');
+
+        $propFind = new PropFind(
+            '/dummyPath',
+            [
+                FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME,
+            ],
+            0
+        );
+
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn(null);
+
+        $user = $this->getMockBuilder(User::class)
+            ->disableOriginalConstructor()->getMock();
+
+        $user
+            ->expects($this->never())
+            ->method('getDisplayName');
+
+        $owner = $this->getMockBuilder(Account::class)
+            ->disableOriginalConstructor()->getMock();
+        $this->accountManager->expects($this->once())
+            ->method('getAccount')
+            ->with($user)
+            ->willReturn($owner);
+
+        $node->expects($this->once())
+            ->method('getOwner')
+            ->willReturn($user);
+
+        $displayNameProp = $this->getMockBuilder(AccountProperty::class)
+            ->disableOriginalConstructor()->getMock();
+        $owner
+            ->expects($this->once())
+            ->method('getProperty')
+            ->with(IAccountManager::PROPERTY_DISPLAYNAME)
+            ->willReturn($displayNameProp);
+        $displayNameProp
+            ->expects($this->once())
+            ->method('getScope')
+            ->willReturn(IAccountManager::SCOPE_PRIVATE);
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals(null, $propFind->get(FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME));
+    }
 	
-	public function testGetDisplayNamePropertyWhenNotPublishedButLoggedIn(): void {
-		/** @var File|\PHPUnit\Framework\MockObject\MockObject $node */
-		$node = $this->createTestNode('\OCA\DAV\Connector\Sabre\File');
-
-		$propFind = new PropFind(
-			'/dummyPath',
-			[
-				FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME,
-			],
-			0
-		);
-
-		$user = $this->getMockBuilder(User::class)
-			->disableOriginalConstructor()->getMock();
-
-		$node->expects($this->once())
-			->method('getOwner')
-			->willReturn($user);
-
-		$loggedInUser = $this->getMockBuilder(User::class)
-			->disableOriginalConstructor()->getMock();
-		$this->userSession->expects($this->once())
-			->method('getUser')
-			->willReturn($loggedInUser);
-
-		$user
-			->expects($this->once())
-			->method('getDisplayName')
-			->willReturn('M. Foo');
-
-		$this->accountManager->expects($this->never())
-			->method('getAccount');
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals('M. Foo', $propFind->get(FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME));
-	}
-
-	public function testGetPropertiesStorageNotAvailable(): void {
-		/** @var File|\PHPUnit\Framework\MockObject\MockObject $node */
-		$node = $this->createTestNode('\OCA\DAV\Connector\Sabre\File');
-
-		$propFind = new PropFind(
-			'/dummyPath',
-			[
-				FilesPlugin::DOWNLOADURL_PROPERTYNAME,
-			],
-			0
-		);
-
-		$node->expects($this->once())
-			->method('getDirectDownload')
-			->will($this->throwException(new StorageNotAvailableException()));
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals(null, $propFind->get(FilesPlugin::DOWNLOADURL_PROPERTYNAME));
-	}
-
-	public function testGetPublicPermissions(): void {
-		/** @var IRequest&MockObject */
-		$request = $this->getMockBuilder(IRequest::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$this->plugin = new FilesPlugin(
-			$this->tree,
-			$this->config,
-			$request,
-			$this->previewManager,
-			$this->userSession,
-			$this->filenameValidator,
-			$this->accountManager,
-			true,
-		);
-		$this->plugin->initialize($this->server);
-
-		$propFind = new PropFind(
-			'/dummyPath',
-			[
-				FilesPlugin::PERMISSIONS_PROPERTYNAME,
-			],
-			0
-		);
-
-		/** @var File|\PHPUnit\Framework\MockObject\MockObject $node */
-		$node = $this->createTestNode('\OCA\DAV\Connector\Sabre\File');
-		$node->expects($this->any())
-			->method('getDavPermissions')
-			->willReturn('DWCKMSR');
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals('DWCKR', $propFind->get(FilesPlugin::PERMISSIONS_PROPERTYNAME));
-	}
-
-	public function testGetPropertiesForDirectory(): void {
-		/** @var Directory|\PHPUnit\Framework\MockObject\MockObject $node */
-		$node = $this->createTestNode('\OCA\DAV\Connector\Sabre\Directory');
-
-		$propFind = new PropFind(
-			'/dummyPath',
-			[
-				FilesPlugin::GETETAG_PROPERTYNAME,
-				FilesPlugin::FILEID_PROPERTYNAME,
-				FilesPlugin::SIZE_PROPERTYNAME,
-				FilesPlugin::PERMISSIONS_PROPERTYNAME,
-				FilesPlugin::DOWNLOADURL_PROPERTYNAME,
-				FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
-			],
-			0
-		);
-
-		$node->expects($this->once())
-			->method('getSize')
-			->willReturn(1025);
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals('"abc"', $propFind->get(FilesPlugin::GETETAG_PROPERTYNAME));
-		$this->assertEquals('00000123instanceid', $propFind->get(FilesPlugin::FILEID_PROPERTYNAME));
-		$this->assertEquals(1025, $propFind->get(FilesPlugin::SIZE_PROPERTYNAME));
-		$this->assertEquals('DWCKMSR', $propFind->get(FilesPlugin::PERMISSIONS_PROPERTYNAME));
-		$this->assertEquals(null, $propFind->get(FilesPlugin::DOWNLOADURL_PROPERTYNAME));
-		$this->assertEquals('my_fingerprint', $propFind->get(FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME));
-		$this->assertEquals([FilesPlugin::DOWNLOADURL_PROPERTYNAME], $propFind->get404Properties());
-	}
-
-	public function testGetPropertiesForRootDirectory(): void {
-		/** @var Directory|\PHPUnit\Framework\MockObject\MockObject $node */
-		$node = $this->getMockBuilder(Directory::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$node->expects($this->any())->method('getPath')->willReturn('/');
-
-		$fileInfo = $this->createMock(FileInfo::class);
-		$fileInfo->expects($this->any())
-			->method('isReadable')
-			->willReturn(true);
-
-		$node->expects($this->any())
-			->method('getFileInfo')
-			->willReturn($fileInfo);
-
-		$propFind = new PropFind(
-			'/',
-			[
-				FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
-			],
-			0
-		);
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals('my_fingerprint', $propFind->get(FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME));
-	}
-
-	public function testGetPropertiesWhenNoPermission(): void {
-		// No read permissions can be caused by files access control.
-		// But we still want to load the directory list, so this is okay for us.
-		// $this->expectException(\Sabre\DAV\Exception\NotFound::class);
-		/** @var Directory|\PHPUnit\Framework\MockObject\MockObject $node */
-		$node = $this->getMockBuilder(Directory::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$node->expects($this->any())->method('getPath')->willReturn('/');
-
-		$fileInfo = $this->createMock(FileInfo::class);
-		$fileInfo->expects($this->any())
-			->method('isReadable')
-			->willReturn(false);
-
-		$node->expects($this->any())
-			->method('getFileInfo')
-			->willReturn($fileInfo);
-
-		$propFind = new PropFind(
-			'/test',
-			[
-				FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
-			],
-			0
-		);
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->addToAssertionCount(1);
-	}
-
-	public function testUpdateProps(): void {
-		$node = $this->createTestNode('\OCA\DAV\Connector\Sabre\File');
-
-		$testDate = 'Fri, 13 Feb 2015 00:01:02 GMT';
-		$testCreationDate = '2007-08-31T16:47+00:00';
-
-		$node->expects($this->once())
-			->method('touch')
-			->with($testDate);
-
-		$node->expects($this->once())
-			->method('setEtag')
-			->with('newetag')
-			->willReturn(true);
-
-		$node->expects($this->once())
-			->method('setCreationTime')
-			->with('1188578820');
-
-		// properties to set
-		$propPatch = new PropPatch([
-			FilesPlugin::GETETAG_PROPERTYNAME => 'newetag',
-			FilesPlugin::LASTMODIFIED_PROPERTYNAME => $testDate,
-			FilesPlugin::CREATIONDATE_PROPERTYNAME => $testCreationDate,
-		]);
-
-
-		$this->plugin->handleUpdateProperties(
-			'/dummypath',
-			$propPatch
-		);
-
-		$propPatch->commit();
-
-		$this->assertEmpty($propPatch->getRemainingMutations());
-
-		$result = $propPatch->getResult();
-		$this->assertEquals(200, $result[FilesPlugin::LASTMODIFIED_PROPERTYNAME]);
-		$this->assertEquals(200, $result[FilesPlugin::GETETAG_PROPERTYNAME]);
-		$this->assertEquals(200, $result[FilesPlugin::CREATIONDATE_PROPERTYNAME]);
-	}
-
-	public function testUpdatePropsForbidden(): void {
-		$propPatch = new PropPatch([
-			FilesPlugin::OWNER_ID_PROPERTYNAME => 'user2',
-			FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME => 'User Two',
-			FilesPlugin::FILEID_PROPERTYNAME => 12345,
-			FilesPlugin::PERMISSIONS_PROPERTYNAME => 'C',
-			FilesPlugin::SIZE_PROPERTYNAME => 123,
-			FilesPlugin::DOWNLOADURL_PROPERTYNAME => 'http://example.com/',
-		]);
-
-		$this->plugin->handleUpdateProperties(
-			'/dummypath',
-			$propPatch
-		);
-
-		$propPatch->commit();
-
-		$this->assertEmpty($propPatch->getRemainingMutations());
-
-		$result = $propPatch->getResult();
-		$this->assertEquals(403, $result[FilesPlugin::OWNER_ID_PROPERTYNAME]);
-		$this->assertEquals(403, $result[FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME]);
-		$this->assertEquals(403, $result[FilesPlugin::FILEID_PROPERTYNAME]);
-		$this->assertEquals(403, $result[FilesPlugin::PERMISSIONS_PROPERTYNAME]);
-		$this->assertEquals(403, $result[FilesPlugin::SIZE_PROPERTYNAME]);
-		$this->assertEquals(403, $result[FilesPlugin::DOWNLOADURL_PROPERTYNAME]);
-	}
-
-	/**
-	 * Test case from https://github.com/owncloud/core/issues/5251
-	 *
-	 * |-FolderA
-	 *  |-text.txt
-	 * |-test.txt
-	 *
-	 * FolderA is an incoming shared folder and there are no delete permissions.
-	 * Thus moving /FolderA/test.txt to /test.txt should fail already on that check
-	 *
-	 */
-	public function testMoveSrcNotDeletable(): void {
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
-		$this->expectExceptionMessage('FolderA/test.txt cannot be deleted');
-
-		$fileInfoFolderATestTXT = $this->getMockBuilder(FileInfo::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$fileInfoFolderATestTXT->expects($this->once())
-			->method('isDeletable')
-			->willReturn(false);
-
-		$node = $this->getMockBuilder(Node::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$node->expects($this->atLeastOnce())
-			->method('getFileInfo')
-			->willReturn($fileInfoFolderATestTXT);
-
-		$this->tree->expects($this->atLeastOnce())
-			->method('getNodeForPath')
-			->willReturn($node);
-
-		$this->plugin->checkMove('FolderA/test.txt', 'test.txt');
-	}
-
-	public function testMoveSrcDeletable(): void {
-		$fileInfoFolderATestTXT = $this->getMockBuilder(FileInfo::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$fileInfoFolderATestTXT->expects($this->once())
-			->method('isDeletable')
-			->willReturn(true);
-
-		$node = $this->getMockBuilder(Node::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$node->expects($this->atLeastOnce())
-			->method('getFileInfo')
-			->willReturn($fileInfoFolderATestTXT);
-
-		$this->tree->expects($this->atLeastOnce())
-			->method('getNodeForPath')
-			->willReturn($node);
-
-		$this->plugin->checkMove('FolderA/test.txt', 'test.txt');
-	}
-
-	public function testMoveSrcNotExist(): void {
-		$this->expectException(\Sabre\DAV\Exception\NotFound::class);
-		$this->expectExceptionMessage('FolderA/test.txt does not exist');
-
-		$node = $this->getMockBuilder(Node::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$node->expects($this->atLeastOnce())
-			->method('getFileInfo')
-			->willReturn(null);
-
-		$this->tree->expects($this->atLeastOnce())
-			->method('getNodeForPath')
-			->willReturn($node);
-
-		$this->plugin->checkMove('FolderA/test.txt', 'test.txt');
-	}
-
-	public function testMoveDestinationInvalid(): void {
-		$this->expectException(InvalidPath::class);
-		$this->expectExceptionMessage('Mocked exception');
-
-		$fileInfoFolderATestTXT = $this->createMock(FileInfo::class);
-		$fileInfoFolderATestTXT->expects(self::any())
-			->method('isDeletable')
-			->willReturn(true);
-
-		$node = $this->createMock(Node::class);
-		$node->expects($this->atLeastOnce())
-			->method('getFileInfo')
-			->willReturn($fileInfoFolderATestTXT);
-
-		$this->tree->expects($this->atLeastOnce())
-			->method('getNodeForPath')
-			->willReturn($node);
-
-		$this->filenameValidator->expects(self::once())
-			->method('validateFilename')
-			->with('invalid\\path.txt')
-			->willThrowException(new InvalidPathException('Mocked exception'));
-
-		$this->plugin->checkMove('FolderA/test.txt', 'invalid\\path.txt');
-	}
-
-	public function testCopySrcNotExist(): void {
-		$this->expectException(\Sabre\DAV\Exception\NotFound::class);
-		$this->expectExceptionMessage('FolderA/test.txt does not exist');
-
-		$node = $this->createMock(Node::class);
-		$node->expects($this->atLeastOnce())
-			->method('getFileInfo')
-			->willReturn(null);
-
-		$this->tree->expects($this->atLeastOnce())
-			->method('getNodeForPath')
-			->willReturn($node);
-
-		$this->plugin->checkCopy('FolderA/test.txt', 'test.txt');
-	}
-
-	public function testCopyDestinationInvalid(): void {
-		$this->expectException(InvalidPath::class);
-		$this->expectExceptionMessage('Mocked exception');
-
-		$fileInfoFolderATestTXT = $this->createMock(FileInfo::class);
-		$node = $this->createMock(Node::class);
-		$node->expects($this->atLeastOnce())
-			->method('getFileInfo')
-			->willReturn($fileInfoFolderATestTXT);
-
-		$this->tree->expects($this->atLeastOnce())
-			->method('getNodeForPath')
-			->willReturn($node);
-
-		$this->filenameValidator->expects(self::once())
-			->method('validateFilename')
-			->with('invalid\\path.txt')
-			->willThrowException(new InvalidPathException('Mocked exception'));
-
-		$this->plugin->checkCopy('FolderA/test.txt', 'invalid\\path.txt');
-	}
-
-	public function downloadHeadersProvider() {
-		return [
-			[
-				false,
-				'attachment; filename*=UTF-8\'\'somefile.xml; filename="somefile.xml"'
-			],
-			[
-				true,
-				'attachment; filename="somefile.xml"'
-			],
-		];
-	}
-
-	/**
-	 * @dataProvider downloadHeadersProvider
-	 */
-	public function testDownloadHeaders($isClumsyAgent, $contentDispositionHeader): void {
-		$request = $this->getMockBuilder(RequestInterface::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$response = $this->getMockBuilder(ResponseInterface::class)
-			->disableOriginalConstructor()
-			->getMock();
-
-		$request
-			->expects($this->once())
-			->method('getPath')
-			->willReturn('test/somefile.xml');
-
-		$node = $this->getMockBuilder(File::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$node
-			->expects($this->once())
-			->method('getName')
-			->willReturn('somefile.xml');
-
-		$this->tree
-			->expects($this->once())
-			->method('getNodeForPath')
-			->with('test/somefile.xml')
-			->willReturn($node);
-
-		$this->request
-			->expects($this->once())
-			->method('isUserAgent')
-			->willReturn($isClumsyAgent);
-
-		$response
-			->expects($this->exactly(2))
-			->method('addHeader')
-			->withConsecutive(
-				['Content-Disposition', $contentDispositionHeader],
-				['X-Accel-Buffering', 'no']
-			);
-
-		$this->plugin->httpGet($request, $response);
-	}
-
-	public function testHasPreview(): void {
-		/** @var Directory|\PHPUnit\Framework\MockObject\MockObject $node */
-		$node = $this->createTestNode('\OCA\DAV\Connector\Sabre\Directory');
-
-		$propFind = new PropFind(
-			'/dummyPath',
-			[
-				FilesPlugin::HAS_PREVIEW_PROPERTYNAME
-			],
-			0
-		);
-
-		$this->previewManager->expects($this->once())
-			->method('isAvailable')
-			->willReturn(false);
-
-		$this->plugin->handleGetProperties(
-			$propFind,
-			$node
-		);
-
-		$this->assertEquals('false', $propFind->get(FilesPlugin::HAS_PREVIEW_PROPERTYNAME));
-	}
+    public function testGetDisplayNamePropertyWhenNotPublishedButLoggedIn(): void {
+        /** @var File|\PHPUnit\Framework\MockObject\MockObject $node */
+        $node = $this->createTestNode('\OCA\DAV\Connector\Sabre\File');
+
+        $propFind = new PropFind(
+            '/dummyPath',
+            [
+                FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME,
+            ],
+            0
+        );
+
+        $user = $this->getMockBuilder(User::class)
+            ->disableOriginalConstructor()->getMock();
+
+        $node->expects($this->once())
+            ->method('getOwner')
+            ->willReturn($user);
+
+        $loggedInUser = $this->getMockBuilder(User::class)
+            ->disableOriginalConstructor()->getMock();
+        $this->userSession->expects($this->once())
+            ->method('getUser')
+            ->willReturn($loggedInUser);
+
+        $user
+            ->expects($this->once())
+            ->method('getDisplayName')
+            ->willReturn('M. Foo');
+
+        $this->accountManager->expects($this->never())
+            ->method('getAccount');
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals('M. Foo', $propFind->get(FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME));
+    }
+
+    public function testGetPropertiesStorageNotAvailable(): void {
+        /** @var File|\PHPUnit\Framework\MockObject\MockObject $node */
+        $node = $this->createTestNode('\OCA\DAV\Connector\Sabre\File');
+
+        $propFind = new PropFind(
+            '/dummyPath',
+            [
+                FilesPlugin::DOWNLOADURL_PROPERTYNAME,
+            ],
+            0
+        );
+
+        $node->expects($this->once())
+            ->method('getDirectDownload')
+            ->will($this->throwException(new StorageNotAvailableException()));
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals(null, $propFind->get(FilesPlugin::DOWNLOADURL_PROPERTYNAME));
+    }
+
+    public function testGetPublicPermissions(): void {
+        /** @var IRequest&MockObject */
+        $request = $this->getMockBuilder(IRequest::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->plugin = new FilesPlugin(
+            $this->tree,
+            $this->config,
+            $request,
+            $this->previewManager,
+            $this->userSession,
+            $this->filenameValidator,
+            $this->accountManager,
+            true,
+        );
+        $this->plugin->initialize($this->server);
+
+        $propFind = new PropFind(
+            '/dummyPath',
+            [
+                FilesPlugin::PERMISSIONS_PROPERTYNAME,
+            ],
+            0
+        );
+
+        /** @var File|\PHPUnit\Framework\MockObject\MockObject $node */
+        $node = $this->createTestNode('\OCA\DAV\Connector\Sabre\File');
+        $node->expects($this->any())
+            ->method('getDavPermissions')
+            ->willReturn('DWCKMSR');
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals('DWCKR', $propFind->get(FilesPlugin::PERMISSIONS_PROPERTYNAME));
+    }
+
+    public function testGetPropertiesForDirectory(): void {
+        /** @var Directory|\PHPUnit\Framework\MockObject\MockObject $node */
+        $node = $this->createTestNode('\OCA\DAV\Connector\Sabre\Directory');
+
+        $propFind = new PropFind(
+            '/dummyPath',
+            [
+                FilesPlugin::GETETAG_PROPERTYNAME,
+                FilesPlugin::FILEID_PROPERTYNAME,
+                FilesPlugin::SIZE_PROPERTYNAME,
+                FilesPlugin::PERMISSIONS_PROPERTYNAME,
+                FilesPlugin::DOWNLOADURL_PROPERTYNAME,
+                FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
+            ],
+            0
+        );
+
+        $node->expects($this->once())
+            ->method('getSize')
+            ->willReturn(1025);
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals('"abc"', $propFind->get(FilesPlugin::GETETAG_PROPERTYNAME));
+        $this->assertEquals('00000123instanceid', $propFind->get(FilesPlugin::FILEID_PROPERTYNAME));
+        $this->assertEquals(1025, $propFind->get(FilesPlugin::SIZE_PROPERTYNAME));
+        $this->assertEquals('DWCKMSR', $propFind->get(FilesPlugin::PERMISSIONS_PROPERTYNAME));
+        $this->assertEquals(null, $propFind->get(FilesPlugin::DOWNLOADURL_PROPERTYNAME));
+        $this->assertEquals('my_fingerprint', $propFind->get(FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME));
+        $this->assertEquals([FilesPlugin::DOWNLOADURL_PROPERTYNAME], $propFind->get404Properties());
+    }
+
+    public function testGetPropertiesForRootDirectory(): void {
+        /** @var Directory|\PHPUnit\Framework\MockObject\MockObject $node */
+        $node = $this->getMockBuilder(Directory::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $node->expects($this->any())->method('getPath')->willReturn('/');
+
+        $fileInfo = $this->createMock(FileInfo::class);
+        $fileInfo->expects($this->any())
+            ->method('isReadable')
+            ->willReturn(true);
+
+        $node->expects($this->any())
+            ->method('getFileInfo')
+            ->willReturn($fileInfo);
+
+        $propFind = new PropFind(
+            '/',
+            [
+                FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
+            ],
+            0
+        );
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals('my_fingerprint', $propFind->get(FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME));
+    }
+
+    public function testGetPropertiesWhenNoPermission(): void {
+        // No read permissions can be caused by files access control.
+        // But we still want to load the directory list, so this is okay for us.
+        // $this->expectException(\Sabre\DAV\Exception\NotFound::class);
+        /** @var Directory|\PHPUnit\Framework\MockObject\MockObject $node */
+        $node = $this->getMockBuilder(Directory::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $node->expects($this->any())->method('getPath')->willReturn('/');
+
+        $fileInfo = $this->createMock(FileInfo::class);
+        $fileInfo->expects($this->any())
+            ->method('isReadable')
+            ->willReturn(false);
+
+        $node->expects($this->any())
+            ->method('getFileInfo')
+            ->willReturn($fileInfo);
+
+        $propFind = new PropFind(
+            '/test',
+            [
+                FilesPlugin::DATA_FINGERPRINT_PROPERTYNAME,
+            ],
+            0
+        );
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->addToAssertionCount(1);
+    }
+
+    public function testUpdateProps(): void {
+        $node = $this->createTestNode('\OCA\DAV\Connector\Sabre\File');
+
+        $testDate = 'Fri, 13 Feb 2015 00:01:02 GMT';
+        $testCreationDate = '2007-08-31T16:47+00:00';
+
+        $node->expects($this->once())
+            ->method('touch')
+            ->with($testDate);
+
+        $node->expects($this->once())
+            ->method('setEtag')
+            ->with('newetag')
+            ->willReturn(true);
+
+        $node->expects($this->once())
+            ->method('setCreationTime')
+            ->with('1188578820');
+
+        // properties to set
+        $propPatch = new PropPatch([
+            FilesPlugin::GETETAG_PROPERTYNAME => 'newetag',
+            FilesPlugin::LASTMODIFIED_PROPERTYNAME => $testDate,
+            FilesPlugin::CREATIONDATE_PROPERTYNAME => $testCreationDate,
+        ]);
+
+
+        $this->plugin->handleUpdateProperties(
+            '/dummypath',
+            $propPatch
+        );
+
+        $propPatch->commit();
+
+        $this->assertEmpty($propPatch->getRemainingMutations());
+
+        $result = $propPatch->getResult();
+        $this->assertEquals(200, $result[FilesPlugin::LASTMODIFIED_PROPERTYNAME]);
+        $this->assertEquals(200, $result[FilesPlugin::GETETAG_PROPERTYNAME]);
+        $this->assertEquals(200, $result[FilesPlugin::CREATIONDATE_PROPERTYNAME]);
+    }
+
+    public function testUpdatePropsForbidden(): void {
+        $propPatch = new PropPatch([
+            FilesPlugin::OWNER_ID_PROPERTYNAME => 'user2',
+            FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME => 'User Two',
+            FilesPlugin::FILEID_PROPERTYNAME => 12345,
+            FilesPlugin::PERMISSIONS_PROPERTYNAME => 'C',
+            FilesPlugin::SIZE_PROPERTYNAME => 123,
+            FilesPlugin::DOWNLOADURL_PROPERTYNAME => 'http://example.com/',
+        ]);
+
+        $this->plugin->handleUpdateProperties(
+            '/dummypath',
+            $propPatch
+        );
+
+        $propPatch->commit();
+
+        $this->assertEmpty($propPatch->getRemainingMutations());
+
+        $result = $propPatch->getResult();
+        $this->assertEquals(403, $result[FilesPlugin::OWNER_ID_PROPERTYNAME]);
+        $this->assertEquals(403, $result[FilesPlugin::OWNER_DISPLAY_NAME_PROPERTYNAME]);
+        $this->assertEquals(403, $result[FilesPlugin::FILEID_PROPERTYNAME]);
+        $this->assertEquals(403, $result[FilesPlugin::PERMISSIONS_PROPERTYNAME]);
+        $this->assertEquals(403, $result[FilesPlugin::SIZE_PROPERTYNAME]);
+        $this->assertEquals(403, $result[FilesPlugin::DOWNLOADURL_PROPERTYNAME]);
+    }
+
+    /**
+     * Test case from https://github.com/owncloud/core/issues/5251
+     *
+     * |-FolderA
+     *  |-text.txt
+     * |-test.txt
+     *
+     * FolderA is an incoming shared folder and there are no delete permissions.
+     * Thus moving /FolderA/test.txt to /test.txt should fail already on that check
+     *
+     */
+    public function testMoveSrcNotDeletable(): void {
+        $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+        $this->expectExceptionMessage('FolderA/test.txt cannot be deleted');
+
+        $fileInfoFolderATestTXT = $this->getMockBuilder(FileInfo::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $fileInfoFolderATestTXT->expects($this->once())
+            ->method('isDeletable')
+            ->willReturn(false);
+
+        $node = $this->getMockBuilder(Node::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $node->expects($this->atLeastOnce())
+            ->method('getFileInfo')
+            ->willReturn($fileInfoFolderATestTXT);
+
+        $this->tree->expects($this->atLeastOnce())
+            ->method('getNodeForPath')
+            ->willReturn($node);
+
+        $this->plugin->checkMove('FolderA/test.txt', 'test.txt');
+    }
+
+    public function testMoveSrcDeletable(): void {
+        $fileInfoFolderATestTXT = $this->getMockBuilder(FileInfo::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $fileInfoFolderATestTXT->expects($this->once())
+            ->method('isDeletable')
+            ->willReturn(true);
+
+        $node = $this->getMockBuilder(Node::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $node->expects($this->atLeastOnce())
+            ->method('getFileInfo')
+            ->willReturn($fileInfoFolderATestTXT);
+
+        $this->tree->expects($this->atLeastOnce())
+            ->method('getNodeForPath')
+            ->willReturn($node);
+
+        $this->plugin->checkMove('FolderA/test.txt', 'test.txt');
+    }
+
+    public function testMoveSrcNotExist(): void {
+        $this->expectException(\Sabre\DAV\Exception\NotFound::class);
+        $this->expectExceptionMessage('FolderA/test.txt does not exist');
+
+        $node = $this->getMockBuilder(Node::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $node->expects($this->atLeastOnce())
+            ->method('getFileInfo')
+            ->willReturn(null);
+
+        $this->tree->expects($this->atLeastOnce())
+            ->method('getNodeForPath')
+            ->willReturn($node);
+
+        $this->plugin->checkMove('FolderA/test.txt', 'test.txt');
+    }
+
+    public function testMoveDestinationInvalid(): void {
+        $this->expectException(InvalidPath::class);
+        $this->expectExceptionMessage('Mocked exception');
+
+        $fileInfoFolderATestTXT = $this->createMock(FileInfo::class);
+        $fileInfoFolderATestTXT->expects(self::any())
+            ->method('isDeletable')
+            ->willReturn(true);
+
+        $node = $this->createMock(Node::class);
+        $node->expects($this->atLeastOnce())
+            ->method('getFileInfo')
+            ->willReturn($fileInfoFolderATestTXT);
+
+        $this->tree->expects($this->atLeastOnce())
+            ->method('getNodeForPath')
+            ->willReturn($node);
+
+        $this->filenameValidator->expects(self::once())
+            ->method('validateFilename')
+            ->with('invalid\\path.txt')
+            ->willThrowException(new InvalidPathException('Mocked exception'));
+
+        $this->plugin->checkMove('FolderA/test.txt', 'invalid\\path.txt');
+    }
+
+    public function testCopySrcNotExist(): void {
+        $this->expectException(\Sabre\DAV\Exception\NotFound::class);
+        $this->expectExceptionMessage('FolderA/test.txt does not exist');
+
+        $node = $this->createMock(Node::class);
+        $node->expects($this->atLeastOnce())
+            ->method('getFileInfo')
+            ->willReturn(null);
+
+        $this->tree->expects($this->atLeastOnce())
+            ->method('getNodeForPath')
+            ->willReturn($node);
+
+        $this->plugin->checkCopy('FolderA/test.txt', 'test.txt');
+    }
+
+    public function testCopyDestinationInvalid(): void {
+        $this->expectException(InvalidPath::class);
+        $this->expectExceptionMessage('Mocked exception');
+
+        $fileInfoFolderATestTXT = $this->createMock(FileInfo::class);
+        $node = $this->createMock(Node::class);
+        $node->expects($this->atLeastOnce())
+            ->method('getFileInfo')
+            ->willReturn($fileInfoFolderATestTXT);
+
+        $this->tree->expects($this->atLeastOnce())
+            ->method('getNodeForPath')
+            ->willReturn($node);
+
+        $this->filenameValidator->expects(self::once())
+            ->method('validateFilename')
+            ->with('invalid\\path.txt')
+            ->willThrowException(new InvalidPathException('Mocked exception'));
+
+        $this->plugin->checkCopy('FolderA/test.txt', 'invalid\\path.txt');
+    }
+
+    public function downloadHeadersProvider() {
+        return [
+            [
+                false,
+                'attachment; filename*=UTF-8\'\'somefile.xml; filename="somefile.xml"'
+            ],
+            [
+                true,
+                'attachment; filename="somefile.xml"'
+            ],
+        ];
+    }
+
+    /**
+     * @dataProvider downloadHeadersProvider
+     */
+    public function testDownloadHeaders($isClumsyAgent, $contentDispositionHeader): void {
+        $request = $this->getMockBuilder(RequestInterface::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $response = $this->getMockBuilder(ResponseInterface::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $request
+            ->expects($this->once())
+            ->method('getPath')
+            ->willReturn('test/somefile.xml');
+
+        $node = $this->getMockBuilder(File::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $node
+            ->expects($this->once())
+            ->method('getName')
+            ->willReturn('somefile.xml');
+
+        $this->tree
+            ->expects($this->once())
+            ->method('getNodeForPath')
+            ->with('test/somefile.xml')
+            ->willReturn($node);
+
+        $this->request
+            ->expects($this->once())
+            ->method('isUserAgent')
+            ->willReturn($isClumsyAgent);
+
+        $response
+            ->expects($this->exactly(2))
+            ->method('addHeader')
+            ->withConsecutive(
+                ['Content-Disposition', $contentDispositionHeader],
+                ['X-Accel-Buffering', 'no']
+            );
+
+        $this->plugin->httpGet($request, $response);
+    }
+
+    public function testHasPreview(): void {
+        /** @var Directory|\PHPUnit\Framework\MockObject\MockObject $node */
+        $node = $this->createTestNode('\OCA\DAV\Connector\Sabre\Directory');
+
+        $propFind = new PropFind(
+            '/dummyPath',
+            [
+                FilesPlugin::HAS_PREVIEW_PROPERTYNAME
+            ],
+            0
+        );
+
+        $this->previewManager->expects($this->once())
+            ->method('isAvailable')
+            ->willReturn(false);
+
+        $this->plugin->handleGetProperties(
+            $propFind,
+            $node
+        );
+
+        $this->assertEquals('false', $propFind->get(FilesPlugin::HAS_PREVIEW_PROPERTYNAME));
+    }
 }

apps/dav/tests/unit/Connector/Sabre/FilesReportPluginTest.php

Indentation +887 added lines, -887 removed lines

@@ -36,891 +36,891 @@
 
 class FilesReportPluginTest extends \Test\TestCase {
 
-	private \Sabre\DAV\Server&MockObject $server;
-	private Tree&MockObject $tree;
-	private ISystemTagObjectMapper&MockObject $tagMapper;
-	private ISystemTagManager&MockObject $tagManager;
-	private ITags&MockObject $privateTags;
-	private ITagManager&MockObject $privateTagManager;
-	private IUserSession&MockObject $userSession;
-	private FilesReportPluginImplementation $plugin;
-	private View&MockObject $view;
-	private IGroupManager&MockObject $groupManager;
-	private Folder&MockObject $userFolder;
-	private IPreview&MockObject $previewManager;
-	private IAppManager&MockObject $appManager;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$this->tree = $this->getMockBuilder(Tree::class)
-			->disableOriginalConstructor()
-			->getMock();
-
-		$this->view = $this->getMockBuilder(View::class)
-			->disableOriginalConstructor()
-			->getMock();
-
-		$this->server = $this->getMockBuilder('\Sabre\DAV\Server')
-			->setConstructorArgs([$this->tree])
-			->onlyMethods(['getRequestUri', 'getBaseUri'])
-			->getMock();
-
-		$this->server->expects($this->any())
-			->method('getBaseUri')
-			->willReturn('http://example.com/owncloud/remote.php/dav');
-
-		$this->groupManager = $this->getMockBuilder(IGroupManager::class)
-			->disableOriginalConstructor()
-			->getMock();
-
-		$this->userFolder = $this->getMockBuilder(Folder::class)
-			->disableOriginalConstructor()
-			->getMock();
-
-		$this->previewManager = $this->getMockBuilder(IPreview::class)
-			->disableOriginalConstructor()
-			->getMock();
-
-		$this->appManager = $this->getMockBuilder(IAppManager::class)
-			->disableOriginalConstructor()
-			->getMock();
-
-		$this->tagManager = $this->createMock(ISystemTagManager::class);
-		$this->tagMapper = $this->createMock(ISystemTagObjectMapper::class);
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->privateTags = $this->createMock(ITags::class);
-		$this->privateTagManager = $this->createMock(ITagManager::class);
-		$this->privateTagManager->expects($this->any())
-			->method('load')
-			->with('files')
-			->willReturn($this->privateTags);
-
-		$user = $this->getMockBuilder(IUser::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$user->expects($this->any())
-			->method('getUID')
-			->willReturn('testuser');
-		$this->userSession->expects($this->any())
-			->method('getUser')
-			->willReturn($user);
-
-		$this->plugin = new FilesReportPluginImplementation(
-			$this->tree,
-			$this->view,
-			$this->tagManager,
-			$this->tagMapper,
-			$this->privateTagManager,
-			$this->userSession,
-			$this->groupManager,
-			$this->userFolder,
-			$this->appManager
-		);
-	}
-
-	public function testOnReportInvalidNode(): void {
-		$path = 'totally/unrelated/13';
-
-		$this->tree->expects($this->any())
-			->method('getNodeForPath')
-			->with('/' . $path)
-			->willReturn(
-				$this->getMockBuilder(INode::class)
-					->disableOriginalConstructor()
-					->getMock()
-			);
-
-		$this->server->expects($this->any())
-			->method('getRequestUri')
-			->willReturn($path);
-		$this->plugin->initialize($this->server);
-
-		$this->assertNull($this->plugin->onReport(FilesReportPluginImplementation::REPORT_NAME, [], '/' . $path));
-	}
-
-	public function testOnReportInvalidReportName(): void {
-		$path = 'test';
-
-		$this->tree->expects($this->any())
-			->method('getNodeForPath')
-			->with('/' . $path)
-			->willReturn(
-				$this->getMockBuilder(INode::class)
-					->disableOriginalConstructor()
-					->getMock()
-			);
-
-		$this->server->expects($this->any())
-			->method('getRequestUri')
-			->willReturn($path);
-		$this->plugin->initialize($this->server);
-
-		$this->assertNull($this->plugin->onReport('{whoever}whatever', [], '/' . $path));
-	}
-
-	public function testOnReport(): void {
-		$path = 'test';
-
-		$parameters = [
-			[
-				'name' => '{DAV:}prop',
-				'value' => [
-					['name' => '{DAV:}getcontentlength', 'value' => ''],
-					['name' => '{http://owncloud.org/ns}size', 'value' => ''],
-				],
-			],
-			[
-				'name' => '{http://owncloud.org/ns}filter-rules',
-				'value' => [
-					['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
-					['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
-				],
-			],
-		];
-
-		$this->groupManager->expects($this->any())
-			->method('isAdmin')
-			->willReturn(true);
-
-		$reportTargetNode = $this->getMockBuilder(Directory::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$reportTargetNode->expects($this->any())
-			->method('getPath')
-			->willReturn('');
-
-		$response = $this->getMockBuilder(ResponseInterface::class)
-			->disableOriginalConstructor()
-			->getMock();
-
-		$response->expects($this->once())
-			->method('setHeader')
-			->with('Content-Type', 'application/xml; charset=utf-8');
-
-		$response->expects($this->once())
-			->method('setStatus')
-			->with(207);
-
-		$response->expects($this->once())
-			->method('setBody');
-
-		$this->tree->expects($this->any())
-			->method('getNodeForPath')
-			->with('/' . $path)
-			->willReturn($reportTargetNode);
-
-		$filesNode1 = $this->createMock(File::class);
-		$filesNode1->expects($this->any())
-			->method('getSize')
-			->willReturn(12);
-		$filesNode2 = $this->createMock(Folder::class);
-		$filesNode2->expects($this->any())
-			->method('getSize')
-			->willReturn(10);
-
-		$tag123 = $this->createMock(ISystemTag::class);
-		$tag123->expects($this->any())
-			->method('getName')
-			->willReturn('OneTwoThree');
-		$tag123->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-		$tag456 = $this->createMock(ISystemTag::class);
-		$tag456->expects($this->any())
-			->method('getName')
-			->willReturn('FourFiveSix');
-		$tag456->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123', '456'])
-			->willReturn([$tag123, $tag456]);
-
-		$this->userFolder->expects($this->exactly(2))
-			->method('searchBySystemTag')
-			->withConsecutive(
-				['OneTwoThree'],
-				['FourFiveSix'],
-			)
-			->willReturnOnConsecutiveCalls(
-				[$filesNode1],
-				[$filesNode2],
-			);
-
-		$this->server->expects($this->any())
-			->method('getRequestUri')
-			->willReturn($path);
-		$this->server->httpResponse = $response;
-		$this->plugin->initialize($this->server);
-
-		$this->assertFalse($this->plugin->onReport(FilesReportPluginImplementation::REPORT_NAME, $parameters, '/' . $path));
-	}
-
-	public function testFindNodesByFileIdsRoot(): void {
-		$filesNode1 = $this->getMockBuilder(Folder::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$filesNode1->expects($this->once())
-			->method('getName')
-			->willReturn('first node');
-
-		$filesNode2 = $this->getMockBuilder(File::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$filesNode2->expects($this->once())
-			->method('getName')
-			->willReturn('second node');
-
-		$reportTargetNode = $this->getMockBuilder(Directory::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$reportTargetNode->expects($this->any())
-			->method('getPath')
-			->willReturn('/');
-
-		$this->userFolder->expects($this->exactly(2))
-			->method('getFirstNodeById')
-			->withConsecutive(
-				['111'],
-				['222'],
-			)
-			->willReturnOnConsecutiveCalls(
-				$filesNode1,
-				$filesNode2,
-			);
-
-		/** @var Directory&MockObject $reportTargetNode */
-		$result = $this->plugin->findNodesByFileIds($reportTargetNode, ['111', '222']);
-
-		$this->assertCount(2, $result);
-		$this->assertInstanceOf('\OCA\DAV\Connector\Sabre\Directory', $result[0]);
-		$this->assertEquals('first node', $result[0]->getName());
-		$this->assertInstanceOf('\OCA\DAV\Connector\Sabre\File', $result[1]);
-		$this->assertEquals('second node', $result[1]->getName());
-	}
-
-	public function testFindNodesByFileIdsSubDir(): void {
-		$filesNode1 = $this->getMockBuilder(Folder::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$filesNode1->expects($this->once())
-			->method('getName')
-			->willReturn('first node');
-
-		$filesNode2 = $this->getMockBuilder(File::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$filesNode2->expects($this->once())
-			->method('getName')
-			->willReturn('second node');
-
-		$reportTargetNode = $this->getMockBuilder(Directory::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$reportTargetNode->expects($this->any())
-			->method('getPath')
-			->willReturn('/sub1/sub2');
-
-
-		$subNode = $this->getMockBuilder(Folder::class)
-			->disableOriginalConstructor()
-			->getMock();
-
-		$this->userFolder->expects($this->once())
-			->method('get')
-			->with('/sub1/sub2')
-			->willReturn($subNode);
-
-		$subNode->expects($this->exactly(2))
-			->method('getFirstNodeById')
-			->withConsecutive(
-				['111'],
-				['222'],
-			)
-			->willReturnOnConsecutiveCalls(
-				$filesNode1,
-				$filesNode2,
-			);
-
-		/** @var Directory&MockObject $reportTargetNode */
-		$result = $this->plugin->findNodesByFileIds($reportTargetNode, ['111', '222']);
-
-		$this->assertCount(2, $result);
-		$this->assertInstanceOf('\OCA\DAV\Connector\Sabre\Directory', $result[0]);
-		$this->assertEquals('first node', $result[0]->getName());
-		$this->assertInstanceOf('\OCA\DAV\Connector\Sabre\File', $result[1]);
-		$this->assertEquals('second node', $result[1]->getName());
-	}
-
-	public function testPrepareResponses(): void {
-		$requestedProps = ['{DAV:}getcontentlength', '{http://owncloud.org/ns}fileid', '{DAV:}resourcetype'];
-
-		$fileInfo = $this->createMock(FileInfo::class);
-		$fileInfo->method('isReadable')->willReturn(true);
-
-		$node1 = $this->getMockBuilder(Directory::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$node2 = $this->getMockBuilder(\OCA\DAV\Connector\Sabre\File::class)
-			->disableOriginalConstructor()
-			->getMock();
-
-		$node1->expects($this->once())
-			->method('getInternalFileId')
-			->willReturn('111');
-		$node1->expects($this->any())
-			->method('getPath')
-			->willReturn('/node1');
-		$node1->method('getFileInfo')->willReturn($fileInfo);
-		$node2->expects($this->once())
-			->method('getInternalFileId')
-			->willReturn('222');
-		$node2->expects($this->once())
-			->method('getSize')
-			->willReturn(1024);
-		$node2->expects($this->any())
-			->method('getPath')
-			->willReturn('/sub/node2');
-		$node2->method('getFileInfo')->willReturn($fileInfo);
-
-		$config = $this->getMockBuilder(IConfig::class)
-			->disableOriginalConstructor()
-			->getMock();
-
-		$validator = $this->createMock(IFilenameValidator::class);
-		$accountManager = $this->createMock(IAccountManager::class);
-
-		$this->server->addPlugin(
-			new FilesPlugin(
-				$this->tree,
-				$config,
-				$this->createMock(IRequest::class),
-				$this->previewManager,
-				$this->createMock(IUserSession::class),
-				$validator,
-				$accountManager,
-			)
-		);
-		$this->plugin->initialize($this->server);
-		$responses = $this->plugin->prepareResponses('/files/username', $requestedProps, [$node1, $node2]);
-
-		$this->assertCount(2, $responses);
-
-		$this->assertEquals('http://example.com/owncloud/remote.php/dav/files/username/node1', $responses[0]->getHref());
-		$this->assertEquals('http://example.com/owncloud/remote.php/dav/files/username/sub/node2', $responses[1]->getHref());
-
-		$props1 = $responses[0]->getResponseProperties();
-		$this->assertEquals('111', $props1[200]['{http://owncloud.org/ns}fileid']);
-		$this->assertNull($props1[404]['{DAV:}getcontentlength']);
-		$this->assertInstanceOf('\Sabre\DAV\Xml\Property\ResourceType', $props1[200]['{DAV:}resourcetype']);
-		$resourceType1 = $props1[200]['{DAV:}resourcetype']->getValue();
-		$this->assertEquals('{DAV:}collection', $resourceType1[0]);
-
-		$props2 = $responses[1]->getResponseProperties();
-		$this->assertEquals('1024', $props2[200]['{DAV:}getcontentlength']);
-		$this->assertEquals('222', $props2[200]['{http://owncloud.org/ns}fileid']);
-		$this->assertInstanceOf('\Sabre\DAV\Xml\Property\ResourceType', $props2[200]['{DAV:}resourcetype']);
-		$this->assertCount(0, $props2[200]['{DAV:}resourcetype']->getValue());
-	}
-
-	public function testProcessFilterRulesSingle(): void {
-		$this->groupManager->expects($this->any())
-			->method('isAdmin')
-			->willReturn(true);
-
-		$rules = [
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
-		];
-
-		$filesNode1 = $this->createMock(File::class);
-		$filesNode1->expects($this->any())
-			->method('getSize')
-			->willReturn(12);
-		$filesNode2 = $this->createMock(Folder::class);
-		$filesNode2->expects($this->any())
-			->method('getSize')
-			->willReturn(10);
-
-		$tag123 = $this->createMock(ISystemTag::class);
-		$tag123->expects($this->any())
-			->method('getName')
-			->willReturn('OneTwoThree');
-		$tag123->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123'])
-			->willReturn([$tag123]);
-
-		$this->userFolder->expects($this->once())
-			->method('searchBySystemTag')
-			->with('OneTwoThree')
-			->willReturn([$filesNode1, $filesNode2]);
-
-		$this->assertEquals([$filesNode1, $filesNode2], $this->invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, 0, 0]));
-	}
-
-	public function testProcessFilterRulesAndCondition(): void {
-		$this->groupManager->expects($this->any())
-			->method('isAdmin')
-			->willReturn(true);
-
-		$filesNode1 = $this->createMock(File::class);
-		$filesNode1->expects($this->any())
-			->method('getSize')
-			->willReturn(12);
-		$filesNode1->expects($this->any())
-			->method('getId')
-			->willReturn(111);
-		$filesNode2 = $this->createMock(Folder::class);
-		$filesNode2->expects($this->any())
-			->method('getSize')
-			->willReturn(10);
-		$filesNode2->expects($this->any())
-			->method('getId')
-			->willReturn(222);
-		$filesNode3 = $this->createMock(File::class);
-		$filesNode3->expects($this->any())
-			->method('getSize')
-			->willReturn(14);
-		$filesNode3->expects($this->any())
-			->method('getId')
-			->willReturn(333);
-
-		$tag123 = $this->createMock(ISystemTag::class);
-		$tag123->expects($this->any())
-			->method('getName')
-			->willReturn('OneTwoThree');
-		$tag123->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-		$tag456 = $this->createMock(ISystemTag::class);
-		$tag456->expects($this->any())
-			->method('getName')
-			->willReturn('FourFiveSix');
-		$tag456->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123', '456'])
-			->willReturn([$tag123, $tag456]);
-
-		$this->userFolder->expects($this->exactly(2))
-			->method('searchBySystemTag')
-			->withConsecutive(
-				['OneTwoThree'],
-				['FourFiveSix'],
-			)
-			->willReturnOnConsecutiveCalls(
-				[$filesNode1, $filesNode2],
-				[$filesNode2, $filesNode3],
-			);
-
-		$rules = [
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
-		];
-
-		$this->assertEquals([$filesNode2], array_values($this->invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null])));
-	}
-
-	public function testProcessFilterRulesAndConditionWithOneEmptyResult(): void {
-		$this->groupManager->expects($this->any())
-			->method('isAdmin')
-			->willReturn(true);
-
-		$filesNode1 = $this->createMock(File::class);
-		$filesNode1->expects($this->any())
-			->method('getSize')
-			->willReturn(12);
-		$filesNode1->expects($this->any())
-			->method('getId')
-			->willReturn(111);
-		$filesNode2 = $this->createMock(Folder::class);
-		$filesNode2->expects($this->any())
-			->method('getSize')
-			->willReturn(10);
-		$filesNode2->expects($this->any())
-			->method('getId')
-			->willReturn(222);
-
-		$tag123 = $this->createMock(ISystemTag::class);
-		$tag123->expects($this->any())
-			->method('getName')
-			->willReturn('OneTwoThree');
-		$tag123->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-		$tag456 = $this->createMock(ISystemTag::class);
-		$tag456->expects($this->any())
-			->method('getName')
-			->willReturn('FourFiveSix');
-		$tag456->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123', '456'])
-			->willReturn([$tag123, $tag456]);
-
-		$this->userFolder->expects($this->exactly(2))
-			->method('searchBySystemTag')
-			->withConsecutive(
-				['OneTwoThree'],
-				['FourFiveSix'],
-			)
-			->willReturnOnConsecutiveCalls(
-				[$filesNode1, $filesNode2],
-				[],
-			);
-
-		$rules = [
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
-		];
-
-		$this->assertEquals([], $this->invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null]));
-	}
-
-	public function testProcessFilterRulesAndConditionWithFirstEmptyResult(): void {
-		$this->groupManager->expects($this->any())
-			->method('isAdmin')
-			->willReturn(true);
-
-		$filesNode1 = $this->createMock(File::class);
-		$filesNode1->expects($this->any())
-			->method('getSize')
-			->willReturn(12);
-		$filesNode1->expects($this->any())
-			->method('getId')
-			->willReturn(111);
-		$filesNode2 = $this->createMock(Folder::class);
-		$filesNode2->expects($this->any())
-			->method('getSize')
-			->willReturn(10);
-		$filesNode2->expects($this->any())
-			->method('getId')
-			->willReturn(222);
-
-		$tag123 = $this->createMock(ISystemTag::class);
-		$tag123->expects($this->any())
-			->method('getName')
-			->willReturn('OneTwoThree');
-		$tag123->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-		$tag456 = $this->createMock(ISystemTag::class);
-		$tag456->expects($this->any())
-			->method('getName')
-			->willReturn('FourFiveSix');
-		$tag456->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123', '456'])
-			->willReturn([$tag123, $tag456]);
-
-		$this->userFolder->expects($this->once())
-			->method('searchBySystemTag')
-			->with('OneTwoThree')
-			->willReturnOnConsecutiveCalls(
-				[],
-				[$filesNode1, $filesNode2],
-			);
-
-		$rules = [
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
-		];
-
-		$this->assertEquals([], $this->invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null]));
-	}
-
-	public function testProcessFilterRulesAndConditionWithEmptyMidResult(): void {
-		$this->groupManager->expects($this->any())
-			->method('isAdmin')
-			->willReturn(true);
-
-		$filesNode1 = $this->createMock(File::class);
-		$filesNode1->expects($this->any())
-			->method('getSize')
-			->willReturn(12);
-		$filesNode1->expects($this->any())
-			->method('getId')
-			->willReturn(111);
-		$filesNode2 = $this->createMock(Folder::class);
-		$filesNode2->expects($this->any())
-			->method('getSize')
-			->willReturn(10);
-		$filesNode2->expects($this->any())
-			->method('getId')
-			->willReturn(222);
-		$filesNode3 = $this->createMock(Folder::class);
-		$filesNode3->expects($this->any())
-			->method('getSize')
-			->willReturn(13);
-		$filesNode3->expects($this->any())
-			->method('getId')
-			->willReturn(333);
-
-		$tag123 = $this->createMock(ISystemTag::class);
-		$tag123->expects($this->any())
-			->method('getName')
-			->willReturn('OneTwoThree');
-		$tag123->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-		$tag456 = $this->createMock(ISystemTag::class);
-		$tag456->expects($this->any())
-			->method('getName')
-			->willReturn('FourFiveSix');
-		$tag456->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-		$tag789 = $this->createMock(ISystemTag::class);
-		$tag789->expects($this->any())
-			->method('getName')
-			->willReturn('SevenEightNein');
-		$tag789->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123', '456', '789'])
-			->willReturn([$tag123, $tag456, $tag789]);
-
-		$this->userFolder->expects($this->exactly(2))
-			->method('searchBySystemTag')
-			->withConsecutive(['OneTwoThree'], ['FourFiveSix'], ['SevenEightNein'])
-			->willReturnOnConsecutiveCalls(
-				[$filesNode1, $filesNode2],
-				[$filesNode3],
-				[$filesNode1, $filesNode2],
-			);
-
-		$rules = [
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '789'],
-		];
-
-		$this->assertEquals([], array_values($this->invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null])));
-	}
-
-	public function testProcessFilterRulesInvisibleTagAsAdmin(): void {
-		$this->groupManager->expects($this->any())
-			->method('isAdmin')
-			->willReturn(true);
-
-		$filesNode1 = $this->createMock(File::class);
-		$filesNode1->expects($this->any())
-			->method('getSize')
-			->willReturn(12);
-		$filesNode1->expects($this->any())
-			->method('getId')
-			->willReturn(111);
-		$filesNode2 = $this->createMock(Folder::class);
-		$filesNode2->expects($this->any())
-			->method('getSize')
-			->willReturn(10);
-		$filesNode2->expects($this->any())
-			->method('getId')
-			->willReturn(222);
-		$filesNode3 = $this->createMock(Folder::class);
-		$filesNode3->expects($this->any())
-			->method('getSize')
-			->willReturn(13);
-		$filesNode3->expects($this->any())
-			->method('getId')
-			->willReturn(333);
-
-		$tag123 = $this->createMock(ISystemTag::class);
-		$tag123->expects($this->any())
-			->method('getName')
-			->willReturn('OneTwoThree');
-		$tag123->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-		$tag456 = $this->createMock(ISystemTag::class);
-		$tag456->expects($this->any())
-			->method('getName')
-			->willReturn('FourFiveSix');
-		$tag456->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(false);
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123', '456'])
-			->willReturn([$tag123, $tag456]);
-
-		$this->userFolder->expects($this->exactly(2))
-			->method('searchBySystemTag')
-			->withConsecutive(['OneTwoThree'], ['FourFiveSix'])
-			->willReturnOnConsecutiveCalls(
-				[$filesNode1, $filesNode2],
-				[$filesNode2, $filesNode3],
-			);
-
-		$rules = [
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
-		];
-
-		$this->assertEquals([$filesNode2], array_values($this->invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null])));
-	}
-
-
-	public function testProcessFilterRulesInvisibleTagAsUser(): void {
-		$this->expectException(TagNotFoundException::class);
-
-		$this->groupManager->expects($this->any())
-			->method('isAdmin')
-			->willReturn(false);
-
-		$tag123 = $this->createMock(ISystemTag::class);
-		$tag123->expects($this->any())
-			->method('getName')
-			->willReturn('OneTwoThree');
-		$tag123->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-		$tag456 = $this->createMock(ISystemTag::class);
-		$tag456->expects($this->any())
-			->method('getName')
-			->willReturn('FourFiveSix');
-		$tag456->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(false);
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123', '456'])
-			->willThrowException(new TagNotFoundException());
-
-		$this->userFolder->expects($this->never())
-			->method('searchBySystemTag');
-
-		$rules = [
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
-		];
-
-		$this->invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null]);
-	}
-
-	public function testProcessFilterRulesVisibleTagAsUser(): void {
-		$this->groupManager->expects($this->any())
-			->method('isAdmin')
-			->willReturn(false);
-
-		$tag1 = $this->createMock(ISystemTag::class);
-		$tag1->expects($this->any())
-			->method('getId')
-			->willReturn('123');
-		$tag1->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-		$tag1->expects($this->any())
-			->method('getName')
-			->willReturn('OneTwoThree');
-
-		$tag2 = $this->createMock(ISystemTag::class);
-		$tag2->expects($this->any())
-			->method('getId')
-			->willReturn('123');
-		$tag2->expects($this->any())
-			->method('isUserVisible')
-			->willReturn(true);
-		$tag2->expects($this->any())
-			->method('getName')
-			->willReturn('FourFiveSix');
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123', '456'])
-			->willReturn([$tag1, $tag2]);
-
-		$filesNode1 = $this->createMock(File::class);
-		$filesNode1->expects($this->any())
-			->method('getId')
-			->willReturn(111);
-		$filesNode1->expects($this->any())
-			->method('getSize')
-			->willReturn(12);
-		$filesNode2 = $this->createMock(Folder::class);
-		$filesNode2->expects($this->any())
-			->method('getId')
-			->willReturn(222);
-		$filesNode2->expects($this->any())
-			->method('getSize')
-			->willReturn(10);
-		$filesNode3 = $this->createMock(Folder::class);
-		$filesNode3->expects($this->any())
-			->method('getId')
-			->willReturn(333);
-		$filesNode3->expects($this->any())
-			->method('getSize')
-			->willReturn(33);
-
-		$this->tagManager->expects($this->once())
-			->method('getTagsByIds')
-			->with(['123', '456'])
-			->willReturn([$tag1, $tag2]);
-
-		// main assertion: only user visible tags are being passed through.
-		$this->userFolder->expects($this->exactly(2))
-			->method('searchBySystemTag')
-			->withConsecutive(['OneTwoThree'], ['FourFiveSix'])
-			->willReturnOnConsecutiveCalls(
-				[$filesNode1, $filesNode2],
-				[$filesNode2, $filesNode3],
-			);
-
-		$rules = [
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
-			['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
-		];
-
-		$this->assertEquals([$filesNode2], array_values($this->invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null])));
-	}
-
-	public function testProcessFavoriteFilter(): void {
-		$rules = [
-			['name' => '{http://owncloud.org/ns}favorite', 'value' => '1'],
-		];
-
-		$this->privateTags->expects($this->once())
-			->method('getFavorites')
-			->willReturn(['456', '789']);
-
-		$this->assertEquals(['456', '789'], array_values($this->invokePrivate($this->plugin, 'processFilterRulesForFileIDs', [$rules])));
-	}
-
-	public function filesBaseUriProvider() {
-		return [
-			['', '', ''],
-			['files/username', '', '/files/username'],
-			['files/username/test', '/test', '/files/username'],
-			['files/username/test/sub', '/test/sub', '/files/username'],
-			['test', '/test', ''],
-		];
-	}
-
-	/**
-	 * @dataProvider filesBaseUriProvider
-	 */
-	public function testFilesBaseUri($uri, $reportPath, $expectedUri): void {
-		$this->assertEquals($expectedUri, $this->invokePrivate($this->plugin, 'getFilesBaseUri', [$uri, $reportPath]));
-	}
+    private \Sabre\DAV\Server&MockObject $server;
+    private Tree&MockObject $tree;
+    private ISystemTagObjectMapper&MockObject $tagMapper;
+    private ISystemTagManager&MockObject $tagManager;
+    private ITags&MockObject $privateTags;
+    private ITagManager&MockObject $privateTagManager;
+    private IUserSession&MockObject $userSession;
+    private FilesReportPluginImplementation $plugin;
+    private View&MockObject $view;
+    private IGroupManager&MockObject $groupManager;
+    private Folder&MockObject $userFolder;
+    private IPreview&MockObject $previewManager;
+    private IAppManager&MockObject $appManager;
+
+    protected function setUp(): void {
+        parent::setUp();
+        $this->tree = $this->getMockBuilder(Tree::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $this->view = $this->getMockBuilder(View::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $this->server = $this->getMockBuilder('\Sabre\DAV\Server')
+            ->setConstructorArgs([$this->tree])
+            ->onlyMethods(['getRequestUri', 'getBaseUri'])
+            ->getMock();
+
+        $this->server->expects($this->any())
+            ->method('getBaseUri')
+            ->willReturn('http://example.com/owncloud/remote.php/dav');
+
+        $this->groupManager = $this->getMockBuilder(IGroupManager::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $this->userFolder = $this->getMockBuilder(Folder::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $this->previewManager = $this->getMockBuilder(IPreview::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $this->appManager = $this->getMockBuilder(IAppManager::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $this->tagManager = $this->createMock(ISystemTagManager::class);
+        $this->tagMapper = $this->createMock(ISystemTagObjectMapper::class);
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->privateTags = $this->createMock(ITags::class);
+        $this->privateTagManager = $this->createMock(ITagManager::class);
+        $this->privateTagManager->expects($this->any())
+            ->method('load')
+            ->with('files')
+            ->willReturn($this->privateTags);
+
+        $user = $this->getMockBuilder(IUser::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('testuser');
+        $this->userSession->expects($this->any())
+            ->method('getUser')
+            ->willReturn($user);
+
+        $this->plugin = new FilesReportPluginImplementation(
+            $this->tree,
+            $this->view,
+            $this->tagManager,
+            $this->tagMapper,
+            $this->privateTagManager,
+            $this->userSession,
+            $this->groupManager,
+            $this->userFolder,
+            $this->appManager
+        );
+    }
+
+    public function testOnReportInvalidNode(): void {
+        $path = 'totally/unrelated/13';
+
+        $this->tree->expects($this->any())
+            ->method('getNodeForPath')
+            ->with('/' . $path)
+            ->willReturn(
+                $this->getMockBuilder(INode::class)
+                    ->disableOriginalConstructor()
+                    ->getMock()
+            );
+
+        $this->server->expects($this->any())
+            ->method('getRequestUri')
+            ->willReturn($path);
+        $this->plugin->initialize($this->server);
+
+        $this->assertNull($this->plugin->onReport(FilesReportPluginImplementation::REPORT_NAME, [], '/' . $path));
+    }
+
+    public function testOnReportInvalidReportName(): void {
+        $path = 'test';
+
+        $this->tree->expects($this->any())
+            ->method('getNodeForPath')
+            ->with('/' . $path)
+            ->willReturn(
+                $this->getMockBuilder(INode::class)
+                    ->disableOriginalConstructor()
+                    ->getMock()
+            );
+
+        $this->server->expects($this->any())
+            ->method('getRequestUri')
+            ->willReturn($path);
+        $this->plugin->initialize($this->server);
+
+        $this->assertNull($this->plugin->onReport('{whoever}whatever', [], '/' . $path));
+    }
+
+    public function testOnReport(): void {
+        $path = 'test';
+
+        $parameters = [
+            [
+                'name' => '{DAV:}prop',
+                'value' => [
+                    ['name' => '{DAV:}getcontentlength', 'value' => ''],
+                    ['name' => '{http://owncloud.org/ns}size', 'value' => ''],
+                ],
+            ],
+            [
+                'name' => '{http://owncloud.org/ns}filter-rules',
+                'value' => [
+                    ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
+                    ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
+                ],
+            ],
+        ];
+
+        $this->groupManager->expects($this->any())
+            ->method('isAdmin')
+            ->willReturn(true);
+
+        $reportTargetNode = $this->getMockBuilder(Directory::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $reportTargetNode->expects($this->any())
+            ->method('getPath')
+            ->willReturn('');
+
+        $response = $this->getMockBuilder(ResponseInterface::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $response->expects($this->once())
+            ->method('setHeader')
+            ->with('Content-Type', 'application/xml; charset=utf-8');
+
+        $response->expects($this->once())
+            ->method('setStatus')
+            ->with(207);
+
+        $response->expects($this->once())
+            ->method('setBody');
+
+        $this->tree->expects($this->any())
+            ->method('getNodeForPath')
+            ->with('/' . $path)
+            ->willReturn($reportTargetNode);
+
+        $filesNode1 = $this->createMock(File::class);
+        $filesNode1->expects($this->any())
+            ->method('getSize')
+            ->willReturn(12);
+        $filesNode2 = $this->createMock(Folder::class);
+        $filesNode2->expects($this->any())
+            ->method('getSize')
+            ->willReturn(10);
+
+        $tag123 = $this->createMock(ISystemTag::class);
+        $tag123->expects($this->any())
+            ->method('getName')
+            ->willReturn('OneTwoThree');
+        $tag123->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+        $tag456 = $this->createMock(ISystemTag::class);
+        $tag456->expects($this->any())
+            ->method('getName')
+            ->willReturn('FourFiveSix');
+        $tag456->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123', '456'])
+            ->willReturn([$tag123, $tag456]);
+
+        $this->userFolder->expects($this->exactly(2))
+            ->method('searchBySystemTag')
+            ->withConsecutive(
+                ['OneTwoThree'],
+                ['FourFiveSix'],
+            )
+            ->willReturnOnConsecutiveCalls(
+                [$filesNode1],
+                [$filesNode2],
+            );
+
+        $this->server->expects($this->any())
+            ->method('getRequestUri')
+            ->willReturn($path);
+        $this->server->httpResponse = $response;
+        $this->plugin->initialize($this->server);
+
+        $this->assertFalse($this->plugin->onReport(FilesReportPluginImplementation::REPORT_NAME, $parameters, '/' . $path));
+    }
+
+    public function testFindNodesByFileIdsRoot(): void {
+        $filesNode1 = $this->getMockBuilder(Folder::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $filesNode1->expects($this->once())
+            ->method('getName')
+            ->willReturn('first node');
+
+        $filesNode2 = $this->getMockBuilder(File::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $filesNode2->expects($this->once())
+            ->method('getName')
+            ->willReturn('second node');
+
+        $reportTargetNode = $this->getMockBuilder(Directory::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $reportTargetNode->expects($this->any())
+            ->method('getPath')
+            ->willReturn('/');
+
+        $this->userFolder->expects($this->exactly(2))
+            ->method('getFirstNodeById')
+            ->withConsecutive(
+                ['111'],
+                ['222'],
+            )
+            ->willReturnOnConsecutiveCalls(
+                $filesNode1,
+                $filesNode2,
+            );
+
+        /** @var Directory&MockObject $reportTargetNode */
+        $result = $this->plugin->findNodesByFileIds($reportTargetNode, ['111', '222']);
+
+        $this->assertCount(2, $result);
+        $this->assertInstanceOf('\OCA\DAV\Connector\Sabre\Directory', $result[0]);
+        $this->assertEquals('first node', $result[0]->getName());
+        $this->assertInstanceOf('\OCA\DAV\Connector\Sabre\File', $result[1]);
+        $this->assertEquals('second node', $result[1]->getName());
+    }
+
+    public function testFindNodesByFileIdsSubDir(): void {
+        $filesNode1 = $this->getMockBuilder(Folder::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $filesNode1->expects($this->once())
+            ->method('getName')
+            ->willReturn('first node');
+
+        $filesNode2 = $this->getMockBuilder(File::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $filesNode2->expects($this->once())
+            ->method('getName')
+            ->willReturn('second node');
+
+        $reportTargetNode = $this->getMockBuilder(Directory::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $reportTargetNode->expects($this->any())
+            ->method('getPath')
+            ->willReturn('/sub1/sub2');
+
+
+        $subNode = $this->getMockBuilder(Folder::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $this->userFolder->expects($this->once())
+            ->method('get')
+            ->with('/sub1/sub2')
+            ->willReturn($subNode);
+
+        $subNode->expects($this->exactly(2))
+            ->method('getFirstNodeById')
+            ->withConsecutive(
+                ['111'],
+                ['222'],
+            )
+            ->willReturnOnConsecutiveCalls(
+                $filesNode1,
+                $filesNode2,
+            );
+
+        /** @var Directory&MockObject $reportTargetNode */
+        $result = $this->plugin->findNodesByFileIds($reportTargetNode, ['111', '222']);
+
+        $this->assertCount(2, $result);
+        $this->assertInstanceOf('\OCA\DAV\Connector\Sabre\Directory', $result[0]);
+        $this->assertEquals('first node', $result[0]->getName());
+        $this->assertInstanceOf('\OCA\DAV\Connector\Sabre\File', $result[1]);
+        $this->assertEquals('second node', $result[1]->getName());
+    }
+
+    public function testPrepareResponses(): void {
+        $requestedProps = ['{DAV:}getcontentlength', '{http://owncloud.org/ns}fileid', '{DAV:}resourcetype'];
+
+        $fileInfo = $this->createMock(FileInfo::class);
+        $fileInfo->method('isReadable')->willReturn(true);
+
+        $node1 = $this->getMockBuilder(Directory::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $node2 = $this->getMockBuilder(\OCA\DAV\Connector\Sabre\File::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $node1->expects($this->once())
+            ->method('getInternalFileId')
+            ->willReturn('111');
+        $node1->expects($this->any())
+            ->method('getPath')
+            ->willReturn('/node1');
+        $node1->method('getFileInfo')->willReturn($fileInfo);
+        $node2->expects($this->once())
+            ->method('getInternalFileId')
+            ->willReturn('222');
+        $node2->expects($this->once())
+            ->method('getSize')
+            ->willReturn(1024);
+        $node2->expects($this->any())
+            ->method('getPath')
+            ->willReturn('/sub/node2');
+        $node2->method('getFileInfo')->willReturn($fileInfo);
+
+        $config = $this->getMockBuilder(IConfig::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $validator = $this->createMock(IFilenameValidator::class);
+        $accountManager = $this->createMock(IAccountManager::class);
+
+        $this->server->addPlugin(
+            new FilesPlugin(
+                $this->tree,
+                $config,
+                $this->createMock(IRequest::class),
+                $this->previewManager,
+                $this->createMock(IUserSession::class),
+                $validator,
+                $accountManager,
+            )
+        );
+        $this->plugin->initialize($this->server);
+        $responses = $this->plugin->prepareResponses('/files/username', $requestedProps, [$node1, $node2]);
+
+        $this->assertCount(2, $responses);
+
+        $this->assertEquals('http://example.com/owncloud/remote.php/dav/files/username/node1', $responses[0]->getHref());
+        $this->assertEquals('http://example.com/owncloud/remote.php/dav/files/username/sub/node2', $responses[1]->getHref());
+
+        $props1 = $responses[0]->getResponseProperties();
+        $this->assertEquals('111', $props1[200]['{http://owncloud.org/ns}fileid']);
+        $this->assertNull($props1[404]['{DAV:}getcontentlength']);
+        $this->assertInstanceOf('\Sabre\DAV\Xml\Property\ResourceType', $props1[200]['{DAV:}resourcetype']);
+        $resourceType1 = $props1[200]['{DAV:}resourcetype']->getValue();
+        $this->assertEquals('{DAV:}collection', $resourceType1[0]);
+
+        $props2 = $responses[1]->getResponseProperties();
+        $this->assertEquals('1024', $props2[200]['{DAV:}getcontentlength']);
+        $this->assertEquals('222', $props2[200]['{http://owncloud.org/ns}fileid']);
+        $this->assertInstanceOf('\Sabre\DAV\Xml\Property\ResourceType', $props2[200]['{DAV:}resourcetype']);
+        $this->assertCount(0, $props2[200]['{DAV:}resourcetype']->getValue());
+    }
+
+    public function testProcessFilterRulesSingle(): void {
+        $this->groupManager->expects($this->any())
+            ->method('isAdmin')
+            ->willReturn(true);
+
+        $rules = [
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
+        ];
+
+        $filesNode1 = $this->createMock(File::class);
+        $filesNode1->expects($this->any())
+            ->method('getSize')
+            ->willReturn(12);
+        $filesNode2 = $this->createMock(Folder::class);
+        $filesNode2->expects($this->any())
+            ->method('getSize')
+            ->willReturn(10);
+
+        $tag123 = $this->createMock(ISystemTag::class);
+        $tag123->expects($this->any())
+            ->method('getName')
+            ->willReturn('OneTwoThree');
+        $tag123->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123'])
+            ->willReturn([$tag123]);
+
+        $this->userFolder->expects($this->once())
+            ->method('searchBySystemTag')
+            ->with('OneTwoThree')
+            ->willReturn([$filesNode1, $filesNode2]);
+
+        $this->assertEquals([$filesNode1, $filesNode2], $this->invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, 0, 0]));
+    }
+
+    public function testProcessFilterRulesAndCondition(): void {
+        $this->groupManager->expects($this->any())
+            ->method('isAdmin')
+            ->willReturn(true);
+
+        $filesNode1 = $this->createMock(File::class);
+        $filesNode1->expects($this->any())
+            ->method('getSize')
+            ->willReturn(12);
+        $filesNode1->expects($this->any())
+            ->method('getId')
+            ->willReturn(111);
+        $filesNode2 = $this->createMock(Folder::class);
+        $filesNode2->expects($this->any())
+            ->method('getSize')
+            ->willReturn(10);
+        $filesNode2->expects($this->any())
+            ->method('getId')
+            ->willReturn(222);
+        $filesNode3 = $this->createMock(File::class);
+        $filesNode3->expects($this->any())
+            ->method('getSize')
+            ->willReturn(14);
+        $filesNode3->expects($this->any())
+            ->method('getId')
+            ->willReturn(333);
+
+        $tag123 = $this->createMock(ISystemTag::class);
+        $tag123->expects($this->any())
+            ->method('getName')
+            ->willReturn('OneTwoThree');
+        $tag123->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+        $tag456 = $this->createMock(ISystemTag::class);
+        $tag456->expects($this->any())
+            ->method('getName')
+            ->willReturn('FourFiveSix');
+        $tag456->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123', '456'])
+            ->willReturn([$tag123, $tag456]);
+
+        $this->userFolder->expects($this->exactly(2))
+            ->method('searchBySystemTag')
+            ->withConsecutive(
+                ['OneTwoThree'],
+                ['FourFiveSix'],
+            )
+            ->willReturnOnConsecutiveCalls(
+                [$filesNode1, $filesNode2],
+                [$filesNode2, $filesNode3],
+            );
+
+        $rules = [
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
+        ];
+
+        $this->assertEquals([$filesNode2], array_values($this->invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null])));
+    }
+
+    public function testProcessFilterRulesAndConditionWithOneEmptyResult(): void {
+        $this->groupManager->expects($this->any())
+            ->method('isAdmin')
+            ->willReturn(true);
+
+        $filesNode1 = $this->createMock(File::class);
+        $filesNode1->expects($this->any())
+            ->method('getSize')
+            ->willReturn(12);
+        $filesNode1->expects($this->any())
+            ->method('getId')
+            ->willReturn(111);
+        $filesNode2 = $this->createMock(Folder::class);
+        $filesNode2->expects($this->any())
+            ->method('getSize')
+            ->willReturn(10);
+        $filesNode2->expects($this->any())
+            ->method('getId')
+            ->willReturn(222);
+
+        $tag123 = $this->createMock(ISystemTag::class);
+        $tag123->expects($this->any())
+            ->method('getName')
+            ->willReturn('OneTwoThree');
+        $tag123->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+        $tag456 = $this->createMock(ISystemTag::class);
+        $tag456->expects($this->any())
+            ->method('getName')
+            ->willReturn('FourFiveSix');
+        $tag456->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123', '456'])
+            ->willReturn([$tag123, $tag456]);
+
+        $this->userFolder->expects($this->exactly(2))
+            ->method('searchBySystemTag')
+            ->withConsecutive(
+                ['OneTwoThree'],
+                ['FourFiveSix'],
+            )
+            ->willReturnOnConsecutiveCalls(
+                [$filesNode1, $filesNode2],
+                [],
+            );
+
+        $rules = [
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
+        ];
+
+        $this->assertEquals([], $this->invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null]));
+    }
+
+    public function testProcessFilterRulesAndConditionWithFirstEmptyResult(): void {
+        $this->groupManager->expects($this->any())
+            ->method('isAdmin')
+            ->willReturn(true);
+
+        $filesNode1 = $this->createMock(File::class);
+        $filesNode1->expects($this->any())
+            ->method('getSize')
+            ->willReturn(12);
+        $filesNode1->expects($this->any())
+            ->method('getId')
+            ->willReturn(111);
+        $filesNode2 = $this->createMock(Folder::class);
+        $filesNode2->expects($this->any())
+            ->method('getSize')
+            ->willReturn(10);
+        $filesNode2->expects($this->any())
+            ->method('getId')
+            ->willReturn(222);
+
+        $tag123 = $this->createMock(ISystemTag::class);
+        $tag123->expects($this->any())
+            ->method('getName')
+            ->willReturn('OneTwoThree');
+        $tag123->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+        $tag456 = $this->createMock(ISystemTag::class);
+        $tag456->expects($this->any())
+            ->method('getName')
+            ->willReturn('FourFiveSix');
+        $tag456->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123', '456'])
+            ->willReturn([$tag123, $tag456]);
+
+        $this->userFolder->expects($this->once())
+            ->method('searchBySystemTag')
+            ->with('OneTwoThree')
+            ->willReturnOnConsecutiveCalls(
+                [],
+                [$filesNode1, $filesNode2],
+            );
+
+        $rules = [
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
+        ];
+
+        $this->assertEquals([], $this->invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null]));
+    }
+
+    public function testProcessFilterRulesAndConditionWithEmptyMidResult(): void {
+        $this->groupManager->expects($this->any())
+            ->method('isAdmin')
+            ->willReturn(true);
+
+        $filesNode1 = $this->createMock(File::class);
+        $filesNode1->expects($this->any())
+            ->method('getSize')
+            ->willReturn(12);
+        $filesNode1->expects($this->any())
+            ->method('getId')
+            ->willReturn(111);
+        $filesNode2 = $this->createMock(Folder::class);
+        $filesNode2->expects($this->any())
+            ->method('getSize')
+            ->willReturn(10);
+        $filesNode2->expects($this->any())
+            ->method('getId')
+            ->willReturn(222);
+        $filesNode3 = $this->createMock(Folder::class);
+        $filesNode3->expects($this->any())
+            ->method('getSize')
+            ->willReturn(13);
+        $filesNode3->expects($this->any())
+            ->method('getId')
+            ->willReturn(333);
+
+        $tag123 = $this->createMock(ISystemTag::class);
+        $tag123->expects($this->any())
+            ->method('getName')
+            ->willReturn('OneTwoThree');
+        $tag123->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+        $tag456 = $this->createMock(ISystemTag::class);
+        $tag456->expects($this->any())
+            ->method('getName')
+            ->willReturn('FourFiveSix');
+        $tag456->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+        $tag789 = $this->createMock(ISystemTag::class);
+        $tag789->expects($this->any())
+            ->method('getName')
+            ->willReturn('SevenEightNein');
+        $tag789->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123', '456', '789'])
+            ->willReturn([$tag123, $tag456, $tag789]);
+
+        $this->userFolder->expects($this->exactly(2))
+            ->method('searchBySystemTag')
+            ->withConsecutive(['OneTwoThree'], ['FourFiveSix'], ['SevenEightNein'])
+            ->willReturnOnConsecutiveCalls(
+                [$filesNode1, $filesNode2],
+                [$filesNode3],
+                [$filesNode1, $filesNode2],
+            );
+
+        $rules = [
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '789'],
+        ];
+
+        $this->assertEquals([], array_values($this->invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null])));
+    }
+
+    public function testProcessFilterRulesInvisibleTagAsAdmin(): void {
+        $this->groupManager->expects($this->any())
+            ->method('isAdmin')
+            ->willReturn(true);
+
+        $filesNode1 = $this->createMock(File::class);
+        $filesNode1->expects($this->any())
+            ->method('getSize')
+            ->willReturn(12);
+        $filesNode1->expects($this->any())
+            ->method('getId')
+            ->willReturn(111);
+        $filesNode2 = $this->createMock(Folder::class);
+        $filesNode2->expects($this->any())
+            ->method('getSize')
+            ->willReturn(10);
+        $filesNode2->expects($this->any())
+            ->method('getId')
+            ->willReturn(222);
+        $filesNode3 = $this->createMock(Folder::class);
+        $filesNode3->expects($this->any())
+            ->method('getSize')
+            ->willReturn(13);
+        $filesNode3->expects($this->any())
+            ->method('getId')
+            ->willReturn(333);
+
+        $tag123 = $this->createMock(ISystemTag::class);
+        $tag123->expects($this->any())
+            ->method('getName')
+            ->willReturn('OneTwoThree');
+        $tag123->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+        $tag456 = $this->createMock(ISystemTag::class);
+        $tag456->expects($this->any())
+            ->method('getName')
+            ->willReturn('FourFiveSix');
+        $tag456->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(false);
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123', '456'])
+            ->willReturn([$tag123, $tag456]);
+
+        $this->userFolder->expects($this->exactly(2))
+            ->method('searchBySystemTag')
+            ->withConsecutive(['OneTwoThree'], ['FourFiveSix'])
+            ->willReturnOnConsecutiveCalls(
+                [$filesNode1, $filesNode2],
+                [$filesNode2, $filesNode3],
+            );
+
+        $rules = [
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
+        ];
+
+        $this->assertEquals([$filesNode2], array_values($this->invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null])));
+    }
+
+
+    public function testProcessFilterRulesInvisibleTagAsUser(): void {
+        $this->expectException(TagNotFoundException::class);
+
+        $this->groupManager->expects($this->any())
+            ->method('isAdmin')
+            ->willReturn(false);
+
+        $tag123 = $this->createMock(ISystemTag::class);
+        $tag123->expects($this->any())
+            ->method('getName')
+            ->willReturn('OneTwoThree');
+        $tag123->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+        $tag456 = $this->createMock(ISystemTag::class);
+        $tag456->expects($this->any())
+            ->method('getName')
+            ->willReturn('FourFiveSix');
+        $tag456->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(false);
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123', '456'])
+            ->willThrowException(new TagNotFoundException());
+
+        $this->userFolder->expects($this->never())
+            ->method('searchBySystemTag');
+
+        $rules = [
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
+        ];
+
+        $this->invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null]);
+    }
+
+    public function testProcessFilterRulesVisibleTagAsUser(): void {
+        $this->groupManager->expects($this->any())
+            ->method('isAdmin')
+            ->willReturn(false);
+
+        $tag1 = $this->createMock(ISystemTag::class);
+        $tag1->expects($this->any())
+            ->method('getId')
+            ->willReturn('123');
+        $tag1->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+        $tag1->expects($this->any())
+            ->method('getName')
+            ->willReturn('OneTwoThree');
+
+        $tag2 = $this->createMock(ISystemTag::class);
+        $tag2->expects($this->any())
+            ->method('getId')
+            ->willReturn('123');
+        $tag2->expects($this->any())
+            ->method('isUserVisible')
+            ->willReturn(true);
+        $tag2->expects($this->any())
+            ->method('getName')
+            ->willReturn('FourFiveSix');
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123', '456'])
+            ->willReturn([$tag1, $tag2]);
+
+        $filesNode1 = $this->createMock(File::class);
+        $filesNode1->expects($this->any())
+            ->method('getId')
+            ->willReturn(111);
+        $filesNode1->expects($this->any())
+            ->method('getSize')
+            ->willReturn(12);
+        $filesNode2 = $this->createMock(Folder::class);
+        $filesNode2->expects($this->any())
+            ->method('getId')
+            ->willReturn(222);
+        $filesNode2->expects($this->any())
+            ->method('getSize')
+            ->willReturn(10);
+        $filesNode3 = $this->createMock(Folder::class);
+        $filesNode3->expects($this->any())
+            ->method('getId')
+            ->willReturn(333);
+        $filesNode3->expects($this->any())
+            ->method('getSize')
+            ->willReturn(33);
+
+        $this->tagManager->expects($this->once())
+            ->method('getTagsByIds')
+            ->with(['123', '456'])
+            ->willReturn([$tag1, $tag2]);
+
+        // main assertion: only user visible tags are being passed through.
+        $this->userFolder->expects($this->exactly(2))
+            ->method('searchBySystemTag')
+            ->withConsecutive(['OneTwoThree'], ['FourFiveSix'])
+            ->willReturnOnConsecutiveCalls(
+                [$filesNode1, $filesNode2],
+                [$filesNode2, $filesNode3],
+            );
+
+        $rules = [
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '123'],
+            ['name' => '{http://owncloud.org/ns}systemtag', 'value' => '456'],
+        ];
+
+        $this->assertEquals([$filesNode2], array_values($this->invokePrivate($this->plugin, 'processFilterRulesForFileNodes', [$rules, null, null])));
+    }
+
+    public function testProcessFavoriteFilter(): void {
+        $rules = [
+            ['name' => '{http://owncloud.org/ns}favorite', 'value' => '1'],
+        ];
+
+        $this->privateTags->expects($this->once())
+            ->method('getFavorites')
+            ->willReturn(['456', '789']);
+
+        $this->assertEquals(['456', '789'], array_values($this->invokePrivate($this->plugin, 'processFilterRulesForFileIDs', [$rules])));
+    }
+
+    public function filesBaseUriProvider() {
+        return [
+            ['', '', ''],
+            ['files/username', '', '/files/username'],
+            ['files/username/test', '/test', '/files/username'],
+            ['files/username/test/sub', '/test/sub', '/files/username'],
+            ['test', '/test', ''],
+        ];
+    }
+
+    /**
+     * @dataProvider filesBaseUriProvider
+     */
+    public function testFilesBaseUri($uri, $reportPath, $expectedUri): void {
+        $this->assertEquals($expectedUri, $this->invokePrivate($this->plugin, 'getFilesBaseUri', [$uri, $reportPath]));
+    }
 }

apps/dav/lib/Server.php

Indentation +327 added lines, -327 removed lines

@@ -100,332 +100,332 @@
 use SearchDAV\DAV\SearchPlugin;
 
 class Server {
-	public Connector\Sabre\Server $server;
-	private IProfiler $profiler;
-
-	public function __construct(
-		private IRequest $request,
-		private string $baseUri,
-	) {
-		$this->profiler = \OCP\Server::get(IProfiler::class);
-		if ($this->profiler->isEnabled()) {
-			/** @var IEventLogger $eventLogger */
-			$eventLogger = \OCP\Server::get(IEventLogger::class);
-			$eventLogger->start('runtime', 'DAV Runtime');
-		}
-
-		$logger = \OCP\Server::get(LoggerInterface::class);
-		$eventDispatcher = \OCP\Server::get(IEventDispatcher::class);
-
-		$root = new RootCollection();
-		$this->server = new \OCA\DAV\Connector\Sabre\Server(new CachingTree($root));
-
-		// Add maintenance plugin
-		$this->server->addPlugin(new MaintenancePlugin(\OCP\Server::get(IConfig::class), \OC::$server->getL10N('dav')));
-
-		$this->server->addPlugin(new AppleQuirksPlugin());
-
-		// Backends
-		$authBackend = new Auth(
-			\OCP\Server::get(ISession::class),
-			\OCP\Server::get(IUserSession::class),
-			\OCP\Server::get(IRequest::class),
-			\OCP\Server::get(\OC\Authentication\TwoFactorAuth\Manager::class),
-			\OCP\Server::get(IThrottler::class)
-		);
-
-		// Set URL explicitly due to reverse-proxy situations
-		$this->server->httpRequest->setUrl($this->request->getRequestUri());
-		$this->server->setBaseUri($this->baseUri);
-
-		$this->server->addPlugin(new ProfilerPlugin($this->request));
-		$this->server->addPlugin(new BlockLegacyClientPlugin(
-			\OCP\Server::get(IConfig::class),
-			\OCP\Server::get(ThemingDefaults::class),
-		));
-		$this->server->addPlugin(new AnonymousOptionsPlugin());
-		$authPlugin = new Plugin();
-		$authPlugin->addBackend(new PublicAuth());
-		$this->server->addPlugin($authPlugin);
-
-		// allow setup of additional auth backends
-		$event = new SabrePluginEvent($this->server);
-		$eventDispatcher->dispatch('OCA\DAV\Connector\Sabre::authInit', $event);
-
-		$newAuthEvent = new SabrePluginAuthInitEvent($this->server);
-		$eventDispatcher->dispatchTyped($newAuthEvent);
-
-		$bearerAuthBackend = new BearerAuth(
-			\OCP\Server::get(IUserSession::class),
-			\OCP\Server::get(ISession::class),
-			\OCP\Server::get(IRequest::class),
-			\OCP\Server::get(IConfig::class),
-		);
-		$authPlugin->addBackend($bearerAuthBackend);
-		// because we are throwing exceptions this plugin has to be the last one
-		$authPlugin->addBackend($authBackend);
-
-		// debugging
-		if (\OCP\Server::get(IConfig::class)->getSystemValue('debug', false)) {
-			$this->server->addPlugin(new \Sabre\DAV\Browser\Plugin());
-		} else {
-			$this->server->addPlugin(new DummyGetResponsePlugin());
-		}
-
-		$this->server->addPlugin(new ExceptionLoggerPlugin('webdav', $logger));
-		$this->server->addPlugin(new LockPlugin());
-		$this->server->addPlugin(new \Sabre\DAV\Sync\Plugin());
-
-		// acl
-		$acl = new DavAclPlugin();
-		$acl->principalCollectionSet = [
-			'principals/users',
-			'principals/groups',
-			'principals/calendar-resources',
-			'principals/calendar-rooms',
-		];
-		$this->server->addPlugin($acl);
-
-		// calendar plugins
-		if ($this->requestIsForSubtree(['calendars', 'public-calendars', 'system-calendars', 'principals'])) {
-			$this->server->addPlugin(new DAV\Sharing\Plugin($authBackend, \OCP\Server::get(IRequest::class), \OCP\Server::get(IConfig::class)));
-			$this->server->addPlugin(new \OCA\DAV\CalDAV\Plugin());
-			$this->server->addPlugin(new ICSExportPlugin(\OCP\Server::get(IConfig::class), $logger));
-			$this->server->addPlugin(new \OCA\DAV\CalDAV\Schedule\Plugin(\OCP\Server::get(IConfig::class), \OCP\Server::get(LoggerInterface::class), \OCP\Server::get(DefaultCalendarValidator::class)));
-
-			$this->server->addPlugin(\OCP\Server::get(\OCA\DAV\CalDAV\Trashbin\Plugin::class));
-			$this->server->addPlugin(new \OCA\DAV\CalDAV\WebcalCaching\Plugin($this->request));
-			if (\OCP\Server::get(IConfig::class)->getAppValue('dav', 'allow_calendar_link_subscriptions', 'yes') === 'yes') {
-				$this->server->addPlugin(new \Sabre\CalDAV\Subscriptions\Plugin());
-			}
-
-			$this->server->addPlugin(new \Sabre\CalDAV\Notifications\Plugin());
-			$this->server->addPlugin(new PublishPlugin(
-				\OCP\Server::get(IConfig::class),
-				\OCP\Server::get(IURLGenerator::class)
-			));
-
-			$this->server->addPlugin(\OCP\Server::get(RateLimitingPlugin::class));
-			$this->server->addPlugin(\OCP\Server::get(CalDavValidatePlugin::class));
-		}
-
-		// addressbook plugins
-		if ($this->requestIsForSubtree(['addressbooks', 'principals'])) {
-			$this->server->addPlugin(new DAV\Sharing\Plugin($authBackend, \OCP\Server::get(IRequest::class), \OCP\Server::get(IConfig::class)));
-			$this->server->addPlugin(new \OCA\DAV\CardDAV\Plugin());
-			$this->server->addPlugin(new VCFExportPlugin());
-			$this->server->addPlugin(new MultiGetExportPlugin());
-			$this->server->addPlugin(new HasPhotoPlugin());
-			$this->server->addPlugin(new ImageExportPlugin(new PhotoCache(
-				\OCP\Server::get(IAppDataFactory::class)->get('dav-photocache'),
-				$logger)
-			));
-
-			$this->server->addPlugin(\OCP\Server::get(CardDavRateLimitingPlugin::class));
-			$this->server->addPlugin(\OCP\Server::get(CardDavValidatePlugin::class));
-		}
-
-		// system tags plugins
-		$this->server->addPlugin(\OCP\Server::get(SystemTagPlugin::class));
-
-		// comments plugin
-		$this->server->addPlugin(new CommentsPlugin(
-			\OCP\Server::get(ICommentsManager::class),
-			\OCP\Server::get(IUserSession::class)
-		));
-
-		$this->server->addPlugin(new CopyEtagHeaderPlugin());
-		$this->server->addPlugin(new RequestIdHeaderPlugin(\OCP\Server::get(IRequest::class)));
-		$this->server->addPlugin(new ChunkingV2Plugin(\OCP\Server::get(ICacheFactory::class)));
-		$this->server->addPlugin(new ChunkingPlugin());
-		$this->server->addPlugin(new ZipFolderPlugin(
-			$this->server->tree,
-			$logger,
-			$eventDispatcher,
-		));
-		$this->server->addPlugin(\OCP\Server::get(PaginatePlugin::class));
-
-		// allow setup of additional plugins
-		$eventDispatcher->dispatch('OCA\DAV\Connector\Sabre::addPlugin', $event);
-		$typedEvent = new SabrePluginAddEvent($this->server);
-		$eventDispatcher->dispatchTyped($typedEvent);
-
-		// Some WebDAV clients do require Class 2 WebDAV support (locking), since
-		// we do not provide locking we emulate it using a fake locking plugin.
-		if ($this->request->isUserAgent([
-			'/WebDAVFS/',
-			'/OneNote/',
-			'/^Microsoft-WebDAV/',// Microsoft-WebDAV-MiniRedir/6.1.7601
-		])) {
-			$this->server->addPlugin(new FakeLockerPlugin());
-		}
-
-		if (BrowserErrorPagePlugin::isBrowserRequest($request)) {
-			$this->server->addPlugin(new BrowserErrorPagePlugin());
-		}
-
-		$lazySearchBackend = new LazySearchBackend();
-		$this->server->addPlugin(new SearchPlugin($lazySearchBackend));
-
-		// wait with registering these until auth is handled and the filesystem is setup
-		$this->server->on('beforeMethod:*', function () use ($root, $lazySearchBackend, $logger): void {
-			// Allow view-only plugin for webdav requests
-			$this->server->addPlugin(new ViewOnlyPlugin(
-				\OC::$server->getUserFolder(),
-			));
-
-			// custom properties plugin must be the last one
-			$userSession = \OCP\Server::get(IUserSession::class);
-			$user = $userSession->getUser();
-			if ($user !== null) {
-				$view = Filesystem::getView();
-				$config = \OCP\Server::get(IConfig::class);
-				$this->server->addPlugin(
-					new FilesPlugin(
-						$this->server->tree,
-						$config,
-						$this->request,
-						\OCP\Server::get(IPreview::class),
-						\OCP\Server::get(IUserSession::class),
-						\OCP\Server::get(IFilenameValidator::class),
-						\OCP\Server::get(IAccountManager::class),
-						false,
-						$config->getSystemValueBool('debug', false) === false,
-					)
-				);
-				$this->server->addPlugin(new ChecksumUpdatePlugin());
-
-				$this->server->addPlugin(
-					new \Sabre\DAV\PropertyStorage\Plugin(
-						new CustomPropertiesBackend(
-							$this->server,
-							$this->server->tree,
-							\OCP\Server::get(IDBConnection::class),
-							\OCP\Server::get(IUserSession::class)->getUser(),
-							\OCP\Server::get(DefaultCalendarValidator::class),
-						)
-					)
-				);
-				if ($view !== null) {
-					$this->server->addPlugin(
-						new QuotaPlugin($view));
-				}
-				$this->server->addPlugin(
-					new TagsPlugin(
-						$this->server->tree, \OCP\Server::get(ITagManager::class), \OCP\Server::get(IEventDispatcher::class), \OCP\Server::get(IUserSession::class)
-					)
-				);
-
-				// TODO: switch to LazyUserFolder
-				$userFolder = \OC::$server->getUserFolder();
-				$shareManager = \OCP\Server::get(\OCP\Share\IManager::class);
-				$this->server->addPlugin(new SharesPlugin(
-					$this->server->tree,
-					$userSession,
-					$userFolder,
-					$shareManager,
-				));
-				$this->server->addPlugin(new CommentPropertiesPlugin(
-					\OCP\Server::get(ICommentsManager::class),
-					$userSession
-				));
-				if (\OCP\Server::get(IConfig::class)->getAppValue('dav', 'sendInvitations', 'yes') === 'yes') {
-					$this->server->addPlugin(new IMipPlugin(
-						\OCP\Server::get(IAppConfig::class),
-						\OCP\Server::get(IMailer::class),
-						\OCP\Server::get(LoggerInterface::class),
-						\OCP\Server::get(ITimeFactory::class),
-						\OCP\Server::get(Defaults::class),
-						$userSession,
-						\OCP\Server::get(IMipService::class),
-						\OCP\Server::get(EventComparisonService::class),
-						\OCP\Server::get(\OCP\Mail\Provider\IManager::class)
-					));
-				}
-				$this->server->addPlugin(new \OCA\DAV\CalDAV\Search\SearchPlugin());
-				if ($view !== null) {
-					$this->server->addPlugin(new FilesReportPlugin(
-						$this->server->tree,
-						$view,
-						\OCP\Server::get(ISystemTagManager::class),
-						\OCP\Server::get(ISystemTagObjectMapper::class),
-						\OCP\Server::get(ITagManager::class),
-						$userSession,
-						\OCP\Server::get(IGroupManager::class),
-						$userFolder,
-						\OCP\Server::get(IAppManager::class)
-					));
-					$lazySearchBackend->setBackend(new FileSearchBackend(
-						$this->server->tree,
-						$user,
-						\OCP\Server::get(IRootFolder::class),
-						$shareManager,
-						$view,
-						\OCP\Server::get(IFilesMetadataManager::class)
-					));
-					$this->server->addPlugin(
-						new BulkUploadPlugin(
-							$userFolder,
-							$logger
-						)
-					);
-				}
-				$this->server->addPlugin(new EnablePlugin(
-					\OCP\Server::get(IConfig::class),
-					\OCP\Server::get(BirthdayService::class),
-					$user
-				));
-				$this->server->addPlugin(new AppleProvisioningPlugin(
-					\OCP\Server::get(IUserSession::class),
-					\OCP\Server::get(IURLGenerator::class),
-					\OCP\Server::get(ThemingDefaults::class),
-					\OCP\Server::get(IRequest::class),
-					\OC::$server->getL10N('dav'),
-					function () {
-						return UUIDUtil::getUUID();
-					}
-				));
-			}
-
-			// register plugins from apps
-			$pluginManager = new PluginManager(
-				\OC::$server,
-				\OCP\Server::get(IAppManager::class)
-			);
-			foreach ($pluginManager->getAppPlugins() as $appPlugin) {
-				$this->server->addPlugin($appPlugin);
-			}
-			foreach ($pluginManager->getAppCollections() as $appCollection) {
-				$root->addChild($appCollection);
-			}
-		});
-
-		$this->server->addPlugin(
-			new PropfindCompressionPlugin()
-		);
-	}
-
-	public function exec() {
-		/** @var IEventLogger $eventLogger */
-		$eventLogger = \OCP\Server::get(IEventLogger::class);
-		$eventLogger->start('dav_server_exec', '');
-		$this->server->start();
-		$eventLogger->end('dav_server_exec');
-		if ($this->profiler->isEnabled()) {
-			$eventLogger->end('runtime');
-			$profile = $this->profiler->collect(\OCP\Server::get(IRequest::class), new Response());
-			$this->profiler->saveProfile($profile);
-		}
-	}
-
-	private function requestIsForSubtree(array $subTrees): bool {
-		foreach ($subTrees as $subTree) {
-			$subTree = trim($subTree, ' /');
-			if (str_starts_with($this->server->getRequestUri(), $subTree . '/')) {
-				return true;
-			}
-		}
-		return false;
-	}
+    public Connector\Sabre\Server $server;
+    private IProfiler $profiler;
+
+    public function __construct(
+        private IRequest $request,
+        private string $baseUri,
+    ) {
+        $this->profiler = \OCP\Server::get(IProfiler::class);
+        if ($this->profiler->isEnabled()) {
+            /** @var IEventLogger $eventLogger */
+            $eventLogger = \OCP\Server::get(IEventLogger::class);
+            $eventLogger->start('runtime', 'DAV Runtime');
+        }
+
+        $logger = \OCP\Server::get(LoggerInterface::class);
+        $eventDispatcher = \OCP\Server::get(IEventDispatcher::class);
+
+        $root = new RootCollection();
+        $this->server = new \OCA\DAV\Connector\Sabre\Server(new CachingTree($root));
+
+        // Add maintenance plugin
+        $this->server->addPlugin(new MaintenancePlugin(\OCP\Server::get(IConfig::class), \OC::$server->getL10N('dav')));
+
+        $this->server->addPlugin(new AppleQuirksPlugin());
+
+        // Backends
+        $authBackend = new Auth(
+            \OCP\Server::get(ISession::class),
+            \OCP\Server::get(IUserSession::class),
+            \OCP\Server::get(IRequest::class),
+            \OCP\Server::get(\OC\Authentication\TwoFactorAuth\Manager::class),
+            \OCP\Server::get(IThrottler::class)
+        );
+
+        // Set URL explicitly due to reverse-proxy situations
+        $this->server->httpRequest->setUrl($this->request->getRequestUri());
+        $this->server->setBaseUri($this->baseUri);
+
+        $this->server->addPlugin(new ProfilerPlugin($this->request));
+        $this->server->addPlugin(new BlockLegacyClientPlugin(
+            \OCP\Server::get(IConfig::class),
+            \OCP\Server::get(ThemingDefaults::class),
+        ));
+        $this->server->addPlugin(new AnonymousOptionsPlugin());
+        $authPlugin = new Plugin();
+        $authPlugin->addBackend(new PublicAuth());
+        $this->server->addPlugin($authPlugin);
+
+        // allow setup of additional auth backends
+        $event = new SabrePluginEvent($this->server);
+        $eventDispatcher->dispatch('OCA\DAV\Connector\Sabre::authInit', $event);
+
+        $newAuthEvent = new SabrePluginAuthInitEvent($this->server);
+        $eventDispatcher->dispatchTyped($newAuthEvent);
+
+        $bearerAuthBackend = new BearerAuth(
+            \OCP\Server::get(IUserSession::class),
+            \OCP\Server::get(ISession::class),
+            \OCP\Server::get(IRequest::class),
+            \OCP\Server::get(IConfig::class),
+        );
+        $authPlugin->addBackend($bearerAuthBackend);
+        // because we are throwing exceptions this plugin has to be the last one
+        $authPlugin->addBackend($authBackend);
+
+        // debugging
+        if (\OCP\Server::get(IConfig::class)->getSystemValue('debug', false)) {
+            $this->server->addPlugin(new \Sabre\DAV\Browser\Plugin());
+        } else {
+            $this->server->addPlugin(new DummyGetResponsePlugin());
+        }
+
+        $this->server->addPlugin(new ExceptionLoggerPlugin('webdav', $logger));
+        $this->server->addPlugin(new LockPlugin());
+        $this->server->addPlugin(new \Sabre\DAV\Sync\Plugin());
+
+        // acl
+        $acl = new DavAclPlugin();
+        $acl->principalCollectionSet = [
+            'principals/users',
+            'principals/groups',
+            'principals/calendar-resources',
+            'principals/calendar-rooms',
+        ];
+        $this->server->addPlugin($acl);
+
+        // calendar plugins
+        if ($this->requestIsForSubtree(['calendars', 'public-calendars', 'system-calendars', 'principals'])) {
+            $this->server->addPlugin(new DAV\Sharing\Plugin($authBackend, \OCP\Server::get(IRequest::class), \OCP\Server::get(IConfig::class)));
+            $this->server->addPlugin(new \OCA\DAV\CalDAV\Plugin());
+            $this->server->addPlugin(new ICSExportPlugin(\OCP\Server::get(IConfig::class), $logger));
+            $this->server->addPlugin(new \OCA\DAV\CalDAV\Schedule\Plugin(\OCP\Server::get(IConfig::class), \OCP\Server::get(LoggerInterface::class), \OCP\Server::get(DefaultCalendarValidator::class)));
+
+            $this->server->addPlugin(\OCP\Server::get(\OCA\DAV\CalDAV\Trashbin\Plugin::class));
+            $this->server->addPlugin(new \OCA\DAV\CalDAV\WebcalCaching\Plugin($this->request));
+            if (\OCP\Server::get(IConfig::class)->getAppValue('dav', 'allow_calendar_link_subscriptions', 'yes') === 'yes') {
+                $this->server->addPlugin(new \Sabre\CalDAV\Subscriptions\Plugin());
+            }
+
+            $this->server->addPlugin(new \Sabre\CalDAV\Notifications\Plugin());
+            $this->server->addPlugin(new PublishPlugin(
+                \OCP\Server::get(IConfig::class),
+                \OCP\Server::get(IURLGenerator::class)
+            ));
+
+            $this->server->addPlugin(\OCP\Server::get(RateLimitingPlugin::class));
+            $this->server->addPlugin(\OCP\Server::get(CalDavValidatePlugin::class));
+        }
+
+        // addressbook plugins
+        if ($this->requestIsForSubtree(['addressbooks', 'principals'])) {
+            $this->server->addPlugin(new DAV\Sharing\Plugin($authBackend, \OCP\Server::get(IRequest::class), \OCP\Server::get(IConfig::class)));
+            $this->server->addPlugin(new \OCA\DAV\CardDAV\Plugin());
+            $this->server->addPlugin(new VCFExportPlugin());
+            $this->server->addPlugin(new MultiGetExportPlugin());
+            $this->server->addPlugin(new HasPhotoPlugin());
+            $this->server->addPlugin(new ImageExportPlugin(new PhotoCache(
+                \OCP\Server::get(IAppDataFactory::class)->get('dav-photocache'),
+                $logger)
+            ));
+
+            $this->server->addPlugin(\OCP\Server::get(CardDavRateLimitingPlugin::class));
+            $this->server->addPlugin(\OCP\Server::get(CardDavValidatePlugin::class));
+        }
+
+        // system tags plugins
+        $this->server->addPlugin(\OCP\Server::get(SystemTagPlugin::class));
+
+        // comments plugin
+        $this->server->addPlugin(new CommentsPlugin(
+            \OCP\Server::get(ICommentsManager::class),
+            \OCP\Server::get(IUserSession::class)
+        ));
+
+        $this->server->addPlugin(new CopyEtagHeaderPlugin());
+        $this->server->addPlugin(new RequestIdHeaderPlugin(\OCP\Server::get(IRequest::class)));
+        $this->server->addPlugin(new ChunkingV2Plugin(\OCP\Server::get(ICacheFactory::class)));
+        $this->server->addPlugin(new ChunkingPlugin());
+        $this->server->addPlugin(new ZipFolderPlugin(
+            $this->server->tree,
+            $logger,
+            $eventDispatcher,
+        ));
+        $this->server->addPlugin(\OCP\Server::get(PaginatePlugin::class));
+
+        // allow setup of additional plugins
+        $eventDispatcher->dispatch('OCA\DAV\Connector\Sabre::addPlugin', $event);
+        $typedEvent = new SabrePluginAddEvent($this->server);
+        $eventDispatcher->dispatchTyped($typedEvent);
+
+        // Some WebDAV clients do require Class 2 WebDAV support (locking), since
+        // we do not provide locking we emulate it using a fake locking plugin.
+        if ($this->request->isUserAgent([
+            '/WebDAVFS/',
+            '/OneNote/',
+            '/^Microsoft-WebDAV/',// Microsoft-WebDAV-MiniRedir/6.1.7601
+        ])) {
+            $this->server->addPlugin(new FakeLockerPlugin());
+        }
+
+        if (BrowserErrorPagePlugin::isBrowserRequest($request)) {
+            $this->server->addPlugin(new BrowserErrorPagePlugin());
+        }
+
+        $lazySearchBackend = new LazySearchBackend();
+        $this->server->addPlugin(new SearchPlugin($lazySearchBackend));
+
+        // wait with registering these until auth is handled and the filesystem is setup
+        $this->server->on('beforeMethod:*', function () use ($root, $lazySearchBackend, $logger): void {
+            // Allow view-only plugin for webdav requests
+            $this->server->addPlugin(new ViewOnlyPlugin(
+                \OC::$server->getUserFolder(),
+            ));
+
+            // custom properties plugin must be the last one
+            $userSession = \OCP\Server::get(IUserSession::class);
+            $user = $userSession->getUser();
+            if ($user !== null) {
+                $view = Filesystem::getView();
+                $config = \OCP\Server::get(IConfig::class);
+                $this->server->addPlugin(
+                    new FilesPlugin(
+                        $this->server->tree,
+                        $config,
+                        $this->request,
+                        \OCP\Server::get(IPreview::class),
+                        \OCP\Server::get(IUserSession::class),
+                        \OCP\Server::get(IFilenameValidator::class),
+                        \OCP\Server::get(IAccountManager::class),
+                        false,
+                        $config->getSystemValueBool('debug', false) === false,
+                    )
+                );
+                $this->server->addPlugin(new ChecksumUpdatePlugin());
+
+                $this->server->addPlugin(
+                    new \Sabre\DAV\PropertyStorage\Plugin(
+                        new CustomPropertiesBackend(
+                            $this->server,
+                            $this->server->tree,
+                            \OCP\Server::get(IDBConnection::class),
+                            \OCP\Server::get(IUserSession::class)->getUser(),
+                            \OCP\Server::get(DefaultCalendarValidator::class),
+                        )
+                    )
+                );
+                if ($view !== null) {
+                    $this->server->addPlugin(
+                        new QuotaPlugin($view));
+                }
+                $this->server->addPlugin(
+                    new TagsPlugin(
+                        $this->server->tree, \OCP\Server::get(ITagManager::class), \OCP\Server::get(IEventDispatcher::class), \OCP\Server::get(IUserSession::class)
+                    )
+                );
+
+                // TODO: switch to LazyUserFolder
+                $userFolder = \OC::$server->getUserFolder();
+                $shareManager = \OCP\Server::get(\OCP\Share\IManager::class);
+                $this->server->addPlugin(new SharesPlugin(
+                    $this->server->tree,
+                    $userSession,
+                    $userFolder,
+                    $shareManager,
+                ));
+                $this->server->addPlugin(new CommentPropertiesPlugin(
+                    \OCP\Server::get(ICommentsManager::class),
+                    $userSession
+                ));
+                if (\OCP\Server::get(IConfig::class)->getAppValue('dav', 'sendInvitations', 'yes') === 'yes') {
+                    $this->server->addPlugin(new IMipPlugin(
+                        \OCP\Server::get(IAppConfig::class),
+                        \OCP\Server::get(IMailer::class),
+                        \OCP\Server::get(LoggerInterface::class),
+                        \OCP\Server::get(ITimeFactory::class),
+                        \OCP\Server::get(Defaults::class),
+                        $userSession,
+                        \OCP\Server::get(IMipService::class),
+                        \OCP\Server::get(EventComparisonService::class),
+                        \OCP\Server::get(\OCP\Mail\Provider\IManager::class)
+                    ));
+                }
+                $this->server->addPlugin(new \OCA\DAV\CalDAV\Search\SearchPlugin());
+                if ($view !== null) {
+                    $this->server->addPlugin(new FilesReportPlugin(
+                        $this->server->tree,
+                        $view,
+                        \OCP\Server::get(ISystemTagManager::class),
+                        \OCP\Server::get(ISystemTagObjectMapper::class),
+                        \OCP\Server::get(ITagManager::class),
+                        $userSession,
+                        \OCP\Server::get(IGroupManager::class),
+                        $userFolder,
+                        \OCP\Server::get(IAppManager::class)
+                    ));
+                    $lazySearchBackend->setBackend(new FileSearchBackend(
+                        $this->server->tree,
+                        $user,
+                        \OCP\Server::get(IRootFolder::class),
+                        $shareManager,
+                        $view,
+                        \OCP\Server::get(IFilesMetadataManager::class)
+                    ));
+                    $this->server->addPlugin(
+                        new BulkUploadPlugin(
+                            $userFolder,
+                            $logger
+                        )
+                    );
+                }
+                $this->server->addPlugin(new EnablePlugin(
+                    \OCP\Server::get(IConfig::class),
+                    \OCP\Server::get(BirthdayService::class),
+                    $user
+                ));
+                $this->server->addPlugin(new AppleProvisioningPlugin(
+                    \OCP\Server::get(IUserSession::class),
+                    \OCP\Server::get(IURLGenerator::class),
+                    \OCP\Server::get(ThemingDefaults::class),
+                    \OCP\Server::get(IRequest::class),
+                    \OC::$server->getL10N('dav'),
+                    function () {
+                        return UUIDUtil::getUUID();
+                    }
+                ));
+            }
+
+            // register plugins from apps
+            $pluginManager = new PluginManager(
+                \OC::$server,
+                \OCP\Server::get(IAppManager::class)
+            );
+            foreach ($pluginManager->getAppPlugins() as $appPlugin) {
+                $this->server->addPlugin($appPlugin);
+            }
+            foreach ($pluginManager->getAppCollections() as $appCollection) {
+                $root->addChild($appCollection);
+            }
+        });
+
+        $this->server->addPlugin(
+            new PropfindCompressionPlugin()
+        );
+    }
+
+    public function exec() {
+        /** @var IEventLogger $eventLogger */
+        $eventLogger = \OCP\Server::get(IEventLogger::class);
+        $eventLogger->start('dav_server_exec', '');
+        $this->server->start();
+        $eventLogger->end('dav_server_exec');
+        if ($this->profiler->isEnabled()) {
+            $eventLogger->end('runtime');
+            $profile = $this->profiler->collect(\OCP\Server::get(IRequest::class), new Response());
+            $this->profiler->saveProfile($profile);
+        }
+    }
+
+    private function requestIsForSubtree(array $subTrees): bool {
+        foreach ($subTrees as $subTree) {
+            $subTree = trim($subTree, ' /');
+            if (str_starts_with($this->server->getRequestUri(), $subTree . '/')) {
+                return true;
+            }
+        }
+        return false;
+    }
 
 }

apps/dav/lib/Connector/Sabre/ServerFactory.php

Indentation +153 added lines, -153 removed lines

@@ -37,157 +37,157 @@
 
 class ServerFactory {
 
-	public function __construct(
-		private IConfig $config,
-		private LoggerInterface $logger,
-		private IDBConnection $databaseConnection,
-		private IUserSession $userSession,
-		private IMountManager $mountManager,
-		private ITagManager $tagManager,
-		private IRequest $request,
-		private IPreview $previewManager,
-		private IEventDispatcher $eventDispatcher,
-		private IL10N $l10n,
-	) {
-	}
-
-	/**
-	 * @param callable $viewCallBack callback that should return the view for the dav endpoint
-	 */
-	public function createServer(string $baseUri,
-		string $requestUri,
-		Plugin $authPlugin,
-		callable $viewCallBack): Server {
-		// Fire up server
-		$objectTree = new ObjectTree();
-		$server = new Server($objectTree);
-		// Set URL explicitly due to reverse-proxy situations
-		$server->httpRequest->setUrl($requestUri);
-		$server->setBaseUri($baseUri);
-
-		// Load plugins
-		$server->addPlugin(new MaintenancePlugin($this->config, $this->l10n));
-		$server->addPlugin(new BlockLegacyClientPlugin(
-			$this->config,
-			\OCP\Server::get(ThemingDefaults::class),
-		));
-		$server->addPlugin(new AnonymousOptionsPlugin());
-		$server->addPlugin($authPlugin);
-		// FIXME: The following line is a workaround for legacy components relying on being able to send a GET to /
-		$server->addPlugin(new DummyGetResponsePlugin());
-		$server->addPlugin(new ExceptionLoggerPlugin('webdav', $this->logger));
-		$server->addPlugin(new LockPlugin());
-
-		$server->addPlugin(new RequestIdHeaderPlugin($this->request));
-
-		$server->addPlugin(new ZipFolderPlugin(
-			$objectTree,
-			$this->logger,
-			$this->eventDispatcher,
-		));
-
-		// Some WebDAV clients do require Class 2 WebDAV support (locking), since
-		// we do not provide locking we emulate it using a fake locking plugin.
-		if ($this->request->isUserAgent([
-			'/WebDAVFS/',
-			'/OneNote/',
-			'/Microsoft-WebDAV-MiniRedir/',
-		])) {
-			$server->addPlugin(new FakeLockerPlugin());
-		}
-
-		if (BrowserErrorPagePlugin::isBrowserRequest($this->request)) {
-			$server->addPlugin(new BrowserErrorPagePlugin());
-		}
-
-		// wait with registering these until auth is handled and the filesystem is setup
-		$server->on('beforeMethod:*', function () use ($server, $objectTree, $viewCallBack): void {
-			// ensure the skeleton is copied
-			$userFolder = \OC::$server->getUserFolder();
-
-			/** @var View $view */
-			$view = $viewCallBack($server);
-			if ($userFolder instanceof Folder && $userFolder->getPath() === $view->getRoot()) {
-				$rootInfo = $userFolder;
-			} else {
-				$rootInfo = $view->getFileInfo('');
-			}
-
-			// Create Nextcloud Dir
-			if ($rootInfo->getType() === 'dir') {
-				$root = new Directory($view, $rootInfo, $objectTree);
-			} else {
-				$root = new File($view, $rootInfo);
-			}
-			$objectTree->init($root, $view, $this->mountManager);
-
-			$server->addPlugin(
-				new FilesPlugin(
-					$objectTree,
-					$this->config,
-					$this->request,
-					$this->previewManager,
-					$this->userSession,
-					\OCP\Server::get(IFilenameValidator::class),
-					\OCP\Server::get(IAccountManager::class),
-					false,
-					!$this->config->getSystemValue('debug', false)
-				)
-			);
-			$server->addPlugin(new QuotaPlugin($view, true));
-			$server->addPlugin(new ChecksumUpdatePlugin());
-
-			// Allow view-only plugin for webdav requests
-			$server->addPlugin(new ViewOnlyPlugin(
-				$userFolder,
-			));
-
-			if ($this->userSession->isLoggedIn()) {
-				$server->addPlugin(new TagsPlugin($objectTree, $this->tagManager, $this->eventDispatcher, $this->userSession));
-				$server->addPlugin(new SharesPlugin(
-					$objectTree,
-					$this->userSession,
-					$userFolder,
-					\OCP\Server::get(\OCP\Share\IManager::class)
-				));
-				$server->addPlugin(new CommentPropertiesPlugin(\OCP\Server::get(ICommentsManager::class), $this->userSession));
-				$server->addPlugin(new FilesReportPlugin(
-					$objectTree,
-					$view,
-					\OCP\Server::get(ISystemTagManager::class),
-					\OCP\Server::get(ISystemTagObjectMapper::class),
-					\OCP\Server::get(ITagManager::class),
-					$this->userSession,
-					\OCP\Server::get(IGroupManager::class),
-					$userFolder,
-					\OCP\Server::get(IAppManager::class)
-				));
-				// custom properties plugin must be the last one
-				$server->addPlugin(
-					new \Sabre\DAV\PropertyStorage\Plugin(
-						new CustomPropertiesBackend(
-							$server,
-							$objectTree,
-							$this->databaseConnection,
-							$this->userSession->getUser(),
-							\OCP\Server::get(DefaultCalendarValidator::class),
-						)
-					)
-				);
-			}
-			$server->addPlugin(new CopyEtagHeaderPlugin());
-
-			// Load dav plugins from apps
-			$event = new SabrePluginEvent($server);
-			$this->eventDispatcher->dispatchTyped($event);
-			$pluginManager = new PluginManager(
-				\OC::$server,
-				\OCP\Server::get(IAppManager::class)
-			);
-			foreach ($pluginManager->getAppPlugins() as $appPlugin) {
-				$server->addPlugin($appPlugin);
-			}
-		}, 30); // priority 30: after auth (10) and acl(20), before lock(50) and handling the request
-		return $server;
-	}
+    public function __construct(
+        private IConfig $config,
+        private LoggerInterface $logger,
+        private IDBConnection $databaseConnection,
+        private IUserSession $userSession,
+        private IMountManager $mountManager,
+        private ITagManager $tagManager,
+        private IRequest $request,
+        private IPreview $previewManager,
+        private IEventDispatcher $eventDispatcher,
+        private IL10N $l10n,
+    ) {
+    }
+
+    /**
+     * @param callable $viewCallBack callback that should return the view for the dav endpoint
+     */
+    public function createServer(string $baseUri,
+        string $requestUri,
+        Plugin $authPlugin,
+        callable $viewCallBack): Server {
+        // Fire up server
+        $objectTree = new ObjectTree();
+        $server = new Server($objectTree);
+        // Set URL explicitly due to reverse-proxy situations
+        $server->httpRequest->setUrl($requestUri);
+        $server->setBaseUri($baseUri);
+
+        // Load plugins
+        $server->addPlugin(new MaintenancePlugin($this->config, $this->l10n));
+        $server->addPlugin(new BlockLegacyClientPlugin(
+            $this->config,
+            \OCP\Server::get(ThemingDefaults::class),
+        ));
+        $server->addPlugin(new AnonymousOptionsPlugin());
+        $server->addPlugin($authPlugin);
+        // FIXME: The following line is a workaround for legacy components relying on being able to send a GET to /
+        $server->addPlugin(new DummyGetResponsePlugin());
+        $server->addPlugin(new ExceptionLoggerPlugin('webdav', $this->logger));
+        $server->addPlugin(new LockPlugin());
+
+        $server->addPlugin(new RequestIdHeaderPlugin($this->request));
+
+        $server->addPlugin(new ZipFolderPlugin(
+            $objectTree,
+            $this->logger,
+            $this->eventDispatcher,
+        ));
+
+        // Some WebDAV clients do require Class 2 WebDAV support (locking), since
+        // we do not provide locking we emulate it using a fake locking plugin.
+        if ($this->request->isUserAgent([
+            '/WebDAVFS/',
+            '/OneNote/',
+            '/Microsoft-WebDAV-MiniRedir/',
+        ])) {
+            $server->addPlugin(new FakeLockerPlugin());
+        }
+
+        if (BrowserErrorPagePlugin::isBrowserRequest($this->request)) {
+            $server->addPlugin(new BrowserErrorPagePlugin());
+        }
+
+        // wait with registering these until auth is handled and the filesystem is setup
+        $server->on('beforeMethod:*', function () use ($server, $objectTree, $viewCallBack): void {
+            // ensure the skeleton is copied
+            $userFolder = \OC::$server->getUserFolder();
+
+            /** @var View $view */
+            $view = $viewCallBack($server);
+            if ($userFolder instanceof Folder && $userFolder->getPath() === $view->getRoot()) {
+                $rootInfo = $userFolder;
+            } else {
+                $rootInfo = $view->getFileInfo('');
+            }
+
+            // Create Nextcloud Dir
+            if ($rootInfo->getType() === 'dir') {
+                $root = new Directory($view, $rootInfo, $objectTree);
+            } else {
+                $root = new File($view, $rootInfo);
+            }
+            $objectTree->init($root, $view, $this->mountManager);
+
+            $server->addPlugin(
+                new FilesPlugin(
+                    $objectTree,
+                    $this->config,
+                    $this->request,
+                    $this->previewManager,
+                    $this->userSession,
+                    \OCP\Server::get(IFilenameValidator::class),
+                    \OCP\Server::get(IAccountManager::class),
+                    false,
+                    !$this->config->getSystemValue('debug', false)
+                )
+            );
+            $server->addPlugin(new QuotaPlugin($view, true));
+            $server->addPlugin(new ChecksumUpdatePlugin());
+
+            // Allow view-only plugin for webdav requests
+            $server->addPlugin(new ViewOnlyPlugin(
+                $userFolder,
+            ));
+
+            if ($this->userSession->isLoggedIn()) {
+                $server->addPlugin(new TagsPlugin($objectTree, $this->tagManager, $this->eventDispatcher, $this->userSession));
+                $server->addPlugin(new SharesPlugin(
+                    $objectTree,
+                    $this->userSession,
+                    $userFolder,
+                    \OCP\Server::get(\OCP\Share\IManager::class)
+                ));
+                $server->addPlugin(new CommentPropertiesPlugin(\OCP\Server::get(ICommentsManager::class), $this->userSession));
+                $server->addPlugin(new FilesReportPlugin(
+                    $objectTree,
+                    $view,
+                    \OCP\Server::get(ISystemTagManager::class),
+                    \OCP\Server::get(ISystemTagObjectMapper::class),
+                    \OCP\Server::get(ITagManager::class),
+                    $this->userSession,
+                    \OCP\Server::get(IGroupManager::class),
+                    $userFolder,
+                    \OCP\Server::get(IAppManager::class)
+                ));
+                // custom properties plugin must be the last one
+                $server->addPlugin(
+                    new \Sabre\DAV\PropertyStorage\Plugin(
+                        new CustomPropertiesBackend(
+                            $server,
+                            $objectTree,
+                            $this->databaseConnection,
+                            $this->userSession->getUser(),
+                            \OCP\Server::get(DefaultCalendarValidator::class),
+                        )
+                    )
+                );
+            }
+            $server->addPlugin(new CopyEtagHeaderPlugin());
+
+            // Load dav plugins from apps
+            $event = new SabrePluginEvent($server);
+            $this->eventDispatcher->dispatchTyped($event);
+            $pluginManager = new PluginManager(
+                \OC::$server,
+                \OCP\Server::get(IAppManager::class)
+            );
+            foreach ($pluginManager->getAppPlugins() as $appPlugin) {
+                $server->addPlugin($appPlugin);
+            }
+        }, 30); // priority 30: after auth (10) and acl(20), before lock(50) and handling the request
+        return $server;
+    }
 }

apps/dav/lib/Connector/Sabre/FilesPlugin.php

Indentation +692 added lines, -692 removed lines

@@ -39,696 +39,696 @@
 use Sabre\HTTP\ResponseInterface;
 
 class FilesPlugin extends ServerPlugin {
-	// namespace
-	public const NS_OWNCLOUD = 'http://owncloud.org/ns';
-	public const NS_NEXTCLOUD = 'http://nextcloud.org/ns';
-	public const FILEID_PROPERTYNAME = '{http://owncloud.org/ns}id';
-	public const INTERNAL_FILEID_PROPERTYNAME = '{http://owncloud.org/ns}fileid';
-	public const PERMISSIONS_PROPERTYNAME = '{http://owncloud.org/ns}permissions';
-	public const SHARE_PERMISSIONS_PROPERTYNAME = '{http://open-collaboration-services.org/ns}share-permissions';
-	public const OCM_SHARE_PERMISSIONS_PROPERTYNAME = '{http://open-cloud-mesh.org/ns}share-permissions';
-	public const SHARE_ATTRIBUTES_PROPERTYNAME = '{http://nextcloud.org/ns}share-attributes';
-	public const DOWNLOADURL_PROPERTYNAME = '{http://owncloud.org/ns}downloadURL';
-	public const SIZE_PROPERTYNAME = '{http://owncloud.org/ns}size';
-	public const GETETAG_PROPERTYNAME = '{DAV:}getetag';
-	public const LASTMODIFIED_PROPERTYNAME = '{DAV:}lastmodified';
-	public const CREATIONDATE_PROPERTYNAME = '{DAV:}creationdate';
-	public const DISPLAYNAME_PROPERTYNAME = '{DAV:}displayname';
-	public const OWNER_ID_PROPERTYNAME = '{http://owncloud.org/ns}owner-id';
-	public const OWNER_DISPLAY_NAME_PROPERTYNAME = '{http://owncloud.org/ns}owner-display-name';
-	public const CHECKSUMS_PROPERTYNAME = '{http://owncloud.org/ns}checksums';
-	public const DATA_FINGERPRINT_PROPERTYNAME = '{http://owncloud.org/ns}data-fingerprint';
-	public const HAS_PREVIEW_PROPERTYNAME = '{http://nextcloud.org/ns}has-preview';
-	public const MOUNT_TYPE_PROPERTYNAME = '{http://nextcloud.org/ns}mount-type';
-	public const MOUNT_ROOT_PROPERTYNAME = '{http://nextcloud.org/ns}is-mount-root';
-	public const IS_FEDERATED_PROPERTYNAME = '{http://nextcloud.org/ns}is-federated';
-	public const METADATA_ETAG_PROPERTYNAME = '{http://nextcloud.org/ns}metadata_etag';
-	public const UPLOAD_TIME_PROPERTYNAME = '{http://nextcloud.org/ns}upload_time';
-	public const CREATION_TIME_PROPERTYNAME = '{http://nextcloud.org/ns}creation_time';
-	public const SHARE_NOTE = '{http://nextcloud.org/ns}note';
-	public const SHARE_HIDE_DOWNLOAD_PROPERTYNAME = '{http://nextcloud.org/ns}hide-download';
-	public const SUBFOLDER_COUNT_PROPERTYNAME = '{http://nextcloud.org/ns}contained-folder-count';
-	public const SUBFILE_COUNT_PROPERTYNAME = '{http://nextcloud.org/ns}contained-file-count';
-	public const FILE_METADATA_PREFIX = '{http://nextcloud.org/ns}metadata-';
-	public const HIDDEN_PROPERTYNAME = '{http://nextcloud.org/ns}hidden';
-
-	/** Reference to main server object */
-	private ?Server $server = null;
-
-	/**
-	 * @param Tree $tree
-	 * @param IConfig $config
-	 * @param IRequest $request
-	 * @param IPreview $previewManager
-	 * @param IUserSession $userSession
-	 * @param bool $isPublic Whether this is public WebDAV. If true, some returned information will be stripped off.
-	 * @param bool $downloadAttachment
-	 * @return void
-	 */
-	public function __construct(
-		private Tree $tree,
-		private IConfig $config,
-		private IRequest $request,
-		private IPreview $previewManager,
-		private IUserSession $userSession,
-		private IFilenameValidator $validator,
-		private IAccountManager $accountManager,
-		private bool $isPublic = false,
-		private bool $downloadAttachment = true,
-	) {
-	}
-
-	/**
-	 * This initializes the plugin.
-	 *
-	 * This function is called by \Sabre\DAV\Server, after
-	 * addPlugin is called.
-	 *
-	 * This method should set up the required event subscriptions.
-	 *
-	 * @return void
-	 */
-	public function initialize(Server $server) {
-		$server->xml->namespaceMap[self::NS_OWNCLOUD] = 'oc';
-		$server->xml->namespaceMap[self::NS_NEXTCLOUD] = 'nc';
-		$server->protectedProperties[] = self::FILEID_PROPERTYNAME;
-		$server->protectedProperties[] = self::INTERNAL_FILEID_PROPERTYNAME;
-		$server->protectedProperties[] = self::PERMISSIONS_PROPERTYNAME;
-		$server->protectedProperties[] = self::SHARE_PERMISSIONS_PROPERTYNAME;
-		$server->protectedProperties[] = self::OCM_SHARE_PERMISSIONS_PROPERTYNAME;
-		$server->protectedProperties[] = self::SHARE_ATTRIBUTES_PROPERTYNAME;
-		$server->protectedProperties[] = self::SIZE_PROPERTYNAME;
-		$server->protectedProperties[] = self::DOWNLOADURL_PROPERTYNAME;
-		$server->protectedProperties[] = self::OWNER_ID_PROPERTYNAME;
-		$server->protectedProperties[] = self::OWNER_DISPLAY_NAME_PROPERTYNAME;
-		$server->protectedProperties[] = self::CHECKSUMS_PROPERTYNAME;
-		$server->protectedProperties[] = self::DATA_FINGERPRINT_PROPERTYNAME;
-		$server->protectedProperties[] = self::HAS_PREVIEW_PROPERTYNAME;
-		$server->protectedProperties[] = self::MOUNT_TYPE_PROPERTYNAME;
-		$server->protectedProperties[] = self::IS_FEDERATED_PROPERTYNAME;
-		$server->protectedProperties[] = self::SHARE_NOTE;
-
-		// normally these cannot be changed (RFC4918), but we want them modifiable through PROPPATCH
-		$allowedProperties = ['{DAV:}getetag'];
-		$server->protectedProperties = array_diff($server->protectedProperties, $allowedProperties);
-
-		$this->server = $server;
-		$this->server->on('propFind', [$this, 'handleGetProperties']);
-		$this->server->on('propPatch', [$this, 'handleUpdateProperties']);
-		$this->server->on('afterBind', [$this, 'sendFileIdHeader']);
-		$this->server->on('afterWriteContent', [$this, 'sendFileIdHeader']);
-		$this->server->on('afterMethod:GET', [$this,'httpGet']);
-		$this->server->on('afterMethod:GET', [$this, 'handleDownloadToken']);
-		$this->server->on('afterResponse', function ($request, ResponseInterface $response): void {
-			$body = $response->getBody();
-			if (is_resource($body)) {
-				fclose($body);
-			}
-		});
-		$this->server->on('beforeMove', [$this, 'checkMove']);
-		$this->server->on('beforeCopy', [$this, 'checkCopy']);
-	}
-
-	/**
-	 * Plugin that checks if a copy can actually be performed.
-	 *
-	 * @param string $source source path
-	 * @param string $target target path
-	 * @throws NotFound If the source does not exist
-	 * @throws InvalidPath If the target is invalid
-	 */
-	public function checkCopy($source, $target): void {
-		$sourceNode = $this->tree->getNodeForPath($source);
-		if (!$sourceNode instanceof Node) {
-			return;
-		}
-
-		// Ensure source exists
-		$sourceNodeFileInfo = $sourceNode->getFileInfo();
-		if ($sourceNodeFileInfo === null) {
-			throw new NotFound($source . ' does not exist');
-		}
-		// Ensure the target name is valid
-		try {
-			[$targetPath, $targetName] = \Sabre\Uri\split($target);
-			$this->validator->validateFilename($targetName);
-		} catch (InvalidPathException $e) {
-			throw new InvalidPath($e->getMessage(), false);
-		}
-		// Ensure the target path is valid
-		$segments = array_slice(explode('/', $targetPath), 2);
-		foreach ($segments as $segment) {
-			if ($this->validator->isFilenameValid($segment) === false) {
-				$l = \OCP\Server::get(IFactory::class)->get('dav');
-				throw new InvalidPath($l->t('Invalid target path'));
-			}
-		}
-	}
-
-	/**
-	 * Plugin that checks if a move can actually be performed.
-	 *
-	 * @param string $source source path
-	 * @param string $target target path
-	 * @throws Forbidden If the source is not deletable
-	 * @throws NotFound If the source does not exist
-	 * @throws InvalidPath If the target name is invalid
-	 */
-	public function checkMove(string $source, string $target): void {
-		$sourceNode = $this->tree->getNodeForPath($source);
-		if (!$sourceNode instanceof Node) {
-			return;
-		}
-
-		// First check copyable (move only needs additional delete permission)
-		$this->checkCopy($source, $target);
-
-		// The source needs to be deletable for moving
-		$sourceNodeFileInfo = $sourceNode->getFileInfo();
-		if (!$sourceNodeFileInfo->isDeletable()) {
-			throw new Forbidden($source . ' cannot be deleted');
-		}
-
-		// The source is not allowed to be the parent of the target
-		if (str_starts_with($source, $target . '/')) {
-			throw new Forbidden($source . ' cannot be moved to it\'s parent');
-		}
-	}
-
-	/**
-	 * This sets a cookie to be able to recognize the start of the download
-	 * the content must not be longer than 32 characters and must only contain
-	 * alphanumeric characters
-	 *
-	 * @param RequestInterface $request
-	 * @param ResponseInterface $response
-	 */
-	public function handleDownloadToken(RequestInterface $request, ResponseInterface $response) {
-		$queryParams = $request->getQueryParameters();
-
-		/**
-		 * this sets a cookie to be able to recognize the start of the download
-		 * the content must not be longer than 32 characters and must only contain
-		 * alphanumeric characters
-		 */
-		if (isset($queryParams['downloadStartSecret'])) {
-			$token = $queryParams['downloadStartSecret'];
-			if (!isset($token[32])
-				&& preg_match('!^[a-zA-Z0-9]+$!', $token) === 1) {
-				// FIXME: use $response->setHeader() instead
-				setcookie('ocDownloadStarted', $token, time() + 20, '/');
-			}
-		}
-	}
-
-	/**
-	 * Add headers to file download
-	 *
-	 * @param RequestInterface $request
-	 * @param ResponseInterface $response
-	 */
-	public function httpGet(RequestInterface $request, ResponseInterface $response) {
-		// Only handle valid files
-		$node = $this->tree->getNodeForPath($request->getPath());
-		if (!($node instanceof IFile)) {
-			return;
-		}
-
-		// adds a 'Content-Disposition: attachment' header in case no disposition
-		// header has been set before
-		if ($this->downloadAttachment &&
-			$response->getHeader('Content-Disposition') === null) {
-			$filename = $node->getName();
-			if ($this->request->isUserAgent(
-				[
-					Request::USER_AGENT_IE,
-					Request::USER_AGENT_ANDROID_MOBILE_CHROME,
-					Request::USER_AGENT_FREEBOX,
-				])) {
-				$response->addHeader('Content-Disposition', 'attachment; filename="' . rawurlencode($filename) . '"');
-			} else {
-				$response->addHeader('Content-Disposition', 'attachment; filename*=UTF-8\'\'' . rawurlencode($filename)
-													 . '; filename="' . rawurlencode($filename) . '"');
-			}
-		}
-
-		if ($node instanceof File) {
-			//Add OC-Checksum header
-			$checksum = $node->getChecksum();
-			if ($checksum !== null && $checksum !== '') {
-				$response->addHeader('OC-Checksum', $checksum);
-			}
-		}
-		$response->addHeader('X-Accel-Buffering', 'no');
-	}
-
-	/**
-	 * Adds all ownCloud-specific properties
-	 *
-	 * @param PropFind $propFind
-	 * @param \Sabre\DAV\INode $node
-	 * @return void
-	 */
-	public function handleGetProperties(PropFind $propFind, \Sabre\DAV\INode $node) {
-		$httpRequest = $this->server->httpRequest;
-
-		if ($node instanceof Node) {
-			/**
-			 * This was disabled, because it made dir listing throw an exception,
-			 * so users were unable to navigate into folders where one subitem
-			 * is blocked by the files_accesscontrol app, see:
-			 * https://github.com/nextcloud/files_accesscontrol/issues/65
-			 * if (!$node->getFileInfo()->isReadable()) {
-			 *     // avoid detecting files through this means
-			 *     throw new NotFound();
-			 * }
-			 */
-
-			$propFind->handle(self::FILEID_PROPERTYNAME, function () use ($node) {
-				return $node->getFileId();
-			});
-
-			$propFind->handle(self::INTERNAL_FILEID_PROPERTYNAME, function () use ($node) {
-				return $node->getInternalFileId();
-			});
-
-			$propFind->handle(self::PERMISSIONS_PROPERTYNAME, function () use ($node) {
-				$perms = $node->getDavPermissions();
-				if ($this->isPublic) {
-					// remove mount information
-					$perms = str_replace(['S', 'M'], '', $perms);
-				}
-				return $perms;
-			});
-
-			$propFind->handle(self::SHARE_PERMISSIONS_PROPERTYNAME, function () use ($node, $httpRequest) {
-				$user = $this->userSession->getUser();
-				if ($user === null) {
-					return null;
-				}
-				return $node->getSharePermissions(
-					$user->getUID()
-				);
-			});
-
-			$propFind->handle(self::OCM_SHARE_PERMISSIONS_PROPERTYNAME, function () use ($node, $httpRequest): ?string {
-				$user = $this->userSession->getUser();
-				if ($user === null) {
-					return null;
-				}
-				$ncPermissions = $node->getSharePermissions(
-					$user->getUID()
-				);
-				$ocmPermissions = $this->ncPermissions2ocmPermissions($ncPermissions);
-				return json_encode($ocmPermissions, JSON_THROW_ON_ERROR);
-			});
-
-			$propFind->handle(self::SHARE_ATTRIBUTES_PROPERTYNAME, function () use ($node, $httpRequest) {
-				return json_encode($node->getShareAttributes(), JSON_THROW_ON_ERROR);
-			});
-
-			$propFind->handle(self::GETETAG_PROPERTYNAME, function () use ($node): string {
-				return $node->getETag();
-			});
-
-			$propFind->handle(self::OWNER_ID_PROPERTYNAME, function () use ($node): ?string {
-				$owner = $node->getOwner();
-				if (!$owner) {
-					return null;
-				} else {
-					return $owner->getUID();
-				}
-			});
-			$propFind->handle(self::OWNER_DISPLAY_NAME_PROPERTYNAME, function () use ($node): ?string {
-				$owner = $node->getOwner();
-				if (!$owner) {
-					return null;
-				}
-
-				// Get current user to see if we're in a public share or not
-				$user = $this->userSession->getUser();
-
-				// If the user is logged in, we can return the display name
-				if ($user !== null) {
-					return $owner->getDisplayName();
-				}
-
-				// Check if the user published their display name
-				$ownerAccount = $this->accountManager->getAccount($owner);
-				$ownerNameProperty = $ownerAccount->getProperty(IAccountManager::PROPERTY_DISPLAYNAME);
-
-				// Since we are not logged in, we need to have at least the published scope
-				if ($ownerNameProperty->getScope() === IAccountManager::SCOPE_PUBLISHED) {
-					return $owner->getDisplayName();
-				}
-
-				return null;
-			});
-
-			$propFind->handle(self::HAS_PREVIEW_PROPERTYNAME, function () use ($node) {
-				return json_encode($this->previewManager->isAvailable($node->getFileInfo()), JSON_THROW_ON_ERROR);
-			});
-			$propFind->handle(self::SIZE_PROPERTYNAME, function () use ($node): int|float {
-				return $node->getSize();
-			});
-			$propFind->handle(self::MOUNT_TYPE_PROPERTYNAME, function () use ($node) {
-				return $node->getFileInfo()->getMountPoint()->getMountType();
-			});
-
-			/**
-			 * This is a special property which is used to determine if a node
-			 * is a mount root or not, e.g. a shared folder.
-			 * If so, then the node can only be unshared and not deleted.
-			 * @see https://github.com/nextcloud/server/blob/cc75294eb6b16b916a342e69998935f89222619d/lib/private/Files/View.php#L696-L698
-			 */
-			$propFind->handle(self::MOUNT_ROOT_PROPERTYNAME, function () use ($node) {
-				return $node->getNode()->getInternalPath() === '' ? 'true' : 'false';
-			});
-
-			$propFind->handle(self::SHARE_NOTE, function () use ($node): ?string {
-				$user = $this->userSession->getUser();
-				return $node->getNoteFromShare(
-					$user?->getUID()
-				);
-			});
-
-			$propFind->handle(self::SHARE_HIDE_DOWNLOAD_PROPERTYNAME, function () use ($node) {
-				$storage = $node->getNode()->getStorage();
-				if ($storage->instanceOfStorage(ISharedStorage::class)) {
-					/** @var ISharedStorage $storage */
-					return match($storage->getShare()->getHideDownload()) {
-						true => 'true',
-						false => 'false',
-					};
-				} else {
-					return null;
-				}
-			});
-
-			$propFind->handle(self::DATA_FINGERPRINT_PROPERTYNAME, function () {
-				return $this->config->getSystemValue('data-fingerprint', '');
-			});
-			$propFind->handle(self::CREATIONDATE_PROPERTYNAME, function () use ($node) {
-				return (new \DateTimeImmutable())
-					->setTimestamp($node->getFileInfo()->getCreationTime())
-					->format(\DateTimeInterface::ATOM);
-			});
-			$propFind->handle(self::CREATION_TIME_PROPERTYNAME, function () use ($node) {
-				return $node->getFileInfo()->getCreationTime();
-			});
-
-			foreach ($node->getFileInfo()->getMetadata() as $metadataKey => $metadataValue) {
-				$propFind->handle(self::FILE_METADATA_PREFIX . $metadataKey, $metadataValue);
-			}
-
-			$propFind->handle(self::HIDDEN_PROPERTYNAME, function () use ($node) {
-				$isLivePhoto = isset($node->getFileInfo()->getMetadata()['files-live-photo']);
-				$isMovFile = $node->getFileInfo()->getMimetype() === 'video/quicktime';
-				return ($isLivePhoto && $isMovFile) ? 'true' : 'false';
-			});
-
-			/**
-			 * Return file/folder name as displayname. The primary reason to
-			 * implement it this way is to avoid costly fallback to
-			 * CustomPropertiesBackend (esp. visible when querying all files
-			 * in a folder).
-			 */
-			$propFind->handle(self::DISPLAYNAME_PROPERTYNAME, function () use ($node) {
-				return $node->getName();
-			});
-
-			$propFind->handle(self::IS_FEDERATED_PROPERTYNAME, function () use ($node) {
-				return $node->getFileInfo()->getMountPoint()
-					instanceof SharingExternalMount;
-			});
-		}
-
-		if ($node instanceof File) {
-			$propFind->handle(self::DOWNLOADURL_PROPERTYNAME, function () use ($node) {
-				try {
-					$directDownloadUrl = $node->getDirectDownload();
-					if (isset($directDownloadUrl['url'])) {
-						return $directDownloadUrl['url'];
-					}
-				} catch (StorageNotAvailableException $e) {
-					return false;
-				} catch (ForbiddenException $e) {
-					return false;
-				}
-				return false;
-			});
-
-			$propFind->handle(self::CHECKSUMS_PROPERTYNAME, function () use ($node) {
-				$checksum = $node->getChecksum();
-				if ($checksum === null || $checksum === '') {
-					return null;
-				}
-
-				return new ChecksumList($checksum);
-			});
-
-			$propFind->handle(self::UPLOAD_TIME_PROPERTYNAME, function () use ($node) {
-				return $node->getFileInfo()->getUploadTime();
-			});
-		}
-
-		if ($node instanceof Directory) {
-			$propFind->handle(self::SIZE_PROPERTYNAME, function () use ($node) {
-				return $node->getSize();
-			});
-
-			$requestProperties = $propFind->getRequestedProperties();
-
-			if (in_array(self::SUBFILE_COUNT_PROPERTYNAME, $requestProperties, true)
-				|| in_array(self::SUBFOLDER_COUNT_PROPERTYNAME, $requestProperties, true)) {
-				$nbFiles = 0;
-				$nbFolders = 0;
-				foreach ($node->getChildren() as $child) {
-					if ($child instanceof File) {
-						$nbFiles++;
-					} elseif ($child instanceof Directory) {
-						$nbFolders++;
-					}
-				}
-
-				$propFind->handle(self::SUBFILE_COUNT_PROPERTYNAME, $nbFiles);
-				$propFind->handle(self::SUBFOLDER_COUNT_PROPERTYNAME, $nbFolders);
-			}
-		}
-	}
-
-	/**
-	 * translate Nextcloud permissions to OCM Permissions
-	 *
-	 * @param $ncPermissions
-	 * @return array
-	 */
-	protected function ncPermissions2ocmPermissions($ncPermissions) {
-		$ocmPermissions = [];
-
-		if ($ncPermissions & Constants::PERMISSION_SHARE) {
-			$ocmPermissions[] = 'share';
-		}
-
-		if ($ncPermissions & Constants::PERMISSION_READ) {
-			$ocmPermissions[] = 'read';
-		}
-
-		if (($ncPermissions & Constants::PERMISSION_CREATE) ||
-			($ncPermissions & Constants::PERMISSION_UPDATE)) {
-			$ocmPermissions[] = 'write';
-		}
-
-		return $ocmPermissions;
-	}
-
-	/**
-	 * Update ownCloud-specific properties
-	 *
-	 * @param string $path
-	 * @param PropPatch $propPatch
-	 *
-	 * @return void
-	 */
-	public function handleUpdateProperties($path, PropPatch $propPatch) {
-		$node = $this->tree->getNodeForPath($path);
-		if (!($node instanceof Node)) {
-			return;
-		}
-
-		$propPatch->handle(self::LASTMODIFIED_PROPERTYNAME, function ($time) use ($node) {
-			if (empty($time)) {
-				return false;
-			}
-			$node->touch($time);
-			return true;
-		});
-		$propPatch->handle(self::GETETAG_PROPERTYNAME, function ($etag) use ($node) {
-			if (empty($etag)) {
-				return false;
-			}
-			return $node->setEtag($etag) !== -1;
-		});
-		$propPatch->handle(self::CREATIONDATE_PROPERTYNAME, function ($time) use ($node) {
-			if (empty($time)) {
-				return false;
-			}
-			$dateTime = new \DateTimeImmutable($time);
-			$node->setCreationTime($dateTime->getTimestamp());
-			return true;
-		});
-		$propPatch->handle(self::CREATION_TIME_PROPERTYNAME, function ($time) use ($node) {
-			if (empty($time)) {
-				return false;
-			}
-			$node->setCreationTime((int)$time);
-			return true;
-		});
-
-		$this->handleUpdatePropertiesMetadata($propPatch, $node);
-
-		/**
-		 * Disable modification of the displayname property for files and
-		 * folders via PROPPATCH. See PROPFIND for more information.
-		 */
-		$propPatch->handle(self::DISPLAYNAME_PROPERTYNAME, function ($displayName) {
-			return 403;
-		});
-	}
-
-
-	/**
-	 * handle the update of metadata from PROPPATCH requests
-	 *
-	 * @param PropPatch $propPatch
-	 * @param Node $node
-	 *
-	 * @throws FilesMetadataException
-	 */
-	private function handleUpdatePropertiesMetadata(PropPatch $propPatch, Node $node): void {
-		$userId = $this->userSession->getUser()?->getUID();
-		if ($userId === null) {
-			return;
-		}
-
-		$accessRight = $this->getMetadataFileAccessRight($node, $userId);
-		$filesMetadataManager = $this->initFilesMetadataManager();
-		$knownMetadata = $filesMetadataManager->getKnownMetadata();
-
-		foreach ($propPatch->getRemainingMutations() as $mutation) {
-			if (!str_starts_with($mutation, self::FILE_METADATA_PREFIX)) {
-				continue;
-			}
-
-			$propPatch->handle(
-				$mutation,
-				function (mixed $value) use ($accessRight, $knownMetadata, $node, $mutation, $filesMetadataManager): bool {
-					/** @var FilesMetadata $metadata */
-					$metadata = $filesMetadataManager->getMetadata((int)$node->getFileId(), true);
-					$metadata->setStorageId($node->getNode()->getStorage()->getCache()->getNumericStorageId());
-					$metadataKey = substr($mutation, strlen(self::FILE_METADATA_PREFIX));
-
-					// confirm metadata key is editable via PROPPATCH
-					if ($knownMetadata->getEditPermission($metadataKey) < $accessRight) {
-						throw new FilesMetadataException('you do not have enough rights to update \'' . $metadataKey . '\' on this node');
-					}
-
-					if ($value === null) {
-						$metadata->unset($metadataKey);
-						$filesMetadataManager->saveMetadata($metadata);
-						return true;
-					}
-
-					// If the metadata is unknown, it defaults to string.
-					try {
-						$type = $knownMetadata->getType($metadataKey);
-					} catch (FilesMetadataNotFoundException) {
-						$type = IMetadataValueWrapper::TYPE_STRING;
-					}
-
-					switch ($type) {
-						case IMetadataValueWrapper::TYPE_STRING:
-							$metadata->setString($metadataKey, $value, $knownMetadata->isIndex($metadataKey));
-							break;
-						case IMetadataValueWrapper::TYPE_INT:
-							$metadata->setInt($metadataKey, $value, $knownMetadata->isIndex($metadataKey));
-							break;
-						case IMetadataValueWrapper::TYPE_FLOAT:
-							$metadata->setFloat($metadataKey, $value);
-							break;
-						case IMetadataValueWrapper::TYPE_BOOL:
-							$metadata->setBool($metadataKey, $value, $knownMetadata->isIndex($metadataKey));
-							break;
-						case IMetadataValueWrapper::TYPE_ARRAY:
-							$metadata->setArray($metadataKey, $value);
-							break;
-						case IMetadataValueWrapper::TYPE_STRING_LIST:
-							$metadata->setStringList($metadataKey, $value, $knownMetadata->isIndex($metadataKey));
-							break;
-						case IMetadataValueWrapper::TYPE_INT_LIST:
-							$metadata->setIntList($metadataKey, $value, $knownMetadata->isIndex($metadataKey));
-							break;
-					}
-
-					$filesMetadataManager->saveMetadata($metadata);
-
-					return true;
-				}
-			);
-		}
-	}
-
-	/**
-	 * init default internal metadata
-	 *
-	 * @return IFilesMetadataManager
-	 */
-	private function initFilesMetadataManager(): IFilesMetadataManager {
-		/** @var IFilesMetadataManager $manager */
-		$manager = \OCP\Server::get(IFilesMetadataManager::class);
-		$manager->initMetadata('files-live-photo', IMetadataValueWrapper::TYPE_STRING, false, IMetadataValueWrapper::EDIT_REQ_OWNERSHIP);
-
-		return $manager;
-	}
-
-	/**
-	 * based on owner and shares, returns the bottom limit to update related metadata
-	 *
-	 * @param Node $node
-	 * @param string $userId
-	 *
-	 * @return int
-	 */
-	private function getMetadataFileAccessRight(Node $node, string $userId): int {
-		if ($node->getOwner()?->getUID() === $userId) {
-			return IMetadataValueWrapper::EDIT_REQ_OWNERSHIP;
-		} else {
-			$filePermissions = $node->getSharePermissions($userId);
-			if ($filePermissions & Constants::PERMISSION_UPDATE) {
-				return IMetadataValueWrapper::EDIT_REQ_WRITE_PERMISSION;
-			}
-		}
-
-		return IMetadataValueWrapper::EDIT_REQ_READ_PERMISSION;
-	}
-
-	/**
-	 * @param string $filePath
-	 * @param ?\Sabre\DAV\INode $node
-	 * @return void
-	 * @throws \Sabre\DAV\Exception\BadRequest
-	 */
-	public function sendFileIdHeader($filePath, ?\Sabre\DAV\INode $node = null) {
-		// we get the node for the given $filePath here because in case of afterCreateFile $node is the parent folder
-		if (!$this->server->tree->nodeExists($filePath)) {
-			return;
-		}
-		$node = $this->server->tree->getNodeForPath($filePath);
-		if ($node instanceof Node) {
-			$fileId = $node->getFileId();
-			if (!is_null($fileId)) {
-				$this->server->httpResponse->setHeader('OC-FileId', $fileId);
-			}
-		}
-	}
+    // namespace
+    public const NS_OWNCLOUD = 'http://owncloud.org/ns';
+    public const NS_NEXTCLOUD = 'http://nextcloud.org/ns';
+    public const FILEID_PROPERTYNAME = '{http://owncloud.org/ns}id';
+    public const INTERNAL_FILEID_PROPERTYNAME = '{http://owncloud.org/ns}fileid';
+    public const PERMISSIONS_PROPERTYNAME = '{http://owncloud.org/ns}permissions';
+    public const SHARE_PERMISSIONS_PROPERTYNAME = '{http://open-collaboration-services.org/ns}share-permissions';
+    public const OCM_SHARE_PERMISSIONS_PROPERTYNAME = '{http://open-cloud-mesh.org/ns}share-permissions';
+    public const SHARE_ATTRIBUTES_PROPERTYNAME = '{http://nextcloud.org/ns}share-attributes';
+    public const DOWNLOADURL_PROPERTYNAME = '{http://owncloud.org/ns}downloadURL';
+    public const SIZE_PROPERTYNAME = '{http://owncloud.org/ns}size';
+    public const GETETAG_PROPERTYNAME = '{DAV:}getetag';
+    public const LASTMODIFIED_PROPERTYNAME = '{DAV:}lastmodified';
+    public const CREATIONDATE_PROPERTYNAME = '{DAV:}creationdate';
+    public const DISPLAYNAME_PROPERTYNAME = '{DAV:}displayname';
+    public const OWNER_ID_PROPERTYNAME = '{http://owncloud.org/ns}owner-id';
+    public const OWNER_DISPLAY_NAME_PROPERTYNAME = '{http://owncloud.org/ns}owner-display-name';
+    public const CHECKSUMS_PROPERTYNAME = '{http://owncloud.org/ns}checksums';
+    public const DATA_FINGERPRINT_PROPERTYNAME = '{http://owncloud.org/ns}data-fingerprint';
+    public const HAS_PREVIEW_PROPERTYNAME = '{http://nextcloud.org/ns}has-preview';
+    public const MOUNT_TYPE_PROPERTYNAME = '{http://nextcloud.org/ns}mount-type';
+    public const MOUNT_ROOT_PROPERTYNAME = '{http://nextcloud.org/ns}is-mount-root';
+    public const IS_FEDERATED_PROPERTYNAME = '{http://nextcloud.org/ns}is-federated';
+    public const METADATA_ETAG_PROPERTYNAME = '{http://nextcloud.org/ns}metadata_etag';
+    public const UPLOAD_TIME_PROPERTYNAME = '{http://nextcloud.org/ns}upload_time';
+    public const CREATION_TIME_PROPERTYNAME = '{http://nextcloud.org/ns}creation_time';
+    public const SHARE_NOTE = '{http://nextcloud.org/ns}note';
+    public const SHARE_HIDE_DOWNLOAD_PROPERTYNAME = '{http://nextcloud.org/ns}hide-download';
+    public const SUBFOLDER_COUNT_PROPERTYNAME = '{http://nextcloud.org/ns}contained-folder-count';
+    public const SUBFILE_COUNT_PROPERTYNAME = '{http://nextcloud.org/ns}contained-file-count';
+    public const FILE_METADATA_PREFIX = '{http://nextcloud.org/ns}metadata-';
+    public const HIDDEN_PROPERTYNAME = '{http://nextcloud.org/ns}hidden';
+
+    /** Reference to main server object */
+    private ?Server $server = null;
+
+    /**
+     * @param Tree $tree
+     * @param IConfig $config
+     * @param IRequest $request
+     * @param IPreview $previewManager
+     * @param IUserSession $userSession
+     * @param bool $isPublic Whether this is public WebDAV. If true, some returned information will be stripped off.
+     * @param bool $downloadAttachment
+     * @return void
+     */
+    public function __construct(
+        private Tree $tree,
+        private IConfig $config,
+        private IRequest $request,
+        private IPreview $previewManager,
+        private IUserSession $userSession,
+        private IFilenameValidator $validator,
+        private IAccountManager $accountManager,
+        private bool $isPublic = false,
+        private bool $downloadAttachment = true,
+    ) {
+    }
+
+    /**
+     * This initializes the plugin.
+     *
+     * This function is called by \Sabre\DAV\Server, after
+     * addPlugin is called.
+     *
+     * This method should set up the required event subscriptions.
+     *
+     * @return void
+     */
+    public function initialize(Server $server) {
+        $server->xml->namespaceMap[self::NS_OWNCLOUD] = 'oc';
+        $server->xml->namespaceMap[self::NS_NEXTCLOUD] = 'nc';
+        $server->protectedProperties[] = self::FILEID_PROPERTYNAME;
+        $server->protectedProperties[] = self::INTERNAL_FILEID_PROPERTYNAME;
+        $server->protectedProperties[] = self::PERMISSIONS_PROPERTYNAME;
+        $server->protectedProperties[] = self::SHARE_PERMISSIONS_PROPERTYNAME;
+        $server->protectedProperties[] = self::OCM_SHARE_PERMISSIONS_PROPERTYNAME;
+        $server->protectedProperties[] = self::SHARE_ATTRIBUTES_PROPERTYNAME;
+        $server->protectedProperties[] = self::SIZE_PROPERTYNAME;
+        $server->protectedProperties[] = self::DOWNLOADURL_PROPERTYNAME;
+        $server->protectedProperties[] = self::OWNER_ID_PROPERTYNAME;
+        $server->protectedProperties[] = self::OWNER_DISPLAY_NAME_PROPERTYNAME;
+        $server->protectedProperties[] = self::CHECKSUMS_PROPERTYNAME;
+        $server->protectedProperties[] = self::DATA_FINGERPRINT_PROPERTYNAME;
+        $server->protectedProperties[] = self::HAS_PREVIEW_PROPERTYNAME;
+        $server->protectedProperties[] = self::MOUNT_TYPE_PROPERTYNAME;
+        $server->protectedProperties[] = self::IS_FEDERATED_PROPERTYNAME;
+        $server->protectedProperties[] = self::SHARE_NOTE;
+
+        // normally these cannot be changed (RFC4918), but we want them modifiable through PROPPATCH
+        $allowedProperties = ['{DAV:}getetag'];
+        $server->protectedProperties = array_diff($server->protectedProperties, $allowedProperties);
+
+        $this->server = $server;
+        $this->server->on('propFind', [$this, 'handleGetProperties']);
+        $this->server->on('propPatch', [$this, 'handleUpdateProperties']);
+        $this->server->on('afterBind', [$this, 'sendFileIdHeader']);
+        $this->server->on('afterWriteContent', [$this, 'sendFileIdHeader']);
+        $this->server->on('afterMethod:GET', [$this,'httpGet']);
+        $this->server->on('afterMethod:GET', [$this, 'handleDownloadToken']);
+        $this->server->on('afterResponse', function ($request, ResponseInterface $response): void {
+            $body = $response->getBody();
+            if (is_resource($body)) {
+                fclose($body);
+            }
+        });
+        $this->server->on('beforeMove', [$this, 'checkMove']);
+        $this->server->on('beforeCopy', [$this, 'checkCopy']);
+    }
+
+    /**
+     * Plugin that checks if a copy can actually be performed.
+     *
+     * @param string $source source path
+     * @param string $target target path
+     * @throws NotFound If the source does not exist
+     * @throws InvalidPath If the target is invalid
+     */
+    public function checkCopy($source, $target): void {
+        $sourceNode = $this->tree->getNodeForPath($source);
+        if (!$sourceNode instanceof Node) {
+            return;
+        }
+
+        // Ensure source exists
+        $sourceNodeFileInfo = $sourceNode->getFileInfo();
+        if ($sourceNodeFileInfo === null) {
+            throw new NotFound($source . ' does not exist');
+        }
+        // Ensure the target name is valid
+        try {
+            [$targetPath, $targetName] = \Sabre\Uri\split($target);
+            $this->validator->validateFilename($targetName);
+        } catch (InvalidPathException $e) {
+            throw new InvalidPath($e->getMessage(), false);
+        }
+        // Ensure the target path is valid
+        $segments = array_slice(explode('/', $targetPath), 2);
+        foreach ($segments as $segment) {
+            if ($this->validator->isFilenameValid($segment) === false) {
+                $l = \OCP\Server::get(IFactory::class)->get('dav');
+                throw new InvalidPath($l->t('Invalid target path'));
+            }
+        }
+    }
+
+    /**
+     * Plugin that checks if a move can actually be performed.
+     *
+     * @param string $source source path
+     * @param string $target target path
+     * @throws Forbidden If the source is not deletable
+     * @throws NotFound If the source does not exist
+     * @throws InvalidPath If the target name is invalid
+     */
+    public function checkMove(string $source, string $target): void {
+        $sourceNode = $this->tree->getNodeForPath($source);
+        if (!$sourceNode instanceof Node) {
+            return;
+        }
+
+        // First check copyable (move only needs additional delete permission)
+        $this->checkCopy($source, $target);
+
+        // The source needs to be deletable for moving
+        $sourceNodeFileInfo = $sourceNode->getFileInfo();
+        if (!$sourceNodeFileInfo->isDeletable()) {
+            throw new Forbidden($source . ' cannot be deleted');
+        }
+
+        // The source is not allowed to be the parent of the target
+        if (str_starts_with($source, $target . '/')) {
+            throw new Forbidden($source . ' cannot be moved to it\'s parent');
+        }
+    }
+
+    /**
+     * This sets a cookie to be able to recognize the start of the download
+     * the content must not be longer than 32 characters and must only contain
+     * alphanumeric characters
+     *
+     * @param RequestInterface $request
+     * @param ResponseInterface $response
+     */
+    public function handleDownloadToken(RequestInterface $request, ResponseInterface $response) {
+        $queryParams = $request->getQueryParameters();
+
+        /**
+         * this sets a cookie to be able to recognize the start of the download
+         * the content must not be longer than 32 characters and must only contain
+         * alphanumeric characters
+         */
+        if (isset($queryParams['downloadStartSecret'])) {
+            $token = $queryParams['downloadStartSecret'];
+            if (!isset($token[32])
+                && preg_match('!^[a-zA-Z0-9]+$!', $token) === 1) {
+                // FIXME: use $response->setHeader() instead
+                setcookie('ocDownloadStarted', $token, time() + 20, '/');
+            }
+        }
+    }
+
+    /**
+     * Add headers to file download
+     *
+     * @param RequestInterface $request
+     * @param ResponseInterface $response
+     */
+    public function httpGet(RequestInterface $request, ResponseInterface $response) {
+        // Only handle valid files
+        $node = $this->tree->getNodeForPath($request->getPath());
+        if (!($node instanceof IFile)) {
+            return;
+        }
+
+        // adds a 'Content-Disposition: attachment' header in case no disposition
+        // header has been set before
+        if ($this->downloadAttachment &&
+            $response->getHeader('Content-Disposition') === null) {
+            $filename = $node->getName();
+            if ($this->request->isUserAgent(
+                [
+                    Request::USER_AGENT_IE,
+                    Request::USER_AGENT_ANDROID_MOBILE_CHROME,
+                    Request::USER_AGENT_FREEBOX,
+                ])) {
+                $response->addHeader('Content-Disposition', 'attachment; filename="' . rawurlencode($filename) . '"');
+            } else {
+                $response->addHeader('Content-Disposition', 'attachment; filename*=UTF-8\'\'' . rawurlencode($filename)
+                                                        . '; filename="' . rawurlencode($filename) . '"');
+            }
+        }
+
+        if ($node instanceof File) {
+            //Add OC-Checksum header
+            $checksum = $node->getChecksum();
+            if ($checksum !== null && $checksum !== '') {
+                $response->addHeader('OC-Checksum', $checksum);
+            }
+        }
+        $response->addHeader('X-Accel-Buffering', 'no');
+    }
+
+    /**
+     * Adds all ownCloud-specific properties
+     *
+     * @param PropFind $propFind
+     * @param \Sabre\DAV\INode $node
+     * @return void
+     */
+    public function handleGetProperties(PropFind $propFind, \Sabre\DAV\INode $node) {
+        $httpRequest = $this->server->httpRequest;
+
+        if ($node instanceof Node) {
+            /**
+             * This was disabled, because it made dir listing throw an exception,
+             * so users were unable to navigate into folders where one subitem
+             * is blocked by the files_accesscontrol app, see:
+             * https://github.com/nextcloud/files_accesscontrol/issues/65
+             * if (!$node->getFileInfo()->isReadable()) {
+             *     // avoid detecting files through this means
+             *     throw new NotFound();
+             * }
+             */
+
+            $propFind->handle(self::FILEID_PROPERTYNAME, function () use ($node) {
+                return $node->getFileId();
+            });
+
+            $propFind->handle(self::INTERNAL_FILEID_PROPERTYNAME, function () use ($node) {
+                return $node->getInternalFileId();
+            });
+
+            $propFind->handle(self::PERMISSIONS_PROPERTYNAME, function () use ($node) {
+                $perms = $node->getDavPermissions();
+                if ($this->isPublic) {
+                    // remove mount information
+                    $perms = str_replace(['S', 'M'], '', $perms);
+                }
+                return $perms;
+            });
+
+            $propFind->handle(self::SHARE_PERMISSIONS_PROPERTYNAME, function () use ($node, $httpRequest) {
+                $user = $this->userSession->getUser();
+                if ($user === null) {
+                    return null;
+                }
+                return $node->getSharePermissions(
+                    $user->getUID()
+                );
+            });
+
+            $propFind->handle(self::OCM_SHARE_PERMISSIONS_PROPERTYNAME, function () use ($node, $httpRequest): ?string {
+                $user = $this->userSession->getUser();
+                if ($user === null) {
+                    return null;
+                }
+                $ncPermissions = $node->getSharePermissions(
+                    $user->getUID()
+                );
+                $ocmPermissions = $this->ncPermissions2ocmPermissions($ncPermissions);
+                return json_encode($ocmPermissions, JSON_THROW_ON_ERROR);
+            });
+
+            $propFind->handle(self::SHARE_ATTRIBUTES_PROPERTYNAME, function () use ($node, $httpRequest) {
+                return json_encode($node->getShareAttributes(), JSON_THROW_ON_ERROR);
+            });
+
+            $propFind->handle(self::GETETAG_PROPERTYNAME, function () use ($node): string {
+                return $node->getETag();
+            });
+
+            $propFind->handle(self::OWNER_ID_PROPERTYNAME, function () use ($node): ?string {
+                $owner = $node->getOwner();
+                if (!$owner) {
+                    return null;
+                } else {
+                    return $owner->getUID();
+                }
+            });
+            $propFind->handle(self::OWNER_DISPLAY_NAME_PROPERTYNAME, function () use ($node): ?string {
+                $owner = $node->getOwner();
+                if (!$owner) {
+                    return null;
+                }
+
+                // Get current user to see if we're in a public share or not
+                $user = $this->userSession->getUser();
+
+                // If the user is logged in, we can return the display name
+                if ($user !== null) {
+                    return $owner->getDisplayName();
+                }
+
+                // Check if the user published their display name
+                $ownerAccount = $this->accountManager->getAccount($owner);
+                $ownerNameProperty = $ownerAccount->getProperty(IAccountManager::PROPERTY_DISPLAYNAME);
+
+                // Since we are not logged in, we need to have at least the published scope
+                if ($ownerNameProperty->getScope() === IAccountManager::SCOPE_PUBLISHED) {
+                    return $owner->getDisplayName();
+                }
+
+                return null;
+            });
+
+            $propFind->handle(self::HAS_PREVIEW_PROPERTYNAME, function () use ($node) {
+                return json_encode($this->previewManager->isAvailable($node->getFileInfo()), JSON_THROW_ON_ERROR);
+            });
+            $propFind->handle(self::SIZE_PROPERTYNAME, function () use ($node): int|float {
+                return $node->getSize();
+            });
+            $propFind->handle(self::MOUNT_TYPE_PROPERTYNAME, function () use ($node) {
+                return $node->getFileInfo()->getMountPoint()->getMountType();
+            });
+
+            /**
+             * This is a special property which is used to determine if a node
+             * is a mount root or not, e.g. a shared folder.
+             * If so, then the node can only be unshared and not deleted.
+             * @see https://github.com/nextcloud/server/blob/cc75294eb6b16b916a342e69998935f89222619d/lib/private/Files/View.php#L696-L698
+             */
+            $propFind->handle(self::MOUNT_ROOT_PROPERTYNAME, function () use ($node) {
+                return $node->getNode()->getInternalPath() === '' ? 'true' : 'false';
+            });
+
+            $propFind->handle(self::SHARE_NOTE, function () use ($node): ?string {
+                $user = $this->userSession->getUser();
+                return $node->getNoteFromShare(
+                    $user?->getUID()
+                );
+            });
+
+            $propFind->handle(self::SHARE_HIDE_DOWNLOAD_PROPERTYNAME, function () use ($node) {
+                $storage = $node->getNode()->getStorage();
+                if ($storage->instanceOfStorage(ISharedStorage::class)) {
+                    /** @var ISharedStorage $storage */
+                    return match($storage->getShare()->getHideDownload()) {
+                        true => 'true',
+                        false => 'false',
+                    };
+                } else {
+                    return null;
+                }
+            });
+
+            $propFind->handle(self::DATA_FINGERPRINT_PROPERTYNAME, function () {
+                return $this->config->getSystemValue('data-fingerprint', '');
+            });
+            $propFind->handle(self::CREATIONDATE_PROPERTYNAME, function () use ($node) {
+                return (new \DateTimeImmutable())
+                    ->setTimestamp($node->getFileInfo()->getCreationTime())
+                    ->format(\DateTimeInterface::ATOM);
+            });
+            $propFind->handle(self::CREATION_TIME_PROPERTYNAME, function () use ($node) {
+                return $node->getFileInfo()->getCreationTime();
+            });
+
+            foreach ($node->getFileInfo()->getMetadata() as $metadataKey => $metadataValue) {
+                $propFind->handle(self::FILE_METADATA_PREFIX . $metadataKey, $metadataValue);
+            }
+
+            $propFind->handle(self::HIDDEN_PROPERTYNAME, function () use ($node) {
+                $isLivePhoto = isset($node->getFileInfo()->getMetadata()['files-live-photo']);
+                $isMovFile = $node->getFileInfo()->getMimetype() === 'video/quicktime';
+                return ($isLivePhoto && $isMovFile) ? 'true' : 'false';
+            });
+
+            /**
+             * Return file/folder name as displayname. The primary reason to
+             * implement it this way is to avoid costly fallback to
+             * CustomPropertiesBackend (esp. visible when querying all files
+             * in a folder).
+             */
+            $propFind->handle(self::DISPLAYNAME_PROPERTYNAME, function () use ($node) {
+                return $node->getName();
+            });
+
+            $propFind->handle(self::IS_FEDERATED_PROPERTYNAME, function () use ($node) {
+                return $node->getFileInfo()->getMountPoint()
+                    instanceof SharingExternalMount;
+            });
+        }
+
+        if ($node instanceof File) {
+            $propFind->handle(self::DOWNLOADURL_PROPERTYNAME, function () use ($node) {
+                try {
+                    $directDownloadUrl = $node->getDirectDownload();
+                    if (isset($directDownloadUrl['url'])) {
+                        return $directDownloadUrl['url'];
+                    }
+                } catch (StorageNotAvailableException $e) {
+                    return false;
+                } catch (ForbiddenException $e) {
+                    return false;
+                }
+                return false;
+            });
+
+            $propFind->handle(self::CHECKSUMS_PROPERTYNAME, function () use ($node) {
+                $checksum = $node->getChecksum();
+                if ($checksum === null || $checksum === '') {
+                    return null;
+                }
+
+                return new ChecksumList($checksum);
+            });
+
+            $propFind->handle(self::UPLOAD_TIME_PROPERTYNAME, function () use ($node) {
+                return $node->getFileInfo()->getUploadTime();
+            });
+        }
+
+        if ($node instanceof Directory) {
+            $propFind->handle(self::SIZE_PROPERTYNAME, function () use ($node) {
+                return $node->getSize();
+            });
+
+            $requestProperties = $propFind->getRequestedProperties();
+
+            if (in_array(self::SUBFILE_COUNT_PROPERTYNAME, $requestProperties, true)
+                || in_array(self::SUBFOLDER_COUNT_PROPERTYNAME, $requestProperties, true)) {
+                $nbFiles = 0;
+                $nbFolders = 0;
+                foreach ($node->getChildren() as $child) {
+                    if ($child instanceof File) {
+                        $nbFiles++;
+                    } elseif ($child instanceof Directory) {
+                        $nbFolders++;
+                    }
+                }
+
+                $propFind->handle(self::SUBFILE_COUNT_PROPERTYNAME, $nbFiles);
+                $propFind->handle(self::SUBFOLDER_COUNT_PROPERTYNAME, $nbFolders);
+            }
+        }
+    }
+
+    /**
+     * translate Nextcloud permissions to OCM Permissions
+     *
+     * @param $ncPermissions
+     * @return array
+     */
+    protected function ncPermissions2ocmPermissions($ncPermissions) {
+        $ocmPermissions = [];
+
+        if ($ncPermissions & Constants::PERMISSION_SHARE) {
+            $ocmPermissions[] = 'share';
+        }
+
+        if ($ncPermissions & Constants::PERMISSION_READ) {
+            $ocmPermissions[] = 'read';
+        }
+
+        if (($ncPermissions & Constants::PERMISSION_CREATE) ||
+            ($ncPermissions & Constants::PERMISSION_UPDATE)) {
+            $ocmPermissions[] = 'write';
+        }
+
+        return $ocmPermissions;
+    }
+
+    /**
+     * Update ownCloud-specific properties
+     *
+     * @param string $path
+     * @param PropPatch $propPatch
+     *
+     * @return void
+     */
+    public function handleUpdateProperties($path, PropPatch $propPatch) {
+        $node = $this->tree->getNodeForPath($path);
+        if (!($node instanceof Node)) {
+            return;
+        }
+
+        $propPatch->handle(self::LASTMODIFIED_PROPERTYNAME, function ($time) use ($node) {
+            if (empty($time)) {
+                return false;
+            }
+            $node->touch($time);
+            return true;
+        });
+        $propPatch->handle(self::GETETAG_PROPERTYNAME, function ($etag) use ($node) {
+            if (empty($etag)) {
+                return false;
+            }
+            return $node->setEtag($etag) !== -1;
+        });
+        $propPatch->handle(self::CREATIONDATE_PROPERTYNAME, function ($time) use ($node) {
+            if (empty($time)) {
+                return false;
+            }
+            $dateTime = new \DateTimeImmutable($time);
+            $node->setCreationTime($dateTime->getTimestamp());
+            return true;
+        });
+        $propPatch->handle(self::CREATION_TIME_PROPERTYNAME, function ($time) use ($node) {
+            if (empty($time)) {
+                return false;
+            }
+            $node->setCreationTime((int)$time);
+            return true;
+        });
+
+        $this->handleUpdatePropertiesMetadata($propPatch, $node);
+
+        /**
+         * Disable modification of the displayname property for files and
+         * folders via PROPPATCH. See PROPFIND for more information.
+         */
+        $propPatch->handle(self::DISPLAYNAME_PROPERTYNAME, function ($displayName) {
+            return 403;
+        });
+    }
+
+
+    /**
+     * handle the update of metadata from PROPPATCH requests
+     *
+     * @param PropPatch $propPatch
+     * @param Node $node
+     *
+     * @throws FilesMetadataException
+     */
+    private function handleUpdatePropertiesMetadata(PropPatch $propPatch, Node $node): void {
+        $userId = $this->userSession->getUser()?->getUID();
+        if ($userId === null) {
+            return;
+        }
+
+        $accessRight = $this->getMetadataFileAccessRight($node, $userId);
+        $filesMetadataManager = $this->initFilesMetadataManager();
+        $knownMetadata = $filesMetadataManager->getKnownMetadata();
+
+        foreach ($propPatch->getRemainingMutations() as $mutation) {
+            if (!str_starts_with($mutation, self::FILE_METADATA_PREFIX)) {
+                continue;
+            }
+
+            $propPatch->handle(
+                $mutation,
+                function (mixed $value) use ($accessRight, $knownMetadata, $node, $mutation, $filesMetadataManager): bool {
+                    /** @var FilesMetadata $metadata */
+                    $metadata = $filesMetadataManager->getMetadata((int)$node->getFileId(), true);
+                    $metadata->setStorageId($node->getNode()->getStorage()->getCache()->getNumericStorageId());
+                    $metadataKey = substr($mutation, strlen(self::FILE_METADATA_PREFIX));
+
+                    // confirm metadata key is editable via PROPPATCH
+                    if ($knownMetadata->getEditPermission($metadataKey) < $accessRight) {
+                        throw new FilesMetadataException('you do not have enough rights to update \'' . $metadataKey . '\' on this node');
+                    }
+
+                    if ($value === null) {
+                        $metadata->unset($metadataKey);
+                        $filesMetadataManager->saveMetadata($metadata);
+                        return true;
+                    }
+
+                    // If the metadata is unknown, it defaults to string.
+                    try {
+                        $type = $knownMetadata->getType($metadataKey);
+                    } catch (FilesMetadataNotFoundException) {
+                        $type = IMetadataValueWrapper::TYPE_STRING;
+                    }
+
+                    switch ($type) {
+                        case IMetadataValueWrapper::TYPE_STRING:
+                            $metadata->setString($metadataKey, $value, $knownMetadata->isIndex($metadataKey));
+                            break;
+                        case IMetadataValueWrapper::TYPE_INT:
+                            $metadata->setInt($metadataKey, $value, $knownMetadata->isIndex($metadataKey));
+                            break;
+                        case IMetadataValueWrapper::TYPE_FLOAT:
+                            $metadata->setFloat($metadataKey, $value);
+                            break;
+                        case IMetadataValueWrapper::TYPE_BOOL:
+                            $metadata->setBool($metadataKey, $value, $knownMetadata->isIndex($metadataKey));
+                            break;
+                        case IMetadataValueWrapper::TYPE_ARRAY:
+                            $metadata->setArray($metadataKey, $value);
+                            break;
+                        case IMetadataValueWrapper::TYPE_STRING_LIST:
+                            $metadata->setStringList($metadataKey, $value, $knownMetadata->isIndex($metadataKey));
+                            break;
+                        case IMetadataValueWrapper::TYPE_INT_LIST:
+                            $metadata->setIntList($metadataKey, $value, $knownMetadata->isIndex($metadataKey));
+                            break;
+                    }
+
+                    $filesMetadataManager->saveMetadata($metadata);
+
+                    return true;
+                }
+            );
+        }
+    }
+
+    /**
+     * init default internal metadata
+     *
+     * @return IFilesMetadataManager
+     */
+    private function initFilesMetadataManager(): IFilesMetadataManager {
+        /** @var IFilesMetadataManager $manager */
+        $manager = \OCP\Server::get(IFilesMetadataManager::class);
+        $manager->initMetadata('files-live-photo', IMetadataValueWrapper::TYPE_STRING, false, IMetadataValueWrapper::EDIT_REQ_OWNERSHIP);
+
+        return $manager;
+    }
+
+    /**
+     * based on owner and shares, returns the bottom limit to update related metadata
+     *
+     * @param Node $node
+     * @param string $userId
+     *
+     * @return int
+     */
+    private function getMetadataFileAccessRight(Node $node, string $userId): int {
+        if ($node->getOwner()?->getUID() === $userId) {
+            return IMetadataValueWrapper::EDIT_REQ_OWNERSHIP;
+        } else {
+            $filePermissions = $node->getSharePermissions($userId);
+            if ($filePermissions & Constants::PERMISSION_UPDATE) {
+                return IMetadataValueWrapper::EDIT_REQ_WRITE_PERMISSION;
+            }
+        }
+
+        return IMetadataValueWrapper::EDIT_REQ_READ_PERMISSION;
+    }
+
+    /**
+     * @param string $filePath
+     * @param ?\Sabre\DAV\INode $node
+     * @return void
+     * @throws \Sabre\DAV\Exception\BadRequest
+     */
+    public function sendFileIdHeader($filePath, ?\Sabre\DAV\INode $node = null) {
+        // we get the node for the given $filePath here because in case of afterCreateFile $node is the parent folder
+        if (!$this->server->tree->nodeExists($filePath)) {
+            return;
+        }
+        $node = $this->server->tree->getNodeForPath($filePath);
+        if ($node instanceof Node) {
+            $fileId = $node->getFileId();
+            if (!is_null($fileId)) {
+                $this->server->httpResponse->setHeader('OC-FileId', $fileId);
+            }
+        }
+    }
 }

Spacing +44 added lines, -44 removed lines

@@ -137,9 +137,9 @@ 
 		$this->server->on('propPatch', [$this, 'handleUpdateProperties']);
 		$this->server->on('afterBind', [$this, 'sendFileIdHeader']);
 		$this->server->on('afterWriteContent', [$this, 'sendFileIdHeader']);
-		$this->server->on('afterMethod:GET', [$this,'httpGet']);
+		$this->server->on('afterMethod:GET', [$this, 'httpGet']);
 		$this->server->on('afterMethod:GET', [$this, 'handleDownloadToken']);
-		$this->server->on('afterResponse', function ($request, ResponseInterface $response): void {
+		$this->server->on('afterResponse', function($request, ResponseInterface $response): void {
 			$body = $response->getBody();
 			if (is_resource($body)) {
 				fclose($body);
@@ -166,7 +166,7 @@ 
 		// Ensure source exists
 		$sourceNodeFileInfo = $sourceNode->getFileInfo();
 		if ($sourceNodeFileInfo === null) {
-			throw new NotFound($source . ' does not exist');
+			throw new NotFound($source.' does not exist');
 		}
 		// Ensure the target name is valid
 		try {
@@ -206,12 +206,12 @@ 
 		// The source needs to be deletable for moving
 		$sourceNodeFileInfo = $sourceNode->getFileInfo();
 		if (!$sourceNodeFileInfo->isDeletable()) {
-			throw new Forbidden($source . ' cannot be deleted');
+			throw new Forbidden($source.' cannot be deleted');
 		}
 
 		// The source is not allowed to be the parent of the target
-		if (str_starts_with($source, $target . '/')) {
-			throw new Forbidden($source . ' cannot be moved to it\'s parent');
+		if (str_starts_with($source, $target.'/')) {
+			throw new Forbidden($source.' cannot be moved to it\'s parent');
 		}
 	}
 
@@ -265,10 +265,10 @@ 
 					Request::USER_AGENT_ANDROID_MOBILE_CHROME,
 					Request::USER_AGENT_FREEBOX,
 				])) {
-				$response->addHeader('Content-Disposition', 'attachment; filename="' . rawurlencode($filename) . '"');
+				$response->addHeader('Content-Disposition', 'attachment; filename="'.rawurlencode($filename).'"');
 			} else {
-				$response->addHeader('Content-Disposition', 'attachment; filename*=UTF-8\'\'' . rawurlencode($filename)
-													 . '; filename="' . rawurlencode($filename) . '"');
+				$response->addHeader('Content-Disposition', 'attachment; filename*=UTF-8\'\''.rawurlencode($filename)
+													 . '; filename="'.rawurlencode($filename).'"');
 			}
 		}
 
@@ -304,15 +304,15 @@ 
 			 * }
 			 */
 
-			$propFind->handle(self::FILEID_PROPERTYNAME, function () use ($node) {
+			$propFind->handle(self::FILEID_PROPERTYNAME, function() use ($node) {
 				return $node->getFileId();
 			});
 
-			$propFind->handle(self::INTERNAL_FILEID_PROPERTYNAME, function () use ($node) {
+			$propFind->handle(self::INTERNAL_FILEID_PROPERTYNAME, function() use ($node) {
 				return $node->getInternalFileId();
 			});
 
-			$propFind->handle(self::PERMISSIONS_PROPERTYNAME, function () use ($node) {
+			$propFind->handle(self::PERMISSIONS_PROPERTYNAME, function() use ($node) {
 				$perms = $node->getDavPermissions();
 				if ($this->isPublic) {
 					// remove mount information
@@ -321,7 +321,7 @@ 
 				return $perms;
 			});
 
-			$propFind->handle(self::SHARE_PERMISSIONS_PROPERTYNAME, function () use ($node, $httpRequest) {
+			$propFind->handle(self::SHARE_PERMISSIONS_PROPERTYNAME, function() use ($node, $httpRequest) {
 				$user = $this->userSession->getUser();
 				if ($user === null) {
 					return null;
@@ -331,7 +331,7 @@ 
 				);
 			});
 
-			$propFind->handle(self::OCM_SHARE_PERMISSIONS_PROPERTYNAME, function () use ($node, $httpRequest): ?string {
+			$propFind->handle(self::OCM_SHARE_PERMISSIONS_PROPERTYNAME, function() use ($node, $httpRequest): ?string {
 				$user = $this->userSession->getUser();
 				if ($user === null) {
 					return null;
@@ -343,15 +343,15 @@ 
 				return json_encode($ocmPermissions, JSON_THROW_ON_ERROR);
 			});
 
-			$propFind->handle(self::SHARE_ATTRIBUTES_PROPERTYNAME, function () use ($node, $httpRequest) {
+			$propFind->handle(self::SHARE_ATTRIBUTES_PROPERTYNAME, function() use ($node, $httpRequest) {
 				return json_encode($node->getShareAttributes(), JSON_THROW_ON_ERROR);
 			});
 
-			$propFind->handle(self::GETETAG_PROPERTYNAME, function () use ($node): string {
+			$propFind->handle(self::GETETAG_PROPERTYNAME, function() use ($node): string {
 				return $node->getETag();
 			});
 
-			$propFind->handle(self::OWNER_ID_PROPERTYNAME, function () use ($node): ?string {
+			$propFind->handle(self::OWNER_ID_PROPERTYNAME, function() use ($node): ?string {
 				$owner = $node->getOwner();
 				if (!$owner) {
 					return null;
@@ -359,7 +359,7 @@ 
 					return $owner->getUID();
 				}
 			});
-			$propFind->handle(self::OWNER_DISPLAY_NAME_PROPERTYNAME, function () use ($node): ?string {
+			$propFind->handle(self::OWNER_DISPLAY_NAME_PROPERTYNAME, function() use ($node): ?string {
 				$owner = $node->getOwner();
 				if (!$owner) {
 					return null;
@@ -385,13 +385,13 @@ 
 				return null;
 			});
 
-			$propFind->handle(self::HAS_PREVIEW_PROPERTYNAME, function () use ($node) {
+			$propFind->handle(self::HAS_PREVIEW_PROPERTYNAME, function() use ($node) {
 				return json_encode($this->previewManager->isAvailable($node->getFileInfo()), JSON_THROW_ON_ERROR);
 			});
-			$propFind->handle(self::SIZE_PROPERTYNAME, function () use ($node): int|float {
+			$propFind->handle(self::SIZE_PROPERTYNAME, function() use ($node): int | float {
 				return $node->getSize();
 			});
-			$propFind->handle(self::MOUNT_TYPE_PROPERTYNAME, function () use ($node) {
+			$propFind->handle(self::MOUNT_TYPE_PROPERTYNAME, function() use ($node) {
 				return $node->getFileInfo()->getMountPoint()->getMountType();
 			});
 
@@ -401,18 +401,18 @@ 
 			 * If so, then the node can only be unshared and not deleted.
 			 * @see https://github.com/nextcloud/server/blob/cc75294eb6b16b916a342e69998935f89222619d/lib/private/Files/View.php#L696-L698
 			 */
-			$propFind->handle(self::MOUNT_ROOT_PROPERTYNAME, function () use ($node) {
+			$propFind->handle(self::MOUNT_ROOT_PROPERTYNAME, function() use ($node) {
 				return $node->getNode()->getInternalPath() === '' ? 'true' : 'false';
 			});
 
-			$propFind->handle(self::SHARE_NOTE, function () use ($node): ?string {
+			$propFind->handle(self::SHARE_NOTE, function() use ($node): ?string {
 				$user = $this->userSession->getUser();
 				return $node->getNoteFromShare(
 					$user?->getUID()
 				);
 			});
 
-			$propFind->handle(self::SHARE_HIDE_DOWNLOAD_PROPERTYNAME, function () use ($node) {
+			$propFind->handle(self::SHARE_HIDE_DOWNLOAD_PROPERTYNAME, function() use ($node) {
 				$storage = $node->getNode()->getStorage();
 				if ($storage->instanceOfStorage(ISharedStorage::class)) {
 					/** @var ISharedStorage $storage */
@@ -425,23 +425,23 @@ 
 				}
 			});
 
-			$propFind->handle(self::DATA_FINGERPRINT_PROPERTYNAME, function () {
+			$propFind->handle(self::DATA_FINGERPRINT_PROPERTYNAME, function() {
 				return $this->config->getSystemValue('data-fingerprint', '');
 			});
-			$propFind->handle(self::CREATIONDATE_PROPERTYNAME, function () use ($node) {
+			$propFind->handle(self::CREATIONDATE_PROPERTYNAME, function() use ($node) {
 				return (new \DateTimeImmutable())
 					->setTimestamp($node->getFileInfo()->getCreationTime())
 					->format(\DateTimeInterface::ATOM);
 			});
-			$propFind->handle(self::CREATION_TIME_PROPERTYNAME, function () use ($node) {
+			$propFind->handle(self::CREATION_TIME_PROPERTYNAME, function() use ($node) {
 				return $node->getFileInfo()->getCreationTime();
 			});
 
 			foreach ($node->getFileInfo()->getMetadata() as $metadataKey => $metadataValue) {
-				$propFind->handle(self::FILE_METADATA_PREFIX . $metadataKey, $metadataValue);
+				$propFind->handle(self::FILE_METADATA_PREFIX.$metadataKey, $metadataValue);
 			}
 
-			$propFind->handle(self::HIDDEN_PROPERTYNAME, function () use ($node) {
+			$propFind->handle(self::HIDDEN_PROPERTYNAME, function() use ($node) {
 				$isLivePhoto = isset($node->getFileInfo()->getMetadata()['files-live-photo']);
 				$isMovFile = $node->getFileInfo()->getMimetype() === 'video/quicktime';
 				return ($isLivePhoto && $isMovFile) ? 'true' : 'false';
@@ -453,18 +453,18 @@ 
 			 * CustomPropertiesBackend (esp. visible when querying all files
 			 * in a folder).
 			 */
-			$propFind->handle(self::DISPLAYNAME_PROPERTYNAME, function () use ($node) {
+			$propFind->handle(self::DISPLAYNAME_PROPERTYNAME, function() use ($node) {
 				return $node->getName();
 			});
 
-			$propFind->handle(self::IS_FEDERATED_PROPERTYNAME, function () use ($node) {
+			$propFind->handle(self::IS_FEDERATED_PROPERTYNAME, function() use ($node) {
 				return $node->getFileInfo()->getMountPoint()
 					instanceof SharingExternalMount;
 			});
 		}
 
 		if ($node instanceof File) {
-			$propFind->handle(self::DOWNLOADURL_PROPERTYNAME, function () use ($node) {
+			$propFind->handle(self::DOWNLOADURL_PROPERTYNAME, function() use ($node) {
 				try {
 					$directDownloadUrl = $node->getDirectDownload();
 					if (isset($directDownloadUrl['url'])) {
@@ -478,7 +478,7 @@ 
 				return false;
 			});
 
-			$propFind->handle(self::CHECKSUMS_PROPERTYNAME, function () use ($node) {
+			$propFind->handle(self::CHECKSUMS_PROPERTYNAME, function() use ($node) {
 				$checksum = $node->getChecksum();
 				if ($checksum === null || $checksum === '') {
 					return null;
@@ -487,13 +487,13 @@ 
 				return new ChecksumList($checksum);
 			});
 
-			$propFind->handle(self::UPLOAD_TIME_PROPERTYNAME, function () use ($node) {
+			$propFind->handle(self::UPLOAD_TIME_PROPERTYNAME, function() use ($node) {
 				return $node->getFileInfo()->getUploadTime();
 			});
 		}
 
 		if ($node instanceof Directory) {
-			$propFind->handle(self::SIZE_PROPERTYNAME, function () use ($node) {
+			$propFind->handle(self::SIZE_PROPERTYNAME, function() use ($node) {
 				return $node->getSize();
 			});
 
@@ -556,20 +556,20 @@ 
 			return;
 		}
 
-		$propPatch->handle(self::LASTMODIFIED_PROPERTYNAME, function ($time) use ($node) {
+		$propPatch->handle(self::LASTMODIFIED_PROPERTYNAME, function($time) use ($node) {
 			if (empty($time)) {
 				return false;
 			}
 			$node->touch($time);
 			return true;
 		});
-		$propPatch->handle(self::GETETAG_PROPERTYNAME, function ($etag) use ($node) {
+		$propPatch->handle(self::GETETAG_PROPERTYNAME, function($etag) use ($node) {
 			if (empty($etag)) {
 				return false;
 			}
 			return $node->setEtag($etag) !== -1;
 		});
-		$propPatch->handle(self::CREATIONDATE_PROPERTYNAME, function ($time) use ($node) {
+		$propPatch->handle(self::CREATIONDATE_PROPERTYNAME, function($time) use ($node) {
 			if (empty($time)) {
 				return false;
 			}
@@ -577,11 +577,11 @@ 
 			$node->setCreationTime($dateTime->getTimestamp());
 			return true;
 		});
-		$propPatch->handle(self::CREATION_TIME_PROPERTYNAME, function ($time) use ($node) {
+		$propPatch->handle(self::CREATION_TIME_PROPERTYNAME, function($time) use ($node) {
 			if (empty($time)) {
 				return false;
 			}
-			$node->setCreationTime((int)$time);
+			$node->setCreationTime((int) $time);
 			return true;
 		});
 
@@ -591,7 +591,7 @@ 
 		 * Disable modification of the displayname property for files and
 		 * folders via PROPPATCH. See PROPFIND for more information.
 		 */
-		$propPatch->handle(self::DISPLAYNAME_PROPERTYNAME, function ($displayName) {
+		$propPatch->handle(self::DISPLAYNAME_PROPERTYNAME, function($displayName) {
 			return 403;
 		});
 	}
@@ -622,15 +622,15 @@ 
 
 			$propPatch->handle(
 				$mutation,
-				function (mixed $value) use ($accessRight, $knownMetadata, $node, $mutation, $filesMetadataManager): bool {
+				function(mixed $value) use ($accessRight, $knownMetadata, $node, $mutation, $filesMetadataManager): bool {
 					/** @var FilesMetadata $metadata */
-					$metadata = $filesMetadataManager->getMetadata((int)$node->getFileId(), true);
+					$metadata = $filesMetadataManager->getMetadata((int) $node->getFileId(), true);
 					$metadata->setStorageId($node->getNode()->getStorage()->getCache()->getNumericStorageId());
 					$metadataKey = substr($mutation, strlen(self::FILE_METADATA_PREFIX));
 
 					// confirm metadata key is editable via PROPPATCH
 					if ($knownMetadata->getEditPermission($metadataKey) < $accessRight) {
-						throw new FilesMetadataException('you do not have enough rights to update \'' . $metadataKey . '\' on this node');
+						throw new FilesMetadataException('you do not have enough rights to update \''.$metadataKey.'\' on this node');
 					}
 
 					if ($value === null) {