Completed
Pull Request — master (#1144)
by Thomas
26:04 queued 12:45
created
apps/dav/lib/CardDAV/SyncService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -246,7 +246,7 @@
 block discarded – undo
246 246
 	}
247 247
 
248 248
 	/**
249
-	 * @return array|null
249
+	 * @return string
250 250
 	 */
251 251
 	public function getLocalSystemAddressBook() {
252 252
 		if (is_null($this->localSystemAddressBook)) {
Please login to merge, or discard this patch.
apps/dav/lib/Command/CreateAddressBook.php 1 patch
Unused Use Statements   -5 removed lines patch added patch discarded remove patch
@@ -22,11 +22,6 @@
 block discarded – undo
22 22
 namespace OCA\DAV\Command;
23 23
 
24 24
 use OCA\DAV\CardDAV\CardDavBackend;
25
-use OCA\DAV\Connector\Sabre\Principal;
26
-use OCP\IConfig;
27
-use OCP\IDBConnection;
28
-use OCP\IGroupManager;
29
-use OCP\ILogger;
30 25
 use OCP\IUserManager;
31 26
 use Symfony\Component\Console\Command\Command;
32 27
 use Symfony\Component\Console\Input\InputArgument;
Please login to merge, or discard this patch.
apps/dav/lib/Command/SyncSystemAddressBook.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -21,10 +21,8 @@
 block discarded – undo
21 21
 namespace OCA\DAV\Command;
22 22
 
23 23
 use OCA\DAV\CardDAV\SyncService;
24
-use OCP\IUserManager;
25 24
 use Symfony\Component\Console\Command\Command;
26 25
 use Symfony\Component\Console\Helper\ProgressBar;
27
-use Symfony\Component\Console\Input\InputArgument;
28 26
 use Symfony\Component\Console\Input\InputInterface;
29 27
 use Symfony\Component\Console\Output\OutputInterface;
30 28
 
Please login to merge, or discard this patch.
apps/dav/lib/Comments/EntityCollection.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@
 block discarded – undo
115 115
 	/**
116 116
 	 * Returns an array with all the child nodes
117 117
 	 *
118
-	 * @return \Sabre\DAV\INode[]
118
+	 * @return CommentNode[]
119 119
 	 */
120 120
 	function getChildren() {
121 121
 		return $this->findChildren();
Please login to merge, or discard this patch.
apps/dav/lib/Connector/LegacyDAVACL.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -64,6 +64,9 @@
 block discarded – undo
64 64
 		);
65 65
 	}
66 66
 
67
+	/**
68
+	 * @param boolean $toV2
69
+	 */
67 70
 	private function convertPrincipal($principal, $toV2) {
68 71
 		list(, $name) = URLUtil::splitPath($principal);
69 72
 		if ($toV2) {
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/ChecksumList.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,6 @@
 block discarded – undo
21 21
 namespace OCA\DAV\Connector\Sabre;
22 22
 
23 23
 use Sabre\Xml\XmlSerializable;
24
-use Sabre\Xml\Element;
25 24
 use Sabre\Xml\Writer;
26 25
 
27 26
 /**
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/CustomPropertiesBackend.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@
 block discarded – undo
75 75
 	private $cache = [];
76 76
 
77 77
 	/**
78
-	 * @param Tree $tree node tree
78
+	 * @param ObjectTree $tree node tree
79 79
 	 * @param IDBConnection $connection database connection
80 80
 	 * @param IUser $user owner of the tree and properties
81 81
 	 */
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/DavAclPlugin.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -23,14 +23,11 @@
 block discarded – undo
23 23
 namespace OCA\DAV\Connector\Sabre;
24 24
 
25 25
 use Sabre\DAV\Exception\NotFound;
26
-use Sabre\DAV\IFile;
27 26
 use Sabre\DAV\INode;
28 27
 use \Sabre\DAV\PropFind;
29 28
 use \Sabre\DAV\PropPatch;
30
-use Sabre\DAVACL\Exception\NeedPrivileges;
31 29
 use \Sabre\HTTP\RequestInterface;
32 30
 use \Sabre\HTTP\ResponseInterface;
33
-use Sabre\HTTP\URLUtil;
34 31
 
35 32
 /**
36 33
  * Class DavAclPlugin is a wrapper around \Sabre\DAVACL\Plugin that returns 404
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/FilesReportPlugin.php 1 patch
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 	private $userFolder;
90 90
 
91 91
 	/**
92
-	 * @param Tree $tree
92
+	 * @param ObjectTree $tree
93 93
 	 * @param View $view
94 94
 	 */
95 95
 	public function __construct(Tree $tree,
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 	 * This will be used in the {DAV:}supported-report-set property.
135 135
 	 *
136 136
 	 * @param string $uri
137
-	 * @return array
137
+	 * @return string[]
138 138
 	 */
139 139
 	public function getSupportedReportSet($uri) {
140 140
 		return [self::REPORT_NAME];
@@ -265,6 +265,7 @@  discard block
 block discarded – undo
265 265
 	 *
266 266
 	 * @param string[] $requestedProps requested properties
267 267
 	 * @param Node[] nodes nodes for which to fetch and prepare responses
268
+	 * @param Node[] $nodes
268 269
 	 * @return Response[]
269 270
 	 */
270 271
 	public function prepareResponses($requestedProps, $nodes) {
Please login to merge, or discard this patch.