Inspection of "switch reshares to true (display reshares in the f..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3829)

by Maxence

created 2017-03-13 18:25 UTC

Status

Indentation +177 added lines, -177 removed lines patch added patch discarded remove patch

@@ -32,181 +32,181 @@
 block discarded – undo
  */
 class SharesPlugin extends \Sabre\DAV\ServerPlugin {
 
-	const NS_OWNCLOUD = 'http://owncloud.org/ns';
-	const SHARETYPES_PROPERTYNAME = '{http://owncloud.org/ns}share-types';
-
-	/**
-	 * Reference to main server object
-	 *
-	 * @var \Sabre\DAV\Server
-	 */
-	private $server;
-
-	/**
-	 * @var \OCP\Share\IManager
-	 */
-	private $shareManager;
-
-	/**
-	 * @var \Sabre\DAV\Tree
-	 */
-	private $tree;
-
-	/**
-	 * @var string
-	 */
-	private $userId;
-
-	/**
-	 * @var \OCP\Files\Folder
-	 */
-	private $userFolder;
-
-	/**
-	 * @var IShare[]
-	 */
-	private $cachedShareTypes;
-
-	private $cachedFolders = [];
-
-	/**
-	 * @param \Sabre\DAV\Tree $tree tree
-	 * @param IUserSession $userSession user session
-	 * @param \OCP\Files\Folder $userFolder user home folder
-	 * @param \OCP\Share\IManager $shareManager share manager
-	 */
-	public function __construct(
-		\Sabre\DAV\Tree $tree,
-		IUserSession $userSession,
-		\OCP\Files\Folder $userFolder,
-		\OCP\Share\IManager $shareManager
-	) {
-		$this->tree = $tree;
-		$this->shareManager = $shareManager;
-		$this->userFolder = $userFolder;
-		$this->userId = $userSession->getUser()->getUID();
-		$this->cachedShareTypes = [];
-	}
-
-	/**
-	 * This initializes the plugin.
-	 *
-	 * This function is called by \Sabre\DAV\Server, after
-	 * addPlugin is called.
-	 *
-	 * This method should set up the required event subscriptions.
-	 *
-	 * @param \Sabre\DAV\Server $server
-	 */
-	public function initialize(\Sabre\DAV\Server $server) {
-		$server->xml->namespacesMap[self::NS_OWNCLOUD] = 'oc';
-		$server->xml->elementMap[self::SHARETYPES_PROPERTYNAME] = 'OCA\\DAV\\Connector\\Sabre\\ShareTypeList';
-		$server->protectedProperties[] = self::SHARETYPES_PROPERTYNAME;
-
-		$this->server = $server;
-		$this->server->on('propFind', array($this, 'handleGetProperties'));
-	}
-
-	/**
-	 * Return a list of share types for outgoing shares
-	 *
-	 * @param \OCP\Files\Node $node file node
-	 *
-	 * @return int[] array of share types
-	 */
-	private function getShareTypes(\OCP\Files\Node $node) {
-		$shareTypes = [];
-		$requestedShareTypes = [
-			\OCP\Share::SHARE_TYPE_USER,
-			\OCP\Share::SHARE_TYPE_GROUP,
-			\OCP\Share::SHARE_TYPE_LINK,
-			\OCP\Share::SHARE_TYPE_REMOTE,
-			\OCP\Share::SHARE_TYPE_EMAIL,
-		];
-		foreach ($requestedShareTypes as $requestedShareType) {
-			// one of each type is enough to find out about the types
-			$shares = $this->shareManager->getSharesBy(
-				$this->userId,
-				$requestedShareType,
-				$node,
-				false,
-				1
-			);
-			if (!empty($shares)) {
-				$shareTypes[] = $requestedShareType;
-			}
-		}
-		return $shareTypes;
-	}
-
-	private function getSharesTypesInFolder(\OCP\Files\Folder $node) {
-		$shares = $this->shareManager->getSharesInFolder(
-			$this->userId,
-			$node,
-			true
-		);
-
-		$shareTypesByFileId = [];
-
-		foreach($shares as $fileId => $sharesForFile) {
-			$types = array_map(function(IShare $share) {
-				return $share->getShareType();
-			}, $sharesForFile);
-			$types = array_unique($types);
-			sort($types);
-			$shareTypesByFileId[$fileId] = $types;
-		}
-
-		return $shareTypesByFileId;
-	}
-
-	/**
-	 * Adds shares to propfind response
-	 *
-	 * @param PropFind $propFind propfind object
-	 * @param \Sabre\DAV\INode $sabreNode sabre node
-	 */
-	public function handleGetProperties(
-		PropFind $propFind,
-		\Sabre\DAV\INode $sabreNode
-	) {
-		if (!($sabreNode instanceof \OCA\DAV\Connector\Sabre\Node)) {
-			return;
-		}
-
-		// need prefetch ?
-		if ($sabreNode instanceof \OCA\DAV\Connector\Sabre\Directory
-			&& $propFind->getDepth() !== 0
-			&& !is_null($propFind->getStatus(self::SHARETYPES_PROPERTYNAME))
-		) {
-			$folderNode = $this->userFolder->get($sabreNode->getPath());
-
-			$childShares = $this->getSharesTypesInFolder($folderNode);
-			$this->cachedFolders[] = $sabreNode->getPath();
-			$this->cachedShareTypes[$folderNode->getId()] = $this->getShareTypes($folderNode);
-			foreach ($childShares as $id => $shares) {
-				$this->cachedShareTypes[$id] = $shares;
-			}
-		}
-
-		$propFind->handle(self::SHARETYPES_PROPERTYNAME, function () use ($sabreNode) {
-			if (isset($this->cachedShareTypes[$sabreNode->getId()])) {
-				$shareTypes = $this->cachedShareTypes[$sabreNode->getId()];
-			} else {
-				list($parentPath,) = \Sabre\Uri\split($sabreNode->getPath());
-				if ($parentPath === '') {
-					$parentPath = '/';
-				}
-				// if we already cached the folder this file is in we know there are no shares for this file
-				if (array_search($parentPath, $this->cachedFolders) === false) {
-					$node = $this->userFolder->get($sabreNode->getPath());
-					$shareTypes = $this->getShareTypes($node);
-				} else {
-					return [];
-				}
-			}
-
-			return new ShareTypeList($shareTypes);
-		});
-	}
+    const NS_OWNCLOUD = 'http://owncloud.org/ns';
+    const SHARETYPES_PROPERTYNAME = '{http://owncloud.org/ns}share-types';
+
+    /**
+     * Reference to main server object
+     *
+     * @var \Sabre\DAV\Server
+     */
+    private $server;
+
+    /**
+     * @var \OCP\Share\IManager
+     */
+    private $shareManager;
+
+    /**
+     * @var \Sabre\DAV\Tree
+     */
+    private $tree;
+
+    /**
+     * @var string
+     */
+    private $userId;
+
+    /**
+     * @var \OCP\Files\Folder
+     */
+    private $userFolder;
+
+    /**
+     * @var IShare[]
+     */
+    private $cachedShareTypes;
+
+    private $cachedFolders = [];
+
+    /**
+     * @param \Sabre\DAV\Tree $tree tree
+     * @param IUserSession $userSession user session
+     * @param \OCP\Files\Folder $userFolder user home folder
+     * @param \OCP\Share\IManager $shareManager share manager
+     */
+    public function __construct(
+        \Sabre\DAV\Tree $tree,
+        IUserSession $userSession,
+        \OCP\Files\Folder $userFolder,
+        \OCP\Share\IManager $shareManager
+    ) {
+        $this->tree = $tree;
+        $this->shareManager = $shareManager;
+        $this->userFolder = $userFolder;
+        $this->userId = $userSession->getUser()->getUID();
+        $this->cachedShareTypes = [];
+    }
+
+    /**
+     * This initializes the plugin.
+     *
+     * This function is called by \Sabre\DAV\Server, after
+     * addPlugin is called.
+     *
+     * This method should set up the required event subscriptions.
+     *
+     * @param \Sabre\DAV\Server $server
+     */
+    public function initialize(\Sabre\DAV\Server $server) {
+        $server->xml->namespacesMap[self::NS_OWNCLOUD] = 'oc';
+        $server->xml->elementMap[self::SHARETYPES_PROPERTYNAME] = 'OCA\\DAV\\Connector\\Sabre\\ShareTypeList';
+        $server->protectedProperties[] = self::SHARETYPES_PROPERTYNAME;
+
+        $this->server = $server;
+        $this->server->on('propFind', array($this, 'handleGetProperties'));
+    }
+
+    /**
+     * Return a list of share types for outgoing shares
+     *
+     * @param \OCP\Files\Node $node file node
+     *
+     * @return int[] array of share types
+     */
+    private function getShareTypes(\OCP\Files\Node $node) {
+        $shareTypes = [];
+        $requestedShareTypes = [
+            \OCP\Share::SHARE_TYPE_USER,
+            \OCP\Share::SHARE_TYPE_GROUP,
+            \OCP\Share::SHARE_TYPE_LINK,
+            \OCP\Share::SHARE_TYPE_REMOTE,
+            \OCP\Share::SHARE_TYPE_EMAIL,
+        ];
+        foreach ($requestedShareTypes as $requestedShareType) {
+            // one of each type is enough to find out about the types
+            $shares = $this->shareManager->getSharesBy(
+                $this->userId,
+                $requestedShareType,
+                $node,
+                false,
+                1
+            );
+            if (!empty($shares)) {
+                $shareTypes[] = $requestedShareType;
+            }
+        }
+        return $shareTypes;
+    }
+
+    private function getSharesTypesInFolder(\OCP\Files\Folder $node) {
+        $shares = $this->shareManager->getSharesInFolder(
+            $this->userId,
+            $node,
+            true
+        );
+
+        $shareTypesByFileId = [];
+
+        foreach($shares as $fileId => $sharesForFile) {
+            $types = array_map(function(IShare $share) {
+                return $share->getShareType();
+            }, $sharesForFile);
+            $types = array_unique($types);
+            sort($types);
+            $shareTypesByFileId[$fileId] = $types;
+        }
+
+        return $shareTypesByFileId;
+    }
+
+    /**
+     * Adds shares to propfind response
+     *
+     * @param PropFind $propFind propfind object
+     * @param \Sabre\DAV\INode $sabreNode sabre node
+     */
+    public function handleGetProperties(
+        PropFind $propFind,
+        \Sabre\DAV\INode $sabreNode
+    ) {
+        if (!($sabreNode instanceof \OCA\DAV\Connector\Sabre\Node)) {
+            return;
+        }
+
+        // need prefetch ?
+        if ($sabreNode instanceof \OCA\DAV\Connector\Sabre\Directory
+            && $propFind->getDepth() !== 0
+            && !is_null($propFind->getStatus(self::SHARETYPES_PROPERTYNAME))
+        ) {
+            $folderNode = $this->userFolder->get($sabreNode->getPath());
+
+            $childShares = $this->getSharesTypesInFolder($folderNode);
+            $this->cachedFolders[] = $sabreNode->getPath();
+            $this->cachedShareTypes[$folderNode->getId()] = $this->getShareTypes($folderNode);
+            foreach ($childShares as $id => $shares) {
+                $this->cachedShareTypes[$id] = $shares;
+            }
+        }
+
+        $propFind->handle(self::SHARETYPES_PROPERTYNAME, function () use ($sabreNode) {
+            if (isset($this->cachedShareTypes[$sabreNode->getId()])) {
+                $shareTypes = $this->cachedShareTypes[$sabreNode->getId()];
+            } else {
+                list($parentPath,) = \Sabre\Uri\split($sabreNode->getPath());
+                if ($parentPath === '') {
+                    $parentPath = '/';
+                }
+                // if we already cached the folder this file is in we know there are no shares for this file
+                if (array_search($parentPath, $this->cachedFolders) === false) {
+                    $node = $this->userFolder->get($sabreNode->getPath());
+                    $shareTypes = $this->getShareTypes($node);
+                } else {
+                    return [];
+                }
+            }
+
+            return new ShareTypeList($shareTypes);
+        });
+    }
 }

Please login to merge, or discard this patch.

		@@ -32,181 +32,181 @@
		block discarded – undo
32	32	*/
33	33	class SharesPlugin extends \Sabre\DAV\ServerPlugin {
34	34
35		- const NS_OWNCLOUD = 'http://owncloud.org/ns';
36		- const SHARETYPES_PROPERTYNAME = '{http://owncloud.org/ns}share-types';
37		-
38		- /**
39		- * Reference to main server object
40		- *
41		- * @var \Sabre\DAV\Server
42		- */
43		- private $server;
44		-
45		- /**
46		- * @var \OCP\Share\IManager
47		- */
48		- private $shareManager;
49		-
50		- /**
51		- * @var \Sabre\DAV\Tree
52		- */
53		- private $tree;
54		-
55		- /**
56		- * @var string
57		- */
58		- private $userId;
59		-
60		- /**
61		- * @var \OCP\Files\Folder
62		- */
63		- private $userFolder;
64		-
65		- /**
66		- * @var IShare[]
67		- */
68		- private $cachedShareTypes;
69		-
70		- private $cachedFolders = [];
71		-
72		- /**
73		- * @param \Sabre\DAV\Tree $tree tree
74		- * @param IUserSession $userSession user session
75		- * @param \OCP\Files\Folder $userFolder user home folder
76		- * @param \OCP\Share\IManager $shareManager share manager
77		- */
78		- public function __construct(
79		- \Sabre\DAV\Tree $tree,
80		- IUserSession $userSession,
81		- \OCP\Files\Folder $userFolder,
82		- \OCP\Share\IManager $shareManager
83		- ) {
84		- $this->tree = $tree;
85		- $this->shareManager = $shareManager;
86		- $this->userFolder = $userFolder;
87		- $this->userId = $userSession->getUser()->getUID();
88		- $this->cachedShareTypes = [];
89		- }
90		-
91		- /**
92		- * This initializes the plugin.
93		- *
94		- * This function is called by \Sabre\DAV\Server, after
95		- * addPlugin is called.
96		- *
97		- * This method should set up the required event subscriptions.
98		- *
99		- * @param \Sabre\DAV\Server $server
100		- */
101		- public function initialize(\Sabre\DAV\Server $server) {
102		- $server->xml->namespacesMap[self::NS_OWNCLOUD] = 'oc';
103		- $server->xml->elementMap[self::SHARETYPES_PROPERTYNAME] = 'OCA\\DAV\\Connector\\Sabre\\ShareTypeList';
104		- $server->protectedProperties[] = self::SHARETYPES_PROPERTYNAME;
105		-
106		- $this->server = $server;
107		- $this->server->on('propFind', array($this, 'handleGetProperties'));
108		- }
109		-
110		- /**
111		- * Return a list of share types for outgoing shares
112		- *
113		- * @param \OCP\Files\Node $node file node
114		- *
115		- * @return int[] array of share types
116		- */
117		- private function getShareTypes(\OCP\Files\Node $node) {
118		- $shareTypes = [];
119		- $requestedShareTypes = [
120		- \OCP\Share::SHARE_TYPE_USER,
121		- \OCP\Share::SHARE_TYPE_GROUP,
122		- \OCP\Share::SHARE_TYPE_LINK,
123		- \OCP\Share::SHARE_TYPE_REMOTE,
124		- \OCP\Share::SHARE_TYPE_EMAIL,
125		- ];
126		- foreach ($requestedShareTypes as $requestedShareType) {
127		- // one of each type is enough to find out about the types
128		- $shares = $this->shareManager->getSharesBy(
129		- $this->userId,
130		- $requestedShareType,
131		- $node,
132		- false,
133		- 1
134		- );
135		- if (!empty($shares)) {
136		- $shareTypes[] = $requestedShareType;
137		- }
138		- }
139		- return $shareTypes;
140		- }
141		-
142		- private function getSharesTypesInFolder(\OCP\Files\Folder $node) {
143		- $shares = $this->shareManager->getSharesInFolder(
144		- $this->userId,
145		- $node,
146		- true
147		- );
148		-
149		- $shareTypesByFileId = [];
150		-
151		- foreach($shares as $fileId => $sharesForFile) {
152		- $types = array_map(function(IShare $share) {
153		- return $share->getShareType();
154		- }, $sharesForFile);
155		- $types = array_unique($types);
156		- sort($types);
157		- $shareTypesByFileId[$fileId] = $types;
158		- }
159		-
160		- return $shareTypesByFileId;
161		- }
162		-
163		- /**
164		- * Adds shares to propfind response
165		- *
166		- * @param PropFind $propFind propfind object
167		- * @param \Sabre\DAV\INode $sabreNode sabre node
168		- */
169		- public function handleGetProperties(
170		- PropFind $propFind,
171		- \Sabre\DAV\INode $sabreNode
172		- ) {
173		- if (!($sabreNode instanceof \OCA\DAV\Connector\Sabre\Node)) {
174		- return;
175		- }
176		-
177		- // need prefetch ?
178		- if ($sabreNode instanceof \OCA\DAV\Connector\Sabre\Directory
179		- && $propFind->getDepth() !== 0
180		- && !is_null($propFind->getStatus(self::SHARETYPES_PROPERTYNAME))
181		- ) {
182		- $folderNode = $this->userFolder->get($sabreNode->getPath());
183		-
184		- $childShares = $this->getSharesTypesInFolder($folderNode);
185		- $this->cachedFolders[] = $sabreNode->getPath();
186		- $this->cachedShareTypes[$folderNode->getId()] = $this->getShareTypes($folderNode);
187		- foreach ($childShares as $id => $shares) {
188		- $this->cachedShareTypes[$id] = $shares;
189		- }
190		- }
191		-
192		- $propFind->handle(self::SHARETYPES_PROPERTYNAME, function () use ($sabreNode) {
193		- if (isset($this->cachedShareTypes[$sabreNode->getId()])) {
194		- $shareTypes = $this->cachedShareTypes[$sabreNode->getId()];
195		- } else {
196		- list($parentPath,) = \Sabre\Uri\split($sabreNode->getPath());
197		- if ($parentPath === '') {
198		- $parentPath = '/';
199		- }
200		- // if we already cached the folder this file is in we know there are no shares for this file
201		- if (array_search($parentPath, $this->cachedFolders) === false) {
202		- $node = $this->userFolder->get($sabreNode->getPath());
203		- $shareTypes = $this->getShareTypes($node);
204		- } else {
205		- return [];
206		- }
207		- }
208		-
209		- return new ShareTypeList($shareTypes);
210		- });
211		- }
	35	+ const NS_OWNCLOUD = 'http://owncloud.org/ns';
	36	+ const SHARETYPES_PROPERTYNAME = '{http://owncloud.org/ns}share-types';
	37	+
	38	+ /**
	39	+ * Reference to main server object
	40	+ *
	41	+ * @var \Sabre\DAV\Server
	42	+ */
	43	+ private $server;
	44	+
	45	+ /**
	46	+ * @var \OCP\Share\IManager
	47	+ */
	48	+ private $shareManager;
	49	+
	50	+ /**
	51	+ * @var \Sabre\DAV\Tree
	52	+ */
	53	+ private $tree;
	54	+
	55	+ /**
	56	+ * @var string
	57	+ */
	58	+ private $userId;
	59	+
	60	+ /**
	61	+ * @var \OCP\Files\Folder
	62	+ */
	63	+ private $userFolder;
	64	+
	65	+ /**
	66	+ * @var IShare[]
	67	+ */
	68	+ private $cachedShareTypes;
	69	+
	70	+ private $cachedFolders = [];
	71	+
	72	+ /**
	73	+ * @param \Sabre\DAV\Tree $tree tree
	74	+ * @param IUserSession $userSession user session
	75	+ * @param \OCP\Files\Folder $userFolder user home folder
	76	+ * @param \OCP\Share\IManager $shareManager share manager
	77	+ */
	78	+ public function __construct(
	79	+ \Sabre\DAV\Tree $tree,
	80	+ IUserSession $userSession,
	81	+ \OCP\Files\Folder $userFolder,
	82	+ \OCP\Share\IManager $shareManager
	83	+ ) {
	84	+ $this->tree = $tree;
	85	+ $this->shareManager = $shareManager;
	86	+ $this->userFolder = $userFolder;
	87	+ $this->userId = $userSession->getUser()->getUID();
	88	+ $this->cachedShareTypes = [];
	89	+ }
	90	+
	91	+ /**
	92	+ * This initializes the plugin.
	93	+ *
	94	+ * This function is called by \Sabre\DAV\Server, after
	95	+ * addPlugin is called.
	96	+ *
	97	+ * This method should set up the required event subscriptions.
	98	+ *
	99	+ * @param \Sabre\DAV\Server $server
	100	+ */
	101	+ public function initialize(\Sabre\DAV\Server $server) {
	102	+ $server->xml->namespacesMap[self::NS_OWNCLOUD] = 'oc';
	103	+ $server->xml->elementMap[self::SHARETYPES_PROPERTYNAME] = 'OCA\\DAV\\Connector\\Sabre\\ShareTypeList';
	104	+ $server->protectedProperties[] = self::SHARETYPES_PROPERTYNAME;
	105	+
	106	+ $this->server = $server;
	107	+ $this->server->on('propFind', array($this, 'handleGetProperties'));
	108	+ }
	109	+
	110	+ /**
	111	+ * Return a list of share types for outgoing shares
	112	+ *
	113	+ * @param \OCP\Files\Node $node file node
	114	+ *
	115	+ * @return int[] array of share types
	116	+ */
	117	+ private function getShareTypes(\OCP\Files\Node $node) {
	118	+ $shareTypes = [];
	119	+ $requestedShareTypes = [
	120	+ \OCP\Share::SHARE_TYPE_USER,
	121	+ \OCP\Share::SHARE_TYPE_GROUP,
	122	+ \OCP\Share::SHARE_TYPE_LINK,
	123	+ \OCP\Share::SHARE_TYPE_REMOTE,
	124	+ \OCP\Share::SHARE_TYPE_EMAIL,
	125	+ ];
	126	+ foreach ($requestedShareTypes as $requestedShareType) {
	127	+ // one of each type is enough to find out about the types
	128	+ $shares = $this->shareManager->getSharesBy(
	129	+ $this->userId,
	130	+ $requestedShareType,
	131	+ $node,
	132	+ false,
	133	+ 1
	134	+ );
	135	+ if (!empty($shares)) {
	136	+ $shareTypes[] = $requestedShareType;
	137	+ }
	138	+ }
	139	+ return $shareTypes;
	140	+ }
	141	+
	142	+ private function getSharesTypesInFolder(\OCP\Files\Folder $node) {
	143	+ $shares = $this->shareManager->getSharesInFolder(
	144	+ $this->userId,
	145	+ $node,
	146	+ true
	147	+ );
	148	+
	149	+ $shareTypesByFileId = [];
	150	+
	151	+ foreach($shares as $fileId => $sharesForFile) {
	152	+ $types = array_map(function(IShare $share) {
	153	+ return $share->getShareType();
	154	+ }, $sharesForFile);
	155	+ $types = array_unique($types);
	156	+ sort($types);
	157	+ $shareTypesByFileId[$fileId] = $types;
	158	+ }
	159	+
	160	+ return $shareTypesByFileId;
	161	+ }
	162	+
	163	+ /**
	164	+ * Adds shares to propfind response
	165	+ *
	166	+ * @param PropFind $propFind propfind object
	167	+ * @param \Sabre\DAV\INode $sabreNode sabre node
	168	+ */
	169	+ public function handleGetProperties(
	170	+ PropFind $propFind,
	171	+ \Sabre\DAV\INode $sabreNode
	172	+ ) {
	173	+ if (!($sabreNode instanceof \OCA\DAV\Connector\Sabre\Node)) {
	174	+ return;
	175	+ }
	176	+
	177	+ // need prefetch ?
	178	+ if ($sabreNode instanceof \OCA\DAV\Connector\Sabre\Directory
	179	+ && $propFind->getDepth() !== 0
	180	+ && !is_null($propFind->getStatus(self::SHARETYPES_PROPERTYNAME))
	181	+ ) {
	182	+ $folderNode = $this->userFolder->get($sabreNode->getPath());
	183	+
	184	+ $childShares = $this->getSharesTypesInFolder($folderNode);
	185	+ $this->cachedFolders[] = $sabreNode->getPath();
	186	+ $this->cachedShareTypes[$folderNode->getId()] = $this->getShareTypes($folderNode);
	187	+ foreach ($childShares as $id => $shares) {
	188	+ $this->cachedShareTypes[$id] = $shares;
	189	+ }
	190	+ }
	191	+
	192	+ $propFind->handle(self::SHARETYPES_PROPERTYNAME, function () use ($sabreNode) {
	193	+ if (isset($this->cachedShareTypes[$sabreNode->getId()])) {
	194	+ $shareTypes = $this->cachedShareTypes[$sabreNode->getId()];
	195	+ } else {
	196	+ list($parentPath,) = \Sabre\Uri\split($sabreNode->getPath());
	197	+ if ($parentPath === '') {
	198	+ $parentPath = '/';
	199	+ }
	200	+ // if we already cached the folder this file is in we know there are no shares for this file
	201	+ if (array_search($parentPath, $this->cachedFolders) === false) {
	202	+ $node = $this->userFolder->get($sabreNode->getPath());
	203	+ $shareTypes = $this->getShareTypes($node);
	204	+ } else {
	205	+ return [];
	206	+ }
	207	+ }
	208	+
	209	+ return new ShareTypeList($shareTypes);
	210	+ });
	211	+ }
212	212	}

nextcloud / server

Pull Request — master (#3829)

Status

Category

Indentation +177 added lines, -177 removed lines patch added patch discarded remove patch