Inspection of "Show share settings only if incoming federated sha..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( cf2d12...dc600f )

by John

created 2019-06-11 16:31 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -8,7 +8,7 @@
 block discarded – undo
 <div id="fileSharingSettings" class="section">
 	<h2 data-anchor-name="federated-cloud"><?php p($l->t('Federated Cloud')); ?></h2>
 	<a target="_blank" rel="noreferrer noopener" class="icon-info svg"
-	title="<?php p($l->t('Open documentation'));?>"
+	title="<?php p($l->t('Open documentation')); ?>"
 	href="<?php p(link_to_docs('user-sharing-federated')); ?>"></a>
 	<p class="settings-hint"><?php p($l->t('You can share with anyone who uses a Nextcloud server or other Open Cloud Mesh (OCM) compatible servers and services! Just put their Federated Cloud ID in the share dialog. It looks like [email protected]')); ?></p>
 

Please login to merge, or discard this patch.

apps/federatedfilesharing/lib/Settings/Personal.php 2 patches

Indentation +59 added lines, -59 removed lines patch added patch discarded remove patch

@@ -33,68 +33,68 @@
 block discarded – undo
 
 class Personal implements ISettings {
 
-	/** @var FederatedShareProvider */
-	private $federatedShareProvider;
-	/** @var IUserSession */
-	private $userSession;
-	/** @var IL10N */
-	private $l;
-	/** @var \OC_Defaults */
-	private $defaults;
+    /** @var FederatedShareProvider */
+    private $federatedShareProvider;
+    /** @var IUserSession */
+    private $userSession;
+    /** @var IL10N */
+    private $l;
+    /** @var \OC_Defaults */
+    private $defaults;
 
-	public function __construct(
-		FederatedShareProvider $federatedShareProvider, #
-		IUserSession $userSession,
-		IL10N $l,
-		\OC_Defaults $defaults
-	) {
-		$this->federatedShareProvider = $federatedShareProvider;
-		$this->userSession = $userSession;
-		$this->l = $l;
-		$this->defaults = $defaults;
-	}
+    public function __construct(
+        FederatedShareProvider $federatedShareProvider, #
+        IUserSession $userSession,
+        IL10N $l,
+        \OC_Defaults $defaults
+    ) {
+        $this->federatedShareProvider = $federatedShareProvider;
+        $this->userSession = $userSession;
+        $this->l = $l;
+        $this->defaults = $defaults;
+    }
 
-	/**
-	 * @return TemplateResponse returns the instance with all parameters set, ready to be rendered
-	 * @since 9.1
-	 */
-	public function getForm() {
-		$cloudID = $this->userSession->getUser()->getCloudId();
-		$url = 'https://nextcloud.com/sharing#' . $cloudID;
+    /**
+     * @return TemplateResponse returns the instance with all parameters set, ready to be rendered
+     * @since 9.1
+     */
+    public function getForm() {
+        $cloudID = $this->userSession->getUser()->getCloudId();
+        $url = 'https://nextcloud.com/sharing#' . $cloudID;
 
-		$parameters = [
-			'message_with_URL' => $this->l->t('Share with me through my #Nextcloud Federated Cloud ID, see %s', [$url]),
-			'message_without_URL' => $this->l->t('Share with me through my #Nextcloud Federated Cloud ID', [$cloudID]),
-			'logoPath' => $this->defaults->getLogo(),
-			'reference' => $url,
-			'cloudId' => $cloudID,
-			'color' => $this->defaults->getColorPrimary(),
-			'textColor' => "#ffffff",
-		];
-		return new TemplateResponse('federatedfilesharing', 'settings-personal', $parameters, '');
-	}
+        $parameters = [
+            'message_with_URL' => $this->l->t('Share with me through my #Nextcloud Federated Cloud ID, see %s', [$url]),
+            'message_without_URL' => $this->l->t('Share with me through my #Nextcloud Federated Cloud ID', [$cloudID]),
+            'logoPath' => $this->defaults->getLogo(),
+            'reference' => $url,
+            'cloudId' => $cloudID,
+            'color' => $this->defaults->getColorPrimary(),
+            'textColor' => "#ffffff",
+        ];
+        return new TemplateResponse('federatedfilesharing', 'settings-personal', $parameters, '');
+    }
 
-	/**
-	 * @return string the section ID, e.g. 'sharing'
-	 * @since 9.1
-	 */
-	public function getSection() {
-		if ($this->federatedShareProvider->isIncomingServer2serverShareEnabled() ||
-			$this->federatedShareProvider->isIncomingServer2serverGroupShareEnabled()) {
-			return 'sharing';
-		}
-		return null;
-	}
+    /**
+     * @return string the section ID, e.g. 'sharing'
+     * @since 9.1
+     */
+    public function getSection() {
+        if ($this->federatedShareProvider->isIncomingServer2serverShareEnabled() ||
+            $this->federatedShareProvider->isIncomingServer2serverGroupShareEnabled()) {
+            return 'sharing';
+        }
+        return null;
+    }
 
-	/**
-	 * @return int whether the form should be rather on the top or bottom of
-	 * the admin section. The forms are arranged in ascending order of the
-	 * priority values. It is required to return a value between 0 and 100.
-	 *
-	 * E.g.: 70
-	 * @since 9.1
-	 */
-	public function getPriority() {
-		return 40;
-	}
+    /**
+     * @return int whether the form should be rather on the top or bottom of
+     * the admin section. The forms are arranged in ascending order of the
+     * priority values. It is required to return a value between 0 and 100.
+     *
+     * E.g.: 70
+     * @since 9.1
+     */
+    public function getPriority() {
+        return 40;
+    }
 }

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -60,7 +60,7 @@
 block discarded – undo
 	 */
 	public function getForm() {
 		$cloudID = $this->userSession->getUser()->getCloudId();
-		$url = 'https://nextcloud.com/sharing#' . $cloudID;
+		$url = 'https://nextcloud.com/sharing#'.$cloudID;
 
 		$parameters = [
 			'message_with_URL' => $this->l->t('Share with me through my #Nextcloud Federated Cloud ID, see %s', [$url]),

Please login to merge, or discard this patch.

		@@ -60,7 +60,7 @@
		block discarded – undo
60	60	*/
61	61	public function getForm() {
62	62	$cloudID = $this->userSession->getUser()->getCloudId();
63		- $url = 'https://nextcloud.com/sharing#' . $cloudID;
	63	+ $url = 'https://nextcloud.com/sharing#'.$cloudID;
64	64
65	65	$parameters = [
66	66	'message_with_URL' => $this->l->t('Share with me through my #Nextcloud Federated Cloud ID, see %s', [$url]),

		@@ -8,7 +8,7 @@
		block discarded – undo
8	8	<div id="fileSharingSettings" class="section">
9	9	<h2 data-anchor-name="federated-cloud"><?php p($l->t('Federated Cloud')); ?></h2>
10	10	<a target="_blank" rel="noreferrer noopener" class="icon-info svg"
11		- title="<?php p($l->t('Open documentation'));?>"
	11	+ title="<?php p($l->t('Open documentation')); ?>"
12	12	href="<?php p(link_to_docs('user-sharing-federated')); ?>"></a>
13	13	<p class="settings-hint"><?php p($l->t('You can share with anyone who uses a Nextcloud server or other Open Cloud Mesh (OCM) compatible servers and services! Just put their Federated Cloud ID in the share dialog. It looks like [email protected]')); ?></p>
14	14

		@@ -33,68 +33,68 @@
		block discarded – undo
33	33
34	34	class Personal implements ISettings {
35	35
36		- /** @var FederatedShareProvider */
37		- private $federatedShareProvider;
38		- /** @var IUserSession */
39		- private $userSession;
40		- /** @var IL10N */
41		- private $l;
42		- /** @var \OC_Defaults */
43		- private $defaults;
	36	+ /** @var FederatedShareProvider */
	37	+ private $federatedShareProvider;
	38	+ /** @var IUserSession */
	39	+ private $userSession;
	40	+ /** @var IL10N */
	41	+ private $l;
	42	+ /** @var \OC_Defaults */
	43	+ private $defaults;
44	44
45		- public function __construct(
46		- FederatedShareProvider $federatedShareProvider, #
47		- IUserSession $userSession,
48		- IL10N $l,
49		- \OC_Defaults $defaults
50		- ) {
51		- $this->federatedShareProvider = $federatedShareProvider;
52		- $this->userSession = $userSession;
53		- $this->l = $l;
54		- $this->defaults = $defaults;
55		- }
	45	+ public function __construct(
	46	+ FederatedShareProvider $federatedShareProvider, #
	47	+ IUserSession $userSession,
	48	+ IL10N $l,
	49	+ \OC_Defaults $defaults
	50	+ ) {
	51	+ $this->federatedShareProvider = $federatedShareProvider;
	52	+ $this->userSession = $userSession;
	53	+ $this->l = $l;
	54	+ $this->defaults = $defaults;
	55	+ }
56	56
57		- /**
58		- * @return TemplateResponse returns the instance with all parameters set, ready to be rendered
59		- * @since 9.1
60		- */
61		- public function getForm() {
62		- $cloudID = $this->userSession->getUser()->getCloudId();
63		- $url = 'https://nextcloud.com/sharing#' . $cloudID;
	57	+ /**
	58	+ * @return TemplateResponse returns the instance with all parameters set, ready to be rendered
	59	+ * @since 9.1
	60	+ */
	61	+ public function getForm() {
	62	+ $cloudID = $this->userSession->getUser()->getCloudId();
	63	+ $url = 'https://nextcloud.com/sharing#' . $cloudID;
64	64
65		- $parameters = [
66		- 'message_with_URL' => $this->l->t('Share with me through my #Nextcloud Federated Cloud ID, see %s', [$url]),
67		- 'message_without_URL' => $this->l->t('Share with me through my #Nextcloud Federated Cloud ID', [$cloudID]),
68		- 'logoPath' => $this->defaults->getLogo(),
69		- 'reference' => $url,
70		- 'cloudId' => $cloudID,
71		- 'color' => $this->defaults->getColorPrimary(),
72		- 'textColor' => "#ffffff",
73		- ];
74		- return new TemplateResponse('federatedfilesharing', 'settings-personal', $parameters, '');
75		- }
	65	+ $parameters = [
	66	+ 'message_with_URL' => $this->l->t('Share with me through my #Nextcloud Federated Cloud ID, see %s', [$url]),
	67	+ 'message_without_URL' => $this->l->t('Share with me through my #Nextcloud Federated Cloud ID', [$cloudID]),
	68	+ 'logoPath' => $this->defaults->getLogo(),
	69	+ 'reference' => $url,
	70	+ 'cloudId' => $cloudID,
	71	+ 'color' => $this->defaults->getColorPrimary(),
	72	+ 'textColor' => "#ffffff",
	73	+ ];
	74	+ return new TemplateResponse('federatedfilesharing', 'settings-personal', $parameters, '');
	75	+ }
76	76
77		- /**
78		- * @return string the section ID, e.g. 'sharing'
79		- * @since 9.1
80		- */
81		- public function getSection() {
82		- if ($this->federatedShareProvider->isIncomingServer2serverShareEnabled() \|\|
83		- $this->federatedShareProvider->isIncomingServer2serverGroupShareEnabled()) {
84		- return 'sharing';
85		- }
86		- return null;
87		- }
	77	+ /**
	78	+ * @return string the section ID, e.g. 'sharing'
	79	+ * @since 9.1
	80	+ */
	81	+ public function getSection() {
	82	+ if ($this->federatedShareProvider->isIncomingServer2serverShareEnabled() \|\|
	83	+ $this->federatedShareProvider->isIncomingServer2serverGroupShareEnabled()) {
	84	+ return 'sharing';
	85	+ }
	86	+ return null;
	87	+ }
88	88
89		- /**
90		- * @return int whether the form should be rather on the top or bottom of
91		- * the admin section. The forms are arranged in ascending order of the
92		- * priority values. It is required to return a value between 0 and 100.
93		- *
94		- * E.g.: 70
95		- * @since 9.1
96		- */
97		- public function getPriority() {
98		- return 40;
99		- }
	89	+ /**
	90	+ * @return int whether the form should be rather on the top or bottom of
	91	+ * the admin section. The forms are arranged in ascending order of the
	92	+ * priority values. It is required to return a value between 0 and 100.
	93	+ *
	94	+ * E.g.: 70
	95	+ * @since 9.1
	96	+ */
	97	+ public function getPriority() {
	98	+ return 40;
	99	+ }
100	100	}

nextcloud / server

Push — master ( cf2d12...dc600f )

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +59 added lines, -59 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch