nextcloud / server

build/integration/features/bootstrap/ShareesContext.php

Indentation +9 added lines, -9 removed lines

@@ -15,14 +15,14 @@
  * Features context.
  */
 class ShareesContext implements Context, SnippetAcceptingContext {
-	use Sharing;
-	use AppConfiguration;
+    use Sharing;
+    use AppConfiguration;
 
-	protected function resetAppConfigs() {
-		$this->deleteServerConfig('core', 'shareapi_only_share_with_group_members');
-		$this->deleteServerConfig('core', 'shareapi_allow_share_dialog_user_enumeration');
-		$this->deleteServerConfig('core', 'shareapi_allow_group_sharing');
-		$this->deleteServerConfig('core', 'shareapi_exclude_groups');
-		$this->deleteServerConfig('core', 'shareapi_exclude_groups_list');
-	}
+    protected function resetAppConfigs() {
+        $this->deleteServerConfig('core', 'shareapi_only_share_with_group_members');
+        $this->deleteServerConfig('core', 'shareapi_allow_share_dialog_user_enumeration');
+        $this->deleteServerConfig('core', 'shareapi_allow_group_sharing');
+        $this->deleteServerConfig('core', 'shareapi_exclude_groups');
+        $this->deleteServerConfig('core', 'shareapi_exclude_groups_list');
+    }
 }

build/integration/features/bootstrap/FeatureContext.php

Indentation +13 added lines, -13 removed lines

@@ -14,18 +14,18 @@
  * Features context.
  */
 class FeatureContext implements Context, SnippetAcceptingContext {
-	use AppConfiguration;
-	use ContactsMenu;
-	use ExternalStorage;
-	use Search;
-	use WebDav;
-	use Trashbin;
+    use AppConfiguration;
+    use ContactsMenu;
+    use ExternalStorage;
+    use Search;
+    use WebDav;
+    use Trashbin;
 
-	protected function resetAppConfigs(): void {
-		$this->deleteServerConfig('bruteForce', 'whitelist_0');
-		$this->deleteServerConfig('bruteForce', 'whitelist_1');
-		$this->deleteServerConfig('bruteforcesettings', 'apply_allowlist_to_ratelimit');
-		$this->deleteServerConfig('core', 'shareapi_exclude_groups');
-		$this->deleteServerConfig('core', 'shareapi_exclude_groups_list');
-	}
+    protected function resetAppConfigs(): void {
+        $this->deleteServerConfig('bruteForce', 'whitelist_0');
+        $this->deleteServerConfig('bruteForce', 'whitelist_1');
+        $this->deleteServerConfig('bruteforcesettings', 'apply_allowlist_to_ratelimit');
+        $this->deleteServerConfig('core', 'shareapi_exclude_groups');
+        $this->deleteServerConfig('core', 'shareapi_exclude_groups_list');
+    }
 }

lib/private/Contacts/ContactsMenu/ContactsStore.php

Indentation +348 added lines, -348 removed lines

@@ -28,352 +28,352 @@
 use function count;
 
 class ContactsStore implements IContactsStore {
-	public function __construct(
-		private IManager $contactsManager,
-		private ?StatusService $userStatusService,
-		private IConfig $config,
-		private ProfileManager $profileManager,
-		private IUserManager $userManager,
-		private IURLGenerator $urlGenerator,
-		private IGroupManager $groupManager,
-		private KnownUserService $knownUserService,
-		private IL10NFactory $l10nFactory,
-	) {
-	}
-
-	/**
-	 * @return IEntry[]
-	 */
-	public function getContacts(IUser $user, ?string $filter, ?int $limit = null, ?int $offset = null): array {
-		$options = [
-			'enumeration' => $this->config->getAppValue('core', 'shareapi_allow_share_dialog_user_enumeration', 'yes') === 'yes',
-			'fullmatch' => $this->config->getAppValue('core', 'shareapi_restrict_user_enumeration_full_match', 'yes') === 'yes',
-		];
-		if ($limit !== null) {
-			$options['limit'] = $limit;
-		}
-		if ($offset !== null) {
-			$options['offset'] = $offset;
-		}
-		// Status integration only works without pagination and filters
-		if ($offset === null && ($filter === null || $filter === '')) {
-			$recentStatuses = $this->userStatusService?->findAllRecentStatusChanges($limit, $offset) ?? [];
-		} else {
-			$recentStatuses = [];
-		}
-
-		// Search by status if there is no filter and statuses are available
-		if (!empty($recentStatuses)) {
-			$allContacts = array_filter(array_map(function (UserStatus $userStatus) use ($options) {
-				// UID is ambiguous with federation. We have to use the federated cloud ID to an exact match of
-				// A local user
-				$user = $this->userManager->get($userStatus->getUserId());
-				if ($user === null) {
-					return null;
-				}
-
-				$contact = $this->contactsManager->search(
-					$user->getCloudId(),
-					[
-						'CLOUD',
-					],
-					array_merge(
-						$options,
-						[
-							'limit' => 1,
-							'offset' => 0,
-						],
-					),
-				)[0] ?? null;
-				if ($contact !== null) {
-					$contact[Entry::PROPERTY_STATUS_MESSAGE_TIMESTAMP] = $userStatus->getStatusMessageTimestamp();
-				}
-				return $contact;
-			}, $recentStatuses));
-			if ($limit !== null && count($allContacts) < $limit) {
-				// More contacts were requested
-				$fromContacts = $this->contactsManager->search(
-					$filter ?? '',
-					[
-						'FN',
-						'EMAIL'
-					],
-					array_merge(
-						$options,
-						[
-							'limit' => $limit - count($allContacts),
-						],
-					),
-				);
-
-				// Create hash map of all status contacts
-				$existing = array_fill_keys(array_column($allContacts, 'URI'), null);
-				// Append the ones that are new
-				$allContacts = array_merge(
-					$allContacts,
-					array_filter($fromContacts, fn (array $contact): bool => !array_key_exists($contact['URI'], $existing))
-				);
-			}
-		} else {
-			$allContacts = $this->contactsManager->search(
-				$filter ?? '',
-				[
-					'FN',
-					'EMAIL'
-				],
-				$options
-			);
-		}
-
-		$userId = $user->getUID();
-		$contacts = array_filter($allContacts, function ($contact) use ($userId) {
-			// When searching for multiple results, we strip out the current user
-			if (array_key_exists('UID', $contact)) {
-				return $contact['UID'] !== $userId;
-			}
-			return true;
-		});
-
-		$entries = array_map(function (array $contact) {
-			return $this->contactArrayToEntry($contact);
-		}, $contacts);
-		return $this->filterContacts(
-			$user,
-			$entries,
-			$filter
-		);
-	}
-
-	/**
-	 * Filters the contacts. Applied filters:
-	 *  1. if the `shareapi_allow_share_dialog_user_enumeration` config option is
-	 * enabled it will filter all local users
-	 *  2. if the `shareapi_exclude_groups` config option is enabled and the
-	 * current user is only in excluded groups it will filter all local users.
-	 *  3. if the `shareapi_only_share_with_group_members` config option is
-	 * enabled it will filter all users which doesn't have a common group
-	 * with the current user.
-	 * If enabled, the 'shareapi_only_share_with_group_members_exclude_group_list'
-	 * config option may specify some groups excluded from the principle of
-	 * belonging to the same group.
-	 *
-	 * @param Entry[] $entries
-	 * @return Entry[] the filtered contacts
-	 */
-	private function filterContacts(
-		IUser $self,
-		array $entries,
-		?string $filter,
-	): array {
-		$disallowEnumeration = $this->config->getAppValue('core', 'shareapi_allow_share_dialog_user_enumeration', 'yes') !== 'yes';
-		$restrictEnumerationGroup = $this->config->getAppValue('core', 'shareapi_restrict_user_enumeration_to_group', 'no') === 'yes';
-		$restrictEnumerationPhone = $this->config->getAppValue('core', 'shareapi_restrict_user_enumeration_to_phone', 'no') === 'yes';
-		$allowEnumerationFullMatch = $this->config->getAppValue('core', 'shareapi_restrict_user_enumeration_full_match', 'yes') === 'yes';
-		$excludeGroups = $this->config->getAppValue('core', 'shareapi_exclude_groups', 'no');
-
-		// whether to filter out local users
-		$skipLocal = false;
-		// whether to filter out all users which don't have a common group as the current user
-		$ownGroupsOnly = $this->config->getAppValue('core', 'shareapi_only_share_with_group_members', 'no') === 'yes';
-
-		$selfGroups = $this->groupManager->getUserGroupIds($self);
-
-		if ($excludeGroups && $excludeGroups !== 'no') {
-			$excludedGroups = $this->config->getAppValue('core', 'shareapi_exclude_groups_list', '');
-			$decodedExcludeGroups = json_decode($excludedGroups, true);
-			$excludeGroupsList = $decodedExcludeGroups ?? [];
-
-			if ($excludeGroups != 'allow') {
-				if (count($selfGroups) > 0 && count(array_diff($selfGroups, $excludeGroupsList)) === 0) {
-					// all the groups of the current user are excluded -> filter all local users
-					$skipLocal = true;
-				}
-			} else {
-				$skipLocal = true;
-				if (count(array_intersect($excludeGroupsList, $selfGroups)) !== 0) {
-					// a group of the current user is allowed -> do not filter all local users
-					$skipLocal = false;
-				}
-			}
-		}
-
-		// ownGroupsOnly : some groups may be excluded
-		if ($ownGroupsOnly) {
-			$excludeGroupsFromOwnGroups = $this->config->getAppValue('core', 'shareapi_only_share_with_group_members_exclude_group_list', '');
-			$excludeGroupsFromOwnGroupsList = json_decode($excludeGroupsFromOwnGroups, true) ?? [];
-			$selfGroups = array_diff($selfGroups, $excludeGroupsFromOwnGroupsList);
-		}
-
-		$selfUID = $self->getUID();
-
-		return array_values(array_filter($entries, function (IEntry $entry) use ($skipLocal, $ownGroupsOnly, $selfGroups, $selfUID, $disallowEnumeration, $restrictEnumerationGroup, $restrictEnumerationPhone, $allowEnumerationFullMatch, $filter) {
-			if ($entry->getProperty('isLocalSystemBook')) {
-				if ($skipLocal) {
-					return false;
-				}
-
-				$checkedCommonGroupAlready = false;
-
-				// Prevent enumerating local users
-				if ($disallowEnumeration) {
-					if (!$allowEnumerationFullMatch) {
-						return false;
-					}
-
-					$filterOutUser = true;
-
-					$mailAddresses = $entry->getEMailAddresses();
-					foreach ($mailAddresses as $mailAddress) {
-						if ($mailAddress === $filter) {
-							$filterOutUser = false;
-							break;
-						}
-					}
-
-					if ($entry->getProperty('UID') && $entry->getProperty('UID') === $filter) {
-						$filterOutUser = false;
-					}
-
-					if ($filterOutUser) {
-						return false;
-					}
-				} elseif ($restrictEnumerationPhone || $restrictEnumerationGroup) {
-					$canEnumerate = false;
-					if ($restrictEnumerationPhone) {
-						$canEnumerate = $this->knownUserService->isKnownToUser($selfUID, $entry->getProperty('UID'));
-					}
-
-					if (!$canEnumerate && $restrictEnumerationGroup) {
-						$user = $this->userManager->get($entry->getProperty('UID'));
-
-						if ($user === null) {
-							return false;
-						}
-
-						$contactGroups = $this->groupManager->getUserGroupIds($user);
-						$canEnumerate = !empty(array_intersect($contactGroups, $selfGroups));
-						$checkedCommonGroupAlready = true;
-					}
-
-					if (!$canEnumerate) {
-						return false;
-					}
-				}
-
-				if ($ownGroupsOnly && !$checkedCommonGroupAlready) {
-					$user = $this->userManager->get($entry->getProperty('UID'));
-
-					if (!$user instanceof IUser) {
-						return false;
-					}
-
-					$contactGroups = $this->groupManager->getUserGroupIds($user);
-					if (empty(array_intersect($contactGroups, $selfGroups))) {
-						// no groups in common, so shouldn't see the contact
-						return false;
-					}
-				}
-			}
-
-			return true;
-		}));
-	}
-
-	public function findOne(IUser $user, int $shareType, string $shareWith): ?IEntry {
-		switch ($shareType) {
-			case 0:
-			case 6:
-				$filter = ['UID'];
-				break;
-			case 4:
-				$filter = ['EMAIL'];
-				break;
-			default:
-				return null;
-		}
-
-		$contacts = $this->contactsManager->search($shareWith, $filter, [
-			'strict_search' => true,
-		]);
-		$match = null;
-
-		foreach ($contacts as $contact) {
-			if ($shareType === 4 && isset($contact['EMAIL'])) {
-				if (in_array($shareWith, $contact['EMAIL'])) {
-					$match = $contact;
-					break;
-				}
-			}
-			if ($shareType === 0 || $shareType === 6) {
-				if (($contact['isLocalSystemBook'] ?? false) === true && $contact['UID'] === $shareWith) {
-					$match = $contact;
-					break;
-				}
-			}
-		}
-
-		if ($match) {
-			$match = $this->filterContacts($user, [$this->contactArrayToEntry($match)], $shareWith);
-			if (count($match) === 1) {
-				$match = $match[0];
-			} else {
-				$match = null;
-			}
-		}
-
-		return $match;
-	}
-
-	private function contactArrayToEntry(array $contact): Entry {
-		$entry = new Entry();
-
-		if (!empty($contact['UID'])) {
-			$uid = $contact['UID'];
-			$entry->setId($uid);
-			$entry->setProperty('isUser', false);
-			// overloaded usage so leaving as-is for now
-			if (isset($contact['isLocalSystemBook'])) {
-				$avatar = $this->urlGenerator->linkToRouteAbsolute('core.avatar.getAvatar', ['userId' => $uid, 'size' => 64]);
-				$entry->setProperty('isUser', true);
-			} elseif (!empty($contact['FN'])) {
-				$avatar = $this->urlGenerator->linkToRouteAbsolute('core.GuestAvatar.getAvatar', ['guestName' => str_replace('/', ' ', $contact['FN']), 'size' => 64]);
-			} else {
-				$avatar = $this->urlGenerator->linkToRouteAbsolute('core.GuestAvatar.getAvatar', ['guestName' => str_replace('/', ' ', $uid), 'size' => 64]);
-			}
-			$entry->setAvatar($avatar);
-		}
-
-		if (!empty($contact['FN'])) {
-			$entry->setFullName($contact['FN']);
-		}
-
-		$avatarPrefix = 'VALUE=uri:';
-		if (!empty($contact['PHOTO']) && str_starts_with($contact['PHOTO'], $avatarPrefix)) {
-			$entry->setAvatar(substr($contact['PHOTO'], strlen($avatarPrefix)));
-		}
-
-		if (!empty($contact['EMAIL'])) {
-			foreach ($contact['EMAIL'] as $email) {
-				$entry->addEMailAddress($email);
-			}
-		}
-
-		// Provide profile parameters for core/src/OC/contactsmenu/contact.handlebars template
-		if (!empty($contact['UID']) && !empty($contact['FN'])) {
-			$targetUserId = $contact['UID'];
-			$targetUser = $this->userManager->get($targetUserId);
-			if (!empty($targetUser)) {
-				if ($this->profileManager->isProfileEnabled($targetUser)) {
-					$entry->setProfileTitle($this->l10nFactory->get('lib')->t('View profile'));
-					$entry->setProfileUrl($this->urlGenerator->linkToRouteAbsolute('profile.ProfilePage.index', ['targetUserId' => $targetUserId]));
-				}
-			}
-		}
-
-		// Attach all other properties to the entry too because some
-		// providers might make use of it.
-		$entry->setProperties($contact);
-
-		return $entry;
-	}
+    public function __construct(
+        private IManager $contactsManager,
+        private ?StatusService $userStatusService,
+        private IConfig $config,
+        private ProfileManager $profileManager,
+        private IUserManager $userManager,
+        private IURLGenerator $urlGenerator,
+        private IGroupManager $groupManager,
+        private KnownUserService $knownUserService,
+        private IL10NFactory $l10nFactory,
+    ) {
+    }
+
+    /**
+     * @return IEntry[]
+     */
+    public function getContacts(IUser $user, ?string $filter, ?int $limit = null, ?int $offset = null): array {
+        $options = [
+            'enumeration' => $this->config->getAppValue('core', 'shareapi_allow_share_dialog_user_enumeration', 'yes') === 'yes',
+            'fullmatch' => $this->config->getAppValue('core', 'shareapi_restrict_user_enumeration_full_match', 'yes') === 'yes',
+        ];
+        if ($limit !== null) {
+            $options['limit'] = $limit;
+        }
+        if ($offset !== null) {
+            $options['offset'] = $offset;
+        }
+        // Status integration only works without pagination and filters
+        if ($offset === null && ($filter === null || $filter === '')) {
+            $recentStatuses = $this->userStatusService?->findAllRecentStatusChanges($limit, $offset) ?? [];
+        } else {
+            $recentStatuses = [];
+        }
+
+        // Search by status if there is no filter and statuses are available
+        if (!empty($recentStatuses)) {
+            $allContacts = array_filter(array_map(function (UserStatus $userStatus) use ($options) {
+                // UID is ambiguous with federation. We have to use the federated cloud ID to an exact match of
+                // A local user
+                $user = $this->userManager->get($userStatus->getUserId());
+                if ($user === null) {
+                    return null;
+                }
+
+                $contact = $this->contactsManager->search(
+                    $user->getCloudId(),
+                    [
+                        'CLOUD',
+                    ],
+                    array_merge(
+                        $options,
+                        [
+                            'limit' => 1,
+                            'offset' => 0,
+                        ],
+                    ),
+                )[0] ?? null;
+                if ($contact !== null) {
+                    $contact[Entry::PROPERTY_STATUS_MESSAGE_TIMESTAMP] = $userStatus->getStatusMessageTimestamp();
+                }
+                return $contact;
+            }, $recentStatuses));
+            if ($limit !== null && count($allContacts) < $limit) {
+                // More contacts were requested
+                $fromContacts = $this->contactsManager->search(
+                    $filter ?? '',
+                    [
+                        'FN',
+                        'EMAIL'
+                    ],
+                    array_merge(
+                        $options,
+                        [
+                            'limit' => $limit - count($allContacts),
+                        ],
+                    ),
+                );
+
+                // Create hash map of all status contacts
+                $existing = array_fill_keys(array_column($allContacts, 'URI'), null);
+                // Append the ones that are new
+                $allContacts = array_merge(
+                    $allContacts,
+                    array_filter($fromContacts, fn (array $contact): bool => !array_key_exists($contact['URI'], $existing))
+                );
+            }
+        } else {
+            $allContacts = $this->contactsManager->search(
+                $filter ?? '',
+                [
+                    'FN',
+                    'EMAIL'
+                ],
+                $options
+            );
+        }
+
+        $userId = $user->getUID();
+        $contacts = array_filter($allContacts, function ($contact) use ($userId) {
+            // When searching for multiple results, we strip out the current user
+            if (array_key_exists('UID', $contact)) {
+                return $contact['UID'] !== $userId;
+            }
+            return true;
+        });
+
+        $entries = array_map(function (array $contact) {
+            return $this->contactArrayToEntry($contact);
+        }, $contacts);
+        return $this->filterContacts(
+            $user,
+            $entries,
+            $filter
+        );
+    }
+
+    /**
+     * Filters the contacts. Applied filters:
+     *  1. if the `shareapi_allow_share_dialog_user_enumeration` config option is
+     * enabled it will filter all local users
+     *  2. if the `shareapi_exclude_groups` config option is enabled and the
+     * current user is only in excluded groups it will filter all local users.
+     *  3. if the `shareapi_only_share_with_group_members` config option is
+     * enabled it will filter all users which doesn't have a common group
+     * with the current user.
+     * If enabled, the 'shareapi_only_share_with_group_members_exclude_group_list'
+     * config option may specify some groups excluded from the principle of
+     * belonging to the same group.
+     *
+     * @param Entry[] $entries
+     * @return Entry[] the filtered contacts
+     */
+    private function filterContacts(
+        IUser $self,
+        array $entries,
+        ?string $filter,
+    ): array {
+        $disallowEnumeration = $this->config->getAppValue('core', 'shareapi_allow_share_dialog_user_enumeration', 'yes') !== 'yes';
+        $restrictEnumerationGroup = $this->config->getAppValue('core', 'shareapi_restrict_user_enumeration_to_group', 'no') === 'yes';
+        $restrictEnumerationPhone = $this->config->getAppValue('core', 'shareapi_restrict_user_enumeration_to_phone', 'no') === 'yes';
+        $allowEnumerationFullMatch = $this->config->getAppValue('core', 'shareapi_restrict_user_enumeration_full_match', 'yes') === 'yes';
+        $excludeGroups = $this->config->getAppValue('core', 'shareapi_exclude_groups', 'no');
+
+        // whether to filter out local users
+        $skipLocal = false;
+        // whether to filter out all users which don't have a common group as the current user
+        $ownGroupsOnly = $this->config->getAppValue('core', 'shareapi_only_share_with_group_members', 'no') === 'yes';
+
+        $selfGroups = $this->groupManager->getUserGroupIds($self);
+
+        if ($excludeGroups && $excludeGroups !== 'no') {
+            $excludedGroups = $this->config->getAppValue('core', 'shareapi_exclude_groups_list', '');
+            $decodedExcludeGroups = json_decode($excludedGroups, true);
+            $excludeGroupsList = $decodedExcludeGroups ?? [];
+
+            if ($excludeGroups != 'allow') {
+                if (count($selfGroups) > 0 && count(array_diff($selfGroups, $excludeGroupsList)) === 0) {
+                    // all the groups of the current user are excluded -> filter all local users
+                    $skipLocal = true;
+                }
+            } else {
+                $skipLocal = true;
+                if (count(array_intersect($excludeGroupsList, $selfGroups)) !== 0) {
+                    // a group of the current user is allowed -> do not filter all local users
+                    $skipLocal = false;
+                }
+            }
+        }
+
+        // ownGroupsOnly : some groups may be excluded
+        if ($ownGroupsOnly) {
+            $excludeGroupsFromOwnGroups = $this->config->getAppValue('core', 'shareapi_only_share_with_group_members_exclude_group_list', '');
+            $excludeGroupsFromOwnGroupsList = json_decode($excludeGroupsFromOwnGroups, true) ?? [];
+            $selfGroups = array_diff($selfGroups, $excludeGroupsFromOwnGroupsList);
+        }
+
+        $selfUID = $self->getUID();
+
+        return array_values(array_filter($entries, function (IEntry $entry) use ($skipLocal, $ownGroupsOnly, $selfGroups, $selfUID, $disallowEnumeration, $restrictEnumerationGroup, $restrictEnumerationPhone, $allowEnumerationFullMatch, $filter) {
+            if ($entry->getProperty('isLocalSystemBook')) {
+                if ($skipLocal) {
+                    return false;
+                }
+
+                $checkedCommonGroupAlready = false;
+
+                // Prevent enumerating local users
+                if ($disallowEnumeration) {
+                    if (!$allowEnumerationFullMatch) {
+                        return false;
+                    }
+
+                    $filterOutUser = true;
+
+                    $mailAddresses = $entry->getEMailAddresses();
+                    foreach ($mailAddresses as $mailAddress) {
+                        if ($mailAddress === $filter) {
+                            $filterOutUser = false;
+                            break;
+                        }
+                    }
+
+                    if ($entry->getProperty('UID') && $entry->getProperty('UID') === $filter) {
+                        $filterOutUser = false;
+                    }
+
+                    if ($filterOutUser) {
+                        return false;
+                    }
+                } elseif ($restrictEnumerationPhone || $restrictEnumerationGroup) {
+                    $canEnumerate = false;
+                    if ($restrictEnumerationPhone) {
+                        $canEnumerate = $this->knownUserService->isKnownToUser($selfUID, $entry->getProperty('UID'));
+                    }
+
+                    if (!$canEnumerate && $restrictEnumerationGroup) {
+                        $user = $this->userManager->get($entry->getProperty('UID'));
+
+                        if ($user === null) {
+                            return false;
+                        }
+
+                        $contactGroups = $this->groupManager->getUserGroupIds($user);
+                        $canEnumerate = !empty(array_intersect($contactGroups, $selfGroups));
+                        $checkedCommonGroupAlready = true;
+                    }
+
+                    if (!$canEnumerate) {
+                        return false;
+                    }
+                }
+
+                if ($ownGroupsOnly && !$checkedCommonGroupAlready) {
+                    $user = $this->userManager->get($entry->getProperty('UID'));
+
+                    if (!$user instanceof IUser) {
+                        return false;
+                    }
+
+                    $contactGroups = $this->groupManager->getUserGroupIds($user);
+                    if (empty(array_intersect($contactGroups, $selfGroups))) {
+                        // no groups in common, so shouldn't see the contact
+                        return false;
+                    }
+                }
+            }
+
+            return true;
+        }));
+    }
+
+    public function findOne(IUser $user, int $shareType, string $shareWith): ?IEntry {
+        switch ($shareType) {
+            case 0:
+            case 6:
+                $filter = ['UID'];
+                break;
+            case 4:
+                $filter = ['EMAIL'];
+                break;
+            default:
+                return null;
+        }
+
+        $contacts = $this->contactsManager->search($shareWith, $filter, [
+            'strict_search' => true,
+        ]);
+        $match = null;
+
+        foreach ($contacts as $contact) {
+            if ($shareType === 4 && isset($contact['EMAIL'])) {
+                if (in_array($shareWith, $contact['EMAIL'])) {
+                    $match = $contact;
+                    break;
+                }
+            }
+            if ($shareType === 0 || $shareType === 6) {
+                if (($contact['isLocalSystemBook'] ?? false) === true && $contact['UID'] === $shareWith) {
+                    $match = $contact;
+                    break;
+                }
+            }
+        }
+
+        if ($match) {
+            $match = $this->filterContacts($user, [$this->contactArrayToEntry($match)], $shareWith);
+            if (count($match) === 1) {
+                $match = $match[0];
+            } else {
+                $match = null;
+            }
+        }
+
+        return $match;
+    }
+
+    private function contactArrayToEntry(array $contact): Entry {
+        $entry = new Entry();
+
+        if (!empty($contact['UID'])) {
+            $uid = $contact['UID'];
+            $entry->setId($uid);
+            $entry->setProperty('isUser', false);
+            // overloaded usage so leaving as-is for now
+            if (isset($contact['isLocalSystemBook'])) {
+                $avatar = $this->urlGenerator->linkToRouteAbsolute('core.avatar.getAvatar', ['userId' => $uid, 'size' => 64]);
+                $entry->setProperty('isUser', true);
+            } elseif (!empty($contact['FN'])) {
+                $avatar = $this->urlGenerator->linkToRouteAbsolute('core.GuestAvatar.getAvatar', ['guestName' => str_replace('/', ' ', $contact['FN']), 'size' => 64]);
+            } else {
+                $avatar = $this->urlGenerator->linkToRouteAbsolute('core.GuestAvatar.getAvatar', ['guestName' => str_replace('/', ' ', $uid), 'size' => 64]);
+            }
+            $entry->setAvatar($avatar);
+        }
+
+        if (!empty($contact['FN'])) {
+            $entry->setFullName($contact['FN']);
+        }
+
+        $avatarPrefix = 'VALUE=uri:';
+        if (!empty($contact['PHOTO']) && str_starts_with($contact['PHOTO'], $avatarPrefix)) {
+            $entry->setAvatar(substr($contact['PHOTO'], strlen($avatarPrefix)));
+        }
+
+        if (!empty($contact['EMAIL'])) {
+            foreach ($contact['EMAIL'] as $email) {
+                $entry->addEMailAddress($email);
+            }
+        }
+
+        // Provide profile parameters for core/src/OC/contactsmenu/contact.handlebars template
+        if (!empty($contact['UID']) && !empty($contact['FN'])) {
+            $targetUserId = $contact['UID'];
+            $targetUser = $this->userManager->get($targetUserId);
+            if (!empty($targetUser)) {
+                if ($this->profileManager->isProfileEnabled($targetUser)) {
+                    $entry->setProfileTitle($this->l10nFactory->get('lib')->t('View profile'));
+                    $entry->setProfileUrl($this->urlGenerator->linkToRouteAbsolute('profile.ProfilePage.index', ['targetUserId' => $targetUserId]));
+                }
+            }
+        }
+
+        // Attach all other properties to the entry too because some
+        // providers might make use of it.
+        $entry->setProperties($contact);
+
+        return $entry;
+    }
 }

tests/lib/Contacts/ContactsMenu/ContactsStoreTest.php

Indentation +1127 added lines, -1127 removed lines

@@ -25,1131 +25,1131 @@
 use Test\TestCase;
 
 class ContactsStoreTest extends TestCase {
-	private ContactsStore $contactsStore;
-	private StatusService|MockObject $statusService;
-	/** @var IManager|MockObject */
-	private $contactsManager;
-	/** @var ProfileManager */
-	private $profileManager;
-	/** @var IUserManager|MockObject */
-	private $userManager;
-	/** @var IURLGenerator */
-	private $urlGenerator;
-	/** @var IGroupManager|MockObject */
-	private $groupManager;
-	/** @var IConfig|MockObject */
-	private $config;
-	/** @var KnownUserService|MockObject */
-	private $knownUserService;
-	/** @var IL10NFactory */
-	private $l10nFactory;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->contactsManager = $this->createMock(IManager::class);
-		$this->statusService = $this->createMock(StatusService::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->profileManager = $this->createMock(ProfileManager::class);
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->knownUserService = $this->createMock(KnownUserService::class);
-		$this->l10nFactory = $this->createMock(IL10NFactory::class);
-		$this->contactsStore = new ContactsStore(
-			$this->contactsManager,
-			$this->statusService,
-			$this->config,
-			$this->profileManager,
-			$this->userManager,
-			$this->urlGenerator,
-			$this->groupManager,
-			$this->knownUserService,
-			$this->l10nFactory,
-		);
-	}
-
-	public function testGetContactsWithoutFilter(): void {
-		/** @var IUser|MockObject $user */
-		$user = $this->createMock(IUser::class);
-		$this->contactsManager->expects($this->once())
-			->method('search')
-			->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
-			->willReturn([
-				[
-					'UID' => 123,
-				],
-				[
-					'UID' => 567,
-					'FN' => 'Darren Roner',
-					'EMAIL' => [
-						'darren@roner.au'
-					],
-				],
-			]);
-		$user->expects($this->exactly(2))
-			->method('getUID')
-			->willReturn('user123');
-
-		$entries = $this->contactsStore->getContacts($user, '');
-
-		$this->assertCount(2, $entries);
-		$this->assertEquals([
-			'darren@roner.au'
-		], $entries[1]->getEMailAddresses());
-	}
-
-	public function testGetContactsHidesOwnEntry(): void {
-		/** @var IUser|MockObject $user */
-		$user = $this->createMock(IUser::class);
-		$this->contactsManager->expects($this->once())
-			->method('search')
-			->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
-			->willReturn([
-				[
-					'UID' => 'user123',
-				],
-				[
-					'UID' => 567,
-					'FN' => 'Darren Roner',
-					'EMAIL' => [
-						'darren@roner.au'
-					],
-				],
-			]);
-		$user->expects($this->exactly(2))
-			->method('getUID')
-			->willReturn('user123');
-
-		$entries = $this->contactsStore->getContacts($user, '');
-
-		$this->assertCount(1, $entries);
-	}
-
-	public function testGetContactsWithoutBinaryImage(): void {
-		/** @var IUser|MockObject $user */
-		$user = $this->createMock(IUser::class);
-		$this->urlGenerator->expects($this->any())
-			->method('linkToRouteAbsolute')
-			->with('core.GuestAvatar.getAvatar', $this->anything())
-			->willReturn('https://urlToNcAvatar.test');
-		$this->contactsManager->expects($this->once())
-			->method('search')
-			->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
-			->willReturn([
-				[
-					'UID' => 123,
-				],
-				[
-					'UID' => 567,
-					'FN' => 'Darren Roner',
-					'EMAIL' => [
-						'darren@roner.au'
-					],
-					'PHOTO' => base64_encode('photophotophoto'),
-				],
-			]);
-		$user->expects($this->exactly(2))
-			->method('getUID')
-			->willReturn('user123');
-
-		$entries = $this->contactsStore->getContacts($user, '');
-
-		$this->assertCount(2, $entries);
-		$this->assertSame('https://urlToNcAvatar.test', $entries[1]->getAvatar());
-	}
-
-	public function testGetContactsWithoutAvatarURI(): void {
-		/** @var IUser|MockObject $user */
-		$user = $this->createMock(IUser::class);
-		$this->contactsManager->expects($this->once())
-			->method('search')
-			->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
-			->willReturn([
-				[
-					'UID' => 123,
-				],
-				[
-					'UID' => 567,
-					'FN' => 'Darren Roner',
-					'EMAIL' => [
-						'darren@roner.au'
-					],
-					'PHOTO' => 'VALUE=uri:https://photo',
-				],
-			]);
-		$user->expects($this->exactly(2))
-			->method('getUID')
-			->willReturn('user123');
-
-		$entries = $this->contactsStore->getContacts($user, '');
-
-		$this->assertCount(2, $entries);
-		$this->assertEquals('https://photo', $entries[1]->getAvatar());
-	}
-
-	public static function dataGetContactsWhenUserIsInExcludeGroups(): array {
-		return [
-			['yes', '[]', [], ['user123', 'user12345']],
-			['yes', '["excludedGroup1"]', [], ['user123', 'user12345']],
-			['yes', '["excludedGroup1"]', ['anotherGroup1'], ['user123', 'user12345']],
-			['yes', '["excludedGroup1"]', ['anotherGroup1', 'anotherGroup2', 'anotherGroup3'], ['user123', 'user12345']],
-			['yes', '["excludedGroup1"]', ['excludedGroup1'], []],
-			['yes', '["excludedGroup1"]', ['anotherGroup1', 'excludedGroup1'], ['user123', 'user12345']],
-			['yes', '["excludedGroup1"]', ['excludedGroup1', 'anotherGroup1', 'anotherGroup2', 'anotherGroup3'], ['user123', 'user12345']],
-			['yes', '["excludedGroup1", "excludedGroup2", "excludedGroup3"]', [], ['user123', 'user12345']],
-			['yes', '["excludedGroup1", "excludedGroup2", "excludedGroup3"]', ['anotherGroup1'], ['user123', 'user12345']],
-			['yes', '["excludedGroup1", "excludedGroup2", "excludedGroup3"]', ['anotherGroup1', 'anotherGroup2', 'anotherGroup3'], ['user123', 'user12345']],
-			['yes', '["excludedGroup1", "excludedGroup2", "excludedGroup3"]', ['excludedGroup1'], []],
-			['yes', '["excludedGroup1", "excludedGroup2", "excludedGroup3"]', ['excludedGroup2'], []],
-			['yes', '["excludedGroup1", "excludedGroup2", "excludedGroup3"]', ['excludedGroup3'], []],
-			['yes', '["excludedGroup1", "excludedGroup2", "excludedGroup3"]', ['excludedGroup1', 'excludedGroup2', 'excludedGroup3'], []],
-			['yes', '["excludedGroup1", "excludedGroup2", "excludedGroup3"]', ['anotherGroup1', 'excludedGroup1'], ['user123', 'user12345']],
-			['yes', '["excludedGroup1", "excludedGroup2", "excludedGroup3"]', ['anotherGroup1', 'excludedGroup2', 'anotherGroup2', 'anotherGroup3'], ['user123', 'user12345']],
-			['yes', '["excludedGroup1", "excludedGroup2", "excludedGroup3"]', ['excludedGroup3', 'anotherGroup1', 'anotherGroup2', 'anotherGroup3'], ['user123', 'user12345']],
-			['allow', '[]', [], []],
-			['allow', '["allowedGroup1"]', [], []],
-			['allow', '["allowedGroup1"]', ['anotherGroup1'], []],
-			['allow', '["allowedGroup1"]', ['anotherGroup1', 'anotherGroup2', 'anotherGroup3'], []],
-			['allow', '["allowedGroup1"]', ['allowedGroup1'], ['user123', 'user12345']],
-			['allow', '["allowedGroup1"]', ['anotherGroup1', 'allowedGroup1'], ['user123', 'user12345']],
-			['allow', '["allowedGroup1"]', ['allowedGroup1', 'anotherGroup1', 'anotherGroup2', 'anotherGroup3'], ['user123', 'user12345']],
-			['allow', '["allowedGroup1", "allowedGroup2", "allowedGroup3"]', [], []],
-			['allow', '["allowedGroup1", "allowedGroup2", "allowedGroup3"]', ['anotherGroup1'], []],
-			['allow', '["allowedGroup1", "allowedGroup2", "allowedGroup3"]', ['anotherGroup1', 'anotherGroup2', 'anotherGroup3'], []],
-			['allow', '["allowedGroup1", "allowedGroup2", "allowedGroup3"]', ['allowedGroup1'], ['user123', 'user12345']],
-			['allow', '["allowedGroup1", "allowedGroup2", "allowedGroup3"]', ['allowedGroup2'], ['user123', 'user12345']],
-			['allow', '["allowedGroup1", "allowedGroup2", "allowedGroup3"]', ['allowedGroup3'], ['user123', 'user12345']],
-			['allow', '["allowedGroup1", "allowedGroup2", "allowedGroup3"]', ['allowedGroup1', 'allowedGroup2', 'allowedGroup3'], ['user123', 'user12345']],
-			['allow', '["allowedGroup1", "allowedGroup2", "allowedGroup3"]', ['anotherGroup1', 'allowedGroup1'], ['user123', 'user12345']],
-			['allow', '["allowedGroup1", "allowedGroup2", "allowedGroup3"]', ['anotherGroup1', 'allowedGroup2', 'anotherGroup2', 'anotherGroup3'], ['user123', 'user12345']],
-			['allow', '["allowedGroup1", "allowedGroup2", "allowedGroup3"]', ['allowedGroup3', 'anotherGroup1', 'anotherGroup2', 'anotherGroup3'], ['user123', 'user12345']],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataGetContactsWhenUserIsInExcludeGroups')]
-	public function testGetContactsWhenUserIsInExcludeGroups(string $excludeGroups, string $excludeGroupsList, array $currentUserGroupIds, array $expectedUids): void {
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', 'yes'],
-				['core', 'shareapi_restrict_user_enumeration_to_group', 'no', 'no'],
-				['core', 'shareapi_restrict_user_enumeration_to_phone', 'no', 'no'],
-				['core', 'shareapi_exclude_groups', 'no', $excludeGroups],
-				['core', 'shareapi_only_share_with_group_members', 'no', 'no'],
-				['core', 'shareapi_exclude_groups_list', '', $excludeGroupsList],
-				['core', 'shareapi_only_share_with_group_members_exclude_group_list', '', '[]'],
-			]);
-
-		/** @var IUser|MockObject $currentUser */
-		$currentUser = $this->createMock(IUser::class);
-		$currentUser->expects($this->exactly(2))
-			->method('getUID')
-			->willReturn('user001');
-
-		$this->groupManager->expects($this->once())
-			->method('getUserGroupIds')
-			->with($this->equalTo($currentUser))
-			->willReturn($currentUserGroupIds);
-
-		$this->contactsManager->expects($this->once())
-			->method('search')
-			->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
-			->willReturn([
-				[
-					'UID' => 'user123',
-					'isLocalSystemBook' => true
-				],
-				[
-					'UID' => 'user12345',
-					'isLocalSystemBook' => true
-				],
-			]);
-
-
-		$entries = $this->contactsStore->getContacts($currentUser, '');
-
-		$this->assertCount(count($expectedUids), $entries);
-		for ($i = 0; $i < count($expectedUids); $i++) {
-			$this->assertEquals($expectedUids[$i], $entries[$i]->getProperty('UID'));
-		}
-	}
-
-	public function testGetContactsOnlyShareIfInTheSameGroupWhenUserIsInExcludeGroups(): void {
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', 'yes'],
-				['core', 'shareapi_restrict_user_enumeration_to_group', 'no', 'no'],
-				['core', 'shareapi_restrict_user_enumeration_to_phone', 'no', 'no'],
-				['core', 'shareapi_exclude_groups', 'no', 'yes'],
-				['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
-				['core', 'shareapi_exclude_groups_list', '', '["group1", "group5", "group6"]'],
-				['core', 'shareapi_only_share_with_group_members_exclude_group_list', '', '[]'],
-			]);
-
-		/** @var IUser|MockObject $currentUser */
-		$currentUser = $this->createMock(IUser::class);
-		$currentUser->expects($this->exactly(2))
-			->method('getUID')
-			->willReturn('user001');
-
-		$this->groupManager->expects($this->once())
-			->method('getUserGroupIds')
-			->with($this->equalTo($currentUser))
-			->willReturn(['group1', 'group2', 'group3']);
-
-
-		$this->contactsManager->expects($this->once())
-			->method('search')
-			->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
-			->willReturn([
-				[
-					'UID' => 'user123',
-					'isLocalSystemBook' => true
-				],
-				[
-					'UID' => 'user12345',
-					'isLocalSystemBook' => true
-				],
-			]);
-
-
-		$entries = $this->contactsStore->getContacts($currentUser, '');
-
-		$this->assertCount(0, $entries);
-	}
-
-	public function testGetContactsOnlyShareIfInTheSameGroup(): void {
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', 'yes'],
-				['core', 'shareapi_restrict_user_enumeration_to_group', 'no', 'no'],
-				['core', 'shareapi_restrict_user_enumeration_to_phone', 'no', 'no'],
-				['core', 'shareapi_exclude_groups', 'no', 'no'],
-				['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
-				['core', 'shareapi_only_share_with_group_members_exclude_group_list', '', '[]'],
-			]);
-
-		/** @var IUser|MockObject $currentUser */
-		$currentUser = $this->createMock(IUser::class);
-		$currentUser->expects($this->exactly(2))
-			->method('getUID')
-			->willReturn('user001');
-
-		$user1 = $this->createMock(IUser::class);
-		$user2 = $this->createMock(IUser::class);
-		$user3 = $this->createMock(IUser::class);
-
-		$calls = [
-			[[$currentUser], ['group1', 'group2', 'group3']],
-			[[$user1], ['group1']],
-			[[$user2], ['group2', 'group3']],
-			[[$user3], ['group8', 'group9']],
-		];
-		$this->groupManager->expects($this->exactly(4))
-			->method('getUserGroupIds')
-			->willReturnCallback(function () use (&$calls): array {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected[0], func_get_args());
-				return $expected[1];
-			});
-
-		$this->userManager->expects($this->exactly(3))
-			->method('get')
-			->willReturnMap([
-				['user1', $user1],
-				['user2', $user2],
-				['user3', $user3],
-			]);
-
-		$this->contactsManager->expects($this->once())
-			->method('search')
-			->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
-			->willReturn([
-				[
-					'UID' => 'user1',
-					'isLocalSystemBook' => true
-				],
-				[
-					'UID' => 'user2',
-					'isLocalSystemBook' => true
-				],
-				[
-					'UID' => 'user3',
-					'isLocalSystemBook' => true
-				],
-				[
-					'UID' => 'contact',
-				],
-			]);
-
-		$entries = $this->contactsStore->getContacts($currentUser, '');
-
-		$this->assertCount(3, $entries);
-		$this->assertEquals('user1', $entries[0]->getProperty('UID'));
-		$this->assertEquals('user2', $entries[1]->getProperty('UID'));
-		$this->assertEquals('contact', $entries[2]->getProperty('UID'));
-	}
-
-	public function testGetContactsOnlyEnumerateIfInTheSameGroup(): void {
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', 'yes'],
-				['core', 'shareapi_restrict_user_enumeration_to_group', 'no', 'yes'],
-				['core', 'shareapi_restrict_user_enumeration_to_phone', 'no', 'no'],
-				['core', 'shareapi_exclude_groups', 'no', 'no'],
-				['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
-				['core', 'shareapi_only_share_with_group_members_exclude_group_list', '', '[]'],
-			]);
-
-		/** @var IUser|MockObject $currentUser */
-		$currentUser = $this->createMock(IUser::class);
-		$currentUser->expects($this->exactly(2))
-			->method('getUID')
-			->willReturn('user001');
-
-		$user1 = $this->createMock(IUser::class);
-		$user2 = $this->createMock(IUser::class);
-		$user3 = $this->createMock(IUser::class);
-
-		$calls = [
-			[[$currentUser], ['group1', 'group2', 'group3']],
-			[[$user1], ['group1']],
-			[[$user2], ['group2', 'group3']],
-			[[$user3], ['group8', 'group9']],
-		];
-		$this->groupManager->expects($this->exactly(4))
-			->method('getUserGroupIds')
-			->willReturnCallback(function () use (&$calls): array {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected[0], func_get_args());
-				return $expected[1];
-			});
-
-		$this->userManager->expects($this->exactly(3))
-			->method('get')
-			->willReturnMap([
-				['user1', $user1],
-				['user2', $user2],
-				['user3', $user3],
-			]);
-
-		$this->contactsManager->expects($this->once())
-			->method('search')
-			->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
-			->willReturn([
-				[
-					'UID' => 'user1',
-					'isLocalSystemBook' => true
-				],
-				[
-					'UID' => 'user2',
-					'isLocalSystemBook' => true
-				],
-				[
-					'UID' => 'user3',
-					'isLocalSystemBook' => true
-				],
-				[
-					'UID' => 'contact',
-				],
-			]);
-
-		$entries = $this->contactsStore->getContacts($currentUser, '');
-
-		$this->assertCount(3, $entries);
-		$this->assertEquals('user1', $entries[0]->getProperty('UID'));
-		$this->assertEquals('user2', $entries[1]->getProperty('UID'));
-		$this->assertEquals('contact', $entries[2]->getProperty('UID'));
-	}
-
-	public function testGetContactsOnlyEnumerateIfPhoneBookMatch(): void {
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', 'yes'],
-				['core', 'shareapi_restrict_user_enumeration_to_group', 'no', 'no'],
-				['core', 'shareapi_restrict_user_enumeration_to_phone', 'no', 'yes'],
-				['core', 'shareapi_exclude_groups', 'no', 'no'],
-				['core', 'shareapi_only_share_with_group_members', 'no', 'no'],
-			]);
-
-		/** @var IUser|MockObject $currentUser */
-		$currentUser = $this->createMock(IUser::class);
-		$currentUser->expects($this->exactly(2))
-			->method('getUID')
-			->willReturn('user001');
-
-		$this->groupManager->expects($this->once())
-			->method('getUserGroupIds')
-			->with($this->equalTo($currentUser))
-			->willReturn(['group1', 'group2', 'group3']);
-
-		$this->knownUserService->method('isKnownToUser')
-			->willReturnMap([
-				['user001', 'user1', true],
-				['user001', 'user2', true],
-				['user001', 'user3', false],
-			]);
-
-		$this->contactsManager->expects($this->once())
-			->method('search')
-			->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
-			->willReturn([
-				[
-					'UID' => 'user1',
-					'isLocalSystemBook' => true
-				],
-				[
-					'UID' => 'user2',
-					'isLocalSystemBook' => true
-				],
-				[
-					'UID' => 'user3',
-					'isLocalSystemBook' => true
-				],
-				[
-					'UID' => 'contact',
-				],
-			]);
-
-		$entries = $this->contactsStore->getContacts($currentUser, '');
-
-		$this->assertCount(3, $entries);
-		$this->assertEquals('user1', $entries[0]->getProperty('UID'));
-		$this->assertEquals('user2', $entries[1]->getProperty('UID'));
-		$this->assertEquals('contact', $entries[2]->getProperty('UID'));
-	}
-
-	public function testGetContactsOnlyEnumerateIfPhoneBookMatchWithOwnGroupsOnly(): void {
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', 'yes'],
-				['core', 'shareapi_restrict_user_enumeration_to_group', 'no', 'no'],
-				['core', 'shareapi_restrict_user_enumeration_to_phone', 'no', 'yes'],
-				['core', 'shareapi_exclude_groups', 'no', 'no'],
-				['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
-				['core', 'shareapi_only_share_with_group_members_exclude_group_list', '', '[]'],
-			]);
-
-		/** @var IUser|MockObject $currentUser */
-		$currentUser = $this->createMock(IUser::class);
-		$currentUser->expects($this->exactly(2))
-			->method('getUID')
-			->willReturn('user001');
-
-		$user1 = $this->createMock(IUser::class);
-		$user2 = $this->createMock(IUser::class);
-		$user3 = $this->createMock(IUser::class);
-
-		$calls = [
-			[[$currentUser], ['group1', 'group2', 'group3']],
-			[[$user1], ['group1']],
-			[[$user2], ['group2', 'group3']],
-			[[$user3], ['group8', 'group9']],
-		];
-		$this->groupManager->expects($this->exactly(4))
-			->method('getUserGroupIds')
-			->willReturnCallback(function () use (&$calls): array {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected[0], func_get_args());
-				return $expected[1];
-			});
-
-		$this->userManager->expects($this->exactly(3))
-			->method('get')
-			->willReturnMap([
-				['user1', $user1],
-				['user2', $user2],
-				['user3', $user3],
-			]);
-
-		$this->knownUserService->method('isKnownToUser')
-			->willReturnMap([
-				['user001', 'user1', true],
-				['user001', 'user2', true],
-				['user001', 'user3', true],
-			]);
-
-		$this->contactsManager->expects($this->once())
-			->method('search')
-			->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
-			->willReturn([
-				[
-					'UID' => 'user1',
-					'isLocalSystemBook' => true
-				],
-				[
-					'UID' => 'user2',
-					'isLocalSystemBook' => true
-				],
-				[
-					'UID' => 'user3',
-					'isLocalSystemBook' => true
-				],
-				[
-					'UID' => 'contact',
-				],
-			]);
-
-		$entries = $this->contactsStore->getContacts($currentUser, '');
-
-		$this->assertCount(3, $entries);
-		$this->assertEquals('user1', $entries[0]->getProperty('UID'));
-		$this->assertEquals('user2', $entries[1]->getProperty('UID'));
-		$this->assertEquals('contact', $entries[2]->getProperty('UID'));
-	}
-
-	public function testGetContactsOnlyEnumerateIfPhoneBookOrSameGroup(): void {
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', 'yes'],
-				['core', 'shareapi_restrict_user_enumeration_to_group', 'no', 'yes'],
-				['core', 'shareapi_restrict_user_enumeration_to_phone', 'no', 'yes'],
-				['core', 'shareapi_exclude_groups', 'no', 'no'],
-				['core', 'shareapi_only_share_with_group_members', 'no', 'no'],
-			]);
-
-		/** @var IUser|MockObject $currentUser */
-		$currentUser = $this->createMock(IUser::class);
-		$currentUser->expects($this->exactly(2))
-			->method('getUID')
-			->willReturn('user001');
-
-		$user1 = $this->createMock(IUser::class);
-
-		$calls = [
-			[[$currentUser], ['group1', 'group2', 'group3']],
-			[[$user1], ['group1']],
-		];
-		$this->groupManager->expects($this->exactly(2))
-			->method('getUserGroupIds')
-			->willReturnCallback(function () use (&$calls): array {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected[0], func_get_args());
-				return $expected[1];
-			});
-
-		$this->userManager->expects($this->once())
-			->method('get')
-			->with('user1')
-			->willReturn($user1);
-
-		$this->knownUserService->method('isKnownToUser')
-			->willReturnMap([
-				['user001', 'user1', false],
-				['user001', 'user2', true],
-				['user001', 'user3', true],
-			]);
-
-		$this->contactsManager->expects($this->once())
-			->method('search')
-			->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
-			->willReturn([
-				[
-					'UID' => 'user1',
-					'isLocalSystemBook' => true
-				],
-				[
-					'UID' => 'user2',
-					'isLocalSystemBook' => true
-				],
-				[
-					'UID' => 'user3',
-					'isLocalSystemBook' => true
-				],
-				[
-					'UID' => 'contact',
-				],
-			]);
-
-		$entries = $this->contactsStore->getContacts($currentUser, '');
-
-		$this->assertCount(4, $entries);
-		$this->assertEquals('user1', $entries[0]->getProperty('UID'));
-		$this->assertEquals('user2', $entries[1]->getProperty('UID'));
-		$this->assertEquals('user3', $entries[2]->getProperty('UID'));
-		$this->assertEquals('contact', $entries[3]->getProperty('UID'));
-	}
-
-	public function testGetContactsOnlyEnumerateIfPhoneBookOrSameGroupInOwnGroupsOnly(): void {
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', 'yes'],
-				['core', 'shareapi_restrict_user_enumeration_to_group', 'no', 'yes'],
-				['core', 'shareapi_restrict_user_enumeration_to_phone', 'no', 'yes'],
-				['core', 'shareapi_exclude_groups', 'no', 'no'],
-				['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
-				['core', 'shareapi_only_share_with_group_members_exclude_group_list', '', '[]'],
-			]);
-
-		/** @var IUser|MockObject $currentUser */
-		$currentUser = $this->createMock(IUser::class);
-		$currentUser->expects($this->exactly(2))
-			->method('getUID')
-			->willReturn('user001');
-
-		$user1 = $this->createMock(IUser::class);
-		$user2 = $this->createMock(IUser::class);
-		$user3 = $this->createMock(IUser::class);
-
-		$calls = [
-			[[$currentUser], ['group1', 'group2', 'group3']],
-			[[$user1], ['group1']],
-			[[$user2], ['group2', 'group3']],
-			[[$user3], ['group8', 'group9']],
-		];
-		$this->groupManager->expects($this->exactly(4))
-			->method('getUserGroupIds')
-			->willReturnCallback(function () use (&$calls): array {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected[0], func_get_args());
-				return $expected[1];
-			});
-
-		$this->userManager->expects($this->exactly(3))
-			->method('get')
-			->willReturnMap([
-				['user1', $user1],
-				['user2', $user2],
-				['user3', $user3],
-			]);
-
-		$this->knownUserService->method('isKnownToUser')
-			->willReturnMap([
-				['user001', 'user1', false],
-				['user001', 'user2', true],
-				['user001', 'user3', true],
-			]);
-
-		$this->contactsManager->expects($this->once())
-			->method('search')
-			->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
-			->willReturn([
-				[
-					'UID' => 'user1',
-					'isLocalSystemBook' => true
-				],
-				[
-					'UID' => 'user2',
-					'isLocalSystemBook' => true
-				],
-				[
-					'UID' => 'user3',
-					'isLocalSystemBook' => true
-				],
-				[
-					'UID' => 'contact',
-				],
-			]);
-
-		$entries = $this->contactsStore->getContacts($currentUser, '');
-
-		$this->assertCount(3, $entries);
-		$this->assertEquals('user1', $entries[0]->getProperty('UID'));
-		$this->assertEquals('user2', $entries[1]->getProperty('UID'));
-		$this->assertEquals('contact', $entries[2]->getProperty('UID'));
-	}
-
-	public function testGetContactsWithFilter(): void {
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', 'no'],
-				['core', 'shareapi_restrict_user_enumeration_full_match', 'yes', 'yes'],
-			]);
-
-		/** @var IUser|MockObject $user */
-		$user = $this->createMock(IUser::class);
-		$this->contactsManager->expects($this->any())
-			->method('search')
-			->willReturn([
-				[
-					'UID' => 'a567',
-					'FN' => 'Darren Roner',
-					'EMAIL' => [
-						'darren@roner.au',
-					],
-					'isLocalSystemBook' => true,
-				],
-				[
-					'UID' => 'john',
-					'FN' => 'John Doe',
-					'EMAIL' => [
-						'john@example.com',
-					],
-					'isLocalSystemBook' => true,
-				],
-				[
-					'FN' => 'Anne D',
-					'EMAIL' => [
-						'anne@example.com',
-					],
-					'isLocalSystemBook' => false,
-				],
-			]);
-		$user->expects($this->any())
-			->method('getUID')
-			->willReturn('user123');
-
-		// Complete match on UID should match
-		$entry = $this->contactsStore->getContacts($user, 'a567');
-		$this->assertSame(2, count($entry));
-		$this->assertEquals([
-			'darren@roner.au'
-		], $entry[0]->getEMailAddresses());
-
-		// Partial match on UID should not match
-		$entry = $this->contactsStore->getContacts($user, 'a56');
-		$this->assertSame(1, count($entry));
-		$this->assertEquals([
-			'anne@example.com'
-		], $entry[0]->getEMailAddresses());
-
-		// Complete match on email should match
-		$entry = $this->contactsStore->getContacts($user, 'john@example.com');
-		$this->assertSame(2, count($entry));
-		$this->assertEquals([
-			'john@example.com'
-		], $entry[0]->getEMailAddresses());
-		$this->assertEquals([
-			'anne@example.com'
-		], $entry[1]->getEMailAddresses());
-
-		// Partial match on email should not match
-		$entry = $this->contactsStore->getContacts($user, 'john@example.co');
-		$this->assertSame(1, count($entry));
-		$this->assertEquals([
-			'anne@example.com'
-		], $entry[0]->getEMailAddresses());
-
-		// Match on FN should not match
-		$entry = $this->contactsStore->getContacts($user, 'Darren Roner');
-		$this->assertSame(1, count($entry));
-		$this->assertEquals([
-			'anne@example.com'
-		], $entry[0]->getEMailAddresses());
-
-		// Don't filter users in local addressbook
-		$entry = $this->contactsStore->getContacts($user, 'Anne D');
-		$this->assertSame(1, count($entry));
-		$this->assertEquals([
-			'anne@example.com'
-		], $entry[0]->getEMailAddresses());
-	}
-
-	public function testGetContactsWithFilterWithoutFullMatch(): void {
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', 'no'],
-				['core', 'shareapi_restrict_user_enumeration_full_match', 'yes', 'no'],
-			]);
-
-		/** @var IUser|MockObject $user */
-		$user = $this->createMock(IUser::class);
-		$this->contactsManager->expects($this->any())
-			->method('search')
-			->willReturn([
-				[
-					'UID' => 'a567',
-					'FN' => 'Darren Roner',
-					'EMAIL' => [
-						'darren@roner.au',
-					],
-					'isLocalSystemBook' => true,
-				],
-				[
-					'UID' => 'john',
-					'FN' => 'John Doe',
-					'EMAIL' => [
-						'john@example.com',
-					],
-					'isLocalSystemBook' => true,
-				],
-				[
-					'FN' => 'Anne D',
-					'EMAIL' => [
-						'anne@example.com',
-					],
-					'isLocalSystemBook' => false,
-				],
-			]);
-		$user->expects($this->any())
-			->method('getUID')
-			->willReturn('user123');
-
-		// Complete match on UID should not match
-		$entry = $this->contactsStore->getContacts($user, 'a567');
-		$this->assertSame(1, count($entry));
-		$this->assertEquals([
-			'anne@example.com'
-		], $entry[0]->getEMailAddresses());
-
-		// Partial match on UID should not match
-		$entry = $this->contactsStore->getContacts($user, 'a56');
-		$this->assertSame(1, count($entry));
-		$this->assertEquals([
-			'anne@example.com'
-		], $entry[0]->getEMailAddresses());
-
-		// Complete match on email should not match
-		$entry = $this->contactsStore->getContacts($user, 'john@example.com');
-		$this->assertSame(1, count($entry));
-		$this->assertEquals([
-			'anne@example.com'
-		], $entry[0]->getEMailAddresses());
-
-		// Partial match on email should not match
-		$entry = $this->contactsStore->getContacts($user, 'john@example.co');
-		$this->assertSame(1, count($entry));
-		$this->assertEquals([
-			'anne@example.com'
-		], $entry[0]->getEMailAddresses());
-
-		// Match on FN should not match
-		$entry = $this->contactsStore->getContacts($user, 'Darren Roner');
-		$this->assertSame(1, count($entry));
-		$this->assertEquals([
-			'anne@example.com'
-		], $entry[0]->getEMailAddresses());
-
-		// Don't filter users in local addressbook
-		$entry = $this->contactsStore->getContacts($user, 'Anne D');
-		$this->assertSame(1, count($entry));
-		$this->assertEquals([
-			'anne@example.com'
-		], $entry[0]->getEMailAddresses());
-	}
-
-	public function testFindOneUser(): void {
-		$this->config
-			->method('getAppValue')
-			->willReturnMap([
-				['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', 'yes'],
-				['core', 'shareapi_restrict_user_enumeration_to_group', 'no', 'no'],
-				['core', 'shareapi_restrict_user_enumeration_to_phone', 'no', 'no'],
-				['core', 'shareapi_restrict_user_enumeration_full_match', 'yes', 'yes'],
-				['core', 'shareapi_exclude_groups', 'no', 'yes'],
-				['core', 'shareapi_exclude_groups_list', '', ''],
-				['core', 'shareapi_only_share_with_group_members', 'no', 'no'],
-			]);
-
-		/** @var IUser|MockObject $user */
-		$user = $this->createMock(IUser::class);
-		$this->contactsManager->expects($this->once())
-			->method('search')
-			->with($this->equalTo('a567'), $this->equalTo(['UID']))
-			->willReturn([
-				[
-					'UID' => 123,
-					'isLocalSystemBook' => false
-				],
-				[
-					'UID' => 'a567',
-					'FN' => 'Darren Roner',
-					'EMAIL' => [
-						'darren@roner.au'
-					],
-					'isLocalSystemBook' => true
-				],
-			]);
-		$user->expects($this->any())
-			->method('getUID')
-			->willReturn('user123');
-
-		$entry = $this->contactsStore->findOne($user, 0, 'a567');
-
-		$this->assertEquals([
-			'darren@roner.au'
-		], $entry->getEMailAddresses());
-	}
-
-	public function testFindOneEMail(): void {
-		/** @var IUser|MockObject $user */
-		$user = $this->createMock(IUser::class);
-		$this->contactsManager->expects($this->once())
-			->method('search')
-			->with($this->equalTo('darren@roner.au'), $this->equalTo(['EMAIL']))
-			->willReturn([
-				[
-					'UID' => 123,
-					'isLocalSystemBook' => false
-				],
-				[
-					'UID' => 'a567',
-					'FN' => 'Darren Roner',
-					'EMAIL' => [
-						'darren@roner.au'
-					],
-					'isLocalSystemBook' => false
-				],
-			]);
-		$user->expects($this->any())
-			->method('getUID')
-			->willReturn('user123');
-
-		$entry = $this->contactsStore->findOne($user, 4, 'darren@roner.au');
-
-		$this->assertEquals([
-			'darren@roner.au'
-		], $entry->getEMailAddresses());
-	}
-
-	public function testFindOneNotSupportedType(): void {
-		/** @var IUser|MockObject $user */
-		$user = $this->createMock(IUser::class);
-
-		$entry = $this->contactsStore->findOne($user, 42, 'darren@roner.au');
-
-		$this->assertEquals(null, $entry);
-	}
-
-	public function testFindOneNoMatches(): void {
-		/** @var IUser|MockObject $user */
-		$user = $this->createMock(IUser::class);
-		$this->contactsManager->expects($this->once())
-			->method('search')
-			->with($this->equalTo('a567'), $this->equalTo(['UID']))
-			->willReturn([
-				[
-					'UID' => 123,
-					'isLocalSystemBook' => false
-				],
-				[
-					'UID' => 'a567',
-					'FN' => 'Darren Roner',
-					'EMAIL' => [
-						'darren@roner.au123'
-					],
-					'isLocalSystemBook' => false
-				],
-			]);
-		$user->expects($this->never())
-			->method('getUID');
-
-		$entry = $this->contactsStore->findOne($user, 0, 'a567');
-
-		$this->assertEquals(null, $entry);
-	}
-
-	public function testGetRecentStatusFirst(): void {
-		$user = $this->createMock(IUser::class);
-		$status1 = new UserStatus();
-		$status1->setUserId('user1');
-		$status2 = new UserStatus();
-		$status2->setUserId('user2');
-		$this->statusService->expects(self::once())
-			->method('findAllRecentStatusChanges')
-			->willReturn([
-				$status1,
-				$status2,
-			]);
-		$user1 = $this->createMock(IUser::class);
-		$user1->method('getCloudId')->willReturn('user1@localcloud');
-		$user2 = $this->createMock(IUser::class);
-		$user2->method('getCloudId')->willReturn('user2@localcloud');
-		$this->userManager->expects(self::exactly(2))
-			->method('get')
-			->willReturnCallback(function ($uid) use ($user1, $user2) {
-				return match ($uid) {
-					'user1' => $user1,
-					'user2' => $user2,
-				};
-			});
-		$this->contactsManager
-			->expects(self::exactly(3))
-			->method('search')
-			->willReturnCallback(function ($uid, $searchProps, $options) {
-				return match ([$uid, $options['limit'] ?? null]) {
-					['user1@localcloud', 1] => [
-						[
-							'UID' => 'user1',
-							'URI' => 'user1.vcf',
-						],
-					],
-					['user2@localcloud' => [], 1], // Simulate not found
-					['', 4] => [
-						[
-							'UID' => 'contact1',
-							'URI' => 'contact1.vcf',
-						],
-						[
-							'UID' => 'contact2',
-							'URI' => 'contact2.vcf',
-						],
-					],
-					default => [],
-				};
-			});
-
-		$contacts = $this->contactsStore->getContacts(
-			$user,
-			null,
-			5,
-		);
-
-		self::assertCount(3, $contacts);
-		self::assertEquals('user1', $contacts[0]->getProperty('UID'));
-		self::assertEquals('contact1', $contacts[1]->getProperty('UID'));
-		self::assertEquals('contact2', $contacts[2]->getProperty('UID'));
-	}
-
-	public function testPaginateRecentStatus(): void {
-		$user = $this->createMock(IUser::class);
-		$status1 = new UserStatus();
-		$status1->setUserId('user1');
-		$status2 = new UserStatus();
-		$status2->setUserId('user2');
-		$status3 = new UserStatus();
-		$status3->setUserId('user3');
-		$this->statusService->expects(self::never())
-			->method('findAllRecentStatusChanges');
-		$this->contactsManager
-			->expects(self::exactly(2))
-			->method('search')
-			->willReturnCallback(function ($uid, $searchProps, $options) {
-				return match ([$uid, $options['limit'] ?? null, $options['offset'] ?? null]) {
-					['', 2, 0] => [
-						[
-							'UID' => 'contact1',
-							'URI' => 'contact1.vcf',
-						],
-						[
-							'UID' => 'contact2',
-							'URI' => 'contact2.vcf',
-						],
-					],
-					['', 2, 3] => [
-						[
-							'UID' => 'contact3',
-							'URI' => 'contact3.vcf',
-						],
-					],
-					default => [],
-				};
-			});
-
-		$page1 = $this->contactsStore->getContacts(
-			$user,
-			null,
-			2,
-			0,
-		);
-		$page2 = $this->contactsStore->getContacts(
-			$user,
-			null,
-			2,
-			3,
-		);
-
-		self::assertCount(2, $page1);
-		self::assertCount(1, $page2);
-	}
+    private ContactsStore $contactsStore;
+    private StatusService|MockObject $statusService;
+    /** @var IManager|MockObject */
+    private $contactsManager;
+    /** @var ProfileManager */
+    private $profileManager;
+    /** @var IUserManager|MockObject */
+    private $userManager;
+    /** @var IURLGenerator */
+    private $urlGenerator;
+    /** @var IGroupManager|MockObject */
+    private $groupManager;
+    /** @var IConfig|MockObject */
+    private $config;
+    /** @var KnownUserService|MockObject */
+    private $knownUserService;
+    /** @var IL10NFactory */
+    private $l10nFactory;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->contactsManager = $this->createMock(IManager::class);
+        $this->statusService = $this->createMock(StatusService::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->profileManager = $this->createMock(ProfileManager::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->knownUserService = $this->createMock(KnownUserService::class);
+        $this->l10nFactory = $this->createMock(IL10NFactory::class);
+        $this->contactsStore = new ContactsStore(
+            $this->contactsManager,
+            $this->statusService,
+            $this->config,
+            $this->profileManager,
+            $this->userManager,
+            $this->urlGenerator,
+            $this->groupManager,
+            $this->knownUserService,
+            $this->l10nFactory,
+        );
+    }
+
+    public function testGetContactsWithoutFilter(): void {
+        /** @var IUser|MockObject $user */
+        $user = $this->createMock(IUser::class);
+        $this->contactsManager->expects($this->once())
+            ->method('search')
+            ->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
+            ->willReturn([
+                [
+                    'UID' => 123,
+                ],
+                [
+                    'UID' => 567,
+                    'FN' => 'Darren Roner',
+                    'EMAIL' => [
+                        'darren@roner.au'
+                    ],
+                ],
+            ]);
+        $user->expects($this->exactly(2))
+            ->method('getUID')
+            ->willReturn('user123');
+
+        $entries = $this->contactsStore->getContacts($user, '');
+
+        $this->assertCount(2, $entries);
+        $this->assertEquals([
+            'darren@roner.au'
+        ], $entries[1]->getEMailAddresses());
+    }
+
+    public function testGetContactsHidesOwnEntry(): void {
+        /** @var IUser|MockObject $user */
+        $user = $this->createMock(IUser::class);
+        $this->contactsManager->expects($this->once())
+            ->method('search')
+            ->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
+            ->willReturn([
+                [
+                    'UID' => 'user123',
+                ],
+                [
+                    'UID' => 567,
+                    'FN' => 'Darren Roner',
+                    'EMAIL' => [
+                        'darren@roner.au'
+                    ],
+                ],
+            ]);
+        $user->expects($this->exactly(2))
+            ->method('getUID')
+            ->willReturn('user123');
+
+        $entries = $this->contactsStore->getContacts($user, '');
+
+        $this->assertCount(1, $entries);
+    }
+
+    public function testGetContactsWithoutBinaryImage(): void {
+        /** @var IUser|MockObject $user */
+        $user = $this->createMock(IUser::class);
+        $this->urlGenerator->expects($this->any())
+            ->method('linkToRouteAbsolute')
+            ->with('core.GuestAvatar.getAvatar', $this->anything())
+            ->willReturn('https://urlToNcAvatar.test');
+        $this->contactsManager->expects($this->once())
+            ->method('search')
+            ->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
+            ->willReturn([
+                [
+                    'UID' => 123,
+                ],
+                [
+                    'UID' => 567,
+                    'FN' => 'Darren Roner',
+                    'EMAIL' => [
+                        'darren@roner.au'
+                    ],
+                    'PHOTO' => base64_encode('photophotophoto'),
+                ],
+            ]);
+        $user->expects($this->exactly(2))
+            ->method('getUID')
+            ->willReturn('user123');
+
+        $entries = $this->contactsStore->getContacts($user, '');
+
+        $this->assertCount(2, $entries);
+        $this->assertSame('https://urlToNcAvatar.test', $entries[1]->getAvatar());
+    }
+
+    public function testGetContactsWithoutAvatarURI(): void {
+        /** @var IUser|MockObject $user */
+        $user = $this->createMock(IUser::class);
+        $this->contactsManager->expects($this->once())
+            ->method('search')
+            ->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
+            ->willReturn([
+                [
+                    'UID' => 123,
+                ],
+                [
+                    'UID' => 567,
+                    'FN' => 'Darren Roner',
+                    'EMAIL' => [
+                        'darren@roner.au'
+                    ],
+                    'PHOTO' => 'VALUE=uri:https://photo',
+                ],
+            ]);
+        $user->expects($this->exactly(2))
+            ->method('getUID')
+            ->willReturn('user123');
+
+        $entries = $this->contactsStore->getContacts($user, '');
+
+        $this->assertCount(2, $entries);
+        $this->assertEquals('https://photo', $entries[1]->getAvatar());
+    }
+
+    public static function dataGetContactsWhenUserIsInExcludeGroups(): array {
+        return [
+            ['yes', '[]', [], ['user123', 'user12345']],
+            ['yes', '["excludedGroup1"]', [], ['user123', 'user12345']],
+            ['yes', '["excludedGroup1"]', ['anotherGroup1'], ['user123', 'user12345']],
+            ['yes', '["excludedGroup1"]', ['anotherGroup1', 'anotherGroup2', 'anotherGroup3'], ['user123', 'user12345']],
+            ['yes', '["excludedGroup1"]', ['excludedGroup1'], []],
+            ['yes', '["excludedGroup1"]', ['anotherGroup1', 'excludedGroup1'], ['user123', 'user12345']],
+            ['yes', '["excludedGroup1"]', ['excludedGroup1', 'anotherGroup1', 'anotherGroup2', 'anotherGroup3'], ['user123', 'user12345']],
+            ['yes', '["excludedGroup1", "excludedGroup2", "excludedGroup3"]', [], ['user123', 'user12345']],
+            ['yes', '["excludedGroup1", "excludedGroup2", "excludedGroup3"]', ['anotherGroup1'], ['user123', 'user12345']],
+            ['yes', '["excludedGroup1", "excludedGroup2", "excludedGroup3"]', ['anotherGroup1', 'anotherGroup2', 'anotherGroup3'], ['user123', 'user12345']],
+            ['yes', '["excludedGroup1", "excludedGroup2", "excludedGroup3"]', ['excludedGroup1'], []],
+            ['yes', '["excludedGroup1", "excludedGroup2", "excludedGroup3"]', ['excludedGroup2'], []],
+            ['yes', '["excludedGroup1", "excludedGroup2", "excludedGroup3"]', ['excludedGroup3'], []],
+            ['yes', '["excludedGroup1", "excludedGroup2", "excludedGroup3"]', ['excludedGroup1', 'excludedGroup2', 'excludedGroup3'], []],
+            ['yes', '["excludedGroup1", "excludedGroup2", "excludedGroup3"]', ['anotherGroup1', 'excludedGroup1'], ['user123', 'user12345']],
+            ['yes', '["excludedGroup1", "excludedGroup2", "excludedGroup3"]', ['anotherGroup1', 'excludedGroup2', 'anotherGroup2', 'anotherGroup3'], ['user123', 'user12345']],
+            ['yes', '["excludedGroup1", "excludedGroup2", "excludedGroup3"]', ['excludedGroup3', 'anotherGroup1', 'anotherGroup2', 'anotherGroup3'], ['user123', 'user12345']],
+            ['allow', '[]', [], []],
+            ['allow', '["allowedGroup1"]', [], []],
+            ['allow', '["allowedGroup1"]', ['anotherGroup1'], []],
+            ['allow', '["allowedGroup1"]', ['anotherGroup1', 'anotherGroup2', 'anotherGroup3'], []],
+            ['allow', '["allowedGroup1"]', ['allowedGroup1'], ['user123', 'user12345']],
+            ['allow', '["allowedGroup1"]', ['anotherGroup1', 'allowedGroup1'], ['user123', 'user12345']],
+            ['allow', '["allowedGroup1"]', ['allowedGroup1', 'anotherGroup1', 'anotherGroup2', 'anotherGroup3'], ['user123', 'user12345']],
+            ['allow', '["allowedGroup1", "allowedGroup2", "allowedGroup3"]', [], []],
+            ['allow', '["allowedGroup1", "allowedGroup2", "allowedGroup3"]', ['anotherGroup1'], []],
+            ['allow', '["allowedGroup1", "allowedGroup2", "allowedGroup3"]', ['anotherGroup1', 'anotherGroup2', 'anotherGroup3'], []],
+            ['allow', '["allowedGroup1", "allowedGroup2", "allowedGroup3"]', ['allowedGroup1'], ['user123', 'user12345']],
+            ['allow', '["allowedGroup1", "allowedGroup2", "allowedGroup3"]', ['allowedGroup2'], ['user123', 'user12345']],
+            ['allow', '["allowedGroup1", "allowedGroup2", "allowedGroup3"]', ['allowedGroup3'], ['user123', 'user12345']],
+            ['allow', '["allowedGroup1", "allowedGroup2", "allowedGroup3"]', ['allowedGroup1', 'allowedGroup2', 'allowedGroup3'], ['user123', 'user12345']],
+            ['allow', '["allowedGroup1", "allowedGroup2", "allowedGroup3"]', ['anotherGroup1', 'allowedGroup1'], ['user123', 'user12345']],
+            ['allow', '["allowedGroup1", "allowedGroup2", "allowedGroup3"]', ['anotherGroup1', 'allowedGroup2', 'anotherGroup2', 'anotherGroup3'], ['user123', 'user12345']],
+            ['allow', '["allowedGroup1", "allowedGroup2", "allowedGroup3"]', ['allowedGroup3', 'anotherGroup1', 'anotherGroup2', 'anotherGroup3'], ['user123', 'user12345']],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataGetContactsWhenUserIsInExcludeGroups')]
+    public function testGetContactsWhenUserIsInExcludeGroups(string $excludeGroups, string $excludeGroupsList, array $currentUserGroupIds, array $expectedUids): void {
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', 'yes'],
+                ['core', 'shareapi_restrict_user_enumeration_to_group', 'no', 'no'],
+                ['core', 'shareapi_restrict_user_enumeration_to_phone', 'no', 'no'],
+                ['core', 'shareapi_exclude_groups', 'no', $excludeGroups],
+                ['core', 'shareapi_only_share_with_group_members', 'no', 'no'],
+                ['core', 'shareapi_exclude_groups_list', '', $excludeGroupsList],
+                ['core', 'shareapi_only_share_with_group_members_exclude_group_list', '', '[]'],
+            ]);
+
+        /** @var IUser|MockObject $currentUser */
+        $currentUser = $this->createMock(IUser::class);
+        $currentUser->expects($this->exactly(2))
+            ->method('getUID')
+            ->willReturn('user001');
+
+        $this->groupManager->expects($this->once())
+            ->method('getUserGroupIds')
+            ->with($this->equalTo($currentUser))
+            ->willReturn($currentUserGroupIds);
+
+        $this->contactsManager->expects($this->once())
+            ->method('search')
+            ->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
+            ->willReturn([
+                [
+                    'UID' => 'user123',
+                    'isLocalSystemBook' => true
+                ],
+                [
+                    'UID' => 'user12345',
+                    'isLocalSystemBook' => true
+                ],
+            ]);
+
+
+        $entries = $this->contactsStore->getContacts($currentUser, '');
+
+        $this->assertCount(count($expectedUids), $entries);
+        for ($i = 0; $i < count($expectedUids); $i++) {
+            $this->assertEquals($expectedUids[$i], $entries[$i]->getProperty('UID'));
+        }
+    }
+
+    public function testGetContactsOnlyShareIfInTheSameGroupWhenUserIsInExcludeGroups(): void {
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', 'yes'],
+                ['core', 'shareapi_restrict_user_enumeration_to_group', 'no', 'no'],
+                ['core', 'shareapi_restrict_user_enumeration_to_phone', 'no', 'no'],
+                ['core', 'shareapi_exclude_groups', 'no', 'yes'],
+                ['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
+                ['core', 'shareapi_exclude_groups_list', '', '["group1", "group5", "group6"]'],
+                ['core', 'shareapi_only_share_with_group_members_exclude_group_list', '', '[]'],
+            ]);
+
+        /** @var IUser|MockObject $currentUser */
+        $currentUser = $this->createMock(IUser::class);
+        $currentUser->expects($this->exactly(2))
+            ->method('getUID')
+            ->willReturn('user001');
+
+        $this->groupManager->expects($this->once())
+            ->method('getUserGroupIds')
+            ->with($this->equalTo($currentUser))
+            ->willReturn(['group1', 'group2', 'group3']);
+
+
+        $this->contactsManager->expects($this->once())
+            ->method('search')
+            ->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
+            ->willReturn([
+                [
+                    'UID' => 'user123',
+                    'isLocalSystemBook' => true
+                ],
+                [
+                    'UID' => 'user12345',
+                    'isLocalSystemBook' => true
+                ],
+            ]);
+
+
+        $entries = $this->contactsStore->getContacts($currentUser, '');
+
+        $this->assertCount(0, $entries);
+    }
+
+    public function testGetContactsOnlyShareIfInTheSameGroup(): void {
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', 'yes'],
+                ['core', 'shareapi_restrict_user_enumeration_to_group', 'no', 'no'],
+                ['core', 'shareapi_restrict_user_enumeration_to_phone', 'no', 'no'],
+                ['core', 'shareapi_exclude_groups', 'no', 'no'],
+                ['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
+                ['core', 'shareapi_only_share_with_group_members_exclude_group_list', '', '[]'],
+            ]);
+
+        /** @var IUser|MockObject $currentUser */
+        $currentUser = $this->createMock(IUser::class);
+        $currentUser->expects($this->exactly(2))
+            ->method('getUID')
+            ->willReturn('user001');
+
+        $user1 = $this->createMock(IUser::class);
+        $user2 = $this->createMock(IUser::class);
+        $user3 = $this->createMock(IUser::class);
+
+        $calls = [
+            [[$currentUser], ['group1', 'group2', 'group3']],
+            [[$user1], ['group1']],
+            [[$user2], ['group2', 'group3']],
+            [[$user3], ['group8', 'group9']],
+        ];
+        $this->groupManager->expects($this->exactly(4))
+            ->method('getUserGroupIds')
+            ->willReturnCallback(function () use (&$calls): array {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected[0], func_get_args());
+                return $expected[1];
+            });
+
+        $this->userManager->expects($this->exactly(3))
+            ->method('get')
+            ->willReturnMap([
+                ['user1', $user1],
+                ['user2', $user2],
+                ['user3', $user3],
+            ]);
+
+        $this->contactsManager->expects($this->once())
+            ->method('search')
+            ->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
+            ->willReturn([
+                [
+                    'UID' => 'user1',
+                    'isLocalSystemBook' => true
+                ],
+                [
+                    'UID' => 'user2',
+                    'isLocalSystemBook' => true
+                ],
+                [
+                    'UID' => 'user3',
+                    'isLocalSystemBook' => true
+                ],
+                [
+                    'UID' => 'contact',
+                ],
+            ]);
+
+        $entries = $this->contactsStore->getContacts($currentUser, '');
+
+        $this->assertCount(3, $entries);
+        $this->assertEquals('user1', $entries[0]->getProperty('UID'));
+        $this->assertEquals('user2', $entries[1]->getProperty('UID'));
+        $this->assertEquals('contact', $entries[2]->getProperty('UID'));
+    }
+
+    public function testGetContactsOnlyEnumerateIfInTheSameGroup(): void {
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', 'yes'],
+                ['core', 'shareapi_restrict_user_enumeration_to_group', 'no', 'yes'],
+                ['core', 'shareapi_restrict_user_enumeration_to_phone', 'no', 'no'],
+                ['core', 'shareapi_exclude_groups', 'no', 'no'],
+                ['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
+                ['core', 'shareapi_only_share_with_group_members_exclude_group_list', '', '[]'],
+            ]);
+
+        /** @var IUser|MockObject $currentUser */
+        $currentUser = $this->createMock(IUser::class);
+        $currentUser->expects($this->exactly(2))
+            ->method('getUID')
+            ->willReturn('user001');
+
+        $user1 = $this->createMock(IUser::class);
+        $user2 = $this->createMock(IUser::class);
+        $user3 = $this->createMock(IUser::class);
+
+        $calls = [
+            [[$currentUser], ['group1', 'group2', 'group3']],
+            [[$user1], ['group1']],
+            [[$user2], ['group2', 'group3']],
+            [[$user3], ['group8', 'group9']],
+        ];
+        $this->groupManager->expects($this->exactly(4))
+            ->method('getUserGroupIds')
+            ->willReturnCallback(function () use (&$calls): array {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected[0], func_get_args());
+                return $expected[1];
+            });
+
+        $this->userManager->expects($this->exactly(3))
+            ->method('get')
+            ->willReturnMap([
+                ['user1', $user1],
+                ['user2', $user2],
+                ['user3', $user3],
+            ]);
+
+        $this->contactsManager->expects($this->once())
+            ->method('search')
+            ->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
+            ->willReturn([
+                [
+                    'UID' => 'user1',
+                    'isLocalSystemBook' => true
+                ],
+                [
+                    'UID' => 'user2',
+                    'isLocalSystemBook' => true
+                ],
+                [
+                    'UID' => 'user3',
+                    'isLocalSystemBook' => true
+                ],
+                [
+                    'UID' => 'contact',
+                ],
+            ]);
+
+        $entries = $this->contactsStore->getContacts($currentUser, '');
+
+        $this->assertCount(3, $entries);
+        $this->assertEquals('user1', $entries[0]->getProperty('UID'));
+        $this->assertEquals('user2', $entries[1]->getProperty('UID'));
+        $this->assertEquals('contact', $entries[2]->getProperty('UID'));
+    }
+
+    public function testGetContactsOnlyEnumerateIfPhoneBookMatch(): void {
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', 'yes'],
+                ['core', 'shareapi_restrict_user_enumeration_to_group', 'no', 'no'],
+                ['core', 'shareapi_restrict_user_enumeration_to_phone', 'no', 'yes'],
+                ['core', 'shareapi_exclude_groups', 'no', 'no'],
+                ['core', 'shareapi_only_share_with_group_members', 'no', 'no'],
+            ]);
+
+        /** @var IUser|MockObject $currentUser */
+        $currentUser = $this->createMock(IUser::class);
+        $currentUser->expects($this->exactly(2))
+            ->method('getUID')
+            ->willReturn('user001');
+
+        $this->groupManager->expects($this->once())
+            ->method('getUserGroupIds')
+            ->with($this->equalTo($currentUser))
+            ->willReturn(['group1', 'group2', 'group3']);
+
+        $this->knownUserService->method('isKnownToUser')
+            ->willReturnMap([
+                ['user001', 'user1', true],
+                ['user001', 'user2', true],
+                ['user001', 'user3', false],
+            ]);
+
+        $this->contactsManager->expects($this->once())
+            ->method('search')
+            ->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
+            ->willReturn([
+                [
+                    'UID' => 'user1',
+                    'isLocalSystemBook' => true
+                ],
+                [
+                    'UID' => 'user2',
+                    'isLocalSystemBook' => true
+                ],
+                [
+                    'UID' => 'user3',
+                    'isLocalSystemBook' => true
+                ],
+                [
+                    'UID' => 'contact',
+                ],
+            ]);
+
+        $entries = $this->contactsStore->getContacts($currentUser, '');
+
+        $this->assertCount(3, $entries);
+        $this->assertEquals('user1', $entries[0]->getProperty('UID'));
+        $this->assertEquals('user2', $entries[1]->getProperty('UID'));
+        $this->assertEquals('contact', $entries[2]->getProperty('UID'));
+    }
+
+    public function testGetContactsOnlyEnumerateIfPhoneBookMatchWithOwnGroupsOnly(): void {
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', 'yes'],
+                ['core', 'shareapi_restrict_user_enumeration_to_group', 'no', 'no'],
+                ['core', 'shareapi_restrict_user_enumeration_to_phone', 'no', 'yes'],
+                ['core', 'shareapi_exclude_groups', 'no', 'no'],
+                ['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
+                ['core', 'shareapi_only_share_with_group_members_exclude_group_list', '', '[]'],
+            ]);
+
+        /** @var IUser|MockObject $currentUser */
+        $currentUser = $this->createMock(IUser::class);
+        $currentUser->expects($this->exactly(2))
+            ->method('getUID')
+            ->willReturn('user001');
+
+        $user1 = $this->createMock(IUser::class);
+        $user2 = $this->createMock(IUser::class);
+        $user3 = $this->createMock(IUser::class);
+
+        $calls = [
+            [[$currentUser], ['group1', 'group2', 'group3']],
+            [[$user1], ['group1']],
+            [[$user2], ['group2', 'group3']],
+            [[$user3], ['group8', 'group9']],
+        ];
+        $this->groupManager->expects($this->exactly(4))
+            ->method('getUserGroupIds')
+            ->willReturnCallback(function () use (&$calls): array {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected[0], func_get_args());
+                return $expected[1];
+            });
+
+        $this->userManager->expects($this->exactly(3))
+            ->method('get')
+            ->willReturnMap([
+                ['user1', $user1],
+                ['user2', $user2],
+                ['user3', $user3],
+            ]);
+
+        $this->knownUserService->method('isKnownToUser')
+            ->willReturnMap([
+                ['user001', 'user1', true],
+                ['user001', 'user2', true],
+                ['user001', 'user3', true],
+            ]);
+
+        $this->contactsManager->expects($this->once())
+            ->method('search')
+            ->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
+            ->willReturn([
+                [
+                    'UID' => 'user1',
+                    'isLocalSystemBook' => true
+                ],
+                [
+                    'UID' => 'user2',
+                    'isLocalSystemBook' => true
+                ],
+                [
+                    'UID' => 'user3',
+                    'isLocalSystemBook' => true
+                ],
+                [
+                    'UID' => 'contact',
+                ],
+            ]);
+
+        $entries = $this->contactsStore->getContacts($currentUser, '');
+
+        $this->assertCount(3, $entries);
+        $this->assertEquals('user1', $entries[0]->getProperty('UID'));
+        $this->assertEquals('user2', $entries[1]->getProperty('UID'));
+        $this->assertEquals('contact', $entries[2]->getProperty('UID'));
+    }
+
+    public function testGetContactsOnlyEnumerateIfPhoneBookOrSameGroup(): void {
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', 'yes'],
+                ['core', 'shareapi_restrict_user_enumeration_to_group', 'no', 'yes'],
+                ['core', 'shareapi_restrict_user_enumeration_to_phone', 'no', 'yes'],
+                ['core', 'shareapi_exclude_groups', 'no', 'no'],
+                ['core', 'shareapi_only_share_with_group_members', 'no', 'no'],
+            ]);
+
+        /** @var IUser|MockObject $currentUser */
+        $currentUser = $this->createMock(IUser::class);
+        $currentUser->expects($this->exactly(2))
+            ->method('getUID')
+            ->willReturn('user001');
+
+        $user1 = $this->createMock(IUser::class);
+
+        $calls = [
+            [[$currentUser], ['group1', 'group2', 'group3']],
+            [[$user1], ['group1']],
+        ];
+        $this->groupManager->expects($this->exactly(2))
+            ->method('getUserGroupIds')
+            ->willReturnCallback(function () use (&$calls): array {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected[0], func_get_args());
+                return $expected[1];
+            });
+
+        $this->userManager->expects($this->once())
+            ->method('get')
+            ->with('user1')
+            ->willReturn($user1);
+
+        $this->knownUserService->method('isKnownToUser')
+            ->willReturnMap([
+                ['user001', 'user1', false],
+                ['user001', 'user2', true],
+                ['user001', 'user3', true],
+            ]);
+
+        $this->contactsManager->expects($this->once())
+            ->method('search')
+            ->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
+            ->willReturn([
+                [
+                    'UID' => 'user1',
+                    'isLocalSystemBook' => true
+                ],
+                [
+                    'UID' => 'user2',
+                    'isLocalSystemBook' => true
+                ],
+                [
+                    'UID' => 'user3',
+                    'isLocalSystemBook' => true
+                ],
+                [
+                    'UID' => 'contact',
+                ],
+            ]);
+
+        $entries = $this->contactsStore->getContacts($currentUser, '');
+
+        $this->assertCount(4, $entries);
+        $this->assertEquals('user1', $entries[0]->getProperty('UID'));
+        $this->assertEquals('user2', $entries[1]->getProperty('UID'));
+        $this->assertEquals('user3', $entries[2]->getProperty('UID'));
+        $this->assertEquals('contact', $entries[3]->getProperty('UID'));
+    }
+
+    public function testGetContactsOnlyEnumerateIfPhoneBookOrSameGroupInOwnGroupsOnly(): void {
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', 'yes'],
+                ['core', 'shareapi_restrict_user_enumeration_to_group', 'no', 'yes'],
+                ['core', 'shareapi_restrict_user_enumeration_to_phone', 'no', 'yes'],
+                ['core', 'shareapi_exclude_groups', 'no', 'no'],
+                ['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
+                ['core', 'shareapi_only_share_with_group_members_exclude_group_list', '', '[]'],
+            ]);
+
+        /** @var IUser|MockObject $currentUser */
+        $currentUser = $this->createMock(IUser::class);
+        $currentUser->expects($this->exactly(2))
+            ->method('getUID')
+            ->willReturn('user001');
+
+        $user1 = $this->createMock(IUser::class);
+        $user2 = $this->createMock(IUser::class);
+        $user3 = $this->createMock(IUser::class);
+
+        $calls = [
+            [[$currentUser], ['group1', 'group2', 'group3']],
+            [[$user1], ['group1']],
+            [[$user2], ['group2', 'group3']],
+            [[$user3], ['group8', 'group9']],
+        ];
+        $this->groupManager->expects($this->exactly(4))
+            ->method('getUserGroupIds')
+            ->willReturnCallback(function () use (&$calls): array {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected[0], func_get_args());
+                return $expected[1];
+            });
+
+        $this->userManager->expects($this->exactly(3))
+            ->method('get')
+            ->willReturnMap([
+                ['user1', $user1],
+                ['user2', $user2],
+                ['user3', $user3],
+            ]);
+
+        $this->knownUserService->method('isKnownToUser')
+            ->willReturnMap([
+                ['user001', 'user1', false],
+                ['user001', 'user2', true],
+                ['user001', 'user3', true],
+            ]);
+
+        $this->contactsManager->expects($this->once())
+            ->method('search')
+            ->with($this->equalTo(''), $this->equalTo(['FN', 'EMAIL']))
+            ->willReturn([
+                [
+                    'UID' => 'user1',
+                    'isLocalSystemBook' => true
+                ],
+                [
+                    'UID' => 'user2',
+                    'isLocalSystemBook' => true
+                ],
+                [
+                    'UID' => 'user3',
+                    'isLocalSystemBook' => true
+                ],
+                [
+                    'UID' => 'contact',
+                ],
+            ]);
+
+        $entries = $this->contactsStore->getContacts($currentUser, '');
+
+        $this->assertCount(3, $entries);
+        $this->assertEquals('user1', $entries[0]->getProperty('UID'));
+        $this->assertEquals('user2', $entries[1]->getProperty('UID'));
+        $this->assertEquals('contact', $entries[2]->getProperty('UID'));
+    }
+
+    public function testGetContactsWithFilter(): void {
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', 'no'],
+                ['core', 'shareapi_restrict_user_enumeration_full_match', 'yes', 'yes'],
+            ]);
+
+        /** @var IUser|MockObject $user */
+        $user = $this->createMock(IUser::class);
+        $this->contactsManager->expects($this->any())
+            ->method('search')
+            ->willReturn([
+                [
+                    'UID' => 'a567',
+                    'FN' => 'Darren Roner',
+                    'EMAIL' => [
+                        'darren@roner.au',
+                    ],
+                    'isLocalSystemBook' => true,
+                ],
+                [
+                    'UID' => 'john',
+                    'FN' => 'John Doe',
+                    'EMAIL' => [
+                        'john@example.com',
+                    ],
+                    'isLocalSystemBook' => true,
+                ],
+                [
+                    'FN' => 'Anne D',
+                    'EMAIL' => [
+                        'anne@example.com',
+                    ],
+                    'isLocalSystemBook' => false,
+                ],
+            ]);
+        $user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('user123');
+
+        // Complete match on UID should match
+        $entry = $this->contactsStore->getContacts($user, 'a567');
+        $this->assertSame(2, count($entry));
+        $this->assertEquals([
+            'darren@roner.au'
+        ], $entry[0]->getEMailAddresses());
+
+        // Partial match on UID should not match
+        $entry = $this->contactsStore->getContacts($user, 'a56');
+        $this->assertSame(1, count($entry));
+        $this->assertEquals([
+            'anne@example.com'
+        ], $entry[0]->getEMailAddresses());
+
+        // Complete match on email should match
+        $entry = $this->contactsStore->getContacts($user, 'john@example.com');
+        $this->assertSame(2, count($entry));
+        $this->assertEquals([
+            'john@example.com'
+        ], $entry[0]->getEMailAddresses());
+        $this->assertEquals([
+            'anne@example.com'
+        ], $entry[1]->getEMailAddresses());
+
+        // Partial match on email should not match
+        $entry = $this->contactsStore->getContacts($user, 'john@example.co');
+        $this->assertSame(1, count($entry));
+        $this->assertEquals([
+            'anne@example.com'
+        ], $entry[0]->getEMailAddresses());
+
+        // Match on FN should not match
+        $entry = $this->contactsStore->getContacts($user, 'Darren Roner');
+        $this->assertSame(1, count($entry));
+        $this->assertEquals([
+            'anne@example.com'
+        ], $entry[0]->getEMailAddresses());
+
+        // Don't filter users in local addressbook
+        $entry = $this->contactsStore->getContacts($user, 'Anne D');
+        $this->assertSame(1, count($entry));
+        $this->assertEquals([
+            'anne@example.com'
+        ], $entry[0]->getEMailAddresses());
+    }
+
+    public function testGetContactsWithFilterWithoutFullMatch(): void {
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', 'no'],
+                ['core', 'shareapi_restrict_user_enumeration_full_match', 'yes', 'no'],
+            ]);
+
+        /** @var IUser|MockObject $user */
+        $user = $this->createMock(IUser::class);
+        $this->contactsManager->expects($this->any())
+            ->method('search')
+            ->willReturn([
+                [
+                    'UID' => 'a567',
+                    'FN' => 'Darren Roner',
+                    'EMAIL' => [
+                        'darren@roner.au',
+                    ],
+                    'isLocalSystemBook' => true,
+                ],
+                [
+                    'UID' => 'john',
+                    'FN' => 'John Doe',
+                    'EMAIL' => [
+                        'john@example.com',
+                    ],
+                    'isLocalSystemBook' => true,
+                ],
+                [
+                    'FN' => 'Anne D',
+                    'EMAIL' => [
+                        'anne@example.com',
+                    ],
+                    'isLocalSystemBook' => false,
+                ],
+            ]);
+        $user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('user123');
+
+        // Complete match on UID should not match
+        $entry = $this->contactsStore->getContacts($user, 'a567');
+        $this->assertSame(1, count($entry));
+        $this->assertEquals([
+            'anne@example.com'
+        ], $entry[0]->getEMailAddresses());
+
+        // Partial match on UID should not match
+        $entry = $this->contactsStore->getContacts($user, 'a56');
+        $this->assertSame(1, count($entry));
+        $this->assertEquals([
+            'anne@example.com'
+        ], $entry[0]->getEMailAddresses());
+
+        // Complete match on email should not match
+        $entry = $this->contactsStore->getContacts($user, 'john@example.com');
+        $this->assertSame(1, count($entry));
+        $this->assertEquals([
+            'anne@example.com'
+        ], $entry[0]->getEMailAddresses());
+
+        // Partial match on email should not match
+        $entry = $this->contactsStore->getContacts($user, 'john@example.co');
+        $this->assertSame(1, count($entry));
+        $this->assertEquals([
+            'anne@example.com'
+        ], $entry[0]->getEMailAddresses());
+
+        // Match on FN should not match
+        $entry = $this->contactsStore->getContacts($user, 'Darren Roner');
+        $this->assertSame(1, count($entry));
+        $this->assertEquals([
+            'anne@example.com'
+        ], $entry[0]->getEMailAddresses());
+
+        // Don't filter users in local addressbook
+        $entry = $this->contactsStore->getContacts($user, 'Anne D');
+        $this->assertSame(1, count($entry));
+        $this->assertEquals([
+            'anne@example.com'
+        ], $entry[0]->getEMailAddresses());
+    }
+
+    public function testFindOneUser(): void {
+        $this->config
+            ->method('getAppValue')
+            ->willReturnMap([
+                ['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', 'yes'],
+                ['core', 'shareapi_restrict_user_enumeration_to_group', 'no', 'no'],
+                ['core', 'shareapi_restrict_user_enumeration_to_phone', 'no', 'no'],
+                ['core', 'shareapi_restrict_user_enumeration_full_match', 'yes', 'yes'],
+                ['core', 'shareapi_exclude_groups', 'no', 'yes'],
+                ['core', 'shareapi_exclude_groups_list', '', ''],
+                ['core', 'shareapi_only_share_with_group_members', 'no', 'no'],
+            ]);
+
+        /** @var IUser|MockObject $user */
+        $user = $this->createMock(IUser::class);
+        $this->contactsManager->expects($this->once())
+            ->method('search')
+            ->with($this->equalTo('a567'), $this->equalTo(['UID']))
+            ->willReturn([
+                [
+                    'UID' => 123,
+                    'isLocalSystemBook' => false
+                ],
+                [
+                    'UID' => 'a567',
+                    'FN' => 'Darren Roner',
+                    'EMAIL' => [
+                        'darren@roner.au'
+                    ],
+                    'isLocalSystemBook' => true
+                ],
+            ]);
+        $user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('user123');
+
+        $entry = $this->contactsStore->findOne($user, 0, 'a567');
+
+        $this->assertEquals([
+            'darren@roner.au'
+        ], $entry->getEMailAddresses());
+    }
+
+    public function testFindOneEMail(): void {
+        /** @var IUser|MockObject $user */
+        $user = $this->createMock(IUser::class);
+        $this->contactsManager->expects($this->once())
+            ->method('search')
+            ->with($this->equalTo('darren@roner.au'), $this->equalTo(['EMAIL']))
+            ->willReturn([
+                [
+                    'UID' => 123,
+                    'isLocalSystemBook' => false
+                ],
+                [
+                    'UID' => 'a567',
+                    'FN' => 'Darren Roner',
+                    'EMAIL' => [
+                        'darren@roner.au'
+                    ],
+                    'isLocalSystemBook' => false
+                ],
+            ]);
+        $user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('user123');
+
+        $entry = $this->contactsStore->findOne($user, 4, 'darren@roner.au');
+
+        $this->assertEquals([
+            'darren@roner.au'
+        ], $entry->getEMailAddresses());
+    }
+
+    public function testFindOneNotSupportedType(): void {
+        /** @var IUser|MockObject $user */
+        $user = $this->createMock(IUser::class);
+
+        $entry = $this->contactsStore->findOne($user, 42, 'darren@roner.au');
+
+        $this->assertEquals(null, $entry);
+    }
+
+    public function testFindOneNoMatches(): void {
+        /** @var IUser|MockObject $user */
+        $user = $this->createMock(IUser::class);
+        $this->contactsManager->expects($this->once())
+            ->method('search')
+            ->with($this->equalTo('a567'), $this->equalTo(['UID']))
+            ->willReturn([
+                [
+                    'UID' => 123,
+                    'isLocalSystemBook' => false
+                ],
+                [
+                    'UID' => 'a567',
+                    'FN' => 'Darren Roner',
+                    'EMAIL' => [
+                        'darren@roner.au123'
+                    ],
+                    'isLocalSystemBook' => false
+                ],
+            ]);
+        $user->expects($this->never())
+            ->method('getUID');
+
+        $entry = $this->contactsStore->findOne($user, 0, 'a567');
+
+        $this->assertEquals(null, $entry);
+    }
+
+    public function testGetRecentStatusFirst(): void {
+        $user = $this->createMock(IUser::class);
+        $status1 = new UserStatus();
+        $status1->setUserId('user1');
+        $status2 = new UserStatus();
+        $status2->setUserId('user2');
+        $this->statusService->expects(self::once())
+            ->method('findAllRecentStatusChanges')
+            ->willReturn([
+                $status1,
+                $status2,
+            ]);
+        $user1 = $this->createMock(IUser::class);
+        $user1->method('getCloudId')->willReturn('user1@localcloud');
+        $user2 = $this->createMock(IUser::class);
+        $user2->method('getCloudId')->willReturn('user2@localcloud');
+        $this->userManager->expects(self::exactly(2))
+            ->method('get')
+            ->willReturnCallback(function ($uid) use ($user1, $user2) {
+                return match ($uid) {
+                    'user1' => $user1,
+                    'user2' => $user2,
+                };
+            });
+        $this->contactsManager
+            ->expects(self::exactly(3))
+            ->method('search')
+            ->willReturnCallback(function ($uid, $searchProps, $options) {
+                return match ([$uid, $options['limit'] ?? null]) {
+                    ['user1@localcloud', 1] => [
+                        [
+                            'UID' => 'user1',
+                            'URI' => 'user1.vcf',
+                        ],
+                    ],
+                    ['user2@localcloud' => [], 1], // Simulate not found
+                    ['', 4] => [
+                        [
+                            'UID' => 'contact1',
+                            'URI' => 'contact1.vcf',
+                        ],
+                        [
+                            'UID' => 'contact2',
+                            'URI' => 'contact2.vcf',
+                        ],
+                    ],
+                    default => [],
+                };
+            });
+
+        $contacts = $this->contactsStore->getContacts(
+            $user,
+            null,
+            5,
+        );
+
+        self::assertCount(3, $contacts);
+        self::assertEquals('user1', $contacts[0]->getProperty('UID'));
+        self::assertEquals('contact1', $contacts[1]->getProperty('UID'));
+        self::assertEquals('contact2', $contacts[2]->getProperty('UID'));
+    }
+
+    public function testPaginateRecentStatus(): void {
+        $user = $this->createMock(IUser::class);
+        $status1 = new UserStatus();
+        $status1->setUserId('user1');
+        $status2 = new UserStatus();
+        $status2->setUserId('user2');
+        $status3 = new UserStatus();
+        $status3->setUserId('user3');
+        $this->statusService->expects(self::never())
+            ->method('findAllRecentStatusChanges');
+        $this->contactsManager
+            ->expects(self::exactly(2))
+            ->method('search')
+            ->willReturnCallback(function ($uid, $searchProps, $options) {
+                return match ([$uid, $options['limit'] ?? null, $options['offset'] ?? null]) {
+                    ['', 2, 0] => [
+                        [
+                            'UID' => 'contact1',
+                            'URI' => 'contact1.vcf',
+                        ],
+                        [
+                            'UID' => 'contact2',
+                            'URI' => 'contact2.vcf',
+                        ],
+                    ],
+                    ['', 2, 3] => [
+                        [
+                            'UID' => 'contact3',
+                            'URI' => 'contact3.vcf',
+                        ],
+                    ],
+                    default => [],
+                };
+            });
+
+        $page1 = $this->contactsStore->getContacts(
+            $user,
+            null,
+            2,
+            0,
+        );
+        $page2 = $this->contactsStore->getContacts(
+            $user,
+            null,
+            2,
+            3,
+        );
+
+        self::assertCount(2, $page1);
+        self::assertCount(1, $page2);
+    }
 }