nextcloud /
server
@@ -34,110 +34,110 @@ |
||
| 34 | 34 | use OCP\ILogger; |
| 35 | 35 | |
| 36 | 36 | class AppFetcher extends Fetcher { |
| 37 | - /** |
|
| 38 | - * @param Factory $appDataFactory |
|
| 39 | - * @param IClientService $clientService |
|
| 40 | - * @param ITimeFactory $timeFactory |
|
| 41 | - * @param IConfig $config |
|
| 42 | - * @param ILogger $logger |
|
| 43 | - */ |
|
| 44 | - public function __construct(Factory $appDataFactory, |
|
| 45 | - IClientService $clientService, |
|
| 46 | - ITimeFactory $timeFactory, |
|
| 47 | - IConfig $config, |
|
| 48 | - ILogger $logger) { |
|
| 49 | - parent::__construct( |
|
| 50 | - $appDataFactory, |
|
| 51 | - $clientService, |
|
| 52 | - $timeFactory, |
|
| 53 | - $config, |
|
| 54 | - $logger |
|
| 55 | - ); |
|
| 37 | + /** |
|
| 38 | + * @param Factory $appDataFactory |
|
| 39 | + * @param IClientService $clientService |
|
| 40 | + * @param ITimeFactory $timeFactory |
|
| 41 | + * @param IConfig $config |
|
| 42 | + * @param ILogger $logger |
|
| 43 | + */ |
|
| 44 | + public function __construct(Factory $appDataFactory, |
|
| 45 | + IClientService $clientService, |
|
| 46 | + ITimeFactory $timeFactory, |
|
| 47 | + IConfig $config, |
|
| 48 | + ILogger $logger) { |
|
| 49 | + parent::__construct( |
|
| 50 | + $appDataFactory, |
|
| 51 | + $clientService, |
|
| 52 | + $timeFactory, |
|
| 53 | + $config, |
|
| 54 | + $logger |
|
| 55 | + ); |
|
| 56 | 56 | |
| 57 | - $this->fileName = 'apps.json'; |
|
| 58 | - $this->setEndpoint(); |
|
| 59 | - } |
|
| 57 | + $this->fileName = 'apps.json'; |
|
| 58 | + $this->setEndpoint(); |
|
| 59 | + } |
|
| 60 | 60 | |
| 61 | - /** |
|
| 62 | - * Only returns the latest compatible app release in the releases array |
|
| 63 | - * |
|
| 64 | - * @param string $ETag |
|
| 65 | - * @param string $content |
|
| 66 | - * |
|
| 67 | - * @return array |
|
| 68 | - */ |
|
| 69 | - protected function fetch($ETag, $content) { |
|
| 70 | - /** @var mixed[] $response */ |
|
| 71 | - $response = parent::fetch($ETag, $content); |
|
| 61 | + /** |
|
| 62 | + * Only returns the latest compatible app release in the releases array |
|
| 63 | + * |
|
| 64 | + * @param string $ETag |
|
| 65 | + * @param string $content |
|
| 66 | + * |
|
| 67 | + * @return array |
|
| 68 | + */ |
|
| 69 | + protected function fetch($ETag, $content) { |
|
| 70 | + /** @var mixed[] $response */ |
|
| 71 | + $response = parent::fetch($ETag, $content); |
|
| 72 | 72 | |
| 73 | - $ncVersion = $this->getVersion(); |
|
| 74 | - $ncMajorVersion = explode('.', $ncVersion)[0]; |
|
| 75 | - foreach($response['data'] as $dataKey => $app) { |
|
| 76 | - $releases = []; |
|
| 73 | + $ncVersion = $this->getVersion(); |
|
| 74 | + $ncMajorVersion = explode('.', $ncVersion)[0]; |
|
| 75 | + foreach($response['data'] as $dataKey => $app) { |
|
| 76 | + $releases = []; |
|
| 77 | 77 | |
| 78 | - // Filter all compatible releases |
|
| 79 | - foreach($app['releases'] as $release) { |
|
| 80 | - // Exclude all nightly and pre-releases |
|
| 81 | - if($release['isNightly'] === false |
|
| 82 | - && strpos($release['version'], '-') === false) { |
|
| 83 | - // Exclude all versions not compatible with the current version |
|
| 84 | - $versionParser = new VersionParser(); |
|
| 85 | - $version = $versionParser->getVersion($release['rawPlatformVersionSpec']); |
|
| 86 | - if ( |
|
| 87 | - // Major version is bigger or equals to the minimum version of the app |
|
| 88 | - version_compare($ncMajorVersion, $version->getMinimumVersion(), '>=') |
|
| 89 | - // Major version is smaller or equals to the maximum version of the app |
|
| 90 | - && version_compare($ncMajorVersion, $version->getMaximumVersion(), '<=') |
|
| 91 | - ) { |
|
| 92 | - $releases[] = $release; |
|
| 93 | - } |
|
| 94 | - } |
|
| 95 | - } |
|
| 78 | + // Filter all compatible releases |
|
| 79 | + foreach($app['releases'] as $release) { |
|
| 80 | + // Exclude all nightly and pre-releases |
|
| 81 | + if($release['isNightly'] === false |
|
| 82 | + && strpos($release['version'], '-') === false) { |
|
| 83 | + // Exclude all versions not compatible with the current version |
|
| 84 | + $versionParser = new VersionParser(); |
|
| 85 | + $version = $versionParser->getVersion($release['rawPlatformVersionSpec']); |
|
| 86 | + if ( |
|
| 87 | + // Major version is bigger or equals to the minimum version of the app |
|
| 88 | + version_compare($ncMajorVersion, $version->getMinimumVersion(), '>=') |
|
| 89 | + // Major version is smaller or equals to the maximum version of the app |
|
| 90 | + && version_compare($ncMajorVersion, $version->getMaximumVersion(), '<=') |
|
| 91 | + ) { |
|
| 92 | + $releases[] = $release; |
|
| 93 | + } |
|
| 94 | + } |
|
| 95 | + } |
|
| 96 | 96 | |
| 97 | - // Get the highest version |
|
| 98 | - $versions = []; |
|
| 99 | - foreach($releases as $release) { |
|
| 100 | - $versions[] = $release['version']; |
|
| 101 | - } |
|
| 102 | - usort($versions, 'version_compare'); |
|
| 103 | - $versions = array_reverse($versions); |
|
| 104 | - $compatible = false; |
|
| 105 | - if(isset($versions[0])) { |
|
| 106 | - $highestVersion = $versions[0]; |
|
| 107 | - foreach ($releases as $release) { |
|
| 108 | - if ((string)$release['version'] === (string)$highestVersion) { |
|
| 109 | - $compatible = true; |
|
| 110 | - $response['data'][$dataKey]['releases'] = [$release]; |
|
| 111 | - break; |
|
| 112 | - } |
|
| 113 | - } |
|
| 114 | - } |
|
| 115 | - if(!$compatible) { |
|
| 116 | - unset($response['data'][$dataKey]); |
|
| 117 | - } |
|
| 118 | - } |
|
| 97 | + // Get the highest version |
|
| 98 | + $versions = []; |
|
| 99 | + foreach($releases as $release) { |
|
| 100 | + $versions[] = $release['version']; |
|
| 101 | + } |
|
| 102 | + usort($versions, 'version_compare'); |
|
| 103 | + $versions = array_reverse($versions); |
|
| 104 | + $compatible = false; |
|
| 105 | + if(isset($versions[0])) { |
|
| 106 | + $highestVersion = $versions[0]; |
|
| 107 | + foreach ($releases as $release) { |
|
| 108 | + if ((string)$release['version'] === (string)$highestVersion) { |
|
| 109 | + $compatible = true; |
|
| 110 | + $response['data'][$dataKey]['releases'] = [$release]; |
|
| 111 | + break; |
|
| 112 | + } |
|
| 113 | + } |
|
| 114 | + } |
|
| 115 | + if(!$compatible) { |
|
| 116 | + unset($response['data'][$dataKey]); |
|
| 117 | + } |
|
| 118 | + } |
|
| 119 | 119 | |
| 120 | - $response['data'] = array_values($response['data']); |
|
| 121 | - return $response; |
|
| 122 | - } |
|
| 120 | + $response['data'] = array_values($response['data']); |
|
| 121 | + return $response; |
|
| 122 | + } |
|
| 123 | 123 | |
| 124 | - private function setEndpoint() { |
|
| 125 | - $versionArray = explode('.', $this->getVersion()); |
|
| 126 | - $this->endpointUrl = sprintf( |
|
| 127 | - 'https://apps.nextcloud.com/api/v1/platform/%d.%d.%d/apps.json', |
|
| 128 | - $versionArray[0], |
|
| 129 | - $versionArray[1], |
|
| 130 | - $versionArray[2] |
|
| 131 | - ); |
|
| 132 | - } |
|
| 124 | + private function setEndpoint() { |
|
| 125 | + $versionArray = explode('.', $this->getVersion()); |
|
| 126 | + $this->endpointUrl = sprintf( |
|
| 127 | + 'https://apps.nextcloud.com/api/v1/platform/%d.%d.%d/apps.json', |
|
| 128 | + $versionArray[0], |
|
| 129 | + $versionArray[1], |
|
| 130 | + $versionArray[2] |
|
| 131 | + ); |
|
| 132 | + } |
|
| 133 | 133 | |
| 134 | - /** |
|
| 135 | - * @param string $version |
|
| 136 | - * @param string $fileName |
|
| 137 | - */ |
|
| 138 | - public function setVersion(string $version, string $fileName = 'apps.json') { |
|
| 139 | - parent::setVersion($version); |
|
| 140 | - $this->fileName = $fileName; |
|
| 141 | - $this->setEndpoint(); |
|
| 142 | - } |
|
| 134 | + /** |
|
| 135 | + * @param string $version |
|
| 136 | + * @param string $fileName |
|
| 137 | + */ |
|
| 138 | + public function setVersion(string $version, string $fileName = 'apps.json') { |
|
| 139 | + parent::setVersion($version); |
|
| 140 | + $this->fileName = $fileName; |
|
| 141 | + $this->setEndpoint(); |
|
| 142 | + } |
|
| 143 | 143 | } |
