Passed
Push — master ( c9949d...1d5058 )
by Roeland
12:46 queued 02:05
created
core/templates/installation.php 2 patches
Spacing   +48 added lines, -48 removed lines patch added patch discarded remove patch
@@ -9,12 +9,12 @@  discard block
 block discarded – undo
9 9
 <input type='hidden' id='hasOracle' value='<?php p($_['hasOracle']) ?>'>
10 10
 <form action="index.php" method="post">
11 11
 <input type="hidden" name="install" value="true">
12
-	<?php if(count($_['errors']) > 0): ?>
12
+	<?php if (count($_['errors']) > 0): ?>
13 13
 	<fieldset class="warning">
14
-		<legend><strong><?php p($l->t('Error'));?></strong></legend>
15
-		<?php foreach($_['errors'] as $err): ?>
14
+		<legend><strong><?php p($l->t('Error')); ?></strong></legend>
15
+		<?php foreach ($_['errors'] as $err): ?>
16 16
 		<p>
17
-			<?php if(is_array($err)):?>
17
+			<?php if (is_array($err)):?>
18 18
 				<?php p($err['error']); ?>
19 19
 				<span class='hint'><?php p($err['hint']); ?></span>
20 20
 			<?php else: ?>
@@ -24,10 +24,10 @@  discard block
 block discarded – undo
24 24
 		<?php endforeach; ?>
25 25
 	</fieldset>
26 26
 	<?php endif; ?>
27
-	<?php if(!$_['htaccessWorking']): ?>
27
+	<?php if (!$_['htaccessWorking']): ?>
28 28
 	<fieldset class="warning">
29
-		<legend><strong><?php p($l->t('Security warning'));?></strong></legend>
30
-		<p><?php p($l->t('Your data directory and files are probably accessible from the internet because the .htaccess file does not work.'));?><br>
29
+		<legend><strong><?php p($l->t('Security warning')); ?></strong></legend>
30
+		<p><?php p($l->t('Your data directory and files are probably accessible from the internet because the .htaccess file does not work.')); ?><br>
31 31
 		<?php print_unescaped($l->t(
32 32
 			'For information how to properly configure your server, please see the <a href="%s" target="_blank" rel="noreferrer noopener">documentation</a>.',
33 33
 			[link_to_docs('admin-install')]
@@ -35,35 +35,35 @@  discard block
 block discarded – undo
35 35
 	</fieldset>
36 36
 	<?php endif; ?>
37 37
 	<fieldset id="adminaccount">
38
-		<legend><?php print_unescaped($l->t( 'Create an <strong>admin account</strong>' )); ?></legend>
38
+		<legend><?php print_unescaped($l->t('Create an <strong>admin account</strong>')); ?></legend>
39 39
 		<p class="grouptop">
40 40
 			<input type="text" name="adminlogin" id="adminlogin"
41
-				placeholder="<?php p($l->t( 'Username' )); ?>"
41
+				placeholder="<?php p($l->t('Username')); ?>"
42 42
 				value="<?php p($_['adminlogin']); ?>"
43 43
 				autocomplete="off" autocapitalize="none" autocorrect="off" autofocus required>
44
-			<label for="adminlogin" class="infield"><?php p($l->t( 'Username' )); ?></label>
44
+			<label for="adminlogin" class="infield"><?php p($l->t('Username')); ?></label>
45 45
 		</p>
46 46
 		<p class="groupbottom">
47 47
 			<input type="password" name="adminpass" data-typetoggle="#show" id="adminpass"
48
-				placeholder="<?php p($l->t( 'Password' )); ?>"
48
+				placeholder="<?php p($l->t('Password')); ?>"
49 49
 				value="<?php p($_['adminpass']); ?>"
50 50
 				autocomplete="off" autocapitalize="none" autocorrect="off" required>
51
-			<label for="adminpass" class="infield"><?php p($l->t( 'Password' )); ?></label>
51
+			<label for="adminpass" class="infield"><?php p($l->t('Password')); ?></label>
52 52
 			<input type="checkbox" id="show" class="hidden-visually" name="show">
53
-			<label for="show" class="hidden-visually"><?php p($l->t( 'Show password')); ?></label>
53
+			<label for="show" class="hidden-visually"><?php p($l->t('Show password')); ?></label>
54 54
 		</p>
55 55
 	</fieldset>
56 56
 
57
-	<?php if(!$_['directoryIsSet'] OR !$_['dbIsSet'] OR count($_['errors']) > 0): ?>
57
+	<?php if (!$_['directoryIsSet'] OR !$_['dbIsSet'] OR count($_['errors']) > 0): ?>
58 58
 	<fieldset id="advancedHeader">
59
-		<legend><a id="showAdvanced" tabindex="0" href="#"><?php p($l->t( 'Storage & database' )); ?><img src="<?php print_unescaped(image_path('', 'actions/caret-white.svg')); ?>" /></a></legend>
59
+		<legend><a id="showAdvanced" tabindex="0" href="#"><?php p($l->t('Storage & database')); ?><img src="<?php print_unescaped(image_path('', 'actions/caret-white.svg')); ?>" /></a></legend>
60 60
 	</fieldset>
61 61
 	<?php endif; ?>
62 62
 
63
-	<?php if(!$_['directoryIsSet'] OR count($_['errors']) > 0): ?>
63
+	<?php if (!$_['directoryIsSet'] OR count($_['errors']) > 0): ?>
64 64
 	<fieldset id="datadirField">
65 65
 		<div id="datadirContent">
66
-			<label for="directory"><?php p($l->t( 'Data folder' )); ?></label>
66
+			<label for="directory"><?php p($l->t('Data folder')); ?></label>
67 67
 			<input type="text" name="directory" id="directory"
68 68
 				placeholder="<?php p(OC::$SERVERROOT.'/data'); ?>"
69 69
 				value="<?php p($_['directory']); ?>"
@@ -72,19 +72,19 @@  discard block
 block discarded – undo
72 72
 	</fieldset>
73 73
 	<?php endif; ?>
74 74
 
75
-	<?php if(!$_['dbIsSet'] OR count($_['errors']) > 0): ?>
75
+	<?php if (!$_['dbIsSet'] OR count($_['errors']) > 0): ?>
76 76
 	<fieldset id='databaseBackend'>
77
-		<?php if($_['hasMySQL'] or $_['hasPostgreSQL'] or $_['hasOracle'])
78
-			$hasOtherDB = true; else $hasOtherDB =false; //other than SQLite ?>
79
-		<legend><?php p($l->t( 'Configure the database' )); ?></legend>
77
+		<?php if ($_['hasMySQL'] or $_['hasPostgreSQL'] or $_['hasOracle'])
78
+			$hasOtherDB = true; else $hasOtherDB = false; //other than SQLite ?>
79
+		<legend><?php p($l->t('Configure the database')); ?></legend>
80 80
 		<div id="selectDbType">
81
-		<?php foreach($_['databases'] as $type => $label): ?>
82
-		<?php if(count($_['databases']) === 1): ?>
81
+		<?php foreach ($_['databases'] as $type => $label): ?>
82
+		<?php if (count($_['databases']) === 1): ?>
83 83
 		<p class="info">
84
-			<?php p($l->t( 'Only %s is available.', array($label) )); ?>
85
-			<?php p($l->t( 'Install and activate additional PHP modules to choose other database types.' )); ?><br>
84
+			<?php p($l->t('Only %s is available.', array($label))); ?>
85
+			<?php p($l->t('Install and activate additional PHP modules to choose other database types.')); ?><br>
86 86
 			<a href="<?php print_unescaped(link_to_docs('admin-source_install')); ?>" target="_blank" rel="noreferrer noopener">
87
-				<?php p($l->t( 'For more details check out the documentation.' )); ?> ↗</a>
87
+				<?php p($l->t('For more details check out the documentation.')); ?> ↗</a>
88 88
 		</p>
89 89
 		<input type="hidden" id="dbtype" name="dbtype" value="<?php p($type) ?>">
90 90
 		<?php else: ?>
@@ -96,64 +96,64 @@  discard block
 block discarded – undo
96 96
 		</div>
97 97
 	</fieldset>
98 98
 
99
-		<?php if($hasOtherDB): ?>
99
+		<?php if ($hasOtherDB): ?>
100 100
 		<fieldset id='databaseField'>
101 101
 		<div id="use_other_db">
102 102
 			<p class="grouptop">
103
-				<label for="dbuser" class="infield"><?php p($l->t( 'Database user' )); ?></label>
103
+				<label for="dbuser" class="infield"><?php p($l->t('Database user')); ?></label>
104 104
 				<input type="text" name="dbuser" id="dbuser"
105
-					placeholder="<?php p($l->t( 'Database user' )); ?>"
105
+					placeholder="<?php p($l->t('Database user')); ?>"
106 106
 					value="<?php p($_['dbuser']); ?>"
107 107
 					autocomplete="off" autocapitalize="none" autocorrect="off">
108 108
 			</p>
109 109
 			<p class="groupmiddle">
110 110
 				<input type="password" name="dbpass" id="dbpass" data-typetoggle="#dbpassword-toggle"
111
-					placeholder="<?php p($l->t( 'Database password' )); ?>"
111
+					placeholder="<?php p($l->t('Database password')); ?>"
112 112
 					value="<?php p($_['dbpass']); ?>"
113 113
 					autocomplete="off" autocapitalize="none" autocorrect="off">
114
-				<label for="dbpass" class="infield"><?php p($l->t( 'Database password' )); ?></label>
114
+				<label for="dbpass" class="infield"><?php p($l->t('Database password')); ?></label>
115 115
 				<input type="checkbox" id="dbpassword-toggle" class="hidden-visually" name="dbpassword-toggle">
116 116
 				<label for="dbpassword-toggle"></label>
117 117
 			</p>
118 118
 			<p class="groupmiddle">
119
-				<label for="dbname" class="infield"><?php p($l->t( 'Database name' )); ?></label>
119
+				<label for="dbname" class="infield"><?php p($l->t('Database name')); ?></label>
120 120
 				<input type="text" name="dbname" id="dbname"
121
-					placeholder="<?php p($l->t( 'Database name' )); ?>"
121
+					placeholder="<?php p($l->t('Database name')); ?>"
122 122
 					value="<?php p($_['dbname']); ?>"
123 123
 					autocomplete="off" autocapitalize="none" autocorrect="off"
124 124
 					pattern="[0-9a-zA-Z$_-]+">
125 125
 			</p>
126
-			<?php if($_['hasOracle']): ?>
126
+			<?php if ($_['hasOracle']): ?>
127 127
 			<div id="use_oracle_db">
128 128
 				<p class="groupmiddle">
129
-					<label for="dbtablespace" class="infield"><?php p($l->t( 'Database tablespace' )); ?></label>
129
+					<label for="dbtablespace" class="infield"><?php p($l->t('Database tablespace')); ?></label>
130 130
 					<input type="text" name="dbtablespace" id="dbtablespace"
131
-						placeholder="<?php p($l->t( 'Database tablespace' )); ?>"
131
+						placeholder="<?php p($l->t('Database tablespace')); ?>"
132 132
 						value="<?php p($_['dbtablespace']); ?>"
133 133
 						autocomplete="off" autocapitalize="none" autocorrect="off">
134 134
 				</p>
135 135
 			</div>
136 136
 			<?php endif; ?>
137 137
 			<p class="groupbottom">
138
-				<label for="dbhost" class="infield"><?php p($l->t( 'Database host' )); ?></label>
138
+				<label for="dbhost" class="infield"><?php p($l->t('Database host')); ?></label>
139 139
 				<input type="text" name="dbhost" id="dbhost"
140
-					placeholder="<?php p($l->t( 'Database host' )); ?>"
140
+					placeholder="<?php p($l->t('Database host')); ?>"
141 141
 					value="<?php p($_['dbhost']); ?>"
142 142
 					autocomplete="off" autocapitalize="none" autocorrect="off">
143 143
 			</p>
144 144
 			<p class="info">
145
-				<?php p($l->t( 'Please specify the port number along with the host name (e.g., localhost:5432).' )); ?>
145
+				<?php p($l->t('Please specify the port number along with the host name (e.g., localhost:5432).')); ?>
146 146
 			</p>
147 147
 		</div>
148 148
 		</fieldset>
149 149
 		<?php endif; ?>
150 150
 	<?php endif; ?>
151 151
 
152
-	<?php if(!$_['dbIsSet'] OR count($_['errors']) > 0): ?>
152
+	<?php if (!$_['dbIsSet'] OR count($_['errors']) > 0): ?>
153 153
 		<fieldset id="sqliteInformation" class="warning">
154
-			<legend><?php p($l->t('Performance warning'));?></legend>
155
-			<p><?php p($l->t('You chose SQLite as database.'));?></p>
156
-			<p><?php p($l->t('SQLite should only be used for minimal and development instances. For production we recommend a different database backend.'));?></p>
154
+			<legend><?php p($l->t('Performance warning')); ?></legend>
155
+			<p><?php p($l->t('You chose SQLite as database.')); ?></p>
156
+			<p><?php p($l->t('SQLite should only be used for minimal and development instances. For production we recommend a different database backend.')); ?></p>
157 157
 			<p><?php p($l->t('If you use clients for file syncing, the use of SQLite is highly discouraged.')); ?></p>
158 158
 		</fieldset>
159 159
 	<?php endif ?>
@@ -162,19 +162,19 @@  discard block
 block discarded – undo
162 162
 		<p class="info">
163 163
 			<input type="checkbox" id="install-recommended-apps" name="install-recommended-apps" class="checkbox checkbox--white" checked>
164 164
 			<label for="install-recommended-apps">
165
-				<?php p($l->t( 'Install recommended apps' )); ?>
166
-				<span><?php p($l->t( 'Calendar, Contacts, Talk, Mail & OnlyOffice' )); ?></span>
165
+				<?php p($l->t('Install recommended apps')); ?>
166
+				<span><?php p($l->t('Calendar, Contacts, Talk, Mail & OnlyOffice')); ?></span>
167 167
 			</label>
168 168
 		</p>
169 169
 	</fieldset>
170 170
 
171 171
 	<div class="icon-loading-dark float-spinner">&nbsp;</div>
172 172
 
173
-	<div class="buttons"><input type="submit" class="primary" value="<?php p($l->t( 'Finish setup' )); ?>" data-finishing="<?php p($l->t( 'Finishing …' )); ?>"></div>
173
+	<div class="buttons"><input type="submit" class="primary" value="<?php p($l->t('Finish setup')); ?>" data-finishing="<?php p($l->t('Finishing …')); ?>"></div>
174 174
 
175 175
 	<p class="info">
176 176
 		<span class="icon-info-white"></span>
177
-		<?php p($l->t('Need help?'));?>
178
-		<a target="_blank" rel="noreferrer noopener" href="<?php p(link_to_docs('admin-install')); ?>"><?php p($l->t('See the documentation'));?> ↗</a>
177
+		<?php p($l->t('Need help?')); ?>
178
+		<a target="_blank" rel="noreferrer noopener" href="<?php p(link_to_docs('admin-install')); ?>"><?php p($l->t('See the documentation')); ?> ↗</a>
179 179
 	</p>
180 180
 </form>
Please login to merge, or discard this patch.
Braces   +16 added lines, -6 removed lines patch added patch discarded remove patch
@@ -17,8 +17,11 @@  discard block
 block discarded – undo
17 17
 			<?php if(is_array($err)):?>
18 18
 				<?php p($err['error']); ?>
19 19
 				<span class='hint'><?php p($err['hint']); ?></span>
20
-			<?php else: ?>
21
-				<?php p($err); ?>
20
+			<?php else {
21
+    : ?>
22
+				<?php p($err);
23
+}
24
+?>
22 25
 			<?php endif; ?>
23 26
 		</p>
24 27
 		<?php endforeach; ?>
@@ -74,8 +77,12 @@  discard block
 block discarded – undo
74 77
 
75 78
 	<?php if(!$_['dbIsSet'] OR count($_['errors']) > 0): ?>
76 79
 	<fieldset id='databaseBackend'>
77
-		<?php if($_['hasMySQL'] or $_['hasPostgreSQL'] or $_['hasOracle'])
78
-			$hasOtherDB = true; else $hasOtherDB =false; //other than SQLite ?>
80
+		<?php if($_['hasMySQL'] or $_['hasPostgreSQL'] or $_['hasOracle']) {
81
+			$hasOtherDB = true;
82
+} else {
83
+			    $hasOtherDB =false;
84
+			}
85
+			//other than SQLite ?>
79 86
 		<legend><?php p($l->t( 'Configure the database' )); ?></legend>
80 87
 		<div id="selectDbType">
81 88
 		<?php foreach($_['databases'] as $type => $label): ?>
@@ -87,11 +94,14 @@  discard block
 block discarded – undo
87 94
 				<?php p($l->t( 'For more details check out the documentation.' )); ?> ↗</a>
88 95
 		</p>
89 96
 		<input type="hidden" id="dbtype" name="dbtype" value="<?php p($type) ?>">
90
-		<?php else: ?>
97
+		<?php else {
98
+    : ?>
91 99
 		<input type="radio" name="dbtype" value="<?php p($type) ?>" id="<?php p($type) ?>"
92 100
 			<?php print_unescaped($_['dbtype'] === $type ? 'checked="checked" ' : '') ?>/>
93 101
 		<label class="<?php p($type) ?>" for="<?php p($type) ?>"><?php p($label) ?></label>
94
-		<?php endif; ?>
102
+		<?php endif;
103
+}
104
+?>
95 105
 		<?php endforeach; ?>
96 106
 		</div>
97 107
 	</fieldset>
Please login to merge, or discard this patch.