Completed
Pull Request — master (#1317)
by Julius
12:14 queued 02:17
created
lib/Controller/OCSController.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,6 @@
 block discarded – undo
28 28
 use OCP\AppFramework\Http\DataResponse;
29 29
 use OCP\AppFramework\OCS\OCSBadRequestException;
30 30
 use OCP\AppFramework\OCS\OCSNotFoundException;
31
-use OCP\Files\File;
32 31
 use OCP\Files\Folder;
33 32
 use OCP\Files\IRootFolder;
34 33
 use OCP\Files\NotFoundException;
Please login to merge, or discard this patch.
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -171,6 +171,9 @@
 block discarded – undo
171 171
 		}
172 172
 	}
173 173
 
174
+	/**
175
+	 * @param string $filepath
176
+	 */
174 177
 	private function mb_pathinfo($filepath) {
175 178
 		$result = [];
176 179
 		preg_match('%^(.*?)[\\\\/]*(([^/\\\\]*?)(\.([^\.\\\\/]+?)|))[\\\\/\.]*$%im', ltrim('/' . $filepath), $matches);
Please login to merge, or discard this patch.
lib/TemplateManager.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,6 @@
 block discarded – undo
31 31
 use OCP\Files\NotFoundException;
32 32
 use OCP\IConfig;
33 33
 use OCP\IL10N;
34
-use OCP\IPreview;
35 34
 use OCP\IURLGenerator;
36 35
 use OC\Files\AppData\Factory;
37 36
 
Please login to merge, or discard this patch.
Doc Comments   +9 added lines, -1 removed lines patch added patch discarded remove patch
@@ -104,7 +104,6 @@  discard block
 block discarded – undo
104 104
 	 * @param string $appName
105 105
 	 * @param string $userId
106 106
 	 * @param IConfig $config
107
-	 * @param Factory $appDataFactory
108 107
 	 * @param IURLGenerator $urlGenerator
109 108
 	 * @param IRootFolder $rootFolder
110 109
 	 * @param IL10N $l
@@ -148,6 +147,9 @@  discard block
 block discarded – undo
148 147
 		}
149 148
 	}
150 149
 
150
+	/**
151
+	 * @param string $userId
152
+	 */
151 153
 	public function setUserId($userId) {
152 154
 		$this->userId = $userId;
153 155
 	}
@@ -323,6 +325,9 @@  discard block
 block discarded – undo
323 325
 		}));
324 326
 	}
325 327
 
328
+	/**
329
+	 * @param string $type
330
+	 */
326 331
 	public function getAllFormatted($type) {
327 332
 		if (!array_key_exists($type, self::$tplTypes)) {
328 333
 			return [];
@@ -457,6 +462,9 @@  discard block
 block discarded – undo
457 462
 		];
458 463
 	}
459 464
 
465
+	/**
466
+	 * @param integer $fileId
467
+	 */
460 468
 	public function isTemplate($fileId) {
461 469
 		$empty = $this->getEmpty();
462 470
 		$system = $this->getSystem();
Please login to merge, or discard this patch.
lib/Settings/Section.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,6 @@
 block discarded – undo
37 37
 	private $capabilitites;
38 38
 
39 39
 	/**
40
-	 * @param IL10N $l
41 40
 	 * @param IURLGenerator $url
42 41
 	 */
43 42
 	public function __construct(IL10N $l10n, IURLGenerator $url, Capabilities $capabilities) {
Please login to merge, or discard this patch.
lib/Controller/TemplatesController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
 	 *
58 58
 	 * @param string $appName
59 59
 	 * @param IRequest $request
60
-	 * @param L10N $l10n
60
+	 * @param IL10N $l10n
61 61
 	 * @param TemplateManager $manager
62 62
 	 * @param IPreview $preview
63 63
 	 */
Please login to merge, or discard this patch.
lib/Db/AssetMapper.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -47,8 +47,8 @@  discard block
 block discarded – undo
47 47
 	}
48 48
 
49 49
 	/**
50
-	 * @param $uid
51
-	 * @param $fileid
50
+	 * @param string $uid
51
+	 * @param integer $fileid
52 52
 	 * @return Asset
53 53
 	 */
54 54
 	public function newAsset($uid, $fileid) {
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 
65 65
 
66 66
 	/**
67
-	 * @param $token
67
+	 * @param string $token
68 68
 	 * @return Asset
69 69
 	 * @throws DoesNotExistException
70 70
 	 */
Please login to merge, or discard this patch.
lib/Db/DirectMapper.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,6 @@
 block discarded – undo
28 28
 use OCP\AppFramework\Utility\ITimeFactory;
29 29
 use OCP\IDBConnection;
30 30
 use OCP\Security\ISecureRandom;
31
-use PhpParser\Node\Scalar\MagicConst\Dir;
32 31
 
33 32
 class DirectMapper extends Mapper {
34 33
 
Please login to merge, or discard this patch.
lib/WOPI/Parser.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@
 block discarded – undo
33 33
 	}
34 34
 
35 35
 	/**
36
-	 * @param $mimetype
36
+	 * @param string $mimetype
37 37
 	 * @return array
38 38
 	 * @throws \Exception
39 39
 	 */
Please login to merge, or discard this patch.
lib/Controller/FederationController.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -26,11 +26,8 @@
 block discarded – undo
26 26
 use \OCP\AppFramework\OCSController;
27 27
 use OCA\Richdocuments\Db\WopiMapper;
28 28
 use OCP\AppFramework\Http\DataResponse;
29
-use OCP\AppFramework\OCS\OCSNotFoundException;
30
-use OCP\Files\NotFoundException;
31 29
 use OCP\IConfig;
32 30
 use OCP\IRequest;
33
-use OCP\Share\Exceptions\ShareNotFound;
34 31
 use OCP\Share\IManager;
35 32
 
36 33
 class FederationController extends OCSController {
Please login to merge, or discard this patch.
lib/Service/FederationService.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -126,6 +126,7 @@
 block discarded – undo
126 126
 
127 127
 	/**
128 128
 	 * @param File $item
129
+	 * @param \OCA\Richdocuments\Db\Direct $direct
129 130
 	 * @return string|null
130 131
 	 * @throws NotFoundException
131 132
 	 * @throws InvalidPathException
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 use OCA\Federation\TrustedServers;
28 28
 use OCA\Files_Sharing\External\Storage as SharingExternalStorage;
29 29
 use OCA\Richdocuments\TokenManager;
30
-use OCP\AppFramework\Http\RedirectResponse;
31 30
 use OCP\AppFramework\QueryException;
32 31
 use OCP\Files\File;
33 32
 use OCP\Files\InvalidPathException;
Please login to merge, or discard this patch.