Passed
Pull Request — master (#1603)
by René
03:50
created
tests/Unit/Db/LogMapperTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@
 block discarded – undo
65 65
 		foreach ($this->polls as &$poll) {
66 66
 			$poll = $this->pollMapper->insert($poll);
67 67
 
68
-			for ($count=0; $count < 2; $count++) {
68
+			for ($count = 0; $count < 2; $count++) {
69 69
 				$log = $this->fm->instance('OCA\Polls\Db\Log');
70 70
 				$log->setPollId($poll->getId());
71 71
 				array_push($this->logs, $this->logMapper->insert($log));
Please login to merge, or discard this patch.
tests/Unit/Db/CommentMapperTest.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@
 block discarded – undo
65 65
 		foreach ($this->polls as &$poll) {
66 66
 			$poll = $this->pollMapper->insert($poll);
67 67
 
68
-			for ($count=0; $count < 2; $count++) {
68
+			for ($count = 0; $count < 2; $count++) {
69 69
 				$comment = $this->fm->instance('OCA\Polls\Db\Comment');
70 70
 				$comment->setPollId($poll->getId());
71 71
 				array_push($this->comments, $this->commentMapper->insert($comment));
Please login to merge, or discard this patch.
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -75,8 +75,8 @@
 block discarded – undo
75 75
 	}
76 76
 
77 77
 	 /**
78
- 	 * testFind
79
- 	 */
78
+	  * testFind
79
+	  */
80 80
  	public function testFind() {
81 81
  		foreach ($this->comments as $comment) {
82 82
  			$this->assertInstanceOf(Comment::class, $this->commentMapper->find($comment->getId()));
Please login to merge, or discard this patch.
tests/Unit/Db/SubscriptionMapperTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
 		foreach ($this->polls as &$poll) {
70 70
 			$poll = $this->pollMapper->insert($poll);
71 71
 
72
-			for ($count=0; $count < 2; $count++) {
72
+			for ($count = 0; $count < 2; $count++) {
73 73
 				$subscription = $this->fm->instance('OCA\Polls\Db\Subscription');
74 74
 				$subscription->setPollId($poll->getId());
75 75
 				array_push($this->subscriptions, $this->subscriptionMapper->insert($subscription));
Please login to merge, or discard this patch.
tests/Unit/Db/OptionMapperTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@
 block discarded – undo
65 65
 		foreach ($this->polls as &$poll) {
66 66
 			$poll = $this->pollMapper->insert($poll);
67 67
 
68
-			for ($count=0; $count < 2; $count++) {
68
+			for ($count = 0; $count < 2; $count++) {
69 69
 				$option = $this->fm->instance('OCA\Polls\Db\Option');
70 70
 				$option->setPollId($poll->getId());
71 71
 				array_push($this->options, $this->optionMapper->insert($option));
Please login to merge, or discard this patch.
tests/Unit/Db/VoteMapperTest.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@
 block discarded – undo
75 75
 		foreach ($this->polls as &$poll) {
76 76
 			$poll = $this->pollMapper->insert($poll);
77 77
 
78
-			for ($optionsCount=0; $optionsCount < 2; $optionsCount++) {
78
+			for ($optionsCount = 0; $optionsCount < 2; $optionsCount++) {
79 79
 				$option = $this->fm->instance('OCA\Polls\Db\Option');
80 80
 				$option->setPollId($poll->getId());
81 81
 				array_push($this->options, $this->optionMapper->insert($option));
Please login to merge, or discard this patch.
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
 	}
137 137
 
138 138
 	/**
139
-	* testUpdate
139
+	 * testUpdate
140 140
 	 */
141 141
 	public function testUpdate() {
142 142
 		foreach ($this->votes as &$vote) {
@@ -156,8 +156,8 @@  discard block
 block discarded – undo
156 156
 	}
157 157
 
158 158
 	/**
159
-	* tearDown
160
-	*/
159
+	 * tearDown
160
+	 */
161 161
 	public function tearDown(): void {
162 162
 		parent::tearDown();
163 163
 		foreach ($this->options as $option) {
Please login to merge, or discard this patch.
lib/Service/CommentService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
 	 * Get comments
58 58
 	 * Read all comments of a poll based on the poll id and return list as array
59 59
 	 */
60
-	public function list(?int $pollId = 0, string $token = ''): array {
60
+	public function list(?int $pollId = 0, string $token = '') : array {
61 61
 		if ($token) {
62 62
 			$this->acl->setToken($token);
63 63
 		} else {
Please login to merge, or discard this patch.
lib/Model/CalendarEvent.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@
 block discarded – undo
86 86
 	}
87 87
 
88 88
 	public function getEnd(): int {
89
-		return isset($this->event['DTEND'][0])? $this->event['DTEND'][0]->getTimestamp() : 0;
89
+		return isset($this->event['DTEND'][0]) ? $this->event['DTEND'][0]->getTimestamp() : 0;
90 90
 	}
91 91
 
92 92
 	public function getHasRRule(): bool {
Please login to merge, or discard this patch.
lib/Service/OptionService.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -448,7 +448,7 @@  discard block
 block discarded – undo
448 448
 			} else {
449 449
 				$this->option->setPollOptionText(date('c', $timestamp));
450 450
 			}
451
-		} elseif ($pollOptionText){
451
+		} elseif ($pollOptionText) {
452 452
 			$this->option->setPollOptionText($pollOptionText);
453 453
 		} else {
454 454
 			throw new InvalidOptionPropertyException('Option must have a value');
@@ -501,7 +501,7 @@  discard block
 block discarded – undo
501 501
 			$option->yes = count(
502 502
 				array_filter($this->votes, function ($vote) use ($option) {
503 503
 					return ($vote->getVoteOptionText() === $option->getPollOptionText()
504
-						&& $vote->getVoteAnswer() === 'yes') ;
504
+						&& $vote->getVoteAnswer() === 'yes');
505 505
 				})
506 506
 			);
507 507
 
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -448,7 +448,7 @@
 block discarded – undo
448 448
 			} else {
449 449
 				$this->option->setPollOptionText(date('c', $timestamp));
450 450
 			}
451
-		} elseif ($pollOptionText){
451
+		} elseif ($pollOptionText) {
452 452
 			$this->option->setPollOptionText($pollOptionText);
453 453
 		} else {
454 454
 			throw new InvalidOptionPropertyException('Option must have a value');
Please login to merge, or discard this patch.