Passed
Pull Request — master (#465)
by René
04:56
created
lib/Controller/ApiController.php 4 patches
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -383,7 +383,7 @@
 block discarded – undo
383 383
 			return 'owner';
384 384
 		} elseif ($event['access'] === 'public') {
385 385
 			return 'public';
386
-		} elseif ($event['access'] === 'registered' && \OC::$server->getUserSession()->getUser() instanceof IUser){
386
+		} elseif ($event['access'] === 'registered' && \OC::$server->getUserSession()->getUser() instanceof IUser) {
387 387
 			return 'registered';
388 388
 		} elseif ($this->checkUserAccess($accessList)) {
389 389
 			return 'userInvitation';
Please login to merge, or discard this patch.
Indentation   +66 added lines, -66 removed lines patch added patch discarded remove patch
@@ -88,13 +88,13 @@  discard block
 block discarded – undo
88 88
 	}
89 89
 
90 90
 	/**
91
-	* Transforms a string with user and group names to an array
92
-	* of nextcloud users and groups
93
-	* @NoAdminRequired
94
-	* @NoCSRFRequired
95
-	* @param string $item
96
-	* @return Array
97
-	*/
91
+	 * Transforms a string with user and group names to an array
92
+	 * of nextcloud users and groups
93
+	 * @NoAdminRequired
94
+	 * @NoCSRFRequired
95
+	 * @param string $item
96
+	 * @return Array
97
+	 */
98 98
 	private function convertAccessList($item) {
99 99
 		$split = Array();
100 100
 		if (strpos($item, 'user_') === 0) {
@@ -127,10 +127,10 @@  discard block
 block discarded – undo
127 127
 	}
128 128
 
129 129
 	/**
130
-	* Check if current user is in the access list
131
-	* @param Array $accessList
132
-	* @return Boolean
133
-	*/
130
+	 * Check if current user is in the access list
131
+	 * @param Array $accessList
132
+	 * @return Boolean
133
+	 */
134 134
 	private function checkUserAccess($accessList) {
135 135
 		foreach ($accessList as $accessItem ) {
136 136
 			if ($accessItem['type'] === 'user' &&  $accessItem['id'] === \OC::$server->getUserSession()->getUser()->getUID()) {
@@ -141,10 +141,10 @@  discard block
 block discarded – undo
141 141
 	}
142 142
 
143 143
 	/**
144
-	* Check If current user is member of a group in the access list
145
-	* @param Array $accessList
146
-	* @return Boolean
147
-	*/
144
+	 * Check If current user is member of a group in the access list
145
+	 * @param Array $accessList
146
+	 * @return Boolean
147
+	 */
148 148
 	private function checkGroupAccess($accessList) {
149 149
 		foreach ($accessList as $accessItem ) {
150 150
 			if ($accessItem['type'] === 'group' &&  $this->groupManager->isInGroup(\OC::$server->getUserSession()->getUser()->getUID(),$accessItem['id'])) {
@@ -155,12 +155,12 @@  discard block
 block discarded – undo
155 155
 	}
156 156
 
157 157
 	/**
158
-	* Read all options of a poll based on the poll id
159
-	* @NoAdminRequired
160
-	* @NoCSRFRequired
161
-	* @param string $pollId
162
-	* @return Array
163
-	*/
158
+	 * Read all options of a poll based on the poll id
159
+	 * @NoAdminRequired
160
+	 * @NoCSRFRequired
161
+	 * @param string $pollId
162
+	 * @return Array
163
+	 */
164 164
 	public function getOptions($pollId) {
165 165
 		$optionList = Array();
166 166
 		try {
@@ -179,12 +179,12 @@  discard block
 block discarded – undo
179 179
 	}
180 180
 
181 181
 	/**
182
-	* Read all votes of a poll based on th poll id
183
-	* @NoAdminRequired
184
-	* @NoCSRFRequired
185
-	* @param Integer $pollId
186
-	* @return Array
187
-	*/
182
+	 * Read all votes of a poll based on th poll id
183
+	 * @NoAdminRequired
184
+	 * @NoCSRFRequired
185
+	 * @param Integer $pollId
186
+	 * @return Array
187
+	 */
188 188
 	public function getVotes($pollId) {
189 189
 		$votesList = Array();
190 190
 		try {
@@ -205,12 +205,12 @@  discard block
 block discarded – undo
205 205
 	}
206 206
 
207 207
 	/**
208
-	* Read all comments of a poll based on the poll id
209
-	* @NoAdminRequired
210
-	* @NoCSRFRequired
211
-	* @param Integer $pollId
212
-	* @return Array
213
-	*/
208
+	 * Read all comments of a poll based on the poll id
209
+	 * @NoAdminRequired
210
+	 * @NoCSRFRequired
211
+	 * @param Integer $pollId
212
+	 * @return Array
213
+	 */
214 214
 	public function getComments($pollId) {
215 215
 		$commentsList = Array();
216 216
 		try {
@@ -230,12 +230,12 @@  discard block
 block discarded – undo
230 230
 	}
231 231
 
232 232
 	/**
233
-	* Read an entire poll based on poll id
234
-	* @NoAdminRequired
235
-	* @NoCSRFRequired
236
-	* @param Integer $pollId
237
-	* @return Array
238
-	*/
233
+	 * Read an entire poll based on poll id
234
+	 * @NoAdminRequired
235
+	 * @NoCSRFRequired
236
+	 * @param Integer $pollId
237
+	 * @return Array
238
+	 */
239 239
 	public function getEvent($pollId) {
240 240
 
241 241
 		try {
@@ -282,12 +282,12 @@  discard block
 block discarded – undo
282 282
 	}
283 283
 
284 284
 	/**
285
-	* Read all shares (users and groups with access) of a poll based on the poll id
286
-	* @NoAdminRequired
287
-	* @NoCSRFRequired
288
-	* @param Integer $pollId
289
-	* @return Array
290
-	*/
285
+	 * Read all shares (users and groups with access) of a poll based on the poll id
286
+	 * @NoAdminRequired
287
+	 * @NoCSRFRequired
288
+	 * @param Integer $pollId
289
+	 * @return Array
290
+	 */
291 291
 	public function getShares($pollId) {
292 292
 
293 293
 		try {
@@ -307,10 +307,10 @@  discard block
 block discarded – undo
307 307
 	}
308 308
 
309 309
 	/**
310
-	* Set the access right of the current user for the poll
311
-	* @param Integer $pollId
312
-	* @return Boolean
313
-	*/
310
+	 * Set the access right of the current user for the poll
311
+	 * @param Integer $pollId
312
+	 * @return Boolean
313
+	 */
314 314
 	private function grantAccessAs($pollId) {
315 315
 		if (!\OC::$server->getUserSession()->getUser() instanceof IUser) {
316 316
 			$currentUser = '';
@@ -339,12 +339,12 @@  discard block
 block discarded – undo
339 339
 
340 340
 
341 341
 	/**
342
-	* Read an entire poll based on it's id or hash
343
-	* @NoAdminRequired
344
-	* @NoCSRFRequired
345
-	* @param string $id hash or id of the poll
346
-	* @return Array
347
-	*/
342
+	 * Read an entire poll based on it's id or hash
343
+	 * @NoAdminRequired
344
+	 * @NoCSRFRequired
345
+	 * @param string $id hash or id of the poll
346
+	 * @return Array
347
+	 */
348 348
 	public function getPoll($pollId) {
349 349
 
350 350
 		if (!\OC::$server->getUserSession()->getUser() instanceof IUser) {
@@ -395,11 +395,11 @@  discard block
 block discarded – undo
395 395
 	}
396 396
 
397 397
   	/**
398
-	* Get a list of NC users and groups
399
-	* @NoAdminRequired
400
-	* @NoCSRFRequired
401
-	* @return DataResponse
402
-	*/
398
+  	 * Get a list of NC users and groups
399
+  	 * @NoAdminRequired
400
+  	 * @NoCSRFRequired
401
+  	 * @return DataResponse
402
+  	 */
403 403
 	public function getSiteUsersAndGroups($query = '', $getGroups = true, $getUsers = true, $skipGroups = array(), $skipUsers = array()) {
404 404
 		$list = array();
405 405
 		$data = array();
@@ -444,12 +444,12 @@  discard block
 block discarded – undo
444 444
 
445 445
 
446 446
 	/**
447
-	* Get all polls
448
-	* @NoAdminRequired
449
-	* @NoCSRFRequired
450
-	* @PublicPage
451
-	* @return DataResponse
452
-	*/
447
+	 * Get all polls
448
+	 * @NoAdminRequired
449
+	 * @NoCSRFRequired
450
+	 * @PublicPage
451
+	 * @return DataResponse
452
+	 */
453 453
 
454 454
 	public function getPolls() {
455 455
 		if (!\OC::$server->getUserSession()->getUser() instanceof IUser) {
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -132,8 +132,8 @@  discard block
 block discarded – undo
132 132
 	* @return Boolean
133 133
 	*/
134 134
 	private function checkUserAccess($accessList) {
135
-		foreach ($accessList as $accessItem ) {
136
-			if ($accessItem['type'] === 'user' &&  $accessItem['id'] === \OC::$server->getUserSession()->getUser()->getUID()) {
135
+		foreach ($accessList as $accessItem) {
136
+			if ($accessItem['type'] === 'user' && $accessItem['id'] === \OC::$server->getUserSession()->getUser()->getUID()) {
137 137
 				return true;
138 138
 			}
139 139
 		}
@@ -146,8 +146,8 @@  discard block
 block discarded – undo
146 146
 	* @return Boolean
147 147
 	*/
148 148
 	private function checkGroupAccess($accessList) {
149
-		foreach ($accessList as $accessItem ) {
150
-			if ($accessItem['type'] === 'group' &&  $this->groupManager->isInGroup(\OC::$server->getUserSession()->getUser()->getUID(),$accessItem['id'])) {
149
+		foreach ($accessList as $accessItem) {
150
+			if ($accessItem['type'] === 'group' && $this->groupManager->isInGroup(\OC::$server->getUserSession()->getUser()->getUID(), $accessItem['id'])) {
151 151
 				return true;
152 152
 			}
153 153
 		}
@@ -297,9 +297,9 @@  discard block
 block discarded – undo
297 297
 		};
298 298
 
299 299
 		if (!strpos('|public|hidden|registered', $poll->getAccess())) {
300
-			$accessList = explode(';',$poll->getAccess());
300
+			$accessList = explode(';', $poll->getAccess());
301 301
 			$accessList = array_filter($accessList);
302
-			$accessList = array_map(Array($this,'convertAccessList'), $accessList);
302
+			$accessList = array_map(Array($this, 'convertAccessList'), $accessList);
303 303
 		} else {
304 304
 			return [];
305 305
 		}
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
 			return 'owner';
325 325
 		} elseif ($event['access'] === 'public') {
326 326
 			return 'public';
327
-		} elseif ($event['access'] === 'registered' && \OC::$server->getUserSession()->getUser() instanceof IUser){
327
+		} elseif ($event['access'] === 'registered' && \OC::$server->getUserSession()->getUser() instanceof IUser) {
328 328
 			return 'registered';
329 329
 		} elseif ($this->checkUserAccess($accessList)) {
330 330
 			return 'userInvitation';
Please login to merge, or discard this patch.
Upper-Lower-Casing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 	* @return Array
97 97
 	*/
98 98
 	private function convertAccessList($item) {
99
-		$split = Array();
99
+		$split = array();
100 100
 		if (strpos($item, 'user_') === 0) {
101 101
 			$user = $this->userManager->get(substr($item, 5));
102 102
 			$split = [
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
 	* @return Array
163 163
 	*/
164 164
 	public function getOptions($pollId) {
165
-		$optionList = Array();
165
+		$optionList = array();
166 166
 		try {
167 167
 			$options = $this->optionsMapper->findByPoll($pollId);
168 168
 			foreach ($options as $optionElement) {
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
 	* @return Array
187 187
 	*/
188 188
 	public function getVotes($pollId) {
189
-		$votesList = Array();
189
+		$votesList = array();
190 190
 		try {
191 191
 			$votes = $this->votesMapper->findByPoll($pollId);
192 192
 			foreach ($votes as $voteElement) {
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
 	* @return Array
213 213
 	*/
214 214
 	public function getComments($pollId) {
215
-		$commentsList = Array();
215
+		$commentsList = array();
216 216
 		try {
217 217
 			$comments = $this->commentMapper->findByPoll($pollId);
218 218
 			foreach ($comments as $commentElement) {
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
 		if (!strpos('|public|hidden|registered', $poll->getAccess())) {
300 300
 			$accessList = explode(';',$poll->getAccess());
301 301
 			$accessList = array_filter($accessList);
302
-			$accessList = array_map(Array($this,'convertAccessList'), $accessList);
302
+			$accessList = array_map(array($this,'convertAccessList'), $accessList);
303 303
 		} else {
304 304
 			return [];
305 305
 		}
@@ -461,7 +461,7 @@  discard block
 block discarded – undo
461 461
 		} catch (DoesNotExistException $e) {
462 462
 			return new DataResponse($e, Http::STATUS_NOT_FOUND);
463 463
 		}
464
-		$eventsList = Array();
464
+		$eventsList = array();
465 465
 		foreach ($events as $eventElement) {
466 466
 			$eventsList[] = $this->getEvent($eventElement->id);
467 467
 		};
Please login to merge, or discard this patch.