View GitHub Repository passman

Schedule Inspection
Subscribe
Completed
Push — phpunit ( ef6eb7...7f2080 )
by Marcos
09:10
created
Status
Category
Toggle Patches
lib/Db/CredentialMapper.php 2 patches
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch 
@@ -41,7 +41,7 @@  discard block
 
 block discarded – undo
41 41 
 		$sql = 'SELECT * FROM `*PREFIX*passman_credentials` ' .
42 42 
 			'WHERE `user_id` = ? and vault_id = ? AND shared_key is NULL LIMIT 20';
43 43 
 		$entities = $this->findEntities($sql, [$user_id, $vault_id]);
44 
-		$count = count($entities)-1;
44 
+		$count = count($entities) - 1;
45 45 
 		$entities = array_splice($entities, rand(0, $count), 1);
46 46 
 		return $entities;
47 47 
 	}
 
@@ -50,7 +50,7 @@  discard block
 
 block discarded – undo
50 50 
 	 * @param $timestamp
51 51 
 	 * @return Credential[]
52 52 
 	 */
53 
-	public function getExpiredCredentials($timestamp){
53 
+	public function getExpiredCredentials($timestamp) {
54 54 
 		$sql = 'SELECT * FROM `*PREFIX*passman_credentials` ' .
55 55 
 			'WHERE `expire_time` > 0 AND `expire_time` < ?';
56 56 
 		return $this->findEntities($sql, [$timestamp]);
 
@@ -61,33 +61,33 @@  discard block
 
 block discarded – undo
61 61 
      * @param null $user_id
62 62 
      * @return Credential
63 63 
      */
64 
-	public function getCredentialById($credential_id, $user_id = null){
64 
+	public function getCredentialById($credential_id, $user_id = null) {
65 65 
 		$sql = 'SELECT * FROM `*PREFIX*passman_credentials` ' .
66 66 
 			'WHERE `id` = ?';
67 67 
         // If we want to check the owner, add it to the query
68 68 
 		$params = [$credential_id];
69 
-        if ($user_id !== null){
69 
+        if ($user_id !== null) {
70 70 
         	$sql .= ' and `user_id` = ? ';
71 71 
 			array_push($params, $user_id);
72 72 
 		}
73 
-		return $this->findEntity($sql,$params);
73 
+		return $this->findEntity($sql, $params);
74 74 
 	}
75 75
76 76 
 	/**
77 77 
 	 * @param $credential_id
78 78 
 	 * @return Credential
79 79 
 	 */
80 
-	public function getCredentialLabelById($credential_id){
80 
+	public function getCredentialLabelById($credential_id) {
81 81 
 		$sql = 'SELECT id, label FROM `*PREFIX*passman_credentials` ' .
82 82 
 			'WHERE `id` = ? ';
83 
-		return $this->findEntity($sql,[$credential_id]);
83 
+		return $this->findEntity($sql, [$credential_id]);
84 84 
 	}
85 85
86 86 
 	/**
87 87 
 	 * @param $raw_credential
88 88 
 	 * @return Credential
89 89 
 	 */
90 
-	public function create($raw_credential){
90 
+	public function create($raw_credential) {
91 91 
 		$credential = new Credential();
92 92
93 93 
 		$credential->setGuid($this->utils->GUID());
 
@@ -118,7 +118,7 @@  discard block
 
 block discarded – undo
118 118 
 	 * @param $raw_credential array An array containing all the credential fields
119 119 
 	 * @return Credential The updated credential
120 120 
 	 */
121 
-	public function updateCredential($raw_credential){
121 
+	public function updateCredential($raw_credential) {
122 122 
 		$original = $this->getCredentialByGUID($raw_credential['guid']);
123 123 
 		$credential = new Credential();
124 124 
 		$credential->setId($original->getId());
 
@@ -146,11 +146,11 @@  discard block
 
 block discarded – undo
146 146 
 		return parent::update($credential);
147 147 
 	}
148 148
149 
-	public function deleteCredential(Credential $credential){
149 
+	public function deleteCredential(Credential $credential) {
150 150 
 		return $this->delete($credential);
151 151 
 	}
152 152
153 
-	public function upd(Credential $credential){
153 
+	public function upd(Credential $credential) {
154 154 
 		$this->update($credential);
155 155 
 	}
156 156 
 
@@ -159,10 +159,10 @@  discard block
 
 block discarded – undo
159 159 
      * @param $credential_guid
160 160 
      * @return Credential
161 161 
      */
162 
-	public function getCredentialByGUID($credential_guid, $user_id = null){
162 
+	public function getCredentialByGUID($credential_guid, $user_id = null) {
163 163 
 	    $q = 'SELECT * FROM `*PREFIX*passman_credentials` WHERE guid = ? ';
164 164 
 		$params = [$credential_guid];
165 
-		if ($user_id !== null){
165 
+		if ($user_id !== null) {
166 166 
 			$q .= ' and `user_id` = ? ';
167 167 
 			array_push($params, $user_id);
168 168 
 		}
Please login to merge, or discard this patch.
Braces   +10 added lines, -10 removed lines patch added patch discarded remove patch 
@@ -50,7 +50,7 @@  discard block
 
 block discarded – undo
50 50 
 	 * @param $timestamp
51 51 
 	 * @return Credential[]
52 52 
 	 */
53 
-	public function getExpiredCredentials($timestamp){
53 
+	public function getExpiredCredentials($timestamp) {
54 54 
 		$sql = 'SELECT * FROM `*PREFIX*passman_credentials` ' .
55 55 
 			'WHERE `expire_time` > 0 AND `expire_time` < ?';
56 56 
 		return $this->findEntities($sql, [$timestamp]);
 
@@ -61,12 +61,12 @@  discard block
 
 block discarded – undo
61 61 
      * @param null $user_id
62 62 
      * @return Credential
63 63 
      */
64 
-	public function getCredentialById($credential_id, $user_id = null){
64 
+	public function getCredentialById($credential_id, $user_id = null) {
65 65 
 		$sql = 'SELECT * FROM `*PREFIX*passman_credentials` ' .
66 66 
 			'WHERE `id` = ?';
67 67 
         // If we want to check the owner, add it to the query
68 68 
 		$params = [$credential_id];
69 
-        if ($user_id !== null){
69 
+        if ($user_id !== null) {
70 70 
         	$sql .= ' and `user_id` = ? ';
71 71 
 			array_push($params, $user_id);
72 72 
 		}
 
@@ -77,7 +77,7 @@  discard block
 
 block discarded – undo
77 77 
 	 * @param $credential_id
78 78 
 	 * @return Credential
79 79 
 	 */
80 
-	public function getCredentialLabelById($credential_id){
80 
+	public function getCredentialLabelById($credential_id) {
81 81 
 		$sql = 'SELECT id, label FROM `*PREFIX*passman_credentials` ' .
82 82 
 			'WHERE `id` = ? ';
83 83 
 		return $this->findEntity($sql,[$credential_id]);
 
@@ -87,7 +87,7 @@  discard block
 
 block discarded – undo
87 87 
 	 * @param $raw_credential
88 88 
 	 * @return Credential
89 89 
 	 */
90 
-	public function create($raw_credential){
90 
+	public function create($raw_credential) {
91 91 
 		$credential = new Credential();
92 92
93 93 
 		$credential->setGuid($this->utils->GUID());
 
@@ -118,7 +118,7 @@  discard block
 
 block discarded – undo
118 118 
 	 * @param $raw_credential array An array containing all the credential fields
119 119 
 	 * @return Credential The updated credential
120 120 
 	 */
121 
-	public function updateCredential($raw_credential){
121 
+	public function updateCredential($raw_credential) {
122 122 
 		$original = $this->getCredentialByGUID($raw_credential['guid']);
123 123 
 		$credential = new Credential();
124 124 
 		$credential->setId($original->getId());
 
@@ -146,11 +146,11 @@  discard block
 
 block discarded – undo
146 146 
 		return parent::update($credential);
147 147 
 	}
148 148
149 
-	public function deleteCredential(Credential $credential){
149 
+	public function deleteCredential(Credential $credential) {
150 150 
 		return $this->delete($credential);
151 151 
 	}
152 152
153 
-	public function upd(Credential $credential){
153 
+	public function upd(Credential $credential) {
154 154 
 		$this->update($credential);
155 155 
 	}
156 156 
 
@@ -159,10 +159,10 @@  discard block
 
 block discarded – undo
159 159 
      * @param $credential_guid
160 160 
      * @return Credential
161 161 
      */
162 
-	public function getCredentialByGUID($credential_guid, $user_id = null){
162 
+	public function getCredentialByGUID($credential_guid, $user_id = null) {
163 163 
 	    $q = 'SELECT * FROM `*PREFIX*passman_credentials` WHERE guid = ? ';
164 164 
 		$params = [$credential_guid];
165 
-		if ($user_id !== null){
165 
+		if ($user_id !== null) {
166 166 
 			$q .= ' and `user_id` = ? ';
167 167 
 			array_push($params, $user_id);
168 168 
 		}
Please login to merge, or discard this patch.