Completed
Branch scrutinizer-patch-1 (ae73bf)
by Sander
02:42
created
controller/credentialcontroller.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
 		try {
259 259
 			$credential = $this->credentialService->getCredentialByGUID($credential_guid);
260 260
 		}
261
-		catch (DoesNotExistException $ex){
261
+		catch (DoesNotExistException $ex) {
262 262
 			return new NotFoundJSONResponse();
263 263
 		}
264 264
 
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
 		}
269 269
 		else {
270 270
 			$acl = $this->sharingService->getACL($this->userId, $credential_guid);
271
-			if ($acl->hasPermission(SharingACL::HISTORY)){
271
+			if ($acl->hasPermission(SharingACL::HISTORY)) {
272 272
 				$result = $this->credentialRevisionService->getRevisions($credential->getId());
273 273
 			}
274 274
 			else {
Please login to merge, or discard this patch.
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -257,21 +257,18 @@
 block discarded – undo
257 257
 	public function getRevision($credential_guid) {
258 258
 		try {
259 259
 			$credential = $this->credentialService->getCredentialByGUID($credential_guid);
260
-		}
261
-		catch (DoesNotExistException $ex){
260
+		} catch (DoesNotExistException $ex){
262 261
 			return new NotFoundJSONResponse();
263 262
 		}
264 263
 
265 264
 		// If the request was made by the owner of the credential
266 265
 		if ($this->userId === $credential->getUserId()) {
267 266
 			$result = $this->credentialRevisionService->getRevisions($credential->getId(), $this->userId);
268
-		}
269
-		else {
267
+		} else {
270 268
 			$acl = $this->sharingService->getACL($this->userId, $credential_guid);
271 269
 			if ($acl->hasPermission(SharingACL::HISTORY)){
272 270
 				$result = $this->credentialRevisionService->getRevisions($credential->getId());
273
-			}
274
-			else {
271
+			} else {
275 272
 				return new NotFoundJSONResponse();
276 273
 			}
277 274
 		}
Please login to merge, or discard this patch.