Completed
Pull Request — master (#151)
by Sander
02:40
created
templates/settings-admin.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
 		$versions = $element->getElementsByTagName("version");
17 17
 		$version = $versions->item(0)->nodeValue;
18 18
 	}
19
-	if($version) {
19
+	if ($version) {
20 20
 		$githubVersion = $version;
21 21
 	}
22 22
 	$AppInstance = new App();
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
 		Github version: <?php p($githubVersion); ?><br />
31 31
 		Local version: <?php p($localVersion); ?><br />
32 32
 		<?php
33
-		if(version_compare($githubVersion, $localVersion) === 1){
33
+		if (version_compare($githubVersion, $localVersion) === 1) {
34 34
 			p($l->t('A newer version of passman is available'));
35 35
 		}
36 36
 		?>
Please login to merge, or discard this patch.
Braces   +21 added lines, -6 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
 		Github version: <?php p($githubVersion); ?><br />
31 31
 		Local version: <?php p($localVersion); ?><br />
32 32
 		<?php
33
-		if(version_compare($githubVersion, $localVersion) === 1){
33
+		if(version_compare($githubVersion, $localVersion) === 1) {
34 34
 			p($l->t('A newer version of passman is available'));
35 35
 		}
36 36
 		?>
@@ -47,7 +47,10 @@  discard block
 block discarded – undo
47 47
 		<p>
48 48
 			<input type="checkbox" name="passman_sharing_enabled"
49 49
 				   id="passman_sharing_enabled" class="checkbox"
50
-				   value="1" <?php if ($_['sharing_enabled']) print_unescaped('checked="checked"'); ?> />
50
+				   value="1" <?php if ($_['sharing_enabled']) {
51
+	print_unescaped('checked="checked"');
52
+}
53
+?> />
51 54
 			<label for="passman_sharing_enabled">
52 55
 				<?php p($l->t('Allow users on this server to share passwords with other users')); ?>
53 56
 			</label>
@@ -80,16 +83,28 @@  discard block
 block discarded – undo
80 83
 		<p>
81 84
 			<label for="vault_key_strength">Minimum vault key strength:</label>
82 85
 			<select name="vault_key_strength" id="vault_key_strength">
83
-				<option value="1" <?php if ($_['vault_key_strength'] === 1) print_unescaped('selected="selected"'); ?>>
86
+				<option value="1" <?php if ($_['vault_key_strength'] === 1) {
87
+	print_unescaped('selected="selected"');
88
+}
89
+?>>
84 90
 					Poor
85 91
 				</option>
86
-				<option value="2" <?php if ($_['vault_key_strength'] === 2) print_unescaped('selected="selected"'); ?>>
92
+				<option value="2" <?php if ($_['vault_key_strength'] === 2) {
93
+	print_unescaped('selected="selected"');
94
+}
95
+?>>
87 96
 					Weak
88 97
 				</option>
89
-				<option value="3" <?php if ($_['vault_key_strength'] === 3) print_unescaped('selected="selected"'); ?>>
98
+				<option value="3" <?php if ($_['vault_key_strength'] === 3) {
99
+	print_unescaped('selected="selected"');
100
+}
101
+?>>
90 102
 					Good
91 103
 				</option>
92
-				<option value="4" <?php if ($_['vault_key_strength'] === 4) print_unescaped('selected="selected"'); ?>>
104
+				<option value="4" <?php if ($_['vault_key_strength'] === 4) {
105
+	print_unescaped('selected="selected"');
106
+}
107
+?>>
93 108
 					Strong
94 109
 				</option>
95 110
 			</select>
Please login to merge, or discard this patch.
controller/internalcontroller.php 3 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
 								$UserId,
29 29
 								CredentialService $credentialService,
30 30
 								IConfig $config
31
-                                ) {
31
+								) {
32 32
 		parent::__construct($AppName, $request);
33 33
 		$this->userId = $UserId;
34 34
 		$this->credentialService = $credentialService;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -105,7 +105,7 @@
 block discarded – undo
105 105
 	 * @NoCSRFRequired
106 106
 	 */
107 107
 	public function saveSettings($key, $value) {
108
-		if(is_numeric($value)){
108
+		if (is_numeric($value)) {
109 109
 			$value = intval($value);
110 110
 		}
111 111
 		$this->config->setAppValue('passman', $key, $value);
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -105,7 +105,7 @@
 block discarded – undo
105 105
 	 * @NoCSRFRequired
106 106
 	 */
107 107
 	public function saveSettings($key, $value) {
108
-		if(is_numeric($value)){
108
+		if(is_numeric($value)) {
109 109
 			$value = intval($value);
110 110
 		}
111 111
 		$this->config->setAppValue('passman', $key, $value);
Please login to merge, or discard this patch.