nextcloud / fulltextsearch

lib/Service/ProviderService.php

Doc Comments +3 added lines

@@ -214,6 +214,9 @@
 	}
 
 
+	/**
+	 * @param boolean $boolean
+	 */
 	public function setProviderAsIndexed(IFullTextSearchProvider $provider, $boolean) {
 		$this->configService->setProviderOptions(
 			$provider->getId(), ConfigService::PROVIDER_INDEXED, (($boolean) ? '1' : '0')

Spacing +3 added lines, -3 removed lines

@@ -107,7 +107,7 @@ 
 		$provider = \OC::$server->query((string)$providerId);
 		if (!($provider instanceof IFullTextSearchProvider)) {
 			throw new ProviderIsNotCompatibleException(
-				$providerId . ' is not a compatible IFullTextSearchProvider'
+				$providerId.' is not a compatible IFullTextSearchProvider'
 			);
 		}
 
@@ -196,7 +196,7 @@ 
 			}
 		}
 
-		throw new ProviderDoesNotExistException('Provider \'' . $providerId . '\' does not exist');
+		throw new ProviderDoesNotExistException('Provider \''.$providerId.'\' does not exist');
 	}
 
 
@@ -284,7 +284,7 @@ 
 			$knownProvider = $providerWrapper->getProvider();
 			if ($knownProvider->getId() === $provider->getId()) {
 				throw new ProviderIsNotUniqueException(
-					'FullTextSearchProvider ' . $provider->getId() . ' already exist'
+					'FullTextSearchProvider '.$provider->getId().' already exist'
 				);
 			}
 		}

lib/Command/Search.php

Spacing +3 added lines, -3 removed lines

@@ -105,13 +105,13 @@
 
 	private function displaySearchResult(SearchResult $searchResult) {
 
-		echo '> ' . $searchResult->getProvider()
-								 ->getName() . "\n";
+		echo '> '.$searchResult->getProvider()
+								 ->getName()."\n";
 
 		/** @var IndexDocument[] $result */
 		$result = $searchResult->getDocuments();
 		foreach ($result as $document) {
-			echo ' - ' . $document->getId() . ' score:' . $document->getScore() . "\n";
+			echo ' - '.$document->getId().' score:'.$document->getScore()."\n";
 		}
 	}
 

lib/Service/RunningService.php

Spacing +5 added lines, -5 removed lines

@@ -224,18 +224,18 @@
 		$preAction = $tick->getAction();
 
 		if ($preAction !== '') {
-			$preActionTotal = $tick->getInfo($preAction . 'Total', 0);
-			$preActionStart = $tick->getInfo($preAction . 'Init', 0);
+			$preActionTotal = $tick->getInfo($preAction.'Total', 0);
+			$preActionStart = $tick->getInfo($preAction.'Init', 0);
 
 			if ($preActionStart > 0) {
 
 				$preActionTotal += ($now - $preActionStart);
-				$tick->setInfo($preAction . 'Total', $preActionTotal);
-				$tick->unsetInfo($preAction . 'Init');
+				$tick->setInfo($preAction.'Total', $preActionTotal);
+				$tick->unsetInfo($preAction.'Init');
 			}
 		}
 		$tick->setAction($action)
-			 ->setInfo($action . 'Init', $now);
+			 ->setInfo($action.'Init', $now);
 	}
 
 

lib/Service/SearchService.php

Spacing +1 added lines, -1 removed lines

@@ -184,7 +184,7 @@
 			try {
 				$rights->setCircles(Circles::joinedCircleIds($user->getUID()));
 			} catch (Exception $e) {
-				$this->miscService->log('Circles is set as enabled but: ' . $e->getMessage());
+				$this->miscService->log('Circles is set as enabled but: '.$e->getMessage());
 			}
 		}
 

lib/Model/Index.php

Doc Comments +1 added lines, -1 removed lines

@@ -129,7 +129,7 @@
 	/**
 	 * @param int $status
 	 *
-	 * @return bool
+	 * @return integer
 	 */
 	public function isStatus($status) {
 		return ((int)$status & $this->getStatus());

lib/Model/SearchRequest.php

Doc Comments +2 added lines, -2 removed lines

@@ -212,8 +212,8 @@
 	}
 
 	/**
-	 * @param $key
-	 * @param $value
+	 * @param string $key
+	 * @param string $value
 	 *
 	 * @return $this
 	 */

Spacing +2 added lines, -2 removed lines

@@ -169,7 +169,7 @@ 
 
 		$options = ['is', 'show'];
 		if (in_array($kw, $options)) {
-			$this->addOption($kw . '_' . $value, '1');
+			$this->addOption($kw.'_'.$value, '1');
 
 			return true;
 		}
@@ -422,7 +422,7 @@ 
 		foreach ($ak as $source) {
 			$tags = $this->subTags[$source];
 			foreach ($tags as $tag) {
-				$subTags[] = $source . '_' . $tag;
+				$subTags[] = $source.'_'.$tag;
 			}
 		}
 

lib/Command/Test.php

Doc Comments +1 added lines, -1 removed lines

@@ -210,7 +210,7 @@
 
 	/**
 	 * @param string|bool $line
-	 * @param $isNewLine
+	 * @param boolean $isNewLine
 	 *
 	 * @return string
 	 */

Spacing +12 added lines, -12 removed lines

@@ -207,7 +207,7 @@ 
 			$output->write(' ', true);
 		}
 
-		$output->write($line . ' ', false);
+		$output->write($line.' ', false);
 	}
 
 
@@ -257,7 +257,7 @@ 
 		$this->output($output, 'Testing mocked provider: get indexable documents.');
 		$indexableDocuments =
 			$testProvider->generateIndexableDocuments(TestService::DOCUMENT_USER1);
-		$this->output($output, '(' . sizeof($indexableDocuments) . ' items)', false);
+		$this->output($output, '('.sizeof($indexableDocuments).' items)', false);
 		$this->output($output, true);
 	}
 
@@ -273,12 +273,12 @@ 
 		$wrapper = $this->platformService->getPlatform();
 		$testPlatform = $wrapper->getPlatform();
 
-		$this->output($output, '(' . $testPlatform->getName() . ')', false);
+		$this->output($output, '('.$testPlatform->getName().')', false);
 		$this->output($output, true);
 
 		$this->output($output, 'Testing search platform.');
 		if (!$testPlatform->testPlatform()) {
-			throw new Exception ('Search platform (' . $testPlatform->getName() . ') down ?');
+			throw new Exception('Search platform ('.$testPlatform->getName().') down ?');
 		}
 		$this->output($output, true);
 
@@ -374,13 +374,13 @@ 
 			);
 
 			$this->output(
-				$output, '(size: ' . $indexDocument->getContentSize() . ')', false
+				$output, '(size: '.$indexDocument->getContentSize().')', false
 			);
 			$this->output($output, true);
 		} catch (Exception $e) {
 			throw new Exception(
-				"Issue while getting test document '" . TestService::DOCUMENT_TYPE_LICENSE
-				. "' from search platform: " . $e->getMessage()
+				"Issue while getting test document '".TestService::DOCUMENT_TYPE_LICENSE
+				. "' from search platform: ".$e->getMessage()
 			);
 		}
 
@@ -554,7 +554,7 @@ 
 	) {
 		$this->output(
 			$output,
-			" - '" . $search . "'" . (($moreOutput === '') ? '' : ' - ' . $moreOutput . ' - ')
+			" - '".$search."'".(($moreOutput === '') ? '' : ' - '.$moreOutput.' - ')
 		);
 		$request = new SearchRequest();
 
@@ -568,7 +568,7 @@ 
 
 		$this->output(
 			$output,
-			'(result: ' . $searchResult->getCount() . ', expected: ' . json_encode($expected) . ')',
+			'(result: '.$searchResult->getCount().', expected: '.json_encode($expected).')',
 			false
 		);
 		$this->compareSearchResult($searchResult, $expected);
@@ -632,12 +632,12 @@ 
 	private function compareSearchResult(SearchResult $searchResult, $entries) {
 		$documents = $searchResult->getDocuments();
 		if (sizeof($documents) !== sizeof($entries)) {
-			throw new \Exception('Unexpected SearchResult: ' . json_encode($searchResult));
+			throw new \Exception('Unexpected SearchResult: '.json_encode($searchResult));
 		}
 
 		foreach ($documents as $document) {
 			if (!in_array($document->getId(), $entries)) {
-				throw new \Exception('Unexpected Document: ' . json_encode($document));
+				throw new \Exception('Unexpected Document: '.json_encode($document));
 			}
 		}
 	}
@@ -650,7 +650,7 @@ 
 	 * @throws InterruptException
 	 */
 	private function pause(OutputInterface $output, $s) {
-		$this->output($output, 'Pausing ' . $s . ' seconds');
+		$this->output($output, 'Pausing '.$s.' seconds');
 
 		for ($i = 1; $i <= $s; $i++) {
 			if (time_nanosleep(1, 0) !== true) {

lib/Service/TestService.php

Spacing +2 added lines, -2 removed lines

@@ -77,7 +77,7 @@ 
 	public function generateIndexDocumentContentLicense(IndexOptions $options = null) {
 		$indexDocument = $this->generateIndexDocument(self::DOCUMENT_TYPE_LICENSE);
 
-		$content = file_get_contents(__DIR__ . '/../../LICENSE');
+		$content = file_get_contents(__DIR__.'/../../LICENSE');
 		$indexDocument->setContent($content);
 
 		if ($options === null) {
@@ -134,7 +134,7 @@ 
 			$orig = call_user_func([$origIndex, $method]);
 			$compare = call_user_func([$compareIndex, $method]);
 			if ($orig !== $compare) {
-				throw new \Exception($method . '() orig:' . $orig . ' compare:' . $compare);
+				throw new \Exception($method.'() orig:'.$orig.' compare:'.$compare);
 
 			};
 		}

lib/Service/CliService.php

Doc Comments +1 added lines, -1 removed lines

@@ -73,7 +73,7 @@
 
 	/**
 	 * @param string $panelId
-	 * @param array $lines
+	 * @param string[] $lines
 	 */
 	public function createPanel($panelId, $lines) {
 		if (!is_array($lines)) {

Spacing +1 added lines, -1 removed lines

@@ -182,7 +182,7 @@
 			}
 		}
 
-		$this->display->setFormat(implode("\n", $format) . "\n");
+		$this->display->setFormat(implode("\n", $format)."\n");
 		$this->refreshInfo();
 		$this->display->start();
 	}