Passed
Pull Request — master (#946)
by Julius
02:30
created
lib/Collaboration/Resources/ResourceProvider.php 3 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,6 @@
 block discarded – undo
55 55
 	/**
56 56
 	 * Get the type of a resource
57 57
 	 *
58
-	 * @param IResource $resource
59 58
 	 * @return string
60 59
 	 * @since 15.0.0
61 60
 	 */
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -25,7 +25,6 @@  discard block
 block discarded – undo
25 25
 
26 26
 
27 27
 use OCA\Deck\Db\Acl;
28
-use OCA\Deck\Db\Board;
29 28
 use OCA\Deck\Db\BoardMapper;
30 29
 use OCA\Deck\Service\PermissionService;
31 30
 use OCP\AppFramework\Db\DoesNotExistException;
@@ -34,7 +33,6 @@  discard block
 block discarded – undo
34 33
 use OCP\Collaboration\Resources\IManager;
35 34
 use OCP\Collaboration\Resources\IProvider;
36 35
 use OCP\Collaboration\Resources\IResource;
37
-use OCP\Collaboration\Resources\ResourceException;
38 36
 use OCP\IUser;
39 37
 
40 38
 class ResourceProvider implements IProvider {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@
 block discarded – undo
124 124
 		} catch (QueryException $e) {
125 125
 		}
126 126
 		if ($boardId !== null) {
127
-			$resource = $resourceManager->getResourceForUser(self::RESOURCE_TYPE, (string)$boardId, null);
127
+			$resource = $resourceManager->getResourceForUser(self::RESOURCE_TYPE, (string) $boardId, null);
128 128
 			$resourceManager->invalidateAccessCacheForResource($resource);
129 129
 		} else {
130 130
 			$resourceManager->invalidateAccessCacheForProvider($this);
Please login to merge, or discard this patch.
lib/Service/PermissionService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -157,7 +157,7 @@
 block discarded – undo
157 157
 
158 158
 	/**
159 159
 	 * @param $boardId
160
-	 * @return bool
160
+	 * @return boolean|null
161 161
 	 */
162 162
 	public function userIsBoardOwner($boardId, $userId = null) {
163 163
 		if ($userId === null) {
Please login to merge, or discard this patch.
lib/AppInfo/Application.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,6 @@
 block discarded – undo
31 31
 use OCA\Deck\Middleware\ExceptionMiddleware;
32 32
 use OCA\Deck\Notification\Notifier;
33 33
 use OCP\AppFramework\App;
34
-use OCA\Deck\Middleware\SharingMiddleware;
35 34
 use OCP\Collaboration\Resources\IManager;
36 35
 use OCP\Comments\CommentsEntityEvent;
37 36
 use OCP\IGroup;
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
 	 * @throws \OCP\AppFramework\QueryException
156 156
 	 */
157 157
 	protected function registerCommentsEventHandler() {
158
-		$this->getContainer()->getServer()->getCommentsManager()->registerEventHandler(function () {
158
+		$this->getContainer()->getServer()->getCommentsManager()->registerEventHandler(function() {
159 159
 			return $this->getContainer()->query(CommentEventHandler::class);
160 160
 		});
161 161
 	}
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
 		/** @var IManager $resourceManager */
176 176
 		$resourceManager = $this->getContainer()->query(IManager::class);
177 177
 		$resourceManager->registerResourceProvider(\OCA\Deck\Collaboration\Resources\ResourceProvider::class);
178
-		\OC::$server->getEventDispatcher()->addListener('\OCP\Collaboration\Resources::loadAdditionalScripts', function () {
178
+		\OC::$server->getEventDispatcher()->addListener('\OCP\Collaboration\Resources::loadAdditionalScripts', function() {
179 179
 			\OCP\Util::addScript('deck', 'build/collections');
180 180
 		});
181 181
 	}
Please login to merge, or discard this patch.