nextcloud / deck

lib/Middleware/SharingMiddleware.php

Spacing +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
 	 */
 	public function afterException($controller, $methodName, \Exception $exception) {
 		if ($exception instanceof StatusException) {
-			if($this->config->getSystemValue('loglevel', Util::WARN) === Util::DEBUG) {
+			if ($this->config->getSystemValue('loglevel', Util::WARN) === Util::DEBUG) {
 				$this->logger->logException($exception);
 			}
 			return new JSONResponse([

lib/Db/RelationalEntity.php

Doc Comments +2 added lines, -2 removed lines

@@ -30,7 +30,7 @@ 
 
 	/**
 	 * Mark a property as relation so it will not get updated using Mapper::update
-	 * @param $property string Name of the property
+	 * @param string $property string Name of the property
 	 */
 	public function addRelation($property) {
 		if (!in_array($property, $this->_relations)) {
@@ -40,7 +40,7 @@ 
 
 	/**
 	 * Mark a property as resolvable via resolveRelation()
-	 * @param $property string Name of the property
+	 * @param string $property string Name of the property
 	 */
 	public function addResolvable($property) {
 		$this->_resolvedProperties[$property] = null;

Spacing +10 added lines, -10 removed lines

@@ -76,7 +76,7 @@ 
 			}
 		}
 		foreach ($this->_resolvedProperties as $property => $value) {
-			if($value !== null) {
+			if ($value !== null) {
 				$json[$property] = $value;
 			}
 		}
@@ -106,30 +106,30 @@ 
 	 */
 	public function resolveRelation($property, $resolver) {
 		$result = null;
-		if($property !== null && $this->$property !== null) {
+		if ($property !== null && $this->$property !== null) {
 			$result = $resolver($this->$property);
 		}
 
-		if($result instanceof RelationalObject || $result === null) {
+		if ($result instanceof RelationalObject || $result === null) {
 			$this->_resolvedProperties[$property] = $result;
 		} else {
 			throw new \Exception('resolver must return an instance of RelationalObject');
 		}
 	}
 
-	public function __call($methodName, $args){
-		$attr = lcfirst( substr($methodName, 7) );
-		if(strpos($methodName, 'resolve') === 0 && array_key_exists($attr, $this->_resolvedProperties)) {
-			if($this->_resolvedProperties[$attr] !== null) {
+	public function __call($methodName, $args) {
+		$attr = lcfirst(substr($methodName, 7));
+		if (strpos($methodName, 'resolve') === 0 && array_key_exists($attr, $this->_resolvedProperties)) {
+			if ($this->_resolvedProperties[$attr] !== null) {
 				return $this->_resolvedProperties[$attr];
 			} else {
 				return $this->getter($attr);
 			}
 		}
 
-		$attr = lcfirst( substr($methodName, 3) );
-		if(strpos($methodName, 'set') === 0 && array_key_exists($attr, $this->_resolvedProperties)) {
-			if(!is_scalar($args[0])) {
+		$attr = lcfirst(substr($methodName, 3));
+		if (strpos($methodName, 'set') === 0 && array_key_exists($attr, $this->_resolvedProperties)) {
+			if (!is_scalar($args[0])) {
 				$args[0] = $args[0]['primaryKey'];
 			}
 			parent::setter($attr, $args);

lib/Db/RelationalObject.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
 	 * This method should be overwritten if object doesn't implement \JsonSerializable
 	 */
 	public function getObjectSerialization() {
-		if($this->object instanceof \JsonSerializable) {
+		if ($this->object instanceof \JsonSerializable) {
 			$this->object->jsonSerialize();
 		} else {
 			throw new \Exception('jsonSerialize is not implemented on ' . get_class($this));

lib/Service/BoardService.php

Spacing +4 added lines, -4 removed lines

@@ -53,10 +53,10 @@ 
 		$groupBoards = $this->boardMapper->findAllByGroups($userInfo['user'], $userInfo['groups']);
 		$complete = array_merge($userBoards, $groupBoards);
 		$result = [];
-		foreach($complete as &$item) {
-			if(!array_key_exists($item->getId(), $result)) {
+		foreach ($complete as &$item) {
+			if (!array_key_exists($item->getId(), $result)) {
 				$this->boardMapper->mapOwner($item);
-				if($item->getAcl() !== null) {
+				if ($item->getAcl() !== null) {
 					foreach ($item->getAcl() as &$acl) {
 						$this->boardMapper->mapAcl($acl);
 					}
@@ -73,7 +73,7 @@ 
 		$board = $this->boardMapper->find($boardId, true, true);
 		$this->boardMapper->mapOwner($board);
 		foreach ($board->getAcl() as &$acl) {
-			if($acl !== null) {
+			if ($acl !== null) {
 				$this->boardMapper->mapAcl($acl);
 			}
 		}

Unused Use Statements -1 removed lines

@@ -23,7 +23,6 @@
 
 namespace OCA\Deck\Service;
 
-use OCA\Deck\ArchivedItemException;
 use OCA\Deck\Db\Acl;
 use OCA\Deck\Db\AclMapper;
 use OCA\Deck\Db\IPermissionMapper;

lib/Migration/UnknownUsers.php

Spacing +4 added lines, -4 removed lines

@@ -64,15 +64,15 @@
 			$acls = $this->aclMapper->findAll($board->getId());
 			/** @var Acl $acl */
 			foreach ($acls as $acl) {
-				if($acl->getType() === Acl::PERMISSION_TYPE_USER) {
+				if ($acl->getType() === Acl::PERMISSION_TYPE_USER) {
 					$user = $this->userManager->get($acl->getParticipant());
-					if($user === null) {
+					if ($user === null) {
 						$this->aclMapper->delete($acl);
 					}
 				}
-				if($acl->getType() === Acl::PERMISSION_TYPE_GROUP) {
+				if ($acl->getType() === Acl::PERMISSION_TYPE_GROUP) {
 					$group = $this->groupManager->get($acl->getParticipant());
-					if($group === null) {
+					if ($group === null) {
 						$this->aclMapper->delete($acl);
 					}
 				}

lib/AppInfo/Application.php

Unused Use Statements -1 removed lines

@@ -28,7 +28,6 @@
 use OCP\AppFramework\App;
 use OCA\Deck\Middleware\SharingMiddleware;
 use OCP\IGroup;
-use OCP\IGroupManager;
 use OCP\IUser;
 use OCP\IUserManager;
 

lib/Db/CardMapper.php

Spacing +2 added lines, -2 removed lines

@@ -129,11 +129,11 @@
 		return $row['id'];
 	}
 
-	public function mapOwner(Card &$card) {
+	public function mapOwner(Card & $card) {
 		$userManager = $this->userManager;
 		$card->resolveRelation('owner', function($owner) use (&$userManager) {
 			$user = $userManager->get($owner);
-			if($user !== null) {
+			if ($user !== null) {
 				return new User($user);
 			}
 			return null;

lib/Service/StackService.php

Spacing +2 added lines, -2 removed lines

@@ -84,7 +84,7 @@ 
 
 	public function create($title, $boardId, $order) {
 		$this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_MANAGE);
-		if($this->boardService->isArchived(null, $boardId)) {
+		if ($this->boardService->isArchived(null, $boardId)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$stack = new Stack();
@@ -102,7 +102,7 @@ 
 
 	public function update($id, $title, $boardId, $order) {
 		$this->permissionService->checkPermission($this->stackMapper, $id, Acl::PERMISSION_MANAGE);
-		if($this->boardService->isArchived($this->stackMapper, $id)) {
+		if ($this->boardService->isArchived($this->stackMapper, $id)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$stack = $this->stackMapper->find($id);

lib/Service/LabelService.php

Spacing +3 added lines, -3 removed lines

@@ -51,7 +51,7 @@ 
 
 	public function create($title, $color, $boardId) {
 		$this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_MANAGE);
-		if($this->boardService->isArchived(null, $boardId)) {
+		if ($this->boardService->isArchived(null, $boardId)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$label = new Label();
@@ -63,7 +63,7 @@ 
 
 	public function delete($id) {
 		$this->permissionService->checkPermission($this->labelMapper, $id, Acl::PERMISSION_MANAGE);
-		if($this->boardService->isArchived($this->labelMapper, $id)) {
+		if ($this->boardService->isArchived($this->labelMapper, $id)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		return $this->labelMapper->delete($this->find($id));
@@ -71,7 +71,7 @@ 
 
 	public function update($id, $title, $color) {
 		$this->permissionService->checkPermission($this->labelMapper, $id, Acl::PERMISSION_MANAGE);
-		if($this->boardService->isArchived($this->labelMapper, $id)) {
+		if ($this->boardService->isArchived($this->labelMapper, $id)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$label = $this->find($id);