nextcloud / deck

lib/Controller/BoardApiController.php

Unused Use Statements -4 removed lines

@@ -25,12 +25,8 @@
 namespace OCA\Deck\Controller;
 
 use OCP\AppFramework\ApiController;
-use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\DataResponse;
 use OCP\IRequest;
-use OCP\IUserManager;
-use OCP\IGroupManager;
-
 use OCA\Deck\Service\BoardService;
 
 /**

lib/Controller/LabelApiController.php

Indentation +4 added lines, -4 removed lines

@@ -32,10 +32,10 @@
 use OCA\Deck\Controller\Helper\ApiHelper;
 
  /**
- * Class BoardApiController
- *
- * @package OCA\Deck\Controller
- */
+  * Class BoardApiController
+  *
+  * @package OCA\Deck\Controller
+  */
 class LabelApiController extends ApiController {
 
 	private $labelService;

lib/Db/AttachmentMapper.php

Spacing +4 added lines, -4 removed lines

@@ -67,14 +67,14 @@ 
 
 		$cursor = $qb->execute();
 		$row = $cursor->fetch(PDO::FETCH_ASSOC);
-		if($row === false) {
+		if ($row === false) {
 			$cursor->closeCursor();
 			throw new DoesNotExistException('Did expect one result but found none when executing' . $qb);
 		}
 
 		$row2 = $cursor->fetch();
 		$cursor->closeCursor();
-		if($row2 !== false ) {
+		if ($row2 !== false) {
 			throw new MultipleObjectsReturnedException('Did not expect more than one result when executing' . $query);
 		}
 
@@ -97,7 +97,7 @@ 
 
 		$entities = [];
 		$cursor = $qb->execute();
-		while($row = $cursor->fetch()){
+		while ($row = $cursor->fetch()) {
 			$entities[] = $this->mapRowToEntity($row);
 		}
 		$cursor->closeCursor();
@@ -127,7 +127,7 @@ 
 
 		$entities = [];
 		$cursor = $qb->execute();
-		while($row = $cursor->fetch()){
+		while ($row = $cursor->fetch()) {
 			$entities[] = $this->mapRowToEntity($row);
 		}
 		$cursor->closeCursor();

lib/Service/PermissionService.php

Doc Comments +1 added lines, -1 removed lines

@@ -141,7 +141,7 @@
 
 	/**
 	 * @param $boardId
-	 * @return bool
+	 * @return boolean|null
 	 */
 	public function userIsBoardOwner($boardId) {
 		try {

lib/Service/StackService.php

Unused Use Statements -2 removed lines

@@ -31,8 +31,6 @@
 use OCA\Deck\Db\StackMapper;
 use OCA\Deck\StatusException;
 use OCA\Deck\BadRequestException;
-use OCP\ICache;
-use OCP\ICacheFactory;
 
 
 class StackService {

Spacing +1 added lines, -1 removed lines

@@ -183,7 +183,7 @@
 	 */
 	public function delete($id) {
 
-		if ( is_numeric($id) === false ) {
+		if (is_numeric($id) === false) {
 			throw new BadRequestException('stack id must be a number');
 		}
 

lib/Controller/CardApiController.php

Indentation +4 added lines, -4 removed lines

@@ -33,10 +33,10 @@
  use OCA\Deck\Service\CardService;
 
  /**
- * Class BoardApiController
- *
- * @package OCA\Deck\Controller
- */
+  * Class BoardApiController
+  *
+  * @package OCA\Deck\Controller
+  */
 class CardApiController extends ApiController {
 	private $cardService;		
 	private $userId;	

Unused Use Statements -4 removed lines

@@ -24,12 +24,8 @@
  namespace OCA\Deck\Controller;
 
  use OCP\AppFramework\ApiController;
- use OCP\AppFramework\Http;
  use OCP\AppFramework\Http\DataResponse;
  use OCP\IRequest;
- 
- use OCA\Deck\Service\BoardService;
- use OCA\Deck\Service\StackService;
  use OCA\Deck\Service\CardService;
 
  /**

Spacing +1 added lines, -1 removed lines

@@ -143,7 +143,7 @@
 	}
 
 	public function assignUser($userId) {
-		$card = $this->cardService->assignUser($this->request->getParam('cardId'), $userId);;
+		$card = $this->cardService->assignUser($this->request->getParam('cardId'), $userId); ;
 		return new DataResponse($card, HTTP::STATUS_OK);
 	}
 

lib/Controller/AttachmentApiController.php

Indentation +35 added lines, -35 removed lines

@@ -31,76 +31,76 @@
 
 class AttachmentApiController extends ApiController {
 
-    private $attachmentService;
+	private $attachmentService;
 
-    public function __construct($appName, IRequest $request, AttachmentService $attachmentService) {
-        parent::__construct($appName, $request);
-        $this->attachmentService = $attachmentService;
-    }
+	public function __construct($appName, IRequest $request, AttachmentService $attachmentService) {
+		parent::__construct($appName, $request);
+		$this->attachmentService = $attachmentService;
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function getAll() {
-        $attachment = $this->attachmentService->findAll($this->request->getParam('cardId'));
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function getAll() {
+		$attachment = $this->attachmentService->findAll($this->request->getParam('cardId'));
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function display() {
-        $attachment = $this->attachmentService->display($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function display() {
+		$attachment = $this->attachmentService->display($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function create($type, $data) {
-        $attachment = $this->attachmentService->create($this->request->getParam('cardId'), $type, $data);
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function create($type, $data) {
+		$attachment = $this->attachmentService->create($this->request->getParam('cardId'), $type, $data);
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function update($data) {
-        $attachment = $this->attachmentService->update($this->request->getParam('cardId'), $this->request->getParam('attachmentId'), $data);
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function update($data) {
+		$attachment = $this->attachmentService->update($this->request->getParam('cardId'), $this->request->getParam('attachmentId'), $data);
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function delete() {
-        $attachment = $this->attachmentService->delete($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function delete() {
+		$attachment = $this->attachmentService->delete($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 
-    /**
+	/**
 	 * @NoAdminRequired
 	 * @CORS
 	 * @NoCSRFRequired
 	 *
 	 */
-    public function restore() {
-        $attachment = $this->attachmentService->restore($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
-        return new DataResponse($attachment, HTTP::STATUS_OK);
-    }
+	public function restore() {
+		$attachment = $this->attachmentService->restore($this->request->getParam('cardId'), $this->request->getParam('attachmentId'));
+		return new DataResponse($attachment, HTTP::STATUS_OK);
+	}
 }
\ No newline at end of file

appinfo/routes.php

Spacing +1 added lines, -1 removed lines

@@ -112,6 +112,6 @@
 		['name' => 'attachment_api#delete', 'url' => '/api/v1.0/boards/{boardId}/stacks/{stackId}/cards/{cardId}/attachments/{attachmentId}', 'verb' => 'DELETE'],
 		['name' => 'attachment_api#restore', 'url' => '/api/v1.0/boards/{boardId}/stacks/{stackId}/cards/{cardId}/attachments/{attachmentId}/restore', 'verb' => 'PUT'],
 
-		['name' => 'board_api#preflighted_cors', 'url' => '/api/v1.0/{path}','verb' => 'OPTIONS', 'requirements' => ['path' => '.+']],
+		['name' => 'board_api#preflighted_cors', 'url' => '/api/v1.0/{path}', 'verb' => 'OPTIONS', 'requirements' => ['path' => '.+']],
 	]
 ];

lib/Service/DefaultBoardService.php

Indentation +7 added lines, -7 removed lines

@@ -40,7 +40,7 @@ 
 	private $config;
 	private $l10n;
 
-    public function __construct(
+	public function __construct(
 			IL10N $l10n,
 			BoardMapper $boardMapper,
 			BoardService $boardService,
@@ -55,7 +55,7 @@ 
 		$this->config = $config;
 		$this->boardMapper = $boardMapper;
 		$this->l10n = $l10n;
-    }
+	}
 
 	/**
 	 * @param $userId
@@ -73,7 +73,7 @@ 
 		}
 
 		return false;
-    }
+	}
 
 	/**
 	 * @param $title
@@ -100,9 +100,9 @@ 
 			throw new BadRequestException('color must be provided');
 		}
 
-        $defaultBoard = $this->boardService->create($title, $userId, $color);
-        $defaultStacks = [];
-        $defaultCards = [];
+		$defaultBoard = $this->boardService->create($title, $userId, $color);
+		$defaultStacks = [];
+		$defaultCards = [];
 
 		$boardId = $defaultBoard->getId();		
 
@@ -115,5 +115,5 @@ 
 		$defaultCards[] = $this->cardService->create($this->l10n->t('Example Task 1'), $defaultStacks[2]->getId(), 'text', 0, $userId);
 
 		return $defaultBoard;
-    }
+	}
 }
\ No newline at end of file