nextcloud / deck

lib/Middleware/SharingMiddleware.php

Spacing +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
 	 */
 	public function afterException($controller, $methodName, \Exception $exception) {
 		if ($exception instanceof StatusException) {
-			if($this->config->getSystemValue('loglevel', Util::WARN) === Util::DEBUG) {
+			if ($this->config->getSystemValue('loglevel', Util::WARN) === Util::DEBUG) {
 				$this->logger->logException($exception);
 			}
 			return new JSONResponse([

lib/Service/BoardService.php

Spacing +4 added lines, -4 removed lines

@@ -53,10 +53,10 @@ 
 		$groupBoards = $this->boardMapper->findAllByGroups($userInfo['user'], $userInfo['groups']);
 		$complete = array_merge($userBoards, $groupBoards);
 		$result = [];
-		foreach($complete as &$item) {
-			if(!array_key_exists($item->getId(), $result)) {
+		foreach ($complete as &$item) {
+			if (!array_key_exists($item->getId(), $result)) {
 				$this->boardMapper->mapOwner($item);
-				if($item->getAcl() !== null) {
+				if ($item->getAcl() !== null) {
 					foreach ($item->getAcl() as &$acl) {
 						$this->boardMapper->mapAcl($acl);
 					}
@@ -73,7 +73,7 @@ 
 		$board = $this->boardMapper->find($boardId, true, true);
 		$this->boardMapper->mapOwner($board);
 		foreach ($board->getAcl() as &$acl) {
-			if($acl !== null) {
+			if ($acl !== null) {
 				$this->boardMapper->mapAcl($acl);
 			}
 		}

lib/Migration/UnknownUsers.php

Spacing +4 added lines, -4 removed lines

@@ -64,15 +64,15 @@
 			$acls = $this->aclMapper->findAll($board->getId());
 			/** @var Acl $acl */
 			foreach ($acls as $acl) {
-				if($acl->getType() === Acl::PERMISSION_TYPE_USER) {
+				if ($acl->getType() === Acl::PERMISSION_TYPE_USER) {
 					$user = $this->userManager->get($acl->getParticipant());
-					if($user === null) {
+					if ($user === null) {
 						$this->aclMapper->delete($acl);
 					}
 				}
-				if($acl->getType() === Acl::PERMISSION_TYPE_GROUP) {
+				if ($acl->getType() === Acl::PERMISSION_TYPE_GROUP) {
 					$group = $this->groupManager->get($acl->getParticipant());
-					if($group === null) {
+					if ($group === null) {
 						$this->aclMapper->delete($acl);
 					}
 				}

lib/Service/StackService.php

Spacing +2 added lines, -2 removed lines

@@ -84,7 +84,7 @@ 
 
 	public function create($title, $boardId, $order) {
 		$this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_MANAGE);
-		if($this->boardService->isArchived(null, $boardId)) {
+		if ($this->boardService->isArchived(null, $boardId)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$stack = new Stack();
@@ -102,7 +102,7 @@ 
 
 	public function update($id, $title, $boardId, $order) {
 		$this->permissionService->checkPermission($this->stackMapper, $id, Acl::PERMISSION_MANAGE);
-		if($this->boardService->isArchived($this->stackMapper, $id)) {
+		if ($this->boardService->isArchived($this->stackMapper, $id)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$stack = $this->stackMapper->find($id);

Doc Comments +3 added lines

@@ -85,6 +85,9 @@
 		return $stacks;
 	}
 
+	/**
+	 * @param integer $order
+	 */
 	public function create($title, $boardId, $order) {
 		$this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_MANAGE);
 		if($this->boardService->isArchived(null, $boardId)) {

Unused Use Statements -2 removed lines

@@ -27,9 +27,7 @@
 use OCA\Deck\Db\CardMapper;
 use OCA\Deck\Db\LabelMapper;
 use OCA\Deck\Db\AssignedUsersMapper;
-
 use OCA\Deck\Db\Stack;
-
 use OCA\Deck\Db\StackMapper;
 use OCA\Deck\StatusException;
 

lib/Service/LabelService.php

Spacing +3 added lines, -3 removed lines

@@ -51,7 +51,7 @@ 
 
 	public function create($title, $color, $boardId) {
 		$this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_MANAGE);
-		if($this->boardService->isArchived(null, $boardId)) {
+		if ($this->boardService->isArchived(null, $boardId)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$label = new Label();
@@ -63,7 +63,7 @@ 
 
 	public function delete($id) {
 		$this->permissionService->checkPermission($this->labelMapper, $id, Acl::PERMISSION_MANAGE);
-		if($this->boardService->isArchived($this->labelMapper, $id)) {
+		if ($this->boardService->isArchived($this->labelMapper, $id)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		return $this->labelMapper->delete($this->find($id));
@@ -71,7 +71,7 @@ 
 
 	public function update($id, $title, $color) {
 		$this->permissionService->checkPermission($this->labelMapper, $id, Acl::PERMISSION_MANAGE);
-		if($this->boardService->isArchived($this->labelMapper, $id)) {
+		if ($this->boardService->isArchived($this->labelMapper, $id)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$label = $this->find($id);

lib/AppInfo/Application.php

Spacing +1 added lines, -1 removed lines

@@ -100,7 +100,7 @@
 		$self = &$this;
 		$notificationManager->registerNotifier(function() use (&$self) {
 			return $self->getContainer()->query(Notifier::class);
-		}, function () {
+		}, function() {
 			return ['id' => 'deck', 'name' => 'Deck'];
 		});
 

Unused Use Statements -1 removed lines

@@ -29,7 +29,6 @@
 use OCP\AppFramework\App;
 use OCA\Deck\Middleware\SharingMiddleware;
 use OCP\IGroup;
-
 use OCP\IUser;
 use OCP\IUserManager;
 use OCP\IURLGenerator;

lib/Service/CardService.php

Spacing +10 added lines, -10 removed lines

@@ -59,7 +59,7 @@ 
 
 	public function create($title, $stackId, $type, $order, $owner) {
 		$this->permissionService->checkPermission($this->stackMapper, $stackId, Acl::PERMISSION_EDIT);
-		if($this->boardService->isArchived($this->stackMapper, $stackId)) {
+		if ($this->boardService->isArchived($this->stackMapper, $stackId)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$card = new Card();
@@ -74,7 +74,7 @@ 
 
 	public function delete($id) {
 		$this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
-		if($this->boardService->isArchived($this->cardMapper, $id)) {
+		if ($this->boardService->isArchived($this->cardMapper, $id)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		return $this->cardMapper->delete($this->cardMapper->find($id));
@@ -82,7 +82,7 @@ 
 
 	public function update($id, $title, $stackId, $type, $order, $description, $owner, $duedate) {
 		$this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
-		if($this->boardService->isArchived($this->cardMapper, $id)) {
+		if ($this->boardService->isArchived($this->cardMapper, $id)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$card = $this->cardMapper->find($id);
@@ -101,7 +101,7 @@ 
 
 	public function rename($id, $title) {
 		$this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
-		if($this->boardService->isArchived($this->cardMapper, $id)) {
+		if ($this->boardService->isArchived($this->cardMapper, $id)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$card = $this->cardMapper->find($id);
@@ -114,7 +114,7 @@ 
 
 	public function reorder($id, $stackId, $order) {
 		$this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
-		if($this->boardService->isArchived($this->cardMapper, $id)) {
+		if ($this->boardService->isArchived($this->cardMapper, $id)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$cards = $this->cardMapper->findAll($stackId);
@@ -145,7 +145,7 @@ 
 
 	public function archive($id) {
 		$this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
-		if($this->boardService->isArchived($this->cardMapper, $id)) {
+		if ($this->boardService->isArchived($this->cardMapper, $id)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$card = $this->cardMapper->find($id);
@@ -155,7 +155,7 @@ 
 
 	public function unarchive($id) {
 		$this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
-		if($this->boardService->isArchived($this->cardMapper, $id)) {
+		if ($this->boardService->isArchived($this->cardMapper, $id)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$card = $this->cardMapper->find($id);
@@ -165,7 +165,7 @@ 
 
 	public function assignLabel($cardId, $labelId) {
 		$this->permissionService->checkPermission($this->cardMapper, $cardId, Acl::PERMISSION_EDIT);
-		if($this->boardService->isArchived($this->cardMapper, $cardId)) {
+		if ($this->boardService->isArchived($this->cardMapper, $cardId)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$card = $this->cardMapper->find($cardId);
@@ -177,7 +177,7 @@ 
 
 	public function removeLabel($cardId, $labelId) {
 		$this->permissionService->checkPermission($this->cardMapper, $cardId, Acl::PERMISSION_EDIT);
-		if($this->boardService->isArchived($this->cardMapper, $cardId)) {
+		if ($this->boardService->isArchived($this->cardMapper, $cardId)) {
 			throw new StatusException('Operation not allowed. This board is archived.');
 		}
 		$card = $this->cardMapper->find($cardId);
@@ -194,7 +194,7 @@ 
 				return false;
 			}
 		}
-		$assignment  = new AssignedUsers();
+		$assignment = new AssignedUsers();
 		$assignment->setCardId($cardId);
 		$assignment->setParticipant($userId);
 		return $this->assignedUsersMapper->insert($assignment);

Doc Comments +3 added lines

@@ -50,6 +50,9 @@
 		return $card;
 	}
 
+	/**
+	 * @param integer $order
+	 */
 	public function create($title, $stackId, $type, $order, $owner) {
 		$this->permissionService->checkPermission($this->stackMapper, $stackId, Acl::PERMISSION_EDIT);
 		if($this->boardService->isArchived($this->stackMapper, $stackId)) {

lib/Notification/Notifier.php

Spacing +5 added lines, -5 removed lines

@@ -67,25 +67,25 @@ 
 	 */
 	public function prepare(INotification $notification, $languageCode) {
 		$l = $this->l10nFactory->get('deck', $languageCode);
-		if($notification->getApp() !== 'deck') {
+		if ($notification->getApp() !== 'deck') {
 			throw new \InvalidArgumentException();
 		}
 		$notification->setIcon($this->url->getAbsoluteURL($this->url->imagePath('deck', 'deck-dark.svg')));
 		$params = $notification->getSubjectParameters();
 
-		switch($notification->getSubject()) {
+		switch ($notification->getSubject()) {
 			case 'card-overdue':
 				$cardId = $notification->getObjectId();
 				$boardId = $this->cardMapper->findBoardId($cardId);
 				$notification->setParsedSubject(
 					(string) $l->t('The card "%s" on "%s" has reached its due date.', $params)
 				);
-				$notification->setLink($this->url->linkToRouteAbsolute('deck.page.index') . '#!/board/'.$boardId.'//card/'.$cardId.'');
+				$notification->setLink($this->url->linkToRouteAbsolute('deck.page.index') . '#!/board/' . $boardId . '//card/' . $cardId . '');
 				break;
 			case 'board-shared':
 				$boardId = $notification->getObjectId();
 				$initiator = $this->userManager->get($params[1]);
-				if($initiator !== null) {
+				if ($initiator !== null) {
 					$dn = $initiator->getDisplayName();
 				} else {
 					$dn = $params[1];
@@ -103,7 +103,7 @@ 
 						]
 					]
 				);
-				$notification->setLink($this->url->linkToRouteAbsolute('deck.page.index') . '#!/board/'.$boardId.'/');
+				$notification->setLink($this->url->linkToRouteAbsolute('deck.page.index') . '#!/board/' . $boardId . '/');
 				break;
 		}
 		return $notification;

lib/Service/PermissionService.php

Spacing +5 added lines, -5 removed lines

@@ -188,8 +188,8 @@ 
 	 */
 	public function findUsers($boardId) {
 		// cache users of a board so we don't query them for every cards
-		if (array_key_exists((string)$boardId, $this->users)) {
-			return $this->users[(string)$boardId];
+		if (array_key_exists((string) $boardId, $this->users)) {
+			return $this->users[(string) $boardId];
 		}
 		try {
 			$board = $this->boardMapper->find($boardId);
@@ -206,14 +206,14 @@ 
 				$user = $this->userManager->get($acl->getParticipant());
 				$users[$user->getUID()] = new User($user);
 			}
-			if($acl->getType() === Acl::PERMISSION_TYPE_GROUP) {
+			if ($acl->getType() === Acl::PERMISSION_TYPE_GROUP) {
 				$group = $this->groupManager->get($acl->getParticipant());
 				foreach ($group->getUsers() as $user) {
 					$users[$user->getUID()] = new User($user);
 				}
 			}
 		}
-		$this->users[(string)$boardId] = $users;
-		return $this->users[(string)$boardId];
+		$this->users[(string) $boardId] = $users;
+		return $this->users[(string) $boardId];
 	}
 }
\ No newline at end of file

Doc Comments +1 added lines, -1 removed lines

@@ -89,7 +89,7 @@
 	/**
 	 * Get current user permissions for a board
 	 *
-	 * @param Board|Entity $board
+	 * @param Board $board
 	 * @return array|bool
 	 * @internal param $boardId
 	 */