Passed
Pull Request — master (#607)
by Julius
02:49
created
lib/Activity/ActivityManager.php 2 patches
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
 	}
153 153
 
154 154
 	/**
155
-	 * @param $subjectIdentifier
155
+	 * @param string $subjectIdentifier
156 156
 	 * @param array $subjectParams
157 157
 	 * @param bool $ownActivity
158 158
 	 * @return string
@@ -263,6 +263,9 @@  discard block
 block discarded – undo
263 263
 		return $subject;
264 264
 	}
265 265
 
266
+	/**
267
+	 * @param \OCP\AppFramework\Db\Entity $entity
268
+	 */
266 269
 	public function triggerEvent($objectType, $entity, $subject, $additionalParams = []) {
267 270
 		try {
268 271
 			$event = $this->createEvent($objectType, $entity, $subject, $additionalParams);
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 		$subject = '';
135 135
 		switch ($subjectIdentifier) {
136 136
 			case self::SUBJECT_BOARD_CREATE:
137
-				$subject = $ownActivity ? $this->l10n->t('You have created a new board {board}'): $this->l10n->t('{user} has created a new board {board}');
137
+				$subject = $ownActivity ? $this->l10n->t('You have created a new board {board}') : $this->l10n->t('{user} has created a new board {board}');
138 138
 				break;
139 139
 			case self::SUBJECT_BOARD_DELETE:
140 140
 				$subject = $ownActivity ? $this->l10n->t('You have deleted the board {board}') : $this->l10n->t('{user} has deleted the board {board}');
@@ -360,7 +360,7 @@  discard block
 block discarded – undo
360 360
 				break;
361 361
 		}
362 362
 
363
-		if ($subject === self::SUBJECT_CARD_UPDATE_DESCRIPTION){
363
+		if ($subject === self::SUBJECT_CARD_UPDATE_DESCRIPTION) {
364 364
 			$subjectParams['diff'] = true;
365 365
 		}
366 366
 		if ($subject === self::SUBJECT_CARD_UPDATE_STACKID) {
@@ -371,7 +371,7 @@  discard block
 block discarded – undo
371 371
 		$event->setApp('deck')
372 372
 			->setType('deck')
373 373
 			->setAuthor($this->userId)
374
-			->setObject($objectType, (int)$object->getId(), $object->getTitle())
374
+			->setObject($objectType, (int) $object->getId(), $object->getTitle())
375 375
 			->setSubject($subject, array_merge($subjectParams, $additionalParams))
376 376
 			->setTimestamp(time());
377 377
 
@@ -426,7 +426,7 @@  discard block
 block discarded – undo
426 426
 					$objectId = $entity->getCardId();
427 427
 					break;
428 428
 				default:
429
-					throw new InvalidArgumentException('No entity relation present for '. $className . ' to ' . $objectType);
429
+					throw new InvalidArgumentException('No entity relation present for ' . $className . ' to ' . $objectType);
430 430
 			}
431 431
 			return $this->cardMapper->find($objectId);
432 432
 		}
@@ -441,11 +441,11 @@  discard block
 block discarded – undo
441 441
 					$objectId = $entity->getBoardId();
442 442
 					break;
443 443
 				default:
444
-					throw new InvalidArgumentException('No entity relation present for '. $className . ' to ' . $objectType);
444
+					throw new InvalidArgumentException('No entity relation present for ' . $className . ' to ' . $objectType);
445 445
 			}
446 446
 			return $this->boardMapper->find($objectId);
447 447
 		}
448
-		throw new InvalidArgumentException('No entity relation present for '. $className . ' to ' . $objectType);
448
+		throw new InvalidArgumentException('No entity relation present for ' . $className . ' to ' . $objectType);
449 449
 	}
450 450
 
451 451
 	private function findDetailsForStack($stackId) {
Please login to merge, or discard this patch.
lib/Service/BoardService.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 	 */
122 122
 	public function find($boardId) {
123 123
 
124
-		if ( is_numeric($boardId) === false ) {
124
+		if (is_numeric($boardId) === false) {
125 125
 			throw new BadRequestException('board id must be a number');
126 126
 		}
127 127
 
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
 	 */
171 171
 	public function isArchived($mapper, $id) {
172 172
 
173
-		if (is_numeric($id) === false)  {
173
+		if (is_numeric($id) === false) {
174 174
 			throw new BadRequestException('id must be a number');
175 175
 		}
176 176
 
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
 			throw new BadRequestException('mapper must be provided');
205 205
 		}
206 206
 
207
-		if (is_numeric($id) === false)  {
207
+		if (is_numeric($id) === false) {
208 208
 			throw new BadRequestException('id must be a number');
209 209
 		}
210 210
 
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
 	 * @throws BadRequestException
336 336
 	 */
337 337
 	public function deleteForce($id) {
338
-		if (is_numeric($id) === false)  {
338
+		if (is_numeric($id) === false) {
339 339
 			throw new BadRequestException('id must be a number');
340 340
 		}
341 341
 
@@ -369,7 +369,7 @@  discard block
 block discarded – undo
369 369
 			throw new BadRequestException('color must be provided');
370 370
 		}
371 371
 
372
-		if ( is_bool($archived) === false ) {
372
+		if (is_bool($archived) === false) {
373 373
 			throw new BadRequestException('archived must be a boolean');
374 374
 		}
375 375
 
Please login to merge, or discard this patch.
appinfo/app.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@
 block discarded – undo
21 21
  *
22 22
  */
23 23
 
24
-if ((@include_once __DIR__ . '/../vendor/autoload.php')===false) {
24
+if ((@include_once __DIR__ . '/../vendor/autoload.php') === false) {
25 25
 	throw new Exception('Cannot include autoload. Did you run install dependencies using composer?');
26 26
 }
27 27
 
Please login to merge, or discard this patch.
lib/Service/StackService.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 	private function enrichStackWithCards($stack) {
77 77
 		$cards = $this->cardMapper->findAll($stack->getId());
78 78
 
79
-		if(is_null($cards)) {
79
+		if (is_null($cards)) {
80 80
 			return;
81 81
 		}
82 82
 
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
 	 */
216 216
 	public function delete($id) {
217 217
 
218
-		if ( is_numeric($id) === false ) {
218
+		if (is_numeric($id) === false) {
219 219
 			throw new BadRequestException('stack id must be a number');
220 220
 		}
221 221
 
Please login to merge, or discard this patch.
lib/Activity/DeckProvider.php 1 patch
Doc Comments   +14 added lines patch added patch discarded remove patch
@@ -166,6 +166,9 @@  discard block
 block discarded – undo
166 166
 		return $event;
167 167
 	}
168 168
 
169
+	/**
170
+	 * @param string $paramName
171
+	 */
169 172
 	private function parseParamForBoard($paramName, $subjectParams, $params) {
170 173
 		if (array_key_exists($paramName, $subjectParams)) {
171 174
 			$params[$paramName] = [
@@ -177,6 +180,10 @@  discard block
 block discarded – undo
177 180
 		}
178 181
 		return $params;
179 182
 	}
183
+
184
+	/**
185
+	 * @param string $paramName
186
+	 */
180 187
 	private function parseParamForStack($paramName, $subjectParams, $params) {
181 188
 		if (array_key_exists($paramName, $subjectParams)) {
182 189
 			$params[$paramName] = [
@@ -188,6 +195,9 @@  discard block
 block discarded – undo
188 195
 		return $params;
189 196
 	}
190 197
 
198
+	/**
199
+	 * @param string $paramName
200
+	 */
191 201
 	private function parseParamForAttachment($paramName, $subjectParams, $params) {
192 202
 		if (array_key_exists($paramName, $subjectParams)) {
193 203
 			$params[$paramName] = [
@@ -226,6 +236,7 @@  discard block
 block discarded – undo
226 236
 	 *
227 237
 	 * @param $subjectParams
228 238
 	 * @param $params
239
+	 * @param IEvent $event
229 240
 	 * @return mixed
230 241
 	 */
231 242
 	private function parseParamForChanges($subjectParams, $params, $event) {
@@ -252,6 +263,9 @@  discard block
 block discarded – undo
252 263
 		return $params;
253 264
 	}
254 265
 
266
+	/**
267
+	 * @param string $endpoint
268
+	 */
255 269
 	public function deckUrl($endpoint) {
256 270
 		return $this->urlGenerator->linkToRoute('deck.page.index') . '#!' . $endpoint;
257 271
 	}
Please login to merge, or discard this patch.