nextcloud / deck

lib/Db/Group.php

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
 namespace OCA\Deck\Db;
 
 use OCP\IGroup;
-use OCP\IUser;
 
 class Group extends RelationalObject {
 

lib/Db/RelationalEntity.php

Doc Comments +7 added lines

@@ -47,6 +47,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $property
+	 */
 	public function addResolvable($property) {
 		$this->_resolvedProperties[$property] = null;
 	}
@@ -63,6 +66,10 @@ 
 		}
 	}
 
+	/**
+	 * @param string $property
+	 * @param \Closure $resolver
+	 */
 	public function resolveRelation($property, $resolver) {
 		if($property !== null && $this->$property !== null) {
 			$result = $resolver($this->$property);

Spacing +9 added lines, -9 removed lines

@@ -64,32 +64,32 @@
 	}
 
 	public function resolveRelation($property, $resolver) {
-		if($property !== null && $this->$property !== null) {
+		if ($property !== null && $this->$property !== null) {
 			$result = $resolver($this->$property);
 		} else {
 			$result = null;
 		}
 
-		if($result instanceof RelationalObject || $result === null) {
+		if ($result instanceof RelationalObject || $result === null) {
 			$this->_resolvedProperties[$property] = $result;
 		} else {
 			throw new \Exception('resolver must return an instance of RelationalObject');
 		}
 	}
 
-	public function __call($methodName, $args){
-		$attr = lcfirst( substr($methodName, 7) );
-		if(strpos($methodName, 'resolve') === 0 && array_key_exists($attr, $this->_resolvedProperties)) {
-			if($this->_resolvedProperties[$attr] !== null) {
+	public function __call($methodName, $args) {
+		$attr = lcfirst(substr($methodName, 7));
+		if (strpos($methodName, 'resolve') === 0 && array_key_exists($attr, $this->_resolvedProperties)) {
+			if ($this->_resolvedProperties[$attr] !== null) {
 				return $this->_resolvedProperties[$attr];
 			} else {
 				return $this->getter($attr, $args);
 			}
 		}
 
-		$attr = lcfirst( substr($methodName, 3) );
-		if(strpos($methodName, 'set') === 0 && array_key_exists($attr, $this->_resolvedProperties)) {
-			if(!is_scalar($args[0])) {
+		$attr = lcfirst(substr($methodName, 3));
+		if (strpos($methodName, 'set') === 0 && array_key_exists($attr, $this->_resolvedProperties)) {
+			if (!is_scalar($args[0])) {
 				$args[0] = $args[0]['primaryKey'];
 				parent::setter($attr, $args);
 			}

lib/Db/User.php

Unused Use Statements -1 removed lines

@@ -23,7 +23,6 @@
 
 namespace OCA\Deck\Db;
 
-use OCP\IGroup;
 use OCP\IUser;
 
 class User extends RelationalObject {

lib/Service/BoardService.php

Unused Use Statements -3 removed lines

@@ -27,12 +27,9 @@
 use OCA\Deck\Db\AclMapper;
 use OCA\Deck\Db\Group;
 use OCA\Deck\Db\Label;
-
-
 use OCA\Deck\Db\User;
 use OCP\IGroupManager;
 use OCP\IL10N;
-
 use OCA\Deck\Db\Board;
 use OCA\Deck\Db\BoardMapper;
 use OCA\Deck\Db\LabelMapper;

Spacing +7 added lines, -7 removed lines

@@ -62,10 +62,10 @@ 
 		$groupBoards = $this->boardMapper->findAllByGroups($userInfo['user'], $userInfo['groups']);
 		$complete = array_merge($userBoards, $groupBoards);
 		$result = [];
-		foreach($complete as &$item) {
-			if(!array_key_exists($item->getId(), $result)) {
+		foreach ($complete as &$item) {
+			if (!array_key_exists($item->getId(), $result)) {
 				$item = $this->mapOwner($item);
-				if($item->getAcl() !== null) {
+				if ($item->getAcl() !== null) {
 					foreach ($item->getAcl() as &$acl) {
 						$acl = $this->mapAcl($acl);
 					}
@@ -81,21 +81,21 @@ 
 		$board = $this->boardMapper->find($boardId, true, true);
 		$board = $this->mapOwner($board);
 		foreach ($board->getAcl() as &$acl) {
-			if($acl !== null) {
+			if ($acl !== null) {
 				$this->mapAcl($acl);
 			}
 		}
 		return $board;
 	}
 
-	private function mapAcl(Acl &$acl) {
+	private function mapAcl(Acl & $acl) {
 		$userManager = $this->userManager;
 		$groupManager = $this->groupManager;
 		$acl->resolveRelation('participant', function($value) use (&$acl, &$userManager, &$groupManager) {
-			if($acl->getType() === Acl::PERMISSION_TYPE_USER) {
+			if ($acl->getType() === Acl::PERMISSION_TYPE_USER) {
 				return new User($userManager->get($acl->getParticipant($value)));
 			}
-			if($acl->getType() === Acl::PERMISSION_TYPE_GROUP) {
+			if ($acl->getType() === Acl::PERMISSION_TYPE_GROUP) {
 				return new Group($groupManager->get($acl->getParticipant($value)));
 			}
 		});

lib/Controller/ShareController.php

Spacing +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
 	 * @return array
 	 */
 	public function searchUser($search) {
-		if($search==='%') {
+		if ($search === '%') {
 			$search = '';
 		}
 		$limit = 5;