Completed
Pull Request — master (#1480)
by Julius
03:46
created
lib/Collaboration/Resources/ResourceProviderCard.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@
 block discarded – undo
134 134
 	}
135 135
 
136 136
 	/**
137
-	 * @param $cardId
137
+	 * @param string $cardId
138 138
 	 * @return Board
139 139
 	 * @throws DoesNotExistException
140 140
 	 * @throws MultipleObjectsReturnedException
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -151,7 +151,7 @@
 block discarded – undo
151 151
 		} catch (QueryException $e) {
152 152
 		}
153 153
 		if ($cardId !== null) {
154
-			$resource = $resourceManager->getResourceForUser(self::RESOURCE_TYPE, (string)$cardId, null);
154
+			$resource = $resourceManager->getResourceForUser(self::RESOURCE_TYPE, (string) $cardId, null);
155 155
 			$resourceManager->invalidateAccessCacheForResource($resource);
156 156
 		} else {
157 157
 			$resourceManager->invalidateAccessCacheForProvider($this);
Please login to merge, or discard this patch.
lib/Service/BoardService.php 1 patch
Doc Comments   +10 added lines, -1 removed lines patch added patch discarded remove patch
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
180 180
 	}
181 181
 
182 182
 	/**
183
-	 * @return array
183
+	 * @return integer
184 184
 	 */
185 185
 	private function getBoardPrerequisites() {
186 186
 		$groups = $this->groupManager->getUserGroupIds(
@@ -658,6 +658,9 @@  discard block
 block discarded – undo
658 658
 		return $newBoard;
659 659
 	}
660 660
 
661
+	/**
662
+	 * @param Board $board
663
+	 */
661 664
 	private function enrichWithStacks($board, $since = -1) {
662 665
 		$stacks = $this->stackMapper->findAll($board->getId(), null, null, $since);
663 666
 
@@ -668,6 +671,9 @@  discard block
 block discarded – undo
668 671
 		$board->setStacks($stacks);
669 672
 	}
670 673
 
674
+	/**
675
+	 * @param Board $board
676
+	 */
671 677
 	private function enrichWithLabels($board, $since = -1) {
672 678
 		$labels = $this->labelMapper->findAll($board->getId(), null, null, $since);
673 679
 
@@ -678,6 +684,9 @@  discard block
 block discarded – undo
678 684
 		$board->setLabels($labels);
679 685
 	}
680 686
 
687
+	/**
688
+	 * @param Board $board
689
+	 */
681 690
 	private function enrichWithUsers($board, $since = -1) {
682 691
 		$boardUsers = $this->permissionService->findUsers($board->getId());
683 692
 		if(\count($boardUsers) === 0) {
Please login to merge, or discard this patch.
lib/Service/CardService.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
 	/**
148 148
 	 * @param $title
149 149
 	 * @param $stackId
150
-	 * @param $type
150
+	 * @param string $type
151 151
 	 * @param integer $order
152 152
 	 * @param $description
153 153
 	 * @param $owner
@@ -576,7 +576,7 @@  discard block
 block discarded – undo
576 576
 	/**
577 577
 	 * @param $cardId
578 578
 	 * @param $userId
579
-	 * @return bool|null|\OCP\AppFramework\Db\Entity
579
+	 * @return AssignedUsers|null
580 580
 	 * @throws BadRequestException
581 581
 	 * @throws \OCA\Deck\NoPermissionException
582 582
 	 * @throws \OCP\AppFramework\Db\DoesNotExistException
Please login to merge, or discard this patch.
lib/AppInfo/Application.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
 	 * @throws \OCP\AppFramework\QueryException
168 168
 	 */
169 169
 	protected function registerCommentsEventHandler() {
170
-		$this->getContainer()->getServer()->getCommentsManager()->registerEventHandler(function () {
170
+		$this->getContainer()->getServer()->getCommentsManager()->registerEventHandler(function() {
171 171
 			return $this->getContainer()->query(CommentEventHandler::class);
172 172
 		});
173 173
 	}
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
 		$resourceManager->registerResourceProvider(\OCA\Deck\Collaboration\Resources\ResourceProvider::class);
197 197
 		$resourceManager->registerResourceProvider(\OCA\Deck\Collaboration\Resources\ResourceProviderCard::class);
198 198
 
199
-		\OC::$server->getEventDispatcher()->addListener('\OCP\Collaboration\Resources::loadAdditionalScripts', function () {
199
+		\OC::$server->getEventDispatcher()->addListener('\OCP\Collaboration\Resources::loadAdditionalScripts', function() {
200 200
 			\OCP\Util::addScript('deck', 'collections');
201 201
 		});
202 202
 	}
Please login to merge, or discard this patch.
lib/Controller/CardController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
 	 * @return array
56 56
 	 */
57 57
 	public function reorder($cardId, $stackId, $order) {
58
-		return $this->cardService->reorder((int)$cardId, (int)$stackId, (int)$order);
58
+		return $this->cardService->reorder((int) $cardId, (int) $stackId, (int) $order);
59 59
 	}
60 60
 
61 61
 	/**
Please login to merge, or discard this patch.
lib/Controller/StackController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@
 block discarded – undo
88 88
 	 * @return array
89 89
 	 */
90 90
 	public function reorder($stackId, $order) {
91
-		return $this->stackService->reorder((int)$stackId, (int)$order);
91
+		return $this->stackService->reorder((int) $stackId, (int) $order);
92 92
 	}
93 93
 
94 94
 	/**
Please login to merge, or discard this patch.