Passed
Pull Request — master (#1545)
by Julius
03:01
created
lib/DAV/CalendarObject.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -94,6 +94,7 @@
 block discarded – undo
94 94
 
95 95
 	/**
96 96
 	 * @inheritDoc
97
+	 * @return string
97 98
 	 */
98 99
 	function get() {
99 100
 		if ($this->card) {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -23,8 +23,6 @@
 block discarded – undo
23 23
 namespace OCA\Deck\DAV;
24 24
 
25 25
 use OCA\Deck\Db\Card;
26
-use OCA\Deck\Service\CardService;
27
-use Sabre\VObject\Component\VCalendar;
28 26
 
29 27
 class CalendarObject implements \Sabre\CalDAV\ICalendarObject, \Sabre\DAVACL\IACL {
30 28
 
Please login to merge, or discard this patch.
lib/Service/CardService.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -99,6 +99,9 @@  discard block
 block discarded – undo
99 99
 		$this->currentUser = $userId;
100 100
 	}
101 101
 
102
+	/**
103
+	 * @param \OCP\AppFramework\Db\Entity $card
104
+	 */
102 105
 	public function enrich($card) {
103 106
 		$cardId = $card->getId();
104 107
 		$this->cardMapper->mapOwner($card);
@@ -153,7 +156,7 @@  discard block
 block discarded – undo
153 156
 	/**
154 157
 	 * @param $title
155 158
 	 * @param $stackId
156
-	 * @param $type
159
+	 * @param string $type
157 160
 	 * @param integer $order
158 161
 	 * @param $description
159 162
 	 * @param $owner
@@ -582,7 +585,7 @@  discard block
 block discarded – undo
582 585
 	/**
583 586
 	 * @param $cardId
584 587
 	 * @param $userId
585
-	 * @return bool|null|\OCP\AppFramework\Db\Entity
588
+	 * @return AssignedUsers|null
586 589
 	 * @throws BadRequestException
587 590
 	 * @throws \OCA\Deck\NoPermissionException
588 591
 	 * @throws \OCP\AppFramework\Db\DoesNotExistException
Please login to merge, or discard this patch.
lib/DAV/Calendar.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
 	 */
121 121
 	function calendarQuery(array $filters) {
122 122
 		// In a real implementation this should actually filter
123
-		return array_map(function (Card $card) {
123
+		return array_map(function(Card $card) {
124 124
 			return $card->getId() . '.ics';
125 125
 		}, $this->children);
126 126
 	}
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
 		if ($this->childExists($name)) {
140 140
 			$card = array_values(array_filter(
141 141
 				$this->children,
142
-				function ($card) use (&$name) {
142
+				function($card) use (&$name) {
143 143
 					return $card->getId() . '.ics' === $name;
144 144
 				}
145 145
 			));
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
 	 * @inheritDoc
154 154
 	 */
155 155
 	function getChildren() {
156
-		$childNames = array_map(function (Card $card) {
156
+		$childNames = array_map(function(Card $card) {
157 157
 			return $card->getId() . '.ics';
158 158
 		}, $this->children);
159 159
 
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
 	function childExists($name) {
173 173
 		return count(array_filter(
174 174
 			$this->children,
175
-			function ($card) use (&$name) {
175
+			function($card) use (&$name) {
176 176
 				return $card->getId() . '.ics' === $name;
177 177
 			}
178 178
 		)) > 0;
Please login to merge, or discard this patch.
lib/DAV/CalendarPlugin.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
 	 */
52 52
 	public function fetchAllForCalendarHome(string $principalUri): array {
53 53
 		$boards = $this->boardService->findAll();
54
-		return array_map(function (Board $board) use ($principalUri) {
54
+		return array_map(function(Board $board) use ($principalUri) {
55 55
 			return new Calendar($principalUri, 'board-' . $board->getId(), $board);
56 56
 		}, $boards);
57 57
 	}
Please login to merge, or discard this patch.