Completed
Pull Request — master (#449)
by Maxence
01:59
created
lib/Db/CircleProviderRequestBuilder.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@
 block discarded – undo
114 114
 	 * limit the request to the children of a share
115 115
 	 *
116 116
 	 * @param IQueryBuilder $qb
117
-	 * @param $userId
117
+	 * @param string $userId
118 118
 	 * @param int $parentId
119 119
 	 */
120 120
 	protected function limitToShareChildren(IQueryBuilder $qb, $userId, $parentId = -1) {
Please login to merge, or discard this patch.
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 		$pf = ($qb->getType() === QueryBuilder::SELECT) ? 's.' : '';
78 78
 		$qb->andWhere(
79 79
 			$expr->in(
80
-				$pf . 'share_with',
80
+				$pf.'share_with',
81 81
 				$qb->createNamedParameter($circleUniqueIds, IQueryBuilder::PARAM_STR_ARRAY)
82 82
 			)
83 83
 		);
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 		$expr = $qb->expr();
95 95
 		$pf = ($qb->getType() === QueryBuilder::SELECT) ? 's.' : '';
96 96
 
97
-		$qb->andWhere($expr->eq($pf . 'id', $qb->createNamedParameter($shareId)));
97
+		$qb->andWhere($expr->eq($pf.'id', $qb->createNamedParameter($shareId)));
98 98
 	}
99 99
 
100 100
 
@@ -142,8 +142,8 @@  discard block
 block discarded – undo
142 142
 
143 143
 		$qb->andWhere(
144 144
 			$expr->orX(
145
-				$expr->eq($pf . 'parent', $qb->createNamedParameter($circleId)),
146
-				$expr->eq($pf . 'id', $qb->createNamedParameter($circleId))
145
+				$expr->eq($pf.'parent', $qb->createNamedParameter($circleId)),
146
+				$expr->eq($pf.'id', $qb->createNamedParameter($circleId))
147 147
 			)
148 148
 		);
149 149
 	}
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
 		$pf = ($qb->getType() === QueryBuilder::SELECT) ? 's.' : '';
166 166
 		$qb->andWhere(
167 167
 			$expr->in(
168
-				$pf . 'file_source',
168
+				$pf.'file_source',
169 169
 				$qb->createNamedParameter($files, IQueryBuilder::PARAM_INT_ARRAY)
170 170
 			)
171 171
 		);
@@ -198,12 +198,12 @@  discard block
 block discarded – undo
198 198
 		$pf = ($qb->getType() === QueryBuilder::SELECT) ? 's.' : '';
199 199
 
200 200
 		if ($reShares === false) {
201
-			$qb->andWhere($expr->eq($pf . 'uid_initiator', $qb->createNamedParameter($userId)));
201
+			$qb->andWhere($expr->eq($pf.'uid_initiator', $qb->createNamedParameter($userId)));
202 202
 		} else {
203 203
 			$qb->andWhere(
204 204
 				$expr->orX(
205
-					$expr->eq($pf . 'uid_owner', $qb->createNamedParameter($userId)),
206
-					$expr->eq($pf . 'uid_initiator', $qb->createNamedParameter($userId))
205
+					$expr->eq($pf.'uid_owner', $qb->createNamedParameter($userId)),
206
+					$expr->eq($pf.'uid_initiator', $qb->createNamedParameter($userId))
207 207
 				)
208 208
 			);
209 209
 		}
@@ -298,11 +298,11 @@  discard block
 block discarded – undo
298 298
 		$expr = $qb->expr();
299 299
 		$andX = $expr->andX();
300 300
 
301
-		$andX->add($expr->eq($aliasM . '.user_id', $qb->createNamedParameter($userId)));
302
-		$andX->add($expr->eq($aliasM . '.circle_id', $aliasC . '.unique_id'));
303
-		$andX->add($expr->gte($aliasM . '.level', $qb->createNamedParameter(Member::LEVEL_MEMBER)));
304
-		$andX->add($expr->eq($aliasM . '.instance', $qb->createNamedParameter('')));
305
-		$andX->add($expr->eq($aliasM . '.user_type', $qb->createNamedParameter(Member::TYPE_USER)));
301
+		$andX->add($expr->eq($aliasM.'.user_id', $qb->createNamedParameter($userId)));
302
+		$andX->add($expr->eq($aliasM.'.circle_id', $aliasC.'.unique_id'));
303
+		$andX->add($expr->gte($aliasM.'.level', $qb->createNamedParameter(Member::LEVEL_MEMBER)));
304
+		$andX->add($expr->eq($aliasM.'.instance', $qb->createNamedParameter('')));
305
+		$andX->add($expr->eq($aliasM.'.user_type', $qb->createNamedParameter(Member::TYPE_USER)));
306 306
 
307 307
 		return $andX;
308 308
 	}
@@ -330,11 +330,11 @@  discard block
 block discarded – undo
330 330
 
331 331
 		$andX = $expr->andX();
332 332
 
333
-		$andX->add($expr->eq($aliasM . '.user_id', 'ncgu.gid'));
334
-		$andX->add($expr->eq($aliasM . '.user_type', $qb->createNamedParameter(Member::TYPE_GROUP)));
335
-		$andX->add($expr->eq($aliasM . '.instance', $qb->createNamedParameter('')));
336
-		$andX->add($expr->eq($aliasM . '.circle_id', $aliasC . '.unique_id'));
337
-		$andX->add($expr->gte($aliasM . '.level', $qb->createNamedParameter(Member::LEVEL_MEMBER)));
333
+		$andX->add($expr->eq($aliasM.'.user_id', 'ncgu.gid'));
334
+		$andX->add($expr->eq($aliasM.'.user_type', $qb->createNamedParameter(Member::TYPE_GROUP)));
335
+		$andX->add($expr->eq($aliasM.'.instance', $qb->createNamedParameter('')));
336
+		$andX->add($expr->eq($aliasM.'.circle_id', $aliasC.'.unique_id'));
337
+		$andX->add($expr->gte($aliasM.'.level', $qb->createNamedParameter(Member::LEVEL_MEMBER)));
338 338
 
339 339
 		return $andX;
340 340
 	}
Please login to merge, or discard this patch.
lib/Db/MembersRequest.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
 	 * returns the index of a specific UserID in a Members List
317 317
 	 *
318 318
 	 * @param array $members
319
-	 * @param $userId
319
+	 * @param string $userId
320 320
 	 *
321 321
 	 * @return int
322 322
 	 */
@@ -656,6 +656,9 @@  discard block
 block discarded – undo
656 656
 	}
657 657
 
658 658
 
659
+	/**
660
+	 * @param string $groupId
661
+	 */
659 662
 	public function unlinkAllFromGroup($groupId) {
660 663
 		$qb = $this->getMembersDeleteSql();
661 664
 
Please login to merge, or discard this patch.
lib/Db/CoreRequestBuilder.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -344,8 +344,8 @@  discard block
 block discarded – undo
344 344
 		$expr = $qb->expr();
345 345
 
346 346
 		if ($pf === '') {
347
-			$p = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias . '.' : '';
348
-			$qb->andWhere($expr->gte($p . 'level', $qb->createNamedParameter($level)));
347
+			$p = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias.'.' : '';
348
+			$qb->andWhere($expr->gte($p.'level', $qb->createNamedParameter($level)));
349 349
 
350 350
 			return;
351 351
 		}
@@ -373,7 +373,7 @@  discard block
 block discarded – undo
373 373
 			if ($p === 'g' && !$this->leftJoinedNCGroupAndUser) {
374 374
 				continue;
375 375
 			}
376
-			$orX->add($expr->gte($p . '.level', $qb->createNamedParameter($level)));
376
+			$orX->add($expr->gte($p.'.level', $qb->createNamedParameter($level)));
377 377
 		}
378 378
 
379 379
 		return $orX;
@@ -388,12 +388,12 @@  discard block
 block discarded – undo
388 388
 	protected function limitToMembersAndAlmost(IQueryBuilder &$qb) {
389 389
 		$expr = $qb->expr();
390 390
 
391
-		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias . '.' : '';
391
+		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias.'.' : '';
392 392
 
393 393
 		$orX = $expr->orX();
394
-		$orX->add($expr->eq($pf . 'status', $qb->createNamedParameter(Member::STATUS_MEMBER)));
395
-		$orX->add($expr->eq($pf . 'status', $qb->createNamedParameter(Member::STATUS_INVITED)));
396
-		$orX->add($expr->eq($pf . 'status', $qb->createNamedParameter(Member::STATUS_REQUEST)));
394
+		$orX->add($expr->eq($pf.'status', $qb->createNamedParameter(Member::STATUS_MEMBER)));
395
+		$orX->add($expr->eq($pf.'status', $qb->createNamedParameter(Member::STATUS_INVITED)));
396
+		$orX->add($expr->eq($pf.'status', $qb->createNamedParameter(Member::STATUS_REQUEST)));
397 397
 
398 398
 		$qb->andWhere($orX);
399 399
 	}
@@ -406,8 +406,8 @@  discard block
 block discarded – undo
406 406
 	 */
407 407
 	private function limitToDBField(IQueryBuilder &$qb, $field, $value) {
408 408
 		$expr = $qb->expr();
409
-		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias . '.' : '';
410
-		$qb->andWhere($expr->eq($pf . $field, $qb->createNamedParameter($value)));
409
+		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias.'.' : '';
410
+		$qb->andWhere($expr->eq($pf.$field, $qb->createNamedParameter($value)));
411 411
 	}
412 412
 
413 413
 
@@ -418,8 +418,8 @@  discard block
 block discarded – undo
418 418
 	 */
419 419
 	private function limitToDBFieldOrGreater(IQueryBuilder &$qb, $field, $value) {
420 420
 		$expr = $qb->expr();
421
-		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias . '.' : '';
422
-		$qb->andWhere($expr->gte($pf . $field, $qb->createNamedParameter($value)));
421
+		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias.'.' : '';
422
+		$qb->andWhere($expr->gte($pf.$field, $qb->createNamedParameter($value)));
423 423
 	}
424 424
 
425 425
 
@@ -434,9 +434,9 @@  discard block
 block discarded – undo
434 434
 	protected function limitToNCGroupUser(IQueryBuilder $qb, $userId = '') {
435 435
 		$expr = $qb->expr();
436 436
 
437
-		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias . '.' : '';
437
+		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias.'.' : '';
438 438
 
439
-		$and = $expr->andX($expr->eq($pf . 'user_id', 'ncgu.gid'));
439
+		$and = $expr->andX($expr->eq($pf.'user_id', 'ncgu.gid'));
440 440
 		if ($userId !== '') {
441 441
 			$and->add($expr->eq('ncgu.uid', $qb->createNamedParameter($userId)));
442 442
 		} else {
@@ -459,14 +459,14 @@  discard block
 block discarded – undo
459 459
 		}
460 460
 
461 461
 		$expr = $qb->expr();
462
-		$pf = $this->default_select_alias . '.';
462
+		$pf = $this->default_select_alias.'.';
463 463
 
464 464
 		/** @noinspection PhpMethodParametersCountMismatchInspection */
465 465
 		$qb->selectAlias('lc.type', 'circle_type')
466 466
 		   ->selectAlias('lc.name', 'circle_name')
467 467
 		   ->leftJoin(
468 468
 			   $this->default_select_alias, CoreRequestBuilder::TABLE_CIRCLES, 'lc',
469
-			   $expr->eq($pf . 'circle_id', 'lc.unique_id')
469
+			   $expr->eq($pf.'circle_id', 'lc.unique_id')
470 470
 		   );
471 471
 	}
472 472
 
Please login to merge, or discard this patch.
lib/Db/CirclesRequestBuilder.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -243,7 +243,7 @@  discard block
 block discarded – undo
243 243
 		}
244 244
 
245 245
 		$expr = $qb->expr();
246
-		$pf = '' . $this->default_select_alias . '.';
246
+		$pf = ''.$this->default_select_alias.'.';
247 247
 
248 248
 		/** @noinspection PhpMethodParametersCountMismatchInspection */
249 249
 		$qb->selectAlias('u.user_id', 'viewer_userid')
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
 		   ->leftJoin(
256 256
 			   $this->default_select_alias, CoreRequestBuilder::TABLE_MEMBERS, 'u',
257 257
 			   $expr->andX(
258
-				   $expr->eq('u.circle_id', $pf . 'unique_id'),
258
+				   $expr->eq('u.circle_id', $pf.'unique_id'),
259 259
 				   $expr->eq('u.user_id', $qb->createNamedParameter($userId)),
260 260
 				   $expr->eq('u.instance', $qb->createNamedParameter($instanceId)),
261 261
 				   $expr->eq('u.user_type', $qb->createNamedParameter($type))
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
 		}
278 278
 
279 279
 		$expr = $qb->expr();
280
-		$pf = $this->default_select_alias . '.';
280
+		$pf = $this->default_select_alias.'.';
281 281
 
282 282
 		/** @noinspection PhpMethodParametersCountMismatchInspection */
283 283
 		$qb->selectAlias('o.user_id', 'owner_userid')
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
287 287
 		   ->leftJoin(
288 288
 			   $this->default_select_alias, CoreRequestBuilder::TABLE_MEMBERS, 'o',
289 289
 			   $expr->andX(
290
-				   $expr->eq('o.circle_id', $pf . 'unique_id'),
290
+				   $expr->eq('o.circle_id', $pf.'unique_id'),
291 291
 				   $expr->eq('o.level', $qb->createNamedParameter(Member::LEVEL_OWNER)),
292 292
 				   $expr->eq('o.user_type', $qb->createNamedParameter(Member::TYPE_USER))
293 293
 			   )
Please login to merge, or discard this patch.