nextcloud / circles

lib/Service/CirclesService.php

Spacing +5 added lines, -5 removed lines

@@ -510,24 +510,24 @@
 		switch ($type) {
 			case Circle::CIRCLES_PERSONAL:
 				return $urlGen->getAbsoluteURL(
-					$urlGen->imagePath(Application::APP_NAME, 'personal' . $ext)
+					$urlGen->imagePath(Application::APP_NAME, 'personal'.$ext)
 				);
 			case Circle::CIRCLES_CLOSED:
 				return $urlGen->getAbsoluteURL(
-					$urlGen->imagePath(Application::APP_NAME, 'closed' . $ext)
+					$urlGen->imagePath(Application::APP_NAME, 'closed'.$ext)
 				);
 			case Circle::CIRCLES_SECRET:
 				return $urlGen->getAbsoluteURL(
-					$urlGen->imagePath(Application::APP_NAME, 'secret' . $ext)
+					$urlGen->imagePath(Application::APP_NAME, 'secret'.$ext)
 				);
 			case Circle::CIRCLES_PUBLIC:
 				return $urlGen->getAbsoluteURL(
-					$urlGen->imagePath(Application::APP_NAME, 'black_circle' . $ext)
+					$urlGen->imagePath(Application::APP_NAME, 'black_circle'.$ext)
 				);
 		}
 
 		return $urlGen->getAbsoluteURL(
-			$urlGen->imagePath(Application::APP_NAME, 'black_circle' . $ext)
+			$urlGen->imagePath(Application::APP_NAME, 'black_circle'.$ext)
 		);
 	}
 

lib/ShareByCircleProvider.php

Spacing +9 added lines, -9 removed lines

@@ -300,19 +300,19 @@ 
 	 */
 	private function createShare($share) {
 		$this->miscService->log(
-			'Creating share (1/4) - type: ' . $share->getShareType() . ' - token: '
-			. $share->getToken() . ' - type: ' . $share->getShareType() . ' - with: '
-			. $share->getSharedWith() . ' - permissions: ' . $share->getPermissions(), 0
+			'Creating share (1/4) - type: '.$share->getShareType().' - token: '
+			. $share->getToken().' - type: '.$share->getShareType().' - with: '
+			. $share->getSharedWith().' - permissions: '.$share->getPermissions(), 0
 		);
 
 		$qb = $this->getBaseInsertSql($share);
-		$this->miscService->log('Share creation (2/4) : ' . json_encode($qb->getSQL()), 0);
+		$this->miscService->log('Share creation (2/4) : '.json_encode($qb->getSQL()), 0);
 
 		$result = $qb->execute();
-		$this->miscService->log('Share creation result (3/4) : ' . json_encode($result), 0);
+		$this->miscService->log('Share creation result (3/4) : '.json_encode($result), 0);
 
 		$id = $qb->getLastInsertId();
-		$this->miscService->log('Share created ID (4/4) : ' . $id, 0);
+		$this->miscService->log('Share created ID (4/4) : '.$id, 0);
 
 		try {
 			$share->setId($id);
@@ -537,7 +537,7 @@ 
 	public function getShareByToken($token) {
 		$qb = $this->dbConnection->getQueryBuilder();
 
-		$this->miscService->log("Opening share by token '#" . $token . "'", 0);
+		$this->miscService->log("Opening share by token '#".$token."'", 0);
 
 		$cursor = $qb->select('*')
 					 ->from('share')
@@ -561,7 +561,7 @@ 
 			try {
 				$data = $this->getShareByPersonalToken($token);
 			} catch (Exception $e) {
-				$this->miscService->log("Share '#" . $token . "' not found.", 0);
+				$this->miscService->log("Share '#".$token."' not found.", 0);
 				throw new ShareNotFound('Share not found', $this->l10n->t('Could not find share'));
 			}
 		}
@@ -570,7 +570,7 @@ 
 			$share = $this->createShareObject($data);
 		} catch (InvalidShare $e) {
 			$this->miscService->log(
-				"Share Object '#" . $token . "' not created. " . json_encode($data), 0
+				"Share Object '#".$token."' not created. ".json_encode($data), 0
 			);
 			throw new ShareNotFound('Share not found', $this->l10n->t('Could not find share'));
 		}

lib/Model/GlobalScale/GSEvent.php

Doc Comments +1 added lines, -1 removed lines

@@ -94,7 +94,7 @@
 	}
 
 	/**
-	 * @param mixed $type
+	 * @param string $type
 	 *
 	 * @return GSEvent
 	 */

lib/Service/ConfigService.php

Spacing +2 added lines, -2 removed lines

@@ -212,7 +212,7 @@ 
 		if ((!$this->isNonSSLLinksAllowed() || strpos($remote, 'http://') !== 0)
 			&& strpos($remote, 'https://') !== 0
 		) {
-			$remote = 'https://' . $remote;
+			$remote = 'https://'.$remote;
 		}
 
 		return rtrim($remote, '/');
@@ -399,7 +399,7 @@ 
 				return false;
 			}
 
-			throw new GSStatusException('GS and lookup are not configured : ' . $lookup . ', ' . $enabled);
+			throw new GSStatusException('GS and lookup are not configured : '.$lookup.', '.$enabled);
 		}
 
 		$clef = $this->config->getSystemValue('gss.jwt.key', '');

Doc Comments +1 added lines

@@ -440,6 +440,7 @@
 	 * @param string $type
 	 *
 	 * @throws GSStatusException
+	 * @return string
 	 */
 	public function getGSStatus(string $type = '') {
 		$enabled = $this->config->getSystemValueBool('gs.enabled', false);

lib/Search/GlobalScaleUsers.php

Spacing +1 added lines, -1 removed lines

@@ -98,7 +98,7 @@
 		RequestServerException |
 		RequestResultNotJsonException $e
 		) {
-			$this->miscService->log('Issue while retrieving instances from lookup: ' . $e->getMessage());
+			$this->miscService->log('Issue while retrieving instances from lookup: '.$e->getMessage());
 
 			return [];
 		}

lib/Model/BaseCircle.php

Doc Comments +4 added lines, -4 removed lines

@@ -406,7 +406,7 @@ 
 	}
 
 	/**
-	 * @return string
+	 * @return integer
 	 */
 	public function getType() {
 		return $this->type;
@@ -460,7 +460,7 @@ 
 	}
 
 	/**
-	 * @return array
+	 * @return Member[]
 	 */
 	public function getGroups() {
 		return $this->groups;
@@ -478,7 +478,7 @@ 
 	}
 
 	/**
-	 * @return array
+	 * @return FederatedLink[]
 	 */
 	public function getLinks() {
 		return $this->links;
@@ -514,7 +514,7 @@ 
 //	}
 
 	/**
-	 * @param integer|string $type
+	 * @param string $type
 	 *
 	 * @return integer
 	 */

lib/Controller/GlobalScaleController.php

Spacing +1 added lines, -1 removed lines

@@ -91,7 +91,7 @@
 			$wrappers = $this->gsUpstreamService->getEventsByToken($token);
 		} catch (Exception $e) {
 			$this->miscService->log(
-				'exception during async: ' . ['token' => $token, 'error' => $e->getMessage()]
+				'exception during async: '.['token' => $token, 'error' => $e->getMessage()]
 			);
 			$this->fail(['token' => $token, 'error' => $e->getMessage()]);
 		}

lib/Service/GSUpstreamService.php

Spacing +3 added lines, -3 removed lines

@@ -140,7 +140,7 @@ 
 			}
 		} catch (Exception $e) {
 			$this->miscService->log(
-				get_class($e) . ' on new event: ' . $e->getMessage() . ' - ' . json_encode($event), 1
+				get_class($e).' on new event: '.$e->getMessage().' - '.json_encode($event), 1
 			);
 			throw $e;
 		}
@@ -224,7 +224,7 @@ 
 		$request->setDataSerialize($event);
 
 		$result = $this->retrieveJson($request);
-		$this->miscService->log('result ' . json_encode($result));
+		$this->miscService->log('result '.json_encode($result));
 		if ($this->getInt('status', $result) === 0) {
 			throw new GlobalScaleEventException($this->get('error', $result));
 		}
@@ -337,7 +337,7 @@ 
 
 			try {
 				$result = $this->retrieveJson($request);
-				$this->miscService->log('result: ' . json_encode($result));
+				$this->miscService->log('result: '.json_encode($result));
 				if ($this->getInt('status', $result, 0) !== 1) {
 					throw new RequestContentException('result status is not good');
 				}

Doc Comments +1 added lines, -1 removed lines

@@ -349,7 +349,7 @@
 
 
 	/**
-	 * @param array $circles
+	 * @param Circle[] $circles
 	 *
 	 * @throws GSStatusException
 	 */

lib/Service/GlobalScaleService.php

Spacing +4 added lines, -4 removed lines

@@ -139,16 +139,16 @@ 
 	 * @throws GlobalScaleEventException
 	 */
 	public function getGlobalScaleEvent(GSEvent $event): AGlobalScaleEvent {
-		$class = '\OCA\Circles\\' . $event->getType();
+		$class = '\OCA\Circles\\'.$event->getType();
 		try {
 			$gs = OC::$server->query($class);
 			if (!$gs instanceof AGlobalScaleEvent) {
-				throw new GlobalScaleEventException($class . ' not an AGlobalScaleEvent');
+				throw new GlobalScaleEventException($class.' not an AGlobalScaleEvent');
 			}
 
 			return $gs;
 		} catch (QueryException $e) {
-			throw new GlobalScaleEventException('AGlobalScaleEvent ' . $class . ' not found');
+			throw new GlobalScaleEventException('AGlobalScaleEvent '.$class.' not found');
 		}
 	}
 
@@ -200,7 +200,7 @@ 
 		try {
 			$instances = $this->retrieveJson($request);
 		} catch (RequestContentException | RequestNetworkException | RequestResultSizeException | RequestServerException | RequestResultNotJsonException $e) {
-			$this->miscService->log('Issue while retrieving instances from lookup: ' . $e->getMessage());
+			$this->miscService->log('Issue while retrieving instances from lookup: '.$e->getMessage());
 
 			return [];
 		}