Completed
Pull Request — master (#551)
by Maxence
02:42
created
lib/Db/CoreQueryBuilder.php 1 patch
Spacing   +55 added lines, -55 removed lines patch added patch discarded remove patch
@@ -162,16 +162,16 @@  discard block
 block discarded – undo
162 162
 		$this->generateMemberSelectAlias($alias, self::PREFIX_MEMBER)
163 163
 			 ->leftJoin(
164 164
 				 $this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $alias,
165
-				 $expr->eq($alias . '.circle_id', $this->getDefaultSelectAlias() . '.unique_id')
165
+				 $expr->eq($alias.'.circle_id', $this->getDefaultSelectAlias().'.unique_id')
166 166
 			 );
167 167
 
168 168
 		// TODO: Check in big table if it is better to put condition in andWhere() or in LeftJoin()
169 169
 		$this->andWhere(
170 170
 			$expr->andX(
171
-				$expr->eq($alias . '.user_id', $this->createNamedParameter($member->getUserId())),
172
-				$expr->eq($alias . '.user_type', $this->createNamedParameter($member->getUserType())),
173
-				$expr->eq($alias . '.instance', $this->createNamedParameter($this->getInstance($member))),
174
-				$expr->gte($alias . '.level', $this->createNamedParameter($level))
171
+				$expr->eq($alias.'.user_id', $this->createNamedParameter($member->getUserId())),
172
+				$expr->eq($alias.'.user_type', $this->createNamedParameter($member->getUserType())),
173
+				$expr->eq($alias.'.instance', $this->createNamedParameter($this->getInstance($member))),
174
+				$expr->gte($alias.'.level', $this->createNamedParameter($level))
175 175
 			)
176 176
 		);
177 177
 	}
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
 			 ->leftJoin(
193 193
 				 $this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_CIRCLE, $alias,
194 194
 				 $expr->andX(
195
-					 $expr->eq($alias . '.unique_id', $this->getDefaultSelectAlias() . '.circle_id')
195
+					 $expr->eq($alias.'.unique_id', $this->getDefaultSelectAlias().'.circle_id')
196 196
 				 )
197 197
 			 );
198 198
 
@@ -222,8 +222,8 @@  discard block
 block discarded – undo
222 222
 			 ->leftJoin(
223 223
 				 $circleTableAlias, CoreRequestBuilder::TABLE_MEMBER, $alias,
224 224
 				 $expr->andX(
225
-					 $expr->eq($alias . '.circle_id', $circleTableAlias . '.unique_id'),
226
-					 $expr->eq($alias . '.level', $this->createNamedParameter(Member::LEVEL_OWNER))
225
+					 $expr->eq($alias.'.circle_id', $circleTableAlias.'.unique_id'),
226
+					 $expr->eq($alias.'.level', $this->createNamedParameter(Member::LEVEL_OWNER))
227 227
 				 )
228 228
 			 );
229 229
 	}
@@ -249,11 +249,11 @@  discard block
 block discarded – undo
249 249
 			 ->leftJoin(
250 250
 				 $aliasCircle, CoreRequestBuilder::TABLE_MEMBER, $alias,
251 251
 				 $expr->andX(
252
-					 $expr->eq($alias . '.circle_id', $aliasCircle . '.unique_id'),
253
-					 $expr->eq($alias . '.user_id', $this->createNamedParameter($initiator->getUserId())),
254
-					 $expr->eq($alias . '.user_type', $this->createNamedParameter($initiator->getUserType())),
252
+					 $expr->eq($alias.'.circle_id', $aliasCircle.'.unique_id'),
253
+					 $expr->eq($alias.'.user_id', $this->createNamedParameter($initiator->getUserId())),
254
+					 $expr->eq($alias.'.user_type', $this->createNamedParameter($initiator->getUserType())),
255 255
 					 $expr->eq(
256
-						 $alias . '.instance', $this->createNamedParameter($this->getInstance($initiator))
256
+						 $alias.'.instance', $this->createNamedParameter($this->getInstance($initiator))
257 257
 					 )
258 258
 				 )
259 259
 			 );
@@ -277,9 +277,9 @@  discard block
 block discarded – undo
277 277
 		$this->leftJoin(
278 278
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $alias,
279 279
 			$expr->andX(
280
-				$expr->eq($alias . '.circle_id', $aliasCircle . '.unique_id'),
281
-				$expr->eq($alias . '.instance', $this->createNamedParameter($instance)),
282
-				$expr->gte($alias . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
280
+				$expr->eq($alias.'.circle_id', $aliasCircle.'.unique_id'),
281
+				$expr->eq($alias.'.instance', $this->createNamedParameter($instance)),
282
+				$expr->gte($alias.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
283 283
 			)
284 284
 		);
285 285
 	}
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
 		$expr = $this->expr();
300 300
 		$this->leftJoin(
301 301
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_REMOTE, $alias,
302
-			$expr->eq($alias . '.instance', $this->createNamedParameter($instance))
302
+			$expr->eq($alias.'.instance', $this->createNamedParameter($instance))
303 303
 		);
304 304
 	}
305 305
 
@@ -318,15 +318,15 @@  discard block
 block discarded – undo
318 318
 		// - 4 (Visible to everyone)
319 319
 		$orX = $expr->orX();
320 320
 		$orX->add(
321
-			$expr->andX($expr->gte($alias . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER)))
321
+			$expr->andX($expr->gte($alias.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER)))
322 322
 		);
323 323
 		$orX->add(
324 324
 			$expr->andX(
325
-				$expr->bitwiseAnd($aliasCircle . '.config', Circle::CFG_PERSONAL),
326
-				$expr->eq($alias . '.level', $this->createNamedParameter(Member::LEVEL_OWNER))
325
+				$expr->bitwiseAnd($aliasCircle.'.config', Circle::CFG_PERSONAL),
326
+				$expr->eq($alias.'.level', $this->createNamedParameter(Member::LEVEL_OWNER))
327 327
 			)
328 328
 		);
329
-		$orX->add($expr->bitwiseAnd($aliasCircle . '.config', Circle::CFG_VISIBLE));
329
+		$orX->add($expr->bitwiseAnd($aliasCircle.'.config', Circle::CFG_VISIBLE));
330 330
 		$this->andWhere($orX);
331 331
 
332 332
 
@@ -361,10 +361,10 @@  discard block
 block discarded – undo
361 361
 		$expr = $this->expr();
362 362
 
363 363
 		$orHidden = $expr->orX();
364
-		$orHidden->add($expr->bitwiseAnd($alias . '.config', Circle::CFG_SINGLE));
365
-		$orHidden->add($expr->bitwiseAnd($alias . '.config', Circle::CFG_HIDDEN));
366
-		$orHidden->add($expr->bitwiseAnd($alias . '.config', Circle::CFG_BACKEND));
367
-		$this->andWhere($this->createFunction('NOT') . $orHidden);
364
+		$orHidden->add($expr->bitwiseAnd($alias.'.config', Circle::CFG_SINGLE));
365
+		$orHidden->add($expr->bitwiseAnd($alias.'.config', Circle::CFG_HIDDEN));
366
+		$orHidden->add($expr->bitwiseAnd($alias.'.config', Circle::CFG_BACKEND));
367
+		$this->andWhere($this->createFunction('NOT').$orHidden);
368 368
 	}
369 369
 
370 370
 
@@ -393,33 +393,33 @@  discard block
 block discarded – undo
393 393
 
394 394
 		$orX = $expr->orX();
395 395
 		$orX->add(
396
-			$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBAL_SCALE))
396
+			$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBAL_SCALE))
397 397
 		);
398 398
 
399 399
 		$orExtOrPassive = $expr->orX();
400 400
 		$orExtOrPassive->add(
401
-			$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))
401
+			$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))
402 402
 		);
403 403
 		if (!$sensitive) {
404 404
 			$orExtOrPassive->add(
405
-				$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
405
+				$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
406 406
 			);
407 407
 		}
408 408
 
409 409
 		$andExternal = $expr->andX();
410 410
 		$andExternal->add($orExtOrPassive);
411
-		$andExternal->add($expr->isNotNull($aliasMembers . '.instance'));
411
+		$andExternal->add($expr->isNotNull($aliasMembers.'.instance'));
412 412
 
413 413
 		$orExtOrTrusted = $expr->orX();
414 414
 		$orExtOrTrusted->add($andExternal);
415 415
 		$orExtOrTrusted->add(
416
-			$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED))
416
+			$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED))
417 417
 		);
418 418
 
419 419
 		$andTrusted = $expr->andX();
420 420
 		$andTrusted->add($orExtOrTrusted);
421
-		$andTrusted->add($expr->bitwiseAnd($aliasCircle . '.config', Circle::CFG_FEDERATED));
422
-		$andTrusted->add($expr->emptyString($aliasOwner . '.instance'));
421
+		$andTrusted->add($expr->bitwiseAnd($aliasCircle.'.config', Circle::CFG_FEDERATED));
422
+		$andTrusted->add($expr->emptyString($aliasOwner.'.instance'));
423 423
 		$orX->add($andTrusted);
424 424
 
425 425
 		$this->andWhere($orX);
@@ -430,7 +430,7 @@  discard block
 block discarded – undo
430 430
 	 * @param int $flag
431 431
 	 */
432 432
 	public function filterConfig(int $flag): void {
433
-		$this->andWhere($this->expr()->bitwiseAnd($this->getDefaultSelectAlias() . '.config', $flag));
433
+		$this->andWhere($this->expr()->bitwiseAnd($this->getDefaultSelectAlias().'.config', $flag));
434 434
 	}
435 435
 
436 436
 
@@ -441,15 +441,15 @@  discard block
 block discarded – undo
441 441
 	 * @return $this
442 442
 	 */
443 443
 	private function generateCircleSelectAlias(string $alias, string $prefix): self {
444
-		$this->selectAlias($alias . '.unique_id', $prefix . 'unique_id')
445
-			 ->selectAlias($alias . '.name', $prefix . 'name')
446
-			 ->selectAlias($alias . '.alt_name', $prefix . 'alt_name')
447
-			 ->selectAlias($alias . '.description', $prefix . 'description')
448
-			 ->selectAlias($alias . '.settings', $prefix . 'settings')
449
-			 ->selectAlias($alias . '.config', $prefix . 'config')
450
-			 ->selectAlias($alias . '.contact_addressbook', $prefix . 'contact_addressbook')
451
-			 ->selectAlias($alias . '.contact_groupname', $prefix . 'contact_groupname')
452
-			 ->selectAlias($alias . '.creation', $prefix . 'creation');
444
+		$this->selectAlias($alias.'.unique_id', $prefix.'unique_id')
445
+			 ->selectAlias($alias.'.name', $prefix.'name')
446
+			 ->selectAlias($alias.'.alt_name', $prefix.'alt_name')
447
+			 ->selectAlias($alias.'.description', $prefix.'description')
448
+			 ->selectAlias($alias.'.settings', $prefix.'settings')
449
+			 ->selectAlias($alias.'.config', $prefix.'config')
450
+			 ->selectAlias($alias.'.contact_addressbook', $prefix.'contact_addressbook')
451
+			 ->selectAlias($alias.'.contact_groupname', $prefix.'contact_groupname')
452
+			 ->selectAlias($alias.'.creation', $prefix.'creation');
453 453
 
454 454
 		return $this;
455 455
 	}
@@ -461,20 +461,20 @@  discard block
 block discarded – undo
461 461
 	 * @return $this
462 462
 	 */
463 463
 	private function generateMemberSelectAlias(string $alias, string $prefix): self {
464
-		$this->selectAlias($alias . '.circle_id', $prefix . 'circle_id')
465
-			 ->selectAlias($alias . '.single_id', $prefix . 'single_id')
466
-			 ->selectAlias($alias . '.user_id', $prefix . 'user_id')
467
-			 ->selectAlias($alias . '.user_type', $prefix . 'user_type')
468
-			 ->selectAlias($alias . '.member_id', $prefix . 'member_id')
469
-			 ->selectAlias($alias . '.instance', $prefix . 'instance')
470
-			 ->selectAlias($alias . '.cached_name', $prefix . 'cached_name')
471
-			 ->selectAlias($alias . '.cached_update', $prefix . 'cached_update')
472
-			 ->selectAlias($alias . '.status', $prefix . 'status')
473
-			 ->selectAlias($alias . '.level', $prefix . 'level')
474
-			 ->selectAlias($alias . '.note', $prefix . 'note')
475
-			 ->selectAlias($alias . '.contact_id', $prefix . 'contact_id')
476
-			 ->selectAlias($alias . '.contact_meta', $prefix . 'contact_meta')
477
-			 ->selectAlias($alias . '.joined', $prefix . 'joined');
464
+		$this->selectAlias($alias.'.circle_id', $prefix.'circle_id')
465
+			 ->selectAlias($alias.'.single_id', $prefix.'single_id')
466
+			 ->selectAlias($alias.'.user_id', $prefix.'user_id')
467
+			 ->selectAlias($alias.'.user_type', $prefix.'user_type')
468
+			 ->selectAlias($alias.'.member_id', $prefix.'member_id')
469
+			 ->selectAlias($alias.'.instance', $prefix.'instance')
470
+			 ->selectAlias($alias.'.cached_name', $prefix.'cached_name')
471
+			 ->selectAlias($alias.'.cached_update', $prefix.'cached_update')
472
+			 ->selectAlias($alias.'.status', $prefix.'status')
473
+			 ->selectAlias($alias.'.level', $prefix.'level')
474
+			 ->selectAlias($alias.'.note', $prefix.'note')
475
+			 ->selectAlias($alias.'.contact_id', $prefix.'contact_id')
476
+			 ->selectAlias($alias.'.contact_meta', $prefix.'contact_meta')
477
+			 ->selectAlias($alias.'.joined', $prefix.'joined');
478 478
 
479 479
 		return $this;
480 480
 	}
Please login to merge, or discard this patch.
lib/Command/MembersList.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@
 block discarded – undo
142 142
 
143 143
 
144 144
 		if ($input->getOption('json')) {
145
-			echo json_encode($members, JSON_PRETTY_PRINT) . "\n";
145
+			echo json_encode($members, JSON_PRETTY_PRINT)."\n";
146 146
 
147 147
 			return 0;
148 148
 		}
Please login to merge, or discard this patch.