nextcloud / circles

lib/Circles/FileSharingBroadcaster.php

Doc Comments +6 added lines, -6 removed lines

@@ -427,7 +427,7 @@ 
 	 * @param $fileName
 	 * @param string $link
 	 * @param string $author
-	 * @param $circleName
+	 * @param string $circleName
 	 * @param string $email
 	 *
 	 * @throws Exception
@@ -464,7 +464,7 @@ 
 	 * @param string $circleName
 	 * @param string $email
 	 *
-	 * @param $password
+	 * @param string $password
 	 *
 	 * @throws NotFoundException
 	 * @throws Exception
@@ -546,7 +546,7 @@ 
 	 * @param $subject
 	 * @param $text
 	 * @param $fileName
-	 * @param $link
+	 * @param string $link
 	 * @param string $author
 	 * @param string $circleName
 	 *
@@ -714,7 +714,7 @@ 
 
 
 	/**
-	 * @param $author
+	 * @param string $author
 	 * @param string $circleName
 	 *
 	 * @return IEMailTemplate
@@ -757,8 +757,8 @@ 
 
 	/**
 	 * @param IEMailTemplate $emailTemplate
-	 * @param $author
-	 * @param $recipient
+	 * @param string $author
+	 * @param string $recipient
 	 *
 	 * @throws Exception
 	 */

Spacing +12 added lines, -12 removed lines

@@ -132,7 +132,7 @@ 
 			$this->miscService = OC::$server->query(MiscService::class);
 		} catch (QueryException $e) {
 			OC::$server->getLogger()
-					   ->log(1, 'Circles: cannot init FileSharingBroadcaster - ' . $e->getMessage());
+					   ->log(1, 'Circles: cannot init FileSharingBroadcaster - '.$e->getMessage());
 		}
 
 		try {
@@ -325,7 +325,7 @@ 
 	 * @throws IllegalIDChangeException
 	 */
 	private function generateShare($data): IShare {
-		$this->logger->log(0, 'Regenerate shares from payload: ' . json_encode($data));
+		$this->logger->log(0, 'Regenerate shares from payload: '.json_encode($data));
 
 		$share = new Share($this->rootFolder, $this->userManager);
 		$share->setId($data['id']);
@@ -418,7 +418,7 @@ 
 			$this->sendPasswordByMail($share, $displayName, $email, $password);
 		} catch (Exception $e) {
 			OC::$server->getLogger()
-					   ->log(1, 'Circles::sharedByMail - mail were not sent: ' . $e->getMessage());
+					   ->log(1, 'Circles::sharedByMail - mail were not sent: '.$e->getMessage());
 		}
 	}
 
@@ -436,8 +436,8 @@ 
 		$message = $this->mailer->createMessage();
 
 		$this->logger->log(
-			0, "Sending mail to circle '" . $circleName . "': " . $email . ' file: ' . $fileName
-			   . ' - link: ' . $link
+			0, "Sending mail to circle '".$circleName."': ".$email.' file: '.$fileName
+			   . ' - link: '.$link
 		);
 
 		$subject = $this->l10n->t('%s shared »%s« with you.', [$author, $fileName]);
@@ -476,7 +476,7 @@ 
 
 		$message = $this->mailer->createMessage();
 
-		$this->logger->log(0, "Sending password mail to circle '" . $circleName . "': " . $email);
+		$this->logger->log(0, "Sending password mail to circle '".$circleName."': ".$email);
 
 		$filename = $share->getNode()
 						  ->getName();
@@ -531,7 +531,7 @@ 
 		$message->setFrom([\OCP\Util::getDefaultEmailAddress($instanceName) => $senderName]);
 		if ($initiatorEmailAddress !== null) {
 			$message->setReplyTo([$initiatorEmailAddress => $initiatorDisplayName]);
-			$emailTemplate->addFooter($instanceName . ' - ' . $this->defaults->getSlogan());
+			$emailTemplate->addFooter($instanceName.' - '.$this->defaults->getSlogan());
 		} else {
 			$emailTemplate->addFooter();
 		}
@@ -566,7 +566,7 @@ 
 		$emailTemplate->addHeader();
 		$emailTemplate->addHeading($subject, false);
 		$emailTemplate->addBodyText(
-			htmlspecialchars($text) . '<br>' . htmlspecialchars(
+			htmlspecialchars($text).'<br>'.htmlspecialchars(
 				$this->l10n->t('Click the button below to open it.')
 			), $text
 		);
@@ -612,7 +612,7 @@ 
 			$this->sendMailExistingShares($template, $author->getCachedName(), $recipient);
 			$this->sendPasswordExistingShares($author, $recipient, $password);
 		} catch (Exception $e) {
-			$this->logger->log(2, 'Failed to send mail about existing share ' . $e->getMessage());
+			$this->logger->log(2, 'Failed to send mail about existing share '.$e->getMessage());
 		}
 	}
 
@@ -635,7 +635,7 @@ 
 		$authorName = ($authorUser instanceof IUser) ? $authorUser->getDisplayName() : $author;
 		$authorEmail = ($authorUser instanceof IUser) ? $authorUser->getEMailAddress() : null;
 
-		$this->logger->log(0, "Sending password mail about existing files to '" . $email . "'");
+		$this->logger->log(0, "Sending password mail about existing files to '".$email."'");
 
 		$plainBodyPart = $this->l10n->t(
 			"%1\$s shared multiple files with you.\nYou should have already received a separate mail with a link to access them.\n",
@@ -677,7 +677,7 @@ 
 		$message->setFrom([\OCP\Util::getDefaultEmailAddress($instanceName) => $senderName]);
 		if ($authorEmail !== null) {
 			$message->setReplyTo([$authorEmail => $authorName]);
-			$emailTemplate->addFooter($instanceName . ' - ' . $this->defaults->getSlogan());
+			$emailTemplate->addFooter($instanceName.' - '.$this->defaults->getSlogan());
 		} else {
 			$emailTemplate->addFooter();
 		}
@@ -722,7 +722,7 @@ 
 	 */
 	protected function generateMailExitingShares($author, $circleName) {
 		$this->logger->log(
-			0, "Generating mail about existing share mail from '" . $author . "' in "
+			0, "Generating mail about existing share mail from '".$author."' in "
 			   . $circleName
 		);
 

lib/Service/GSUpstreamService.php

Doc Comments +1 added lines, -1 removed lines

@@ -340,7 +340,7 @@
 
 
 	/**
-	 * @param array $sync
+	 * @param Circle[] $sync
 	 *
 	 * @throws GSStatusException
 	 */

lib/Service/MiscService.php

Doc Comments +5 added lines, -2 removed lines

@@ -78,7 +78,7 @@ 
 
 	/**
 	 * @param $arr
-	 * @param $k
+	 * @param string $k
 	 *
 	 * @param string $default
 	 *
@@ -93,6 +93,9 @@ 
 	}
 
 
+	/**
+	 * @param string[] $arr
+	 */
 	public static function mustContains($data, $arr) {
 		if (!is_array($arr)) {
 			$arr = [$arr];
@@ -250,7 +253,7 @@ 
 
 
 	/**
-	 * @param $ident
+	 * @param string $ident
 	 *
 	 * @return mixed|string
 	 * @deprecated

lib/Api/v1/Circles.php

Spacing +5 added lines, -5 removed lines

@@ -463,7 +463,7 @@ 
 	 */
 	public static function generateLink($circleUniqueId) {
 		return OC::$server->getURLGenerator()
-						  ->linkToRoute('circles.Navigation.navigate') . '#' . $circleUniqueId;
+						  ->linkToRoute('circles.Navigation.navigate').'#'.$circleUniqueId;
 	}
 
 
@@ -478,7 +478,7 @@ 
 	 */
 	public static function generateAbsoluteLink($circleUniqueId) {
 		return OC::$server->getURLGenerator()
-						  ->linkToRouteAbsolute('circles.Navigation.navigate') . '#' . $circleUniqueId;
+						  ->linkToRouteAbsolute('circles.Navigation.navigate').'#'.$circleUniqueId;
 	}
 
 
@@ -493,8 +493,8 @@ 
 	 */
 	public static function generateRemoteLink(FederatedLink $link) {
 		return OC::$server->getURLGenerator()
-						  ->linkToRoute('circles.Navigation.navigate') . '#' . $link->getUniqueId()
-			   . '-' . $link->getToken();
+						  ->linkToRoute('circles.Navigation.navigate').'#'.$link->getUniqueId()
+			   . '-'.$link->getToken();
 	}
 
 
@@ -505,7 +505,7 @@ 
 	 */
 	public static function generateUserParameter(SharingFrame $frame) {
 		if ($frame->getCloudId() !== null) {
-			$name = $frame->getAuthor() . '@' . $frame->getCloudId();
+			$name = $frame->getAuthor().'@'.$frame->getCloudId();
 		} else {
 			try {
 				$membersService = \OC::$server->query(MembersService::class);

lib/Db/CoreRequestBuilder.php

Spacing +15 added lines, -15 removed lines

@@ -346,8 +346,8 @@ 
 		$expr = $qb->expr();
 
 		if ($pf === '') {
-			$p = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias . '.' : '';
-			$qb->andWhere($expr->gte($p . 'level', $qb->createNamedParameter($level)));
+			$p = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias.'.' : '';
+			$qb->andWhere($expr->gte($p.'level', $qb->createNamedParameter($level)));
 
 			return;
 		}
@@ -376,7 +376,7 @@ 
 			if ($p === 'g' && !$this->leftJoinedNCGroupAndUser) {
 				continue;
 			}
-			$orX->add($expr->gte($p . '.level', $qb->createNamedParameter($level)));
+			$orX->add($expr->gte($p.'.level', $qb->createNamedParameter($level)));
 		}
 
 		return $orX;
@@ -391,12 +391,12 @@ 
 	protected function limitToMembersAndAlmost(IQueryBuilder $qb) {
 		$expr = $qb->expr();
 
-		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias . '.' : '';
+		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias.'.' : '';
 
 		$orX = $expr->orX();
-		$orX->add($expr->eq($pf . 'status', $qb->createNamedParameter(Member::STATUS_MEMBER)));
-		$orX->add($expr->eq($pf . 'status', $qb->createNamedParameter(Member::STATUS_INVITED)));
-		$orX->add($expr->eq($pf . 'status', $qb->createNamedParameter(Member::STATUS_REQUEST)));
+		$orX->add($expr->eq($pf.'status', $qb->createNamedParameter(Member::STATUS_MEMBER)));
+		$orX->add($expr->eq($pf.'status', $qb->createNamedParameter(Member::STATUS_INVITED)));
+		$orX->add($expr->eq($pf.'status', $qb->createNamedParameter(Member::STATUS_REQUEST)));
 
 		$qb->andWhere($orX);
 	}
@@ -409,8 +409,8 @@ 
 	 */
 	public function limitToDBField(IQueryBuilder $qb, $field, $value) {
 		$expr = $qb->expr();
-		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias . '.' : '';
-		$qb->andWhere($expr->eq($pf . $field, $qb->createNamedParameter($value)));
+		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias.'.' : '';
+		$qb->andWhere($expr->eq($pf.$field, $qb->createNamedParameter($value)));
 	}
 
 
@@ -421,8 +421,8 @@ 
 	 */
 	private function limitToDBFieldOrGreater(IQueryBuilder $qb, $field, $value) {
 		$expr = $qb->expr();
-		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias . '.' : '';
-		$qb->andWhere($expr->gte($pf . $field, $qb->createNamedParameter($value)));
+		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias.'.' : '';
+		$qb->andWhere($expr->gte($pf.$field, $qb->createNamedParameter($value)));
 	}
 
 
@@ -437,9 +437,9 @@ 
 	protected function limitToNCGroupUser(IQueryBuilder $qb, $userId = '') {
 		$expr = $qb->expr();
 
-		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias . '.' : '';
+		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias.'.' : '';
 
-		$and = $expr->andX($expr->eq($pf . 'user_id', 'ncgu.gid'));
+		$and = $expr->andX($expr->eq($pf.'user_id', 'ncgu.gid'));
 		if ($userId !== '') {
 			$and->add($expr->eq('ncgu.uid', $qb->createNamedParameter($userId)));
 		} else {
@@ -462,7 +462,7 @@ 
 		}
 
 		$expr = $qb->expr();
-		$pf = $this->default_select_alias . '.';
+		$pf = $this->default_select_alias.'.';
 
 		/** @noinspection PhpMethodParametersCountMismatchInspection */
 		$qb->selectAlias('lc.type', 'circle_type')
@@ -471,7 +471,7 @@ 
 		   ->selectAlias('lc.settings', 'circle_settings')
 		   ->leftJoin(
 			   $this->default_select_alias, CoreRequestBuilder::TABLE_CIRCLES, 'lc',
-			   $expr->eq($pf . 'circle_id', 'lc.unique_id')
+			   $expr->eq($pf.'circle_id', 'lc.unique_id')
 		   );
 	}
 

lib/Service/GlobalScaleService.php

Spacing +6 added lines, -6 removed lines

@@ -167,12 +167,12 @@ 
 		try {
 			$gs = OC::$server->query($class);
 			if (!$gs instanceof AGlobalScaleEvent) {
-				throw new GlobalScaleEventException($class . ' not an AGlobalScaleEvent');
+				throw new GlobalScaleEventException($class.' not an AGlobalScaleEvent');
 			}
 
 			return $gs;
 		} catch (QueryException $e) {
-			throw new GlobalScaleEventException('AGlobalScaleEvent ' . $class . ' not found');
+			throw new GlobalScaleEventException('AGlobalScaleEvent '.$class.' not found');
 		}
 	}
 
@@ -191,7 +191,7 @@ 
 			}
 		}
 
-		return md5('gskey:' . $key);
+		return md5('gskey:'.$key);
 	}
 
 	/**
@@ -238,7 +238,7 @@ 
 				$instances = $this->retrieveJson($request);
 			} catch (RequestContentException | RequestNetworkException | RequestResultSizeException | RequestServerException | RequestResultNotJsonException $e) {
 				$this->miscService->log(
-					'Issue while retrieving instances from lookup: ' . get_class($e) . ' ' . $e->getMessage()
+					'Issue while retrieving instances from lookup: '.get_class($e).' '.$e->getMessage()
 				);
 
 				return [];
@@ -268,7 +268,7 @@ 
 		$absolute = $this->urlGenerator->linkToRouteAbsolute('circles.Navigation.navigate');
 		$local = parse_url($absolute);
 
-		return [$local['host'] . ':' . $local['port']];
+		return [$local['host'].':'.$local['port']];
 	}
 
 
@@ -282,7 +282,7 @@ 
 		$className = $event->getType();
 		if (substr($className, 0, 25) !== '\OCA\Circles\GlobalScale\\' || strpos($className, '.')) {
 			throw new GlobalScaleEventException(
-				$className . ' does not seems to be a secured AGlobalScaleEvent'
+				$className.' does not seems to be a secured AGlobalScaleEvent'
 			);
 		}
 

lib/Service/DavService.php

Spacing +38 added lines, -38 removed lines

@@ -164,7 +164,7 @@ 
 	public function onDeleteCard(GenericEvent $event) {
 		$davCard = $this->generateDavCard($event, true);
 
-		$this->miscService->log('Deleting Card: ' . json_encode($davCard), 1);
+		$this->miscService->log('Deleting Card: '.json_encode($davCard), 1);
 		$this->membersRequest->removeMembersByContactId($davCard->getUniqueId(), Member::TYPE_USER);
 		$this->manageDeprecatedCircles($davCard->getAddressBookId());
 		$this->manageDeprecatedMembers($davCard);
@@ -205,7 +205,7 @@ 
 	 */
 	private function generateDavCardFromCard(int $bookId, array $card): DavCard {
 		$this->miscService->log(
-			'generating DavCard Model from book=' . $bookId . ' from ' . json_encode($card), 0
+			'generating DavCard Model from book='.$bookId.' from '.json_encode($card), 0
 		);
 
 		$davCard = new DavCard();
@@ -215,7 +215,7 @@ 
 		$davCard->setOwner($this->getOwnerFromAddressBook($bookId));
 		$davCard->importFromDav($card['carddata']);
 
-		$this->miscService->log('generated DavCard Model: ' . json_encode($davCard), 0);
+		$this->miscService->log('generated DavCard Model: '.json_encode($davCard), 0);
 
 		return $davCard;
 	}
@@ -226,7 +226,7 @@ 
 	 *
 	 */
 	private function manageDavCard(DavCard $davCard) {
-		$this->miscService->log('Updating Card: ' . json_encode($davCard), 1);
+		$this->miscService->log('Updating Card: '.json_encode($davCard), 1);
 		$this->manageCircles($davCard);
 		$this->manageContact($davCard);
 	}
@@ -260,7 +260,7 @@ 
 	 */
 	private function manageDeprecatedMembers(DavCard $davCard) {
 		$this->miscService->log(
-			'Managing deprecated circles memberships from DavCard Model: ' . json_encode($davCard), 0
+			'Managing deprecated circles memberships from DavCard Model: '.json_encode($davCard), 0
 		);
 
 		$circles = array_map(
@@ -271,13 +271,13 @@ 
 
 		$members = $this->membersRequest->getMembersByContactId($davCard->getUniqueId());
 		$this->miscService->log(
-			'Found ' . sizeof($members) . ' memberships with contactId=' . $davCard->getUniqueId(), 0
+			'Found '.sizeof($members).' memberships with contactId='.$davCard->getUniqueId(), 0
 		);
 
 		foreach ($members as $member) {
 			if (!in_array($member->getCircleId(), $circles)) {
 				$this->miscService->log(
-					'Removing membership ' . $member->getMemberId() . ' from ' . $member->getCircleId(), 0
+					'Removing membership '.$member->getMemberId().' from '.$member->getCircleId(), 0
 				);
 				$this->membersRequest->removeMember($member);
 			}
@@ -357,7 +357,7 @@ 
 			}
 		}
 
-		$davCard->setUserId($davCard->getOwner() . ':' . $davCard->getContactId());
+		$davCard->setUserId($davCard->getOwner().':'.$davCard->getContactId());
 
 		return DavCard::TYPE_CONTACT;
 	}
@@ -402,7 +402,7 @@ 
 		);
 
 		$this->miscService->log(
-			'manage Circles from DavCard: ' . json_encode($fromCard) . ' - current: ' . json_encode($current)
+			'manage Circles from DavCard: '.json_encode($fromCard).' - current: '.json_encode($current)
 		);
 
 		$this->manageNewCircles($davCard, $fromCard, $current);
@@ -425,7 +425,7 @@ 
 
 			$user = $this->userManager->get($davCard->getOwner());
 			$circle = new Circle(
-				$this->configService->contactsBackendType(), $group . ' - ' . $user->getDisplayName()
+				$this->configService->contactsBackendType(), $group.' - '.$user->getDisplayName()
 			);
 			$circle->setAltName($group);
 			$circle->generateUniqueId();
@@ -433,7 +433,7 @@ 
 			$circle->setContactGroupName($group);
 
 			$this->miscService->log(
-				'creating new Circle: ' . json_encode($circle) . ', with owner=' . $davCard->getOwner(), 0
+				'creating new Circle: '.json_encode($circle).', with owner='.$davCard->getOwner(), 0
 			);
 			try {
 				$this->circlesRequest->createCircle($circle);
@@ -442,7 +442,7 @@ 
 				$owner->setStatus(Member::STATUS_MEMBER);
 				$this->membersService->updateCachedName($owner);
 
-				$this->miscService->log('creating new Member: ' . json_encode($owner), 0);
+				$this->miscService->log('creating new Member: '.json_encode($owner), 0);
 				try {
 					$this->membersRequest->createMember($owner);
 				} catch (MemberAlreadyExistsException $e) {
@@ -457,7 +457,7 @@ 
 	 * @param DavCard $davCard
 	 */
 	private function assignCirclesToCard(DavCard $davCard) {
-		$this->miscService->log('assigning Circles to DavCard Model: ' . json_encode($davCard), 0);
+		$this->miscService->log('assigning Circles to DavCard Model: '.json_encode($davCard), 0);
 		foreach ($davCard->getGroups() as $group) {
 			try {
 				$davCard->addCircle(
@@ -467,7 +467,7 @@ 
 			}
 		}
 
-		$this->miscService->log('assigned Circles to DavCard Model: ' . json_encode($davCard), 0);
+		$this->miscService->log('assigned Circles to DavCard Model: '.json_encode($davCard), 0);
 	}
 
 
@@ -512,12 +512,12 @@ 
 	 * @return string
 	 */
 	public function getOwnerFromAddressBook(int $bookId): string {
-		$this->miscService->log('Retrieving Owner from book:' . $bookId, 0);
+		$this->miscService->log('Retrieving Owner from book:'.$bookId, 0);
 		$data = $this->cardDavBackend->getAddressBookById($bookId);
 
 		// let's assume the format is principals/users/OWNER
 		$owner = substr($data['principaluri'], 17);
-		$this->miscService->log('Retrieved Owner:' . $owner, 0);
+		$this->miscService->log('Retrieved Owner:'.$owner, 0);
 
 		return $owner;
 	}
@@ -534,12 +534,12 @@ 
 		$this->manageDeprecatedContacts();
 		$this->manageDeprecatedCircles();
 		$users = $this->userManager->search('');
-		$this->miscService->log('initiating migration for ' . sizeof($users) . ' users', 0);
+		$this->miscService->log('initiating migration for '.sizeof($users).' users', 0);
 		foreach ($users as $user) {
-			$this->miscService->log('retrieving books for user=' . $user->getUID(), 0);
-			$books = $this->cardDavBackend->getAddressBooksForUser('principals/users/' . $user->getUID());
+			$this->miscService->log('retrieving books for user='.$user->getUID(), 0);
+			$books = $this->cardDavBackend->getAddressBooksForUser('principals/users/'.$user->getUID());
 
-			$this->miscService->log('initiating migration for user=' . $user->getUID(), 0);
+			$this->miscService->log('initiating migration for user='.$user->getUID(), 0);
 			foreach ($books as $book) {
 				$this->migrateBook($book['id']);
 			}
@@ -552,16 +552,16 @@ 
 	private function manageDeprecatedContacts() {
 		$contacts = $this->membersRequest->getMembersByContactId();
 		$this->miscService->log(
-			'Managing Deprecated Contacts, checking ' . sizeof($contacts) . ' known contacts in database', 0
+			'Managing Deprecated Contacts, checking '.sizeof($contacts).' known contacts in database', 0
 		);
 
 		foreach ($contacts as $contact) {
 			try {
 				$this->getDavCardFromMember($contact);
-				$this->miscService->log('Contact is not deprecated: ' . json_encode($contact));
+				$this->miscService->log('Contact is not deprecated: '.json_encode($contact));
 			} catch (MemberDoesNotExistException $e) {
 				$this->miscService->log(
-					'Contact is deprecated and will be removed: ' . json_encode($contact)
+					'Contact is deprecated and will be removed: '.json_encode($contact)
 				);
 				$this->membersRequest->removeMember($contact);
 			}
@@ -576,12 +576,12 @@ 
 	 */
 	private function manageDeprecatedCircles(int $bookId = 0) {
 		$knownBooks = [$bookId];
-		$this->miscService->log('Managing Deprecated Circles, using bookId: ' . $bookId, 0);
+		$this->miscService->log('Managing Deprecated Circles, using bookId: '.$bookId, 0);
 
 		if ($bookId > 0) {
 			$knownBooks = [];
 			$contacts = $this->membersRequest->getMembersByContactId();
-			$this->miscService->log(sizeof($contacts) . ' known members as contacts in Circles DB', 0);
+			$this->miscService->log(sizeof($contacts).' known members as contacts in Circles DB', 0);
 
 			foreach ($contacts as $contact) {
 				list($bookId,) = explode('/', $contact->getContactId(), 2);
@@ -593,17 +593,17 @@ 
 			}
 		}
 
-		$this->miscService->log('Known books: ' . json_encode($knownBooks), 0);
+		$this->miscService->log('Known books: '.json_encode($knownBooks), 0);
 		foreach ($knownBooks as $bookId) {
-			$this->miscService->log('retrieving local Circles data for bookId=' . $bookId, 0);
+			$this->miscService->log('retrieving local Circles data for bookId='.$bookId, 0);
 			$circles = $this->circlesRequest->getFromContactBook($bookId);
 			$this->miscService->log(
-				'Known circles for bookId=' . $bookId . ': ' . json_encode($circles), 0
+				'Known circles for bookId='.$bookId.': '.json_encode($circles), 0
 			);
 
 			$fromBook = $this->getExistingCirclesFromBook($bookId);
 			$this->miscService->log(
-				'Generated circles from bookId=' . $bookId . ': ' . json_encode($fromBook), 0
+				'Generated circles from bookId='.$bookId.': '.json_encode($fromBook), 0
 			);
 
 			foreach ($circles as $circle) {
@@ -612,7 +612,7 @@ 
 				}
 
 				$this->miscService->log(
-					$circle->getUniqueId() . ' is a deprecated Circle and will be destroyed', 0
+					$circle->getUniqueId().' is a deprecated Circle and will be destroyed', 0
 				);
 
 				$this->membersRequest->removeAllFromCircle($circle->getUniqueId());
@@ -634,7 +634,7 @@ 
 		$cards = $this->cardDavBackend->getCards($bookId);
 
 		$this->miscService->log(
-			'retrieving existing circles from bookId=' . $bookId . ' in ' . sizeof($cards) . ' cards', 0
+			'retrieving existing circles from bookId='.$bookId.' in '.sizeof($cards).' cards', 0
 		);
 		foreach ($cards as $card) {
 			$davCard = $this->generateDavCardFromCard($bookId, $card);
@@ -642,7 +642,7 @@ 
 			$circles = array_merge($circles, $davCard->getCircles());
 		}
 
-		$this->miscService->log('Found ' . sizeof($circles) . ' Circles from book=' . $bookId, 0);
+		$this->miscService->log('Found '.sizeof($circles).' Circles from book='.$bookId, 0);
 		$existing = array_unique(
 			array_map(
 				function(Circle $circle) {
@@ -652,7 +652,7 @@ 
 		);
 
 		$this->miscService->log(
-			'retrieved existing circles from book=' . $bookId . ': ' . json_encode($existing), 0
+			'retrieved existing circles from book='.$bookId.': '.json_encode($existing), 0
 		);
 
 		return $existing;
@@ -667,14 +667,14 @@ 
 	 */
 	public function getDavCardFromMember(Member $contact): DavCard {
 		list($bookId, $cardUri) = explode('/', $contact->getContactId(), 2);
-		$this->miscService->log('Retrieving DavCard from book:' . $bookId . ', uri:' . $cardUri, 0);
+		$this->miscService->log('Retrieving DavCard from book:'.$bookId.', uri:'.$cardUri, 0);
 
 		$cards = $this->cardDavBackend->getCards($bookId);
-		$this->miscService->log('Book contains ' . sizeof($cards) . ' cards', 0);
+		$this->miscService->log('Book contains '.sizeof($cards).' cards', 0);
 		foreach ($cards as $card) {
 			if ($card['uri'] === $cardUri) {
 				$davCard = $this->generateDavCardFromCard($bookId, $card);
-				$this->miscService->log('Retrieved DavCard: ' . json_encode($card));
+				$this->miscService->log('Retrieved DavCard: '.json_encode($card));
 
 				return $davCard;
 			}
@@ -692,11 +692,11 @@ 
 			return;
 		}
 
-		$this->miscService->log('migrating book: ' . $bookId, 0);
+		$this->miscService->log('migrating book: '.$bookId, 0);
 		$owner = $this->getOwnerFromAddressBook($bookId);
 
 		$cards = $this->cardDavBackend->getCards($bookId);
-		$this->miscService->log('found ' . sizeof($cards) . 'cards from book=' . $bookId, 0);
+		$this->miscService->log('found '.sizeof($cards).'cards from book='.$bookId, 0);
 
 		foreach ($cards as $card) {
 			$davCard = new DavCard();

lib/Search/GlobalScaleUsers.php

Spacing +1 added lines, -1 removed lines

@@ -95,7 +95,7 @@
 		RequestResultNotJsonException $e
 		) {
 			$this->miscService->log(
-				'Issue while search users from lookup: ' . get_class($e) . ' ' . $e->getMessage()
+				'Issue while search users from lookup: '.get_class($e).' '.$e->getMessage()
 			);
 
 			return [];

lib/Activity/ProviderParser.php

Spacing +4 added lines, -4 removed lines

@@ -137,7 +137,7 @@ 
 				continue;
 			}
 
-			$replace['{' . $k . '}'] = $data[$k]['_parsed'];
+			$replace['{'.$k.'}'] = $data[$k]['_parsed'];
 		}
 
 		$line = strtr($line, $replace);
@@ -301,7 +301,7 @@ 
 		return [
 			'type'    => $member->getTypeName(),
 			'id'      => $member->getUserId(),
-			'name'    => $member->getCachedName() . ' (' . $member->getTypeString() . ')',
+			'name'    => $member->getCachedName().' ('.$member->getTypeString().')',
 			'_parsed' => $member->getCachedName()
 		];
 	}
@@ -337,8 +337,8 @@ 
 		return [
 			'type'    => 'circle',
 			'id'      => $link->getUniqueId(),
-			'name'    => $link->getToken() . '@' . $link->getAddress(),
-			'_parsed' => $link->getToken() . '@' . $link->getAddress()
+			'name'    => $link->getToken().'@'.$link->getAddress(),
+			'_parsed' => $link->getToken().'@'.$link->getAddress()
 		];
 	}