@@ -288,8 +288,8 @@ discard block |
||
| 288 | 288 | |
| 289 | 289 | |
| 290 | 290 | /** |
| 291 | - * @param $circleUniqueId |
|
| 292 | - * @param $remote |
|
| 291 | + * @param string $circleUniqueId |
|
| 292 | + * @param string $remote |
|
| 293 | 293 | * |
| 294 | 294 | * @return FederatedLink |
| 295 | 295 | */ |
@@ -402,7 +402,7 @@ discard block |
||
| 402 | 402 | * |
| 403 | 403 | * Will parse the error reason returned by requestLink() and throw an Exception |
| 404 | 404 | * |
| 405 | - * @param $reason |
|
| 405 | + * @param string $reason |
|
| 406 | 406 | * |
| 407 | 407 | * @throws Exception |
| 408 | 408 | * @throws FederatedRemoteCircleDoesNotExistException |
@@ -317,7 +317,7 @@ discard block |
||
| 317 | 317 | * @return string |
| 318 | 318 | */ |
| 319 | 319 | private function generateLinkRemoteURL($remote) { |
| 320 | - return $this->configService->generateRemoteHost($remote) . Application::REMOTE_URL_LINK; |
|
| 320 | + return $this->configService->generateRemoteHost($remote).Application::REMOTE_URL_LINK; |
|
| 321 | 321 | } |
| 322 | 322 | |
| 323 | 323 | |
@@ -331,7 +331,7 @@ discard block |
||
| 331 | 331 | * @return boolean |
| 332 | 332 | * @throws Exception |
| 333 | 333 | */ |
| 334 | - private function requestLink(Circle $circle, FederatedLink &$link) { |
|
| 334 | + private function requestLink(Circle $circle, FederatedLink & $link) { |
|
| 335 | 335 | $args = array_merge(self::generateLinkData($link), ['sourceName' => $circle->getName()]); |
| 336 | 336 | |
| 337 | 337 | try { |
@@ -378,7 +378,7 @@ discard block |
||
| 378 | 378 | * |
| 379 | 379 | * @throws Exception |
| 380 | 380 | */ |
| 381 | - private function eventOnRequestLink(Circle $circle, FederatedLink &$link, $status, $reason) { |
|
| 381 | + private function eventOnRequestLink(Circle $circle, FederatedLink & $link, $status, $reason) { |
|
| 382 | 382 | |
| 383 | 383 | switch ($status) { |
| 384 | 384 | case FederatedLink::STATUS_LINK_UP: |
@@ -515,7 +515,7 @@ discard block |
||
| 515 | 515 | * @return bool |
| 516 | 516 | * @throws Exception |
| 517 | 517 | */ |
| 518 | - private function updateLinkRemote(FederatedLink &$link) { |
|
| 518 | + private function updateLinkRemote(FederatedLink & $link) { |
|
| 519 | 519 | |
| 520 | 520 | try { |
| 521 | 521 | $client = $this->clientService->newClient(); |
@@ -542,7 +542,7 @@ discard block |
||
| 542 | 542 | * |
| 543 | 543 | * @throws Exception |
| 544 | 544 | */ |
| 545 | - public function initiateLink(Circle $circle, FederatedLink &$link) { |
|
| 545 | + public function initiateLink(Circle $circle, FederatedLink & $link) { |
|
| 546 | 546 | |
| 547 | 547 | try { |
| 548 | 548 | $this->checkLinkRequestValidity($circle, $link); |
@@ -625,7 +625,7 @@ discard block |
||
| 625 | 625 | * @param Circle $circle |
| 626 | 626 | * @param FederatedLink $link |
| 627 | 627 | */ |
| 628 | - private function checkUpdateLinkFromRemoteLinkRequestSent(Circle $circle, FederatedLink &$link) { |
|
| 628 | + private function checkUpdateLinkFromRemoteLinkRequestSent(Circle $circle, FederatedLink & $link) { |
|
| 629 | 629 | |
| 630 | 630 | if ($link->getStatus() !== FederatedLink::STATUS_REQUEST_SENT) { |
| 631 | 631 | return; |
@@ -640,7 +640,7 @@ discard block |
||
| 640 | 640 | * @param Circle $circle |
| 641 | 641 | * @param FederatedLink $link |
| 642 | 642 | */ |
| 643 | - private function checkUpdateLinkFromRemoteLinkRequested(Circle $circle, FederatedLink &$link) { |
|
| 643 | + private function checkUpdateLinkFromRemoteLinkRequested(Circle $circle, FederatedLink & $link) { |
|
| 644 | 644 | |
| 645 | 645 | if ($link->getStatus() !== FederatedLink::STATUS_LINK_REQUESTED) { |
| 646 | 646 | return; |
@@ -655,7 +655,7 @@ discard block |
||
| 655 | 655 | * @param Circle $circle |
| 656 | 656 | * @param FederatedLink $link |
| 657 | 657 | */ |
| 658 | - private function checkUpdateLinkFromRemoteLinkDown(Circle $circle, FederatedLink &$link) { |
|
| 658 | + private function checkUpdateLinkFromRemoteLinkDown(Circle $circle, FederatedLink & $link) { |
|
| 659 | 659 | |
| 660 | 660 | if ($link->getStatus() < FederatedLink::STATUS_LINK_DOWN) { |
| 661 | 661 | return; |