Completed
Pull Request — master (#551)
by Maxence
02:04
created
lib/Db/CoreQueryBuilder.php 1 patch
Spacing   +58 added lines, -58 removed lines patch added patch discarded remove patch
@@ -161,16 +161,16 @@  discard block
 block discarded – undo
161 161
 		$this->generateMemberSelectAlias($alias, self::PREFIX_MEMBER)
162 162
 			 ->leftJoin(
163 163
 				 $this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $alias,
164
-				 $expr->eq($alias . '.circle_id', $this->getDefaultSelectAlias() . '.unique_id')
164
+				 $expr->eq($alias.'.circle_id', $this->getDefaultSelectAlias().'.unique_id')
165 165
 			 );
166 166
 
167 167
 		// TODO: Check in big table if it is better to put condition in andWhere() or in LeftJoin()
168 168
 		$this->andWhere(
169 169
 			$expr->andX(
170
-				$expr->eq($alias . '.user_id', $this->createNamedParameter($member->getUserId())),
171
-				$expr->eq($alias . '.user_type', $this->createNamedParameter($member->getUserType())),
172
-				$expr->eq($alias . '.instance', $this->createNamedParameter($this->getInstance($member))),
173
-				$expr->gte($alias . '.level', $this->createNamedParameter($level))
170
+				$expr->eq($alias.'.user_id', $this->createNamedParameter($member->getUserId())),
171
+				$expr->eq($alias.'.user_type', $this->createNamedParameter($member->getUserType())),
172
+				$expr->eq($alias.'.instance', $this->createNamedParameter($this->getInstance($member))),
173
+				$expr->gte($alias.'.level', $this->createNamedParameter($level))
174 174
 			)
175 175
 		);
176 176
 	}
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
 			 ->leftJoin(
192 192
 				 $this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_CIRCLE, $alias,
193 193
 				 $expr->andX(
194
-					 $expr->eq($alias . '.unique_id', $this->getDefaultSelectAlias() . '.circle_id')
194
+					 $expr->eq($alias.'.unique_id', $this->getDefaultSelectAlias().'.circle_id')
195 195
 				 )
196 196
 			 );
197 197
 
@@ -221,8 +221,8 @@  discard block
 block discarded – undo
221 221
 			 ->leftJoin(
222 222
 				 $circleTableAlias, CoreRequestBuilder::TABLE_MEMBER, $alias,
223 223
 				 $expr->andX(
224
-					 $expr->eq($alias . '.circle_id', $circleTableAlias . '.unique_id'),
225
-					 $expr->eq($alias . '.level', $this->createNamedParameter(Member::LEVEL_OWNER))
224
+					 $expr->eq($alias.'.circle_id', $circleTableAlias.'.unique_id'),
225
+					 $expr->eq($alias.'.level', $this->createNamedParameter(Member::LEVEL_OWNER))
226 226
 				 )
227 227
 			 );
228 228
 	}
@@ -248,11 +248,11 @@  discard block
 block discarded – undo
248 248
 			 ->leftJoin(
249 249
 				 $aliasCircle, CoreRequestBuilder::TABLE_MEMBER, $alias,
250 250
 				 $expr->andX(
251
-					 $expr->eq($alias . '.circle_id', $aliasCircle . '.unique_id'),
252
-					 $expr->eq($alias . '.user_id', $this->createNamedParameter($initiator->getUserId())),
253
-					 $expr->eq($alias . '.user_type', $this->createNamedParameter($initiator->getUserType())),
251
+					 $expr->eq($alias.'.circle_id', $aliasCircle.'.unique_id'),
252
+					 $expr->eq($alias.'.user_id', $this->createNamedParameter($initiator->getUserId())),
253
+					 $expr->eq($alias.'.user_type', $this->createNamedParameter($initiator->getUserType())),
254 254
 					 $expr->eq(
255
-						 $alias . '.instance', $this->createNamedParameter($this->getInstance($initiator))
255
+						 $alias.'.instance', $this->createNamedParameter($this->getInstance($initiator))
256 256
 					 )
257 257
 				 )
258 258
 			 );
@@ -278,9 +278,9 @@  discard block
 block discarded – undo
278 278
 		$this->leftJoin(
279 279
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $alias,
280 280
 			$expr->andX(
281
-				$expr->eq($alias . '.circle_id', $aliasCircle . '.unique_id'),
282
-				$expr->eq($alias . '.instance', $this->createNamedParameter($instance)),
283
-				$expr->gte($alias . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
281
+				$expr->eq($alias.'.circle_id', $aliasCircle.'.unique_id'),
282
+				$expr->eq($alias.'.instance', $this->createNamedParameter($instance)),
283
+				$expr->gte($alias.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
284 284
 			)
285 285
 		);
286 286
 	}
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
 		$expr = $this->expr();
301 301
 		$this->leftJoin(
302 302
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_REMOTE, $alias,
303
-			$expr->eq($alias . '.instance', $this->createNamedParameter($instance))
303
+			$expr->eq($alias.'.instance', $this->createNamedParameter($instance))
304 304
 		);
305 305
 	}
306 306
 
@@ -319,15 +319,15 @@  discard block
 block discarded – undo
319 319
 		// - 4 (Visible to everyone)
320 320
 		$orX = $expr->orX();
321 321
 		$orX->add(
322
-			$expr->andX($expr->gte($alias . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER)))
322
+			$expr->andX($expr->gte($alias.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER)))
323 323
 		);
324 324
 		$orX->add(
325 325
 			$expr->andX(
326
-				$expr->bitwiseAnd($aliasCircle . '.config', Circle::CFG_PERSONAL),
327
-				$expr->eq($alias . '.level', $this->createNamedParameter(Member::LEVEL_OWNER))
326
+				$expr->bitwiseAnd($aliasCircle.'.config', Circle::CFG_PERSONAL),
327
+				$expr->eq($alias.'.level', $this->createNamedParameter(Member::LEVEL_OWNER))
328 328
 			)
329 329
 		);
330
-		$orX->add($expr->bitwiseAnd($aliasCircle . '.config', Circle::CFG_VISIBLE));
330
+		$orX->add($expr->bitwiseAnd($aliasCircle.'.config', Circle::CFG_VISIBLE));
331 331
 		$this->andWhere($orX);
332 332
 
333 333
 
@@ -362,10 +362,10 @@  discard block
 block discarded – undo
362 362
 		$expr = $this->expr();
363 363
 
364 364
 		$orHidden = $expr->orX();
365
-		$orHidden->add($expr->bitwiseAnd($alias . '.config', Circle::CFG_SINGLE));
366
-		$orHidden->add($expr->bitwiseAnd($alias . '.config', Circle::CFG_HIDDEN));
367
-		$orHidden->add($expr->bitwiseAnd($alias . '.config', Circle::CFG_BACKEND));
368
-		$this->andWhere($this->createFunction('NOT') . $orHidden);
365
+		$orHidden->add($expr->bitwiseAnd($alias.'.config', Circle::CFG_SINGLE));
366
+		$orHidden->add($expr->bitwiseAnd($alias.'.config', Circle::CFG_HIDDEN));
367
+		$orHidden->add($expr->bitwiseAnd($alias.'.config', Circle::CFG_BACKEND));
368
+		$this->andWhere($this->createFunction('NOT').$orHidden);
369 369
 	}
370 370
 
371 371
 
@@ -394,30 +394,30 @@  discard block
 block discarded – undo
394 394
 
395 395
 		$orX = $expr->orX();
396 396
 		$orX->add(
397
-			$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBAL_SCALE))
397
+			$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBAL_SCALE))
398 398
 		);
399 399
 
400 400
 		$orExtOrPassive = $expr->orX();
401 401
 		$orExtOrPassive->add(
402
-			$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))
402
+			$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))
403 403
 		);
404 404
 		if (!$sensitive) {
405 405
 			$orExtOrPassive->add(
406
-				$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
406
+				$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
407 407
 			);
408 408
 		} else {
409 409
 			if ($this->getDefaultSelectAlias() === 'm') {
410 410
 				$andPassive = $expr->andX();
411 411
 				$andPassive->add(
412
-					$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
412
+					$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
413 413
 				);
414 414
 				$orMemberOrLevel = $expr->orX();
415 415
 				$orMemberOrLevel->add(
416
-					$expr->eq($this->getDefaultSelectAlias() . '.instance', $alias . '.instance')
416
+					$expr->eq($this->getDefaultSelectAlias().'.instance', $alias.'.instance')
417 417
 				);
418 418
 				$orMemberOrLevel->add(
419 419
 					$expr->eq(
420
-						$this->getDefaultSelectAlias() . '.level',
420
+						$this->getDefaultSelectAlias().'.level',
421 421
 						$this->createNamedParameter(Member::LEVEL_OWNER)
422 422
 					)
423 423
 				);
@@ -428,18 +428,18 @@  discard block
 block discarded – undo
428 428
 
429 429
 		$andExternal = $expr->andX();
430 430
 		$andExternal->add($orExtOrPassive);
431
-		$andExternal->add($expr->isNotNull($aliasMembers . '.instance'));
431
+		$andExternal->add($expr->isNotNull($aliasMembers.'.instance'));
432 432
 
433 433
 		$orExtOrTrusted = $expr->orX();
434 434
 		$orExtOrTrusted->add($andExternal);
435 435
 		$orExtOrTrusted->add(
436
-			$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED))
436
+			$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED))
437 437
 		);
438 438
 
439 439
 		$andTrusted = $expr->andX();
440 440
 		$andTrusted->add($orExtOrTrusted);
441
-		$andTrusted->add($expr->bitwiseAnd($aliasCircle . '.config', Circle::CFG_FEDERATED));
442
-		$andTrusted->add($expr->emptyString($aliasOwner . '.instance'));
441
+		$andTrusted->add($expr->bitwiseAnd($aliasCircle.'.config', Circle::CFG_FEDERATED));
442
+		$andTrusted->add($expr->emptyString($aliasOwner.'.instance'));
443 443
 		$orX->add($andTrusted);
444 444
 
445 445
 		$this->andWhere($orX);
@@ -450,7 +450,7 @@  discard block
 block discarded – undo
450 450
 	 * @param int $flag
451 451
 	 */
452 452
 	public function filterConfig(int $flag): void {
453
-		$this->andWhere($this->expr()->bitwiseAnd($this->getDefaultSelectAlias() . '.config', $flag));
453
+		$this->andWhere($this->expr()->bitwiseAnd($this->getDefaultSelectAlias().'.config', $flag));
454 454
 	}
455 455
 
456 456
 
@@ -461,15 +461,15 @@  discard block
 block discarded – undo
461 461
 	 * @return $this
462 462
 	 */
463 463
 	private function generateCircleSelectAlias(string $alias, string $prefix): self {
464
-		$this->selectAlias($alias . '.unique_id', $prefix . 'unique_id')
465
-			 ->selectAlias($alias . '.name', $prefix . 'name')
466
-			 ->selectAlias($alias . '.alt_name', $prefix . 'alt_name')
467
-			 ->selectAlias($alias . '.description', $prefix . 'description')
468
-			 ->selectAlias($alias . '.settings', $prefix . 'settings')
469
-			 ->selectAlias($alias . '.config', $prefix . 'config')
470
-			 ->selectAlias($alias . '.contact_addressbook', $prefix . 'contact_addressbook')
471
-			 ->selectAlias($alias . '.contact_groupname', $prefix . 'contact_groupname')
472
-			 ->selectAlias($alias . '.creation', $prefix . 'creation');
464
+		$this->selectAlias($alias.'.unique_id', $prefix.'unique_id')
465
+			 ->selectAlias($alias.'.name', $prefix.'name')
466
+			 ->selectAlias($alias.'.alt_name', $prefix.'alt_name')
467
+			 ->selectAlias($alias.'.description', $prefix.'description')
468
+			 ->selectAlias($alias.'.settings', $prefix.'settings')
469
+			 ->selectAlias($alias.'.config', $prefix.'config')
470
+			 ->selectAlias($alias.'.contact_addressbook', $prefix.'contact_addressbook')
471
+			 ->selectAlias($alias.'.contact_groupname', $prefix.'contact_groupname')
472
+			 ->selectAlias($alias.'.creation', $prefix.'creation');
473 473
 
474 474
 		return $this;
475 475
 	}
@@ -481,20 +481,20 @@  discard block
 block discarded – undo
481 481
 	 * @return $this
482 482
 	 */
483 483
 	private function generateMemberSelectAlias(string $alias, string $prefix): self {
484
-		$this->selectAlias($alias . '.circle_id', $prefix . 'circle_id')
485
-			 ->selectAlias($alias . '.single_id', $prefix . 'single_id')
486
-			 ->selectAlias($alias . '.user_id', $prefix . 'user_id')
487
-			 ->selectAlias($alias . '.user_type', $prefix . 'user_type')
488
-			 ->selectAlias($alias . '.member_id', $prefix . 'member_id')
489
-			 ->selectAlias($alias . '.instance', $prefix . 'instance')
490
-			 ->selectAlias($alias . '.cached_name', $prefix . 'cached_name')
491
-			 ->selectAlias($alias . '.cached_update', $prefix . 'cached_update')
492
-			 ->selectAlias($alias . '.status', $prefix . 'status')
493
-			 ->selectAlias($alias . '.level', $prefix . 'level')
494
-			 ->selectAlias($alias . '.note', $prefix . 'note')
495
-			 ->selectAlias($alias . '.contact_id', $prefix . 'contact_id')
496
-			 ->selectAlias($alias . '.contact_meta', $prefix . 'contact_meta')
497
-			 ->selectAlias($alias . '.joined', $prefix . 'joined');
484
+		$this->selectAlias($alias.'.circle_id', $prefix.'circle_id')
485
+			 ->selectAlias($alias.'.single_id', $prefix.'single_id')
486
+			 ->selectAlias($alias.'.user_id', $prefix.'user_id')
487
+			 ->selectAlias($alias.'.user_type', $prefix.'user_type')
488
+			 ->selectAlias($alias.'.member_id', $prefix.'member_id')
489
+			 ->selectAlias($alias.'.instance', $prefix.'instance')
490
+			 ->selectAlias($alias.'.cached_name', $prefix.'cached_name')
491
+			 ->selectAlias($alias.'.cached_update', $prefix.'cached_update')
492
+			 ->selectAlias($alias.'.status', $prefix.'status')
493
+			 ->selectAlias($alias.'.level', $prefix.'level')
494
+			 ->selectAlias($alias.'.note', $prefix.'note')
495
+			 ->selectAlias($alias.'.contact_id', $prefix.'contact_id')
496
+			 ->selectAlias($alias.'.contact_meta', $prefix.'contact_meta')
497
+			 ->selectAlias($alias.'.joined', $prefix.'joined');
498 498
 
499 499
 		return $this;
500 500
 	}
Please login to merge, or discard this patch.