Completed
Pull Request — master (#625)
by Maxence
02:28
created
lib/Db/CoreQueryBuilder.php 1 patch
Spacing   +73 added lines, -73 removed lines patch added patch discarded remove patch
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
375 375
 		}
376 376
 
377 377
 		if ($circle->getDisplayName() !== '') {
378
-			$this->searchInDBField('display_name', '%' . $circle->getDisplayName() . '%');
378
+			$this->searchInDBField('display_name', '%'.$circle->getDisplayName().'%');
379 379
 		}
380 380
 		if ($circle->getConfig() > 0) {
381 381
 			$this->limitBitwise('config', $circle->getConfig());
@@ -394,7 +394,7 @@  discard block
 block discarded – undo
394 394
 			$this->generateRemoteInstanceSelectAlias($aliasRemoteInstance)
395 395
 				 ->leftJoin(
396 396
 					 $alias, CoreRequestBuilder::TABLE_REMOTE, $aliasRemoteInstance,
397
-					 $expr->eq($alias . '.instance', $aliasRemoteInstance . '.instance')
397
+					 $expr->eq($alias.'.instance', $aliasRemoteInstance.'.instance')
398 398
 				 );
399 399
 		} catch (RequestBuilderException $e) {
400 400
 		}
@@ -447,7 +447,7 @@  discard block
 block discarded – undo
447 447
 		$expr = $this->expr();
448 448
 		$this->leftJoin(
449 449
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_REMOTE, $aliasRemote,
450
-			$expr->eq($aliasRemote . '.instance', $this->createNamedParameter($remoteInstance->getInstance()))
450
+			$expr->eq($aliasRemote.'.instance', $this->createNamedParameter($remoteInstance->getInstance()))
451 451
 		);
452 452
 	}
453 453
 
@@ -475,12 +475,12 @@  discard block
 block discarded – undo
475 475
 		$this->leftJoin(
476 476
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteMember,
477 477
 			$expr->andX(
478
-				$expr->eq($aliasRemoteMember . '.circle_id', $aliasCircle . '.unique_id'),
478
+				$expr->eq($aliasRemoteMember.'.circle_id', $aliasCircle.'.unique_id'),
479 479
 				$expr->eq(
480
-					$aliasRemoteMember . '.instance',
480
+					$aliasRemoteMember.'.instance',
481 481
 					$this->createNamedParameter($remoteInstance->getInstance())
482 482
 				),
483
-				$expr->gte($aliasRemoteMember . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
483
+				$expr->gte($aliasRemoteMember.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
484 484
 			)
485 485
 		);
486 486
 	}
@@ -512,21 +512,21 @@  discard block
 block discarded – undo
512 512
 		$this->leftJoin(
513 513
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteCircle,
514 514
 			$expr->andX(
515
-				$expr->eq($aliasRemoteCircle . '.single_id', $aliasCircle . '.unique_id'),
516
-				$expr->emptyString($aliasRemoteCircle . '.instance'),
517
-				$expr->gte($aliasRemoteCircle . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
515
+				$expr->eq($aliasRemoteCircle.'.single_id', $aliasCircle.'.unique_id'),
516
+				$expr->emptyString($aliasRemoteCircle.'.instance'),
517
+				$expr->gte($aliasRemoteCircle.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
518 518
 			)
519 519
 		);
520 520
 		$this->leftJoin(
521 521
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteCircleOwner,
522 522
 			$expr->andX(
523
-				$expr->eq($aliasRemoteCircle . '.circle_id', $aliasRemoteCircleOwner . '.circle_id'),
523
+				$expr->eq($aliasRemoteCircle.'.circle_id', $aliasRemoteCircleOwner.'.circle_id'),
524 524
 				$expr->eq(
525
-					$aliasRemoteCircleOwner . '.instance',
525
+					$aliasRemoteCircleOwner.'.instance',
526 526
 					$this->createNamedParameter($remoteInstance->getInstance())
527 527
 				),
528 528
 				$expr->eq(
529
-					$aliasRemoteCircleOwner . '.level', $this->createNamedParameter(Member::LEVEL_OWNER)
529
+					$aliasRemoteCircleOwner.'.level', $this->createNamedParameter(Member::LEVEL_OWNER)
530 530
 				)
531 531
 			)
532 532
 		);
@@ -559,16 +559,16 @@  discard block
 block discarded – undo
559 559
 		$expr = $this->expr();
560 560
 		$orX = $expr->orX();
561 561
 		$orX->add(
562
-			$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBALSCALE))
562
+			$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBALSCALE))
563 563
 		);
564 564
 
565 565
 		$orExtOrPassive = $expr->orX();
566 566
 		$orExtOrPassive->add(
567
-			$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))
567
+			$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))
568 568
 		);
569 569
 		if (!$sensitive) {
570 570
 			$orExtOrPassive->add(
571
-				$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
571
+				$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
572 572
 			);
573 573
 		} else {
574 574
 			if ($this->getDefaultSelectAlias() === CoreQueryBuilder::MEMBER) {
@@ -577,8 +577,8 @@  discard block
 block discarded – undo
577 577
 		}
578 578
 
579 579
 		$orInstance = $expr->orX();
580
-		$orInstance->add($expr->isNotNull($aliasRemoteMember . '.instance'));
581
-		$orInstance->add($expr->isNotNull($aliasRemoteCircleOwner . '.instance'));
580
+		$orInstance->add($expr->isNotNull($aliasRemoteMember.'.instance'));
581
+		$orInstance->add($expr->isNotNull($aliasRemoteCircleOwner.'.instance'));
582 582
 
583 583
 		$andExternal = $expr->andX();
584 584
 		$andExternal->add($orExtOrPassive);
@@ -587,13 +587,13 @@  discard block
 block discarded – undo
587 587
 		$orExtOrTrusted = $expr->orX();
588 588
 		$orExtOrTrusted->add($andExternal);
589 589
 		$orExtOrTrusted->add(
590
-			$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED))
590
+			$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED))
591 591
 		);
592 592
 
593 593
 		$andTrusted = $expr->andX();
594 594
 		$andTrusted->add($orExtOrTrusted);
595 595
 		$andTrusted->add($this->exprLimitBitwise('config', Circle::CFG_FEDERATED, $aliasCircle));
596
-		$andTrusted->add($expr->emptyString($aliasOwner . '.instance'));
596
+		$andTrusted->add($expr->emptyString($aliasOwner.'.instance'));
597 597
 		$orX->add($andTrusted);
598 598
 
599 599
 		$this->andWhere($orX);
@@ -620,7 +620,7 @@  discard block
 block discarded – undo
620 620
 		}
621 621
 		$this->leftJoin(
622 622
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
623
-			$expr->eq($aliasMember . '.circle_id', $alias . '.unique_id')
623
+			$expr->eq($aliasMember.'.circle_id', $alias.'.unique_id')
624 624
 		);
625 625
 
626 626
 		$this->filterDirectMembership($aliasMember, $member);
@@ -641,30 +641,30 @@  discard block
 block discarded – undo
641 641
 
642 642
 		if ($member->getUserId() !== '') {
643 643
 			$andX->add(
644
-				$expr->eq($aliasMember . '.user_id', $this->createNamedParameter($member->getUserId()))
644
+				$expr->eq($aliasMember.'.user_id', $this->createNamedParameter($member->getUserId()))
645 645
 			);
646 646
 		}
647 647
 
648 648
 		if ($member->getSingleId() !== '') {
649 649
 			$andX->add(
650
-				$expr->eq($aliasMember . '.single_id', $this->createNamedParameter($member->getSingleId()))
650
+				$expr->eq($aliasMember.'.single_id', $this->createNamedParameter($member->getSingleId()))
651 651
 			);
652 652
 		}
653 653
 
654 654
 		if ($member->getUserType() > 0) {
655 655
 			$andX->add(
656
-				$expr->eq($aliasMember . '.user_type', $this->createNamedParameter($member->getUserType()))
656
+				$expr->eq($aliasMember.'.user_type', $this->createNamedParameter($member->getUserType()))
657 657
 			);
658 658
 		}
659 659
 
660 660
 		$andX->add(
661
-			$expr->eq($aliasMember . '.instance', $this->createNamedParameter($this->getInstance($member)))
661
+			$expr->eq($aliasMember.'.instance', $this->createNamedParameter($this->getInstance($member)))
662 662
 		);
663 663
 
664 664
 		if ($member->getLevel() > 0) {
665 665
 			$andX->add(
666 666
 				$expr->gte(
667
-					$aliasMember . '.level',
667
+					$aliasMember.'.level',
668 668
 					$this->createNamedParameter($member->getLevel(), IQueryBuilder::PARAM_INT)
669 669
 				)
670 670
 			);
@@ -705,7 +705,7 @@  discard block
 block discarded – undo
705 705
 			$helperAlias,
706 706
 			CoreRequestBuilder::TABLE_CIRCLE,
707 707
 			$aliasCircle,
708
-			$expr->eq($aliasCircle . '.unique_id', $helperAlias . '.' . $field)
708
+			$expr->eq($aliasCircle.'.unique_id', $helperAlias.'.'.$field)
709 709
 		);
710 710
 
711 711
 		if (!is_null($initiator)) {
@@ -736,7 +736,7 @@  discard block
 block discarded – undo
736 736
 		$this->generateCircleSelectAlias($aliasInvitedBy)
737 737
 			 ->leftJoin(
738 738
 				 $aliasMember, CoreRequestBuilder::TABLE_CIRCLE, $aliasInvitedBy,
739
-				 $expr->eq($aliasMember . '.invited_by', $aliasInvitedBy . '.unique_id')
739
+				 $expr->eq($aliasMember.'.invited_by', $aliasInvitedBy.'.unique_id')
740 740
 			 );
741 741
 
742 742
 		$this->leftJoinOwner($aliasInvitedBy);
@@ -767,7 +767,7 @@  discard block
 block discarded – undo
767 767
 		$this->generateCircleSelectAlias($aliasBasedOn)
768 768
 			 ->leftJoin(
769 769
 				 $aliasMember, CoreRequestBuilder::TABLE_CIRCLE, $aliasBasedOn,
770
-				 $expr->eq($aliasBasedOn . '.unique_id', $aliasMember . '.single_id')
770
+				 $expr->eq($aliasBasedOn.'.unique_id', $aliasMember.'.single_id')
771 771
 			 );
772 772
 
773 773
 		if (!is_null($initiator)) {
@@ -800,9 +800,9 @@  discard block
 block discarded – undo
800 800
 			 ->leftJoin(
801 801
 				 $alias, CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
802 802
 				 $expr->andX(
803
-					 $expr->eq($aliasMember . '.circle_id', $alias . '.' . $field),
803
+					 $expr->eq($aliasMember.'.circle_id', $alias.'.'.$field),
804 804
 					 $expr->eq(
805
-						 $aliasMember . '.level',
805
+						 $aliasMember.'.level',
806 806
 						 $this->createNamedParameter(Member::LEVEL_OWNER, self::PARAM_INT)
807 807
 					 )
808 808
 				 )
@@ -840,10 +840,10 @@  discard block
 block discarded – undo
840 840
 			 ->leftJoin(
841 841
 				 $alias, CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
842 842
 				 $expr->andX(
843
-					 $expr->eq($aliasMember . '.circle_id', $alias . '.' . $fieldCircleId),
844
-					 $expr->eq($aliasMember . '.single_id', $alias . '.' . $fieldSingleId),
843
+					 $expr->eq($aliasMember.'.circle_id', $alias.'.'.$fieldCircleId),
844
+					 $expr->eq($aliasMember.'.single_id', $alias.'.'.$fieldSingleId),
845 845
 					 $expr->gte(
846
-						 $aliasMember . '.level',
846
+						 $aliasMember.'.level',
847 847
 						 $this->createNamedParameter(Member::LEVEL_MEMBER, self::PARAM_INT)
848 848
 					 )
849 849
 				 )
@@ -876,7 +876,7 @@  discard block
 block discarded – undo
876 876
 
877 877
 		$this->leftJoin(
878 878
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasMembership,
879
-			$expr->eq($aliasMembership . '.circle_id', $alias . '.' . $field)
879
+			$expr->eq($aliasMembership.'.circle_id', $alias.'.'.$field)
880 880
 		);
881 881
 
882 882
 //		if (!$this->getBool('getData', $options, false)) {
@@ -890,8 +890,8 @@  discard block
 block discarded – undo
890 890
 			 ->leftJoin(
891 891
 				 $alias, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritedBy,
892 892
 				 $expr->andX(
893
-					 $expr->eq($aliasMembership . '.inheritance_last', $aliasInheritedBy . '.circle_id'),
894
-					 $expr->eq($aliasMembership . '.single_id', $aliasInheritedBy . '.single_id')
893
+					 $expr->eq($aliasMembership.'.inheritance_last', $aliasInheritedBy.'.circle_id'),
894
+					 $expr->eq($aliasMembership.'.single_id', $aliasInheritedBy.'.single_id')
895 895
 				 )
896 896
 			 );
897 897
 
@@ -908,12 +908,12 @@  discard block
 block discarded – undo
908 908
 		$aliasUpstreamMembership = $this->generateAlias($alias, self::UPSTREAM_MEMBERSHIPS, $options);
909 909
 		$this->leftJoin(
910 910
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasUpstreamMembership,
911
-			$expr->eq($aliasUpstreamMembership . '.single_id', $this->createNamedParameter($singleId))
911
+			$expr->eq($aliasUpstreamMembership.'.single_id', $this->createNamedParameter($singleId))
912 912
 		);
913 913
 
914 914
 		$orX = $expr->orX(
915
-			$expr->eq($aliasUpstreamMembership . '.circle_id', $alias . '.' . $field),
916
-			$expr->eq($alias . '.' . $field, $this->createNamedParameter($singleId))
915
+			$expr->eq($aliasUpstreamMembership.'.circle_id', $alias.'.'.$field),
916
+			$expr->eq($alias.'.'.$field, $this->createNamedParameter($singleId))
917 917
 		);
918 918
 
919 919
 		$this->andWhere($orX);
@@ -934,11 +934,11 @@  discard block
 block discarded – undo
934 934
 
935 935
 		$expr = $this->expr();
936 936
 		$aliasMembership = $this->generateAlias($alias, self::MEMBERSHIPS);
937
-		$this->andWhere($expr->eq($aliasMembership . '.circle_id', $this->createNamedParameter($singleId)));
937
+		$this->andWhere($expr->eq($aliasMembership.'.circle_id', $this->createNamedParameter($singleId)));
938 938
 		if ($level > 1) {
939 939
 			$this->andWhere(
940 940
 				$expr->gte(
941
-					$aliasMembership . '.level',
941
+					$aliasMembership.'.level',
942 942
 					$this->createNamedParameter($level, IQueryBuilder::PARAM_INT)
943 943
 				)
944 944
 			);
@@ -966,8 +966,8 @@  discard block
 block discarded – undo
966 966
 		$this->leftJoin(
967 967
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasMembership,
968 968
 			$expr->andX(
969
-				$expr->eq($aliasMembership . '.inheritance_last', $alias . '.' . $field),
970
-				$expr->eq($aliasMembership . '.single_id', $alias . '.single_id')
969
+				$expr->eq($aliasMembership.'.inheritance_last', $alias.'.'.$field),
970
+				$expr->eq($aliasMembership.'.single_id', $alias.'.single_id')
971 971
 			)
972 972
 		);
973 973
 
@@ -980,8 +980,8 @@  discard block
 block discarded – undo
980 980
 			 ->leftJoin(
981 981
 				 $aliasMembership, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritanceFrom,
982 982
 				 $expr->andX(
983
-					 $expr->eq($aliasMembership . '.circle_id', $aliasInheritanceFrom . '.circle_id'),
984
-					 $expr->eq($aliasMembership . '.inheritance_first', $aliasInheritanceFrom . '.single_id')
983
+					 $expr->eq($aliasMembership.'.circle_id', $aliasInheritanceFrom.'.circle_id'),
984
+					 $expr->eq($aliasMembership.'.inheritance_first', $aliasInheritanceFrom.'.single_id')
985 985
 				 )
986 986
 			 );
987 987
 	}
@@ -1047,7 +1047,7 @@  discard block
 block discarded – undo
1047 1047
 			$aliasMembership,
1048 1048
 			$expr->andX(
1049 1049
 				$this->exprLimit('single_id', $initiator->getSingleId(), $aliasMembership),
1050
-				$expr->eq($aliasMembership . '.circle_id', $helperAlias . '.' . $field)
1050
+				$expr->eq($aliasMembership.'.circle_id', $helperAlias.'.'.$field)
1051 1051
 			)
1052 1052
 		);
1053 1053
 
@@ -1060,8 +1060,8 @@  discard block
 block discarded – undo
1060 1060
 			$this->leftJoin(
1061 1061
 				$aliasMembership, CoreRequestBuilder::TABLE_MEMBER, $aliasInitiator,
1062 1062
 				$expr->andX(
1063
-					$expr->eq($aliasMembership . '.inheritance_first', $aliasInitiator . '.single_id'),
1064
-					$expr->eq($aliasMembership . '.circle_id', $aliasInitiator . '.circle_id')
1063
+					$expr->eq($aliasMembership.'.inheritance_first', $aliasInitiator.'.single_id'),
1064
+					$expr->eq($aliasMembership.'.circle_id', $aliasInitiator.'.circle_id')
1065 1065
 				)
1066 1066
 			);
1067 1067
 
@@ -1069,8 +1069,8 @@  discard block
 block discarded – undo
1069 1069
 			$this->leftJoin(
1070 1070
 				$aliasInitiator, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritedBy,
1071 1071
 				$expr->andX(
1072
-					$expr->eq($aliasMembership . '.single_id', $aliasInheritedBy . '.single_id'),
1073
-					$expr->eq($aliasMembership . '.inheritance_last', $aliasInheritedBy . '.circle_id')
1072
+					$expr->eq($aliasMembership.'.single_id', $aliasInheritedBy.'.single_id'),
1073
+					$expr->eq($aliasMembership.'.inheritance_last', $aliasInheritedBy.'.circle_id')
1074 1074
 				)
1075 1075
 			);
1076 1076
 
@@ -1090,7 +1090,7 @@  discard block
 block discarded – undo
1090 1090
 			$aliasInheritedByMembership = $this->generateAlias($aliasInheritedBy, self::MEMBERSHIPS);
1091 1091
 			$this->generateMembershipSelectAlias($aliasMembership, $aliasInheritedByMembership);
1092 1092
 		} catch (RequestBuilderException $e) {
1093
-			\OC::$server->getLogger()->log(3, '-- ' . $e->getMessage());
1093
+			\OC::$server->getLogger()->log(3, '-- '.$e->getMessage());
1094 1094
 		}
1095 1095
 	}
1096 1096
 
@@ -1114,7 +1114,7 @@  discard block
 block discarded – undo
1114 1114
 		$orX = $expr->orX();
1115 1115
 		$orX->add(
1116 1116
 			$expr->andX(
1117
-				$expr->gte($aliasMembership . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
1117
+				$expr->gte($aliasMembership.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
1118 1118
 			)
1119 1119
 		);
1120 1120
 
@@ -1122,7 +1122,7 @@  discard block
 block discarded – undo
1122 1122
 			$orX->add(
1123 1123
 				$expr->andX(
1124 1124
 					$this->exprLimitBitwise('config', Circle::CFG_PERSONAL, $alias),
1125
-					$expr->eq($aliasMembership . '.level', $this->createNamedParameter(Member::LEVEL_OWNER))
1125
+					$expr->eq($aliasMembership.'.level', $this->createNamedParameter(Member::LEVEL_OWNER))
1126 1126
 				)
1127 1127
 			);
1128 1128
 		}
@@ -1131,7 +1131,7 @@  discard block
 block discarded – undo
1131 1131
 		}
1132 1132
 		if ($this->getBool('canBeVisitor', $options, false)) {
1133 1133
 			// TODO: should find a better way, also filter on remote initiator on non-federated ?
1134
-			$orX->add($expr->gte($alias . '.config', $this->createNamedParameter(0)));
1134
+			$orX->add($expr->gte($alias.'.config', $this->createNamedParameter(0)));
1135 1135
 		}
1136 1136
 		if ($this->getBool('canBeVisitorOnOpen', $options, false)) {
1137 1137
 			$andOpen = $expr->andX();
@@ -1199,21 +1199,21 @@  discard block
 block discarded – undo
1199 1199
 		$expr = $this->expr();
1200 1200
 		$andPassive = $expr->andX();
1201 1201
 		$andPassive->add(
1202
-			$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
1202
+			$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
1203 1203
 		);
1204 1204
 
1205 1205
 		$orMemberOrLevel = $expr->orX();
1206 1206
 		$orMemberOrLevel->add(
1207
-			$expr->eq($this->getDefaultSelectAlias() . '.instance', $alias . '.instance')
1207
+			$expr->eq($this->getDefaultSelectAlias().'.instance', $alias.'.instance')
1208 1208
 		);
1209 1209
 		// TODO: do we need this ? (display members from the local instance)
1210 1210
 		$orMemberOrLevel->add(
1211
-			$expr->emptyString($this->getDefaultSelectAlias() . '.instance')
1211
+			$expr->emptyString($this->getDefaultSelectAlias().'.instance')
1212 1212
 		);
1213 1213
 
1214 1214
 		$orMemberOrLevel->add(
1215 1215
 			$expr->eq(
1216
-				$this->getDefaultSelectAlias() . '.level',
1216
+				$this->getDefaultSelectAlias().'.level',
1217 1217
 				$this->createNamedParameter(Member::LEVEL_OWNER)
1218 1218
 			)
1219 1219
 		);
@@ -1250,11 +1250,11 @@  discard block
 block discarded – undo
1250 1250
 			 )
1251 1251
 			 ->leftJoin(
1252 1252
 				 $aliasShare, CoreRequestBuilder::TABLE_FILE_CACHE, $aliasFileCache,
1253
-				 $expr->eq($aliasShare . '.file_source', $aliasFileCache . '.fileid')
1253
+				 $expr->eq($aliasShare.'.file_source', $aliasFileCache.'.fileid')
1254 1254
 			 )
1255 1255
 			 ->leftJoin(
1256 1256
 				 $aliasFileCache, CoreRequestBuilder::TABLE_STORAGES, $aliasStorages,
1257
-				 $expr->eq($aliasFileCache . '.storage', $aliasStorages . '.numeric_id')
1257
+				 $expr->eq($aliasFileCache.'.storage', $aliasStorages.'.numeric_id')
1258 1258
 			 );
1259 1259
 	}
1260 1260
 
@@ -1276,8 +1276,8 @@  discard block
 block discarded – undo
1276 1276
 		$this->leftJoin(
1277 1277
 			$aliasShareMemberships, CoreRequestBuilder::TABLE_SHARE, $aliasShareChild,
1278 1278
 			$expr->andX(
1279
-				$expr->eq($aliasShareChild . '.parent', $aliasShare . '.id'),
1280
-				$expr->eq($aliasShareChild . '.share_with', $aliasShareMemberships . '.single_id')
1279
+				$expr->eq($aliasShareChild.'.parent', $aliasShare.'.id'),
1280
+				$expr->eq($aliasShareChild.'.share_with', $aliasShareMemberships.'.single_id')
1281 1281
 			)
1282 1282
 		);
1283 1283
 
@@ -1327,13 +1327,13 @@  discard block
 block discarded – undo
1327 1327
 		$this->leftJoin(
1328 1328
 			$aliasMountMemberships, CoreRequestBuilder::TABLE_MOUNTPOINT, $aliasMountpoint,
1329 1329
 			$expr->andX(
1330
-				$expr->eq($aliasMountpoint . '.mount_id', $aliasMount . '.mount_id'),
1331
-				$expr->eq($aliasMountpoint . '.single_id', $aliasMountMemberships . '.single_id')
1330
+				$expr->eq($aliasMountpoint.'.mount_id', $aliasMount.'.mount_id'),
1331
+				$expr->eq($aliasMountpoint.'.single_id', $aliasMountMemberships.'.single_id')
1332 1332
 			)
1333 1333
 		);
1334 1334
 
1335
-		$this->selectAlias($aliasMountpoint . '.mountpoint', $aliasMountpoint . '_mountpoint');
1336
-		$this->selectAlias($aliasMountpoint . '.mountpoint_hash', $aliasMountpoint . '_mountpoint_hash');
1335
+		$this->selectAlias($aliasMountpoint.'.mountpoint', $aliasMountpoint.'_mountpoint');
1336
+		$this->selectAlias($aliasMountpoint.'.mountpoint_hash', $aliasMountpoint.'_mountpoint_hash');
1337 1337
 	}
1338 1338
 
1339 1339
 
@@ -1437,10 +1437,10 @@  discard block
 block discarded – undo
1437 1437
 	 */
1438 1438
 	public function generateAlias(string $base, string $extension, ?array &$options = []): string {
1439 1439
 		$search = str_replace('_', '.', $base);
1440
-		$path = $search . '.' . $extension;
1440
+		$path = $search.'.'.$extension;
1441 1441
 		if (!$this->validKey($path, self::$SQL_PATH)
1442 1442
 			&& !in_array($extension, $this->getArray($search, self::$SQL_PATH))) {
1443
-			throw new RequestBuilderException($extension . ' not found in ' . $search);
1443
+			throw new RequestBuilderException($extension.' not found in '.$search);
1444 1444
 		}
1445 1445
 
1446 1446
 		if (!is_array($options)) {
@@ -1449,15 +1449,15 @@  discard block
 block discarded – undo
1449 1449
 
1450 1450
 		$optionPath = '';
1451 1451
 		foreach (explode('.', $path) as $p) {
1452
-			$optionPath = trim($optionPath . '.' . $p, '.');
1452
+			$optionPath = trim($optionPath.'.'.$p, '.');
1453 1453
 			$options = array_merge(
1454 1454
 				$options,
1455
-				$this->getArray($optionPath . '.' . self::OPTIONS, self::$SQL_PATH),
1456
-				$this->getArray($optionPath . '.' . self::OPTIONS, $this->options)
1455
+				$this->getArray($optionPath.'.'.self::OPTIONS, self::$SQL_PATH),
1456
+				$this->getArray($optionPath.'.'.self::OPTIONS, $this->options)
1457 1457
 			);
1458 1458
 		}
1459 1459
 
1460
-		return $base . '_' . $extension;
1460
+		return $base.'_'.$extension;
1461 1461
 	}
1462 1462
 
1463 1463
 
@@ -1477,7 +1477,7 @@  discard block
 block discarded – undo
1477 1477
 			} else {
1478 1478
 				$k = $arr;
1479 1479
 			}
1480
-			$path[$k] = $prefix . '_' . $k . '_';
1480
+			$path[$k] = $prefix.'_'.$k.'_';
1481 1481
 		}
1482 1482
 
1483 1483
 		return $path;
Please login to merge, or discard this patch.
lib/Db/MemberRequest.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -239,8 +239,8 @@  discard block
 block discarded – undo
239 239
 			$qb->filterDirectMembership(CoreQueryBuilder::MEMBER, $filter);
240 240
 		}
241 241
 
242
-		$qb->orderBy($qb->getDefaultSelectAlias() . '.level', 'desc');
243
-		$qb->addOrderBy($qb->getDefaultSelectAlias() . '.cached_name', 'asc');
242
+		$qb->orderBy($qb->getDefaultSelectAlias().'.level', 'desc');
243
+		$qb->addOrderBy($qb->getDefaultSelectAlias().'.cached_name', 'asc');
244 244
 
245 245
 		return $this->getItemsFromRequest($qb);
246 246
 	}
@@ -265,8 +265,8 @@  discard block
 block discarded – undo
265 265
 		$qb->limitToMembersByInheritance(CoreQueryBuilder::MEMBER, $singleId, $level);
266 266
 
267 267
 		$aliasMembership = $qb->generateAlias(CoreQueryBuilder::MEMBER, CoreQueryBuilder::MEMBERSHIPS);
268
-		$qb->orderBy($aliasMembership . '.inheritance_depth', 'asc')
269
-		   ->addGroupBy($aliasMembership . '.inheritance_depth');
268
+		$qb->orderBy($aliasMembership.'.inheritance_depth', 'asc')
269
+		   ->addGroupBy($aliasMembership.'.inheritance_depth');
270 270
 
271 271
 		return $this->getItemsFromRequest($qb);
272 272
 	}
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
308 308
 		$qb = $this->getMemberSelectSql();
309 309
 		$qb->limitToCircleId($circleId);
310 310
 
311
-		$qb->andwhere($qb->expr()->nonEmptyString(CoreQueryBuilder::MEMBER . '.instance'));
311
+		$qb->andwhere($qb->expr()->nonEmptyString(CoreQueryBuilder::MEMBER.'.instance'));
312 312
 
313 313
 		return array_map(
314 314
 			function(Member $member): string {
@@ -361,7 +361,7 @@  discard block
 block discarded – undo
361 361
 	 */
362 362
 	public function searchFederatedUsers(string $needle): array {
363 363
 		$qb = $this->getMemberSelectSql();
364
-		$qb->searchInDBField('user_id', '%' . $needle . '%');
364
+		$qb->searchInDBField('user_id', '%'.$needle.'%');
365 365
 
366 366
 		return $this->getItemsFromRequest($qb, true);
367 367
 	}
Please login to merge, or discard this patch.
lib/Service/NotificationService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -146,7 +146,7 @@
 block discarded – undo
146 146
 				continue;
147 147
 			}
148 148
 
149
-			$this->log(3, '### ' . json_encode($moderator));
149
+			$this->log(3, '### '.json_encode($moderator));
150 150
 
151 151
 
152 152
 			$notification = $this->createMemberNotification(
Please login to merge, or discard this patch.