nextcloud / circles

lib/Controller/CirclesController.php

Doc Comments -3 removed lines

@@ -159,7 +159,6 @@ 
 	 * @NoAdminRequired
 	 * @NoSubAdminRequired
 	 *
-	 * @param string $name
 	 *
 	 * @return DataResponse
 	 */
@@ -194,7 +193,6 @@ 
 	 * @NoAdminRequired
 	 * @NoSubAdminRequired
 	 *
-	 * @param string $name
 	 *
 	 * @return DataResponse
 	 */
@@ -233,7 +231,6 @@ 
 	 * @NoAdminRequired
 	 * @NoSubAdminRequired
 	 *
-	 * @param string $name
 	 *
 	 * @return DataResponse
 	 */

Unused Use Statements -2 removed lines

@@ -39,9 +39,7 @@
 use OC\AppFramework\Http;
 use OCP\AppFramework\Controller;
 use OCP\AppFramework\Http\DataResponse;
-use OCP\AppFramework\Http\TemplateResponse;
 use OCP\IL10N;
-use OCP\ILogger;
 use OCP\IRequest;
 
 class CirclesController extends Controller {

lib/Controller/MembersController.php

Doc Comments -1 removed lines

@@ -143,7 +143,6 @@
 	 * @NoAdminRequired
 	 * @NoSubAdminRequired
 	 *
-	 * @param string $name
 	 *
 	 * @return DataResponse
 	 */

Unused Use Statements -2 removed lines

@@ -39,9 +39,7 @@
 use OC\AppFramework\Http;
 use OCP\AppFramework\Controller;
 use OCP\AppFramework\Http\DataResponse;
-use OCP\AppFramework\Http\TemplateResponse;
 use OCP\IL10N;
-use OCP\ILogger;
 use OCP\IRequest;
 
 class MembersController extends Controller {

lib/Model/Circle.php

Doc Comments +15 added lines

@@ -69,6 +69,9 @@ 
 		return $this;
 	}
 
+	/**
+	 * @return string
+	 */
 	public function getName() {
 		return $this->name;
 	}
@@ -78,6 +81,9 @@ 
 		return $this->owner;
 	}
 
+	/**
+	 * @param Member $owner
+	 */
 	public function setOwner($owner) {
 		$this->owner = $owner;
 	}
@@ -87,6 +93,9 @@ 
 		return $this->user;
 	}
 
+	/**
+	 * @param Member $user
+	 */
 	public function setUser($user) {
 		$this->user = $user;
 	}
@@ -116,6 +125,9 @@ 
 		return $this->type;
 	}
 
+	/**
+	 * @param string|null $str
+	 */
 	public function setTypeString($str) {
 		$this->typeString = $str;
 
@@ -126,6 +138,9 @@ 
 		return $this->typeString;
 	}
 
+	/**
+	 * @param string|null $str
+	 */
 	public function setTypeLongString($str) {
 		$this->typeLongString = $str;
 	}

Braces +3 added lines, -2 removed lines

@@ -202,8 +202,9 @@
 		$circle->setDescription($arr['description']);
 		$circle->setType($arr['type']);
 		$circle->setCreation($arr['creation']);
-		if (key_exists('count', $arr))
-			$circle->setCount($arr['count']);
+		if (key_exists('count', $arr)) {
+					$circle->setCount($arr['count']);
+		}
 
 		$owner = new Member();
 		$owner->setUserId($arr['owner']);

lib/Model/iError.php

Doc Comments +3 added lines

@@ -55,6 +55,9 @@
 	function __construct() {
 	}
 
+	/**
+	 * @param string $message
+	 */
 	public function setMessage($message) {
 		$this->message = $message;
 

lib/Service/CirclesService.php

Doc Comments +3 added lines

@@ -55,6 +55,9 @@
 	}
 
 
+	/**
+	 * @param string $name
+	 */
 	public function createCircle($type, $name, &$iError = '') {
 
 		$iError = new iError();

lib/Service/MembersService.php

Doc Comments +3 added lines

@@ -77,6 +77,9 @@
 //		return $result;
 //	}
 
+	/**
+	 * @param string $name
+	 */
 	public function addMember($circleid, $name, &$iError = '') {
 
 		if ($iError === '' || $iError === null) {

lib/ShareByCircleProvider.php

Doc Comments +1 added lines, -1 removed lines

@@ -879,7 +879,7 @@
 	/**
 	 * get database row of a give share
 	 *
-	 * @param $id
+	 * @param integer $id
 	 *
 	 * @return array
 	 * @throws ShareNotFound

Spacing +1 added lines, -1 removed lines

@@ -686,7 +686,7 @@
 		   )
 		   ->leftJoin(
 			   's', 'share', 's2', $qb->expr()
-									  ->eq('s.id', 's2.parent') . ' AND ' . $qb->expr()
+									  ->eq('s.id', 's2.parent').' AND '.$qb->expr()
 																			   ->eq(
 																				   's2.share_with',
 																				   $qb->createNamedParameter(

lib/AppInfo/Application.php

Spacing +16 added lines, -16 removed lines

@@ -64,14 +64,14 @@ 
 		 * Services
 		 */
 		$container->registerService(
-			'MiscService', function ($c) {
+			'MiscService', function($c) {
 			return new MiscService($c->query('Logger'), $c->query('AppName'));
 		}
 		);
 
 
 		$container->registerService(
-			'ConfigService', function ($c) {
+			'ConfigService', function($c) {
 			return new ConfigService(
 				$c->query('AppName'), $c->query('CoreConfig'), $c->query('UserId'),
 				$c->query('MiscService')
@@ -80,7 +80,7 @@ 
 		);
 
 		$container->registerService(
-			'DatabaseService', function ($c) {
+			'DatabaseService', function($c) {
 			return new DatabaseService(
 				$c->query('CirclesMapper'),
 				$c->query('MembersMapper')
@@ -89,7 +89,7 @@ 
 		);
 
 		$container->registerService(
-			'CirclesService', function ($c) {
+			'CirclesService', function($c) {
 			return new CirclesService(
 				$c->query('UserId'), $c->query('L10N'),
 				$c->query('ConfigService'),
@@ -100,7 +100,7 @@ 
 		);
 
 		$container->registerService(
-			'MembersService', function ($c) {
+			'MembersService', function($c) {
 			return new MembersService(
 				$c->query('UserId'), $c->query('L10N'),
 				$c->query('UserManager'),
@@ -133,7 +133,7 @@ 
 //		);
 
 		$container->registerService(
-			'NavigationController', function ($c) {
+			'NavigationController', function($c) {
 			return new NavigationController(
 				$c->query('AppName'), $c->query('Request'), $c->query('UserId'), $c->query('L10N'),
 				$c->query('ConfigService'),
@@ -143,7 +143,7 @@ 
 		);
 
 		$container->registerService(
-			'CirclesController', function ($c) {
+			'CirclesController', function($c) {
 			return new CirclesController(
 				$c->query('AppName'), $c->query('Request'), $c->query('UserId'), $c->query('L10N'),
 				$c->query('ConfigService'),
@@ -154,7 +154,7 @@ 
 		);
 
 		$container->registerService(
-			'MembersController', function ($c) {
+			'MembersController', function($c) {
 			return new MembersController(
 				$c->query('AppName'), $c->query('Request'), $c->query('UserId'), $c->query('L10N'),
 				$c->query('ConfigService'),
@@ -168,7 +168,7 @@ 
 		 * Mapper
 		 */
 		$container->registerService(
-			'CirclesMapper', function ($c) {
+			'CirclesMapper', function($c) {
 			return new CirclesMapper(
 				$c->query('ServerContainer')
 				  ->getDatabaseConnection(), $c->query('MiscService')
@@ -177,7 +177,7 @@ 
 		);
 
 		$container->registerService(
-			'MembersMapper', function ($c) {
+			'MembersMapper', function($c) {
 			return new MembersMapper(
 				$c->query('ServerContainer')
 				  ->getDatabaseConnection(), $c->query('MiscService')
@@ -188,7 +188,7 @@ 
 
 		// Translates
 		$container->registerService(
-			'L10N', function ($c) {
+			'L10N', function($c) {
 			return $c->query('ServerContainer')
 					 ->getL10N($c->query('AppName'));
 		}
@@ -198,20 +198,20 @@ 
 		 * Core
 		 */
 		$container->registerService(
-			'Logger', function ($c) {
+			'Logger', function($c) {
 			return $c->query('ServerContainer')
 					 ->getLogger();
 		}
 		);
 		$container->registerService(
-			'CoreConfig', function ($c) {
+			'CoreConfig', function($c) {
 			return $c->query('ServerContainer')
 					 ->getConfig();
 		}
 		);
 
 		$container->registerService(
-			'UserId', function ($c) {
+			'UserId', function($c) {
 			$user = $c->query('ServerContainer')
 					  ->getUserSession()
 					  ->getUser();
@@ -221,7 +221,7 @@ 
 		);
 
 		$container->registerService(
-			'UserManager', function ($c) {
+			'UserManager', function($c) {
 			return $c->query('ServerContainer')
 					 ->getUserManager();
 		}
@@ -247,7 +247,7 @@ 
 			 ->getServer()
 			 ->getNavigationManager()
 			 ->add(
-				 function () {
+				 function() {
 					 return [
 						 'id'    => $this->appName,
 						 'order' => 5,

lib/Db/CirclesMapper.php

Spacing +1 added lines, -1 removed lines

@@ -225,7 +225,7 @@
 	}
 
 
-	public function create(Circle &$circle, Member &$owner, &$iError = '') {
+	public function create(Circle & $circle, Member & $owner, &$iError = '') {
 
 		if ($iError === '') {
 			$iError = new iError();