Completed
Pull Request — master (#362)
by Maxence
02:45 queued 01:07
created
lib/Controller/GlobalScaleController.php 2 patches
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -53,7 +53,6 @@  discard block
 block discarded – undo
53 53
 	 * @PublicPage
54 54
 	 * @NoCSRFRequired
55 55
 	 *
56
-	 * @param string $data
57 56
 	 *
58 57
 	 * @return DataResponse
59 58
 	 */
@@ -100,7 +99,6 @@  discard block
 block discarded – undo
100 99
 	 * @PublicPage
101 100
 	 * @NoCSRFRequired
102 101
 	 *
103
-	 * @param string $data
104 102
 	 *
105 103
 	 * @return DataResponse
106 104
 	 */
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@
 block discarded – undo
91 91
 			$wrapper = $this->gsUpstreamService->getEventByToken($token);
92 92
 		} catch (Exception $e) {
93 93
 			$this->miscService->log(
94
-				'exception during async: ' . ['token' => $token, 'error' => $e->getMessage()]
94
+				'exception during async: '.['token' => $token, 'error' => $e->getMessage()]
95 95
 			);
96 96
 		}
97 97
 
Please login to merge, or discard this patch.
lib/Model/GlobalScale/GSEvent.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@
 block discarded – undo
94 94
 	}
95 95
 
96 96
 	/**
97
-	 * @param mixed $type
97
+	 * @param string $type
98 98
 	 *
99 99
 	 * @return GSEvent
100 100
 	 */
Please login to merge, or discard this patch.
appinfo/app.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
  *
27 27
  */
28 28
 
29
-require_once __DIR__ . '/autoload.php';
29
+require_once __DIR__.'/autoload.php';
30 30
 
31 31
 $app = \OC::$server->query(\OCA\Circles\AppInfo\Application::class);
32 32
 
Please login to merge, or discard this patch.
lib/Db/CirclesRequest.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -130,7 +130,6 @@
 block discarded – undo
130 130
 
131 131
 	/**
132 132
 	 * @param string $userId
133
-	 * @param string $instanceId
134 133
 	 * @param int $type
135 134
 	 * @param string $name
136 135
 	 * @param int $level
Please login to merge, or discard this patch.
lib/Db/CirclesRequestBuilder.php 1 patch
Doc Comments   +3 added lines, -4 removed lines patch added patch discarded remove patch
@@ -92,7 +92,6 @@  discard block
 block discarded – undo
92 92
 	/**
93 93
 	 * @param IQueryBuilder $qb
94 94
 	 * @param $userId
95
-	 * @param string $instanceId
96 95
 	 * @param string $circleUniqueId
97 96
 	 * @param $type
98 97
 	 * @param $name
@@ -126,9 +125,9 @@  discard block
 block discarded – undo
126 125
 	/**
127 126
 	 * @param IQueryBuilder $qb
128 127
 	 * @param string $circleUniqueId
129
-	 * @param $userId
130
-	 * @param $type
131
-	 * @param $name
128
+	 * @param string $userId
129
+	 * @param integer $type
130
+	 * @param string $name
132 131
 	 * @param bool $forceAll
133 132
 	 *
134 133
 	 * @return array
Please login to merge, or discard this patch.
lib/Db/GSEventsRequest.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,6 @@
 block discarded – undo
52 52
 
53 53
 	/**
54 54
 	 * @param GSEvent $event
55
-	 * @param array $instances
56 55
 	 *
57 56
 	 * @return GSWrapper
58 57
 	 */
Please login to merge, or discard this patch.
lib/Service/GSUpstreamService.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
 			}
141 141
 		} catch (Exception $e) {
142 142
 			$this->miscService->log(
143
-				get_class($e) . ' on new event: ' . $e->getMessage() . ' - ' . json_encode($event), 1
143
+				get_class($e).' on new event: '.$e->getMessage().' - '.json_encode($event), 1
144 144
 			);
145 145
 			throw $e;
146 146
 		}
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
 		$request->setDataSerialize($event);
199 199
 
200 200
 		$result = $this->retrieveJson($request);
201
-		$this->miscService->log('result ' . json_encode($result));
201
+		$this->miscService->log('result '.json_encode($result));
202 202
 		if ($this->getInt('status', $result) === 0) {
203 203
 			throw new GlobalScaleEventException($this->get('error', $result));
204 204
 		}
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
 		RequestServerException |
243 243
 		RequestResultNotJsonException $e
244 244
 		) {
245
-			$this->miscService->log('Issue while retrieving instances from lookup: ' . $e->getMessage());
245
+			$this->miscService->log('Issue while retrieving instances from lookup: '.$e->getMessage());
246 246
 
247 247
 			return [];
248 248
 		}
Please login to merge, or discard this patch.
lib/Service/ConfigService.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
 		if ((!$this->isNonSSLLinksAllowed() || strpos($remote, 'http://') !== 0)
213 213
 			&& strpos($remote, 'https://') !== 0
214 214
 		) {
215
-			$remote = 'https://' . $remote;
215
+			$remote = 'https://'.$remote;
216 216
 		}
217 217
 
218 218
 		return rtrim($remote, '/');
@@ -399,7 +399,7 @@  discard block
 block discarded – undo
399 399
 				return false;
400 400
 			}
401 401
 
402
-			throw new GSStatusException('GS and lookup are not configured : ' . $lookup . ', ' . $enabled);
402
+			throw new GSStatusException('GS and lookup are not configured : '.$lookup.', '.$enabled);
403 403
 		}
404 404
 
405 405
 		$clef = $this->config->getSystemValue('gss.jwt.key', '');
Please login to merge, or discard this patch.
lib/GlobalScale/MemberCreate.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -111,13 +111,13 @@
 block discarded – undo
111 111
 	 * @throws MemberAlreadyExistsException
112 112
 	 */
113 113
 	public function manage(GSEvent $event): void {
114
-		$this->miscService->log('new event; ' . json_encode($event));
114
+		$this->miscService->log('new event; '.json_encode($event));
115 115
 		if (!$event->hasCircle() || !$event->hasMember()) {
116 116
 			return;
117 117
 		}
118 118
 
119 119
 		$member = $event->getMember();
120
-		$this->miscService->log('new event; ' . json_encode($member));
120
+		$this->miscService->log('new event; '.json_encode($member));
121 121
 
122 122
 //		if ($member->getInstance() === '') {
123 123
 //			$member->setInstance($event->getSource());
Please login to merge, or discard this patch.