nextcloud / circles

lib/Model/BaseCircle.php

Doc Comments +6 added lines, -6 removed lines

@@ -400,7 +400,7 @@ 
 	}
 
 	/**
-	 * @return string
+	 * @return integer
 	 */
 	public function getType() {
 		return $this->type;
@@ -425,7 +425,7 @@ 
 	}
 
 	/**
-	 * @param array $members
+	 * @param Member[] $members
 	 *
 	 * @return BaseCircle
 	 */
@@ -436,7 +436,7 @@ 
 	}
 
 	/**
-	 * @return array
+	 * @return Member[]
 	 */
 	public function getMembers() {
 		return $this->members;
@@ -454,7 +454,7 @@ 
 	}
 
 	/**
-	 * @return array
+	 * @return Member[]
 	 */
 	public function getGroups() {
 		return $this->groups;
@@ -472,7 +472,7 @@ 
 	}
 
 	/**
-	 * @return array
+	 * @return FederatedLink[]
 	 */
 	public function getLinks() {
 		return $this->links;
@@ -508,7 +508,7 @@ 
 //	}
 
 	/**
-	 * @param integer|string $type
+	 * @param string $type
 	 *
 	 * @return integer
 	 */

lib/Db/MembersRequest.php

Doc Comments +4 added lines, -3 removed lines

@@ -232,7 +232,7 @@ 
 	 * returns the index of a specific UserID in a Members List
 	 *
 	 * @param array $members
-	 * @param $userId
+	 * @param string $userId
 	 *
 	 * @return int
 	 */
@@ -545,6 +545,9 @@ 
 	}
 
 
+	/**
+	 * @param string $groupId
+	 */
 	public function unlinkAllFromGroup($groupId) {
 		$qb = $this->getGroupsDeleteSql($groupId);
 		$qb->execute();
@@ -575,8 +578,6 @@ 
 	/**
 	 * @param string $circleId
 	 * @param string $contactId
-	 * @param string $userId
-	 * @param int $type
 	 *
 	 * @return Member
 	 * @throws MemberDoesNotExistException

appinfo/app.php

Spacing +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
 use OCA\Circles\AppInfo\Application;
 
 
-require_once __DIR__ . '/autoload.php';
+require_once __DIR__.'/autoload.php';
 
 
 $app = \OC::$server->query(Application::class);

lib/Model/DavCard.php

Spacing +1 added lines, -1 removed lines

@@ -146,7 +146,7 @@
 	 * @return string
 	 */
 	public function getUniqueId(): string {
-		return $this->getAddressBookId() . '/' . $this->getCardUri();
+		return $this->getAddressBookId().'/'.$this->getCardUri();
 	}
 
 

lib/Service/DavService.php

Spacing +5 added lines, -5 removed lines

@@ -152,7 +152,7 @@ 
 	public function onDeleteCard(GenericEvent $event) {
 		$davCard = $this->generateDavCard($event, true);
 
-		$this->miscService->log('Deleting Card: ' . json_encode($davCard), 1);
+		$this->miscService->log('Deleting Card: '.json_encode($davCard), 1);
 		$this->membersRequest->removeMembersByContactId($davCard->getUniqueId(), Member::TYPE_USER);
 	}
 
@@ -206,7 +206,7 @@ 
 	 *
 	 */
 	private function manageDavCard(DavCard $davCard) {
-		$this->miscService->log('Updating Card: ' . json_encode($davCard), 1);
+		$this->miscService->log('Updating Card: '.json_encode($davCard), 1);
 		$this->manageCircles($davCard);
 		$this->manageContact($davCard);
 	}
@@ -320,7 +320,7 @@ 
 			}
 		}
 
-		$davCard->setUserId($davCard->getOwner() . ':' . $davCard->getContactId());
+		$davCard->setUserId($davCard->getOwner().':'.$davCard->getContactId());
 
 		return DavCard::TYPE_CONTACT;
 	}
@@ -378,7 +378,7 @@ 
 				continue;
 			}
 
-			$circle = new Circle(Circle::CIRCLES_PUBLIC, $group . ' - ' . $this->uuid(5));
+			$circle = new Circle(Circle::CIRCLES_PUBLIC, $group.' - '.$this->uuid(5));
 			$circle->setContactAddressBook($davCard->getAddressBookId());
 			$circle->setContactGroupName($group);
 
@@ -477,7 +477,7 @@ 
 		$this->manageDeprecatedCircles();
 		$users = $this->userManager->search('');
 		foreach ($users as $user) {
-			$books = $this->cardDavBackend->getAddressBooksForUser('principals/users/' . $user->getUID());
+			$books = $this->cardDavBackend->getAddressBooksForUser('principals/users/'.$user->getUID());
 			foreach ($books as $book) {
 				$this->migrateBook($book['id']);
 			}

lib/Circles/FileSharingBroadcaster.php

Doc Comments +8 added lines, -10 removed lines

@@ -338,7 +338,7 @@ 
 	 * @param Circle $circle
 	 * @param IShare $share
 	 * @param string $address
-	 * @param string $token
+	 * @param SharesToken $token
 	 *
 	 * @return bool
 	 */
@@ -418,7 +418,7 @@ 
 	 * @param $fileName
 	 * @param string $link
 	 * @param string $author
-	 * @param $circleName
+	 * @param string $circleName
 	 * @param string $email
 	 *
 	 * @throws Exception
@@ -455,7 +455,7 @@ 
 	 * @param string $circleName
 	 * @param string $email
 	 *
-	 * @param $password
+	 * @param string $password
 	 *
 	 * @throws NotFoundException
 	 * @throws Exception
@@ -537,7 +537,7 @@ 
 	 * @param $subject
 	 * @param $text
 	 * @param $fileName
-	 * @param $link
+	 * @param string $link
 	 * @param string $author
 	 * @param string $circleName
 	 *
@@ -575,7 +575,6 @@ 
 	 * @param Member $member
 	 * @param string $recipient
 	 * @param string $circleName
-	 * @param string $password
 	 */
 	public function sendMailExitingShares(
 		array $unknownShares, $author, Member $member, $recipient, $circleName
@@ -608,7 +607,7 @@ 
 
 
 	/**
-	 * @param $author
+	 * @param string $author
 	 * @param string $email
 	 *
 	 * @param $password
@@ -682,7 +681,6 @@ 
 	 * @param array $share
 	 * @param Member $member
 	 * @param string $password
-	 * @param string $token
 	 *
 	 * @return array
 	 * @throws TokenDoesNotExistException
@@ -707,7 +705,7 @@ 
 
 
 	/**
-	 * @param $author
+	 * @param string $author
 	 * @param string $circleName
 	 *
 	 * @return IEMailTemplate
@@ -750,8 +748,8 @@ 
 
 	/**
 	 * @param IEMailTemplate $emailTemplate
-	 * @param $author
-	 * @param $recipient
+	 * @param string $author
+	 * @param string $recipient
 	 *
 	 * @throws Exception
 	 */

Spacing +13 added lines, -13 removed lines

@@ -141,7 +141,7 @@ 
 			$this->miscService = OC::$server->query(MiscService::class);
 		} catch (QueryException $e) {
 			OC::$server->getLogger()
-					   ->log(1, 'Circles: cannot init FileSharingBroadcaster - ' . $e->getMessage());
+					   ->log(1, 'Circles: cannot init FileSharingBroadcaster - '.$e->getMessage());
 		}
 
 		try {
@@ -298,7 +298,7 @@ 
 		if ($member->getType() === Member::TYPE_CONTACT) {
 			$recipient = MiscService::getContactData($member->getUserId());
 			// TODO: CHECK THIS CHECK THIS CHECK TINS :: Get email from Contact
-			$this->miscService->log('___ RECIPIENT !! ' . json_encode($recipient));
+			$this->miscService->log('___ RECIPIENT !! '.json_encode($recipient));
 		}
 
 		$recipient = $member->getUserId();
@@ -318,7 +318,7 @@ 
 	 * @throws IllegalIDChangeException
 	 */
 	private function generateShare($data): IShare {
-		$this->logger->log(0, 'Regenerate shares from payload: ' . json_encode($data));
+		$this->logger->log(0, 'Regenerate shares from payload: '.json_encode($data));
 
 		$share = new Share($this->rootFolder, $this->userManager);
 		$share->setId($data['id']);
@@ -409,7 +409,7 @@ 
 			);
 		} catch (Exception $e) {
 			OC::$server->getLogger()
-					   ->log(1, 'Circles::sharedByMail - mail were not sent: ' . $e->getMessage());
+					   ->log(1, 'Circles::sharedByMail - mail were not sent: '.$e->getMessage());
 		}
 	}
 
@@ -427,8 +427,8 @@ 
 		$message = $this->mailer->createMessage();
 
 		$this->logger->log(
-			0, "Sending mail to circle '" . $circleName . "': " . $email . ' file: ' . $fileName
-			   . ' - link: ' . $link
+			0, "Sending mail to circle '".$circleName."': ".$email.' file: '.$fileName
+			   . ' - link: '.$link
 		);
 
 		$subject = $this->l10n->t('%s shared »%s« with you.', [$author, $fileName]);
@@ -467,7 +467,7 @@ 
 
 		$message = $this->mailer->createMessage();
 
-		$this->logger->log(0, "Sending password mail to circle '" . $circleName . "': " . $email);
+		$this->logger->log(0, "Sending password mail to circle '".$circleName."': ".$email);
 
 		$filename = $share->getNode()
 						  ->getName();
@@ -522,7 +522,7 @@ 
 		$message->setFrom([\OCP\Util::getDefaultEmailAddress($instanceName) => $senderName]);
 		if ($initiatorEmailAddress !== null) {
 			$message->setReplyTo([$initiatorEmailAddress => $initiatorDisplayName]);
-			$emailTemplate->addFooter($instanceName . ' - ' . $this->defaults->getSlogan());
+			$emailTemplate->addFooter($instanceName.' - '.$this->defaults->getSlogan());
 		} else {
 			$emailTemplate->addFooter();
 		}
@@ -557,7 +557,7 @@ 
 		$emailTemplate->addHeader();
 		$emailTemplate->addHeading($subject, false);
 		$emailTemplate->addBodyText(
-			htmlspecialchars($text) . '<br>' . htmlspecialchars(
+			htmlspecialchars($text).'<br>'.htmlspecialchars(
 				$this->l10n->t('Click the button below to open it.')
 			), $text
 		);
@@ -602,7 +602,7 @@ 
 			$this->sendMailExistingShares($template, $author, $recipient);
 			$this->sendPasswordExistingShares($author, $recipient, $password);
 		} catch (Exception $e) {
-			$this->logger->log(2, 'Failed to send mail about existing share ' . $e->getMessage());
+			$this->logger->log(2, 'Failed to send mail about existing share '.$e->getMessage());
 		}
 	}
 
@@ -626,7 +626,7 @@ 
 		$authorName = ($authorUser instanceof IUser) ? $authorUser->getDisplayName() : $author;
 		$authorEmail = ($authorUser instanceof IUser) ? $authorUser->getEMailAddress() : null;
 
-		$this->logger->log(0, "Sending password mail about existing files to '" . $email . "'");
+		$this->logger->log(0, "Sending password mail about existing files to '".$email."'");
 
 		$plainBodyPart = $this->l10n->t(
 			"%1\$s shared multiple files with you.\nYou should have already received a separate mail with a link to access them.\n",
@@ -668,7 +668,7 @@ 
 		$message->setFrom([\OCP\Util::getDefaultEmailAddress($instanceName) => $senderName]);
 		if ($authorEmail !== null) {
 			$message->setReplyTo([$authorEmail => $authorName]);
-			$emailTemplate->addFooter($instanceName . ' - ' . $this->defaults->getSlogan());
+			$emailTemplate->addFooter($instanceName.' - '.$this->defaults->getSlogan());
 		} else {
 			$emailTemplate->addFooter();
 		}
@@ -715,7 +715,7 @@ 
 	 */
 	protected function generateMailExitingShares($author, $circleName) {
 		$this->logger->log(
-			0, "Generating mail about existing share mail from '" . $author . "' in "
+			0, "Generating mail about existing share mail from '".$author."' in "
 			   . $circleName
 		);
 

lib/Db/TokensRequestBuilder.php

Doc Comments +3 added lines

@@ -131,6 +131,9 @@
 	}
 
 
+	/**
+	 * @param string $encoded
+	 */
 	protected function origPasswordDecrypt($encoded): string {
 		$key = $this->configService->getInstanceId();
 		$c = base64_decode($encoded);

Spacing +1 added lines, -1 removed lines

@@ -127,7 +127,7 @@
 		$raw = openssl_encrypt($password, $cipher, $key, $options = OPENSSL_RAW_DATA, $iv);
 		$hmac = hash_hmac('sha256', $raw, $key, $as_binary = true);
 
-		return base64_encode($iv . $hmac . $raw);
+		return base64_encode($iv.$hmac.$raw);
 	}
 
 

lib/Service/ConfigService.php

Doc Comments +3 added lines

@@ -406,6 +406,9 @@
 	}
 
 
+	/**
+	 * @return string
+	 */
 	public function getInstanceId() {
 		return $this->config->getSystemValue('instanceid');
 	}