Completed
Push — master ( 908eaf...3a56d9 )
by Maxence
02:45
created
lib/Db/CoreQueryBuilder.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -644,7 +644,7 @@
 block discarded – undo
644 644
 	 * @param string $alias
645 645
 	 * @param IFederatedUser|null $initiator
646 646
 	 * @param string $field
647
-	 * @param string $helpedAlias
647
+	 * @param string $helperAlias
648 648
 	 *
649 649
 	 * @throws RequestBuilderException
650 650
 	 */
Please login to merge, or discard this patch.
Spacing   +78 added lines, -78 removed lines patch added patch discarded remove patch
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
 	 * @param int $config
266 266
 	 */
267 267
 	public function limitToConfigFlag(int $config): void {
268
-		$this->andWhere($this->expr()->bitwiseAnd($this->getDefaultSelectAlias() . '.config', $config));
268
+		$this->andWhere($this->expr()->bitwiseAnd($this->getDefaultSelectAlias().'.config', $config));
269 269
 	}
270 270
 
271 271
 
@@ -349,7 +349,7 @@  discard block
 block discarded – undo
349 349
 		}
350 350
 
351 351
 		if ($circle->getDisplayName() !== '') {
352
-			$this->searchInDBField('display_name', '%' . $circle->getDisplayName() . '%');
352
+			$this->searchInDBField('display_name', '%'.$circle->getDisplayName().'%');
353 353
 		}
354 354
 	}
355 355
 
@@ -365,7 +365,7 @@  discard block
 block discarded – undo
365 365
 			$this->generateRemoteInstanceSelectAlias($aliasRemoteInstance)
366 366
 				 ->leftJoin(
367 367
 					 $alias, CoreRequestBuilder::TABLE_REMOTE, $aliasRemoteInstance,
368
-					 $expr->eq($alias . '.instance', $aliasRemoteInstance . '.instance')
368
+					 $expr->eq($alias.'.instance', $aliasRemoteInstance.'.instance')
369 369
 				 );
370 370
 		} catch (RequestBuilderException $e) {
371 371
 		}
@@ -418,7 +418,7 @@  discard block
 block discarded – undo
418 418
 		$expr = $this->expr();
419 419
 		$this->leftJoin(
420 420
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_REMOTE, $aliasRemote,
421
-			$expr->eq($aliasRemote . '.instance', $this->createNamedParameter($remoteInstance->getInstance()))
421
+			$expr->eq($aliasRemote.'.instance', $this->createNamedParameter($remoteInstance->getInstance()))
422 422
 		);
423 423
 	}
424 424
 
@@ -446,12 +446,12 @@  discard block
 block discarded – undo
446 446
 		$this->leftJoin(
447 447
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteMember,
448 448
 			$expr->andX(
449
-				$expr->eq($aliasRemoteMember . '.circle_id', $aliasCircle . '.unique_id'),
449
+				$expr->eq($aliasRemoteMember.'.circle_id', $aliasCircle.'.unique_id'),
450 450
 				$expr->eq(
451
-					$aliasRemoteMember . '.instance',
451
+					$aliasRemoteMember.'.instance',
452 452
 					$this->createNamedParameter($remoteInstance->getInstance())
453 453
 				),
454
-				$expr->gte($aliasRemoteMember . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
454
+				$expr->gte($aliasRemoteMember.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
455 455
 			)
456 456
 		);
457 457
 	}
@@ -483,21 +483,21 @@  discard block
 block discarded – undo
483 483
 		$this->leftJoin(
484 484
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteCircle,
485 485
 			$expr->andX(
486
-				$expr->eq($aliasRemoteCircle . '.single_id', $aliasCircle . '.unique_id'),
487
-				$expr->emptyString($aliasRemoteCircle . '.instance'),
488
-				$expr->gte($aliasRemoteCircle . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
486
+				$expr->eq($aliasRemoteCircle.'.single_id', $aliasCircle.'.unique_id'),
487
+				$expr->emptyString($aliasRemoteCircle.'.instance'),
488
+				$expr->gte($aliasRemoteCircle.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
489 489
 			)
490 490
 		);
491 491
 		$this->leftJoin(
492 492
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteCircleOwner,
493 493
 			$expr->andX(
494
-				$expr->eq($aliasRemoteCircle . '.circle_id', $aliasRemoteCircleOwner . '.circle_id'),
494
+				$expr->eq($aliasRemoteCircle.'.circle_id', $aliasRemoteCircleOwner.'.circle_id'),
495 495
 				$expr->eq(
496
-					$aliasRemoteCircleOwner . '.instance',
496
+					$aliasRemoteCircleOwner.'.instance',
497 497
 					$this->createNamedParameter($remoteInstance->getInstance())
498 498
 				),
499 499
 				$expr->eq(
500
-					$aliasRemoteCircleOwner . '.level', $this->createNamedParameter(Member::LEVEL_OWNER)
500
+					$aliasRemoteCircleOwner.'.level', $this->createNamedParameter(Member::LEVEL_OWNER)
501 501
 				)
502 502
 			)
503 503
 		);
@@ -530,16 +530,16 @@  discard block
 block discarded – undo
530 530
 		$expr = $this->expr();
531 531
 		$orX = $expr->orX();
532 532
 		$orX->add(
533
-			$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBALSCALE))
533
+			$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBALSCALE))
534 534
 		);
535 535
 
536 536
 		$orExtOrPassive = $expr->orX();
537 537
 		$orExtOrPassive->add(
538
-			$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))
538
+			$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))
539 539
 		);
540 540
 		if (!$sensitive) {
541 541
 			$orExtOrPassive->add(
542
-				$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
542
+				$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
543 543
 			);
544 544
 		} else {
545 545
 			if ($this->getDefaultSelectAlias() === CoreQueryBuilder::MEMBER) {
@@ -548,8 +548,8 @@  discard block
 block discarded – undo
548 548
 		}
549 549
 
550 550
 		$orInstance = $expr->orX();
551
-		$orInstance->add($expr->isNotNull($aliasRemoteMember . '.instance'));
552
-		$orInstance->add($expr->isNotNull($aliasRemoteCircleOwner . '.instance'));
551
+		$orInstance->add($expr->isNotNull($aliasRemoteMember.'.instance'));
552
+		$orInstance->add($expr->isNotNull($aliasRemoteCircleOwner.'.instance'));
553 553
 
554 554
 		$andExternal = $expr->andX();
555 555
 		$andExternal->add($orExtOrPassive);
@@ -558,13 +558,13 @@  discard block
 block discarded – undo
558 558
 		$orExtOrTrusted = $expr->orX();
559 559
 		$orExtOrTrusted->add($andExternal);
560 560
 		$orExtOrTrusted->add(
561
-			$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED))
561
+			$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED))
562 562
 		);
563 563
 
564 564
 		$andTrusted = $expr->andX();
565 565
 		$andTrusted->add($orExtOrTrusted);
566
-		$andTrusted->add($expr->bitwiseAnd($aliasCircle . '.config', Circle::CFG_FEDERATED));
567
-		$andTrusted->add($expr->emptyString($aliasOwner . '.instance'));
566
+		$andTrusted->add($expr->bitwiseAnd($aliasCircle.'.config', Circle::CFG_FEDERATED));
567
+		$andTrusted->add($expr->emptyString($aliasOwner.'.instance'));
568 568
 		$orX->add($andTrusted);
569 569
 
570 570
 		$this->andWhere($orX);
@@ -591,7 +591,7 @@  discard block
 block discarded – undo
591 591
 		}
592 592
 		$this->leftJoin(
593 593
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
594
-			$expr->eq($aliasMember . '.circle_id', $alias . '.unique_id')
594
+			$expr->eq($aliasMember.'.circle_id', $alias.'.unique_id')
595 595
 		);
596 596
 
597 597
 		$this->filterDirectMembership($aliasMember, $member);
@@ -612,28 +612,28 @@  discard block
 block discarded – undo
612 612
 
613 613
 		if ($member->getUserId() !== '') {
614 614
 			$andX->add(
615
-				$expr->eq($aliasMember . '.user_id', $this->createNamedParameter($member->getUserId()))
615
+				$expr->eq($aliasMember.'.user_id', $this->createNamedParameter($member->getUserId()))
616 616
 			);
617 617
 		}
618 618
 
619 619
 		if ($member->getSingleId() !== '') {
620 620
 			$andX->add(
621
-				$expr->eq($aliasMember . '.single_id', $this->createNamedParameter($member->getSingleId()))
621
+				$expr->eq($aliasMember.'.single_id', $this->createNamedParameter($member->getSingleId()))
622 622
 			);
623 623
 		}
624 624
 
625 625
 		if ($member->getUserType() > 0) {
626 626
 			$andX->add(
627
-				$expr->eq($aliasMember . '.user_type', $this->createNamedParameter($member->getUserType()))
627
+				$expr->eq($aliasMember.'.user_type', $this->createNamedParameter($member->getUserType()))
628 628
 			);
629 629
 		}
630 630
 
631 631
 		$andX->add(
632
-			$expr->eq($aliasMember . '.instance', $this->createNamedParameter($this->getInstance($member)))
632
+			$expr->eq($aliasMember.'.instance', $this->createNamedParameter($this->getInstance($member)))
633 633
 		);
634 634
 
635 635
 		if ($member->getLevel() > 0) {
636
-			$andX->add($expr->gte($aliasMember . '.level', $this->createNamedParameter($member->getLevel())));
636
+			$andX->add($expr->gte($aliasMember.'.level', $this->createNamedParameter($member->getLevel())));
637 637
 		}
638 638
 
639 639
 		$this->andWhere($andX);
@@ -671,7 +671,7 @@  discard block
 block discarded – undo
671 671
 			$helperAlias,
672 672
 			CoreRequestBuilder::TABLE_CIRCLE,
673 673
 			$aliasCircle,
674
-			$expr->eq($aliasCircle . '.unique_id', $helperAlias . '.' . $field)
674
+			$expr->eq($aliasCircle.'.unique_id', $helperAlias.'.'.$field)
675 675
 		);
676 676
 
677 677
 		if (!is_null($initiator)) {
@@ -706,7 +706,7 @@  discard block
 block discarded – undo
706 706
 		$this->generateCircleSelectAlias($aliasBasedOn)
707 707
 			 ->leftJoin(
708 708
 				 $aliasMember, CoreRequestBuilder::TABLE_CIRCLE, $aliasBasedOn,
709
-				 $expr->eq($aliasBasedOn . '.unique_id', $aliasMember . '.single_id')
709
+				 $expr->eq($aliasBasedOn.'.unique_id', $aliasMember.'.single_id')
710 710
 			 );
711 711
 
712 712
 		if (!is_null($initiator)) {
@@ -739,9 +739,9 @@  discard block
 block discarded – undo
739 739
 			 ->leftJoin(
740 740
 				 $alias, CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
741 741
 				 $expr->andX(
742
-					 $expr->eq($aliasMember . '.circle_id', $alias . '.' . $field),
742
+					 $expr->eq($aliasMember.'.circle_id', $alias.'.'.$field),
743 743
 					 $expr->eq(
744
-						 $aliasMember . '.level',
744
+						 $aliasMember.'.level',
745 745
 						 $this->createNamedParameter(Member::LEVEL_OWNER, self::PARAM_INT)
746 746
 					 )
747 747
 				 )
@@ -779,10 +779,10 @@  discard block
 block discarded – undo
779 779
 			 ->leftJoin(
780 780
 				 $alias, CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
781 781
 				 $expr->andX(
782
-					 $expr->eq($aliasMember . '.circle_id', $alias . '.' . $fieldCircleId),
783
-					 $expr->eq($aliasMember . '.single_id', $alias . '.' . $fieldSingleId),
782
+					 $expr->eq($aliasMember.'.circle_id', $alias.'.'.$fieldCircleId),
783
+					 $expr->eq($aliasMember.'.single_id', $alias.'.'.$fieldSingleId),
784 784
 					 $expr->gte(
785
-						 $aliasMember . '.level',
785
+						 $aliasMember.'.level',
786 786
 						 $this->createNamedParameter(Member::LEVEL_MEMBER, self::PARAM_INT)
787 787
 					 )
788 788
 				 )
@@ -812,7 +812,7 @@  discard block
 block discarded – undo
812 812
 
813 813
 		$this->leftJoin(
814 814
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasMembership,
815
-			$expr->eq($aliasMembership . '.circle_id', $alias . '.' . $field)
815
+			$expr->eq($aliasMembership.'.circle_id', $alias.'.'.$field)
816 816
 		);
817 817
 
818 818
 //		if (!$this->getBool('getData', $options, false)) {
@@ -826,8 +826,8 @@  discard block
 block discarded – undo
826 826
 			 ->leftJoin(
827 827
 				 $alias, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritedBy,
828 828
 				 $expr->andX(
829
-					 $expr->eq($aliasMembership . '.inheritance_last', $aliasInheritedBy . '.circle_id'),
830
-					 $expr->eq($aliasMembership . '.single_id', $aliasInheritedBy . '.single_id')
829
+					 $expr->eq($aliasMembership.'.inheritance_last', $aliasInheritedBy.'.circle_id'),
830
+					 $expr->eq($aliasMembership.'.single_id', $aliasInheritedBy.'.single_id')
831 831
 				 )
832 832
 			 );
833 833
 
@@ -844,12 +844,12 @@  discard block
 block discarded – undo
844 844
 		$aliasUpstreamMembership = $this->generateAlias($alias, self::UPSTREAM_MEMBERSHIPS, $options);
845 845
 		$this->leftJoin(
846 846
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasUpstreamMembership,
847
-			$expr->eq($aliasUpstreamMembership . '.single_id', $this->createNamedParameter($singleId))
847
+			$expr->eq($aliasUpstreamMembership.'.single_id', $this->createNamedParameter($singleId))
848 848
 		);
849 849
 
850 850
 		$orX = $expr->orX(
851
-			$expr->eq($aliasUpstreamMembership . '.circle_id', $alias . '.' . $field),
852
-			$expr->eq($alias . '.' . $field, $this->createNamedParameter($singleId))
851
+			$expr->eq($aliasUpstreamMembership.'.circle_id', $alias.'.'.$field),
852
+			$expr->eq($alias.'.'.$field, $this->createNamedParameter($singleId))
853 853
 		);
854 854
 
855 855
 		$this->andWhere($orX);
@@ -869,7 +869,7 @@  discard block
 block discarded – undo
869 869
 
870 870
 		$expr = $this->expr();
871 871
 		$aliasMembership = $this->generateAlias($alias, self::MEMBERSHIPS);
872
-		$this->andWhere($expr->eq($aliasMembership . '.circle_id', $this->createNamedParameter($singleId)));
872
+		$this->andWhere($expr->eq($aliasMembership.'.circle_id', $this->createNamedParameter($singleId)));
873 873
 	}
874 874
 
875 875
 
@@ -893,7 +893,7 @@  discard block
 block discarded – undo
893 893
 		$this->leftJoin(
894 894
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasMembership,
895 895
 //			$expr->andX(
896
-			$expr->eq($aliasMembership . '.inheritance_last', $alias . '.' . $field)
896
+			$expr->eq($aliasMembership.'.inheritance_last', $alias.'.'.$field)
897 897
 //				$expr->eq($aliasMembership . '.single_id', $alias . '.single_id')
898 898
 //			)
899 899
 		);
@@ -907,8 +907,8 @@  discard block
 block discarded – undo
907 907
 			 ->leftJoin(
908 908
 				 $aliasMembership, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritanceFrom,
909 909
 				 $expr->andX(
910
-					 $expr->eq($aliasMembership . '.circle_id', $aliasInheritanceFrom . '.circle_id'),
911
-					 $expr->eq($aliasMembership . '.inheritance_first', $aliasInheritanceFrom . '.single_id')
910
+					 $expr->eq($aliasMembership.'.circle_id', $aliasInheritanceFrom.'.circle_id'),
911
+					 $expr->eq($aliasMembership.'.inheritance_first', $aliasInheritanceFrom.'.single_id')
912 912
 				 )
913 913
 			 );
914 914
 	}
@@ -974,7 +974,7 @@  discard block
 block discarded – undo
974 974
 			$aliasMembership,
975 975
 			$expr->andX(
976 976
 				$this->exprLimit('single_id', $initiator->getSingleId(), $aliasMembership),
977
-				$expr->eq($aliasMembership . '.circle_id', $helperAlias . '.' . $field)
977
+				$expr->eq($aliasMembership.'.circle_id', $helperAlias.'.'.$field)
978 978
 			)
979 979
 		);
980 980
 
@@ -987,8 +987,8 @@  discard block
 block discarded – undo
987 987
 			$this->leftJoin(
988 988
 				$aliasMembership, CoreRequestBuilder::TABLE_MEMBER, $aliasInitiator,
989 989
 				$expr->andX(
990
-					$expr->eq($aliasMembership . '.inheritance_first', $aliasInitiator . '.single_id'),
991
-					$expr->eq($aliasMembership . '.circle_id', $aliasInitiator . '.circle_id')
990
+					$expr->eq($aliasMembership.'.inheritance_first', $aliasInitiator.'.single_id'),
991
+					$expr->eq($aliasMembership.'.circle_id', $aliasInitiator.'.circle_id')
992 992
 				)
993 993
 			);
994 994
 
@@ -996,8 +996,8 @@  discard block
 block discarded – undo
996 996
 			$this->leftJoin(
997 997
 				$aliasInitiator, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritedBy,
998 998
 				$expr->andX(
999
-					$expr->eq($aliasMembership . '.single_id', $aliasInheritedBy . '.single_id'),
1000
-					$expr->eq($aliasMembership . '.inheritance_last', $aliasInheritedBy . '.circle_id')
999
+					$expr->eq($aliasMembership.'.single_id', $aliasInheritedBy.'.single_id'),
1000
+					$expr->eq($aliasMembership.'.inheritance_last', $aliasInheritedBy.'.circle_id')
1001 1001
 				)
1002 1002
 			);
1003 1003
 
@@ -1016,7 +1016,7 @@  discard block
 block discarded – undo
1016 1016
 			$aliasInheritedByMembership = $this->generateAlias($aliasInheritedBy, self::MEMBERSHIPS);
1017 1017
 			$this->generateMembershipSelectAlias($aliasMembership, $aliasInheritedByMembership);
1018 1018
 		} catch (RequestBuilderException $e) {
1019
-			\OC::$server->getLogger()->log(3, '-- ' . $e->getMessage());
1019
+			\OC::$server->getLogger()->log(3, '-- '.$e->getMessage());
1020 1020
 		}
1021 1021
 	}
1022 1022
 
@@ -1040,30 +1040,30 @@  discard block
 block discarded – undo
1040 1040
 		$orX = $expr->orX();
1041 1041
 		$orX->add(
1042 1042
 			$expr->andX(
1043
-				$expr->gte($aliasMembership . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
1043
+				$expr->gte($aliasMembership.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
1044 1044
 			)
1045 1045
 		);
1046 1046
 
1047 1047
 		if ($getPersonalCircle) {
1048 1048
 			$orX->add(
1049 1049
 				$expr->andX(
1050
-					$expr->bitwiseAnd($alias . '.config', Circle::CFG_PERSONAL),
1051
-					$expr->eq($aliasMembership . '.level', $this->createNamedParameter(Member::LEVEL_OWNER))
1050
+					$expr->bitwiseAnd($alias.'.config', Circle::CFG_PERSONAL),
1051
+					$expr->eq($aliasMembership.'.level', $this->createNamedParameter(Member::LEVEL_OWNER))
1052 1052
 				)
1053 1053
 			);
1054 1054
 		}
1055 1055
 		if (!$this->getBool('mustBeMember', $options, true)) {
1056
-			$orX->add($expr->bitwiseAnd($alias . '.config', Circle::CFG_VISIBLE));
1056
+			$orX->add($expr->bitwiseAnd($alias.'.config', Circle::CFG_VISIBLE));
1057 1057
 		}
1058 1058
 		if ($this->getBool('canBeVisitor', $options, false)) {
1059 1059
 			// TODO: should find a better way, also filter on remote initiator on non-federated ?
1060
-			$orX->add($expr->gte($alias . '.config', $this->createNamedParameter(0)));
1060
+			$orX->add($expr->gte($alias.'.config', $this->createNamedParameter(0)));
1061 1061
 		}
1062 1062
 		if ($this->getBool('canBeVisitorOnOpen', $options, false)) {
1063 1063
 			$andOpen = $expr->andX();
1064
-			$andOpen->add($expr->bitwiseAnd($alias . '.config', Circle::CFG_OPEN));
1064
+			$andOpen->add($expr->bitwiseAnd($alias.'.config', Circle::CFG_OPEN));
1065 1065
 			$andOpen->add(
1066
-				$this->createFunction('NOT') . $expr->bitwiseAnd($alias . '.config', Circle::CFG_REQUEST)
1066
+				$this->createFunction('NOT').$expr->bitwiseAnd($alias.'.config', Circle::CFG_REQUEST)
1067 1067
 			);
1068 1068
 			$orX->add($andOpen);
1069 1069
 		}
@@ -1108,7 +1108,7 @@  discard block
 block discarded – undo
1108 1108
 		$hide = $expr->andX();
1109 1109
 		foreach (Circle::$DEF_CFG as $cfg => $v) {
1110 1110
 			if ($flag & $cfg) {
1111
-				$hide->add($this->createFunction('NOT') . $expr->bitwiseAnd($aliasCircle . '.config', $cfg));
1111
+				$hide->add($this->createFunction('NOT').$expr->bitwiseAnd($aliasCircle.'.config', $cfg));
1112 1112
 			}
1113 1113
 		}
1114 1114
 
@@ -1127,21 +1127,21 @@  discard block
 block discarded – undo
1127 1127
 		$expr = $this->expr();
1128 1128
 		$andPassive = $expr->andX();
1129 1129
 		$andPassive->add(
1130
-			$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
1130
+			$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
1131 1131
 		);
1132 1132
 
1133 1133
 		$orMemberOrLevel = $expr->orX();
1134 1134
 		$orMemberOrLevel->add(
1135
-			$expr->eq($this->getDefaultSelectAlias() . '.instance', $alias . '.instance')
1135
+			$expr->eq($this->getDefaultSelectAlias().'.instance', $alias.'.instance')
1136 1136
 		);
1137 1137
 		// TODO: do we need this ? (display members from the local instance)
1138 1138
 		$orMemberOrLevel->add(
1139
-			$expr->emptyString($this->getDefaultSelectAlias() . '.instance')
1139
+			$expr->emptyString($this->getDefaultSelectAlias().'.instance')
1140 1140
 		);
1141 1141
 
1142 1142
 		$orMemberOrLevel->add(
1143 1143
 			$expr->eq(
1144
-				$this->getDefaultSelectAlias() . '.level',
1144
+				$this->getDefaultSelectAlias().'.level',
1145 1145
 				$this->createNamedParameter(Member::LEVEL_OWNER)
1146 1146
 			)
1147 1147
 		);
@@ -1157,7 +1157,7 @@  discard block
 block discarded – undo
1157 1157
 	 * @param int $flag
1158 1158
 	 */
1159 1159
 	public function filterConfig(string $aliasCircle, int $flag): void {
1160
-		$this->andWhere($this->expr()->bitwiseAnd($aliasCircle . '.config', $flag));
1160
+		$this->andWhere($this->expr()->bitwiseAnd($aliasCircle.'.config', $flag));
1161 1161
 	}
1162 1162
 
1163 1163
 
@@ -1188,11 +1188,11 @@  discard block
 block discarded – undo
1188 1188
 			 )
1189 1189
 			 ->leftJoin(
1190 1190
 				 $aliasShare, CoreRequestBuilder::TABLE_FILE_CACHE, $aliasFileCache,
1191
-				 $expr->eq($aliasShare . '.file_source', $aliasFileCache . '.fileid')
1191
+				 $expr->eq($aliasShare.'.file_source', $aliasFileCache.'.fileid')
1192 1192
 			 )
1193 1193
 			 ->leftJoin(
1194 1194
 				 $aliasFileCache, CoreRequestBuilder::TABLE_STORAGES, $aliasStorages,
1195
-				 $expr->eq($aliasFileCache . '.storage', $aliasStorages . '.numeric_id')
1195
+				 $expr->eq($aliasFileCache.'.storage', $aliasStorages.'.numeric_id')
1196 1196
 			 );
1197 1197
 	}
1198 1198
 
@@ -1214,8 +1214,8 @@  discard block
 block discarded – undo
1214 1214
 		$this->leftJoin(
1215 1215
 			$aliasShareMemberships, CoreRequestBuilder::TABLE_SHARE, $aliasShareChild,
1216 1216
 			$expr->andX(
1217
-				$expr->eq($aliasShareChild . '.parent', $aliasShare . '.id'),
1218
-				$expr->eq($aliasShareChild . '.share_with', $aliasShareMemberships . '.single_id')
1217
+				$expr->eq($aliasShareChild.'.parent', $aliasShare.'.id'),
1218
+				$expr->eq($aliasShareChild.'.share_with', $aliasShareMemberships.'.single_id')
1219 1219
 			)
1220 1220
 		);
1221 1221
 
@@ -1265,13 +1265,13 @@  discard block
 block discarded – undo
1265 1265
 		$this->leftJoin(
1266 1266
 			$aliasMountMemberships, CoreRequestBuilder::TABLE_MOUNTPOINT, $aliasMountpoint,
1267 1267
 			$expr->andX(
1268
-				$expr->eq($aliasMountpoint . '.mount_id', $aliasMount . '.mount_id'),
1269
-				$expr->eq($aliasMountpoint . '.single_id', $aliasMountMemberships . '.single_id')
1268
+				$expr->eq($aliasMountpoint.'.mount_id', $aliasMount.'.mount_id'),
1269
+				$expr->eq($aliasMountpoint.'.single_id', $aliasMountMemberships.'.single_id')
1270 1270
 			)
1271 1271
 		);
1272 1272
 
1273
-		$this->selectAlias($aliasMountpoint . '.mountpoint', $aliasMountpoint . '_mountpoint');
1274
-		$this->selectAlias($aliasMountpoint . '.mountpoint_hash', $aliasMountpoint . '_mountpoint_hash');
1273
+		$this->selectAlias($aliasMountpoint.'.mountpoint', $aliasMountpoint.'_mountpoint');
1274
+		$this->selectAlias($aliasMountpoint.'.mountpoint_hash', $aliasMountpoint.'_mountpoint_hash');
1275 1275
 	}
1276 1276
 
1277 1277
 
@@ -1375,10 +1375,10 @@  discard block
 block discarded – undo
1375 1375
 	 */
1376 1376
 	public function generateAlias(string $base, string $extension, ?array &$options = []): string {
1377 1377
 		$search = str_replace('_', '.', $base);
1378
-		$path = $search . '.' . $extension;
1378
+		$path = $search.'.'.$extension;
1379 1379
 		if (!$this->validKey($path, self::$SQL_PATH)
1380 1380
 			&& !in_array($extension, $this->getArray($search, self::$SQL_PATH))) {
1381
-			throw new RequestBuilderException($extension . ' not found in ' . $search);
1381
+			throw new RequestBuilderException($extension.' not found in '.$search);
1382 1382
 		}
1383 1383
 
1384 1384
 		if (!is_array($options)) {
@@ -1387,15 +1387,15 @@  discard block
 block discarded – undo
1387 1387
 
1388 1388
 		$optionPath = '';
1389 1389
 		foreach (explode('.', $path) as $p) {
1390
-			$optionPath = trim($optionPath . '.' . $p, '.');
1390
+			$optionPath = trim($optionPath.'.'.$p, '.');
1391 1391
 			$options = array_merge(
1392 1392
 				$options,
1393
-				$this->getArray($optionPath . '.' . self::OPTIONS, self::$SQL_PATH),
1394
-				$this->getArray($optionPath . '.' . self::OPTIONS, $this->options)
1393
+				$this->getArray($optionPath.'.'.self::OPTIONS, self::$SQL_PATH),
1394
+				$this->getArray($optionPath.'.'.self::OPTIONS, $this->options)
1395 1395
 			);
1396 1396
 		}
1397 1397
 
1398
-		return $base . '_' . $extension;
1398
+		return $base.'_'.$extension;
1399 1399
 	}
1400 1400
 
1401 1401
 
@@ -1415,7 +1415,7 @@  discard block
 block discarded – undo
1415 1415
 			} else {
1416 1416
 				$k = $arr;
1417 1417
 			}
1418
-			$path[$k] = $prefix . '_' . $k . '_';
1418
+			$path[$k] = $prefix.'_'.$k.'_';
1419 1419
 		}
1420 1420
 
1421 1421
 		return $path;
Please login to merge, or discard this patch.
lib/CirclesQueryHelper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -144,7 +144,7 @@
 block discarded – undo
144 144
 		$circle = new Circle();
145 145
 		$circle->importFromDatabase(
146 146
 			$data,
147
-			CoreQueryBuilder::HELPER . '_' . CoreQueryBuilder::CIRCLE . '_'
147
+			CoreQueryBuilder::HELPER.'_'.CoreQueryBuilder::CIRCLE.'_'
148 148
 		);
149 149
 
150 150
 		return $circle;
Please login to merge, or discard this patch.