Completed
Pull Request — master (#379)
by Maxence
01:44
created
lib/Service/MembersService.php 1 patch
Doc Comments   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 	 *
144 144
 	 * @param bool $force
145 145
 	 *
146
-	 * @return array
146
+	 * @return Member[]
147 147
 	 * @throws Exception
148 148
 	 */
149 149
 	public function addMember($circleUniqueId, $ident, $type, bool $force = false) {
@@ -301,8 +301,8 @@  discard block
 block discarded – undo
301 301
 	/**
302 302
 	 * Verify if a local account is valid.
303 303
 	 *
304
-	 * @param $ident
305
-	 * @param $type
304
+	 * @param string $ident
305
+	 * @param integer $type
306 306
 	 *
307 307
 	 * @throws NoUserException
308 308
 	 */
@@ -323,7 +323,7 @@  discard block
 block discarded – undo
323 323
 	 * Verify if a mail have a valid format.
324 324
 	 *
325 325
 	 * @param $ident
326
-	 * @param $type
326
+	 * @param integer $type
327 327
 	 *
328 328
 	 * @throws EmailAccountInvalidFormatException
329 329
 	 */
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
 	 * Verify if a contact exist in current user address books.
352 352
 	 *
353 353
 	 * @param $ident
354
-	 * @param $type
354
+	 * @param integer $type
355 355
 	 *
356 356
 	 * @throws NoUserException
357 357
 	 * @throws EmailAccountInvalidFormatException
@@ -482,7 +482,7 @@  discard block
 block discarded – undo
482 482
 	 * @param int $level
483 483
 	 * @param bool $force
484 484
 	 *
485
-	 * @return array
485
+	 * @return Member[]
486 486
 	 * @throws CircleDoesNotExistException
487 487
 	 * @throws CircleTypeNotValidException
488 488
 	 * @throws ConfigNoCircleAvailableException
@@ -523,7 +523,7 @@  discard block
 block discarded – undo
523 523
 	/**
524 524
 	 * @param Circle $circle
525 525
 	 * @param Member $member
526
-	 * @param $level
526
+	 * @param integer $level
527 527
 	 * @param bool $force
528 528
 	 *
529 529
 	 * @throws Exception
@@ -598,10 +598,10 @@  discard block
 block discarded – undo
598 598
 	/**
599 599
 	 * @param string $circleUniqueId
600 600
 	 * @param string $name
601
-	 * @param $type
601
+	 * @param integer $type
602 602
 	 * @param bool $force
603 603
 	 *
604
-	 * @return array
604
+	 * @return Member[]
605 605
 	 * @throws CircleDoesNotExistException
606 606
 	 * @throws ConfigNoCircleAvailableException
607 607
 	 * @throws MemberDoesNotExistException
Please login to merge, or discard this patch.
lib/Command/CirclesDetails.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@
 block discarded – undo
86 86
 
87 87
 		$circle = $this->circlesRequest->forceGetCircle($circleId);
88 88
 
89
-		echo json_encode($circle, JSON_PRETTY_PRINT) . "\n";
89
+		echo json_encode($circle, JSON_PRETTY_PRINT)."\n";
90 90
 
91 91
 		return 0;
92 92
 	}
Please login to merge, or discard this patch.
lib/Command/MembersCreate.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
 		];
120 120
 
121 121
 		if (!key_exists(strtolower($level), $levels)) {
122
-			throw new Exception('unknown level: ' . json_encode(array_keys($levels)));
122
+			throw new Exception('unknown level: '.json_encode(array_keys($levels)));
123 123
 		}
124 124
 
125 125
 		$level = $levels[strtolower($level)];
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
 		$this->membersService->levelMember($circleId, $userId, Member::TYPE_USER, $level, true);
129 129
 
130 130
 		$member = $this->membersRequest->forceGetMember($circleId, $userId, Member::TYPE_USER);
131
-		echo json_encode($member, JSON_PRETTY_PRINT) . "\n";
131
+		echo json_encode($member, JSON_PRETTY_PRINT)."\n";
132 132
 
133 133
 		return 0;
134 134
 	}
Please login to merge, or discard this patch.
lib/Command/MembersLevel.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 		];
112 112
 
113 113
 		if (!key_exists(strtolower($level), $levels)) {
114
-			throw new Exception('unknown level: ' . json_encode(array_keys($levels)));
114
+			throw new Exception('unknown level: '.json_encode(array_keys($levels)));
115 115
 		}
116 116
 
117 117
 		$level = $levels[strtolower($level)];
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
 		$member = $this->membersRequest->forceGetMember(
125 125
 			$member->getCircleId(), $member->getUserId(), Member::TYPE_USER
126 126
 		);
127
-		echo json_encode($member, JSON_PRETTY_PRINT) . "\n";
127
+		echo json_encode($member, JSON_PRETTY_PRINT)."\n";
128 128
 
129 129
 		return 0;
130 130
 	}
Please login to merge, or discard this patch.
lib/Command/CirclesList.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -97,7 +97,7 @@
 block discarded – undo
97 97
 		$circles = $this->getCircles($owner, $viewer);
98 98
 
99 99
 		if ($json) {
100
-			echo json_encode($circles, JSON_PRETTY_PRINT) . "\n";
100
+			echo json_encode($circles, JSON_PRETTY_PRINT)."\n";
101 101
 
102 102
 			return 0;
103 103
 		}
Please login to merge, or discard this patch.
lib/Command/MembersList.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@
 block discarded – undo
100 100
 		$members = $this->membersRequest->forceGetMembers($circleId);
101 101
 
102 102
 		if ($json) {
103
-			echo json_encode($members, JSON_PRETTY_PRINT) . "\n";
103
+			echo json_encode($members, JSON_PRETTY_PRINT)."\n";
104 104
 
105 105
 			return 0;
106 106
 		}
Please login to merge, or discard this patch.
lib/Command/CirclesCreate.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 		];
126 126
 
127 127
 		if (!key_exists(strtolower($type), $types)) {
128
-			throw new CircleTypeNotValidException('unknown type: ' . json_encode(array_keys($types)));
128
+			throw new CircleTypeNotValidException('unknown type: '.json_encode(array_keys($types)));
129 129
 		}
130 130
 
131 131
 		$type = $types[strtolower($type)];
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
 		$circle = $this->circlesService->createCircle($type, $name, $ownerId);
134 134
 		$circle = $this->circlesRequest->forceGetCircle($circle->getUniqueId());
135 135
 
136
-		echo json_encode($circle, JSON_PRETTY_PRINT) . "\n";
136
+		echo json_encode($circle, JSON_PRETTY_PRINT)."\n";
137 137
 
138 138
 		return 0;
139 139
 	}
Please login to merge, or discard this patch.
lib/Command/MembersDetails.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@
 block discarded – undo
85 85
 		$memberId = $input->getArgument('member_id');
86 86
 
87 87
 		$member = $this->membersRequest->forceGetMemberById($memberId);
88
-		echo json_encode($member, JSON_PRETTY_PRINT) . "\n";
88
+		echo json_encode($member, JSON_PRETTY_PRINT)."\n";
89 89
 
90 90
 		return 0;
91 91
 	}
Please login to merge, or discard this patch.