Completed
Pull Request — master (#2076)
by Maxence
27s
created
lib/Tools/ActivityPub/NCSignature.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -197,8 +197,8 @@  discard block
 block discarded – undo
197 197
 			throw new SignatureException('missing elements in \'headers\'');
198 198
 		}
199 199
 
200
-		$target = strtolower($request->getMethod()) . ' ' . urldecode($request->getRequestUri());
201
-		$estimated = ['(request-target): ' . $target];
200
+		$target = strtolower($request->getMethod()).' '.urldecode($request->getRequestUri());
201
+		$estimated = ['(request-target): '.$target];
202 202
 
203 203
 		foreach ($headers as $key) {
204 204
 			$value = $request->getHeader($key);
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
 				throw new SignatureException('empty elements in \'headers\'');
210 210
 			}
211 211
 
212
-			$estimated[] = $key . ': ' . $value;
212
+			$estimated[] = $key.': '.$value;
213 213
 		}
214 214
 		$signedRequest->setClearSignature(implode("\n", $estimated));
215 215
 	}
@@ -281,7 +281,7 @@  discard block
 block discarded – undo
281 281
 		$request = $signedRequest->getOutgoingRequest();
282 282
 
283 283
 		$data = new SimpleDataStore();
284
-		$data->s('(request-target)', NCRequest::method($request->getType()) . ' ' . $request->getPath())
284
+		$data->s('(request-target)', NCRequest::method($request->getType()).' '.$request->getPath())
285 285
 			->sInt('content-length', strlen($signedRequest->getBody()))
286 286
 			->s('date', gmdate($this->dateHeader))
287 287
 			->s('digest', $signedRequest->getDigest())
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
 		foreach ($data->keys() as $element) {
301 301
 			try {
302 302
 				$value = $data->gItem($element);
303
-				$signing[] = $element . ': ' . $value;
303
+				$signing[] = $element.': '.$value;
304 304
 				if ($element !== '(request-target)') {
305 305
 					$signedRequest->getOutgoingRequest()->addHeader($element, $value);
306 306
 				}
@@ -333,10 +333,10 @@  discard block
 block discarded – undo
333 333
 		$headers = array_diff($signedRequest->getSignatureHeader()->keys(), ['(request-target)']);
334 334
 		$signatory = $signedRequest->getSignatory();
335 335
 		$signatureElements = [
336
-			'keyId="' . $signatory->getKeyId() . '"',
337
-			'algorithm="' . $this->getChosenEncryption($signatory) . '"',
338
-			'headers="' . implode(' ', $headers) . '"',
339
-			'signature="' . $signedRequest->getSignedSignature() . '"'
336
+			'keyId="'.$signatory->getKeyId().'"',
337
+			'algorithm="'.$this->getChosenEncryption($signatory).'"',
338
+			'headers="'.implode(' ', $headers).'"',
339
+			'signature="'.$signedRequest->getSignedSignature().'"'
340 340
 		];
341 341
 
342 342
 		$signedRequest->getOutgoingRequest()->addHeader('Signature', implode(',', $signatureElements));
Please login to merge, or discard this patch.