nextcloud / circles

lib/Migration/ImportOwncloudCustomGroups.php

Spacing +1 added lines, -1 removed lines

@@ -148,7 +148,7 @@
 				continue;
 			}
 
-			$level = (int) $row['role'] === 1 ? Member::LEVEL_OWNER : Member::LEVEL_MEMBER;
+			$level = (int)$row['role'] === 1 ? Member::LEVEL_OWNER : Member::LEVEL_MEMBER;
 
 			if ($level === Member::LEVEL_OWNER) {
 				if (isset($this->circleHasAdmin[$this->circlesById[$row['group_id']]])) {

lib/Service/EventsService.php

Doc Comments +1 added lines, -1 removed lines

@@ -282,7 +282,7 @@
 	 * generateEvent()
 	 * Create an Activity Event with the basic settings for the app.
 	 *
-	 * @param $type
+	 * @param string $type
 	 *
 	 * @return \OCP\Activity\IEvent
 	 */

lib/Db/CircleProviderRequestBuilder.php

Doc Comments +1 added lines, -1 removed lines

@@ -107,7 +107,7 @@
 	 * limit the request to the children of a share
 	 *
 	 * @param IQueryBuilder $qb
-	 * @param $userId
+	 * @param string $userId
 	 * @param int $parentId
 	 */
 	protected function limitToShareChildren(IQueryBuilder &$qb, $userId, $parentId = -1) {

Spacing +8 added lines, -8 removed lines

@@ -77,7 +77,7 @@ 
 		$pf = ($qb->getType() === QueryBuilder::SELECT) ? 's.' : '';
 		$qb->andWhere(
 			$expr->in(
-				$pf . 'share_with',
+				$pf.'share_with',
 				$qb->createNamedParameter($circleUniqueIds, IQueryBuilder::PARAM_STR_ARRAY)
 			)
 		);
@@ -94,7 +94,7 @@ 
 		$expr = $qb->expr();
 		$pf = ($qb->getType() === QueryBuilder::SELECT) ? 's.' : '';
 
-		$qb->andWhere($expr->eq($pf . 'id', $qb->createNamedParameter($shareId)));
+		$qb->andWhere($expr->eq($pf.'id', $qb->createNamedParameter($shareId)));
 	}
 
 
@@ -143,8 +143,8 @@ 
 		/** @noinspection PhpMethodParametersCountMismatchInspection */
 		$qb->andWhere(
 			$expr->orX(
-				$expr->eq($pf . 'parent', $qb->createNamedParameter($circleId)),
-				$expr->eq($pf . 'id', $qb->createNamedParameter($circleId))
+				$expr->eq($pf.'parent', $qb->createNamedParameter($circleId)),
+				$expr->eq($pf.'id', $qb->createNamedParameter($circleId))
 			)
 		);
 	}
@@ -166,7 +166,7 @@ 
 		$pf = ($qb->getType() === QueryBuilder::SELECT) ? 's.' : '';
 		$qb->andWhere(
 			$expr->in(
-				$pf . 'file_source',
+				$pf.'file_source',
 				$qb->createNamedParameter($files, IQueryBuilder::PARAM_INT_ARRAY)
 			)
 		);
@@ -199,13 +199,13 @@ 
 		$pf = ($qb->getType() === QueryBuilder::SELECT) ? 's.' : '';
 
 		if ($reShares === false) {
-			$qb->andWhere($expr->eq($pf . 'uid_initiator', $qb->createNamedParameter($userId)));
+			$qb->andWhere($expr->eq($pf.'uid_initiator', $qb->createNamedParameter($userId)));
 		} else {
 			/** @noinspection PhpMethodParametersCountMismatchInspection */
 			$qb->andWhere(
 				$expr->orX(
-					$expr->eq($pf . 'uid_owner', $qb->createNamedParameter($userId)),
-					$expr->eq($pf . 'uid_initiator', $qb->createNamedParameter($userId))
+					$expr->eq($pf.'uid_owner', $qb->createNamedParameter($userId)),
+					$expr->eq($pf.'uid_initiator', $qb->createNamedParameter($userId))
 				)
 			);
 		}

lib/Service/GroupsService.php

Doc Comments +6 added lines, -6 removed lines

@@ -86,7 +86,7 @@ 
 	 * @param string $circleUniqueId
 	 * @param string $groupId
 	 *
-	 * @return array
+	 * @return Member[]
 	 * @throws \Exception
 	 */
 	public function linkGroup($circleUniqueId, $groupId) {
@@ -112,8 +112,8 @@ 
 	/**
 	 * Check if a fresh member can be generated (by linkGroup)
 	 *
-	 * @param $circleId
-	 * @param $groupId
+	 * @param string $circleId
+	 * @param string $groupId
 	 *
 	 * @return null|Member
 	 * @throws MemberAlreadyExistsException
@@ -148,7 +148,7 @@ 
 	 * @param string $groupId
 	 * @param int $level
 	 *
-	 * @return array
+	 * @return Member[]
 	 * @throws \Exception
 	 */
 	public function levelGroup($circleUniqueId, $groupId, $level) {
@@ -186,7 +186,7 @@ 
 	/**
 	 * @param Circle $circle
 	 * @param Member $group
-	 * @param $level
+	 * @param integer $level
 	 *
 	 * @throws \Exception
 	 */
@@ -213,7 +213,7 @@ 
 	 * @param string $circleUniqueId
 	 * @param string $groupId
 	 *
-	 * @return array
+	 * @return Member[]
 	 * @throws \Exception
 	 */
 	public function unlinkGroup($circleUniqueId, $groupId) {

lib/Model/BaseMember.php

Doc Comments +3 added lines

@@ -149,6 +149,9 @@
 	}
 
 
+	/**
+	 * @param string $display
+	 */
 	public function setDisplayName($display) {
 		$this->displayName = $display;
 

lib/Service/SearchService.php

Spacing +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
 			$searcher = \OC::$server->query((string)$container);
 
 			if (!($searcher instanceof ISearch)) {
-				$this->miscService->log('Search ' . $container . ' is not compatible exception');
+				$this->miscService->log('Search '.$container.' is not compatible exception');
 				continue;
 			}
 

lib/Service/FederatedLinkCreationService.php

Doc Comments +3 added lines, -3 removed lines

@@ -189,8 +189,8 @@ 
 
 
 	/**
-	 * @param $circleUniqueId
-	 * @param $remote
+	 * @param string $circleUniqueId
+	 * @param string $remote
 	 *
 	 * @return FederatedLink
 	 */
@@ -281,7 +281,7 @@ 
 	 *
 	 * Will parse the error reason returned by requestLink() and throw an Exception
 	 *
-	 * @param $reason
+	 * @param string $reason
 	 *
 	 * @throws Exception
 	 * @throws FederatedRemoteDoesNotAllowException

lib/Model/FederatedLink.php

Doc Comments +3 added lines

@@ -303,6 +303,9 @@
 	}
 
 
+	/**
+	 * @param integer $status
+	 */
 	public function hasToBeValidStatusUpdate($status) {
 		try {
 			$this->hasToBeValidStatusUpdateWhileLinkDown($status);

lib/Service/MiscService.php

Doc Comments +5 added lines, -2 removed lines

@@ -64,7 +64,7 @@ 
 
 	/**
 	 * @param $arr
-	 * @param $k
+	 * @param string $k
 	 *
 	 * @param string $default
 	 *
@@ -79,6 +79,9 @@ 
 	}
 
 
+	/**
+	 * @param string[] $arr
+	 */
 	public static function mustContains($data, $arr) {
 		if (!is_array($arr)) {
 			$arr = [$arr];
@@ -188,7 +191,7 @@ 
 
 
 	/**
-	 * @param $ident
+	 * @param string $ident
 	 *
 	 * @return mixed|string
 	 */

Spacing +1 added lines, -1 removed lines

@@ -284,7 +284,7 @@
 		ob_start();
 		echo(json_encode($result));
 		$size = ob_get_length();
-		header('Content-Length: ' . $size);
+		header('Content-Length: '.$size);
 		ob_end_flush();
 		flush();
 	}