nextcloud / circles

lib/GlobalScale/GSMount/Mount.php

Doc Comments +3 added lines, -3 removed lines

@@ -56,7 +56,7 @@ 
 	/**
 	 * Mount constructor.
 	 *
-	 * @param $storage
+	 * @param string $storage
 	 * @param string $mountPoint
 	 * @param array $options
 	 * @param MountManager $manager
@@ -90,8 +90,8 @@ 
 	/**
 	 * Remove the mount points
 	 *
-	 * @return mixed
-	 * @return bool
+	 * @return boolean
+	 * @return boolean
 	 */
 	public function removeMount() {
 		return $this->mountManager->unshare($this->gsShareId);

lib/GlobalScale/GSMount/MountManager.php

Spacing +1 added lines, -1 removed lines

@@ -109,7 +109,7 @@
 	 * @return string
 	 */
 	protected function stripPath($path) {
-		$prefix = '/' . $this->userId . '/files';
+		$prefix = '/'.$this->userId.'/files';
 
 		return rtrim(substr($path, strlen($prefix)), '/');
 	}

lib/Model/GlobalScale/GSShare.php

Spacing +2 added lines, -2 removed lines

@@ -154,7 +154,7 @@ 
 			return $mountPoint;
 		}
 
-		return '/' . $userId . '/files/' . ltrim($mountPoint, '/');
+		return '/'.$userId.'/files/'.ltrim($mountPoint, '/');
 	}
 
 	/**
@@ -293,7 +293,7 @@ 
 	public function toMount(string $userId, string $protocol = 'https'): array {
 		return [
 			'owner'       => $this->getOwner(),
-			'remote'      => $protocol . '://' . $this->getInstance(),
+			'remote'      => $protocol.'://'.$this->getInstance(),
 			'token'       => $this->getToken(),
 			'share_token' => $this->getToken(),
 			'password'    => $this->getPassword(),

lib/Db/GSSharesRequest.php

Spacing +2 added lines, -2 removed lines

@@ -121,11 +121,11 @@
 
 	private function leftJoinMountPoint(IQueryBuilder $qb, string $userId) {
 		$expr = $qb->expr();
-		$pf = '' . $this->default_select_alias . '.';
+		$pf = ''.$this->default_select_alias.'.';
 
 		$on = $expr->andX();
 		$on->add($expr->eq('mp.user_id', $qb->createNamedParameter($userId)));
-		$on->add($expr->eq('mp.share_id', $pf . 'id'));
+		$on->add($expr->eq('mp.share_id', $pf.'id'));
 
 		/** @noinspection PhpMethodParametersCountMismatchInspection */
 		$qb->selectAlias('mp.mountPoint', 'gsshares_mountpoint')

lib/Events/UserEvents.php

Spacing +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
 		try {
 			$this->membersService->onUserRemoved($userId);
 		} catch (\Exception $e) {
-			$this->miscService->log('exception while onUserDeleted ' . $e->getMessage());
+			$this->miscService->log('exception while onUserDeleted '.$e->getMessage());
 		}
 	}
 

lib/GlobalScale/GSMount/MountProvider.php

Spacing +3 added lines, -3 removed lines

@@ -148,13 +148,13 @@
 		}
 
 		$info = pathinfo($share->getMountPoint());
-		$filename = $this->get('dirname', $info) . '/' . $this->get('filename', $info);
+		$filename = $this->get('dirname', $info).'/'.$this->get('filename', $info);
 		$extension = $this->get('extension', $info);
-		$extension = ($extension === '') ? '' : '.' . $extension;
+		$extension = ($extension === '') ? '' : '.'.$extension;
 
 		$n = 2;
 		while (true) {
-			$path = $filename . " ($n)" . $extension;
+			$path = $filename." ($n)".$extension;
 			try {
 				$fs->get($path);
 			} catch (NotFoundException $e) {

lib/GlobalScale/FileShare.php

Doc Comments +3 added lines, -3 removed lines

@@ -257,7 +257,7 @@ 
 	 * @param $fileName
 	 * @param string $link
 	 * @param string $author
-	 * @param $circleName
+	 * @param string $circleName
 	 * @param string $email
 	 *
 	 * @throws Exception
@@ -294,7 +294,7 @@ 
 	 * @param string $circleName
 	 * @param string $email
 	 *
-	 * @param $password
+	 * @param string $password
 	 *
 	 * @throws NotFoundException
 	 * @throws Exception
@@ -371,7 +371,7 @@ 
 	 * @param $subject
 	 * @param $text
 	 * @param $fileName
-	 * @param $link
+	 * @param string $link
 	 * @param string $author
 	 * @param string $circleName
 	 *

Spacing +8 added lines, -8 removed lines

@@ -105,14 +105,14 @@ 
 			$node = $share->getNode();
 			$filename = $node->getName();
 		} catch (NotFoundException $e) {
-			$this->miscService->log('issue while FileShare: ' . $e->getMessage());
+			$this->miscService->log('issue while FileShare: '.$e->getMessage());
 
 			return;
 		}
 
 		$event->getData()
 			  ->s('gs_federated', $share->getToken())
-			  ->s('gs_filename', '/' . $filename);
+			  ->s('gs_filename', '/'.$filename);
 	}
 
 
@@ -301,7 +301,7 @@ 
 			);
 		} catch (Exception $e) {
 			OC::$server->getLogger()
-					   ->log(1, 'Circles::sharedByMail - mail were not sent: ' . $e->getMessage());
+					   ->log(1, 'Circles::sharedByMail - mail were not sent: '.$e->getMessage());
 		}
 	}
 
@@ -319,8 +319,8 @@ 
 		$message = $this->mailer->createMessage();
 
 		$this->miscService->log(
-			"Sending mail to circle '" . $circleName . "': " . $email . ' file: ' . $fileName
-			. ' - link: ' . $link, 0
+			"Sending mail to circle '".$circleName."': ".$email.' file: '.$fileName
+			. ' - link: '.$link, 0
 		);
 
 		$subject = $this->l10n->t('%s shared »%s« with you.', [$author, $fileName]);
@@ -359,7 +359,7 @@ 
 
 		$message = $this->mailer->createMessage();
 
-		$this->miscService->log("Sending password mail to circle '" . $circleName . "': " . $email, 0);
+		$this->miscService->log("Sending password mail to circle '".$circleName."': ".$email, 0);
 
 		$filename = $share->getNode()
 						  ->getName();
@@ -414,7 +414,7 @@ 
 		$message->setFrom([\OCP\Util::getDefaultEmailAddress($instanceName) => $senderName]);
 		if ($initiatorEmailAddress !== null) {
 			$message->setReplyTo([$initiatorEmailAddress => $initiatorDisplayName]);
-			$emailTemplate->addFooter($instanceName . ' - ' . $this->defaults->getSlogan());
+			$emailTemplate->addFooter($instanceName.' - '.$this->defaults->getSlogan());
 		} else {
 			$emailTemplate->addFooter();
 		}
@@ -449,7 +449,7 @@ 
 		$emailTemplate->addHeader();
 		$emailTemplate->addHeading($subject, false);
 		$emailTemplate->addBodyText(
-			htmlspecialchars($text) . '<br>' . htmlspecialchars(
+			htmlspecialchars($text).'<br>'.htmlspecialchars(
 				$this->l10n->t('Click the button below to open it.')
 			), $text
 		);

lib/GlobalScale/FileUnshare.php

Doc Comments +1 added lines, -1 removed lines

@@ -240,7 +240,7 @@
 	/**
 	 * @param SimpleDataStore $data
 	 *
-	 * @return IShare
+	 * @return string
 	 * @throws ShareNotFound
 	 * @throws IllegalIDChangeException
 	 */

Spacing +4 added lines, -4 removed lines

@@ -91,7 +91,7 @@ 
 			\OC::$server->getLogger()->log(3, '### 2');
 
 
-			$this->miscService->log('### ' . json_encode($event->getData()));
+			$this->miscService->log('### '.json_encode($event->getData()));
 
 			try {
 				$node = $share->getNode();
@@ -102,7 +102,7 @@ 
 
 			$event->getData()
 				  ->s('gs_federated', $share->getToken())
-				  ->s('gs_filename', '/' . $filename);
+				  ->s('gs_filename', '/'.$filename);
 		}
 
 	}
@@ -191,7 +191,7 @@ 
 		}
 
 		$members =
-			$this->membersRequest->forceGetMembers($circle->getUniqueId(), Member::LEVEL_MEMBER, 0,true);
+			$this->membersRequest->forceGetMembers($circle->getUniqueId(), Member::LEVEL_MEMBER, 0, true);
 		foreach ($members AS $member) {
 			$this->parseMember($member);
 
@@ -200,7 +200,7 @@ 
 			}
 
 			if ($member->getInstance() !== '') {
-				$this->miscService->log('#### GENERATE FEDERATED CIRCLES SHARE ' . $member->getInstance());
+				$this->miscService->log('#### GENERATE FEDERATED CIRCLES SHARE '.$member->getInstance());
 			}
 		}
 	}

lib/Service/GSDownstreamService.php

Spacing +1 added lines, -1 removed lines

@@ -155,7 +155,7 @@
 			$gs = $this->globalScaleService->getGlobalScaleEvent($event);
 			$gs->manage($event);
 		} catch (Exception $e) {
-			$this->miscService->log('issue onNewEvent: ' . json_encode($event) . ' - ' . $e->getMessage());
+			$this->miscService->log('issue onNewEvent: '.json_encode($event).' - '.$e->getMessage());
 		}
 	}