nextcloud / circles

lib/Db/CirclesRequest.php

Doc Comments +1 added lines, -1 removed lines

@@ -95,7 +95,7 @@
 
 
 	/**
-	 * @param $circleId
+	 * @param integer $circleId
 	 * @param int $level
 	 *
 	 * @return Member[]

Braces +3 added lines, -2 removed lines

@@ -64,8 +64,9 @@
 		$qb = $this->getCirclesSelectSql();
 
 		$this->limitToId($qb, $circleId);
-		if ($userId !== '')
-			$this->limitToUserId($qb, $userId);
+		if ($userId !== '') {
+					$this->limitToUserId($qb, $userId);
+		}
 
 //		$this->leftjoinOwner($qb);
 //		$this->buildWithMemberLevel($qb, 'u.level', $level);

lib/Db/CirclesRequestBuilder.php

Doc Comments +4 added lines

@@ -53,6 +53,7 @@ 
 	 * Join the Circles table
 	 *
 	 * @param IQueryBuilder $qb
+	 * @param string $field
 	 */
 	protected function joinCircles(& $qb, $field) {
 		$expr = $qb->expr();
@@ -108,6 +109,9 @@ 
 
 
 
+	/**
+	 * @param integer $level
+	 */
 	protected function limitToMemberLevel(IQueryBuilder &$qb, $level) {
 		$qb->where(
 			$qb->expr()

Spacing +11 added lines, -11 removed lines

@@ -68,11 +68,11 @@ 
 	 * @param IQueryBuilder $qb
 	 * @param int $circleId
 	 */
-	protected function limitToCircle(IQueryBuilder &$qb, $circleId) {
+	protected function limitToCircle(IQueryBuilder & $qb, $circleId) {
 		$expr = $qb->expr();
-		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias . '.' : '';
+		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias.'.' : '';
 
-		$qb->andWhere($expr->eq($pf . 'circle_id', $qb->createNamedParameter($circleId)));
+		$qb->andWhere($expr->eq($pf.'circle_id', $qb->createNamedParameter($circleId)));
 	}
 
 
@@ -83,11 +83,11 @@ 
 	 * @param IQueryBuilder $qb
 	 * @param int $id
 	 */
-	protected function limitToId(IQueryBuilder &$qb, $id) {
+	protected function limitToId(IQueryBuilder & $qb, $id) {
 		$expr = $qb->expr();
-		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias . '.' : '';
+		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias.'.' : '';
 
-		$qb->andWhere($expr->eq($pf . 'id', $qb->createNamedParameter($id)));
+		$qb->andWhere($expr->eq($pf.'id', $qb->createNamedParameter($id)));
 	}
 
 
@@ -97,7 +97,7 @@ 
 	 * @param IQueryBuilder $qb
 	 * @param string $userId
 	 */
-	protected function limitToUserId(IQueryBuilder &$qb, $userId) {
+	protected function limitToUserId(IQueryBuilder & $qb, $userId) {
 //		$expr = $qb->expr();
 //		$pf = ($qb->getType() === QueryBuilder::SELECT) ? $this->default_select_alias . '.' : '';
 //
@@ -108,7 +108,7 @@ 
 
 
 
-	protected function limitToMemberLevel(IQueryBuilder &$qb, $level) {
+	protected function limitToMemberLevel(IQueryBuilder & $qb, $level) {
 		$qb->where(
 			$qb->expr()
 			   ->gte('m.level', $qb->createNamedParameter($level))
@@ -122,19 +122,19 @@ 
 	 * @deprecated
 	 * never used in fact.
 	 */
-	protected function leftJoinOwner(IQueryBuilder &$qb) {
+	protected function leftJoinOwner(IQueryBuilder & $qb) {
 
 		if ($qb->getType() !== QueryBuilder::SELECT) {
 			return;
 		}
 
 		$expr = $qb->expr();
-		$pf = $this->default_select_alias . '.';
+		$pf = $this->default_select_alias.'.';
 
 		$qb->leftJoin(
 			$this->default_select_alias, MembersMapper::TABLENAME, 'o',
 			$expr->andX(
-				$expr->eq($pf . 'id', 'o.circle_id'),
+				$expr->eq($pf.'id', 'o.circle_id'),
 				$expr->eq('o.level', $qb->createNamedParameter(Member::LEVEL_OWNER))
 			)
 		);

lib/Service/FederatedService.php

Doc Comments +8 added lines, -5 removed lines

@@ -163,8 +163,8 @@ 
 	 * in the database and send a request to the remote circle using requestLink()
 	 * If any issue, entry is removed from the database.
 	 *
-	 * @param $circleId
-	 * @param $remote
+	 * @param integer $circleId
+	 * @param string $remote
 	 *
 	 * @return FederatedLink
 	 * @throws Exception
@@ -234,7 +234,7 @@ 
 	 * @param Circle $circle
 	 * @param FederatedLink $link
 	 *
-	 * @return int
+	 * @return boolean
 	 * @throws Exception
 	 */
 	private function requestLink(Circle $circle, FederatedLink &$link) {
@@ -328,8 +328,8 @@ 
 
 
 	/**
-	 * @param $circleId
-	 * @param $uniqueId
+	 * @param integer $circleId
+	 * @param string $uniqueId
 	 *
 	 * @return FederatedLink
 	 */
@@ -338,6 +338,9 @@ 
 	}
 
 
+	/**
+	 * @param string $token
+	 */
 	public function initiateRemoteShare($token) {
 		$args = [
 			'token' => $token,

Spacing +7 added lines, -7 removed lines

@@ -207,10 +207,10 @@ 
 	 */
 	private function generateLinkRemoteURL($remote) {
 		if (strpos($remote, 'http') !== 0) {
-			$remote = 'https://' . $remote;
+			$remote = 'https://'.$remote;
 		}
 
-		return rtrim($remote, '/') . '/index.php/apps/circles/circles/link/';
+		return rtrim($remote, '/').'/index.php/apps/circles/circles/link/';
 	}
 
 	/**
@@ -220,10 +220,10 @@ 
 	 */
 	private function generatePayloadDeliveryURL($remote) {
 		if (strpos($remote, 'http') !== 0) {
-			$remote = 'http://' . $remote;
+			$remote = 'http://'.$remote;
 		}
 
-		return rtrim($remote, '/') . '/index.php/apps/circles/circles/payload/';
+		return rtrim($remote, '/').'/index.php/apps/circles/circles/payload/';
 	}
 
 
@@ -237,7 +237,7 @@ 
 	 * @return int
 	 * @throws Exception
 	 */
-	private function requestLink(Circle $circle, FederatedLink &$link) {
+	private function requestLink(Circle $circle, FederatedLink & $link) {
 		$args = [
 			'token'      => $link->getToken(),
 			'uniqueId'   => $circle->getUniqueId(),
@@ -313,7 +313,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function initiateLink(Circle $circle, FederatedLink &$link) {
+	public function initiateLink(Circle $circle, FederatedLink & $link) {
 
 		$link->setCircleId($circle->getId());
 
@@ -356,7 +356,7 @@ 
 			);
 
 			$result = json_decode($request->getBody(), true);
-			$this->miscService->log("RESULT: " . $result);
+			$this->miscService->log("RESULT: ".$result);
 
 			return true;
 		} catch (Exception $e) {

lib/Controller/FederatedController.php

Spacing +1 added lines, -1 removed lines

@@ -132,7 +132,7 @@
 	 */
 	public function initFederatedDelivery($uniqueId) {
 
-		$this->miscService->log("initFederatedDelivery start " . $uniqueId);
+		$this->miscService->log("initFederatedDelivery start ".$uniqueId);
 
 		// We don't want to keep the connection with the client up and running
 		// as he might have others things to do

lib/Db/CirclesMapper.php

Spacing +1 added lines, -1 removed lines

@@ -360,7 +360,7 @@
 		if ($data === false) {
 			return null;
 		}
-$this->miscService->log("  ---- " . var_export($data, true));
+$this->miscService->log("  ---- ".var_export($data, true));
 		$circle = new Circle($this->l10n);
 		$circle->setId($data['id']);
 		$circle->setType($data['type']);