FederatedService::linkCircle() - Code Metrics - Inspection of "initiating the payload delivery" - nextcloud/circles - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — federated-circles ( 92a91f...545292 )

by Maxence

created 2017-05-19 22:27 UTC

FederatedService::linkCircle() A

↳ Parent: FederatedService

Complexity

Conditions	4
Paths	4

Size

Total Lines	20
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
dl	0
loc	20
rs	9.2
c	1
b	0
f	1
cc	4
eloc	11
nc	4
nop	2

<?php
/**
 * Circles - Bring cloud-users closer together.
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Maxence Lange <[email protected]>
 * @copyright 2017
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OCA\Circles\Service;


use Exception;
use OC\Http\Client\ClientService;
use OCA\Circles\Db\CirclesMapper;
use OCA\Circles\Db\FederatedLinksRequest;
use OCA\Circles\Db\MembersMapper;
use OCA\Circles\Exceptions\FederatedCircleLinkFormatException;
use OCA\Circles\Exceptions\FederatedCircleNotAllowedException;
use OCA\Circles\Exceptions\CircleTypeNotValid;
use OCA\Circles\Exceptions\FederatedLinkCreationIssue;
use OCA\Circles\Exceptions\FederatedRemoteCircleDoesNotExistException;
use OCA\Circles\Exceptions\FederatedRemoteDoesNotAllowException;
use OCA\Circles\Exceptions\MemberIsNotAdminException;
use OCA\Circles\Model\Circle;
use OCA\Circles\Model\FederatedLink;
use OCP\IL10N;

class FederatedService {


	/** @var string */
	private $userId;

	/** @var IL10N */
	private $l10n;

	/** @var ConfigService */
	private $configService;

	/** @var CirclesService */
	private $circlesService;

	/** @var FederatedLinksRequest */
	private $federatedLinksRequest;

	/** @var CirclesMapper */
	private $dbCircles;

	/** @var MembersMapper */
	private $dbMembers;

	/** @var ClientService */
	private $clientService;

	/** @var MiscService */
	private $miscService;


	/**
	 * CirclesService constructor.
	 *
	 * @param $userId
	 * @param IL10N $l10n
	 * @param ConfigService $configService
	 * @param DatabaseService $databaseService
	 * @param CirclesService $circlesService
	 * @param FederatedLinksRequest $federatedLinksRequest
	 * @param string $serverHost
	 * @param ClientService $clientService
	 * @param MiscService $miscService
	 */
	public function __construct(
		$userId,
		IL10N $l10n,
		ConfigService $configService,
		DatabaseService $databaseService,
		CirclesService $circlesService,
		FederatedLinksRequest $federatedLinksRequest,
		string $serverHost,
		ClientService $clientService,
		MiscService $miscService
	) {
		$this->userId = $userId;
		$this->l10n = $l10n;
		$this->configService = $configService;
		$this->circlesService = $circlesService;
		$this->federatedLinksRequest = $federatedLinksRequest;
		$this->serverHost = $serverHost;
class MyClass { }

$x = new MyClass();
$x->foo = true;
		$this->clientService = $clientService;

		$this->miscService = $miscService;

		$this->dbCircles = $databaseService->getCirclesMapper();
		$this->dbMembers = $databaseService->getMembersMapper();
	}


	/**
	 * linkCircle()
	 *
	 * link to a circle.
	 * Function will check if settings allow Federated links between circles, and the format of
	 * the link ($remote). If no exception, a request to the remote circle will be initiated
	 * using requestLinkWithCircle()
	 *
	 * $remote format: <circle_name>@<remote_host>
	 *
	 * @param int $circleId
	 * @param string $remote
	 *
	 * @throws Exception
	 * @throws FederatedCircleLinkFormatException
	 * @throws CircleTypeNotValid
	 * @throws MemberIsNotAdminException
	 *
	 * @return FederatedLink
	 */
	public function linkCircle($circleId, $remote) {

		if (!$this->configService->isFederatedAllowed()) {
			throw new FederatedCircleNotAllowedException(
				$this->l10n->t("Federated circles are not allowed on this Nextcloud")
			);
		}

		if (strpos($remote, '@') === false) {
			throw new FederatedCircleLinkFormatException(
				$this->l10n->t("Federated link does not have a valid format")
			);
		}

		try {
			return $this->requestLinkWithCircle($circleId, $remote);
		} catch (Exception $e) {
			throw $e;
		}
	}


	/**
	 * requestLinkWithCircle()
	 *
	 * Using CircleId, function will get more infos from the database.
	 * Will check if author is not admin and initiate a FederatedLink, save it
	 * in the database and send a request to the remote circle using requestLink()
	 * If any issue, entry is removed from the database.
	 *
	 * @param $circleId
	 * @param $remote
	 *
	 * @return FederatedLink
	 * @throws Exception
	 */
	private function requestLinkWithCircle($circleId, $remote) {

		$link = null;
		try {
			list($remoteCircle, $remoteAddress) = explode('@', $remote, 2);

			$circle = $this->circlesService->detailsCircle($circleId);
			$circle->getUser()
				   ->hasToBeAdmin();
			$circle->cantBePersonal();

			$link = new FederatedLink();
			$link->setCircleId($circleId)
				 ->setLocalAddress($this->serverHost)
				 ->setAddress($remoteAddress)
				 ->setRemoteCircleName($remoteCircle)
				 ->setStatus(FederatedLink::STATUS_LINK_SETUP)
				 ->generateToken();

			$this->federatedLinksRequest->create($link);
			$this->requestLink($circle, $link);

		} catch (Exception $e) {
			$this->federatedLinksRequest->delete($link);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
			throw $e;
		}

		return $link;
	}


	/**
	 * @param string $remote
	 *
	 * @return string
	 */
	private function generateLinkRemoteURL($remote) {

		if (strpos($remote, 'http') !== 0) {
			$remote = 'https://' . $remote;
		}

		return rtrim($remote, '/') . '/index.php/apps/circles/circles/link/';
	}

	/**
	 * @param string $remote
	 *
	 * @return string
	 */
	private function generatePayloadDeliveryURL($remote) {

		if (strpos($remote, 'http') !== 0) {
			$remote = 'http://' . $remote;
		}

		return rtrim($remote, '/') . '/index.php/apps/circles/circles/payload/';
	}


	/**
	 * requestLink()
	 *
	 *
	 * @param Circle $circle
	 * @param FederatedLink $link
	 *
	 * @return int

	 * @throws Exception
	 */
	private function requestLink(Circle $circle, FederatedLink &$link) {
		$args = [
			'token'      => $link->getToken(),
			'uniqueId'   => $circle->getUniqueId(),
			'sourceName' => $circle->getName(),
			'linkTo'     => $link->getRemoteCircleName(),
			'address'    => $link->getLocalAddress()
		];

		$client = $this->clientService->newClient();

		// TEST TEST TEST
		try {
			$request = $client->put(
				$this->generateLinkRemoteURL($link->getAddress()), [
																	 'body'            => $args,
																	 'timeout'         => 10,
																	 'connect_timeout' => 10,
																 ]
			);

			$result = json_decode($request->getBody(), true);

			$link->setStatus($result['status']);
			if (!$link->isValid()) {
				$this->parsingRequestLinkResult($result);
			}

			$link->setUniqueId($result['uniqueId']);
			$this->federatedLinksRequest->update($link);

			return true;
		} catch (Exception $e) {
			throw $e;
		}
	}


	private function parsingRequestLinkResult($result) {

		if ($result['reason'] === 'federated_not_allowed') {
			throw new FederatedRemoteDoesNotAllowException(
				$this->l10n->t('Federated circles are not allowed on the remote Nextcloud')
			);
		}

		if ($result['reason'] === 'duplicate_unique_id') {
			throw new FederatedRemoteDoesNotAllowException(
				$this->l10n->t('It seems that you are trying to link a circle to itself')
			);
		}

		if ($result['reason'] === 'duplicate_link') {
			throw new FederatedRemoteDoesNotAllowException(
				$this->l10n->t('This link exists already')
			);
		}

		if ($result['reason'] === 'circle_does_not_exist') {
			throw new FederatedRemoteCircleDoesNotExistException(
				$this->l10n->t('The requested remote circle does not exist')
			);
		}

		throw new Exception();
	}


	/**
	 * Create a new link into database and assign the correct status.
	 *
	 * @param Circle $circle
	 * @param FederatedLink $link
	 *
	 * @return bool
	 */
	public function initiateLink(Circle $circle, FederatedLink &$link) {

		$link->setCircleId($circle->getId());

		if ($circle->getType() === Circle::CIRCLES_PUBLIC) {
			$link->setStatus(FederatedLink::STATUS_LINK_UP);
		} else {
			$link->setStatus(FederatedLink::STATUS_REQUEST_SENT);
		}

		return $this->federatedLinksRequest->create($link);
	}


	/**
	 * @param $circleId
	 * @param $uniqueId
	 *
	 * @return FederatedLink

	 */
	public function getLink($circleId, $uniqueId) {
		return $this->federatedLinksRequest->get($circleId, $uniqueId);
	}


	public function initiateRemoteShare($token) {
		$args = [
			'token' => $token,
		];

		$client = $this->clientService->newClient();

		// TEST TEST TEST
		try {
			$request = $client->get(
				$this->generatePayloadDeliveryURL($this->serverHost), [
																		'body'            => $args,
																		'timeout'         => 10,
																		'connect_timeout' => 10,
																	]
			);

			$result = json_decode($request->getBody(), true);
			$this->miscService->log("RESULT: " . $result);

			return true;
		} catch (Exception $e) {
			throw $e;
		}
	}

}

1		<?php
2		/**
3		* Circles - Bring cloud-users closer together.
4		*
5		* This file is licensed under the Affero General Public License version 3 or
6		* later. See the COPYING file.
7		*
8		* @author Maxence Lange <[email protected]>
9		* @copyright 2017
10		* @license GNU AGPL version 3 or any later version
11		*
12		* This program is free software: you can redistribute it and/or modify
13		* it under the terms of the GNU Affero General Public License as
14		* published by the Free Software Foundation, either version 3 of the
15		* License, or (at your option) any later version.
16		*
17		* This program is distributed in the hope that it will be useful,
18		* but WITHOUT ANY WARRANTY; without even the implied warranty of
19		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
20		* GNU Affero General Public License for more details.
21		*
22		* You should have received a copy of the GNU Affero General Public License
23		* along with this program. If not, see <http://www.gnu.org/licenses/>.
24		*
25		*/
26
27		namespace OCA\Circles\Service;
28
29
30		use Exception;
31		use OC\Http\Client\ClientService;
32		use OCA\Circles\Db\CirclesMapper;
33		use OCA\Circles\Db\FederatedLinksRequest;
34		use OCA\Circles\Db\MembersMapper;
35		use OCA\Circles\Exceptions\FederatedCircleLinkFormatException;
36		use OCA\Circles\Exceptions\FederatedCircleNotAllowedException;
37		use OCA\Circles\Exceptions\CircleTypeNotValid;
38		use OCA\Circles\Exceptions\FederatedLinkCreationIssue;
39		use OCA\Circles\Exceptions\FederatedRemoteCircleDoesNotExistException;
40		use OCA\Circles\Exceptions\FederatedRemoteDoesNotAllowException;
41		use OCA\Circles\Exceptions\MemberIsNotAdminException;
42		use OCA\Circles\Model\Circle;
43		use OCA\Circles\Model\FederatedLink;
44		use OCP\IL10N;
45
46		class FederatedService {
47
48
49		/** @var string */
50		private $userId;
51
52		/** @var IL10N */
53		private $l10n;
54
55		/** @var ConfigService */
56		private $configService;
57
58		/** @var CirclesService */
59		private $circlesService;
60
61		/** @var FederatedLinksRequest */
62		private $federatedLinksRequest;
63
64		/** @var CirclesMapper */
65		private $dbCircles;
66
67		/** @var MembersMapper */
68		private $dbMembers;
69
70		/** @var ClientService */
71		private $clientService;
72
73		/** @var MiscService */
74		private $miscService;
75
76
77		/**
78		* CirclesService constructor.
79		*
80		* @param $userId
81		* @param IL10N $l10n
82		* @param ConfigService $configService
83		* @param DatabaseService $databaseService
84		* @param CirclesService $circlesService
85		* @param FederatedLinksRequest $federatedLinksRequest
86		* @param string $serverHost
87		* @param ClientService $clientService
88		* @param MiscService $miscService
89		*/
90		public function __construct(
91		$userId,
92		IL10N $l10n,
93		ConfigService $configService,
94		DatabaseService $databaseService,
95		CirclesService $circlesService,
96		FederatedLinksRequest $federatedLinksRequest,
97		string $serverHost,
98		ClientService $clientService,
99		MiscService $miscService
100		) {
101		$this->userId = $userId;
102		$this->l10n = $l10n;
103		$this->configService = $configService;
104		$this->circlesService = $circlesService;
105		$this->federatedLinksRequest = $federatedLinksRequest;
106		$this->serverHost = $serverHost;
		0 ignored issues – show Bug introduced 2017-05-17 08:59 UTC by Report Bug Copy Issue Report The property `serverHost` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
107		$this->clientService = $clientService;
108
109		$this->miscService = $miscService;
110
111		$this->dbCircles = $databaseService->getCirclesMapper();
112		$this->dbMembers = $databaseService->getMembersMapper();
113		}
114
115
116		/**
117		* linkCircle()
118		*
119		* link to a circle.
120		* Function will check if settings allow Federated links between circles, and the format of
121		* the link ($remote). If no exception, a request to the remote circle will be initiated
122		* using requestLinkWithCircle()
123		*
124		* $remote format: <circle_name>@<remote_host>
125		*
126		* @param int $circleId
127		* @param string $remote
128		*
129		* @throws Exception
130		* @throws FederatedCircleLinkFormatException
131		* @throws CircleTypeNotValid
132		* @throws MemberIsNotAdminException
133		*
134		* @return FederatedLink
135		*/
136		public function linkCircle($circleId, $remote) {
137
138		if (!$this->configService->isFederatedAllowed()) {
139		throw new FederatedCircleNotAllowedException(
140		$this->l10n->t("Federated circles are not allowed on this Nextcloud")
141		);
142		}
143
144		if (strpos($remote, '@') === false) {
145		throw new FederatedCircleLinkFormatException(
146		$this->l10n->t("Federated link does not have a valid format")
147		);
148		}
149
150		try {
151		return $this->requestLinkWithCircle($circleId, $remote);
152		} catch (Exception $e) {
153		throw $e;
154		}
155		}
156
157
158		/**
159		* requestLinkWithCircle()
160		*
161		* Using CircleId, function will get more infos from the database.
162		* Will check if author is not admin and initiate a FederatedLink, save it
163		* in the database and send a request to the remote circle using requestLink()
164		* If any issue, entry is removed from the database.
165		*
166		* @param $circleId
167		* @param $remote
168		*
169		* @return FederatedLink
170		* @throws Exception
171		*/
172		private function requestLinkWithCircle($circleId, $remote) {
173
174		$link = null;
175		try {
176		list($remoteCircle, $remoteAddress) = explode('@', $remote, 2);
177
178		$circle = $this->circlesService->detailsCircle($circleId);
179		$circle->getUser()
180		->hasToBeAdmin();
181		$circle->cantBePersonal();
182
183		$link = new FederatedLink();
184		$link->setCircleId($circleId)
185		->setLocalAddress($this->serverHost)
186		->setAddress($remoteAddress)
187		->setRemoteCircleName($remoteCircle)
188		->setStatus(FederatedLink::STATUS_LINK_SETUP)
189		->generateToken();
190
191		$this->federatedLinksRequest->create($link);
192		$this->requestLink($circle, $link);
193
194		} catch (Exception $e) {
195		$this->federatedLinksRequest->delete($link);
		0 ignored issues – show Bug introduced 2017-05-17 18:03 UTC by Report Bug Copy Issue Report It seems like `$link` defined by `null` on line `174` can be `null`; however, `OCA\Circles\Db\FederatedLinksRequest::delete()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
196		throw $e;
197		}
198
199		return $link;
200		}
201
202
203		/**
204		* @param string $remote
205		*
206		* @return string
207		*/
208	View Code Duplication	private function generateLinkRemoteURL($remote) {
		0 ignored issues – show Duplication introduced 2017-05-19 22:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
209		if (strpos($remote, 'http') !== 0) {
210		$remote = 'https://' . $remote;
211		}
212
213		return rtrim($remote, '/') . '/index.php/apps/circles/circles/link/';
214		}
215
216		/**
217		* @param string $remote
218		*
219		* @return string
220		*/
221	View Code Duplication	private function generatePayloadDeliveryURL($remote) {
		0 ignored issues – show Duplication introduced 2017-05-19 22:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
222		if (strpos($remote, 'http') !== 0) {
223		$remote = 'http://' . $remote;
224		}
225
226		return rtrim($remote, '/') . '/index.php/apps/circles/circles/payload/';
227		}
228
229
230		/**
231		* requestLink()
232		*
233		*
234		* @param Circle $circle
235		* @param FederatedLink $link
236		*
237		* @return int
		0 ignored issues – show Documentation introduced 2017-05-17 18:03 UTC by Report Bug Copy Issue Report Should the return type not be `boolean`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
238		* @throws Exception
239		*/
240		private function requestLink(Circle $circle, FederatedLink &$link) {
241		$args = [
242		'token' => $link->getToken(),
243		'uniqueId' => $circle->getUniqueId(),
244		'sourceName' => $circle->getName(),
245		'linkTo' => $link->getRemoteCircleName(),
246		'address' => $link->getLocalAddress()
247		];
248
249		$client = $this->clientService->newClient();
250
251		// TEST TEST TEST
252		try {
253		$request = $client->put(
254		$this->generateLinkRemoteURL($link->getAddress()), [
255		'body' => $args,
256		'timeout' => 10,
257		'connect_timeout' => 10,
258		]
259		);
260
261		$result = json_decode($request->getBody(), true);
262
263		$link->setStatus($result['status']);
264		if (!$link->isValid()) {
265		$this->parsingRequestLinkResult($result);
266		}
267
268		$link->setUniqueId($result['uniqueId']);
269		$this->federatedLinksRequest->update($link);
270
271		return true;
272		} catch (Exception $e) {
273		throw $e;
274		}
275		}
276
277
278		private function parsingRequestLinkResult($result) {
279
280		if ($result['reason'] === 'federated_not_allowed') {
281		throw new FederatedRemoteDoesNotAllowException(
282		$this->l10n->t('Federated circles are not allowed on the remote Nextcloud')
283		);
284		}
285
286		if ($result['reason'] === 'duplicate_unique_id') {
287		throw new FederatedRemoteDoesNotAllowException(
288		$this->l10n->t('It seems that you are trying to link a circle to itself')
289		);
290		}
291
292		if ($result['reason'] === 'duplicate_link') {
293		throw new FederatedRemoteDoesNotAllowException(
294		$this->l10n->t('This link exists already')
295		);
296		}
297
298		if ($result['reason'] === 'circle_does_not_exist') {
299		throw new FederatedRemoteCircleDoesNotExistException(
300		$this->l10n->t('The requested remote circle does not exist')
301		);
302		}
303
304		throw new Exception();
305		}
306
307
308		/**
309		* Create a new link into database and assign the correct status.
310		*
311		* @param Circle $circle
312		* @param FederatedLink $link
313		*
314		* @return bool
315		*/
316		public function initiateLink(Circle $circle, FederatedLink &$link) {
317
318		$link->setCircleId($circle->getId());
319
320		if ($circle->getType() === Circle::CIRCLES_PUBLIC) {
321		$link->setStatus(FederatedLink::STATUS_LINK_UP);
322		} else {
323		$link->setStatus(FederatedLink::STATUS_REQUEST_SENT);
324		}
325
326		return $this->federatedLinksRequest->create($link);
327		}
328
329
330		/**
331		* @param $circleId
332		* @param $uniqueId
333		*
334		* @return FederatedLink
		0 ignored issues – show Documentation introduced 2017-05-17 21:24 UTC by Report Bug Copy Issue Report Should the return type not be `FederatedLink\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
335		*/
336		public function getLink($circleId, $uniqueId) {
337		return $this->federatedLinksRequest->get($circleId, $uniqueId);
338		}
339
340
341		public function initiateRemoteShare($token) {
342		$args = [
343		'token' => $token,
344		];
345
346		$client = $this->clientService->newClient();
347
348		// TEST TEST TEST
349		try {
350		$request = $client->get(
351		$this->generatePayloadDeliveryURL($this->serverHost), [
352		'body' => $args,
353		'timeout' => 10,
354		'connect_timeout' => 10,
355		]
356		);
357
358		$result = json_decode($request->getBody(), true);
359		$this->miscService->log("RESULT: " . $result);
360
361		return true;
362		} catch (Exception $e) {
363		throw $e;
364		}
365		}
366
367		}

nextcloud / circles

Push — federated-circles ( 92a91f...545292 )

FederatedService::linkCircle() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like