nextcloud / circles

lib/ShareByCircleProvider.php

Spacing +9 added lines, -9 removed lines

@@ -300,19 +300,19 @@ 
 	 */
 	private function createShare($share) {
 		$this->miscService->log(
-			'Creating share (1/4) - type: ' . $share->getShareType() . ' - token: '
-			. $share->getToken() . ' - type: ' . $share->getShareType() . ' - with: '
-			. $share->getSharedWith() . ' - permissions: ' . $share->getPermissions(), 0
+			'Creating share (1/4) - type: '.$share->getShareType().' - token: '
+			. $share->getToken().' - type: '.$share->getShareType().' - with: '
+			. $share->getSharedWith().' - permissions: '.$share->getPermissions(), 0
 		);
 
 		$qb = $this->getBaseInsertSql($share);
-		$this->miscService->log('Share creation (2/4) : ' . json_encode($qb->getSQL()), 0);
+		$this->miscService->log('Share creation (2/4) : '.json_encode($qb->getSQL()), 0);
 
 		$result = $qb->execute();
-		$this->miscService->log('Share creation result (3/4) : ' . json_encode($result), 0);
+		$this->miscService->log('Share creation result (3/4) : '.json_encode($result), 0);
 
 		$id = $qb->getLastInsertId();
-		$this->miscService->log('Share created ID (4/4) : ' . $id, 0);
+		$this->miscService->log('Share created ID (4/4) : '.$id, 0);
 
 		try {
 			$share->setId($id);
@@ -537,7 +537,7 @@ 
 	public function getShareByToken($token) {
 		$qb = $this->dbConnection->getQueryBuilder();
 
-		$this->miscService->log("Opening share by token '#" . $token . "'", 0);
+		$this->miscService->log("Opening share by token '#".$token."'", 0);
 
 		$cursor = $qb->select('*')
 					 ->from('share')
@@ -561,7 +561,7 @@ 
 			try {
 				$data = $this->getShareByPersonalToken($token);
 			} catch (Exception $e) {
-				$this->miscService->log("Share '#" . $token . "' not found.", 0);
+				$this->miscService->log("Share '#".$token."' not found.", 0);
 				throw new ShareNotFound('Share not found', $this->l10n->t('Could not find share'));
 			}
 		}
@@ -570,7 +570,7 @@ 
 			$share = $this->createShareObject($data);
 		} catch (InvalidShare $e) {
 			$this->miscService->log(
-				"Share Object '#" . $token . "' not created. " . json_encode($data), 0
+				"Share Object '#".$token."' not created. ".json_encode($data), 0
 			);
 			throw new ShareNotFound('Share not found', $this->l10n->t('Could not find share'));
 		}

lib/Model/GlobalScale/GSEvent.php

Doc Comments +1 added lines, -1 removed lines

@@ -94,7 +94,7 @@
 	}
 
 	/**
-	 * @param mixed $type
+	 * @param string $type
 	 *
 	 * @return GSEvent
 	 */

lib/Db/CirclesRequest.php

Doc Comments -1 removed lines

@@ -130,7 +130,6 @@
 
 	/**
 	 * @param string $userId
-	 * @param string $instanceId
 	 * @param int $type
 	 * @param string $name
 	 * @param int $level

lib/Db/CirclesRequestBuilder.php

Doc Comments +3 added lines, -4 removed lines

@@ -92,7 +92,6 @@ 
 	/**
 	 * @param IQueryBuilder $qb
 	 * @param $userId
-	 * @param string $instanceId
 	 * @param string $circleUniqueId
 	 * @param $type
 	 * @param $name
@@ -126,9 +125,9 @@ 
 	/**
 	 * @param IQueryBuilder $qb
 	 * @param string $circleUniqueId
-	 * @param $userId
-	 * @param $type
-	 * @param $name
+	 * @param string $userId
+	 * @param integer $type
+	 * @param string $name
 	 * @param bool $forceAll
 	 *
 	 * @return array

lib/Service/ConfigService.php

Spacing +2 added lines, -2 removed lines

@@ -212,7 +212,7 @@ 
 		if ((!$this->isNonSSLLinksAllowed() || strpos($remote, 'http://') !== 0)
 			&& strpos($remote, 'https://') !== 0
 		) {
-			$remote = 'https://' . $remote;
+			$remote = 'https://'.$remote;
 		}
 
 		return rtrim($remote, '/');
@@ -399,7 +399,7 @@ 
 				return false;
 			}
 
-			throw new GSStatusException('GS and lookup are not configured : ' . $lookup . ', ' . $enabled);
+			throw new GSStatusException('GS and lookup are not configured : '.$lookup.', '.$enabled);
 		}
 
 		$clef = $this->config->getSystemValue('gss.jwt.key', '');

Doc Comments +1 added lines

@@ -440,6 +440,7 @@
 	 * @param string $type
 	 *
 	 * @throws GSStatusException
+	 * @return string
 	 */
 	public function getGSStatus(string $type = '') {
 		$enabled = $this->config->getSystemValueBool('gs.enabled', false);

lib/GlobalScale/MemberCreate.php

Spacing +2 added lines, -2 removed lines

@@ -111,13 +111,13 @@
 	 * @throws MemberAlreadyExistsException
 	 */
 	public function manage(GSEvent $event): void {
-		$this->miscService->log('new event; ' . json_encode($event));
+		$this->miscService->log('new event; '.json_encode($event));
 		if (!$event->hasCircle() || !$event->hasMember()) {
 			return;
 		}
 
 		$member = $event->getMember();
-		$this->miscService->log('new event; ' . json_encode($member));
+		$this->miscService->log('new event; '.json_encode($member));
 
 //		if ($member->getInstance() === '') {
 //			$member->setInstance($event->getSource());

lib/Search/GlobalScaleUsers.php

Spacing +1 added lines, -1 removed lines

@@ -98,7 +98,7 @@
 		RequestServerException |
 		RequestResultNotJsonException $e
 		) {
-			$this->miscService->log('Issue while retrieving instances from lookup: ' . $e->getMessage());
+			$this->miscService->log('Issue while retrieving instances from lookup: '.$e->getMessage());
 
 			return [];
 		}

lib/Service/MembersService.php

Doc Comments +6 added lines, -6 removed lines

@@ -145,7 +145,7 @@ 
 	 * @param int $type
 	 * @param string $instance
 	 *
-	 * @return array
+	 * @return Member[]
 	 * @throws Exception
 	 */
 	public function addMember($circleUniqueId, $ident, $type, string $instance) {
@@ -314,8 +314,8 @@ 
 	/**
 	 * Verify if a local account is valid.
 	 *
-	 * @param $ident
-	 * @param $type
+	 * @param string $ident
+	 * @param integer $type
 	 *
 	 * @param string $instance
 	 *
@@ -340,7 +340,7 @@ 
 	 * Verify if a mail have a valid format.
 	 *
 	 * @param $ident
-	 * @param $type
+	 * @param integer $type
 	 *
 	 * @throws EmailAccountInvalidFormatException
 	 */
@@ -368,7 +368,7 @@ 
 	 * Verify if a contact exist in current user address books.
 	 *
 	 * @param $ident
-	 * @param $type
+	 * @param integer $type
 	 *
 	 * @throws NoUserException
 	 * @throws EmailAccountInvalidFormatException
@@ -487,7 +487,7 @@ 
 	 * @param int $type
 	 * @param int $level
 	 *
-	 * @return array
+	 * @return Member[]
 	 * @throws Exception
 	 */
 	public function levelMember($circleUniqueId, $name, $type, $instance, $level) {

lib/Controller/GlobalScaleController.php

Doc Comments -1 removed lines

@@ -111,7 +111,6 @@
 	 * @PublicPage
 	 * @NoCSRFRequired
 	 *
-	 * @param string $data
 	 *
 	 * @return DataResponse
 	 */

Spacing +1 added lines, -1 removed lines

@@ -91,7 +91,7 @@
 			$wrappers = $this->gsUpstreamService->getEventsByToken($token);
 		} catch (Exception $e) {
 			$this->miscService->log(
-				'exception during async: ' . ['token' => $token, 'error' => $e->getMessage()]
+				'exception during async: '.['token' => $token, 'error' => $e->getMessage()]
 			);
 			$this->fail(['token' => $token, 'error' => $e->getMessage()]);
 		}