nextcloud / circles

lib/Migration/ImportOwncloudCustomGroups.php

Spacing +1 added lines, -1 removed lines

@@ -148,7 +148,7 @@
 				continue;
 			}
 
-			$level = (int) $row['role'] === 1 ? Member::LEVEL_OWNER : Member::LEVEL_MEMBER;
+			$level = (int)$row['role'] === 1 ? Member::LEVEL_OWNER : Member::LEVEL_MEMBER;
 
 			if ($level === Member::LEVEL_OWNER) {
 				if (isset($this->circleHasAdmin[$this->circlesById[$row['group_id']]])) {

lib/Service/CirclesService.php

Doc Comments +1 added lines, -1 removed lines

@@ -273,7 +273,7 @@
 
 
 	/**
-	 * @param $circleName
+	 * @param string $circleName
 	 *
 	 * @return Circle|null
 	 */

Spacing +8 added lines, -8 removed lines

@@ -195,7 +195,7 @@ 
 	 *
 	 * @param Circle $circle
 	 */
-	private function detailsCircleMembers(Circle &$circle) {
+	private function detailsCircleMembers(Circle & $circle) {
 		$members =
 			$this->membersRequest->getMembers($circle->getUniqueId(), $circle->getHigherViewer());
 
@@ -208,7 +208,7 @@ 
 	 *
 	 * @param Circle $circle
 	 */
-	private function detailsCircleLinkedGroups(Circle &$circle) {
+	private function detailsCircleLinkedGroups(Circle & $circle) {
 		$groups = [];
 		if ($this->configService->isLinkedGroupsAllowed()) {
 			$groups =
@@ -226,7 +226,7 @@ 
 	 *
 	 * @param Circle $circle
 	 */
-	private function detailsCircleFederatedCircles(Circle &$circle) {
+	private function detailsCircleFederatedCircles(Circle & $circle) {
 		$links = [];
 
 		try {
@@ -407,23 +407,23 @@ 
 		switch ($type) {
 			case Circle::CIRCLES_PERSONAL:
 				return $urlGen->getAbsoluteURL(
-					$urlGen->imagePath(Application::APP_NAME, 'personal' . $ext)
+					$urlGen->imagePath(Application::APP_NAME, 'personal'.$ext)
 				);
 			case Circle::CIRCLES_CLOSED:
 				return $urlGen->getAbsoluteURL(
-					$urlGen->imagePath(Application::APP_NAME, 'closed' . $ext)
+					$urlGen->imagePath(Application::APP_NAME, 'closed'.$ext)
 				);
 			case Circle::CIRCLES_SECRET:
 				return $urlGen->getAbsoluteURL(
-					$urlGen->imagePath(Application::APP_NAME, 'secret' . $ext)
+					$urlGen->imagePath(Application::APP_NAME, 'secret'.$ext)
 				);
 			case Circle::CIRCLES_PUBLIC:
 				return $urlGen->getAbsoluteURL(
-					$urlGen->imagePath(Application::APP_NAME, 'public' . $ext)
+					$urlGen->imagePath(Application::APP_NAME, 'public'.$ext)
 				);
 		}
 
-		return $urlGen->getAbsoluteURL($urlGen->imagePath(Application::APP_NAME, 'black_circle' . $ext));
+		return $urlGen->getAbsoluteURL($urlGen->imagePath(Application::APP_NAME, 'black_circle'.$ext));
 	}
 
 }
\ No newline at end of file

lib/Migration/GenerateUniqueIdOnCreatedCircle.php

Spacing +1 added lines, -1 removed lines

@@ -93,7 +93,7 @@
 
 			$update = $this->connection->getQueryBuilder();
 			$update->update('circles_circles')
-				   ->set('unique_id', $update->createNamedParameter('d' . $uniqueId))
+				   ->set('unique_id', $update->createNamedParameter('d'.$uniqueId))
 				   ->where(
 					   $update->expr()
 							  ->eq('id', $update->createNamedParameter($itemId))

lib/Service/EventsService.php

Doc Comments +1 added lines, -1 removed lines

@@ -282,7 +282,7 @@
 	 * generateEvent()
 	 * Create an Activity Event with the basic settings for the app.
 	 *
-	 * @param $type
+	 * @param string $type
 	 *
 	 * @return \OCP\Activity\IEvent
 	 */

lib/Service/FederatedService.php

Doc Comments +1 added lines, -1 removed lines

@@ -227,7 +227,7 @@
 	 *
 	 * @param Circle $circle
 	 * @param FederatedLink $link
-	 * @param $status
+	 * @param integer $status
 	 *
 	 * @return bool
 	 */

Spacing +8 added lines, -8 removed lines

@@ -312,7 +312,7 @@ 
 	 * @return string
 	 */
 	private function generateLinkRemoteURL($remote) {
-		return $this->generateRemoteHost($remote) . self::REMOTE_URL_LINK;
+		return $this->generateRemoteHost($remote).self::REMOTE_URL_LINK;
 	}
 
 
@@ -322,7 +322,7 @@ 
 	 * @return string
 	 */
 	private function generatePayloadDeliveryURL($remote) {
-		return $this->generateRemoteHost($remote) . self::REMOTE_URL_PAYLOAD;
+		return $this->generateRemoteHost($remote).self::REMOTE_URL_PAYLOAD;
 	}
 
 
@@ -335,7 +335,7 @@ 
 		if ((!$this->configService->isNonSSLLinksAllowed() || strpos($remote, 'http://') !== 0)
 			&& strpos($remote, 'https://') !== 0
 		) {
-			$remote = 'https://' . $remote;
+			$remote = 'https://'.$remote;
 		}
 
 		return rtrim($remote, '/');
@@ -352,7 +352,7 @@ 
 	 * @return boolean
 	 * @throws Exception
 	 */
-	private function requestLink(Circle $circle, FederatedLink &$link) {
+	private function requestLink(Circle $circle, FederatedLink & $link) {
 		$args = [
 			'apiVersion' => Circles::version(),
 			'token'      => $link->getToken(true),
@@ -609,7 +609,7 @@ 
 	 * @return bool
 	 * @throws Exception
 	 */
-	public function updateLinkRemote(FederatedLink &$link) {
+	public function updateLinkRemote(FederatedLink & $link) {
 		$args = [
 			'apiVersion' => Circles::version(),
 			'token'      => $link->getToken(true),
@@ -647,7 +647,7 @@ 
 	 *
 	 * @throws Exception
 	 */
-	public function initiateLink(Circle $circle, FederatedLink &$link) {
+	public function initiateLink(Circle $circle, FederatedLink & $link) {
 
 		try {
 			$this->checkLinkRequestValidity($circle, $link);
@@ -697,7 +697,7 @@ 
 	 * @return bool
 	 * @throws Exception
 	 */
-	public function receiveFrame($token, $uniqueId, SharingFrame &$frame) {
+	public function receiveFrame($token, $uniqueId, SharingFrame & $frame) {
 		try {
 			$link = $this->circlesRequest->getLinkFromToken((string)$token, (string)$uniqueId);
 		} catch (Exception $e) {
@@ -821,7 +821,7 @@ 
 
 			} catch (Exception $e) {
 				$this->miscService->log(
-					'Issue while sending sharing frame to ' . $link->getAddress() . ' - '
+					'Issue while sending sharing frame to '.$link->getAddress().' - '
 					. $e->getMessage()
 				);
 			}

lib/Db/CirclesRequest.php

Spacing +1 added lines, -1 removed lines

@@ -185,7 +185,7 @@
 	 *
 	 * @throws CircleAlreadyExistsException
 	 */
-	public function createCircle(Circle &$circle, $userId) {
+	public function createCircle(Circle & $circle, $userId) {
 
 		if (!$this->isCircleUnique($circle, $userId)) {
 			throw new CircleAlreadyExistsException(

lib/AppInfo/Application.php

Spacing +4 added lines, -4 removed lines

@@ -89,7 +89,7 @@ 
 	 *
 	 * @param $container
 	 */
-	private function registerServices(IAppContainer &$container) {
+	private function registerServices(IAppContainer & $container) {
 
 		$container->registerService(
 			'MiscService', function(IAppContainer $c) {
@@ -183,7 +183,7 @@ 
 	 *
 	 * @param $container
 	 */
-	private static function registerControllers(IAppContainer &$container) {
+	private static function registerControllers(IAppContainer & $container) {
 
 		$container->registerService(
 			'SettingsController', function(IAppContainer $c) {
@@ -268,7 +268,7 @@ 
 	 *
 	 * @param IAppContainer $container
 	 */
-	private static function registerDatabaseRequesters(IAppContainer &$container) {
+	private static function registerDatabaseRequesters(IAppContainer & $container) {
 
 		$container->registerService(
 			'CirclesRequest', function(IAppContainer $c) {
@@ -307,7 +307,7 @@ 
 	 *
 	 * @param $container
 	 */
-	private static function registerCores(IAppContainer &$container) {
+	private static function registerCores(IAppContainer & $container) {
 
 		$container->registerService(
 			'Logger', function(IAppContainer $c) {

lib/Service/GroupsService.php

Spacing +1 added lines, -1 removed lines

@@ -190,7 +190,7 @@
 	 *
 	 * @throws \Exception
 	 */
-	private function editGroupLevel(Circle $circle, Member &$group, $level) {
+	private function editGroupLevel(Circle $circle, Member & $group, $level) {
 		try {
 			$isMod = $circle->getHigherViewer();
 			$isMod->hasToBeAdmin();

Doc Comments +6 added lines, -6 removed lines

@@ -86,7 +86,7 @@ 
 	 * @param string $circleUniqueId
 	 * @param string $groupId
 	 *
-	 * @return array
+	 * @return Member[]
 	 * @throws \Exception
 	 */
 	public function linkGroup($circleUniqueId, $groupId) {
@@ -112,8 +112,8 @@ 
 	/**
 	 * Check if a fresh member can be generated (by linkGroup)
 	 *
-	 * @param $circleId
-	 * @param $groupId
+	 * @param string $circleId
+	 * @param string $groupId
 	 *
 	 * @return null|Member
 	 * @throws MemberAlreadyExistsException
@@ -148,7 +148,7 @@ 
 	 * @param string $groupId
 	 * @param int $level
 	 *
-	 * @return array
+	 * @return Member[]
 	 * @throws \Exception
 	 */
 	public function levelGroup($circleUniqueId, $groupId, $level) {
@@ -186,7 +186,7 @@ 
 	/**
 	 * @param Circle $circle
 	 * @param Member $group
-	 * @param $level
+	 * @param integer $level
 	 *
 	 * @throws \Exception
 	 */
@@ -213,7 +213,7 @@ 
 	 * @param string $circleUniqueId
 	 * @param string $groupId
 	 *
-	 * @return array
+	 * @return Member[]
 	 * @throws \Exception
 	 */
 	public function unlinkGroup($circleUniqueId, $groupId) {

lib/ShareByCircleProvider.php

Doc Comments +7 added lines

@@ -432,6 +432,13 @@
 	}
 
 
+	/**
+	 * @param string $userId
+	 * @param integer $shareType
+	 * @param Node|null $node
+	 * @param integer $limit
+	 * @param integer $offset
+	 */
 	private function getSharedWithCircleMembers($userId, $shareType, $node, $limit, $offset) {
 
 		$qb = $this->getCompleteSelectSql();

Spacing +2 added lines, -2 removed lines

@@ -569,7 +569,7 @@ 
 	 * @param IShare $share
 	 * @param $data
 	 */
-	private function assignShareObjectPropertiesFromParent(IShare &$share, $data) {
+	private function assignShareObjectPropertiesFromParent(IShare & $share, $data) {
 		if (isset($data['f_permissions'])) {
 			$entryData = $data;
 			$entryData['permissions'] = $entryData['f_permissions'];
@@ -588,7 +588,7 @@ 
 	 * @param IShare $share
 	 * @param $data
 	 */
-	private function assignShareObjectSharesProperties(IShare &$share, $data) {
+	private function assignShareObjectSharesProperties(IShare & $share, $data) {
 		$shareTime = new \DateTime();
 		$shareTime->setTimestamp((int)$data['stime']);