Completed
Pull Request — master (#615)
by Maxence
02:40
created
lib/Db/CoreQueryBuilder.php 1 patch
Spacing   +71 added lines, -71 removed lines patch added patch discarded remove patch
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
375 375
 		}
376 376
 
377 377
 		if ($circle->getDisplayName() !== '') {
378
-			$this->searchInDBField('display_name', '%' . $circle->getDisplayName() . '%');
378
+			$this->searchInDBField('display_name', '%'.$circle->getDisplayName().'%');
379 379
 		}
380 380
 		if ($circle->getConfig() > 0) {
381 381
 			$this->limitBitwise('config', $circle->getConfig());
@@ -394,7 +394,7 @@  discard block
 block discarded – undo
394 394
 			$this->generateRemoteInstanceSelectAlias($aliasRemoteInstance)
395 395
 				 ->leftJoin(
396 396
 					 $alias, CoreRequestBuilder::TABLE_REMOTE, $aliasRemoteInstance,
397
-					 $expr->eq($alias . '.instance', $aliasRemoteInstance . '.instance')
397
+					 $expr->eq($alias.'.instance', $aliasRemoteInstance.'.instance')
398 398
 				 );
399 399
 		} catch (RequestBuilderException $e) {
400 400
 		}
@@ -447,7 +447,7 @@  discard block
 block discarded – undo
447 447
 		$expr = $this->expr();
448 448
 		$this->leftJoin(
449 449
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_REMOTE, $aliasRemote,
450
-			$expr->eq($aliasRemote . '.instance', $this->createNamedParameter($remoteInstance->getInstance()))
450
+			$expr->eq($aliasRemote.'.instance', $this->createNamedParameter($remoteInstance->getInstance()))
451 451
 		);
452 452
 	}
453 453
 
@@ -475,12 +475,12 @@  discard block
 block discarded – undo
475 475
 		$this->leftJoin(
476 476
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteMember,
477 477
 			$expr->andX(
478
-				$expr->eq($aliasRemoteMember . '.circle_id', $aliasCircle . '.unique_id'),
478
+				$expr->eq($aliasRemoteMember.'.circle_id', $aliasCircle.'.unique_id'),
479 479
 				$expr->eq(
480
-					$aliasRemoteMember . '.instance',
480
+					$aliasRemoteMember.'.instance',
481 481
 					$this->createNamedParameter($remoteInstance->getInstance())
482 482
 				),
483
-				$expr->gte($aliasRemoteMember . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
483
+				$expr->gte($aliasRemoteMember.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
484 484
 			)
485 485
 		);
486 486
 	}
@@ -512,21 +512,21 @@  discard block
 block discarded – undo
512 512
 		$this->leftJoin(
513 513
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteCircle,
514 514
 			$expr->andX(
515
-				$expr->eq($aliasRemoteCircle . '.single_id', $aliasCircle . '.unique_id'),
516
-				$expr->emptyString($aliasRemoteCircle . '.instance'),
517
-				$expr->gte($aliasRemoteCircle . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
515
+				$expr->eq($aliasRemoteCircle.'.single_id', $aliasCircle.'.unique_id'),
516
+				$expr->emptyString($aliasRemoteCircle.'.instance'),
517
+				$expr->gte($aliasRemoteCircle.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
518 518
 			)
519 519
 		);
520 520
 		$this->leftJoin(
521 521
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteCircleOwner,
522 522
 			$expr->andX(
523
-				$expr->eq($aliasRemoteCircle . '.circle_id', $aliasRemoteCircleOwner . '.circle_id'),
523
+				$expr->eq($aliasRemoteCircle.'.circle_id', $aliasRemoteCircleOwner.'.circle_id'),
524 524
 				$expr->eq(
525
-					$aliasRemoteCircleOwner . '.instance',
525
+					$aliasRemoteCircleOwner.'.instance',
526 526
 					$this->createNamedParameter($remoteInstance->getInstance())
527 527
 				),
528 528
 				$expr->eq(
529
-					$aliasRemoteCircleOwner . '.level', $this->createNamedParameter(Member::LEVEL_OWNER)
529
+					$aliasRemoteCircleOwner.'.level', $this->createNamedParameter(Member::LEVEL_OWNER)
530 530
 				)
531 531
 			)
532 532
 		);
@@ -559,16 +559,16 @@  discard block
 block discarded – undo
559 559
 		$expr = $this->expr();
560 560
 		$orX = $expr->orX();
561 561
 		$orX->add(
562
-			$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBALSCALE))
562
+			$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBALSCALE))
563 563
 		);
564 564
 
565 565
 		$orExtOrPassive = $expr->orX();
566 566
 		$orExtOrPassive->add(
567
-			$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))
567
+			$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))
568 568
 		);
569 569
 		if (!$sensitive) {
570 570
 			$orExtOrPassive->add(
571
-				$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
571
+				$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
572 572
 			);
573 573
 		} else {
574 574
 			if ($this->getDefaultSelectAlias() === CoreQueryBuilder::MEMBER) {
@@ -577,8 +577,8 @@  discard block
 block discarded – undo
577 577
 		}
578 578
 
579 579
 		$orInstance = $expr->orX();
580
-		$orInstance->add($expr->isNotNull($aliasRemoteMember . '.instance'));
581
-		$orInstance->add($expr->isNotNull($aliasRemoteCircleOwner . '.instance'));
580
+		$orInstance->add($expr->isNotNull($aliasRemoteMember.'.instance'));
581
+		$orInstance->add($expr->isNotNull($aliasRemoteCircleOwner.'.instance'));
582 582
 
583 583
 		$andExternal = $expr->andX();
584 584
 		$andExternal->add($orExtOrPassive);
@@ -587,13 +587,13 @@  discard block
 block discarded – undo
587 587
 		$orExtOrTrusted = $expr->orX();
588 588
 		$orExtOrTrusted->add($andExternal);
589 589
 		$orExtOrTrusted->add(
590
-			$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED))
590
+			$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED))
591 591
 		);
592 592
 
593 593
 		$andTrusted = $expr->andX();
594 594
 		$andTrusted->add($orExtOrTrusted);
595 595
 		$andTrusted->add($this->exprLimitBitwise('config', Circle::CFG_FEDERATED, $aliasCircle));
596
-		$andTrusted->add($expr->emptyString($aliasOwner . '.instance'));
596
+		$andTrusted->add($expr->emptyString($aliasOwner.'.instance'));
597 597
 		$orX->add($andTrusted);
598 598
 
599 599
 		$this->andWhere($orX);
@@ -620,7 +620,7 @@  discard block
 block discarded – undo
620 620
 		}
621 621
 		$this->leftJoin(
622 622
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
623
-			$expr->eq($aliasMember . '.circle_id', $alias . '.unique_id')
623
+			$expr->eq($aliasMember.'.circle_id', $alias.'.unique_id')
624 624
 		);
625 625
 
626 626
 		$this->filterDirectMembership($aliasMember, $member);
@@ -641,30 +641,30 @@  discard block
 block discarded – undo
641 641
 
642 642
 		if ($member->getUserId() !== '') {
643 643
 			$andX->add(
644
-				$expr->eq($aliasMember . '.user_id', $this->createNamedParameter($member->getUserId()))
644
+				$expr->eq($aliasMember.'.user_id', $this->createNamedParameter($member->getUserId()))
645 645
 			);
646 646
 		}
647 647
 
648 648
 		if ($member->getSingleId() !== '') {
649 649
 			$andX->add(
650
-				$expr->eq($aliasMember . '.single_id', $this->createNamedParameter($member->getSingleId()))
650
+				$expr->eq($aliasMember.'.single_id', $this->createNamedParameter($member->getSingleId()))
651 651
 			);
652 652
 		}
653 653
 
654 654
 		if ($member->getUserType() > 0) {
655 655
 			$andX->add(
656
-				$expr->eq($aliasMember . '.user_type', $this->createNamedParameter($member->getUserType()))
656
+				$expr->eq($aliasMember.'.user_type', $this->createNamedParameter($member->getUserType()))
657 657
 			);
658 658
 		}
659 659
 
660 660
 		$andX->add(
661
-			$expr->eq($aliasMember . '.instance', $this->createNamedParameter($this->getInstance($member)))
661
+			$expr->eq($aliasMember.'.instance', $this->createNamedParameter($this->getInstance($member)))
662 662
 		);
663 663
 
664 664
 		if ($member->getLevel() > 0) {
665 665
 			$andX->add(
666 666
 				$expr->gte(
667
-					$aliasMember . '.level',
667
+					$aliasMember.'.level',
668 668
 					$this->createNamedParameter($member->getLevel(), IQueryBuilder::PARAM_INT)
669 669
 				)
670 670
 			);
@@ -705,7 +705,7 @@  discard block
 block discarded – undo
705 705
 			$helperAlias,
706 706
 			CoreRequestBuilder::TABLE_CIRCLE,
707 707
 			$aliasCircle,
708
-			$expr->eq($aliasCircle . '.unique_id', $helperAlias . '.' . $field)
708
+			$expr->eq($aliasCircle.'.unique_id', $helperAlias.'.'.$field)
709 709
 		);
710 710
 
711 711
 		if (!is_null($initiator)) {
@@ -736,7 +736,7 @@  discard block
 block discarded – undo
736 736
 		$this->generateCircleSelectAlias($aliasInvitedBy)
737 737
 			 ->leftJoin(
738 738
 				 $aliasMember, CoreRequestBuilder::TABLE_CIRCLE, $aliasInvitedBy,
739
-				 $expr->eq($aliasMember . '.invited_by', $aliasInvitedBy . '.unique_id')
739
+				 $expr->eq($aliasMember.'.invited_by', $aliasInvitedBy.'.unique_id')
740 740
 			 );
741 741
 
742 742
 		$this->leftJoinOwner($aliasInvitedBy);
@@ -767,7 +767,7 @@  discard block
 block discarded – undo
767 767
 		$this->generateCircleSelectAlias($aliasBasedOn)
768 768
 			 ->leftJoin(
769 769
 				 $aliasMember, CoreRequestBuilder::TABLE_CIRCLE, $aliasBasedOn,
770
-				 $expr->eq($aliasBasedOn . '.unique_id', $aliasMember . '.single_id')
770
+				 $expr->eq($aliasBasedOn.'.unique_id', $aliasMember.'.single_id')
771 771
 			 );
772 772
 
773 773
 		if (!is_null($initiator)) {
@@ -800,9 +800,9 @@  discard block
 block discarded – undo
800 800
 			 ->leftJoin(
801 801
 				 $alias, CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
802 802
 				 $expr->andX(
803
-					 $expr->eq($aliasMember . '.circle_id', $alias . '.' . $field),
803
+					 $expr->eq($aliasMember.'.circle_id', $alias.'.'.$field),
804 804
 					 $expr->eq(
805
-						 $aliasMember . '.level',
805
+						 $aliasMember.'.level',
806 806
 						 $this->createNamedParameter(Member::LEVEL_OWNER, self::PARAM_INT)
807 807
 					 )
808 808
 				 )
@@ -840,10 +840,10 @@  discard block
 block discarded – undo
840 840
 			 ->leftJoin(
841 841
 				 $alias, CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
842 842
 				 $expr->andX(
843
-					 $expr->eq($aliasMember . '.circle_id', $alias . '.' . $fieldCircleId),
844
-					 $expr->eq($aliasMember . '.single_id', $alias . '.' . $fieldSingleId),
843
+					 $expr->eq($aliasMember.'.circle_id', $alias.'.'.$fieldCircleId),
844
+					 $expr->eq($aliasMember.'.single_id', $alias.'.'.$fieldSingleId),
845 845
 					 $expr->gte(
846
-						 $aliasMember . '.level',
846
+						 $aliasMember.'.level',
847 847
 						 $this->createNamedParameter(Member::LEVEL_MEMBER, self::PARAM_INT)
848 848
 					 )
849 849
 				 )
@@ -876,7 +876,7 @@  discard block
 block discarded – undo
876 876
 
877 877
 		$this->leftJoin(
878 878
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasMembership,
879
-			$expr->eq($aliasMembership . '.circle_id', $alias . '.' . $field)
879
+			$expr->eq($aliasMembership.'.circle_id', $alias.'.'.$field)
880 880
 		);
881 881
 
882 882
 //		if (!$this->getBool('getData', $options, false)) {
@@ -890,8 +890,8 @@  discard block
 block discarded – undo
890 890
 			 ->leftJoin(
891 891
 				 $alias, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritedBy,
892 892
 				 $expr->andX(
893
-					 $expr->eq($aliasMembership . '.inheritance_last', $aliasInheritedBy . '.circle_id'),
894
-					 $expr->eq($aliasMembership . '.single_id', $aliasInheritedBy . '.single_id')
893
+					 $expr->eq($aliasMembership.'.inheritance_last', $aliasInheritedBy.'.circle_id'),
894
+					 $expr->eq($aliasMembership.'.single_id', $aliasInheritedBy.'.single_id')
895 895
 				 )
896 896
 			 );
897 897
 
@@ -908,12 +908,12 @@  discard block
 block discarded – undo
908 908
 		$aliasUpstreamMembership = $this->generateAlias($alias, self::UPSTREAM_MEMBERSHIPS, $options);
909 909
 		$this->leftJoin(
910 910
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasUpstreamMembership,
911
-			$expr->eq($aliasUpstreamMembership . '.single_id', $this->createNamedParameter($singleId))
911
+			$expr->eq($aliasUpstreamMembership.'.single_id', $this->createNamedParameter($singleId))
912 912
 		);
913 913
 
914 914
 		$orX = $expr->orX(
915
-			$expr->eq($aliasUpstreamMembership . '.circle_id', $alias . '.' . $field),
916
-			$expr->eq($alias . '.' . $field, $this->createNamedParameter($singleId))
915
+			$expr->eq($aliasUpstreamMembership.'.circle_id', $alias.'.'.$field),
916
+			$expr->eq($alias.'.'.$field, $this->createNamedParameter($singleId))
917 917
 		);
918 918
 
919 919
 		$this->andWhere($orX);
@@ -933,7 +933,7 @@  discard block
 block discarded – undo
933 933
 
934 934
 		$expr = $this->expr();
935 935
 		$aliasMembership = $this->generateAlias($alias, self::MEMBERSHIPS);
936
-		$this->andWhere($expr->eq($aliasMembership . '.circle_id', $this->createNamedParameter($singleId)));
936
+		$this->andWhere($expr->eq($aliasMembership.'.circle_id', $this->createNamedParameter($singleId)));
937 937
 	}
938 938
 
939 939
 
@@ -957,7 +957,7 @@  discard block
 block discarded – undo
957 957
 		$this->leftJoin(
958 958
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasMembership,
959 959
 //			$expr->andX(
960
-			$expr->eq($aliasMembership . '.inheritance_last', $alias . '.' . $field)
960
+			$expr->eq($aliasMembership.'.inheritance_last', $alias.'.'.$field)
961 961
 //				$expr->eq($aliasMembership . '.single_id', $alias . '.single_id')
962 962
 //			)
963 963
 		);
@@ -971,8 +971,8 @@  discard block
 block discarded – undo
971 971
 			 ->leftJoin(
972 972
 				 $aliasMembership, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritanceFrom,
973 973
 				 $expr->andX(
974
-					 $expr->eq($aliasMembership . '.circle_id', $aliasInheritanceFrom . '.circle_id'),
975
-					 $expr->eq($aliasMembership . '.inheritance_first', $aliasInheritanceFrom . '.single_id')
974
+					 $expr->eq($aliasMembership.'.circle_id', $aliasInheritanceFrom.'.circle_id'),
975
+					 $expr->eq($aliasMembership.'.inheritance_first', $aliasInheritanceFrom.'.single_id')
976 976
 				 )
977 977
 			 );
978 978
 	}
@@ -1038,7 +1038,7 @@  discard block
 block discarded – undo
1038 1038
 			$aliasMembership,
1039 1039
 			$expr->andX(
1040 1040
 				$this->exprLimit('single_id', $initiator->getSingleId(), $aliasMembership),
1041
-				$expr->eq($aliasMembership . '.circle_id', $helperAlias . '.' . $field)
1041
+				$expr->eq($aliasMembership.'.circle_id', $helperAlias.'.'.$field)
1042 1042
 			)
1043 1043
 		);
1044 1044
 
@@ -1051,8 +1051,8 @@  discard block
 block discarded – undo
1051 1051
 			$this->leftJoin(
1052 1052
 				$aliasMembership, CoreRequestBuilder::TABLE_MEMBER, $aliasInitiator,
1053 1053
 				$expr->andX(
1054
-					$expr->eq($aliasMembership . '.inheritance_first', $aliasInitiator . '.single_id'),
1055
-					$expr->eq($aliasMembership . '.circle_id', $aliasInitiator . '.circle_id')
1054
+					$expr->eq($aliasMembership.'.inheritance_first', $aliasInitiator.'.single_id'),
1055
+					$expr->eq($aliasMembership.'.circle_id', $aliasInitiator.'.circle_id')
1056 1056
 				)
1057 1057
 			);
1058 1058
 
@@ -1060,8 +1060,8 @@  discard block
 block discarded – undo
1060 1060
 			$this->leftJoin(
1061 1061
 				$aliasInitiator, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritedBy,
1062 1062
 				$expr->andX(
1063
-					$expr->eq($aliasMembership . '.single_id', $aliasInheritedBy . '.single_id'),
1064
-					$expr->eq($aliasMembership . '.inheritance_last', $aliasInheritedBy . '.circle_id')
1063
+					$expr->eq($aliasMembership.'.single_id', $aliasInheritedBy.'.single_id'),
1064
+					$expr->eq($aliasMembership.'.inheritance_last', $aliasInheritedBy.'.circle_id')
1065 1065
 				)
1066 1066
 			);
1067 1067
 
@@ -1080,7 +1080,7 @@  discard block
 block discarded – undo
1080 1080
 			$aliasInheritedByMembership = $this->generateAlias($aliasInheritedBy, self::MEMBERSHIPS);
1081 1081
 			$this->generateMembershipSelectAlias($aliasMembership, $aliasInheritedByMembership);
1082 1082
 		} catch (RequestBuilderException $e) {
1083
-			\OC::$server->getLogger()->log(3, '-- ' . $e->getMessage());
1083
+			\OC::$server->getLogger()->log(3, '-- '.$e->getMessage());
1084 1084
 		}
1085 1085
 	}
1086 1086
 
@@ -1104,7 +1104,7 @@  discard block
 block discarded – undo
1104 1104
 		$orX = $expr->orX();
1105 1105
 		$orX->add(
1106 1106
 			$expr->andX(
1107
-				$expr->gte($aliasMembership . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
1107
+				$expr->gte($aliasMembership.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
1108 1108
 			)
1109 1109
 		);
1110 1110
 
@@ -1112,7 +1112,7 @@  discard block
 block discarded – undo
1112 1112
 			$orX->add(
1113 1113
 				$expr->andX(
1114 1114
 					$this->exprLimitBitwise('config', Circle::CFG_PERSONAL, $alias),
1115
-					$expr->eq($aliasMembership . '.level', $this->createNamedParameter(Member::LEVEL_OWNER))
1115
+					$expr->eq($aliasMembership.'.level', $this->createNamedParameter(Member::LEVEL_OWNER))
1116 1116
 				)
1117 1117
 			);
1118 1118
 		}
@@ -1121,7 +1121,7 @@  discard block
 block discarded – undo
1121 1121
 		}
1122 1122
 		if ($this->getBool('canBeVisitor', $options, false)) {
1123 1123
 			// TODO: should find a better way, also filter on remote initiator on non-federated ?
1124
-			$orX->add($expr->gte($alias . '.config', $this->createNamedParameter(0)));
1124
+			$orX->add($expr->gte($alias.'.config', $this->createNamedParameter(0)));
1125 1125
 		}
1126 1126
 		if ($this->getBool('canBeVisitorOnOpen', $options, false)) {
1127 1127
 			$andOpen = $expr->andX();
@@ -1189,21 +1189,21 @@  discard block
 block discarded – undo
1189 1189
 		$expr = $this->expr();
1190 1190
 		$andPassive = $expr->andX();
1191 1191
 		$andPassive->add(
1192
-			$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
1192
+			$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
1193 1193
 		);
1194 1194
 
1195 1195
 		$orMemberOrLevel = $expr->orX();
1196 1196
 		$orMemberOrLevel->add(
1197
-			$expr->eq($this->getDefaultSelectAlias() . '.instance', $alias . '.instance')
1197
+			$expr->eq($this->getDefaultSelectAlias().'.instance', $alias.'.instance')
1198 1198
 		);
1199 1199
 		// TODO: do we need this ? (display members from the local instance)
1200 1200
 		$orMemberOrLevel->add(
1201
-			$expr->emptyString($this->getDefaultSelectAlias() . '.instance')
1201
+			$expr->emptyString($this->getDefaultSelectAlias().'.instance')
1202 1202
 		);
1203 1203
 
1204 1204
 		$orMemberOrLevel->add(
1205 1205
 			$expr->eq(
1206
-				$this->getDefaultSelectAlias() . '.level',
1206
+				$this->getDefaultSelectAlias().'.level',
1207 1207
 				$this->createNamedParameter(Member::LEVEL_OWNER)
1208 1208
 			)
1209 1209
 		);
@@ -1240,11 +1240,11 @@  discard block
 block discarded – undo
1240 1240
 			 )
1241 1241
 			 ->leftJoin(
1242 1242
 				 $aliasShare, CoreRequestBuilder::TABLE_FILE_CACHE, $aliasFileCache,
1243
-				 $expr->eq($aliasShare . '.file_source', $aliasFileCache . '.fileid')
1243
+				 $expr->eq($aliasShare.'.file_source', $aliasFileCache.'.fileid')
1244 1244
 			 )
1245 1245
 			 ->leftJoin(
1246 1246
 				 $aliasFileCache, CoreRequestBuilder::TABLE_STORAGES, $aliasStorages,
1247
-				 $expr->eq($aliasFileCache . '.storage', $aliasStorages . '.numeric_id')
1247
+				 $expr->eq($aliasFileCache.'.storage', $aliasStorages.'.numeric_id')
1248 1248
 			 );
1249 1249
 	}
1250 1250
 
@@ -1266,8 +1266,8 @@  discard block
 block discarded – undo
1266 1266
 		$this->leftJoin(
1267 1267
 			$aliasShareMemberships, CoreRequestBuilder::TABLE_SHARE, $aliasShareChild,
1268 1268
 			$expr->andX(
1269
-				$expr->eq($aliasShareChild . '.parent', $aliasShare . '.id'),
1270
-				$expr->eq($aliasShareChild . '.share_with', $aliasShareMemberships . '.single_id')
1269
+				$expr->eq($aliasShareChild.'.parent', $aliasShare.'.id'),
1270
+				$expr->eq($aliasShareChild.'.share_with', $aliasShareMemberships.'.single_id')
1271 1271
 			)
1272 1272
 		);
1273 1273
 
@@ -1317,13 +1317,13 @@  discard block
 block discarded – undo
1317 1317
 		$this->leftJoin(
1318 1318
 			$aliasMountMemberships, CoreRequestBuilder::TABLE_MOUNTPOINT, $aliasMountpoint,
1319 1319
 			$expr->andX(
1320
-				$expr->eq($aliasMountpoint . '.mount_id', $aliasMount . '.mount_id'),
1321
-				$expr->eq($aliasMountpoint . '.single_id', $aliasMountMemberships . '.single_id')
1320
+				$expr->eq($aliasMountpoint.'.mount_id', $aliasMount.'.mount_id'),
1321
+				$expr->eq($aliasMountpoint.'.single_id', $aliasMountMemberships.'.single_id')
1322 1322
 			)
1323 1323
 		);
1324 1324
 
1325
-		$this->selectAlias($aliasMountpoint . '.mountpoint', $aliasMountpoint . '_mountpoint');
1326
-		$this->selectAlias($aliasMountpoint . '.mountpoint_hash', $aliasMountpoint . '_mountpoint_hash');
1325
+		$this->selectAlias($aliasMountpoint.'.mountpoint', $aliasMountpoint.'_mountpoint');
1326
+		$this->selectAlias($aliasMountpoint.'.mountpoint_hash', $aliasMountpoint.'_mountpoint_hash');
1327 1327
 	}
1328 1328
 
1329 1329
 
@@ -1427,10 +1427,10 @@  discard block
 block discarded – undo
1427 1427
 	 */
1428 1428
 	public function generateAlias(string $base, string $extension, ?array &$options = []): string {
1429 1429
 		$search = str_replace('_', '.', $base);
1430
-		$path = $search . '.' . $extension;
1430
+		$path = $search.'.'.$extension;
1431 1431
 		if (!$this->validKey($path, self::$SQL_PATH)
1432 1432
 			&& !in_array($extension, $this->getArray($search, self::$SQL_PATH))) {
1433
-			throw new RequestBuilderException($extension . ' not found in ' . $search);
1433
+			throw new RequestBuilderException($extension.' not found in '.$search);
1434 1434
 		}
1435 1435
 
1436 1436
 		if (!is_array($options)) {
@@ -1439,15 +1439,15 @@  discard block
 block discarded – undo
1439 1439
 
1440 1440
 		$optionPath = '';
1441 1441
 		foreach (explode('.', $path) as $p) {
1442
-			$optionPath = trim($optionPath . '.' . $p, '.');
1442
+			$optionPath = trim($optionPath.'.'.$p, '.');
1443 1443
 			$options = array_merge(
1444 1444
 				$options,
1445
-				$this->getArray($optionPath . '.' . self::OPTIONS, self::$SQL_PATH),
1446
-				$this->getArray($optionPath . '.' . self::OPTIONS, $this->options)
1445
+				$this->getArray($optionPath.'.'.self::OPTIONS, self::$SQL_PATH),
1446
+				$this->getArray($optionPath.'.'.self::OPTIONS, $this->options)
1447 1447
 			);
1448 1448
 		}
1449 1449
 
1450
-		return $base . '_' . $extension;
1450
+		return $base.'_'.$extension;
1451 1451
 	}
1452 1452
 
1453 1453
 
@@ -1467,7 +1467,7 @@  discard block
 block discarded – undo
1467 1467
 			} else {
1468 1468
 				$k = $arr;
1469 1469
 			}
1470
-			$path[$k] = $prefix . '_' . $k . '_';
1470
+			$path[$k] = $prefix.'_'.$k.'_';
1471 1471
 		}
1472 1472
 
1473 1473
 		return $path;
Please login to merge, or discard this patch.
lib/Command/MembersList.php 1 patch
Spacing   +14 added lines, -15 removed lines patch added patch discarded remove patch
@@ -186,11 +186,11 @@  discard block
 block discarded – undo
186 186
 			$this->federatedUserService->commandLineInitiator($initiator, $initiatorType, $circleId, true);
187 187
 			$circle = $this->circleService->getCircle($circleId);
188 188
 
189
-			$output->writeln('<info>Name</info>: ' . $circle->getName());
189
+			$output->writeln('<info>Name</info>: '.$circle->getName());
190 190
 			$owner = $circle->getOwner();
191
-			$output->writeln('<info>Owner</info>: ' . $owner->getUserId() . '@' . $owner->getInstance());
191
+			$output->writeln('<info>Owner</info>: '.$owner->getUserId().'@'.$owner->getInstance());
192 192
 			$type = implode(", ", Circle::getCircleFlags($circle, Circle::FLAGS_LONG));
193
-			$output->writeln('<info>Config</info>: ' . $type);
193
+			$output->writeln('<info>Config</info>: '.$type);
194 194
 			$output->writeln(' ');
195 195
 
196 196
 			$tree = new NC22TreeNode(null, new SimpleDataStore(['circle' => $circle]));
@@ -254,8 +254,7 @@  discard block
 block discarded – undo
254 254
 					($this->input->getOption('display-name')) ?
255 255
 						$member->getDisplayName() : $member->getUserId(),
256 256
 					$this->configService->displayInstance($member->getInstance()),
257
-					($level > 0) ? Member::$DEF_LEVEL[$level] :
258
-						'(' . strtolower($member->getStatus()) . ')',
257
+					($level > 0) ? Member::$DEF_LEVEL[$level] : '('.strtolower($member->getStatus()).')',
259 258
 					($member->hasInvitedBy()) ? $this->configService->displayFederatedUser(
260 259
 						$member->getInvitedBy()
261 260
 					) : 'Unknown'
@@ -417,18 +416,18 @@  discard block
 block discarded – undo
417 416
 				$member = $data->gObj('member', Member::class);
418 417
 
419 418
 				if ($lineNumber === 1) {
420
-					$line .= '<info>' . $member->getSingleId() . '</info>';
419
+					$line .= '<info>'.$member->getSingleId().'</info>';
421 420
 					if (!$this->configService->isLocalInstance($member->getInstance())) {
422
-						$line .= '@' . $member->getInstance();
421
+						$line .= '@'.$member->getInstance();
423 422
 					}
424
-					$line .= ' (' . Member::$DEF_LEVEL[$member->getLevel()] . ')';
423
+					$line .= ' ('.Member::$DEF_LEVEL[$member->getLevel()].')';
425 424
 
426
-					$line .= ' <info>MemberId</info>: ' . $member->getId();
425
+					$line .= ' <info>MemberId</info>: '.$member->getId();
427 426
 					$name = ($this->input->getOption('display-name')) ?
428 427
 						$member->getDisplayName() : $member->getUserId();
429
-					$line .= ' <info>Name</info>: ' . $name;
428
+					$line .= ' <info>Name</info>: '.$name;
430 429
 					$source = ($member->hasBasedOn()) ? $member->getBasedOn()->getSource() : '';
431
-					$line .= ' <info>Source</info>: ' . Circle::$DEF_SOURCE[$source];
430
+					$line .= ' <info>Source</info>: '.Circle::$DEF_SOURCE[$source];
432 431
 				}
433 432
 
434 433
 				if ($lineNumber === 2) {
@@ -440,16 +439,16 @@  discard block
 block discarded – undo
440 439
 						return $line;
441 440
 					}
442 441
 					$owner = $circle->getOwner();
443
-					$line .= '<info>Owner</info>: ' . $owner->getUserId() . '@' . $owner->getInstance();
442
+					$line .= '<info>Owner</info>: '.$owner->getUserId().'@'.$owner->getInstance();
444 443
 					$type = implode(", ", Circle::getCircleFlags($circle, Circle::FLAGS_LONG));
445
-					$line .= ($type === '') ? '' : ' <info>Config</info>: ' . $type;
444
+					$line .= ($type === '') ? '' : ' <info>Config</info>: '.$type;
446 445
 				}
447 446
 
448 447
 			} else {
449 448
 				if ($lineNumber === 1 && !is_null($circle)) {
450
-					$line .= '<info>' . $circle->getSingleId() . '</info>';
449
+					$line .= '<info>'.$circle->getSingleId().'</info>';
451 450
 					if (!$this->configService->isLocalInstance($circle->getInstance())) {
452
-						$line .= '@' . $circle->getInstance();
451
+						$line .= '@'.$circle->getInstance();
453 452
 					}
454 453
 				}
455 454
 			}
Please login to merge, or discard this patch.