Completed
Push — federated-circles ( 673aab...31ccdf )
by Maxence
02:42
created
lib/Service/FederatedService.php 2 patches
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -167,8 +167,8 @@  discard block
 block discarded – undo
167 167
 	 * in the database and send a request to the remote circle using requestLink()
168 168
 	 * If any issue, entry is removed from the database.
169 169
 	 *
170
-	 * @param $circleId
171
-	 * @param $remote
170
+	 * @param integer $circleId
171
+	 * @param string $remote
172 172
 	 *
173 173
 	 * @return FederatedLink
174 174
 	 * @throws Exception
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
 	 * @param Circle $circle
239 239
 	 * @param FederatedLink $link
240 240
 	 *
241
-	 * @return int
241
+	 * @return boolean
242 242
 	 * @throws Exception
243 243
 	 */
244 244
 	private function requestLink(Circle $circle, FederatedLink &$link) {
@@ -369,8 +369,8 @@  discard block
 block discarded – undo
369 369
 	}
370 370
 
371 371
 	/**
372
-	 * @param $circleId
373
-	 * @param $uniqueId
372
+	 * @param integer $circleId
373
+	 * @param string $uniqueId
374 374
 	 *
375 375
 	 * @return FederatedLink
376 376
 	 */
@@ -380,7 +380,7 @@  discard block
 block discarded – undo
380 380
 
381 381
 
382 382
 	/**
383
-	 * @param $circleId
383
+	 * @param integer $circleId
384 384
 	 *
385 385
 	 * @return FederatedLink[]
386 386
 	 */
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -211,10 +211,10 @@  discard block
 block discarded – undo
211 211
 	 */
212 212
 	private function generateLinkRemoteURL($remote) {
213 213
 		if (strpos($remote, 'http') !== 0) {
214
-			$remote = 'https://' . $remote;
214
+			$remote = 'https://'.$remote;
215 215
 		}
216 216
 
217
-		return rtrim($remote, '/') . '/index.php/apps/circles/circles/link/';
217
+		return rtrim($remote, '/').'/index.php/apps/circles/circles/link/';
218 218
 	}
219 219
 
220 220
 	/**
@@ -224,10 +224,10 @@  discard block
 block discarded – undo
224 224
 	 */
225 225
 	private function generatePayloadDeliveryURL($remote) {
226 226
 		if (strpos($remote, 'http') !== 0) {
227
-			$remote = 'http://' . $remote;
227
+			$remote = 'http://'.$remote;
228 228
 		}
229 229
 
230
-		return rtrim($remote, '/') . '/index.php/apps/circles/circles/payload/';
230
+		return rtrim($remote, '/').'/index.php/apps/circles/circles/payload/';
231 231
 	}
232 232
 
233 233
 
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
 	 * @return int
242 242
 	 * @throws Exception
243 243
 	 */
244
-	private function requestLink(Circle $circle, FederatedLink &$link) {
244
+	private function requestLink(Circle $circle, FederatedLink & $link) {
245 245
 		$args = [
246 246
 			'token'      => $link->getToken(),
247 247
 			'uniqueId'   => $circle->getUniqueId(),
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
 	 *
317 317
 	 * @return bool
318 318
 	 */
319
-	public function initiateLink(Circle $circle, FederatedLink &$link) {
319
+	public function initiateLink(Circle $circle, FederatedLink & $link) {
320 320
 
321 321
 		$link->setCircleId($circle->getId());
322 322
 
@@ -338,7 +338,7 @@  discard block
 block discarded – undo
338 338
 	 * @return bool
339 339
 	 * @throws Exception
340 340
 	 */
341
-	public function receiveFrame(string $token, string $uniqueId, SharingFrame &$frame) {
341
+	public function receiveFrame(string $token, string $uniqueId, SharingFrame & $frame) {
342 342
 
343 343
 		$link = $this->circlesRequest->getLinkFromToken($token, $uniqueId);
344 344
 		if ($link === null) {
@@ -414,7 +414,7 @@  discard block
 block discarded – undo
414 414
 
415 415
 			$result = json_decode($request->getBody(), true);
416 416
 			$this->miscService->log(
417
-				"initiateRemoteShare result: " . $uniqueId . '  ----  ' . var_export($result, true)
417
+				"initiateRemoteShare result: ".$uniqueId.'  ----  '.var_export($result, true)
418 418
 			);
419 419
 
420 420
 			return true;
Please login to merge, or discard this patch.