nextcloud / circles

lib/Service/EventsService.php

Doc Comments +1 added lines, -1 removed lines

@@ -282,7 +282,7 @@
 	 * generateEvent()
 	 * Create an Activity Event with the basic settings for the app.
 	 *
-	 * @param $type
+	 * @param string $type
 	 *
 	 * @return \OCP\Activity\IEvent
 	 */

lib/Service/MiscService.php

Spacing +1 added lines, -1 removed lines

@@ -284,7 +284,7 @@
 		ob_start();
 		echo(json_encode($result));
 		$size = ob_get_length();
-		header('Content-Length: ' . $size);
+		header('Content-Length: '.$size);
 		ob_end_flush();
 		flush();
 	}

Doc Comments +5 added lines, -2 removed lines

@@ -66,6 +66,9 @@ 
 		$this->userManager = $userManager;
 	}
 
+	/**
+	 * @param string $message
+	 */
 	public function log($message, $level = 4) {
 		$data = array(
 			'app'   => $this->appName,
@@ -86,7 +89,7 @@ 
 
 	/**
 	 * @param $arr
-	 * @param $k
+	 * @param string $k
 	 *
 	 * @param string $default
 	 *
@@ -257,7 +260,7 @@ 
 
 
 	/**
-	 * @param $ident
+	 * @param string $ident
 	 *
 	 * @return mixed|string
 	 * @deprecated

lib/Service/MembersService.php

Spacing +1 added lines, -1 removed lines

@@ -323,7 +323,7 @@
 			return;
 		}
 
-		$tmpContact = $this->userId . ':' . $ident;
+		$tmpContact = $this->userId.':'.$ident;
 		$result = MiscService::getContactData($tmpContact);
 		if (empty($result)) {
 			throw new NoUserException($this->l10n->t("This contact is not available"));

Doc Comments +7 added lines, -7 removed lines

@@ -349,8 +349,8 @@ 
 	/**
 	 * Verify if a local account is valid.
 	 *
-	 * @param $ident
-	 * @param $type
+	 * @param string $ident
+	 * @param integer $type
 	 *
 	 * @param string $instance
 	 *
@@ -401,8 +401,8 @@ 
 	/**
 	 * Verify if a contact exist in current user address books.
 	 *
-	 * @param $ident
-	 * @param $type
+	 * @param string $ident
+	 * @param integer $type
 	 *
 	 * @throws NoUserException
 	 * @throws EmailAccountInvalidFormatException
@@ -494,8 +494,8 @@ 
 	 * Will return any data of a user related to a circle (as a Member). User can be a 'non-member'
 	 * Viewer needs to be at least Member of the Circle
 	 *
-	 * @param $circleId
-	 * @param $userId
+	 * @param string $circleId
+	 * @param string $userId
 	 * @param $type
 	 * @param bool $forceAll
 	 *
@@ -551,7 +551,7 @@ 
 	 * @param int $level
 	 * @param bool $force
 	 *
-	 * @return array
+	 * @return DeprecatedMember[]
 	 * @throws CircleDoesNotExistException
 	 * @throws CircleTypeNotValidException
 	 * @throws ConfigNoCircleAvailableException

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 namespace OCA\Circles\Service;
 
 
-use daita\MySmallPhpTools\Exceptions\RequestNetworkException;
 use daita\MySmallPhpTools\Exceptions\RequestResultNotJsonException;
 use daita\MySmallPhpTools\Model\Nextcloud\nc22\NC22Request;
 use daita\MySmallPhpTools\Model\Request;

lib/Model/DavCard.php

Spacing +1 added lines, -1 removed lines

@@ -146,7 +146,7 @@
 	 * @return string
 	 */
 	public function getUniqueId(): string {
-		return $this->getAddressBookId() . '/' . $this->getCardUri();
+		return $this->getAddressBookId().'/'.$this->getCardUri();
 	}
 
 

lib/Model/GlobalScale/GSEvent.php

Doc Comments +1 added lines, -1 removed lines

@@ -94,7 +94,7 @@
 	}
 
 	/**
-	 * @param mixed $type
+	 * @param string $type
 	 *
 	 * @return GSEvent
 	 */

lib/GlobalScale/GSMount/MountManager.php

Spacing +1 added lines, -1 removed lines

@@ -109,7 +109,7 @@
 	 * @return string
 	 */
 	protected function stripPath($path) {
-		$prefix = '/' . $this->userId . '/files';
+		$prefix = '/'.$this->userId.'/files';
 
 		return rtrim(substr($path, strlen($prefix)), '/');
 	}

lib/Model/GlobalScale/GSShare.php

Spacing +2 added lines, -2 removed lines

@@ -154,7 +154,7 @@ 
 			return $mountPoint;
 		}
 
-		return '/' . $userId . '/files/' . ltrim($mountPoint, '/');
+		return '/'.$userId.'/files/'.ltrim($mountPoint, '/');
 	}
 
 	/**
@@ -293,7 +293,7 @@ 
 	public function toMount(string $userId, string $protocol = 'https'): array {
 		return [
 			'owner'       => $this->getOwner(),
-			'remote'      => $protocol . '://' . $this->getInstance(),
+			'remote'      => $protocol.'://'.$this->getInstance(),
 			'token'       => $this->getToken(),
 			'share_token' => $this->getToken(),
 			'password'    => $this->getPassword(),

lib/Db/GSSharesRequest.php

Spacing +2 added lines, -2 removed lines

@@ -121,11 +121,11 @@
 
 	private function leftJoinMountPoint(IQueryBuilder $qb, string $userId) {
 		$expr = $qb->expr();
-		$pf = '' . $this->default_select_alias . '.';
+		$pf = ''.$this->default_select_alias.'.';
 
 		$on = $expr->andX();
 		$on->add($expr->eq('mp.user_id', $qb->createNamedParameter($userId)));
-		$on->add($expr->eq('mp.share_id', $pf . 'id'));
+		$on->add($expr->eq('mp.share_id', $pf.'id'));
 
 		/** @noinspection PhpMethodParametersCountMismatchInspection */
 		$qb->selectAlias('mp.mountPoint', 'gsshares_mountpoint')

lib/GlobalScale/GSMount/MountProvider.php

Spacing +3 added lines, -3 removed lines

@@ -148,13 +148,13 @@
 		}
 
 		$info = pathinfo($share->getMountPoint());
-		$filename = $this->get('dirname', $info) . '/' . $this->get('filename', $info);
+		$filename = $this->get('dirname', $info).'/'.$this->get('filename', $info);
 		$extension = $this->get('extension', $info);
-		$extension = ($extension === '') ? '' : '.' . $extension;
+		$extension = ($extension === '') ? '' : '.'.$extension;
 
 		$n = 2;
 		while (true) {
-			$path = $filename . " ($n)" . $extension;
+			$path = $filename." ($n)".$extension;
 			try {
 				$fs->get($path);
 			} catch (NotFoundException $e) {