nextcloud / circles

lib/Search/GlobalScaleUsers.php

Spacing +1 added lines, -1 removed lines

@@ -95,7 +95,7 @@
 		RequestResultNotJsonException $e
 		) {
 			$this->miscService->log(
-				'Issue while search users from lookup: ' . get_class($e) . ' ' . $e->getMessage()
+				'Issue while search users from lookup: '.get_class($e).' '.$e->getMessage()
 			);
 
 			return [];

lib/Activity/ProviderParser.php

Spacing +4 added lines, -4 removed lines

@@ -137,7 +137,7 @@ 
 				continue;
 			}
 
-			$replace['{' . $k . '}'] = $data[$k]['_parsed'];
+			$replace['{'.$k.'}'] = $data[$k]['_parsed'];
 		}
 
 		$line = strtr($line, $replace);
@@ -301,7 +301,7 @@ 
 		return [
 			'type'    => $member->getTypeName(),
 			'id'      => $member->getUserId(),
-			'name'    => $member->getCachedName() . ' (' . $member->getTypeString() . ')',
+			'name'    => $member->getCachedName().' ('.$member->getTypeString().')',
 			'_parsed' => $member->getCachedName()
 		];
 	}
@@ -337,8 +337,8 @@ 
 		return [
 			'type'    => 'circle',
 			'id'      => $link->getUniqueId(),
-			'name'    => $link->getToken() . '@' . $link->getAddress(),
-			'_parsed' => $link->getToken() . '@' . $link->getAddress()
+			'name'    => $link->getToken().'@'.$link->getAddress(),
+			'_parsed' => $link->getToken().'@'.$link->getAddress()
 		];
 	}
 

lib/AppInfo/Application.php

Spacing +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
 use Throwable;
 
 
-require_once __DIR__ . '/../../vendor/autoload.php';
+require_once __DIR__.'/../../vendor/autoload.php';
 
 
 /**

lib/Command/Groups.php

Spacing +1 added lines, -1 removed lines

@@ -93,7 +93,7 @@
 	 */
 	private function listLinkedGroups(InputInterface $input, OutputInterface $output) {
 		if ($input->getOption('list') !== true) {
-			return ;
+			return;
 		}
 
 		throw new FakeException();

lib/Service/SharingFrameService.php

Doc Comments +2 added lines, -2 removed lines

@@ -181,7 +181,7 @@ 
 	 *
 	 * @param SharingFrame $frame
 	 * @param DeprecatedCircle $circle
-	 * @param $broadcast
+	 * @param string|null $broadcast
 	 */
 	private function generateHeaders(SharingFrame $frame, DeprecatedCircle $circle, $broadcast) {
 
@@ -220,7 +220,7 @@ 
 	 * Please use getFrameFromCircle();
 	 *
 	 * @param string $circleUniqueId
-	 * @param $viewerId
+	 * @param string $viewerId
 	 *
 	 * @return SharingFrame[]
 	 * @throws CircleDoesNotExistException

Unused Use Statements -1 removed lines

@@ -38,7 +38,6 @@
 use OCA\Circles\Exceptions\CircleDoesNotExistException;
 use OCA\Circles\Exceptions\ConfigNoCircleAvailableException;
 use OCA\Circles\Exceptions\MemberDoesNotExistException;
-use OCA\Circles\Exceptions\PayloadDeliveryException;
 use OCA\Circles\Exceptions\SharingFrameAlreadyDeliveredException;
 use OCA\Circles\Exceptions\SharingFrameAlreadyExistException;
 use OCA\Circles\Exceptions\SharingFrameDoesNotExistException;

Spacing +3 added lines, -3 removed lines

@@ -148,7 +148,7 @@ 
 	public function createFrame($circleUniqueId, SharingFrame $frame, $broadcast = null) {
 
 		$this->miscService->log(
-			'Create frame with payload ' . json_encode($frame->getPayload()) . ' as ' . $this->userId, 0
+			'Create frame with payload '.json_encode($frame->getPayload()).' as '.$this->userId, 0
 		);
 		try {
 			$circle = $this->circlesRequest->getCircle($circleUniqueId, $this->userId);
@@ -163,7 +163,7 @@ 
 			$this->initiateShare($circle->getUniqueId(), $frame->getUniqueId());
 		} catch (Exception $e) {
 			$this->miscService->log(
-				'fail to create frame for circle ' . $circleUniqueId . ' - ' . $e->getMessage()
+				'fail to create frame for circle '.$circleUniqueId.' - '.$e->getMessage()
 			);
 			throw $e;
 		}
@@ -310,7 +310,7 @@ 
 			return true;
 		} catch (Exception $e) {
 			$this->miscService->log(
-				'fail to initialise circle share with request ' . json_encode($request) . ' - '
+				'fail to initialise circle share with request '.json_encode($request).' - '
 				. $e->getMessage(), 3
 			);
 			throw $e;

lib/Service/CirclesService.php

Spacing +5 added lines, -5 removed lines

@@ -569,24 +569,24 @@
 		switch ($type) {
 			case DeprecatedCircle::CIRCLES_PERSONAL:
 				return $urlGen->getAbsoluteURL(
-					$urlGen->imagePath(Application::APP_ID, 'personal' . $ext)
+					$urlGen->imagePath(Application::APP_ID, 'personal'.$ext)
 				);
 			case DeprecatedCircle::CIRCLES_CLOSED:
 				return $urlGen->getAbsoluteURL(
-					$urlGen->imagePath(Application::APP_ID, 'closed' . $ext)
+					$urlGen->imagePath(Application::APP_ID, 'closed'.$ext)
 				);
 			case DeprecatedCircle::CIRCLES_SECRET:
 				return $urlGen->getAbsoluteURL(
-					$urlGen->imagePath(Application::APP_ID, 'secret' . $ext)
+					$urlGen->imagePath(Application::APP_ID, 'secret'.$ext)
 				);
 			case DeprecatedCircle::CIRCLES_PUBLIC:
 				return $urlGen->getAbsoluteURL(
-					$urlGen->imagePath(Application::APP_ID, 'black_circle' . $ext)
+					$urlGen->imagePath(Application::APP_ID, 'black_circle'.$ext)
 				);
 		}
 
 		return $urlGen->getAbsoluteURL(
-			$urlGen->imagePath(Application::APP_ID, 'black_circle' . $ext)
+			$urlGen->imagePath(Application::APP_ID, 'black_circle'.$ext)
 		);
 	}
 

lib/Db/DeprecatedMembersRequest.php

Doc Comments +4 added lines, -1 removed lines

@@ -316,7 +316,7 @@ 
 	 * returns the index of a specific UserID in a Members List
 	 *
 	 * @param array $members
-	 * @param $userId
+	 * @param string $userId
 	 *
 	 * @return int
 	 */
@@ -656,6 +656,9 @@ 
 	}
 
 
+	/**
+	 * @param string $groupId
+	 */
 	public function unlinkAllFromGroup($groupId) {
 		$qb = $this->getMembersDeleteSql();
 

lib/Model/DeprecatedCircle.php

Doc Comments +1 added lines, -1 removed lines

@@ -178,7 +178,7 @@
 
 	/**
 	 * @param array $arr
-	 * @param $key
+	 * @param string $key
 	 * @param int $type
 	 *
 	 * @return null|DeprecatedMember

Spacing +1 added lines, -1 removed lines

@@ -292,7 +292,7 @@
 	 * @return int
 	 */
 	public static function convertTypeToConfig(int $type): int {
-		switch($type) {
+		switch ($type) {
 			case DeprecatedCircle::CIRCLES_PERSONAL:
 				return 2;
 			case DeprecatedCircle::CIRCLES_SECRET:

lib/Model/DeprecatedMember.php

Doc Comments +3 added lines

@@ -41,6 +41,9 @@
 class DeprecatedMember extends BaseMember {
 
 
+	/**
+	 * @param integer $circleType
+	 */
 	public function inviteToCircle($circleType) {
 
 		if ($circleType === 0) {

Unused Use Statements -2 removed lines

@@ -31,9 +31,7 @@
 use OCA\Circles\Exceptions\MemberCantJoinCircleException;
 use OCA\Circles\Exceptions\MemberDoesNotExistException;
 use OCA\Circles\Exceptions\MemberIsBlockedException;
-use OCA\Circles\Exceptions\MemberIsNotAdminException;
 use OCA\Circles\Exceptions\MemberIsNotModeratorException;
-use OCA\Circles\Exceptions\MemberIsNotOwnerException;
 use OCA\Circles\Exceptions\MemberIsOwnerException;
 use OCA\Circles\Exceptions\MemberTypeCantEditLevelException;
 use OCA\Circles\Exceptions\ModeratorIsNotHighEnoughException;