Completed
Pull Request — master (#637)
by Maxence
02:59
created
lib/Command/CirclesList.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -226,7 +226,7 @@
 block discarded – undo
226 226
 					Circle::$DEF_SOURCE[$circle->getSource()],
227 227
 					$this->cut($displayName ? $owner->getDisplayName() : $owner->getUserId(), 40),
228 228
 					$this->configService->displayInstance($owner->getInstance()),
229
-					$circle->getPopulation() . '/' . $this->getInt(
229
+					$circle->getPopulation().'/'.$this->getInt(
230 230
 						'members_limit', $circle->getSettings(), -1
231 231
 					)
232 232
 				]
Please login to merge, or discard this patch.
lib/Command/MembersList.php 1 patch
Spacing   +14 added lines, -15 removed lines patch added patch discarded remove patch
@@ -189,11 +189,11 @@  discard block
 block discarded – undo
189 189
 			$this->federatedUserService->commandLineInitiator($initiator, $initiatorType, $circleId, true);
190 190
 			$circle = $this->circleService->getCircle($circleId);
191 191
 
192
-			$output->writeln('<info>Name</info>: ' . $circle->getName());
192
+			$output->writeln('<info>Name</info>: '.$circle->getName());
193 193
 			$owner = $circle->getOwner();
194
-			$output->writeln('<info>Owner</info>: ' . $owner->getUserId() . '@' . $owner->getInstance());
194
+			$output->writeln('<info>Owner</info>: '.$owner->getUserId().'@'.$owner->getInstance());
195 195
 			$type = implode(", ", Circle::getCircleFlags($circle, Circle::FLAGS_LONG));
196
-			$output->writeln('<info>Config</info>: ' . $type);
196
+			$output->writeln('<info>Config</info>: '.$type);
197 197
 			$output->writeln(' ');
198 198
 
199 199
 			$tree = new NC22TreeNode(null, new SimpleDataStore(['circle' => $circle]));
@@ -260,8 +260,7 @@  discard block
 block discarded – undo
260 260
 						), 40
261 261
 					),
262 262
 					$this->configService->displayInstance($member->getInstance()),
263
-					($level > 0) ? Member::$DEF_LEVEL[$level] :
264
-						'(' . strtolower($member->getStatus()) . ')',
263
+					($level > 0) ? Member::$DEF_LEVEL[$level] : '('.strtolower($member->getStatus()).')',
265 264
 					($member->hasInvitedBy()) ? $this->configService->displayFederatedUser(
266 265
 						$member->getInvitedBy(), $this->input->getOption('display-name')
267 266
 					) : 'Unknown'
@@ -423,19 +422,19 @@  discard block
 block discarded – undo
423 422
 				$member = $data->gObj('member', Member::class);
424 423
 
425 424
 				if ($lineNumber === 1) {
426
-					$line .= '<info>' . $member->getSingleId() . '</info>';
425
+					$line .= '<info>'.$member->getSingleId().'</info>';
427 426
 					if (!$this->configService->isLocalInstance($member->getInstance())) {
428
-						$line .= '@' . $member->getInstance();
427
+						$line .= '@'.$member->getInstance();
429 428
 					}
430
-					$line .= ' (' . Member::$DEF_LEVEL[$member->getLevel()] . ')';
429
+					$line .= ' ('.Member::$DEF_LEVEL[$member->getLevel()].')';
431 430
 
432
-					$line .= ' <info>MemberId</info>: ' . $member->getId();
433
-					$line .= ' <info>Name</info>: ' . $this->configService->displayFederatedUser(
431
+					$line .= ' <info>MemberId</info>: '.$member->getId();
432
+					$line .= ' <info>Name</info>: '.$this->configService->displayFederatedUser(
434 433
 							$member,
435 434
 							$this->input->getOption('display-name')
436 435
 						);
437 436
 					$source = ($member->hasBasedOn()) ? $member->getBasedOn()->getSource() : '';
438
-					$line .= ' <info>Source</info>: ' . Circle::$DEF_SOURCE[$source];
437
+					$line .= ' <info>Source</info>: '.Circle::$DEF_SOURCE[$source];
439 438
 				}
440 439
 
441 440
 				if ($lineNumber === 2) {
@@ -447,16 +446,16 @@  discard block
 block discarded – undo
447 446
 						return $line;
448 447
 					}
449 448
 					$owner = $circle->getOwner();
450
-					$line .= '<info>Owner</info>: ' . $owner->getUserId() . '@' . $owner->getInstance();
449
+					$line .= '<info>Owner</info>: '.$owner->getUserId().'@'.$owner->getInstance();
451 450
 					$type = implode(", ", Circle::getCircleFlags($circle, Circle::FLAGS_LONG));
452
-					$line .= ($type === '') ? '' : ' <info>Config</info>: ' . $type;
451
+					$line .= ($type === '') ? '' : ' <info>Config</info>: '.$type;
453 452
 				}
454 453
 
455 454
 			} else {
456 455
 				if ($lineNumber === 1 && !is_null($circle)) {
457
-					$line .= '<info>' . $circle->getSingleId() . '</info>';
456
+					$line .= '<info>'.$circle->getSingleId().'</info>';
458 457
 					if (!$this->configService->isLocalInstance($circle->getInstance())) {
459
-						$line .= '@' . $circle->getInstance();
458
+						$line .= '@'.$circle->getInstance();
460 459
 					}
461 460
 				}
462 461
 			}
Please login to merge, or discard this patch.
lib/Db/CoreQueryBuilder.php 1 patch
Spacing   +77 added lines, -77 removed lines patch added patch discarded remove patch
@@ -381,7 +381,7 @@  discard block
 block discarded – undo
381 381
 		}
382 382
 
383 383
 		if ($circle->getDisplayName() !== '') {
384
-			$this->searchInDBField('display_name', '%' . $circle->getDisplayName() . '%');
384
+			$this->searchInDBField('display_name', '%'.$circle->getDisplayName().'%');
385 385
 		}
386 386
 		if ($circle->getConfig() > 0) {
387 387
 			$this->limitBitwise('config', $circle->getConfig());
@@ -400,7 +400,7 @@  discard block
 block discarded – undo
400 400
 			$this->generateRemoteInstanceSelectAlias($aliasRemoteInstance)
401 401
 				 ->leftJoin(
402 402
 					 $alias, CoreRequestBuilder::TABLE_REMOTE, $aliasRemoteInstance,
403
-					 $expr->eq($alias . '.instance', $aliasRemoteInstance . '.instance')
403
+					 $expr->eq($alias.'.instance', $aliasRemoteInstance.'.instance')
404 404
 				 );
405 405
 		} catch (RequestBuilderException $e) {
406 406
 		}
@@ -453,7 +453,7 @@  discard block
 block discarded – undo
453 453
 		$expr = $this->expr();
454 454
 		$this->leftJoin(
455 455
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_REMOTE, $aliasRemote,
456
-			$expr->eq($aliasRemote . '.instance', $this->createNamedParameter($remoteInstance->getInstance()))
456
+			$expr->eq($aliasRemote.'.instance', $this->createNamedParameter($remoteInstance->getInstance()))
457 457
 		);
458 458
 	}
459 459
 
@@ -481,12 +481,12 @@  discard block
 block discarded – undo
481 481
 		$this->leftJoin(
482 482
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteMember,
483 483
 			$expr->andX(
484
-				$expr->eq($aliasRemoteMember . '.circle_id', $aliasCircle . '.unique_id'),
484
+				$expr->eq($aliasRemoteMember.'.circle_id', $aliasCircle.'.unique_id'),
485 485
 				$expr->eq(
486
-					$aliasRemoteMember . '.instance',
486
+					$aliasRemoteMember.'.instance',
487 487
 					$this->createNamedParameter($remoteInstance->getInstance())
488 488
 				),
489
-				$expr->gte($aliasRemoteMember . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
489
+				$expr->gte($aliasRemoteMember.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
490 490
 			)
491 491
 		);
492 492
 	}
@@ -518,21 +518,21 @@  discard block
 block discarded – undo
518 518
 		$this->leftJoin(
519 519
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteCircle,
520 520
 			$expr->andX(
521
-				$expr->eq($aliasRemoteCircle . '.single_id', $aliasCircle . '.unique_id'),
522
-				$expr->emptyString($aliasRemoteCircle . '.instance'),
523
-				$expr->gte($aliasRemoteCircle . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
521
+				$expr->eq($aliasRemoteCircle.'.single_id', $aliasCircle.'.unique_id'),
522
+				$expr->emptyString($aliasRemoteCircle.'.instance'),
523
+				$expr->gte($aliasRemoteCircle.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
524 524
 			)
525 525
 		);
526 526
 		$this->leftJoin(
527 527
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteCircleOwner,
528 528
 			$expr->andX(
529
-				$expr->eq($aliasRemoteCircle . '.circle_id', $aliasRemoteCircleOwner . '.circle_id'),
529
+				$expr->eq($aliasRemoteCircle.'.circle_id', $aliasRemoteCircleOwner.'.circle_id'),
530 530
 				$expr->eq(
531
-					$aliasRemoteCircleOwner . '.instance',
531
+					$aliasRemoteCircleOwner.'.instance',
532 532
 					$this->createNamedParameter($remoteInstance->getInstance())
533 533
 				),
534 534
 				$expr->eq(
535
-					$aliasRemoteCircleOwner . '.level', $this->createNamedParameter(Member::LEVEL_OWNER)
535
+					$aliasRemoteCircleOwner.'.level', $this->createNamedParameter(Member::LEVEL_OWNER)
536 536
 				)
537 537
 			)
538 538
 		);
@@ -565,16 +565,16 @@  discard block
 block discarded – undo
565 565
 		$expr = $this->expr();
566 566
 		$orX = $expr->orX();
567 567
 		$orX->add(
568
-			$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBALSCALE))
568
+			$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBALSCALE))
569 569
 		);
570 570
 
571 571
 		$orExtOrPassive = $expr->orX();
572 572
 		$orExtOrPassive->add(
573
-			$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))
573
+			$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))
574 574
 		);
575 575
 		if (!$sensitive) {
576 576
 			$orExtOrPassive->add(
577
-				$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
577
+				$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
578 578
 			);
579 579
 		} else {
580 580
 			if ($this->getDefaultSelectAlias() === CoreQueryBuilder::MEMBER) {
@@ -583,8 +583,8 @@  discard block
 block discarded – undo
583 583
 		}
584 584
 
585 585
 		$orInstance = $expr->orX();
586
-		$orInstance->add($expr->isNotNull($aliasRemoteMember . '.instance'));
587
-		$orInstance->add($expr->isNotNull($aliasRemoteCircleOwner . '.instance'));
586
+		$orInstance->add($expr->isNotNull($aliasRemoteMember.'.instance'));
587
+		$orInstance->add($expr->isNotNull($aliasRemoteCircleOwner.'.instance'));
588 588
 
589 589
 		$andExternal = $expr->andX();
590 590
 		$andExternal->add($orExtOrPassive);
@@ -593,13 +593,13 @@  discard block
 block discarded – undo
593 593
 		$orExtOrTrusted = $expr->orX();
594 594
 		$orExtOrTrusted->add($andExternal);
595 595
 		$orExtOrTrusted->add(
596
-			$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED))
596
+			$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED))
597 597
 		);
598 598
 
599 599
 		$andTrusted = $expr->andX();
600 600
 		$andTrusted->add($orExtOrTrusted);
601 601
 		$andTrusted->add($this->exprLimitBitwise('config', Circle::CFG_FEDERATED, $aliasCircle));
602
-		$andTrusted->add($expr->emptyString($aliasOwner . '.instance'));
602
+		$andTrusted->add($expr->emptyString($aliasOwner.'.instance'));
603 603
 		$orX->add($andTrusted);
604 604
 
605 605
 		$this->andWhere($orX);
@@ -626,7 +626,7 @@  discard block
 block discarded – undo
626 626
 		}
627 627
 		$this->leftJoin(
628 628
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
629
-			$expr->eq($aliasMember . '.circle_id', $alias . '.unique_id')
629
+			$expr->eq($aliasMember.'.circle_id', $alias.'.unique_id')
630 630
 		);
631 631
 
632 632
 		$this->filterDirectMembership($aliasMember, $member);
@@ -647,30 +647,30 @@  discard block
 block discarded – undo
647 647
 
648 648
 		if ($member->getUserId() !== '') {
649 649
 			$andX->add(
650
-				$expr->eq($aliasMember . '.user_id', $this->createNamedParameter($member->getUserId()))
650
+				$expr->eq($aliasMember.'.user_id', $this->createNamedParameter($member->getUserId()))
651 651
 			);
652 652
 		}
653 653
 
654 654
 		if ($member->getSingleId() !== '') {
655 655
 			$andX->add(
656
-				$expr->eq($aliasMember . '.single_id', $this->createNamedParameter($member->getSingleId()))
656
+				$expr->eq($aliasMember.'.single_id', $this->createNamedParameter($member->getSingleId()))
657 657
 			);
658 658
 		}
659 659
 
660 660
 		if ($member->getUserType() > 0) {
661 661
 			$andX->add(
662
-				$expr->eq($aliasMember . '.user_type', $this->createNamedParameter($member->getUserType()))
662
+				$expr->eq($aliasMember.'.user_type', $this->createNamedParameter($member->getUserType()))
663 663
 			);
664 664
 		}
665 665
 
666 666
 		$andX->add(
667
-			$expr->eq($aliasMember . '.instance', $this->createNamedParameter($this->getInstance($member)))
667
+			$expr->eq($aliasMember.'.instance', $this->createNamedParameter($this->getInstance($member)))
668 668
 		);
669 669
 
670 670
 		if ($member->getLevel() > 0) {
671 671
 			$andX->add(
672 672
 				$expr->gte(
673
-					$aliasMember . '.level',
673
+					$aliasMember.'.level',
674 674
 					$this->createNamedParameter($member->getLevel(), IQueryBuilder::PARAM_INT)
675 675
 				)
676 676
 			);
@@ -701,12 +701,12 @@  discard block
 block discarded – undo
701 701
 
702 702
 		$expr = $this->expr();
703 703
 		$this->selectAlias(
704
-			$this->createFunction('COUNT(`' . $aliasMemberCount . '`.`member_id`)'),
705
-			(($alias !== $this->getDefaultSelectAlias()) ? $alias . '_' : '') . 'population'
704
+			$this->createFunction('COUNT(`'.$aliasMemberCount.'`.`member_id`)'),
705
+			(($alias !== $this->getDefaultSelectAlias()) ? $alias.'_' : '').'population'
706 706
 		);
707 707
 		$this->leftJoin(
708 708
 			$alias, CoreRequestBuilder::TABLE_MEMBER, $aliasMemberCount,
709
-			$expr->eq($alias . '.unique_id', $aliasMemberCount . '.circle_id')
709
+			$expr->eq($alias.'.unique_id', $aliasMemberCount.'.circle_id')
710 710
 		);
711 711
 	}
712 712
 
@@ -742,7 +742,7 @@  discard block
 block discarded – undo
742 742
 			$helperAlias,
743 743
 			CoreRequestBuilder::TABLE_CIRCLE,
744 744
 			$aliasCircle,
745
-			$expr->eq($aliasCircle . '.unique_id', $helperAlias . '.' . $field)
745
+			$expr->eq($aliasCircle.'.unique_id', $helperAlias.'.'.$field)
746 746
 		);
747 747
 
748 748
 		if (!is_null($initiator)) {
@@ -773,7 +773,7 @@  discard block
 block discarded – undo
773 773
 		$this->generateCircleSelectAlias($aliasInvitedBy)
774 774
 			 ->leftJoin(
775 775
 				 $aliasMember, CoreRequestBuilder::TABLE_CIRCLE, $aliasInvitedBy,
776
-				 $expr->eq($aliasMember . '.invited_by', $aliasInvitedBy . '.unique_id')
776
+				 $expr->eq($aliasMember.'.invited_by', $aliasInvitedBy.'.unique_id')
777 777
 			 );
778 778
 
779 779
 		$this->leftJoinOwner($aliasInvitedBy);
@@ -804,7 +804,7 @@  discard block
 block discarded – undo
804 804
 		$this->generateCircleSelectAlias($aliasBasedOn)
805 805
 			 ->leftJoin(
806 806
 				 $aliasMember, CoreRequestBuilder::TABLE_CIRCLE, $aliasBasedOn,
807
-				 $expr->eq($aliasBasedOn . '.unique_id', $aliasMember . '.single_id')
807
+				 $expr->eq($aliasBasedOn.'.unique_id', $aliasMember.'.single_id')
808 808
 			 );
809 809
 
810 810
 		if (!is_null($initiator)) {
@@ -837,9 +837,9 @@  discard block
 block discarded – undo
837 837
 			 ->leftJoin(
838 838
 				 $alias, CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
839 839
 				 $expr->andX(
840
-					 $expr->eq($aliasMember . '.circle_id', $alias . '.' . $field),
840
+					 $expr->eq($aliasMember.'.circle_id', $alias.'.'.$field),
841 841
 					 $expr->eq(
842
-						 $aliasMember . '.level',
842
+						 $aliasMember.'.level',
843 843
 						 $this->createNamedParameter(Member::LEVEL_OWNER, self::PARAM_INT)
844 844
 					 )
845 845
 				 )
@@ -877,10 +877,10 @@  discard block
 block discarded – undo
877 877
 			 ->leftJoin(
878 878
 				 $alias, CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
879 879
 				 $expr->andX(
880
-					 $expr->eq($aliasMember . '.circle_id', $alias . '.' . $fieldCircleId),
881
-					 $expr->eq($aliasMember . '.single_id', $alias . '.' . $fieldSingleId),
880
+					 $expr->eq($aliasMember.'.circle_id', $alias.'.'.$fieldCircleId),
881
+					 $expr->eq($aliasMember.'.single_id', $alias.'.'.$fieldSingleId),
882 882
 					 $expr->gte(
883
-						 $aliasMember . '.level',
883
+						 $aliasMember.'.level',
884 884
 						 $this->createNamedParameter(Member::LEVEL_MEMBER, self::PARAM_INT)
885 885
 					 )
886 886
 				 )
@@ -913,7 +913,7 @@  discard block
 block discarded – undo
913 913
 
914 914
 		$this->leftJoin(
915 915
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasMembership,
916
-			$expr->eq($aliasMembership . '.circle_id', $alias . '.' . $field)
916
+			$expr->eq($aliasMembership.'.circle_id', $alias.'.'.$field)
917 917
 		);
918 918
 
919 919
 //		if (!$this->getBool('getData', $options, false)) {
@@ -927,8 +927,8 @@  discard block
 block discarded – undo
927 927
 			 ->leftJoin(
928 928
 				 $alias, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritedBy,
929 929
 				 $expr->andX(
930
-					 $expr->eq($aliasMembership . '.inheritance_last', $aliasInheritedBy . '.circle_id'),
931
-					 $expr->eq($aliasMembership . '.single_id', $aliasInheritedBy . '.single_id')
930
+					 $expr->eq($aliasMembership.'.inheritance_last', $aliasInheritedBy.'.circle_id'),
931
+					 $expr->eq($aliasMembership.'.single_id', $aliasInheritedBy.'.single_id')
932 932
 				 )
933 933
 			 );
934 934
 
@@ -945,12 +945,12 @@  discard block
 block discarded – undo
945 945
 		$aliasUpstreamMembership = $this->generateAlias($alias, self::UPSTREAM_MEMBERSHIPS, $options);
946 946
 		$this->leftJoin(
947 947
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasUpstreamMembership,
948
-			$expr->eq($aliasUpstreamMembership . '.single_id', $this->createNamedParameter($singleId))
948
+			$expr->eq($aliasUpstreamMembership.'.single_id', $this->createNamedParameter($singleId))
949 949
 		);
950 950
 
951 951
 		$orX = $expr->orX(
952
-			$expr->eq($aliasUpstreamMembership . '.circle_id', $alias . '.' . $field),
953
-			$expr->eq($alias . '.' . $field, $this->createNamedParameter($singleId))
952
+			$expr->eq($aliasUpstreamMembership.'.circle_id', $alias.'.'.$field),
953
+			$expr->eq($alias.'.'.$field, $this->createNamedParameter($singleId))
954 954
 		);
955 955
 
956 956
 		$this->andWhere($orX);
@@ -971,11 +971,11 @@  discard block
 block discarded – undo
971 971
 
972 972
 		$expr = $this->expr();
973 973
 		$aliasMembership = $this->generateAlias($alias, self::MEMBERSHIPS);
974
-		$this->andWhere($expr->eq($aliasMembership . '.circle_id', $this->createNamedParameter($singleId)));
974
+		$this->andWhere($expr->eq($aliasMembership.'.circle_id', $this->createNamedParameter($singleId)));
975 975
 		if ($level > 1) {
976 976
 			$this->andWhere(
977 977
 				$expr->gte(
978
-					$aliasMembership . '.level',
978
+					$aliasMembership.'.level',
979 979
 					$this->createNamedParameter($level, IQueryBuilder::PARAM_INT)
980 980
 				)
981 981
 			);
@@ -1003,8 +1003,8 @@  discard block
 block discarded – undo
1003 1003
 		$this->leftJoin(
1004 1004
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasMembership,
1005 1005
 			$expr->andX(
1006
-				$expr->eq($aliasMembership . '.inheritance_last', $alias . '.' . $field),
1007
-				$expr->eq($aliasMembership . '.single_id', $alias . '.single_id')
1006
+				$expr->eq($aliasMembership.'.inheritance_last', $alias.'.'.$field),
1007
+				$expr->eq($aliasMembership.'.single_id', $alias.'.single_id')
1008 1008
 			)
1009 1009
 		);
1010 1010
 
@@ -1017,8 +1017,8 @@  discard block
 block discarded – undo
1017 1017
 			 ->leftJoin(
1018 1018
 				 $aliasMembership, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritanceFrom,
1019 1019
 				 $expr->andX(
1020
-					 $expr->eq($aliasMembership . '.circle_id', $aliasInheritanceFrom . '.circle_id'),
1021
-					 $expr->eq($aliasMembership . '.inheritance_first', $aliasInheritanceFrom . '.single_id')
1020
+					 $expr->eq($aliasMembership.'.circle_id', $aliasInheritanceFrom.'.circle_id'),
1021
+					 $expr->eq($aliasMembership.'.inheritance_first', $aliasInheritanceFrom.'.single_id')
1022 1022
 				 )
1023 1023
 			 );
1024 1024
 	}
@@ -1084,7 +1084,7 @@  discard block
 block discarded – undo
1084 1084
 			$aliasMembership,
1085 1085
 			$expr->andX(
1086 1086
 				$this->exprLimit('single_id', $initiator->getSingleId(), $aliasMembership),
1087
-				$expr->eq($aliasMembership . '.circle_id', $helperAlias . '.' . $field)
1087
+				$expr->eq($aliasMembership.'.circle_id', $helperAlias.'.'.$field)
1088 1088
 			)
1089 1089
 		);
1090 1090
 
@@ -1102,7 +1102,7 @@  discard block
 block discarded – undo
1102 1102
 					$aliasDirectInitiator,
1103 1103
 					$expr->andX(
1104 1104
 						$this->exprLimit('single_id', $initiator->getSingleId(), $aliasDirectInitiator),
1105
-						$expr->eq($aliasDirectInitiator . '.circle_id', $helperAlias . '.' . $field)
1105
+						$expr->eq($aliasDirectInitiator.'.circle_id', $helperAlias.'.'.$field)
1106 1106
 					)
1107 1107
 				);
1108 1108
 			} catch (RequestBuilderException $e) {
@@ -1115,8 +1115,8 @@  discard block
 block discarded – undo
1115 1115
 			$this->leftJoin(
1116 1116
 				$aliasMembership, CoreRequestBuilder::TABLE_MEMBER, $aliasInitiator,
1117 1117
 				$expr->andX(
1118
-					$expr->eq($aliasMembership . '.inheritance_first', $aliasInitiator . '.single_id'),
1119
-					$expr->eq($aliasMembership . '.circle_id', $aliasInitiator . '.circle_id')
1118
+					$expr->eq($aliasMembership.'.inheritance_first', $aliasInitiator.'.single_id'),
1119
+					$expr->eq($aliasMembership.'.circle_id', $aliasInitiator.'.circle_id')
1120 1120
 				)
1121 1121
 			);
1122 1122
 
@@ -1124,8 +1124,8 @@  discard block
 block discarded – undo
1124 1124
 			$this->leftJoin(
1125 1125
 				$aliasInitiator, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritedBy,
1126 1126
 				$expr->andX(
1127
-					$expr->eq($aliasMembership . '.single_id', $aliasInheritedBy . '.single_id'),
1128
-					$expr->eq($aliasMembership . '.inheritance_last', $aliasInheritedBy . '.circle_id')
1127
+					$expr->eq($aliasMembership.'.single_id', $aliasInheritedBy.'.single_id'),
1128
+					$expr->eq($aliasMembership.'.inheritance_last', $aliasInheritedBy.'.circle_id')
1129 1129
 				)
1130 1130
 			);
1131 1131
 
@@ -1145,7 +1145,7 @@  discard block
 block discarded – undo
1145 1145
 			$aliasInheritedByMembership = $this->generateAlias($aliasInheritedBy, self::MEMBERSHIPS);
1146 1146
 			$this->generateMembershipSelectAlias($aliasMembership, $aliasInheritedByMembership);
1147 1147
 		} catch (RequestBuilderException $e) {
1148
-			\OC::$server->getLogger()->log(3, '-- ' . $e->getMessage());
1148
+			\OC::$server->getLogger()->log(3, '-- '.$e->getMessage());
1149 1149
 		}
1150 1150
 	}
1151 1151
 
@@ -1175,7 +1175,7 @@  discard block
 block discarded – undo
1175 1175
 		$orX = $expr->orX();
1176 1176
 		$orX->add(
1177 1177
 			$expr->andX(
1178
-				$expr->gte($aliasMembership . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
1178
+				$expr->gte($aliasMembership.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
1179 1179
 			)
1180 1180
 		);
1181 1181
 
@@ -1193,7 +1193,7 @@  discard block
 block discarded – undo
1193 1193
 		}
1194 1194
 		if ($this->getBool('canBeVisitor', $options, false)) {
1195 1195
 			// TODO: should find a better way, also filter on remote initiator on non-federated ?
1196
-			$orX->add($expr->gte($alias . '.config', $this->createNamedParameter(0)));
1196
+			$orX->add($expr->gte($alias.'.config', $this->createNamedParameter(0)));
1197 1197
 		}
1198 1198
 		if ($this->getBool('canBeVisitorOnOpen', $options, false)) {
1199 1199
 			$andOpen = $expr->andX();
@@ -1261,21 +1261,21 @@  discard block
 block discarded – undo
1261 1261
 		$expr = $this->expr();
1262 1262
 		$andPassive = $expr->andX();
1263 1263
 		$andPassive->add(
1264
-			$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
1264
+			$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
1265 1265
 		);
1266 1266
 
1267 1267
 		$orMemberOrLevel = $expr->orX();
1268 1268
 		$orMemberOrLevel->add(
1269
-			$expr->eq($this->getDefaultSelectAlias() . '.instance', $alias . '.instance')
1269
+			$expr->eq($this->getDefaultSelectAlias().'.instance', $alias.'.instance')
1270 1270
 		);
1271 1271
 		// TODO: do we need this ? (display members from the local instance)
1272 1272
 		$orMemberOrLevel->add(
1273
-			$expr->emptyString($this->getDefaultSelectAlias() . '.instance')
1273
+			$expr->emptyString($this->getDefaultSelectAlias().'.instance')
1274 1274
 		);
1275 1275
 
1276 1276
 		$orMemberOrLevel->add(
1277 1277
 			$expr->eq(
1278
-				$this->getDefaultSelectAlias() . '.level',
1278
+				$this->getDefaultSelectAlias().'.level',
1279 1279
 				$this->createNamedParameter(Member::LEVEL_OWNER)
1280 1280
 			)
1281 1281
 		);
@@ -1312,11 +1312,11 @@  discard block
 block discarded – undo
1312 1312
 			 )
1313 1313
 			 ->leftJoin(
1314 1314
 				 $aliasShare, CoreRequestBuilder::TABLE_FILE_CACHE, $aliasFileCache,
1315
-				 $expr->eq($aliasShare . '.file_source', $aliasFileCache . '.fileid')
1315
+				 $expr->eq($aliasShare.'.file_source', $aliasFileCache.'.fileid')
1316 1316
 			 )
1317 1317
 			 ->leftJoin(
1318 1318
 				 $aliasFileCache, CoreRequestBuilder::TABLE_STORAGES, $aliasStorages,
1319
-				 $expr->eq($aliasFileCache . '.storage', $aliasStorages . '.numeric_id')
1319
+				 $expr->eq($aliasFileCache.'.storage', $aliasStorages.'.numeric_id')
1320 1320
 			 );
1321 1321
 	}
1322 1322
 
@@ -1338,8 +1338,8 @@  discard block
 block discarded – undo
1338 1338
 		$this->leftJoin(
1339 1339
 			$aliasShareMemberships, CoreRequestBuilder::TABLE_SHARE, $aliasShareChild,
1340 1340
 			$expr->andX(
1341
-				$expr->eq($aliasShareChild . '.parent', $aliasShare . '.id'),
1342
-				$expr->eq($aliasShareChild . '.share_with', $aliasShareMemberships . '.single_id')
1341
+				$expr->eq($aliasShareChild.'.parent', $aliasShare.'.id'),
1342
+				$expr->eq($aliasShareChild.'.share_with', $aliasShareMemberships.'.single_id')
1343 1343
 			)
1344 1344
 		);
1345 1345
 
@@ -1389,13 +1389,13 @@  discard block
 block discarded – undo
1389 1389
 		$this->leftJoin(
1390 1390
 			$aliasMountMemberships, CoreRequestBuilder::TABLE_MOUNTPOINT, $aliasMountpoint,
1391 1391
 			$expr->andX(
1392
-				$expr->eq($aliasMountpoint . '.mount_id', $aliasMount . '.mount_id'),
1393
-				$expr->eq($aliasMountpoint . '.single_id', $aliasMountMemberships . '.single_id')
1392
+				$expr->eq($aliasMountpoint.'.mount_id', $aliasMount.'.mount_id'),
1393
+				$expr->eq($aliasMountpoint.'.single_id', $aliasMountMemberships.'.single_id')
1394 1394
 			)
1395 1395
 		);
1396 1396
 
1397
-		$this->selectAlias($aliasMountpoint . '.mountpoint', $aliasMountpoint . '_mountpoint');
1398
-		$this->selectAlias($aliasMountpoint . '.mountpoint_hash', $aliasMountpoint . '_mountpoint_hash');
1397
+		$this->selectAlias($aliasMountpoint.'.mountpoint', $aliasMountpoint.'_mountpoint');
1398
+		$this->selectAlias($aliasMountpoint.'.mountpoint_hash', $aliasMountpoint.'_mountpoint_hash');
1399 1399
 	}
1400 1400
 
1401 1401
 
@@ -1499,10 +1499,10 @@  discard block
 block discarded – undo
1499 1499
 	 */
1500 1500
 	public function generateAlias(string $base, string $extension, ?array &$options = []): string {
1501 1501
 		$search = str_replace('_', '.', $base);
1502
-		$path = $search . '.' . $extension;
1502
+		$path = $search.'.'.$extension;
1503 1503
 		if (!$this->validKey($path, self::$SQL_PATH)
1504 1504
 			&& !in_array($extension, $this->getArray($search, self::$SQL_PATH))) {
1505
-			throw new RequestBuilderException($extension . ' not found in ' . $search);
1505
+			throw new RequestBuilderException($extension.' not found in '.$search);
1506 1506
 		}
1507 1507
 
1508 1508
 		if (!is_array($options)) {
@@ -1511,15 +1511,15 @@  discard block
 block discarded – undo
1511 1511
 
1512 1512
 		$optionPath = '';
1513 1513
 		foreach (explode('.', $path) as $p) {
1514
-			$optionPath = trim($optionPath . '.' . $p, '.');
1514
+			$optionPath = trim($optionPath.'.'.$p, '.');
1515 1515
 			$options = array_merge(
1516 1516
 				$options,
1517
-				$this->getArray($optionPath . '.' . self::OPTIONS, self::$SQL_PATH),
1518
-				$this->getArray($optionPath . '.' . self::OPTIONS, $this->options)
1517
+				$this->getArray($optionPath.'.'.self::OPTIONS, self::$SQL_PATH),
1518
+				$this->getArray($optionPath.'.'.self::OPTIONS, $this->options)
1519 1519
 			);
1520 1520
 		}
1521 1521
 
1522
-		return $base . '_' . $extension;
1522
+		return $base.'_'.$extension;
1523 1523
 	}
1524 1524
 
1525 1525
 
@@ -1539,7 +1539,7 @@  discard block
 block discarded – undo
1539 1539
 			} else {
1540 1540
 				$k = $arr;
1541 1541
 			}
1542
-			$path[$k] = $prefix . '_' . $k . '_';
1542
+			$path[$k] = $prefix.'_'.$k.'_';
1543 1543
 		}
1544 1544
 
1545 1545
 		return $path;
@@ -1556,7 +1556,7 @@  discard block
 block discarded – undo
1556 1556
 		$expr = $this->expr();
1557 1557
 		$orX = $expr->orX();
1558 1558
 		foreach ($aliases as $alias) {
1559
-			$orX->add($expr->gte($alias . '.level', $this->createNamedParameter($level)));
1559
+			$orX->add($expr->gte($alias.'.level', $this->createNamedParameter($level)));
1560 1560
 		}
1561 1561
 
1562 1562
 		return $orX;
Please login to merge, or discard this patch.