nextcloud / circles

lib/Migration/ImportOwncloudCustomGroups.php

Spacing +1 added lines, -1 removed lines

@@ -148,7 +148,7 @@
 				continue;
 			}
 
-			$level = (int) $row['role'] === 1 ? Member::LEVEL_OWNER : Member::LEVEL_MEMBER;
+			$level = (int)$row['role'] === 1 ? Member::LEVEL_OWNER : Member::LEVEL_MEMBER;
 
 			if ($level === Member::LEVEL_OWNER) {
 				if (isset($this->circleHasAdmin[$this->circlesById[$row['group_id']]])) {

lib/Migration/GenerateUniqueIdOnCreatedCircle.php

Spacing +1 added lines, -1 removed lines

@@ -93,7 +93,7 @@
 
 			$update = $this->connection->getQueryBuilder();
 			$update->update('circles_circles')
-				   ->set('unique_id', $update->createNamedParameter('d' . $uniqueId))
+				   ->set('unique_id', $update->createNamedParameter('d'.$uniqueId))
 				   ->where(
 					   $update->expr()
 							  ->eq('id', $update->createNamedParameter($itemId))

lib/Service/EventsService.php

Doc Comments +1 added lines, -1 removed lines

@@ -282,7 +282,7 @@
 	 * generateEvent()
 	 * Create an Activity Event with the basic settings for the app.
 	 *
-	 * @param $type
+	 * @param string $type
 	 *
 	 * @return \OCP\Activity\IEvent
 	 */

Spacing +22 added lines, -22 removed lines

@@ -116,7 +116,7 @@ 
 			}
 		);
 
-		$this->dispatch('\OCA\Circles::onCircleCreation',  ['circle' => $circle]);
+		$this->dispatch('\OCA\Circles::onCircleCreation', ['circle' => $circle]);
 	}
 
 
@@ -142,7 +142,7 @@ 
 				$circle->getUniqueId(), Member::LEVEL_MEMBER, true
 			)
 		);
-		$this->dispatch('\OCA\Circles::onCircleDestruction',  ['circle' => $circle]);
+		$this->dispatch('\OCA\Circles::onCircleDestruction', ['circle' => $circle]);
 	}
 
 
@@ -186,7 +186,7 @@ 
 					  )
 				  )
 		);
-		$this->dispatch('\OCA\Circles::onMemberNew',  ['circle' => $circle, 'member' => $member]);
+		$this->dispatch('\OCA\Circles::onMemberNew', ['circle' => $circle, 'member' => $member]);
 	}
 
 
@@ -242,7 +242,7 @@ 
 					  )
 				  )
 		);
-		$this->dispatch('\OCA\Circles::onMemberInvited',  ['circle' => $circle, 'member' => $member]);
+		$this->dispatch('\OCA\Circles::onMemberInvited', ['circle' => $circle, 'member' => $member]);
 	}
 
 
@@ -274,7 +274,7 @@ 
 					  )
 				  )
 		);
-		$this->dispatch('\OCA\Circles::onMemberRequesting',  ['circle' => $circle, 'member' => $member]);
+		$this->dispatch('\OCA\Circles::onMemberRequesting', ['circle' => $circle, 'member' => $member]);
 	}
 
 
@@ -307,7 +307,7 @@ 
 					  )
 				  )
 		);
-		$this->dispatch('\OCA\Circles::onMemberLeaving',  ['circle' => $circle, 'member' => $member]);
+		$this->dispatch('\OCA\Circles::onMemberLeaving', ['circle' => $circle, 'member' => $member]);
 	}
 
 
@@ -340,7 +340,7 @@ 
 		$this->membersRequest->avoidDuplicateMembers($mods, [$member]);
 
 		$this->publishEvent($event, $mods);
-		$this->dispatch('\OCA\Circles::onMemberLevel',  ['circle' => $circle, 'member' => $member]);
+		$this->dispatch('\OCA\Circles::onMemberLevel', ['circle' => $circle, 'member' => $member]);
 	}
 
 
@@ -365,7 +365,7 @@ 
 				$circle->getUniqueId(), Member::LEVEL_MEMBER, true
 			)
 		);
-		$this->dispatch('\OCA\Circles::onMemberOwner',  ['circle' => $circle, 'member' => $member]);
+		$this->dispatch('\OCA\Circles::onMemberOwner', ['circle' => $circle, 'member' => $member]);
 	}
 
 
@@ -398,7 +398,7 @@ 
 		);
 
 		$this->publishEvent($event, $mods);
-		$this->dispatch('\OCA\Circles::onGroupLink',  ['circle' => $circle, 'group' => $group]);
+		$this->dispatch('\OCA\Circles::onGroupLink', ['circle' => $circle, 'group' => $group]);
 	}
 
 
@@ -431,7 +431,7 @@ 
 		);
 
 		$this->publishEvent($event, $mods);
-		$this->dispatch('\OCA\Circles::onGroupUnlink',  ['circle' => $circle, 'group' => $group]);
+		$this->dispatch('\OCA\Circles::onGroupUnlink', ['circle' => $circle, 'group' => $group]);
 	}
 
 
@@ -464,7 +464,7 @@ 
 		);
 
 		$this->publishEvent($event, $mods);
-		$this->dispatch('\OCA\Circles::onGroupLevel',  ['circle' => $circle, 'group' => $group]);
+		$this->dispatch('\OCA\Circles::onGroupLevel', ['circle' => $circle, 'group' => $group]);
 	}
 
 
@@ -489,7 +489,7 @@ 
 			$link->getCircleId(), Member::LEVEL_MODERATOR, true
 		)
 		);
-		$this->dispatch('\OCA\Circles::onLinkRequestSent',  ['circle' => $circle, 'link' => $link]);
+		$this->dispatch('\OCA\Circles::onLinkRequestSent', ['circle' => $circle, 'link' => $link]);
 	}
 
 
@@ -514,7 +514,7 @@ 
 			$link->getCircleId(), Member::LEVEL_MODERATOR, true
 		)
 		);
-		$this->dispatch('\OCA\Circles::onLinkRequestReceived',  ['circle' => $circle, 'link' => $link]);
+		$this->dispatch('\OCA\Circles::onLinkRequestReceived', ['circle' => $circle, 'link' => $link]);
 	}
 
 
@@ -539,7 +539,7 @@ 
 			$link->getCircleId(), Member::LEVEL_MODERATOR, true
 		)
 		);
-		$this->dispatch('\OCA\Circles::onLinkRequestRejected',  ['circle' => $circle, 'link' => $link]);
+		$this->dispatch('\OCA\Circles::onLinkRequestRejected', ['circle' => $circle, 'link' => $link]);
 	}
 
 
@@ -564,7 +564,7 @@ 
 			$link->getCircleId(), Member::LEVEL_MODERATOR, true
 		)
 		);
-		$this->dispatch('\OCA\Circles::onLinkRequestCanceled',  ['circle' => $circle, 'link' => $link]);
+		$this->dispatch('\OCA\Circles::onLinkRequestCanceled', ['circle' => $circle, 'link' => $link]);
 	}
 
 
@@ -589,7 +589,7 @@ 
 			$link->getCircleId(), Member::LEVEL_MODERATOR, true
 		)
 		);
-		$this->dispatch('\OCA\Circles::onLinkRequestAccepted',  ['circle' => $circle, 'link' => $link]);
+		$this->dispatch('\OCA\Circles::onLinkRequestAccepted', ['circle' => $circle, 'link' => $link]);
 	}
 
 
@@ -614,7 +614,7 @@ 
 			$link->getCircleId(), Member::LEVEL_MODERATOR, true
 		)
 		);
-		$this->dispatch('\OCA\Circles::onLinkRequestAccepting',  ['circle' => $circle, 'link' => $link]);
+		$this->dispatch('\OCA\Circles::onLinkRequestAccepting', ['circle' => $circle, 'link' => $link]);
 	}
 
 
@@ -639,7 +639,7 @@ 
 			$link->getCircleId(), Member::LEVEL_MODERATOR, true
 		)
 		);
-		$this->dispatch('\OCA\Circles::onLinkUp',  ['circle' => $circle, 'link' => $link]);
+		$this->dispatch('\OCA\Circles::onLinkUp', ['circle' => $circle, 'link' => $link]);
 	}
 
 
@@ -664,7 +664,7 @@ 
 			$link->getCircleId(), Member::LEVEL_MODERATOR, true
 		)
 		);
-		$this->dispatch('\OCA\Circles::onLinkDown',  ['circle' => $circle, 'link' => $link]);
+		$this->dispatch('\OCA\Circles::onLinkDown', ['circle' => $circle, 'link' => $link]);
 	}
 
 
@@ -701,7 +701,7 @@ 
 			$link->getCircleId(), Member::LEVEL_MODERATOR, true
 		)
 		);
-		$this->dispatch('\OCA\Circles::onLinkRemove',  ['circle' => $circle, 'link' => $link]);
+		$this->dispatch('\OCA\Circles::onLinkRemove', ['circle' => $circle, 'link' => $link]);
 	}
 
 	/**
@@ -712,7 +712,7 @@ 
 	 * @param Circle $circle
 	 */
 	public function onSettingsChange(Circle $circle) {
-		$this->dispatch('\OCA\Circles::onSettingsChange',  ['circle' => $circle]);
+		$this->dispatch('\OCA\Circles::onSettingsChange', ['circle' => $circle]);
 	}
 
 
@@ -763,7 +763,7 @@ 
 	 * @param array $arguments
 	 */
 	private function dispatch($context, $arguments) {
-		$this->eventDispatcher->dispatch($context, new GenericEvent(null,$arguments));
+		$this->eventDispatcher->dispatch($context, new GenericEvent(null, $arguments));
 	}
 
 }
\ No newline at end of file

lib/Db/CirclesRequest.php

Spacing +1 added lines, -1 removed lines

@@ -185,7 +185,7 @@
 	 *
 	 * @throws CircleAlreadyExistsException
 	 */
-	public function createCircle(Circle &$circle, $userId) {
+	public function createCircle(Circle & $circle, $userId) {
 
 		if (!$this->isCircleUnique($circle, $userId)) {
 			throw new CircleAlreadyExistsException(

lib/Service/GroupsService.php

Spacing +1 added lines, -1 removed lines

@@ -190,7 +190,7 @@
 	 *
 	 * @throws \Exception
 	 */
-	private function editGroupLevel(Circle $circle, Member &$group, $level) {
+	private function editGroupLevel(Circle $circle, Member & $group, $level) {
 		try {
 			$isMod = $circle->getHigherViewer();
 			$isMod->hasToBeAdmin();

Doc Comments +6 added lines, -6 removed lines

@@ -86,7 +86,7 @@ 
 	 * @param string $circleUniqueId
 	 * @param string $groupId
 	 *
-	 * @return array
+	 * @return Member[]
 	 * @throws \Exception
 	 */
 	public function linkGroup($circleUniqueId, $groupId) {
@@ -112,8 +112,8 @@ 
 	/**
 	 * Check if a fresh member can be generated (by linkGroup)
 	 *
-	 * @param $circleId
-	 * @param $groupId
+	 * @param string $circleId
+	 * @param string $groupId
 	 *
 	 * @return null|Member
 	 * @throws MemberAlreadyExistsException
@@ -148,7 +148,7 @@ 
 	 * @param string $groupId
 	 * @param int $level
 	 *
-	 * @return array
+	 * @return Member[]
 	 * @throws \Exception
 	 */
 	public function levelGroup($circleUniqueId, $groupId, $level) {
@@ -186,7 +186,7 @@ 
 	/**
 	 * @param Circle $circle
 	 * @param Member $group
-	 * @param $level
+	 * @param integer $level
 	 *
 	 * @throws \Exception
 	 */
@@ -213,7 +213,7 @@ 
 	 * @param string $circleUniqueId
 	 * @param string $groupId
 	 *
-	 * @return array
+	 * @return Member[]
 	 * @throws \Exception
 	 */
 	public function unlinkGroup($circleUniqueId, $groupId) {

lib/Db/CircleProviderRequestBuilder.php

Doc Comments +1 added lines, -1 removed lines

@@ -107,7 +107,7 @@
 	 * limit the request to the children of a share
 	 *
 	 * @param IQueryBuilder $qb
-	 * @param $userId
+	 * @param string $userId
 	 * @param int $parentId
 	 */
 	protected function limitToShareChildren(IQueryBuilder &$qb, $userId, $parentId = -1) {

Indentation +1 added lines, -1 removed lines

@@ -252,7 +252,7 @@
 			'c', CoreRequestBuilder::TABLE_MEMBERS, 'mo', $expr->andX(
 			$expr->eq(
 				'mo.circle_id',
-        $qb->createFunction('SUBSTR(`c`.`unique_id`, 1, ' . Circle::SHORT_UNIQUE_ID_LENGTH . ')')
+		$qb->createFunction('SUBSTR(`c`.`unique_id`, 1, ' . Circle::SHORT_UNIQUE_ID_LENGTH . ')')
 			), $expr->eq('mo.user_type', $qb->createNamedParameter(Member::TYPE_USER)),
 			$expr->eq('mo.level', $qb->createNamedParameter(Member::LEVEL_OWNER))
 		)

Spacing +29 added lines, -29 removed lines

@@ -66,7 +66,7 @@ 
 	 * @param IQueryBuilder $qb
 	 * @param array $circleUniqueIds
 	 */
-	protected function limitToCircles(IQueryBuilder &$qb, $circleUniqueIds) {
+	protected function limitToCircles(IQueryBuilder & $qb, $circleUniqueIds) {
 
 		if (!is_array($circleUniqueIds)) {
 			$circleUniqueIds = array($circleUniqueIds);
@@ -76,7 +76,7 @@ 
 		$pf = ($qb->getType() === QueryBuilder::SELECT) ? 's.' : '';
 		$qb->andWhere(
 			$expr->in(
-				$pf . 'share_with',
+				$pf.'share_with',
 				$qb->createNamedParameter($circleUniqueIds, IQueryBuilder::PARAM_STR_ARRAY)
 			)
 		);
@@ -89,11 +89,11 @@ 
 	 * @param IQueryBuilder $qb
 	 * @param $shareId
 	 */
-	protected function limitToShare(IQueryBuilder &$qb, $shareId) {
+	protected function limitToShare(IQueryBuilder & $qb, $shareId) {
 		$expr = $qb->expr();
 		$pf = ($qb->getType() === QueryBuilder::SELECT) ? 's.' : '';
 
-		$qb->andWhere($expr->eq($pf . 'id', $qb->createNamedParameter($shareId)));
+		$qb->andWhere($expr->eq($pf.'id', $qb->createNamedParameter($shareId)));
 	}
 
 
@@ -102,7 +102,7 @@ 
 	 *
 	 * @param IQueryBuilder $qb
 	 */
-	protected function limitToShareParent(IQueryBuilder &$qb) {
+	protected function limitToShareParent(IQueryBuilder & $qb) {
 		$expr = $qb->expr();
 
 		$qb->andWhere($expr->isNull('parent'));
@@ -116,7 +116,7 @@ 
 	 * @param $userId
 	 * @param int $parentId
 	 */
-	protected function limitToShareChildren(IQueryBuilder &$qb, $userId, $parentId = -1) {
+	protected function limitToShareChildren(IQueryBuilder & $qb, $userId, $parentId = -1) {
 		$expr = $qb->expr();
 		$qb->andWhere($expr->eq('share_with', $qb->createNamedParameter($userId)));
 
@@ -135,15 +135,15 @@ 
 	 * @param IQueryBuilder $qb
 	 * @param $circleId
 	 */
-	protected function limitToShareAndChildren(IQueryBuilder &$qb, $circleId) {
+	protected function limitToShareAndChildren(IQueryBuilder & $qb, $circleId) {
 		$expr = $qb->expr();
 		$pf = ($qb->getType() === QueryBuilder::SELECT) ? 's.' : '';
 
 		/** @noinspection PhpMethodParametersCountMismatchInspection */
 		$qb->andWhere(
 			$expr->orX(
-				$expr->eq($pf . 'parent', $qb->createNamedParameter($circleId)),
-				$expr->eq($pf . 'id', $qb->createNamedParameter($circleId))
+				$expr->eq($pf.'parent', $qb->createNamedParameter($circleId)),
+				$expr->eq($pf.'id', $qb->createNamedParameter($circleId))
 			)
 		);
 	}
@@ -155,7 +155,7 @@ 
 	 * @param IQueryBuilder $qb
 	 * @param $files
 	 */
-	protected function limitToFiles(IQueryBuilder &$qb, $files) {
+	protected function limitToFiles(IQueryBuilder & $qb, $files) {
 
 		if (!is_array($files)) {
 			$files = array($files);
@@ -165,7 +165,7 @@ 
 		$pf = ($qb->getType() === QueryBuilder::SELECT) ? 's.' : '';
 		$qb->andWhere(
 			$expr->in(
-				$pf . 'file_source',
+				$pf.'file_source',
 				$qb->createNamedParameter($files, IQueryBuilder::PARAM_INT_ARRAY)
 			)
 		);
@@ -177,7 +177,7 @@ 
 	 * @param int $limit
 	 * @param int $offset
 	 */
-	protected function limitToPage(IQueryBuilder &$qb, $limit = -1, $offset = 0) {
+	protected function limitToPage(IQueryBuilder & $qb, $limit = -1, $offset = 0) {
 		if ($limit !== -1) {
 			$qb->setMaxResults($limit);
 		}
@@ -193,18 +193,18 @@ 
 	 * @param string $userId
 	 * @param bool $reShares
 	 */
-	protected function limitToShareOwner(IQueryBuilder &$qb, $userId, $reShares = false) {
+	protected function limitToShareOwner(IQueryBuilder & $qb, $userId, $reShares = false) {
 		$expr = $qb->expr();
 		$pf = ($qb->getType() === QueryBuilder::SELECT) ? 's.' : '';
 
 		if ($reShares === false) {
-			$qb->andWhere($expr->eq($pf . 'uid_initiator', $qb->createNamedParameter($userId)));
+			$qb->andWhere($expr->eq($pf.'uid_initiator', $qb->createNamedParameter($userId)));
 		} else {
 			/** @noinspection PhpMethodParametersCountMismatchInspection */
 			$qb->andWhere(
 				$expr->orX(
-					$expr->eq($pf . 'uid_owner', $qb->createNamedParameter($userId)),
-					$expr->eq($pf . 'uid_initiator', $qb->createNamedParameter($userId))
+					$expr->eq($pf.'uid_owner', $qb->createNamedParameter($userId)),
+					$expr->eq($pf.'uid_initiator', $qb->createNamedParameter($userId))
 				)
 			);
 		}
@@ -219,14 +219,14 @@ 
 	 * @param IQueryBuilder $qb
 	 * @param int $shareId
 	 */
-	protected function linkCircleField(IQueryBuilder &$qb, $shareId = -1) {
+	protected function linkCircleField(IQueryBuilder & $qb, $shareId = -1) {
 		$expr = $qb->expr();
 
 		$qb->from(CoreRequestBuilder::TABLE_CIRCLES, 'c');
 
 		$tmpOrX = $expr->eq(
 			's.share_with',
-			$qb->createFunction('SUBSTR(`c`.`unique_id`, 1, ' . Circle::SHORT_UNIQUE_ID_LENGTH . ')')
+			$qb->createFunction('SUBSTR(`c`.`unique_id`, 1, '.Circle::SHORT_UNIQUE_ID_LENGTH.')')
 		);
 
 		if ($shareId === -1) {
@@ -248,7 +248,7 @@ 
 	/**
 	 * @param IQueryBuilder $qb
 	 */
-	protected function linkToCircleOwner(IQueryBuilder &$qb) {
+	protected function linkToCircleOwner(IQueryBuilder & $qb) {
 		$expr = $qb->expr();
 
 		$qb->selectAlias('mo.user_id', 'circle_owner');
@@ -257,7 +257,7 @@ 
 			'c', CoreRequestBuilder::TABLE_MEMBERS, 'mo', $expr->andX(
 			$expr->eq(
 				'mo.circle_id',
-        $qb->createFunction('SUBSTR(`c`.`unique_id`, 1, ' . Circle::SHORT_UNIQUE_ID_LENGTH . ')')
+        $qb->createFunction('SUBSTR(`c`.`unique_id`, 1, '.Circle::SHORT_UNIQUE_ID_LENGTH.')')
 			), $expr->eq('mo.user_type', $qb->createNamedParameter(Member::TYPE_USER)),
 			$expr->eq('mo.level', $qb->createNamedParameter(Member::LEVEL_OWNER))
 		)
@@ -272,7 +272,7 @@ 
 	 * @param string $userId
 	 * @param bool $groupMemberAllowed
 	 */
-	protected function linkToMember(IQueryBuilder &$qb, $userId, $groupMemberAllowed) {
+	protected function linkToMember(IQueryBuilder & $qb, $userId, $groupMemberAllowed) {
 		$expr = $qb->expr();
 
 		$qb->from(CoreRequestBuilder::TABLE_MEMBERS, 'm');
@@ -296,7 +296,7 @@ 
 	 *
 	 * @return \OCP\DB\QueryBuilder\ICompositeExpression
 	 */
-	private function exprLinkToMemberAsCircleMember(IQueryBuilder &$qb, $userId) {
+	private function exprLinkToMemberAsCircleMember(IQueryBuilder & $qb, $userId) {
 
 		$expr = $qb->expr();
 		$andX = $expr->andX();
@@ -307,7 +307,7 @@ 
 			$expr->eq(
 				'm.circle_id',
 				$qb->createFunction(
-					'SUBSTR(`c`.`unique_id`, 1, ' . Circle::SHORT_UNIQUE_ID_LENGTH . ')'
+					'SUBSTR(`c`.`unique_id`, 1, '.Circle::SHORT_UNIQUE_ID_LENGTH.')'
 				)
 			)
 		);
@@ -325,7 +325,7 @@ 
 	 *
 	 * @return \OCP\DB\QueryBuilder\ICompositeExpression
 	 */
-	private function exprLinkToMemberAsGroupMember(IQueryBuilder &$qb, $userId) {
+	private function exprLinkToMemberAsGroupMember(IQueryBuilder & $qb, $userId) {
 		$expr = $qb->expr();
 
 		/** @noinspection PhpMethodParametersCountMismatchInspection */
@@ -334,7 +334,7 @@ 
 			$expr->andX(
 				$expr->eq(
 					'g.circle_id',
-					$qb->createFunction('SUBSTR(`c`.`unique_id`, 1, ' . Circle::SHORT_UNIQUE_ID_LENGTH . ')')
+					$qb->createFunction('SUBSTR(`c`.`unique_id`, 1, '.Circle::SHORT_UNIQUE_ID_LENGTH.')')
 				),
 				$expr->gte('g.level', $qb->createNamedParameter(Member::LEVEL_MEMBER))
 			)
@@ -354,7 +354,7 @@ 
 	 *
 	 * @param IQueryBuilder $qb
 	 */
-	protected function leftJoinShareInitiator(IQueryBuilder &$qb) {
+	protected function leftJoinShareInitiator(IQueryBuilder & $qb) {
 		$expr = $qb->expr();
 
 		$qb->selectAlias('src_m.level', 'initiator_circle_level');
@@ -390,7 +390,7 @@ 
 	 *
 	 * @param IQueryBuilder $qb
 	 */
-	protected function joinCircleMembers(IQueryBuilder &$qb) {
+	protected function joinCircleMembers(IQueryBuilder & $qb) {
 		$expr = $qb->expr();
 
 		/** @noinspection PhpMethodParametersCountMismatchInspection */
@@ -411,7 +411,7 @@ 
 	 * @param IQueryBuilder $qb
 	 * @param string $userId
 	 */
-	protected function linkToFileCache(IQueryBuilder &$qb, $userId) {
+	protected function linkToFileCache(IQueryBuilder & $qb, $userId) {
 		$expr = $qb->expr();
 
 		/** @noinspection PhpMethodParametersCountMismatchInspection */
@@ -527,7 +527,7 @@ 
 	/**
 	 * @param IQueryBuilder $qb
 	 */
-	private function joinShare(IQueryBuilder &$qb) {
+	private function joinShare(IQueryBuilder & $qb) {
 		$expr = $qb->expr();
 
 		/** @noinspection PhpMethodParametersCountMismatchInspection */

lib/Db/MembersRequest.php

Doc Comments +4 added lines, -1 removed lines

@@ -192,7 +192,7 @@ 
 	 * returns the index of a specific UserID in a Members List
 	 *
 	 * @param array $members
-	 * @param $userId
+	 * @param string $userId
 	 *
 	 * @return int
 	 */
@@ -415,6 +415,9 @@ 
 	}
 
 
+	/**
+	 * @param string $groupId
+	 */
 	public function unlinkAllFromGroup($groupId) {
 		$qb = $this->getGroupsDeleteSql($groupId);
 		$qb->execute();

lib/ShareByCircleProvider.php

Spacing +2 added lines, -2 removed lines

@@ -569,7 +569,7 @@ 
 	 * @param IShare $share
 	 * @param $data
 	 */
-	private function assignShareObjectPropertiesFromParent(IShare &$share, $data) {
+	private function assignShareObjectPropertiesFromParent(IShare & $share, $data) {
 		if (isset($data['f_permissions'])) {
 			$entryData = $data;
 			$entryData['permissions'] = $entryData['f_permissions'];
@@ -588,7 +588,7 @@ 
 	 * @param IShare $share
 	 * @param $data
 	 */
-	private function assignShareObjectSharesProperties(IShare &$share, $data) {
+	private function assignShareObjectSharesProperties(IShare & $share, $data) {
 		$shareTime = new \DateTime();
 		$shareTime->setTimestamp((int)$data['stime']);
 

Doc Comments +2 added lines, -2 removed lines

@@ -438,8 +438,8 @@
 
 	/**
 	 * @param string $userId
-	 * @param $shareType
-	 * @param Node $node
+	 * @param integer $shareType
+	 * @param Node|null $node
 	 * @param int $limit
 	 * @param int $offset
 	 *

lib/Controller/FederatedController.php

Spacing +1 added lines, -1 removed lines

@@ -225,7 +225,7 @@
 	 * @return DataResponse
 	 */
 	private function federatedFail($reason) {
-		$this->miscService->log(2, 'federated fail: ' . $reason);
+		$this->miscService->log(2, 'federated fail: '.$reason);
 
 		return new DataResponse(
 			[