Completed
Pull Request — master (#603)
by John
02:40
created
lib/Service/EventsService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -282,7 +282,7 @@
 block discarded – undo
282 282
 	 * generateEvent()
283 283
 	 * Create an Activity Event with the basic settings for the app.
284 284
 	 *
285
-	 * @param $type
285
+	 * @param string $type
286 286
 	 *
287 287
 	 * @return \OCP\Activity\IEvent
288 288
 	 */
Please login to merge, or discard this patch.
lib/Service/MiscService.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -284,7 +284,7 @@
 block discarded – undo
284 284
 		ob_start();
285 285
 		echo(json_encode($result));
286 286
 		$size = ob_get_length();
287
-		header('Content-Length: ' . $size);
287
+		header('Content-Length: '.$size);
288 288
 		ob_end_flush();
289 289
 		flush();
290 290
 	}
Please login to merge, or discard this patch.
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -66,6 +66,9 @@  discard block
 block discarded – undo
66 66
 		$this->userManager = $userManager;
67 67
 	}
68 68
 
69
+	/**
70
+	 * @param string $message
71
+	 */
69 72
 	public function log($message, $level = 4) {
70 73
 		$data = array(
71 74
 			'app'   => $this->appName,
@@ -86,7 +89,7 @@  discard block
 block discarded – undo
86 89
 
87 90
 	/**
88 91
 	 * @param $arr
89
-	 * @param $k
92
+	 * @param string $k
90 93
 	 *
91 94
 	 * @param string $default
92 95
 	 *
@@ -257,7 +260,7 @@  discard block
 block discarded – undo
257 260
 
258 261
 
259 262
 	/**
260
-	 * @param $ident
263
+	 * @param string $ident
261 264
 	 *
262 265
 	 * @return mixed|string
263 266
 	 * @deprecated
Please login to merge, or discard this patch.
lib/Service/MembersService.php 3 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -323,7 +323,7 @@
 block discarded – undo
323 323
 			return;
324 324
 		}
325 325
 
326
-		$tmpContact = $this->userId . ':' . $ident;
326
+		$tmpContact = $this->userId.':'.$ident;
327 327
 		$result = MiscService::getContactData($tmpContact);
328 328
 		if (empty($result)) {
329 329
 			throw new NoUserException($this->l10n->t("This contact is not available"));
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 namespace OCA\Circles\Service;
28 28
 
29 29
 
30
-use daita\MySmallPhpTools\Exceptions\RequestNetworkException;
31 30
 use daita\MySmallPhpTools\Exceptions\RequestResultNotJsonException;
32 31
 use daita\MySmallPhpTools\Model\Nextcloud\nc22\NC22Request;
33 32
 use daita\MySmallPhpTools\Model\Request;
Please login to merge, or discard this patch.
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -353,8 +353,8 @@  discard block
 block discarded – undo
353 353
 	/**
354 354
 	 * Verify if a local account is valid.
355 355
 	 *
356
-	 * @param $ident
357
-	 * @param $type
356
+	 * @param string $ident
357
+	 * @param integer $type
358 358
 	 *
359 359
 	 * @param string $instance
360 360
 	 *
@@ -399,8 +399,8 @@  discard block
 block discarded – undo
399 399
 	/**
400 400
 	 * Verify if a contact exist in current user address books.
401 401
 	 *
402
-	 * @param $ident
403
-	 * @param $type
402
+	 * @param string $ident
403
+	 * @param integer $type
404 404
 	 *
405 405
 	 * @throws NoUserException
406 406
 	 * @throws EmailAccountInvalidFormatException
@@ -543,7 +543,7 @@  discard block
 block discarded – undo
543 543
 	 * @param int $level
544 544
 	 * @param bool $force
545 545
 	 *
546
-	 * @return array
546
+	 * @return DeprecatedMember[]
547 547
 	 * @throws CircleDoesNotExistException
548 548
 	 * @throws CircleTypeNotValidException
549 549
 	 * @throws ConfigNoCircleAvailableException
Please login to merge, or discard this patch.
lib/Model/DavCard.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -146,7 +146,7 @@
 block discarded – undo
146 146
 	 * @return string
147 147
 	 */
148 148
 	public function getUniqueId(): string {
149
-		return $this->getAddressBookId() . '/' . $this->getCardUri();
149
+		return $this->getAddressBookId().'/'.$this->getCardUri();
150 150
 	}
151 151
 
152 152
 
Please login to merge, or discard this patch.
lib/Model/GlobalScale/GSEvent.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@
 block discarded – undo
94 94
 	}
95 95
 
96 96
 	/**
97
-	 * @param mixed $type
97
+	 * @param string $type
98 98
 	 *
99 99
 	 * @return GSEvent
100 100
 	 */
Please login to merge, or discard this patch.
lib/GlobalScale/GSMount/MountManager.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -109,7 +109,7 @@
 block discarded – undo
109 109
 	 * @return string
110 110
 	 */
111 111
 	protected function stripPath($path) {
112
-		$prefix = '/' . $this->userId . '/files';
112
+		$prefix = '/'.$this->userId.'/files';
113 113
 
114 114
 		return rtrim(substr($path, strlen($prefix)), '/');
115 115
 	}
Please login to merge, or discard this patch.
lib/Model/GlobalScale/GSShare.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
 			return $mountPoint;
155 155
 		}
156 156
 
157
-		return '/' . $userId . '/files/' . ltrim($mountPoint, '/');
157
+		return '/'.$userId.'/files/'.ltrim($mountPoint, '/');
158 158
 	}
159 159
 
160 160
 	/**
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
 	public function toMount(string $userId, string $protocol = 'https'): array {
294 294
 		return [
295 295
 			'owner'       => $this->getOwner(),
296
-			'remote'      => $protocol . '://' . $this->getInstance(),
296
+			'remote'      => $protocol.'://'.$this->getInstance(),
297 297
 			'token'       => $this->getToken(),
298 298
 			'share_token' => $this->getToken(),
299 299
 			'password'    => $this->getPassword(),
Please login to merge, or discard this patch.
lib/Db/GSSharesRequest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -121,11 +121,11 @@
 block discarded – undo
121 121
 
122 122
 	private function leftJoinMountPoint(IQueryBuilder $qb, string $userId) {
123 123
 		$expr = $qb->expr();
124
-		$pf = '' . $this->default_select_alias . '.';
124
+		$pf = ''.$this->default_select_alias.'.';
125 125
 
126 126
 		$on = $expr->andX();
127 127
 		$on->add($expr->eq('mp.user_id', $qb->createNamedParameter($userId)));
128
-		$on->add($expr->eq('mp.share_id', $pf . 'id'));
128
+		$on->add($expr->eq('mp.share_id', $pf.'id'));
129 129
 
130 130
 		/** @noinspection PhpMethodParametersCountMismatchInspection */
131 131
 		$qb->selectAlias('mp.mountPoint', 'gsshares_mountpoint')
Please login to merge, or discard this patch.
lib/GlobalScale/GSMount/MountProvider.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -148,13 +148,13 @@
 block discarded – undo
148 148
 		}
149 149
 
150 150
 		$info = pathinfo($share->getMountPoint());
151
-		$filename = $this->get('dirname', $info) . '/' . $this->get('filename', $info);
151
+		$filename = $this->get('dirname', $info).'/'.$this->get('filename', $info);
152 152
 		$extension = $this->get('extension', $info);
153
-		$extension = ($extension === '') ? '' : '.' . $extension;
153
+		$extension = ($extension === '') ? '' : '.'.$extension;
154 154
 
155 155
 		$n = 2;
156 156
 		while (true) {
157
-			$path = $filename . " ($n)" . $extension;
157
+			$path = $filename." ($n)".$extension;
158 158
 			try {
159 159
 				$fs->get($path);
160 160
 			} catch (NotFoundException $e) {
Please login to merge, or discard this patch.